Re: Publishing the AAR after the next release of Cordova

On Fri, Apr 8, 2016 at 9:29 PM, Nikhil Khandelwal wrote: > This seems useful. > > I'm guessing publishing the AAR requires us to establish a release process > for it? Are you planning to document the guidelines for releasing, signing, > building & versioning of this? Do

RE: Publishing the AAR after the next release of Cordova

This seems useful. I'm guessing publishing the AAR requires us to establish a release process for it? Are you planning to document the guidelines for releasing, signing, building & versioning of this? Do you propose - every time cordova-android is released we well release AAR as well? Or this

[GitHub] cordova-plugin-contacts pull request: CB-11043: Android App crashe...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/121#issuecomment-207667561 @sarangan12 LGTM, but can you add a test? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-contacts pull request: CB-11043: Android App crashe...

GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/121 CB-11043: Android App crashes while trying to save contact with phone numbers array with deleted values If you use delete operator to remove the phone numbers in a phone number

[GitHub] cordova-plugin-camera pull request: CB-11034: Camera.getPicture -H...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/201#issuecomment-207661306 There are definitely cases where native exceptions should be surfaced to the javascript, but memory issues are the responsibility of the native

[GitHub] cordova-plugin-camera pull request: CB-11034: Camera.getPicture -H...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/201#issuecomment-207659474 Ah, I think I misunderstood your JIRA and I agree with @nikhilkh that optimizing our memory use is the right approach. Looking through the code, it

[GitHub] cordova-plugin-camera pull request: CB-11034: Camera.getPicture -H...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/201#issuecomment-207648380 Silently handling OutOfMemoryError is not a good idea - we should look to optimize the code so that it uses less memory instead. --- If your project

[GitHub] cordova-paramedic pull request: Paramedic improvements

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r59101538 --- Diff: lib/paramedic.js --- @@ -0,0 +1,231 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-paramedic pull request: Paramedic improvements

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r59101124 --- Diff: lib/LocalServer.js --- @@ -0,0 +1,162 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-lib pull request: CB-10770 Remove cache-min when adding pl...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/422#issuecomment-207640986 Yes, I'm aware he is removing npm cache completely. This fix is still valuable in the interim till Steve completes the fetch work. --- If your project is set up

[GitHub] cordova-docs pull request: CB-10968 Update iOS 'Requirements & Sup...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/574 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-camera pull request: Added Sample section to the Ca...

GitHub user Mikejo5000 opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/203 Added Sample section to the Camera plugin README You can merge this pull request into a Git repository by running: $ git pull

RE: Publishing the AAR after the next release of Cordova

+1 This will make it much easier to develop and unit-test plugins as a self-contained lib project. -Original Message- From: julio cesar sanchez [mailto:jcesarmob...@gmail.com] Sent: Friday, April 8, 2016 12:43 PM To: dev@cordova.apache.org Subject: Re: Publishing the AAR after the next

[GitHub] cordova-windows pull request: CB-10964 Handle build.json file star...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/166 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android pull request: CB-10964 Handle build.json file star...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/286 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-ios pull request: CB-10964 Handle build.json file starting...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/215 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [Android] Library Project/AAR alternatives to current plugin situation

On Fri, Apr 8, 2016 at 3:07 PM, Jason Ginchereau wrote: > Distributing Android platforms and plugins as AAR binaries seems to go > against open-source conventions and the existing Cordova model, where > everything is distributed as source. It also breaks the

RE: [Android] Library Project/AAR alternatives to current plugin situation

Distributing Android platforms and plugins as AAR binaries seems to go against open-source conventions and the existing Cordova model, where everything is distributed as source. It also breaks the platform-centric workflow that otherwise allows easily making changes to the platform and plugin

[GitHub] cordova-plugin-contacts pull request: CB-11048 Fix spec27's inadve...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/120 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-paramedic pull request: Paramedic improvements

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r59094438 --- Diff: lib/LocalServer.js --- @@ -0,0 +1,162 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-paramedic pull request: Paramedic improvements

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r59094353 --- Diff: lib/LocalServer.js --- @@ -0,0 +1,162 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-docs pull request: CB-10968 Update iOS 'Requirements & Sup...

Github user omefire commented on the pull request: https://github.com/apache/cordova-docs/pull/574#issuecomment-207621789 hmm, missed that earlier. Added them: https://en.wikipedia.org/wiki/IOS_9#Supported_devices --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-docs pull request: CB-10968 Update iOS 'Requirements & Sup...

Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-docs/pull/574#issuecomment-207615024 Sorry, the list I provided was for devices that supported iOS 8. I think we should add the devices that went out with iOS 9 (iPhone 6S, iPhone 6S Plus,

[GitHub] cordova-paramedic pull request: Paramedic improvements

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r59092104 --- Diff: paramedic-plugin/paramedic.js --- @@ -0,0 +1,93 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] cordova-paramedic pull request: Paramedic improvements

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r59091985 --- Diff: lib/paramedic.js --- @@ -0,0 +1,232 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-android pull request: [CB-10689] fix issue with app_name c...

Github user akofman commented on the pull request: https://github.com/apache/cordova-android/pull/272#issuecomment-207612423 Ok perfect ! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-android pull request: [CB-10689] fix issue with app_name c...

Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/272#issuecomment-207611395 @akofman After doing some triage, we should probably tweak this for an earlier CB that deals with the same thing. --- If your project is set up for it, you

[GitHub] cordova-plugin-contacts pull request: CB-11048 Fix spec27's inadve...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/120#issuecomment-207601712 https://issues.apache.org/jira/browse/CB-11051 is a duplicate of another issue I referenced in the JIRA - please update your cordova-lib repo to see

[GitHub] cordova-plugin-contacts pull request: CB-11048 Fix spec27's inadve...

Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/120#issuecomment-207593547 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-contacts pull request: CB-11048 Fix spec27's inadve...

Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/120#issuecomment-207580945 @sarangan12 could you please review ? I haven't been able to run this locally due to some error I'm facing with Mobilespec setup:

Re: this is my bug

This is the cordova development list, used to talk about the cordova project, not to ask questions or post problems while using it. You should ask on stack overflow, the phonegap google group or the cordova slack. If you think that you have found a bug then report it on http://issues.cordova.io

Re: Publishing the AAR after the next release of Cordova

+1 to adding it El viernes, 8 de abril de 2016, Joe Bowser escribió: > BTW: I contacted asfinfra to be added to the ASF org on BinTray, so we'll > see how that goes. > > On Fri, Apr 8, 2016 at 11:31 AM, Joe Bowser > wrote: > > > Hey > > > >

Re: [DISCUSS] Plugins release

I can wait, and maybe fix some issues this weekend. El viernes, 8 de abril de 2016, Simon MacDonald escribió: > I'm currently waiting for a third party to verify an enhancement to media. > Anyone have a burning desire to release plugins now or can we wait a bit >

[GitHub] cordova-plugin-contacts pull request: CB-11048 Fix spec27's inadve...

GitHub user omefire opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/120 CB-11048 Fix spec27's inadvertant breakage that happened during loggi… …ng rollback You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-docs pull request: CB-11020, CB-11040 Documenting event fi...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/573 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-windows pull request: CB-11024: Add preference to set the ...

Github user rakatyal closed the pull request at: https://github.com/apache/cordova-windows/pull/165 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows pull request: CB-11024: Add preference to set the ...

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-windows/pull/165#issuecomment-207563072 Merged [here](https://github.com/apache/cordova-windows/commit/07f6158bc24eda28c2946f54b1e3626c7e124c92) --- If your project is set up for it, you can reply

Re: [DISCUSS] Plugins release

I'm currently waiting for a third party to verify an enhancement to media. Anyone have a burning desire to release plugins now or can we wait a bit longer? Simon Mac Donald http://hi.im/simonmacdonald On Wed, Apr 6, 2016 at 12:23 PM, Simon MacDonald wrote: > Yeah,

[GitHub] cordova-docs pull request: CB-10968 Update iOS 'Requirements & Sup...

GitHub user omefire opened a pull request: https://github.com/apache/cordova-docs/pull/574 CB-10968 Update iOS 'Requirements & Supports' section You can merge this pull request into a Git repository by running: $ git pull https://github.com/omefire/cordova-docs CB-10968

[GitHub] cordova-paramedic pull request: Paramedic improvements

Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r59072232 --- Diff: lib/LocalServer.js --- @@ -0,0 +1,141 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

Re: Publishing the AAR after the next release of Cordova

BTW: I contacted asfinfra to be added to the ASF org on BinTray, so we'll see how that goes. On Fri, Apr 8, 2016 at 11:31 AM, Joe Bowser wrote: > Hey > > So, here's something that I want to put on the dev list before we do it, > which is that for the next release of Apache

Publishing the AAR after the next release of Cordova

Hey So, here's something that I want to put on the dev list before we do it, which is that for the next release of Apache Cordova, we publish an AAR on JCenter/BinTray and/or MavenCentral/Sonatype with the new release. Basically, this is a convenience package and we could technically do it now,

[GitHub] cordova-plugin-contacts pull request: CB-11041: cordova-plugin-con...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/119 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

RE: cordova-plugin-remote-inject release

There are some docs here: 1. http://cordova.apache.org/docs/en/latest/guide/hybrid/plugins/index.html#publishing-plugins 2. http://cordova.apache.org/docs/en/latest/guide/hybrid/plugins/index.html#integrating-with-plugin-search -Nikhil -Original Message- From: Brad Reynolds

[GitHub] cordova-lib pull request: CB-11022 Improve performance of `cordova...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/423#issuecomment-207527874 This code is pretty hard to follow. I don't mean your changes, but plugin installation overall is more complex than I expected. How do these changes

[GitHub] cordova-lib pull request: CB-10770 Remove cache-min when adding pl...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/422#issuecomment-207526774 I think Steve is addressing this in his changes to fetch. Cc: @stevengill --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-media pull request: CB-10723: iOS audio should use ...

Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-207525949 @tommy1688 could you please file a JIRA ticket to track the recording issue you're facing ? also, make sure to reference the PR which you said fixes

[GitHub] cordova-ios pull request: CB-10957 Remove build-*.xcconfig files f...

Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/214#issuecomment-207525756 Once you do the changes, you should run "npm test" (as you can see your patch has already failed the create tests in Travis) --- If your project is set up for it,

[GitHub] cordova-ios pull request: CB-10957 Remove build-*.xcconfig files f...

Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/214#issuecomment-207525427 See staging patches -> https://git-scm.com/book/en/v2/Git-Tools-Interactive-Staging or use a gui tool like SourceTree to only stage those hunks you need --- If

[GitHub] cordova-ios pull request: CB-10957 Remove build-*.xcconfig files f...

Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/214#issuecomment-207524864 The changes are not good - Xcode has a habit of removing those double quotes, which we need. I mentioned in my last comment " (and only stage those changes, it

[GitHub] cordova-ios pull request: CB-10957 Remove build-*.xcconfig files f...

Github user omefire commented on the pull request: https://github.com/apache/cordova-ios/pull/214#issuecomment-207523910 @shazron could you please take another look ? This time, I did it via Xcode. I noticed minor diffs between before & after and I think it's due to my version of

[GitHub] cordova-ios pull request: CB-10957 Remove build-*.xcconfig files f...

Github user omefire commented on the pull request: https://github.com/apache/cordova-ios/pull/214#issuecomment-207521639 Yes, that's what I just realized. I just loaded it in xcode and deleted those from the 'Build Phases' tab -> 'Copy Bundle Resources'. Much easier. --- If

[GitHub] cordova-ios pull request: CB-10957 Remove build-*.xcconfig files f...

Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/214#issuecomment-207520136 Not sure what you mean to do, but I would just load the .xcodeproj file in Xcode and delete those references I mentioned in Copy Bundle Resources? (and only stage

Re: [ANNOUNCE] cordova-ios 4.1.1 released

Thanks Edna! On Thu, Apr 7, 2016 at 9:06 PM, Edna Y Morales wrote: > > > cordova-ios@4.1.1 is on NPM now: https://www.npmjs.com/package/cordova-ios > Check out blog post at > https://cordova.apache.org/announcements/2016/04/04/ios-4.1.1.html and > retweet

[GitHub] cordova-plugin-camera pull request: [CB-10388] - Added correctOrie...

Github user morioma commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/158#issuecomment-207511327 I prefer this one to https://github.com/apache/cordova-plugin-camera/pull/197, because that one has code duplication for calculating rotation. I am

[GitHub] cordova-windows pull request: CB-11024: Add preference to set the ...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/165#discussion_r59051696 --- Diff: template/cordova/lib/ConfigParser.js --- @@ -73,6 +73,15 @@ WindowsConfigParser.prototype.getWindowsTargetVersion = function() {

[GitHub] cordova-lib pull request: CB-10770 Remove cache-min when adding pl...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/422#discussion_r59051171 --- Diff: cordova-lib/src/cordova/lazy_load.js --- @@ -147,10 +147,7 @@ function cordova_npm(platform) { // Returns a promise that resolves to

[GitHub] cordova-windows pull request: CB-10964 Handle build.json file star...

Github user omefire commented on the pull request: https://github.com/apache/cordova-windows/pull/166#issuecomment-207477821 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-ios pull request: CB-10964 Handle build.json file starting...

Github user omefire commented on the pull request: https://github.com/apache/cordova-ios/pull/215#issuecomment-207477475 Cool, LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/420#discussion_r59039160 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -157,6 +157,7 @@ module.exports = function plugin(command, targets, opts) {

[GitHub] cordova-ios pull request: CB-10964 Handle build.json file starting...

Github user daserge commented on the pull request: https://github.com/apache/cordova-ios/pull/215#issuecomment-207467840 Yes: https://github.com/apache/cordova-android/pull/286, https://github.com/apache/cordova-windows/pull/166 --- If your project is set up for it, you can reply to

[GitHub] cordova-ios pull request: CB-10964 Handle build.json file starting...

Github user omefire commented on the pull request: https://github.com/apache/cordova-ios/pull/215#issuecomment-207467649 Do we have corresponding PRs for other platforms ? (i.e: Android & Windows) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/420#discussion_r59037903 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -157,6 +157,7 @@ module.exports = function plugin(command, targets, opts) {

[GitHub] cordova-ios pull request: CB-10964 Handle build.json file starting...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-ios/pull/215 CB-10964 Handle build.json file starting with a BOM [Jira issue](https://issues.apache.org/jira/browse/CB-10964) You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/420#discussion_r59029064 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -157,6 +157,7 @@ module.exports = function plugin(command, targets, opts) {

Re: [ANNOUNCE] cordova-ios 4.1.1 released

Yay ! +1 Edna great job getting this thru On Fri, Apr 8, 2016 at 12:07 AM Edna Y Morales wrote: > > > cordova-ios@4.1.1 is on NPM now: https://www.npmjs.com/package/cordova-ios > Check out blog post at > https://cordova.apache.org/announcements/2016/04/04/ios-4.1.1.html and

[GitHub] cordova-plugin-file-transfer pull request: Insert Content-Type to ...

GitHub user claudiobadii opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/139 Insert Content-Type to each part of the multipart request You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/420#discussion_r59018183 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -157,6 +157,7 @@ module.exports = function plugin(command, targets, opts) {

[GitHub] cordova-lib pull request: CB-11022 Improve performance of `cordova...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/423#issuecomment-207411302 @jasongin, @nikhilkh, please take a look when you have a chance --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-android pull request: CB-11022 Duplicate www files to both...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-android/pull/289 CB-11022 Duplicate www files to both destinations on plugin add/rm This is a supplementary PR for https://github.com/apache/cordova-lib/pull/423 which removes requirement for

[GitHub] cordova-lib pull request: CB-11022 Improve performance of `cordova...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/423 CB-11022 Improve performance of `cordova plugin add` command This addresses [CB-11022](https://issues.apache.org/jira/browse/CB-11022) and dramaticaly reduces time required for plugin

[GitHub] cordova-lib pull request: CB-10770 Remove cache-min when adding pl...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/422#discussion_r59007596 --- Diff: cordova-lib/src/cordova/lazy_load.js --- @@ -147,10 +147,7 @@ function cordova_npm(platform) { // Returns a promise that resolves to

[GitHub] cordova-paramedic pull request: Paramedic improvements

Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r59005735 --- Diff: lib/LocalServer.js --- @@ -0,0 +1,141 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-paramedic pull request: Paramedic improvements

Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r59003845 --- Diff: lib/LocalServer.js --- @@ -0,0 +1,141 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-paramedic pull request: Paramedic improvements

Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r59003645 --- Diff: lib/LocalServer.js --- @@ -0,0 +1,141 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/420#issuecomment-207354240 LGTM! except for a minor comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/420#discussion_r59003112 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -157,6 +157,7 @@ module.exports = function plugin(command, targets, opts) {

[GitHub] cordova-paramedic pull request: Paramedic improvements

Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r59002757 --- Diff: paramedic-plugin/paramedic.js --- @@ -0,0 +1,93 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] cordova-paramedic pull request: Paramedic improvements

Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r59002202 --- Diff: paramedic-plugin/paramedic.js --- @@ -0,0 +1,93 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] cordova-ios pull request: CB-10957 Remove build-*.xcconfig files f...

Github user omefire commented on the pull request: https://github.com/apache/cordova-ios/pull/214#issuecomment-207350922 can't find a good reference for the .pbxproj file, do you have any link ? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-paramedic pull request: Paramedic improvements

Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r59001110 --- Diff: lib/utils/execWrapper.js --- @@ -0,0 +1,39 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or

[GitHub] cordova-paramedic pull request: Paramedic improvements

Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r59001026 --- Diff: lib/paramedic.js --- @@ -0,0 +1,232 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-plugin-camera pull request: Appium tests stability improve...

Github user alsorokin commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/202#issuecomment-207332653 @riknoll addressed both of your comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-media pull request: Fix for CB-10822 : Plugin Media...

Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/87#issuecomment-207303423 @sonicwong it's not related to this as this PR is related to getPosition for recordings. There was however, recently a PR merged that fixed

[GitHub] cordova-plugin-media pull request: Fix for CB-10822 : Plugin Media...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/87#issuecomment-207302758 @ThillaiganeshChan, please update this PR's title to use the correct JIRA ticket number. The title for

[GitHub] cordova-plugin-media pull request: Fix for CB-10822 : Plugin Media...

Github user sonicwong commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/87#issuecomment-207281846 When I play a mp3 in 2.2.0 @ ios. No sound come out. I am not sure it related to this fix or not. --- If your project is set up for it, you can

[GitHub] cordova-plugin-file pull request: CB-10960 Uncaught # i...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/177#discussion_r58983833 --- Diff: www/FileWriter.js --- @@ -107,8 +108,29 @@ FileWriter.prototype.write = function(data) { var fileReader = new

[GitHub] cordova-plugin-file pull request: CB-10960 Uncaught # i...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/177#discussion_r58983822 --- Diff: www/FileWriter.js --- @@ -107,8 +108,29 @@ FileWriter.prototype.write = function(data) { var fileReader = new

[GitHub] cordova-plugin-file pull request: CB-10960 Uncaught # i...

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/177#issuecomment-207234305 Thank you for the review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project