NPM v3 packaging issues

Hey, guys We've just ran into issue, caused by NPM v3 flat directory structure. The issue is that NPM does not pack sub-dependencies of bundled dependencies into resultant archive. This only affects flatten dependency trees, but we already switched to that in platform repos. As an example, we

[GitHub] cordova-android pull request: CB-10600 'cordova run android --rele...

Github user daserge commented on the pull request: https://github.com/apache/cordova-android/pull/276#issuecomment-222618225 @pke, the fix is not released yet. You can use master version for now: `cordova platform add https://github.com/apache/cordova-android`. --- If your projec

[GitHub] cordova-android pull request: CB-10600 'cordova run android --rele...

Github user pke commented on the pull request: https://github.com/apache/cordova-android/pull/276#issuecomment-222626969 ah ok, thanks. For the future: Are fixed + released PR marked here with a special label? --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-android pull request: CB-10600 'cordova run android --rele...

Github user daserge commented on the pull request: https://github.com/apache/cordova-android/pull/276#issuecomment-222627964 The tags a commit is released under are below the commit description, for example: https://github.com/apache/cordova-android/commit/bc9e895e2537f212756

[Vote] Cordova-windows 4.4.0 release

Please review and vote on this 5.0.0 Android Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-11334 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-11334 The package

Re: Proposal: Change Android Project Directory Structure to Android Studio style

On Fri, May 27, 2016 at 12:22 PM, Nikhil Khandelwal wrote: > As I see it, a change to the directory structure will break almost every > Android plugin currently out there. > > I know. However, I don't think that's a good enough reason to not do this. > There are atleast 20K references [1] on g

[GitHub] cordova-android pull request: Cb 11343

GitHub user ankon opened a pull request: https://github.com/apache/cordova-android/pull/308 Cb 11343 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ankon/cordova-android CB-11343 Alternatively you can review and apply these cha

[GitHub] cordova-android pull request: CB-11343: Handle Java versions after JEP-223

Github user codecov-io commented on the pull request: https://github.com/apache/cordova-android/pull/308 ## [Current coverage][cc-pull] is **34.21%** > Merging [#308][cc-pull] into [master][cc-base-branch] will not change coverage ```diff @@ master #3

RE: Proposal: Change Android Project Directory Structure to Android Studio style

It sounds like you are working on a plan to remap the older directory structure to a new one. Will look forward to updates on the design and code for that. In that case our expectation is that most plugins will not break - is that correct? It will be great to do some compat testing with say the

RE: NPM v3 packaging issues

Could npm shrinkwrap be a solution? The cordova-coho docs mention shrinkwrap was avoided previously because it was "not mature", but it has apparently improved a lot in v3. According to a comment [1] in another related issue it has solved this problem in v3. I'm not totally familiar with the pla

[GitHub] cordova-android pull request: CB-11117: Use FileUpdater to optimize prepare ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/295 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

Re: Cordova Monthly Hangouts

Okay, my apologies, I totally dropped the ball on this. Since we are not having the hangout literally 1 hour ago, which was the best available time, please everyone have another look and let's see what we can salvage from this. If you haven't put your name in, please do so soon so we can agree on

RE: [DISCUSS] Cordova-Android 5.2.0 Release

Support for incremental prepare (PR #295) has been merged. We should be ready for a release. -Nikhil -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Thursday, May 26, 2016 2:52 PM To: dev Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release Do we have an N PR yet?

[GitHub] cordova-plugin-file-transfer pull request: Master

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/147 There are some test failures as `options` might be undefined: http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/15/label=mac-slave,platformName=andr

[GitHub] cordova-plugin-file-transfer pull request: Master

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/147 Please change the title of the pull request to something more meaningful. Rebase and squash all the commits and file a JIRA issue here talking about the feature and its

[GitHub] cordova-plugin-device-orientation pull request: add Android support for true...

Github user sinzianag commented on the pull request: https://github.com/apache/cordova-plugin-device-orientation/pull/19 Most calls to Location Manager require permissions that in android 5.0+ need to be handled at runtime (ACCESS_COARSE_LOCATION,ACCESS_FINE_LOCATION) and I don't see

Re: Proposal: Change Android Project Directory Structure to Android Studio style

I know it's only a detail, but https://github.com/phonegap-build/PushPlugin, the example used as a plugin that would "break", is a deprecated and old plugin. 2016-05-31 13:46 GMT-03:00 Nikhil Khandelwal : > It sounds like you are working on a plan to remap the older directory > structure to a new

Re: [DISCUSS] CLI Templates

Sorry to bring up a old thread instead of starting a new one but I thought the context might be relevant. Currently, template pretty much copies over all of the files. I see this as a problem. Example [1]. When you add a template, its package.json gets copied into your app. I don't think we want

[GitHub] cordova-plugin-file-transfer pull request: [Android] Handle redirects when d...

Github user Pazkov commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/126 Please merge... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: Cordova Monthly Hangouts

I have deleted all available dates in the past, because if time travel were ever going to be possible it would already have happened. I have also deleted the imposter Tommy, and let the good one stay. At this point, it is looking like Thursday June 2, at 12:00 PM SF Time. This gives us: Steve, Me

Re: [DISCUSS] CLI Templates

I opened a JIRA for ignoring .git Don't have it handy on mobile now Best practice: 1. To use subdir feature to specify dir to use via main module 2. To follow npm best practices when publishing to npm (i.e. do not include everything, only the minimum required) - Carlos Santana @csantanapr >

[GitHub] cordova-lib pull request: CB-11345 Added '/package.json' to path of template...

GitHub user carynbear opened a pull request: https://github.com/apache/cordova-lib/pull/446 CB-11345 Added '/package.json' to path of templatePkg You can merge this pull request into a Git repository by running: $ git pull https://github.com/carynbear/cordova-lib master Alter

Re: Cordova Monthly Hangouts

Quick update on my part — I might be able to make it at that time. A lot depends upon a couple things going on tomorrow, so I won’t know for sure just yet, but I’m going to cross my fingers and think a lot of happy thoughts. :-) From: Jesse Reply: dev@cordova.apache.org Date: May 31, 2016 a

Re: [DISCUSS] CLI Templates

.npmignore can help with some of those unwanted files, but not all… However, what happens in the circumstance when the template _does_ need a package.json file, such as the react-hot-loader template Jed and I made? It has npm dips and npm scripts that are vital to how it works in its package,jso

Re: [DISCUSS] CLI Templates

package.json should be ignore also is fetching template via npm If you want to include a package.json then use the subdir feature and include the package.json inside the subdir On Tue, May 31, 2016 at 7:18 PM Tommy Williams wrote: > .npmignore can help with some of those unwanted files, but not

Re: [DISCUSS] CLI Templates

`cordova create` is destructive by nature. Anything and everything required by the templated app should be part of what is copied. Our current blind folder copy needs to be more intelligent. I would prefer that template files be in a sub-dir, much like they are in each platform. Simon and I faced

Re: [DISCUSS] CLI Templates

Using a subdir makes a clear separation between final template files vs. files associated with tooling, tests, packaging - Carlos Santana @csantanapr > On May 31, 2016, at 7:37 PM, Jesse wrote: > > `cordova create` is destructive by nature. > Anything and everything required by the templated

Re: [DISCUSS] CLI Templates

I definitely see the usecase tommy describes. I think subdir makes the most sense. package.json has a `dirname` field which would fetch everything in that subdirectory. This functionality already exists for `--template`. TLDR We should be a bit more picky for top level files we copy over but blin

Re: [DISCUSS] CLI Templates

Yeah, a subduer is fine as long as we can merge the package.json from the template somehow… Dibs not writing that :/ > On 1 Jun 2016, at 10:47 AM, Steven Gill wrote: > > I definitely see the usecase tommy describes. > > I think subdir makes the most sense. package.json has a `dirname` field

Re: [DISCUSS] CLI Templates

By merge the package.json, do you mean update the package.name to the name of the app? On May 31, 2016 6:01 PM, "Tommy Williams" wrote: > Yeah, a subduer is fine as long as we can merge the package.json from the > template somehow… > > Dibs not writing that :/ > > > > On 1 Jun 2016, at 10:47 AM,

Re: [DISCUSS] CLI Templates

Yeah, I don’t really mean any more than what templates + create already do with config.xml. Use case: `cordova create mycoolapp —template=some-react-template` cd mycoolapp npm install npm start etc The `some-react-template` by necessity will have a package.json with stuff in it (deps, npm scr

Build failed in Jenkins: cordova-nightly #25

See -- [...truncated 448 lines...] ├── js-yaml@3.6.1 (esprima@2.7.2, argparse@1.0.7) └── handlebars@4.0.5 (source-map@0.4.4, optimist@0.6.1, uglify-js@2.6.2) /home/jenkins/.npm-global/lib/node_m