Re: [Cordova dev] Task :app:stripDebugDebugSymbols / No version of NDK matched [...]

2021-07-16 Thread @brodybits - Chris Brody
Thanks for the response. Yes I think none of the Apache Cordova maintained plugins would use C or C++ code with Android NDK, but there are some third-party plugins which do use at least C code with NDK and cordova-sqlite-storage from myself would be a major example. Setting ANDROID_NDK_HOME

[GitHub] cordova-app-hello-world pull request #19: CB-12397 fix .gitignore for plugin...

2017-05-10 Thread brodybits
GitHub user brodybits opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/19 CB-12397 fix .gitignore for plugins & platforms ### Platforms affected All ### What does this PR do? Add `plugins` and `platf

[GitHub] cordova-lib issue #528: CB-12572: (windows) pin cordova-windows 5.0.0

2017-03-21 Thread brodybits
Github user brodybits commented on the issue: https://github.com/apache/cordova-lib/pull/528 @stevengill when do you expect this to be released? I think we still have to update cordova-cli to reference a version of cordova-lib with this fix. I would be happy to contribute

[GitHub] cordova-lib issue #528: CB-12572: (windows) pin cordova-windows 5.0.0

2017-03-21 Thread brodybits
Github user brodybits commented on the issue: https://github.com/apache/cordova-lib/pull/528 Thanks @stevengill! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-lib pull request #528: CB-12572: (windows) pin cordova-windows 5.0.0

2017-03-15 Thread brodybits
GitHub user brodybits opened a pull request: https://github.com/apache/cordova-lib/pull/528 CB-12572: (windows) pin cordova-windows 5.0.0 ### Platforms affected Windows ### What does this PR do? [CB-12572](https://issues.apache.org/jira/browse/CB

[GitHub] cordova-cli issue #266: CB-12008 : made autosave the default for platform an...

2017-01-25 Thread brodybits
Github user brodybits commented on the issue: https://github.com/apache/cordova-cli/pull/266 I hope to see this integrated soon. I have seen way too many new users keeping old plugins in git instead of just adding them to config.xml. --- If your project is set up for it, you can

[GitHub] cordova-cli issue #255: CLI Refactor

2017-01-25 Thread brodybits
Github user brodybits commented on the issue: https://github.com/apache/cordova-cli/pull/255 Status? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-lib issue #498: CB-11985 Check if cached platform/plugin exists befo...

2016-10-10 Thread brodybits
Github user brodybits commented on the issue: https://github.com/apache/cordova-lib/pull/498 Thanks @TimBarham for the explanation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib issue #498: CB-11985 Check if cached platform/plugin exists befo...

2016-10-10 Thread brodybits
Github user brodybits commented on the issue: https://github.com/apache/cordova-lib/pull/498 I would personally favor this change to be "opt-in". I like the idea that npm checks for a newer release before using the cached version of a package. --- If your project

[GitHub] cordova-docs pull request: Update SQLite plugin details

2016-05-12 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-docs/pull/600#issuecomment-218708663 The updates look good to me, thanks! FYI I dropped the Cordova engine constraint on Cordova-sqlite-storage. --- If your project is set up for it, you

[GitHub] cordova-docs pull request: Update SQLite plugin details

2016-05-11 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-docs/pull/600#issuecomment-218391884 I don't think "relies on native SQLite implementation" is so relevant anymore. The cordova-sqlite-storage version now includes its own sqlite3 impl

[GitHub] cordova-android pull request: CB-10673 fixed conflicting plugin in...

2016-03-01 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-android/pull/264#issuecomment-190951704 I would favor leaving it to the plugins to use the `lib-file` instead of `source-file` to install the libraries. A couple of things that could really help

[GitHub] cordova-windows pull request: CB-8866: add Windows platforms Mixe...

2015-07-22 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-windows/pull/67#issuecomment-123846880 Have you been unblocked by using the --archs parameter? Yes. I think this should be documented very clearly (I will document this in my own plugin

[GitHub] cordova-windows pull request: CB-8866: add Windows platforms Mixe...

2015-07-22 Thread brodybits
Github user brodybits closed the pull request at: https://github.com/apache/cordova-windows/pull/67 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-file pull request: CB-8968 fix readAsArrayBuffer by...

2015-06-15 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/115#issuecomment-112238832 I believe this is still required, will test. Sorry I missed the question before. I don't think this should be needed as already commented

[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll

2015-05-12 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-101394601 If we can avoid the breaking change it would be better and in this case we have a solution that works well to avoid it (apache/cordova-plugin-file-transfer#72

[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll

2015-05-07 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-99960110 Issued PR to fix CB-8968 (automatic build failed, don't think it is my fault) --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-file pull request: CB-8968 fix readAsArrayBuffer by...

2015-05-07 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/115#issuecomment-99957767 NOTE: my ICLA was already submitted and accepted for cordova-wp8. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll

2015-05-07 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-99847116 @brodybits follow these steps: as documented in https://github.com/apache/cordova-plugin-test-framework. Could add a reference to README.md in the plugin

[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll

2015-05-07 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-99931329 The Newtonsoft JSON library does seem much easier to use and perhaps more efficient as well, but unlike the .NET JSON `DataContractJsonSerializer`, Newtonsoft does

[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll

2015-05-07 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-99942506 Array.ConvertAll did not compile on Visual Studio Express 2013, and is apparently not supported for Metro or Silverlight. Figured out how to do this using Linq

[GitHub] cordova-plugin-file pull request: CB-8968 fix readAsArrayBuffer by...

2015-05-07 Thread brodybits
GitHub user brodybits opened a pull request: https://github.com/apache/cordova-plugin-file/pull/115 CB-8968 fix readAsArrayBuffer by converting byte array to integer array using LINQ Needed to fix CB-8968 since Newtonsoft JSON does not support JSON serialization of arbitrary types

[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll

2015-05-06 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-99354856 So the apache/cordova-plugin-file-transfer#72 probably should be closed then... My point that apache/cordova-plugin-file-transfer#54 was an improvement

[GitHub] cordova-plugin-file-transfer pull request: CB-8951 Fixed crash rel...

2015-05-06 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/82#issuecomment-99399217 Isn't this one enough? https://issues.apache.org/jira/browse/CB-8721 Yes it looks like you fix the problem (and am very happy to see

[GitHub] cordova-plugin-file-transfer pull request: CB-8721 Fixes incorrect...

2015-05-06 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/72#issuecomment-99359895 Can we consider #54 again, now that apache/cordova-wp8#79 has been integrated? --- If your project is set up for it, you can reply to this email

[GitHub] cordova-plugin-file-transfer pull request: Better header parse wit...

2015-05-06 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/54#issuecomment-99360986 This one is now possible since apache/cordova-wp8#62 has been integrated (I already tested building with apache/cordova-wp8#62 OK). Can we

[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll

2015-05-06 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-99371506 Yeah @brodybits, will have another look at apache/cordova-plugin-file-transfer#54 :+1: thanks! --- If your project is set up for it, you can reply

[GitHub] cordova-plugin-file-transfer pull request: CB-8951 Fixed crash rel...

2015-05-06 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/82#issuecomment-99432098 we already have JIRA issue created which will be resolved by your PR #54 Yes, understood (PR #54 was raised by @mowcixo). I just added

[GitHub] cordova-plugin-file-transfer pull request: Better header parse wit...

2015-05-06 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/54#issuecomment-99430542 Great! Reopened! Also I suggest we should mark this as a solution to CB-8721, both in the title of this PR and in JIRA CB-8721 (see

[GitHub] cordova-plugin-file-transfer pull request: Better header parse wit...

2015-05-06 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/54#issuecomment-99422459 Great! Reopened! ... apache/cordova-wp8#79 ... Yes I meant apache/cordova-wp8#79 - my bad! --- If your project

[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll

2015-05-06 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-99611924 It looks like these changes brought new test failures on wp8: https://issues.apache.org/jira/browse/CB-8968 Can someone describe how I would run

[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll

2015-05-06 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-99544620 It looks like these changes brought new test failures on wp8: https://issues.apache.org/jira/browse/CB-8968 @alsorokin I will take a look as well

[GitHub] cordova-plugin-file-transfer pull request: Better header parse wit...

2015-05-05 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/54#issuecomment-99142847 Once apache/cordova-wp8#79 is included (and released) then we can include this one. --- If your project is set up for it, you can reply

[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll

2015-05-05 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-99134840 apache/cordova-plugin-file-transfer#82 apache/cordova-plugin-file-transfer#82 is a quick fix that could have been included already. Looking through

[GitHub] cordova-windows pull request: CB-8866: add Windows platforms Mixe...

2015-04-28 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-windows/pull/67#issuecomment-97033277 I believe cordova windows provides an --archs option to specify the architectures to build. Is that not sufficient for your purposes? Here's

[GitHub] cordova-windows pull request: CB-8866: add Windows platforms Mixe...

2015-04-27 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-windows/pull/67#issuecomment-96677896 When can this fix be considered? People are having problems using the sqlite plugin with the Visual Studio Cordova project template (ref: litehelpers/Cordova

[GitHub] cordova-windows pull request: CB-8866: add Windows platforms Mixe...

2015-04-27 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-windows/pull/67#issuecomment-96760704 I just pushed a new change to add Mixed Platforms *only*, based off the latest commit in the `master` branch. For reference purpose only, my first proposed fix

[GitHub] cordova-windows pull request: Alt for discussion: CB-8866: add Mi...

2015-04-21 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-windows/pull/69#issuecomment-94813170 Withdrawn for reasons described in #68. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-windows pull request: For discussion: CB-8869 remove Windo...

2015-04-21 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-windows/pull/68#issuecomment-94813044 Withdrawn. It is possible to configure an app to target Windows 8.1 in config.xml. To completely remove Windows 8.0 would entail removing CordovaApp.Windows80

[GitHub] cordova-windows pull request: For discussion: CB-8869 remove Windo...

2015-04-21 Thread brodybits
Github user brodybits closed the pull request at: https://github.com/apache/cordova-windows/pull/68 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-windows pull request: Alt for discussion: CB-8866: add Mi...

2015-04-21 Thread brodybits
Github user brodybits closed the pull request at: https://github.com/apache/cordova-windows/pull/69 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-windows pull request: Alt for discussion: CB-8866: add Mi...

2015-04-16 Thread brodybits
GitHub user brodybits opened a pull request: https://github.com/apache/cordova-windows/pull/69 Alt for discussion: CB-8866: add Mixed Platforms and Win32 and CB-8869: Windows Universal without Windows 8.0 This PR is an alternative to PR #67 and PR #68 for discussion and mutually

[GitHub] cordova-windows pull request: For discussion: CB-8869 remove Windo...

2015-04-16 Thread brodybits
GitHub user brodybits opened a pull request: https://github.com/apache/cordova-windows/pull/68 For discussion: CB-8869 remove Windows 8.0 from Windows Universal version As I described [CB-8869](https://issues.apache.org/jira/browse/CB-8869), the Windows 8.0 target does not work

[GitHub] cordova-windows pull request: CB-8866: add Windows platforms Mixe...

2015-04-16 Thread brodybits
GitHub user brodybits opened a pull request: https://github.com/apache/cordova-windows/pull/67 CB-8866: add Windows platforms Mixed Platforms and Win32 See [CB-8866](https://issues.apache.org/jira/browse/CB-8866): This is needed to install a plugin with a C++ component library

[GitHub] cordova-wp8 pull request: JsonHelper testing, and use of Newtonsof...

2015-03-23 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-wp8/pull/62#issuecomment-85245731 Given a version of `cordova-wp8` checked out (or extracted from a release zip) in the `cordova-wp8` subdirectory, I tried creating my test project using

[GitHub] cordova-wp8 pull request: Use WP8 thread pool for each command, in...

2015-03-14 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-wp8/pull/72#issuecomment-80507934 @brodybits - We'll start a new release soon. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-wp8 pull request: JsonHelper testing, and use of Newtonsof...

2015-03-12 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-wp8/pull/62#issuecomment-78657210 :+1: Any idea if and when this will be included? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-wp8 pull request: Use WP8 thread pool for each command, in...

2015-01-21 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-wp8/pull/72#issuecomment-70862219 I just sent the Individual CLA to Adobe (and forwarded a copy to your e-mail address). Glad you like it! --- If your project is set up for it, you can reply

[GitHub] cordova-wp8 pull request: Use WP8 thread pool for each command, in...

2015-01-21 Thread brodybits
GitHub user brodybits opened a pull request: https://github.com/apache/cordova-wp8/pull/72 Use WP8 thread pool for each command, instead of starting new thread As reported in [CB-7443](https://issues.apache.org/jira/browse/CB-7443), ref: https://msdn.microsoft.com/en-us/library