Github user riknoll closed the pull request at:
https://github.com/apache/cordova-lib/pull/472
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user riknoll commented on the issue:
https://github.com/apache/cordova-lib/pull/473
The only other consideration I can think of off the top of my head is that
the edit-config stuff also made changes to the android.json (and other
equivalent platform files) for edit-config
Github user riknoll commented on the issue:
https://github.com/apache/cordova-lib/pull/472
Closing in favor of #473
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user riknoll commented on the issue:
https://github.com/apache/cordova-lib/pull/472
@ktop @stevengill @vladimir-kotikov @TimBarham please take a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-lib/pull/472
CB-11645: Check for getEditConfigs before invoking it on pluginInfo
Adding a guard to prevent a type error when platforms and CLI have
mismatching cordova-common versions. The issue here is
Github user riknoll commented on the issue:
https://github.com/apache/cordova-docs/pull/614
@macdonst any chance you can take over merging this? Been sick and swamped
this week and I don't think I'll have a chance to test out the site before
merging it in.
---
If your
Github user riknoll commented on the issue:
https://github.com/apache/cordova-docs/pull/614
That make sense to me. I added a few more comments, but otherwise LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/614#discussion_r70540948
--- Diff: www/docs/en/dev/plugin_ref/spec.md ---
@@ -365,6 +365,111 @@ For windows-specific attributes:
```
The above example will set pre-8.1
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/614#discussion_r70540822
--- Diff: www/docs/en/dev/plugin_ref/spec.md ---
@@ -365,6 +365,111 @@ For windows-specific attributes:
```
The above example will set pre-8.1
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/614#discussion_r70540748
--- Diff: www/docs/en/dev/plugin_ref/spec.md ---
@@ -365,6 +365,111 @@ For windows-specific attributes:
```
The above example will set pre-8.1
Github user riknoll commented on the issue:
https://github.com/apache/cordova-docs/pull/614
For the examples, I would just give a snippet of the AndroidMainfest and
not the whole thing. There's a lot that doesn't change in the before and after.
Secondly, the example of fo
Github user riknoll commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/197
@swbradshaw I apologize, I have not had a chance to test this out and I am
not likely to anytime soon. Sorry, I should have left a comment
---
If your project is set up for it, you
Github user riknoll commented on the issue:
https://github.com/apache/cordova-lib/pull/449
Yep! The guide for writing xml references is
[here](https://github.com/apache/cordova-docs/blob/master/doc/docs-STYLEGUIDE.md#xml-references).
The file you need to edit is the one I linked in
Github user riknoll commented on the issue:
https://github.com/apache/cordova-lib/pull/449
Done! Sorry for the delay. @ktop can you open a PR documenting this feature
in the [plugin.xml
reference](https://github.com/apache/cordova-docs/blob/master/www/docs/en/dev/plugin_ref/spec.md
Github user riknoll commented on the issue:
https://github.com/apache/cordova-lib/pull/449
This is working fine for me! When this feature gets documented, we need to
make sure to document how to get your project back in order if you mess it up
by adding a plugin with `--force`. I
Github user riknoll commented on the issue:
https://github.com/apache/cordova-lib/pull/449
@ktop Run `git log` and check out the author field. Your email shows up,
but the name is unknown for some reason.
As for the force add thing, that sounds fine to me. There are two
Github user riknoll commented on the issue:
https://github.com/apache/cordova-lib/pull/449
I've tested it out and I think there needs to be a slight tweak to the
`--force` behavior. When a plugin is force added, any conflicting edit-config
changes it has should not be ap
Github user riknoll commented on the issue:
https://github.com/apache/cordova-lib/pull/449
@ktop the author name on the commit is "unknown"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/449#discussion_r66486389
--- Diff: cordova-common/src/ConfigChanges/ConfigChanges.js ---
@@ -125,12 +128,32 @@ function remove_plugin_changes(pluginInfo,
is_top_level
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/604#issuecomment-221043107
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/253#discussion_r64092365
--- Diff: src/cli.js ---
@@ -143,20 +143,27 @@ module.exports = function (inputArgs, cb) {
return cli(inputArgs);
}).then(function
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/253#discussion_r64091935
--- Diff: src/cli.js ---
@@ -143,20 +143,27 @@ module.exports = function (inputArgs, cb) {
return cli(inputArgs);
}).then(function
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-220658702
My suggestion was to separate editing and inserting altogether. Continue to
have a `config-file` tag that works exactly like before for adding things to
XML, and
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-220467601
I think that the issue might be that we need to separate inserting child
elements and editing existing ones. Something like this:
```xml
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-220386776
@vladimir-kotikov yep, my thought's exactly! We definitely need to handle
plugins conflicting with each other because any bugs caused by those conflicts
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-220179183
@ktop I have a couple questions. First, do we have a plan for dealing with
plugins that have conflicting attribute edits? For example, if plugin A has
this in its
Github user riknoll closed the pull request at:
https://github.com/apache/cordova-plugin-media/pull/72
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/52#issuecomment-219884158
@rakatyal this one too!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/155#issuecomment-219869580
@rakatyal take a look real quick. The docs for this feature are
[here](http://cordova.apache.org/docs/en/latest/guide/hybrid/plugins/index.html
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/18#issuecomment-219856568
This isn't a regression, and this PR has been open for quite a while so I'm
going to merge this. That being said, I will create a JIRA beca
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/18#issuecomment-219847832
@stewshka the `cordovaDependencies` object is used by Cordova, not npm, so
it isn't really covered in the npm docs. You can find our documentati
Github user riknoll closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/94
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/305#issuecomment-219589249
Sorry @jasongin, I made a few more updates. Mind taking a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-labs/pull/13#issuecomment-219587750
@daserge issue is resolved and server should be updated! Let me know if it
isn't!
---
If your project is set up for it, you can reply to this email and have
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-labs/pull/13#issuecomment-219579494
@daserge I haven't forgotten! The issue is that some changes were recently
made to the server configuration and the README appears to be out of date. I'm
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/176#discussion_r63428275
--- Diff: bin/lib/create.js ---
@@ -46,15 +47,15 @@ module.exports.create = function (destinationDir,
config, options) {
var root
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/603#issuecomment-219550624
LGTM! Checked to make sure all changes were to `.md` files in 6.x and that
seems to be the case.
---
If your project is set up for it, you can reply to this
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/602#issuecomment-219502716
LGTM! Only other comment is that it looks like you mention UWP but it
doesn't show up in the screenshot
---
If your project is set up for it, you can rep
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/602#discussion_r63397530
--- Diff: www/docs/en/dev/guide/platforms/win8/index.md ---
@@ -80,11 +80,10 @@ Install any edition of
[Visual Studio](http://www.visualstudio.com
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#discussion_r63394154
--- Diff: appium-tests/helpers/cameraHelper.js ---
@@ -103,11 +109,185 @@ module.exports.getPicture = function (opts, pid) {
}, opts
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#discussion_r63387806
--- Diff: appium-tests/helpers/cameraHelper.js ---
@@ -103,11 +109,185 @@ module.exports.getPicture = function (opts, pid) {
}, opts
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-ios/pull/223#issuecomment-219194851
@omefire @jasongin @shazron please take a look when you have a moment
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-windows/pull/176#issuecomment-219187935
@jasongin I made a few tweaks based on some log messages in the iOS
platform. Can you take another quick look?
---
If your project is set up for it, you can
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-ios/pull/223
Improving iOS build output and verbose logging
Improving grammar, consistency of language, detail, etc. for verbose and
regular output. Also made to more closely match the output of the
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#issuecomment-219182375
Awesome! LGTM other than the one comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-labs/pull/13#issuecomment-219181062
@daserge sorry for the delay, I am verifying something and then will do the
deploy ASAP
---
If your project is set up for it, you can reply to this email and have
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#discussion_r63256712
--- Diff: appium-tests/helpers/cameraHelper.js ---
@@ -103,11 +109,185 @@ module.exports.getPicture = function (opts, pid) {
}, opts
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/215#issuecomment-219136559
I wonder if we should shorten the commit message bullet so that it doesn't
wrap lines like that? Maybe we can link to
http://cordova.apach
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/215#issuecomment-219136048
@nikhilkh please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/215
Moving message in PR template to a comment
### Platforms affected
None!
### What does this PR do?
Change the template that I am currently filling out so that the
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-cli/pull/252#issuecomment-219114198
LGTM. Returning help isn't really consistent with any other commands in the
CLI. Platform-specific ones (prepare, build, clean, etc.) generally throw an
erro
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/439#issuecomment-218911859
@stevengill done!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-218908787
@JEGardner apologies, this is a pretty big change and I haven't had an
opportunity to review/test it. I'll try and take a look at it this we
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/439#issuecomment-218892839
I'll merge whenever the Travis build finishes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-windows/pull/176#issuecomment-21889
@jasongin removed the word please pretty much everywhere
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/439#discussion_r63097000
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -286,7 +286,7 @@ module.exports = function plugin(command, targets,
opts
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/105#issuecomment-218884515
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-windows/pull/176
Improving Windows build output and verbose logging
Improving grammar, consistency of language, detail, etc. for verbose and
regular output. Also made to more closely match the output of
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-android/pull/305
Improving Android build output and verbose logging
Improving grammar, consistency of language, detail, etc. for verbose and
regular output. I'm going to use Android as an exampl
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/104#issuecomment-218609674
Nitpick: You have a lot of long inline code blocks that span multiple
lines. Might look better to just use non-inline code blocks (i.e. with \`\`\`).
You can
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/104#discussion_r62937577
--- Diff: JENKINS.md ---
@@ -0,0 +1,123 @@
+# Jenkins Master Setup
+## Purpose
+The purpose of this document is to provide instructions on
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-lib/pull/439
Improving prepare and build output
The purpose of this PR is to improve the quality and clarity of our logging
(including verbose). Some things I tried to improve:
* Consistency of
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/5#discussion_r62926584
--- Diff: lib/paramedic.js ---
@@ -175,39 +178,58 @@ ParamedicRunner.prototype.runTests = function() {
reject(new Error('devi
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-docs/pull/601
CB-11253: Fixing sitemap url entries
We were giving relative paths, we need to give full URLs. This should
improve our SEO, hopefully. @nikhilkh take a quick look.
You can merge this pull
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/601#issuecomment-218561121
Changes entries like this
```
/news/2015/03/02/tools-release.html
```
to look like this:
```
https
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#issuecomment-218538540
It would be nice to refactor the specs a bit, because they seem to be 90%
shared code. This looks pretty good! Reading the file and checking the
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/5#discussion_r62734243
--- Diff: lib/utils/utilities.js ---
@@ -50,10 +50,14 @@ function getSimId() {
if (findSimResult.code > 0) {
logger.er
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/5#discussion_r62733686
--- Diff: lib/paramedic.js ---
@@ -175,39 +178,58 @@ ParamedicRunner.prototype.runTests = function() {
reject(new Error('devi
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/5#discussion_r62733344
--- Diff: lib/ParamedicTargetChooser.js ---
@@ -0,0 +1,127 @@
+var Q = require('q');
+var shelljs = require('shelljs&#
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/5#discussion_r62733203
--- Diff: lib/ParamedicTargetChooser.js ---
@@ -0,0 +1,127 @@
+var Q = require('q');
+var shelljs = require('shelljs&#
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218253991
Do we need to provide a link for CCLA info just in case? Can we also
suggest a format for PR titles? Something like:
```
[CB-12345]: Short
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/102#issuecomment-218225885
@stevengill no worries! Thanks for taking a look!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/102#issuecomment-218028324
@rakatyal @stevengill please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-medic/pull/102
CB-11237: linking cordova-fetch
See [CB-11237](https://issues.apache.org/jira/browse/CB-11237). I have not
tested this code, because I do not have a buildbot dev environment set up.
You can
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/595#issuecomment-217945411
@nikhilkh updated. I also added pointers to the CLI reference for the
`--save` flag. Is that the right place? We are still planning on getting rid of
[this
page
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-docs/pull/596
Moving analytics script to head
It looks like it got moved in a refactor. It needs to be in the head of
every page to work properly according to this:
https://support.google.com/analytics
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/5#discussion_r62402348
--- Diff: lib/utils/utilities.js ---
@@ -40,6 +40,57 @@ function getSimulatorsFolder() {
return simulatorsFolderPath
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/5#discussion_r62402014
--- Diff: lib/utils/utilities.js ---
@@ -40,6 +40,57 @@ function getSimulatorsFolder() {
return simulatorsFolderPath
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/5#discussion_r62401164
--- Diff: lib/ParamedicTargetChooser.js ---
@@ -0,0 +1,126 @@
+var Q = require('q');
+var shelljs = require('shelljs&#
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/5#discussion_r62400361
--- Diff: lib/ParamedicAppUninstall.js ---
@@ -0,0 +1,68 @@
+var shelljs = require('shelljs');
+var path= require('path
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/5#discussion_r62400177
--- Diff: lib/ParamedicAppUninstall.js ---
@@ -0,0 +1,68 @@
+var shelljs = require('shelljs');
+var path= require('path
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/436#issuecomment-217513174
@omefire you are correct. That flag seems to be totally broken
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-lib/pull/436
CB-11134: Removing duplicated warning
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-11134
Alternatively you
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/595#issuecomment-217050499
@nikhilkh please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-docs/pull/595
CB-11203: Improving documentation of plugin CLI variables
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-docs CB
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/593#issuecomment-217001592
@jasongin @rakatyal @purplecabbage updated. iOS logo back to normal and new
logo for OS X.
 for OS X.
Title text is added by docs.js
[here](https://github.com/apache
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/593#issuecomment-216662778
Also note that this changes the iOS logo (see leftmost logo in attached
image). The Apple logo is now used to indicate the OS X platform. The new iOS
logo is sort
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/593#issuecomment-216661665
@rakatyal @nikhilkh please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/593#issuecomment-216661525
Here is what it looks like. The logos appear under the attribute name.
 {
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/123#issuecomment-215809141
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-docs/pull/588
CB-11169: Adding new repo links to contribute page
@rakatyal
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-docs new
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/300#issuecomment-215524649
I tried it out a bit just now (without crosswalk). Java code changes
refreshed fine for me. The webview gets restarted of course, but my java
changes were
1 - 100 of 779 matches
Mail list logo
