GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-windows/pull/123
CB-9565: Build failure for Windows 10. This error is a result of using
This error is a result of using x64 Node and an incompatibility with x64
msbuild; the .NET Native compiler is x86
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-windows/pull/122
Fixed up "resport" to "report"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-w
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/38#discussion_r38670056
--- Diff: src/windows/VibrationProxy.js ---
@@ -60,12 +61,43 @@ if (VibrationDevice) {
fail(e
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/38#discussion_r38669919
--- Diff: src/windows/VibrationProxy.js ---
@@ -60,12 +61,43 @@ if (VibrationDevice) {
fail(e
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/38#discussion_r38669813
--- Diff: src/windows/VibrationProxy.js ---
@@ -60,12 +61,43 @@ if (VibrationDevice) {
fail(e
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/154#discussion_r37478335
--- Diff: bin/templates/scripts/cordova/run.bat ---
@@ -15,11 +15,5 @@
:: specific language governing permissions and limitations
:: under
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/116#discussion_r37243479
--- Diff: template/cordova/lib/package.js ---
@@ -215,13 +215,20 @@ module.exports.deployToDesktop = function (package,
deployTarget
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-windows/pull/116
CB-9499: There is a run failure when trying to deploy an x64 app whenâ¦
⦠running on an x86 version of Node. This change addresses the problem
by modifying the run process by
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/113#discussion_r36926008
--- Diff: template/cordova/lib/deployment.js ---
@@ -194,13 +194,28 @@ AppDeployCmdTool.prototype.enumerateDevices =
function
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/113#discussion_r36925808
--- Diff: template/cordova/lib/deployment.js ---
@@ -194,13 +194,28 @@ AppDeployCmdTool.prototype.enumerateDevices =
function
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/113#discussion_r36925416
--- Diff: template/cordova/lib/deployment.js ---
@@ -35,7 +35,7 @@ function run(cmd, args, opt_cwd) {
child.stderr.on('data'
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/113#discussion_r36925333
--- Diff: template/cordova/lib/deployment.js ---
@@ -194,13 +194,28 @@ AppDeployCmdTool.prototype.enumerateDevices =
function
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-windows/pull/113
CB-9482: Upon further investigation of CI failures, we saw that
AppDeployCmd also failed to install an app when:
- The emulator had been off previously
- It had been started
Github user robpaveza closed the pull request at:
https://github.com/apache/cordova-windows/pull/112
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/112#issuecomment-130335077
There isn't a way to get a "proper" fix. The tool doesn't have a mechanism
to query for the presence of a device (AppDeployCmd /Enu
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-windows/pull/112
CB-9482: Modifies the deployment code to account for problems with
emulators, which are currently blocking the CI from executing. Modifying
the uninstall function to never fail
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/228#discussion_r36766958
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -206,10 +178,41 @@ module.exports = function plugin(command, targets,
opts
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/228#discussion_r36766838
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -206,10 +178,41 @@ module.exports = function plugin(command, targets,
opts
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/228#discussion_r36766569
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -146,11 +145,7 @@ function fetchPlugin(plugin_src, plugins_dir, options
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/228#discussion_r36766359
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -206,10 +178,41 @@ module.exports = function plugin(command, targets,
opts
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/228#discussion_r36766275
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -206,10 +178,41 @@ module.exports = function plugin(command, targets,
opts
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-plugin-globalization/pull/40
CB-9476: Mobilespec crash on startup when running on Windows 10.
Windows 10 apparently deprecated and removed the navigator.userLanguage
property. This change addresses
Github user robpaveza closed the pull request at:
https://github.com/apache/cordova-windows/pull/110
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/109#issuecomment-128053464
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/108#issuecomment-128051522
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/107#discussion_r36318952
--- Diff: template/cordova/lib/log.js ---
@@ -0,0 +1,226 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/107#discussion_r36318858
--- Diff: template/cordova/lib/log.js ---
@@ -0,0 +1,226 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-windows/pull/111
CB-9450: Added a manifest munge step during build that updates app...
...manifests with build and packaging parameters. Also added the new
`WindowsStoreIdentityName` preference which
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-windows/pull/110
CB-9458: Updated the baseline version of Universal Windows to 10240.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/111#discussion_r36199186
--- Diff: src/windows/CameraProxy.js ---
@@ -696,21 +696,22 @@ function
takePictureFromCameraWindows(successCallback, errorCallback, args
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/111#discussion_r36130435
--- Diff: src/windows/CameraProxy.js ---
@@ -696,21 +696,22 @@ function
takePictureFromCameraWindows(successCallback, errorCallback, args
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/111#discussion_r36129853
--- Diff: src/windows/CameraProxy.js ---
@@ -696,21 +696,22 @@ function
takePictureFromCameraWindows(successCallback, errorCallback, args
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/106#issuecomment-126521787
I'm game. Let's make a Jira for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/106#issuecomment-126520990
It only goes into the case if it's an "old project template." This change
is only expected for newer Cordova projects.
(src/c
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/298#discussion_r35931879
--- Diff: docs/en/edge/guide/platforms/win8/index.md ---
@@ -272,4 +272,18 @@ command-line tools or the SDK in your workflow. The
Cordova CLI relies
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-windows/pull/106
CB-9410: Added preferences for Windows Store ingestion.
`WindowsStoreDisplayName` and `WindowsStorePublisherName` are the new
properties. If they are not provided, we fall back to the
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-lib/pull/268
CB-9408: Added support for `windows-packageVersion` on ``.
Corresponds to a similar change on cordova-windows.
You can merge this pull request into a Git repository by running:
$ git
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-docs/pull/300
CB-9408: Documented the new `windows-packageVersion` attribute on
... `` to allow Windows to have an independent binary version than
its
widget.
You can merge this pull request into a
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-windows/pull/105
CB-9408: Added a `windows-packageVersion` attribute to the ``
...element which enables Windows to have a separate, independent binary
version than other platforms. This attribute
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/94#issuecomment-123831922
Hey @surajpindoria - is this still a valid task? It seems like cordova-lib
is responsible for synthesizing cordova-js into a final file upon create. What
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/67#issuecomment-123830935
@brodybits: Have you been unblocked by using the `--archs` parameter?
In my experience, building Windows apps using a "Mixed Platforms"
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-docs/pull/298
CB-9398: Added documentation for WindowsToastCapable to the Windows
...docs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/92#issuecomment-123432180
I'm supposing build.spec.js spec.13 fails because it doesn't mock
`findAllAvailableVersions` (or was also `findAvailableVersions` in your code).
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/92#issuecomment-123430303
build.spec.js spec.13 fails.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/92#issuecomment-123413927
When I run this branch on my local, I get an npm test failure for
check_reqs.spec.js, failing to find config.xml in cordova-windows root.
---
If your project
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/92#issuecomment-123412166
I'm checking out how it works with #102 .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/102#issuecomment-121792352
I don't really have a preference. We could say be consistent with msbuild
and do a pipe separator but I don't think that is terribly valuable.
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/102#discussion_r34741242
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -38,6 +38,13 @@ MSBuildTools.prototype.buildProject = function(projFile,
buildType
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-windows/pull/102
CB-9359: Adds support for .appxbundle creation
.appxbundle files are convenient app packages which can be uploaded to the
Windows Store. They contain debug or release (typically release
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/101#issuecomment-121745707
I see a different history on AppVeyor than on my machine, I'm going to
close the PR and re-create.
---
If your project is set up for it, you can rep
Github user robpaveza closed the pull request at:
https://github.com/apache/cordova-windows/pull/101
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-windows/pull/101
CB-9359: Adds support for .appxbundle creation
.appxbundle files are convenient app packages which can be uploaded to the
Windows Store. They contain debug or release (typically
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/99#issuecomment-121325599
I like the change overall but I need to still merge it with my latest to
make sure it functionally works as expected.
---
If your project is set up for it
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#issuecomment-121324570
Pending my other comments, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-lib/pull/257
CB-9335: Windows quality-of-life improvements. To align with the change
To align with the change in Cordova-Windows which removes the Windows 8
project from the solution
file used by
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/98#issuecomment-120985543
@TimBarham We don't require any changes to jsprojManager because this
change didn't change any .jsprojes, only .slns.
I'll go ahe
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34480922
--- Diff: template/cordova/lib/package.js ---
@@ -130,58 +145,47 @@ module.exports.findDevice = function (target) {
};
// returns
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/45#discussion_r34479900
--- Diff: src/windows/GeolocationProxy.js ---
@@ -142,8 +143,8 @@ module.exports
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/45#discussion_r34479855
--- Diff: src/windows/GeolocationProxy.js ---
@@ -16,7 +16,8 @@
--- End diff --
In ensureLocator you should also call
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/45#discussion_r34478957
--- Diff: src/windows/GeolocationProxy.js ---
@@ -16,7 +16,8 @@
var PositionError = require('./PositionError'),
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/97#issuecomment-120509743
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-windows/pull/98
CB-9335: Windows quality-of-life improvements.
This change documents the separator between and how to specify multiple
architectures using the
--archs argument to build and run
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34167364
--- Diff: template/cordova/lib/package.js ---
@@ -113,16 +112,32 @@ function getPackageName(platformPath) {
// returns one of available
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34166300
--- Diff: template/cordova/lib/package.js ---
@@ -113,16 +112,32 @@ function getPackageName(platformPath) {
// returns one of available
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34166637
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,275 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34166452
--- Diff: template/cordova/lib/package.js ---
@@ -113,16 +112,32 @@ function getPackageName(platformPath) {
// returns one of available
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34165767
--- Diff: template/cordova/lib/target-list.js ---
@@ -17,20 +17,21 @@
under the License.
*/
-var devices = require
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34164434
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,275 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34164191
--- Diff: template/cordova/lib/run.js ---
@@ -155,7 +155,8 @@ module.exports.help = function () {
console.log('--appx=<8.1
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34164096
--- Diff: template/cordova/lib/package.js ---
@@ -130,58 +145,47 @@ module.exports.findDevice = function (target) {
};
// returns
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34163912
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,275 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34163428
--- Diff: spec/unit/deployment.spec.js ---
@@ -0,0 +1,282 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/96#issuecomment-119379779
The siblings work as expected, although they only support Windows 8.1.
We'll have to make a decision about how to invoke the Windows 10 equivalent.
-
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34105951
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34105978
--- Diff: template/cordova/lib/target-list.js ---
@@ -17,20 +17,21 @@
under the License.
*/
-var devices = require
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34105916
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34104776
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34104478
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34089196
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/92#discussion_r33998489
--- Diff: bin/lib/check_reqs.js ---
@@ -19,15 +19,226 @@
/*jshint node:true*/
-var Q = require('Q');
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/92#discussion_r33998435
--- Diff: bin/lib/check_reqs.js ---
@@ -19,15 +19,226 @@
/*jshint node:true*/
-var Q = require('Q');
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/92#discussion_r33998401
--- Diff: bin/lib/check_reqs.js ---
@@ -19,15 +19,226 @@
/*jshint node:true*/
-var Q = require('Q');
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/92#discussion_r33998339
--- Diff: bin/lib/check_reqs.js ---
@@ -19,15 +19,226 @@
/*jshint node:true*/
-var Q = require('Q');
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-windows/pull/96
CB-9283: Add support for Windows 10 WinAppDeployCmd
The Windows 10 SDK uses a new "WinAppDeployCmd" utility for deployment to
phones. This change abstracts out the differenc
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/58#discussion_r33955365
--- Diff: medic/medic-run.js ---
@@ -232,12 +233,18 @@ function windowsSpecificPreparation(argv) {
/^\s*\$appActivator .*$/gim
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/58#discussion_r33955321
--- Diff: medic/medic-run.js ---
@@ -232,12 +233,18 @@ function windowsSpecificPreparation(argv) {
/^\s*\$appActivator .*$/gim
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-plugin-vibration/pull/35
CB-9166: Changed plugin.xml framework reference condition to be valid XML
The original plugin.xml referenced "<10.0.0" which caused some validating
XML readers to
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-windows/pull/95
CB-9271: Removed the unnecessary device capabilities from the Windows 10
Removed the unnecessary device capabilities from the Windows 10 app
manifest. These capabilities are no longer
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/91#issuecomment-116763083
In general LGTM.
I would prefer that we examine the pipeline here. We had been talking
about making the build process be module-based for Windows
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/91#discussion_r33486397
--- Diff: template/cordova/lib/run.js ---
@@ -169,20 +135,10 @@ module.exports.help = function () {
process.exit(0
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33482157
--- Diff: src/windows/MediaProxy.js ---
@@ -203,20 +234,64 @@ module.exports = {
var id = args[0];
var thisM
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33482258
--- Diff: src/windows/MediaProxy.js ---
@@ -226,6 +301,10 @@ module.exports = {
try {
if (thisM.node
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33482012
--- Diff: src/windows/MediaProxy.js ---
@@ -203,20 +234,64 @@ module.exports = {
var id = args[0];
var thisM
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33481751
--- Diff: src/windows/MediaProxy.js ---
@@ -159,7 +176,21 @@ module.exports = {
var id = args[0];
var src = args[1
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33481357
--- Diff: src/windows/MediaProxy.js ---
@@ -91,6 +106,8 @@ module.exports = {
var thisM = Media.get(id);
// if Media
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33481074
--- Diff: src/windows/MediaProxy.js ---
@@ -33,8 +42,11 @@ module.exports = {
create:function(win, lose, args) {
var id
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33480928
--- Diff: src/windows/MediaProxy.js ---
@@ -33,8 +42,11 @@ module.exports = {
create:function(win, lose, args) {
var id
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33480844
--- Diff: src/windows/MediaProxy.js ---
@@ -26,6 +26,15 @@ var MediaError =
require('cordova-plugin-media.MediaError');
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-windows/pull/93
CB-9252: Migrate WinJS to an NPM dependency
This change puts the current WinJS NPM package into the node_modules
directory as well as package.json (for "npm install" support)
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/80#issuecomment-104441598
Also I made a corresponding PR for Cordova.js.
https://github.com/apache/cordova-js/pull/113
---
If your project is set up for it, you can reply to
1 - 100 of 154 matches
Mail list logo
