Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-09 Thread Shazron
Please label issues "cordova-ios-4.0.1" for the upcoming patch release like so: https://issues.apache.org/jira/browse/CB-10162 On Tue, Dec 8, 2015 at 5:19 AM, Shazron wrote: > I removed the root node_modules in cordova-ios, and re-created the > archive. They are re-published at: > https://dist.ap

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-08 Thread Shazron
I removed the root node_modules in cordova-ios, and re-created the archive. They are re-published at: https://dist.apache.org/repos/dist/dev/cordova/CB-10147 On Tue, Dec 8, 2015 at 5:12 AM, Carlos Santana wrote: > Wow good find ! > > I some times do a rm -r node_modules then npm install before r

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-08 Thread Carlos Santana
Wow good find ! I some times do a rm -r node_modules then npm install before running coho create-archive, but not all the time. So I can see this happening I agree we should automate this in coho. The coho create-archive should clean node_modules for repo ios only, or also do rm and then an

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-08 Thread Shazron
Mystery solved. cordova-ios has devDependencies in the root package.josn. This will install a "node_modules" in the root, which npm pack will ignore and git will as well (since it is in the .gitignore). However, even though it is not packed, it will affect 'npm pack', as I will explain... I hadn'

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-08 Thread Carlos Santana
Thanks for the update Did you said you tried a new directory via clone What about updating to latest npm@2.x ? On Tue, Dec 8, 2015 at 7:16 AM Shazron wrote: > A regular `tar -cvzf` the missing folders are included, it's just `npm > pack` not liking my local repo for some reason. > > On Tue, Dec

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-08 Thread Shazron
A regular `tar -cvzf` the missing folders are included, it's just `npm pack` not liking my local repo for some reason. On Tue, Dec 8, 2015 at 3:51 AM, Shazron wrote: > This is certainly bizarre. > > I've verified that my local repo copy of the cordova-ios 4.0.x branch > does have those modules, t

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-08 Thread Shazron
This is certainly bizarre. I've verified that my local repo copy of the cordova-ios 4.0.x branch does have those modules, then ran "npm pack" on the repo folder (which coho create-archive calls): [cordova-ios (4.0.x)]$ npm pack --verbose npm info it worked if it ends with ok npm verb cli [ '

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-07 Thread Carlos Santana
Currently finding a discrepancy when recreating the archive The tgz dist/ [1] is missing 3 node modules, they are located in git [2] Running the command coho create-archive --tag 4.0.0 -r ios --dest test-ios4/ I ran with npm@2.11.3 and npm@3.3.12 and was able to get all three in expected location

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-07 Thread Carlos Santana
Currently working on it... - Carlos @csantanapr > On Dec 7, 2015, at 6:50 PM, Steven Gill wrote: > > both ios@4 and cordova-plugin-wkwebviewengine need 1 more vote. Someone > step up so Shaz can wrap up the vote threads and publish these! > >> On Fri, Dec 4, 2015 at 2:07 PM, Carlos Santana wr

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-07 Thread Steven Gill
both ios@4 and cordova-plugin-wkwebviewengine need 1 more vote. Someone step up so Shaz can wrap up the vote threads and publish these! On Fri, Dec 4, 2015 at 2:07 PM, Carlos Santana wrote: > +1 > > On Fri, Dec 4, 2015 at 3:07 PM Shazron wrote: > > > After working out some bridge improvements a

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-04 Thread Carlos Santana
+1 On Fri, Dec 4, 2015 at 3:07 PM Shazron wrote: > After working out some bridge improvements and fixing some Platform > API bugs and testing, I believe it's ready. I'll start a [VOTE] thread > soon. > > On Thu, Dec 3, 2015 at 5:19 PM, Carlos Santana > wrote: > > +1 let's move forward this item

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-04 Thread Shazron
After working out some bridge improvements and fixing some Platform API bugs and testing, I believe it's ready. I'll start a [VOTE] thread soon. On Thu, Dec 3, 2015 at 5:19 PM, Carlos Santana wrote: > +1 let's move forward this items with WKWebview I don't see holding up the > platform. > > Don't

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-03 Thread Carlos Santana
+1 let's move forward this items with WKWebview I don't see holding up the platform. Don't see any changes going on the platform, if any they will go into the pluggable webview plugin or creating new plugin to handle. On Wed, Dec 2, 2015 at 8:40 PM Shazron wrote: > Regarding Platform API, Vladim

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-02 Thread Shazron
Regarding Platform API, Vladimir Kotikov and Sergey Grebnov agree in the PR comments that the changes can go in to cordova-ios-4.x: https://github.com/apache/cordova-ios/pull/176 On Wed, Dec 2, 2015 at 5:38 PM, Shazron wrote: > Also, check footnote 3 above. > > Yes, WebKit defines window.openData

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-02 Thread Shazron
Also, check footnote 3 above. Yes, WebKit defines window.openDatabase but it doesn't do anything. Not sure why their tests didn't catch this... (see footnote for the bug) With CSP off to rule things out: XHR to yourself of course works, but doesn't really make sense for real-world use. XHR to a s

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-02 Thread Carlos Santana
I'm guessing "pending" is the same as skipping the test. I'm guessing WKWebView doesn't support Web SQL, but window.openDatabase exist but it doesn't do anything? I ask because I only saw the pending for wkwebview spec.18 for using it, not for spec.9 where it checks that exists. Anyway after all qu

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-02 Thread Shazron
Marked the two known failures as pending. Now everything is green (and yellow) across the board for UIWebView and WKWebView. On Tue, Dec 1, 2015 at 11:49 PM, Jesse wrote: >>> Or should I just let it fail still? > It depends how long it'll be until we fix them. The build will be broken > in the C

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-01 Thread Jesse
>> Or should I just let it fail still? It depends how long it'll be until we fix them. The build will be broken in the CI until it is fixed so probably marking them as pending is the better option. @purplecabbage risingj.com On Tue, Dec 1, 2015 at 10:42 PM, Shazron wrote: > Couldn't wait. All

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-01 Thread Shazron
Couldn't wait. All file-transfer specs now pass for uiwebview and wkwebview. For those two WKWebView tests that are failing, but are expected to fail -- I'll try to modify the tests to mark the test as pending if the platform is iOS and the WKWebView bridge is found. Or should I just let it fail

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-01 Thread Shazron
Thanks! - yeah after I posted it, of course I realized it is all open source (duh) and I can run a local server or throw it on a digitalocean instance or something :) I'll do that tomorrow... On Tue, Dec 1, 2015 at 9:24 PM, Carlos Santana wrote: > For a second I read "the bar is clear", but then

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-01 Thread Carlos Santana
For a second I read "the bar is clear", but then I went to my fridge and saw I still have some beer left :-) How long before the INFRA provides the VM for the file transfer, I looked the JIRA and it mentioned something like "complete" and "we are in holding because of capacity" in the same comment

[DISCUSS] cordova-ios-4.x release (for real)

2015-12-01 Thread Shazron
The board is almost clear [1]. UIWebView mobile-spec passes, just waiting for INFRA-10831 [2] for the file-transfer tests. Ditto for WKWebView, it essentially just fails two tests, which are expected [3] (filed a feature request issue [4] for local xhr loading, if needed). Platform API [4] could