Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/521#discussion_r107994895
--- Diff: cordova-lib/src/cordova/restore-util.js ---
@@ -63,7 +64,27 @@ function installPlatformsFromConfigXML(platforms, opts) {
Github user shazron closed the pull request at:
https://github.com/apache/cordova-lib/pull/489
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/521#discussion_r107954943
--- Diff: cordova-lib/src/cordova/restore-util.js ---
@@ -114,13 +135,19 @@ function installPlatformsFromConfigXML(platforms,
opts) {
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/521#discussion_r107954295
--- Diff: cordova-lib/src/cordova/restore-util.js ---
@@ -63,7 +64,27 @@ function installPlatformsFromConfigXML(platforms, opts) {
//
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/522#discussion_r107952809
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -255,13 +235,7 @@ function checkID(expectedIdAndVersion, pinfo) {
if (!expectedIdAndVersion)
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/521#discussion_r107840862
--- Diff: cordova-lib/src/cordova/restore-util.js ---
@@ -114,13 +135,19 @@ function installPlatformsFromConfigXML(platforms,
opts) {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/521#discussion_r107840945
--- Diff: cordova-lib/src/cordova/restore-util.js ---
@@ -63,7 +64,27 @@ function installPlatformsFromConfigXML(platforms, opts) {
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/455
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/530
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/453
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/260
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/315
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/390
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/358
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/261
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/51
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/522#discussion_r107831849
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -255,13 +235,7 @@ function checkID(expectedIdAndVersion, pinfo) {
if
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/522#discussion_r107829266
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -255,13 +235,7 @@ function checkID(expectedIdAndVersion, pinfo) {
if
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/528
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user audreyso closed the pull request at:
https://github.com/apache/cordova-lib/pull/530
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user audreyso reopened a pull request:
https://github.com/apache/cordova-lib/pull/530
CB-10438 : Install correct dependency version
requires force to install plugin with wrong dependency version installed.
### Platforms affected
### What does
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/530
CB-10438 : Install correct dependency version
requires force to install plugin with wrong dependency version installed.
### Platforms affected
### What does
Github user audreyso closed the pull request at:
https://github.com/apache/cordova-lib/pull/527
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/529
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/519
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/523
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-lib/pull/529
CB-11346 Remove known platforms check
Building on top of the work by @purplecabbage and @shazron.
Still need to fix failing tests + add some new tests.
Also, need to run
GitHub user brodybits opened a pull request:
https://github.com/apache/cordova-lib/pull/528
CB-12572: (windows) pin cordova-windows 5.0.0
### Platforms affected
Windows
### What does this PR do?
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/527
CB-10438 : Install correct dependency version
### Platforms affected
### What does this PR do?
Install correct dependency version, requires force to install plugin
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/526
CB-11242 - Removed platform-specific code for platforms w/ PlatformApi
implemented
### Platforms affected
### What does this PR do?
Removed platform-specific code
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/520
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user daserge closed the pull request at:
https://github.com/apache/cordova-lib/pull/480
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user daserge closed the pull request at:
https://github.com/apache/cordova-lib/pull/477
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/524
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/346
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/397
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/525
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user audreyso commented on the pull request:
https://github.com/apache/cordova-lib/commit/d7b74471034d6999839e8a5b78190c9f784023fa#commitcomment-21237797
In cordova-lib/spec-cordova/platforms/PlatformApiPoly.spec.js:
In
GitHub user filmaj opened a pull request:
https://github.com/apache/cordova-lib/pull/525
CB-12557: superspawn now returns both stdout and stderr in reject handler
Please review @stevengill and @audreyso.
### Platforms affected
All.
### What does this PR
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-lib/pull/524
CB-12528 use fs instead of our own existsSync
### Platforms affected
Lib
### What does this PR do?
Removes unneeded API
### What testing has been
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/commit/b3ca300172fdb94860a523505ab12d90512d984c#commitcomment-21110531
In
cordova-lib/spec-cordova/fixtures/platforms/cordova-browser/bin/lib/create.js:
In
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/522#discussion_r103528081
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -257,7 +237,7 @@ function checkID(expectedIdAndVersion, pinfo) {
var parsedSpec =
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/522#discussion_r103526011
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -257,7 +237,7 @@ function checkID(expectedIdAndVersion, pinfo) {
var parsedSpec =
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/522#discussion_r103361780
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -165,14 +165,7 @@ module.exports.uninstallPlugin = function(id,
plugins_dir, options) {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/522#discussion_r103362278
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -342,13 +322,6 @@ function copyPlugin(pinfo, plugins_dir, link) {
var dest =
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/522#discussion_r103360880
--- Diff: cordova-lib/spec-plugman/install.spec.js ---
@@ -221,7 +221,7 @@ describe('install', function() {
});
});
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/522#discussion_r103362438
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -257,7 +237,7 @@ function checkID(expectedIdAndVersion, pinfo) {
var parsedSpec =
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-lib/pull/523
CB-11346
### Platforms affected
All, none, ...
### What does this PR do?
Removes multiple checks for 'known' platforms
### What testing has been done
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/522#discussion_r103343073
--- Diff: cordova-lib/spec-plugman/install.spec.js ---
@@ -221,7 +221,7 @@ describe('install', function() {
});
});
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/522
CB-12016 : removes pluginId mapping
### Platforms affected
### What does this PR do?
Removes pluginId mapping
### What testing has been done on this
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/521
CB-12425 : Auto-create package.json if it doesn't exist yet (during prepare)
### Platforms affected
### What does this PR do?
Auto-creates package.json if it
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/520
CB-11977 : removed support for node 0.x
### Platforms affected
### What does this PR do?
Removed support for node 0.x. Node 4 and 6 still supported.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/518
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r102321817
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -412,15 +412,26 @@ function determinePluginTarget(projectRoot, cfg,
target, fetchOptions) {
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-lib/pull/519
CB-11346 - Remove known platforms check for Platform API
### Platforms affected
CLI
### What does this PR do?
Removes platforms check. Right now only known platforms
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r102099272
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -412,15 +412,26 @@ function determinePluginTarget(projectRoot, cfg,
target, fetchOptions) {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r101877578
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -414,13 +414,15 @@ function determinePluginTarget(projectRoot, cfg,
target, fetchOptions) {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r101877994
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -414,13 +414,15 @@ function determinePluginTarget(projectRoot, cfg,
target, fetchOptions) {
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r101875939
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -388,26 +384,54 @@ module.exports = function plugin(command, targets,
opts) {
function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r101873081
--- Diff: cordova-lib/spec-cordova/platform.spec.js ---
@@ -353,4 +353,5 @@ describe('plugin add and rm end-to-end --fetch',
function () {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r101872753
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -253,6 +275,7 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r101873667
--- Diff: cordova-lib/spec-cordova/pkgJson-restore.spec.js ---
@@ -742,7 +742,7 @@ describe('update config.xml to use the variable found
in
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r101870795
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -388,26 +384,54 @@ module.exports = function plugin(command, targets,
opts) {
function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r101826675
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -69,7 +71,7 @@ function fetchPlugin(plugin_src, plugins_dir, options) {
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/518
CB-12021 : --fetch should use dependency version saved in package.json
before default cordova version when adding/restoring
### Platforms affected
### What does this
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/517
Cb 12017
### Platforms affected
### What does this PR do?
Updates npm dependencies used in cordova-lib.
### What testing has been done on this change?
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/499
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/499#discussion_r98560154
--- Diff: cordova-lib/spec-plugman/fetch.spec.js ---
@@ -214,20 +214,23 @@ describe('fetch', function() {
it('Test 017 : should fetch from a
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/515
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/499#discussion_r97895425
--- Diff: cordova-lib/spec-cordova/fixtures/basePkgJson4/package.json ---
@@ -5,7 +5,7 @@
"main": "index.js",
"dependencies": {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/499#discussion_r97894467
--- Diff: cordova-lib/spec-cordova/pkgJson-restore.spec.js ---
@@ -680,10 +681,10 @@ describe('update config.xml to include platforms in
pkg.json',
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/499#discussion_r97894300
--- Diff: cordova-lib/spec-cordova/fixtures/basePkgJson4/package.json ---
@@ -5,7 +5,7 @@
"main": "index.js",
"dependencies": {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/499#discussion_r97894545
--- Diff: cordova-lib/spec-cordova/pkgJson-restore.spec.js ---
@@ -697,18 +698,18 @@ describe('update config.xml to include platforms in
pkg.json',
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/499#discussion_r97894565
--- Diff: cordova-lib/spec-cordova/pkgJson-restore.spec.js ---
@@ -697,18 +698,18 @@ describe('update config.xml to include platforms in
pkg.json',
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/499#discussion_r97894506
--- Diff: cordova-lib/spec-cordova/pkgJson-restore.spec.js ---
@@ -697,18 +698,18 @@ describe('update config.xml to include platforms in
pkg.json',
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/515#discussion_r97743108
--- Diff: cordova-lib/src/plugman/browserify.js ---
@@ -157,8 +157,8 @@ module.exports = function doBrowserify (project,
platformApi,
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/515#discussion_r97741534
--- Diff: cordova-lib/src/plugman/browserify.js ---
@@ -157,8 +157,8 @@ module.exports = function doBrowserify (project,
platformApi, pluginInfoProvider
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/515#discussion_r97738068
--- Diff: cordova-lib/src/plugman/browserify.js ---
@@ -157,8 +157,8 @@ module.exports = function doBrowserify (project,
platformApi,
GitHub user botcheddevil opened a pull request:
https://github.com/apache/cordova-lib/pull/516
CB-12385: (win32/linux/darwin) auto open devtools in chrome for
cordova-serve
### Platforms affected
linux, win32, darwin
### What does this PR do?
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-lib/pull/515
CB-12383 Fix cordova_plugins metadata definition
Define parent object first
[Jira issue](https://issues.apache.org/jira/browse/CB-12383)
### Platforms affected
Tested
Github user ktop closed the pull request at:
https://github.com/apache/cordova-lib/pull/214
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/468
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/510
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95627089
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -192,34 +203,39 @@ beforeEach(function () {
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95625647
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -192,34 +203,39 @@ beforeEach(function () {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500848
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95501588
--- Diff: cordova-lib/spec-plugman/install.spec.js ---
@@ -206,134 +178,136 @@ describe('install', function() {
beforeEach(function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95502237
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -192,34 +203,39 @@ beforeEach(function () {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500857
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500726
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -145,30 +146,36 @@ describe('plugin end-to-end', function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95501387
--- Diff: cordova-lib/spec-plugman/create.spec.js ---
@@ -35,46 +35,42 @@ describe( 'create plugin', function() {
existsSync,
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500893
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -309,10 +341,13 @@ describe('plugin end-to-end', function() {
.then(function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500826
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500649
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -83,6 +83,7 @@ function removePlugin(id) {
var errorHandler = {
errorCallback:
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500805
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95497591
--- Diff: cordova-common/spec/ActionStack.spec.js ---
@@ -59,19 +59,19 @@ describe('action-stack', function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500766
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95502073
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -192,34 +203,39 @@ beforeEach(function () {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500793
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500754
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -199,11 +209,14 @@ describe('plugin end-to-end', function() {
.then(function() {
301 - 400 of 3208 matches
Mail list logo
