RE: Building cordova.js on first build

2015-06-11 Thread Nikhil Khandelwal
ough 4.0.0 >> is already out there. >> >> Thanks, >> Nikhil >> >> >> -Original Message- >> From: brian.ler...@gmail.com [mailto:brian.ler...@gmail.com] On >> Behalf Of Brian LeRoux >> Sent: Friday, May 29, 2015 5:55 AM >> To: d

Re: Building cordova.js on first build

2015-06-10 Thread Steven Gill
> > - cordova-lib depends on cordova-js, meaning platforms are >> double-pinned? >> > > >> > > Is it possible that the pinned versions could get out of sync? Seems >> > > possible... >> > > >> > > I think there's probably two ways that

Re: Building cordova.js on first build

2015-06-10 Thread Steven Gill
gt; > Thanks, > Nikhil > > > -Original Message- > From: brian.ler...@gmail.com [mailto:brian.ler...@gmail.com] On Behalf Of > Brian LeRoux > Sent: Friday, May 29, 2015 5:55 AM > To: dev@cordova.apache.org > Subject: Re: Building cordova.js on first build > > +1 &

RE: Building cordova.js on first build

2015-06-10 Thread Nikhil Khandelwal
e- From: brian.ler...@gmail.com [mailto:brian.ler...@gmail.com] On Behalf Of Brian LeRoux Sent: Friday, May 29, 2015 5:55 AM To: dev@cordova.apache.org Subject: Re: Building cordova.js on first build +1 On Thu, May 28, 2015 at 6:32 PM, Steven Gill wrote: > Right now, only the --browserify way

Re: Building cordova.js on first build

2015-05-29 Thread Brian LeRoux
gt; > We could actually do both, since in CLI we don't download package > > dependencies when adding downloading platform packages. > > > > On Tue, May 26, 2015 at 9:14 PM, Murat Sutunc > > wrote: > > > > > I think this would be a valuable addition to coh

Re: Building cordova.js on first build

2015-05-28 Thread Steven Gill
cordova-js\cordova-windows to cordova-windows. Once linked you have to > > > grunt compile cordova-js and manually move file over cordova-windows. > > > > > > On second thought, regenerating cordova.js from cordova-cli is not a > > > great idea. For browserify

Re: Building cordova.js on first build

2015-05-27 Thread Andrew Grieve
sday, May 26, 2015 5:40 PM > To: dev@cordova.apache.org > Subject: Re: Building cordova.js on first build > > npm linking is suggested when testing platform specific JS changes. > > cordova-coho's prepare-release-branch command will generate cordova.js and > move it over to the platform

RE: Building cordova.js on first build

2015-05-26 Thread Murat Sutunc
I think this would be a valuable addition to coho. +1 -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Tuesday, May 26, 2015 5:40 PM To: dev@cordova.apache.org Subject: Re: Building cordova.js on first build npm linking is suggested when testing platform

Re: Building cordova.js on first build

2015-05-26 Thread Steven Gill
ify workflow it makes a lot of sense because we don't know > which plugins the user has but otherwise the file is static. > > -Original Message- > From: Steven Gill [mailto:stevengil...@gmail.com] > Sent: Tuesday, May 26, 2015 5:10 PM > To: dev@cordova.apache.org > Subjec

RE: Building cordova.js on first build

2015-05-26 Thread Murat Sutunc
x27;t know which plugins the user has but otherwise the file is static. -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Tuesday, May 26, 2015 5:10 PM To: dev@cordova.apache.org Subject: Re: Building cordova.js on first build If people are into it, I can han

Re: Building cordova.js on first build

2015-05-26 Thread Steven Gill
If people are into it, I can handle this one as I am very familiar with the code base since I just did it for the browserify workflow. On Tue, May 26, 2015 at 4:15 PM, Steven Gill wrote: > Hey Murat, > > By two files you mean cordova-js-src and www\cordova.js I assume. The > www\cordova.js file

Re: Building cordova.js on first build

2015-05-26 Thread Steven Gill
Hey Murat, By two files you mean cordova-js-src and www\cordova.js I assume. The www\cordova.js file is generated and updated on each release of the platform. It will use cordova-js-src to build it when available (instead of legacy-exe version) Problem with removing www\cordova.js and building it

Building cordova.js on first build

2015-05-26 Thread Murat Sutunc
Hey there, I've a quick question. Now that every platform comes with cordova-js-src should we remove the www\cordova.js from platform repos? I think it's a better idea to compile cordova.js on first build if it's missing. This way we don't have to update two files when working on platform js. Tho