Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-17 Thread Carlos Santana
Andrew when you say denote your app as an android library Your thinking a AAR archive, which includes the cordova-platform core, cordova.js, and plugins native and web assets? On Tue, Mar 17, 2015 at 11:06 AM, Carlos Santana csantan...@gmail.com wrote: Andrew similar requirement we have for

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-17 Thread Carlos Santana
Andrew similar requirement we have for iOS. If we implement something like that in CLI to have an option to produce a library instead of an App. In theory this is something we have discussed here in IBM, to do something similar with Cocoa Pods, produce a cocoapod that represent the iOS Cordova

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-17 Thread Andrew Grieve
On Tue, Mar 17, 2015 at 10:10 AM, Carlos Santana csantan...@gmail.com wrote: @Michal I would get together with Marcel and Martin, they are our Android goto SME @Joe Do we have all the test cases created now are some missing? How do you run this specific test cases on Android Studio? Google

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-17 Thread Andrew Grieve
The place where we're lacking on the plugins side (IMO), is that CLI / plugman create an application target in Gradle. This is no different form ANT, but it would be nice if you could denote your app as an android library so that it's easily usable by those wanting to embed. On Tue, Mar 17, 2015

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-17 Thread Carlos Santana
Andrew where is this new enhancements documented, Only place I can find any documentation is here: http://cordova.apache.org/docs/en/4.0.0/guide_platforms_android_webview.md.html#Android%20WebViews Can you update this Docs? In addition to having the docs updated I think it will be great

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-17 Thread Andrew Grieve
Not documented yet. That's one of the TODOs for 4.0.x On Tue, Mar 17, 2015 at 11:03 AM, Carlos Santana csantan...@gmail.com wrote: Andrew where is this new enhancements documented, Only place I can find any documentation is here:

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-17 Thread Andrew Grieve
I just mean use: apply plugin: 'android-library' rather than apply plugin: 'android' On Tue, Mar 17, 2015 at 11:09 AM, Carlos Santana csantan...@gmail.com wrote: Andrew when you say denote your app as an android library Your thinking a AAR archive, which includes the cordova-platform core,

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-16 Thread Joe Bowser
Well, this feature was tested using TDD, and when the tests were re-written I assumed that they would be run. In this case, I'll blame Android Studio, since we're still battling with the learning curve on that one. (I have no clue how to run the new tests from Gradle on the command line, only in

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-16 Thread Michal Mocny
Carlos, thats great, then perhaps you could give 4.0 embedded webview a shot to confirm that it is still adequately supported for your customers? I think this thread has been too much talk and not enough trying it out in practice. Everyone agrees the use case is important, what's left is to

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-11 Thread Joe Bowser
That's why we have tests! I just changed the activity and saw that we have one failure. I'm not sure why this test in particular is failing, since there's too many assertions in one method, so I'll have to try and debug it today. The thing is that if we're deprecating something and replacing it

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-11 Thread Andrew Grieve
I wanted to make sure that I didn't break the old way of doing things. On Tue, Mar 10, 2015 at 2:24 PM, Joe Bowser bows...@gmail.com wrote: The main issue is that this isn't documented anywhere, and this is necessary for people to use a Third Party WebView. Also, why didn't you bother

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-10 Thread Joe Bowser
The main issue is that this isn't documented anywhere, and this is necessary for people to use a Third Party WebView. Also, why didn't you bother updating the test with the new API? On Mon, Mar 9, 2015 at 5:19 PM Andrew Grieve agri...@chromium.org wrote: Here's an example: ConfigXmlParser

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-09 Thread Joe Bowser
On Mon, Mar 9, 2015 at 7:39 AM Andrew Grieve agri...@chromium.org wrote: You can now instantiate a CordovaWebView without a config.xml, and without using Config. This happened when I added an init() method to CordovaWebView. You can pass in a CordovaPreferences object, and a list of

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-09 Thread Andrew Grieve
On Mon, Mar 9, 2015 at 11:56 AM, Joe Bowser bows...@gmail.com wrote: On Mon, Mar 9, 2015 at 7:39 AM Andrew Grieve agri...@chromium.org wrote: You can now instantiate a CordovaWebView without a config.xml, and without using Config. This happened when I added an init() method to

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-09 Thread Andrew Grieve
On Fri, Mar 6, 2015 at 6:50 PM, Joe Bowser bows...@gmail.com wrote: The issue is that it's a public API that is used by anyone who is looking to embed a webview. This can be found in the test that you re-wrote. Right now, there's no way for people who want to embed a CordovaWebView in their

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-09 Thread Joe Bowser
OK, this actually makes using the WebView as a component a lot harder, since you now have to have this loadConfig method which you also marked for deprecation required to get all of the necessary attributes out of this. I'm pretty sure this is a major step backwards in that people looking to use

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-09 Thread Andrew Grieve
Here's an example: ConfigXmlParser parser = new ConfigXmlParser(); parser.parse(activity); webView.init(cordova, parser.getPluginEntries(), parser.getPreferences()); Feel free to iterate if you think the API is too obtuse, but I think it's good to allow a file-less mode, and to allow different

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-09 Thread Joe Bowser
Do you have an example of how this would work? This seems to be a lot more complex than it needs to be. On Mon, Mar 9, 2015 at 5:05 PM Andrew Grieve agri...@chromium.org wrote: It's so that you can have multiple CordovaWebViews that use different configs within one application. It's also so

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-06 Thread Joe Bowser
The issue is that it's a public API that is used by anyone who is looking to embed a webview. This can be found in the test that you re-wrote. Right now, there's no way for people who want to embed a CordovaWebView in their app to do so without the Config class. Having a public API marked as

Deprecation of Config and the embedded use case (4.0.x related)

2015-03-06 Thread Joe Bowser
Hey I've been trying to figure out how you would embed a WebView with the changes that we made to Cordova for 4.0.x, and I noticed that we're still making heavy use of the Config class, even though we have it set up to be deprecated. Are we still intending to deprecate this class, and if so,

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-06 Thread Andrew Grieve
Where do you see it being used? Within cordova-android, we are setting it, but I don't the we ever read from it. Within plugins: $ grep -r Config *plugin*/src/android cordova-plugin-file-transfer/src/android/FileTransfer.java:import org.apache.cordova.Config;