Subject: Hello
Hi,
I am Vishal and have joined the Adobe team that works on Cordova. I will
be working on making Cordova work better with the new devices and platforms.
Regards,
Vishal
-
To unsubscribe, e-mail: dev-unsubscr
GitHub user Yamini-Sontakke opened a pull request:
https://github.com/apache/cordova-app-hello-world/pull/11
Useless change
Added by Android
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Yamini-Sontakke/cordova-app-hello-world
Github user Yamini-Sontakke commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/11#issuecomment-106284959
hello demo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user Yamini-Sontakke closed the pull request at:
https://github.com/apache/cordova-app-hello-world/pull/11
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user Yamini-Sontakke opened a pull request:
https://github.com/apache/cordova-app-hello-world/pull/13
Useless change
Added by Android
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Yamini-Sontakke/cordova-app-hello-world
GitHub user Yamini-Sontakke opened a pull request:
https://github.com/apache/cordova-app-hello-world/pull/12
Useless change
Added by Android
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Yamini-Sontakke/cordova-app-hello-world
GitHub user Yamini-Sontakke reopened a pull request:
https://github.com/apache/cordova-app-hello-world/pull/12
Useless change
Added by Android
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Yamini-Sontakke/cordova-app-hello
Github user Yamini-Sontakke closed the pull request at:
https://github.com/apache/cordova-app-hello-world/pull/12
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user Yamini-Sontakke commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/12#issuecomment-106285245
hell
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101816514
Is this required for development time experience or every app needs access
to localhost port 8472 to run on the phone?
---
If your project is set up
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101817138
It's required for runtime if an app (running on BlackBerry 10) has any
plugins. The app doesn't actually talk to port 8472, it's just magically
https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-10142
9782
Problem:
As is, today, Cordova projects created w/ the default cordova hello-world
template which have any plugins won't work on BlackBerry 10 at-all
My fix is to add a CSP whitelist for the BlackBerry 10 magic
-hello-world/pull/10#issuecomment-10142
9782
Problem:
As is, today, Cordova projects created w/ the default cordova hello-world
template which have any plugins won't work on BlackBerry 10 at-all
My fix is to add a CSP whitelist for the BlackBerry 10 magic port...
Steve Gill commented
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101429782
As long as this doesn't negatively impact other platforms, merge away.
---
If your project is set up for it, you can reply to this email and have
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101026209
@timwindsor
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user jsoref opened a pull request:
https://github.com/apache/cordova-app-hello-world/pull/10
CB-9009 default CSP needs to include 8472 for blackberry
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jsoref/cordova-app
Github user timwindsor commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101032363
Works for me - required for use of any plugins.
---
If your project is set up for it, you can reply to this email and have your
reply appear
+1
On Tue, Mar 24, 2015 at 9:29 AM, Ian Clelland iclell...@google.com wrote:
+1
* Checked signatures and checksums
* Verified contents against Git repo at 3.9.0 tag
* Successfully built and ran hello world with Cordova-Android 3.7.1 and
4.0.0-dev (master)
On Mon, Mar 23, 2015 at 8:13 PM
On 20 Mar 2015, at 14:46, Andrew Grieve wrote:
First: just committed a change to add the whitelist plugin to the
default
app template:
https://git1-us-west.apache.org/repos/asf?p=cordova-app-hello-world.git;a=commit;h=2e856b845a0134e7056bdc74f89cafcf483a379f
Perhaps a bit strange
Yup
On Mar 23, 2015 11:50 AM, Ian Clelland iclell...@chromium.org wrote:
This includes
https://github.com/apache/cordova-app-hello-world/commit/2e856b845a0134e7056bdc74f89cafcf483a379f
,
right?
If so, +1 for releasing!
On Mon, Mar 23, 2015 at 1:54 PM, Steven Gill stevengil...@gmail.com
+1
The code that uses NPM version of cordova-app-hello-world in cordova-lib is
currently on a branch
https://github.com/apache/cordova-lib/blob/copy-from-app-hello-world/cordova-lib/package.json.
Should we merge it now to start using the npm version of hello world?
On Mon, Mar 23, 2015 at 3:20
yes!
On Mon, Mar 23, 2015 at 1:16 PM, Mark Koudritsky kam...@google.com wrote:
+1
The code that uses NPM version of cordova-app-hello-world in cordova-lib is
currently on a branch
https://github.com/apache/cordova-lib/blob/copy-from-app-hello-world/cordova-lib/package.json
.
Should we
Does anyone have any reason to delay a cordova-app-hello-world release?
Any outstanding patches to land?
If not, I will start the release this afternoon.
This includes
https://github.com/apache/cordova-app-hello-world/commit/2e856b845a0134e7056bdc74f89cafcf483a379f,
right?
If so, +1 for releasing!
On Mon, Mar 23, 2015 at 1:54 PM, Steven Gill stevengil...@gmail.com wrote:
Does anyone have any reason to delay a cordova-app-hello-world release
Please review and vote on this 3.9.0 Cordova App Hello World Release.
Release issue: https://issues.apache.org/jira/browse/CB-8731
Repos ready to be released have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8731
The package was published from its corresponding
at 3:01 PM, Mark Koudritsky kam...@google.com
wrote:
+1
Built and ran on
- Android 5.0.2 on Nexus 7
- iOS simulator
On Fri, Mar 13, 2015 at 2:32 PM, Steven Gill stevengil...@gmail.com
wrote:
Please review and vote on this 3.8.0 Cordova App Hello World Release.
Release
+1
On Fri, Mar 13, 2015 at 3:01 PM, Mark Koudritsky kam...@google.com wrote:
+1
Built and ran on
- Android 5.0.2 on Nexus 7
- iOS simulator
On Fri, Mar 13, 2015 at 2:32 PM, Steven Gill stevengil...@gmail.com
wrote:
Please review and vote on this 3.8.0 Cordova App Hello World Release
Gill [mailto:stevengil...@gmail.com]
Sent: Friday, March 13, 2015 2:22 AM
To: dev@cordova.apache.org
Subject: [Vote] 3.8.0 Cordova App Hello World Release (attempt 2)
Please review and vote on this 3.8.0 Cordova App Hello World Release.
Release issue: https://issues.apache.org
+1
Built and ran on
- Android 5.0.2 on Nexus 7
- iOS simulator
On Fri, Mar 13, 2015 at 2:32 PM, Steven Gill stevengil...@gmail.com wrote:
Please review and vote on this 3.8.0 Cordova App Hello World Release.
Release issue: https://issues.apache.org/jira/browse/CB-8645
Repos ready
Please review and vote on this 3.8.0 Cordova App Hello World Release.
Release issue: https://issues.apache.org/jira/browse/CB-8645
Repos ready to be released have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8645
The package was published from its corresponding
I vote +1
* Verified that app can be built and ran (android, windows, wp8)
Thx!
Sergey
-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com]
Sent: Friday, March 13, 2015 2:22 AM
To: dev@cordova.apache.org
Subject: [Vote] 3.8.0 Cordova App Hello World Release (attempt 2
[mailto:stevengil...@gmail.com]
Sent: Friday, March 13, 2015 2:22 AM
To: dev@cordova.apache.org
Subject: [Vote] 3.8.0 Cordova App Hello World Release (attempt 2)
Please review and vote on this 3.8.0 Cordova App Hello World Release.
Release issue: https://issues.apache.org/jira/browse/CB-8645
and ran (android, windows, wp8)
Thx!
Sergey
-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com]
Sent: Friday, March 13, 2015 2:22 AM
To: dev@cordova.apache.org
Subject: [Vote] 3.8.0 Cordova App Hello World Release (attempt 2)
Please review and vote
releasenotes.md
+ removed version file, package.json can keep track of version
+ Adding hooks to default app
+ [CB-8597] First attempt at importing cordova-app-hello-world via npm
dependency
+ Remove jasmine ref
+ Tweak CSP string
+ CB-8295 Add content-security
Message-
From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew
Grieve
Sent: Wednesday, March 11, 2015 6:18 PM
To: dev
Subject: Re: [Vote] 3.8.0 Cordova App Hello World Release
-1 Verified it works on the latest release iOS and Android, but I had a
typo in the CSP string
Perfect. Thanks Steve.
On Mon, Mar 9, 2015 at 7:46 PM, Steven Gill stevengil...@gmail.com wrote:
Release steps:
https://github.com/apache/cordova-coho/blob/master/docs/app-hello-world-release-process.md
I will have to run through a release to see if I got it all right.
Okay, I'm going
-1 Verified it works on the latest release iOS and Android, but I had a
typo in the CSP string:
https://github.com/apache/cordova-app-hello-world/commit/18fc9b4eaecd90bf35795c31a7801bc5260b5c6c
Perhaps we could re-spin with this one fix and leave the vote end period
the same (assuming everyone
Subject: Re: [Vote] 3.8.0 Cordova App Hello World Release
-1 Verified it works on the latest release iOS and Android, but I had a typo in
the CSP string:
https://github.com/apache/cordova-app-hello-world/commit/18fc9b4eaecd90bf35795c31a7801bc5260b5c6c
Perhaps we could re-spin with this one fix
Note that this pulls in the addition of a content-security-policy meta
tag.
Please ensure that this doesn't break your platform when voting.
On Tue, Mar 10, 2015 at 7:30 PM, Steven Gill stevengil...@gmail.com wrote:
Please review and vote on this 3.8.0 Cordova App Hello World Release.
Release
Please review and vote on this 3.8.0 Cordova App Hello World Release.
Release issue: https://issues.apache.org/jira/browse/CB-8645
Repos ready to be released have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8645
The package was published from its corresponding
Release steps:
https://github.com/apache/cordova-coho/blob/master/docs/app-hello-world-release-process.md
I will have to run through a release to see if I got it all right.
Okay, I'm going to merge the copy-from-app-hello-world branch into master
and start a vote thread! Lets hold off on merging
Mocny; Andrew Grieve; dev
Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as
dependency of cordova-lib
Agreed.
Everything is upstream on the branch. The package.json wasn't fully thought
out, so please peak at it. Ping me if you need anything, I'll rebase
cordova-lib
I wanted to originally, but you can --copy-from a www/ only (no
config.xml), and then we need a template. If I change cordova-lib to
depend on app-hello-world then we can remove it. Another reason to do so.
-Michal
On Thu, Mar 5, 2015 at 10:17 PM, Andrew Grieve agri...@chromium.org wrote
need a template. If I change cordova-lib to
depend on app-hello-world then we can remove it. Another reason to do so.
-Michal
On Thu, Mar 5, 2015 at 10:17 PM, Andrew Grieve agri...@chromium.org
wrote:
Can we move the config.xml template out of cordova-lib/templates and into
app-hello-world
Sure. I can make the changes to release process + coho for it.
I imagine it won't be released often, so it might be best give
app-hello-world its own release process instead of tying it into tools,
platforms or plugins release.
On Mar 6, 2015 1:04 PM, Michal Mocny mmo...@chromium.org wrote
:
Sure. I can make the changes to release process + coho for it.
I imagine it won't be released often, so it might be best give
app-hello-world its own release process instead of tying it into tools,
platforms or plugins release.
On Mar 6, 2015 1:04 PM, Michal Mocny mmo...@chromium.org wrote
Alight, remote branches (named copy-from-app-hello-world) are created for
cordova-lib, cordova-cli, and cordova-app-hello-world.
There are still 2 failing cordova-lib tests, but I'm working to resolve
that. My actual end-to-end tests appear to be working with all use cases.
Please, please
The current breaking change is that you cannot create a new project using
cordova-lib directly, without providing a project template to import from.
cordova-cli works as it always has, and will provide the app-hello-world
as a default if you do not use --copy-from / --link-to.
However, writing
PM
To: dev
Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as
dependency of cordova-lib
Alight, remote branches (named copy-from-app-hello-world) are created for
cordova-lib, cordova-cli, and cordova-app-hello-world.
There are still 2 failing cordova-lib tests, but I'm
Can we move the config.xml template out of cordova-lib/templates and into
app-hello-world as a part of this?
On Thu, Mar 5, 2015 at 5:13 PM, Michal Mocny mmo...@chromium.org wrote:
The current breaking change is that you cannot create a new project using
cordova-lib directly, without providing
wrote:
Hello! I'm Rob Paveza. I'm a software engineer at Microsoft, on the
Visual Studio team. I've been working on the Cordova tools for a short
while, particularly getting a cordova-windows prototype ready to roll out
with Windows 10 support. I wanted to start getting into the mix
I like moving this to npm because Apache Git as a distribution mechanism for
the hello world app has been less reliable than desirable in the past.
Thanks,
Nikhil
-Original Message-
From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal Mocny
Sent: Tuesday, March 3
Welcome Rob!
On Tue, Mar 3, 2015 at 8:30 PM, Shazron shaz...@gmail.com wrote:
Welcome Rob!
On Tue, Mar 3, 2015 at 4:33 PM, Rob Paveza rob.pav...@microsoft.com
wrote:
Hello! I'm Rob Paveza. I'm a software engineer at Microsoft, on the
Visual Studio team. I've been working on the Cordova
create.js to just always do a --copy-from (or --link-to), and
change cordova-cli to provide the default
--copy-from=./node_modules/cordova-app-hello-world.
This also implies we can remove our last use of lazy_load from cordova-lib
(minus explicit git clones or platforms/plugins), and npm all
the default
--copy-from=./node_modules/cordova-app-hello-world.
This also implies we can remove our last use of lazy_load from cordova-lib
(minus explicit git clones or platforms/plugins), and npm all the things!
It also means a semver MAJOR change to cordova-lib that downstreams
directly
-to), and
change cordova-cli to provide the default
--copy-from=./node_modules/cordova-app-hello-world.
This also implies we can remove our last use of lazy_load from
cordova-lib
(minus explicit git clones or platforms/plugins), and npm all the things!
It also means a semver MAJOR change
Pushed first attempt to remote branches:
- https://github.com/Apache/cordova-cli/tree/copy-from-app-hello-world
-
https://github.com/Apache/cordova-app-hello-world/tree/copy-from-app-hello-world
Cleaning up cordova-lib is strictly required, though I think we should
still take the opportunity
Hello, and welcome!
@purplecabbage
risingj.com
On Tue, Mar 3, 2015 at 4:33 PM, Rob Paveza rob.pav...@microsoft.com wrote:
Hello! I'm Rob Paveza. I'm a software engineer at Microsoft, on the
Visual Studio team. I've been working on the Cordova tools for a short
while, particularly getting
Welcome Rob!
On Tue, Mar 3, 2015 at 4:33 PM, Rob Paveza rob.pav...@microsoft.com wrote:
Hello! I'm Rob Paveza. I'm a software engineer at Microsoft, on the Visual
Studio team. I've been working on the Cordova tools for a short while,
particularly getting a cordova-windows prototype ready
Hello! I'm Rob Paveza. I'm a software engineer at Microsoft, on the Visual
Studio team. I've been working on the Cordova tools for a short while,
particularly getting a cordova-windows prototype ready to roll out with Windows
10 support. I wanted to start getting into the mix and getting
, 2015 10:37 PM
To: dev@cordova.apache.org
Subject: Re: Hello
Welcome Eric! No more lurking. Glad to hear you're involved in many
platforms.
On Feb 28, 2015, at 5:28 PM, Harmon, Eric eric.har...@intel.com wrote:
Hi,
I wanted to introduce myself. My name is Eric Harmon and I’m
*Moving Eric from the 'lurker' file to the 'participant' file, wrings hands*
Welcome Eric! Be sure to check out
http://wiki.apache.org/cordova/ContributorWorkflow
Also, each repo should have a CONTRIBUTING.md file that shows how to contribute.
On Sat, Feb 28, 2015 at 5:28 PM, Harmon, Eric
Welcome, Eric !
Nice to have you contributing.
Thanks,
Mefire
-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com]
Sent: Saturday, February 28, 2015 10:37 PM
To: dev@cordova.apache.org
Subject: Re: Hello
Welcome Eric! No more lurking. Glad to hear you're involved in many
Hi,
I wanted to introduce myself. My name is Eric Harmon and I’m a software
engineer at Intel. I work on the Intel XDK team.I’ve been working with
the Cordova CLI and the android, iOS, windows, and wp8 platforms for the build
component of the XDK. I’ve also been lurking on the mailing
Welcome Eric! No more lurking. Glad to hear you're involved in many platforms.
On Feb 28, 2015, at 5:28 PM, Harmon, Eric eric.har...@intel.com wrote:
Hi,
I wanted to introduce myself. My name is Eric Harmon and I’m a software
engineer at Intel. I work on the Intel XDK team.I’ve
Welcome Les!
On Mon, Jan 5, 2015 at 11:58 AM, Les Orchard lorch...@mozilla.com wrote:
Hey folks! Just realized that my attempt last year at an intro email
bounced, so here goes again...
My name's Les Orchard, and I'm a webdev at the Mozilla Corp. I'm just
starting to dig into contributing
Hey folks! Just realized that my attempt last year at an intro email
bounced, so here goes again...
My name's Les Orchard, and I'm a webdev at the Mozilla Corp. I'm just
starting to dig into contributing work on Firefox OS support, alongside
Piotr Zalewa. I think my sweet spot will be looking at
GitHub user kingIZZZY opened a pull request:
https://github.com/apache/cordova-app-hello-world/pull/9
more helpful stupid-friendly index.js
3:07:37 PM regedit: i did actually look at index.js at first, but it
seemed a little daunting so i put it aside and started coding my own
Github user kingIZZZY commented on a diff in the pull request:
https://github.com/apache/cordova-app-hello-world/pull/9#discussion_r19973706
--- Diff: www/js/index.js ---
@@ -16,27 +16,15 @@
* specific language governing permissions and limitations
* under the License
Welcome Nikolai!
On Sun, Aug 17, 2014 at 5:02 PM, tommy-carlos williams to...@devgeeks.org
wrote:
Welcome!
On 18 August 2014 at 8:59:55, Nikolai Kotchetkov (moto...@gmail.com)
wrote:
Hello Cordova!
My name is Nikolai, and I've been taking part in several Cordova projects
already mostly
Hello Cordova!
My name is Nikolai, and I've been taking part in several Cordova projects
already mostly by writing plugins for Android.
At this time I'd like to contribute a small feature to make a plugin
handling a bit easier :)
https://github.com/apache/cordova-lib/pull/63
My ICLA is on it's
Welcome!
On 18 August 2014 at 8:59:55, Nikolai Kotchetkov (moto...@gmail.com) wrote:
Hello Cordova!
My name is Nikolai, and I've been taking part in several Cordova projects
already mostly by writing plugins for Android.
At this time I'd like to contribute a small feature to make a plugin
Hi all,
I'm Jason Chase, and I just joined the Google team working on Cordova.
I've spent the last while working on enterprise SaaS solution, so I'm
looking forward to the challenge of getting up to speed on Cordova. Looks
like there's a lot going on with Cordova, so I can't wait to contribute!
Welcome Jason !
On Thu, Aug 7, 2014 at 10:19 AM, Jason Chase cha...@chromium.org wrote:
Hi all,
I'm Jason Chase, and I just joined the Google team working on Cordova.
I've spent the last while working on enterprise SaaS solution, so I'm
looking forward to the challenge of getting up to
Hi Jason!
On Thu, Aug 7, 2014 at 9:50 AM, Carlos Santana csantan...@gmail.com wrote:
Welcome Jason !
On Thu, Aug 7, 2014 at 10:19 AM, Jason Chase cha...@chromium.org wrote:
Hi all,
I'm Jason Chase, and I just joined the Google team working on Cordova.
I've spent the last while
Welcome Jason!
On Thu, Aug 7, 2014 at 9:55 AM, Sebastian Mil sebastianthe...@gmail.com
wrote:
Hi Jason!
On Thu, Aug 7, 2014 at 9:50 AM, Carlos Santana csantan...@gmail.com
wrote:
Welcome Jason !
On Thu, Aug 7, 2014 at 10:19 AM, Jason Chase cha...@chromium.org
wrote:
Hi all,
Welcome Jason! Lots to do and see here. Please document your journey of
getting up to speed. Lots of rough edges that we can smooth out with a
fresh perspective.
I'm sure your colleagues have already given you a boat load of stuff to
look at but our wiki [1] * is a great place to start.
[1]
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-app-hello-world/pull/8
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user JohnMcLear commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-48886202
Thanks guys :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zalun commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-48788987
I'll wait for any possible -1 and if none, I'm pushing it to master on
Monday
---
If your project is set up for it, you can reply to this email and have
Hi everyone, Marcel K introduced me on here a couple weeks ago. I just
started with IBM out of college and I'm glad I'm going to be getting a
chance to work on Cordova with all of you. Hope you all have a good
weekend coming up.
I am having problems having Jiras assigned to me. In particular
I've added you to the JIRA project. Try it again and let me know if you
still can't assign it to yourself.
On Thu, Jul 3, 2014 at 1:33 PM, Eric Weiterman eweit@gmail.com wrote:
Hi everyone, Marcel K introduced me on here a couple weeks ago. I just
started with IBM out of college and
Ok, I was able to assign it to myself. Thanks Andrew.
Eric.
On Thu, Jul 3, 2014 at 3:03 PM, Andrew Grieve agri...@chromium.org wrote:
I've added you to the JIRA project. Try it again and let me know if you
still can't assign it to yourself.
On Thu, Jul 3, 2014 at 1:33 PM, Eric Weiterman
Github user JohnMcLear commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47515954
PR looks fine to me, this i how I would have made this change.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user marti1125 commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47554060
why I removed this line? because it has a warning about CSP when I
validated in marketplace
https://developer.mozilla.org/en-US/Apps/CSP
Github user JohnMcLear commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47555716
@marti1125 wut?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user marti1125 commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47559877
@JohnMcLear ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47561643
Code looks good to me too. @zalun, can you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mwbrooks commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47569377
Generally, our philosophy for the Hello World app is to avoid over
complicating the code. This is why we use the `app` object instead of a self
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47574133
The pull request looks fine to me. My only suggestion would be to leave a
comment explaining that initialization must happen after cordova.js
Github user zalun commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47574935
Looks good to me - I haven't tested it though.
Moving JS to separate file is a good practice. I'd suggest doing that even
if it wouldn't be about CSP
GitHub user marti1125 opened a pull request:
https://github.com/apache/cordova-app-hello-world/pull/8
update index.html and index.js
I removed this script of index.html
app.initialize();
https://issues.apache.org/jira/browse/CB-6949
You can merge this pull request
Github user marti1125 commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47493059
Hi!
@rodms10, when I try to validated this app at marketplace, this value:
pkgName: io.cordova.hellocordova,
doesn't valid
The vote has now closed. The results are:
Positive Binding Votes: 4
Steve Gill
Marcel Kinard
Carlos Santana
Ian Clelland
Negative Binding Votes: 0
The vote has passed.
On Wed, May 21, 2014 at 1:59 PM, Marcel Kinard cmarc...@gmail.com wrote:
+1 for app-hello-world. Verified hashes
Bump. Not sure if this needs to be voted + released on. Thoughts? We don't
need to put any of this on dist.
On Wed, May 14, 2014 at 1:26 PM, Steven Gill stevengil...@gmail.com wrote:
Please review and vote on this 3.5.0 cordova-js, cordova-mobile-spec
cordova-app-hello-world Releases
cordova-app-hello-world gets dynamically fetched via git when a new project is
created, so IMHO it does get distributed even though it’s not the usual
channel. So I’d suggest that the distribution process should apply for it (vote
+ post to dist).
cordova-mobile-spec isn’t used by anyone
+1 for cordova-app-hello-world only
no need for cordova-js and cordova-mobile-spec as Marcel's comments.
On Wed, May 21, 2014 at 4:01 PM, Ian Clelland iclell...@chromium.orgwrote:
+1 for cordova-app-hello-world, then :)
On Wed, May 21, 2014 at 3:53 PM, Marcel Kinard cmarc...@gmail.com
I agree!
I'm going to take those +1s as votes for app-hello-world
On May 21, 2014 1:27 PM, Carlos Santana csantan...@gmail.com wrote:
+1 for cordova-app-hello-world only
no need for cordova-js and cordova-mobile-spec as Marcel's comments.
On Wed, May 21, 2014 at 4:01 PM, Ian Clelland
+1 for app-hello-world. Verified hashes, signatures, and content.
On May 21, 2014, at 4:46 PM, Steven Gill stevengil...@gmail.com wrote:
I agree!
I'm going to take those +1s as votes for app-hello-world
Please review and vote on this 3.5.0 cordova-js, cordova-mobile-spec
cordova-app-hello-world Releases.
Release issue: https://issues.apache.org/jira/browse/CB-6586
Repos ready to be released have been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-6586/final
101 - 200 of 259 matches
Mail list logo
