Hi interested people.
I spent the last few days unblocking pull requests for our plugin
repositories. This meant fixing our test configuration, fixing some
specific problems of our test infrastructure and in general making
sure that PRs with failing tests were fixed and rerun.
The result: 83
chrieb Jan Piotrowski <
>>> > piotrow...@gmail.com>:
>>> >
>>> >> Having (🤖/👩🔧) in the column title turned out to be a bad idea as
>>> >> it made the messages added to PRs very noisy.
>>> >> I removed them and added a card wit
>
>> > Am Mi., 5. Sep. 2018 um 12:39 Uhr schrieb Jan Piotrowski <
>> > piotrow...@gmail.com>:
>> >
>> >> Having (🤖/👩🔧) in the column title turned out to be a bad idea as
>> >> it made the messages added to PRs very noisy.
>> >&g
s
> >> it made the messages added to PRs very noisy.
> >> I removed them and added a card with the same information ("column
> >> managed by 👩🔧 + 🤖") instead.
> >>
> >> As I personally did benefit from having the Platforms PR boar
title turned out to be a bad idea as
>> it made the messages added to PRs very noisy.
>> I removed them and added a card with the same information ("column
>> managed by 👩🔧 + 🤖") instead.
>>
>> As I personally did benefit from having the Platforms PR board
rsonally did benefit from having the Platforms PR board in
> going through all the existing PRs, I created another one for tooling:
>
> Apache Cordova: Tooling Pull Requests
> https://github.com/orgs/apache/projects/8?fullscreen=true
> Linked repositories: cordova-js cordova-cli cordova
ng through all the existing PRs, I created another one for tooling:
Apache Cordova: Tooling Pull Requests
https://github.com/orgs/apache/projects/8?fullscreen=true
Linked repositories: cordova-js cordova-cli cordova-lib cordova-common
cordova-fetch
Unfortunately we hit the "5 linked repositories
e?
>
> On Mon, Sep 3, 2018 at 6:13 PM Jan Piotrowski wrote:
>
>> Hi,
>>
>> with the switch to GitHub for issues I started looking into GitHub
>> Project boards to help us manage Issues and Pull Requests.
>>
>> The first concrete result of this is ready for
lp us manage Issues and Pull Requests.
>
> The first concrete result of this is ready for feedback:
>
> Apache Cordova - Platforms Pull Requests
> https://github.com/orgs/apache/projects/7
>
> As the name implies, this board contains all Pull Requests for the
> Platform repo
um 14:43 Uhr schrieb Jan Piotrowski <
piotrow...@gmail.com>:
> Hi,
>
> with the switch to GitHub for issues I started looking into GitHub
> Project boards to help us manage Issues and Pull Requests.
>
> The first concrete result of this is ready for feedback:
>
> Apache Co
Hi,
with the switch to GitHub for issues I started looking into GitHub
Project boards to help us manage Issues and Pull Requests.
The first concrete result of this is ready for feedback:
Apache Cordova - Platforms Pull Requests
https://github.com/orgs/apache/projects/7
As the name implies
cordova-android --> 21 Pull Requests
cordova-amazon-fireos --> 4 Pull Requests
cordova-ios --> 4 Pull Requests
cordova-windows --> 3 Pull Requests
cordova-ubuntu --> 3 Pull Requests
cordova-osx --> 1 Pull Requests
cordova-wp8 --> 1 Pull Requests
cordova-browser --> 1 Pul
cordova-plugin-inappbrowser --> 30 Pull Requests
cordova-plugin-camera --> 30 Pull Requests
cordova-plugin-media --> 26 Pull Requests
cordova-plugin-dialogs --> 18 Pull Requests
cordova-plugin-file --> 18 Pull Requests
cordova-plugin-splashscreen --> 15 Pull Requests
cordova-plug
ved CordovaPlugin is supposed to do with it.
> > None of our core plugins seem to use it.
> >
> > Thanks,
> > Nikhil
> >
> > -Original Message-
> > From: Joe Bowser [mailto:bows...@gmail.com]
> > Sent: Monday, October 5, 2015 9:05 AM
> &g
x27;permissions' and what a derived CordovaPlugin is supposed to do with it.
> None of our core plugins seem to use it.
>
> Thanks,
> Nikhil
>
> -Original Message-
> From: Joe Bowser [mailto:bows...@gmail.com]
> Sent: Monday, October 5, 2015 9:05 AM
> To: dev
t.
Thanks,
Nikhil
-Original Message-
From: Joe Bowser [mailto:bows...@gmail.com]
Sent: Monday, October 5, 2015 9:05 AM
To: dev
Subject: Merging latest pull requests into Master today
Hey
I'm going to pull the 5.0.x proposed pull requests into Master today. Can
anyone take a look a
Hey
I'm going to pull the 5.0.x proposed pull requests into Master today. Can
anyone take a look at them before I do this. I'm going to wait until after
1 PM to do it, so if you can check out the new pull requests and comment on
them before then, that would be greatly appreciated, oth
Hey
I did a second iteration for most of the pull requests. If people could
check out these pull requests, that would be awesome:
https://github.com/apache/cordova-android/pull/223
https://github.com/apache/cordova-plugin-geolocation/pull/53
https://github.com/apache/cordova-plugin-file/pull
ctivity
>
>
>
> My team is hiring!
> @purplecabbage
> risingj.com
>
> On Mon, Sep 28, 2015 at 11:57 AM, Joe Bowser wrote:
>
>> Hey
>>
>> So, this happened...
>>
>> https://github.com/apache/cordova-android/pull/220#issuecomment-143840327
>&
oid/pull/220#issuecomment-143840327
>
> Has anyone else been getting spam on GitHub pull requests? Is there any
> way we can stop it? Should we use a different tool for code review?
>
> Thoughts?
>
> Joe
mment-143840327
>
> Has anyone else been getting spam on GitHub pull requests? Is there any
> way we can stop it? Should we use a different tool for code review?
>
> Thoughts?
>
> Joe
>
Hey
So, this happened...
https://github.com/apache/cordova-android/pull/220#issuecomment-143840327
Has anyone else been getting spam on GitHub pull requests? Is there any
way we can stop it? Should we use a different tool for code review?
Thoughts?
Joe
Thanks for sharing Nikhil with the broader audience
On Fri, Jul 17, 2015 at 1:51 PM Nikhil Khandelwal
wrote:
> FYI. In short, we are part of an early access program from github that
> should allow us to have better ability to manage pull requests and issues
> in Github.
>
> htt
FYI. In short, we are part of an early access program from github that should
allow us to have better ability to manage pull requests and issues in Github.
https://github.com/blog/2020-improved-organization-permissions
Thanks,
Nikhil
-Original Message-
From: David Nalley [mailto:da
Hi all,
Could someone merge the pull requests for StatusBar plugin.
https://github.com/apache/cordova-plugin-statusbar/pulls
Seems nobody take a look on it.
Specifically this one was confirmed to be fixed.
https://github.com/apache/cordova-plugin-statusbar/pull/19
Don't look on other th
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-coho/pull/75
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-coho/pull/75
Add github URL for pull requests to `list-pulls` command
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-coho pull_url
.
2014-12-07 21:04 GMT+06:00 Andrey Kurdumov :
> Could someone review and merge following pull requests?
>
> https://github.com/apache/cordova-docs/pull/232 (CB-6259 Add StatusBar
> row to Platform Support)
>
> https://github.com/apache/cordova-docs/pull/235 (Removed Invalid secti
Could someone review and merge following pull requests?
https://github.com/apache/cordova-docs/pull/232 (CB-6259 Add StatusBar row
to Platform Support)
https://github.com/apache/cordova-docs/pull/235 (Removed Invalid section in
BlackBerry platform guides)
The test is broken and has been for a while,
Introduced by:
https://issues.apache.org/jira/browse/CB-5421
fix:
https://github.com/apache/cordova-lib/pull/8
Please merge...
We didn't have pull request notification (I filed a bug, I think it's
fixed),
https://github.com/apache/cordova-lib/pull/20
This makes our toolchain much friendlier to users.
It will enable phonegap, webworks, and others to use cordova-lib and have
error messages which make sense to users inste
https://github.com/apache/cordova-coho/blob/master/docs/processing-pull-req
uests.md
> Platforms, mobile-spec, cordova-js, cordova-docs:
> * Commit all changes to branch: master
...
> All other Repos:
> * Commit all changes to branch: master
This distinction used to make sense when one wasn't mas
--
> From: purplecabbage [mailto:purplecabb...@gmail.com]
> Sent: Tuesday, April 29, 2014 10:45 AM
> To: dev@cordova.apache.org
> Subject: Re: Help Wanted: Pull Requests
>
> Um, Sergey is a committer, has been from since we moved to Apache.
>
> Sent from my iPhone
>
mailto:purplecabb...@gmail.com]
>> Sent: Tuesday, April 29, 2014 10:45 AM
>> To: dev@cordova.apache.org
>> Subject: Re: Help Wanted: Pull Requests
>>
>> Um, Sergey is a committer, has been from since we moved to Apache.
>>
>> Sent from my iPhone
>>
&
rplecabbage [mailto:purplecabb...@gmail.com ]
> Sent: Tuesday, April 29, 2014 10:45 AM
> To: dev@cordova.apache.org
> Subject: Re: Help Wanted: Pull Requests
>
> Um, Sergey is a committer, has been from since we moved to Apache.
>
> Sent from my iPhone
>
> > On Apr
Yep, I'm a committer but I believe I don't have write access to the repos.
-Sergey
-Original Message-
From: purplecabbage [mailto:purplecabb...@gmail.com]
Sent: Tuesday, April 29, 2014 10:45 AM
To: dev@cordova.apache.org
Subject: Re: Help Wanted: Pull Requests
Um, Sergey is a
Um, Sergey is a committer, has been from since we moved to Apache.
Sent from my iPhone
> On Apr 29, 2014, at 10:14 AM, "Parashuram Narasimhan (MS OPEN TECH)"
> wrote:
>
> We also have a couple of pull requests open for Contacts, and other plugins.
> Would lov
We also have a couple of pull requests open for Contacts, and other plugins.
Would love to see them merged fast.
Sergey and I could help, but we are not committers and cannot merge.
-Original Message-
From: Josh Soref [mailto:jso...@blackberry.com]
Sent: Tuesday, April 29, 2014 9:12 AM
Andrew Grieve wrote:
> I've been managing PRs for CLI & Plugman alright, but no one's been doing
> plugins.
> Just did camera last night, and now I'm spent on time.
>
> Any volunteers?
I can't commit to doing this yet. I still haven't done any official
commits yet. I've relied on others to merge f
Hello,
Please review/pull the:
https://github.com/apache/cordova-plugin-file-transfer/pull/22
https://github.com/apache/cordova-plugin-device-motion/pull/11
https://github.com/apache/cordova-plugin-camera/pull/16
https://github.com/apache/cordova-cli/pull/136
_
Best regards,
Maxim Er
2014 at 8:56 PM, Andrew Grieve
> > > wrote:
> > >
> > > > Without --signoff, you already get set as the "committer", while the
> > > > author is maintained. You can verify this by running "coho last-week"
> > and
> > > &
ally by GitHub)
> >
> >
> >
> > On Fri, Feb 28, 2014 at 8:56 PM, Andrew Grieve
> > wrote:
> >
> > > Without --signoff, you already get set as the "committer", while the
> > > author is maintained. You can verify this by running &quo
Grieve
> wrote:
>
> > Without --signoff, you already get set as the "committer", while the
> > author is maintained. You can verify this by running "coho last-week" and
> > see that it separates commits you wrote vs commits that you did from pull
> &g
ntained. You can verify this by running "coho last-week" and
> see that it separates commits you wrote vs commits that you did from pull
> requests. That said, adding "--signoff" couldn't hurt.
>
> Squishing & fixing up does maintain authorship, so I think tha
Without --signoff, you already get set as the "committer", while the
author is maintained. You can verify this by running "coho last-week" and
see that it separates commits you wrote vs commits that you did from pull
requests. That said, adding "--signoff" couldn&
Does the squash keep original author info? I know the hashes change so
they don't match up, but if we have the author and a reference to the PR in
the commit, I think thats fine for me.
Alternative is to ask the contributor to do the squash, which we do try to
do, but its usually the non-responsi
Hey
I saw the wiki was updated, and I'm not quite sure how I feel about this:
https://wiki.apache.org/cordova/ProcessingPullRequests
# REPO_NAME example: "js"
# PULL_REQUEST_NUMBER example: "44"
curl https://github.com/apache/cordova-REPO_NAME/pull/PULL_REQUEST_NUMBER.patch
| git am
git rebase or
n the human-readable site (/pull/)?
>> >
>> > Is there something useful that a committer could do with the JSON URL?
>> >
>> > Ian
>> >
>> > On Saturday, February 1, 2014, Bas Bosman wrote:
>> >
>> >> While browsing JIRA I cam
; (/pulls/), rather than the human-readable site (/pull/)?
> >
> > Is there something useful that a committer could do with the JSON URL?
> >
> > Ian
> >
> > On Saturday, February 1, 2014, Bas Bosman wrote:
> >
> >> While browsing JIRA I came acro
No reply from issues-owner@c.a.o so I filed an INFRA issue:
https://issues.apache.org/jira/browse/INFRA-7283
On Thu, Jan 16, 2014 at 3:49 PM, Shazron wrote:
> Just one snag - the iss...@cordova.apache.org list only takes submissions
> from @apache.org addresses, and there is no way to send emai
omething useful that a committer could do with the JSON URL?
>
> Ian
>
> On Saturday, February 1, 2014, Bas Bosman wrote:
>
>> While browsing JIRA I came across CB-5625 about implementing a coho
>> command for listing outstanding pull requests on GitHub.
>>
>&g
?
Ian
On Saturday, February 1, 2014, Bas Bosman wrote:
> While browsing JIRA I came across CB-5625 about implementing a coho
> command for listing outstanding pull requests on GitHub.
>
> As Coho is self contained and has a lot of code I can reuse I decided that
> it would be a ni
While browsing JIRA I came across CB-5625 about implementing a coho
command for listing outstanding pull requests on GitHub.
As Coho is self contained and has a lot of code I can reuse I decided that
it would be a nice issue to try to tackle and get my feet wet.
Pull Request at: https
All done!
On Wed, Jan 29, 2014 at 7:44 AM, Maxim Ermilov
wrote:
> >I will take a look at these tomorrow/today?
> It will be great to merge it before 3.4.0 ;)
>
>I will take a look at these tomorrow/today?
It will be great to merge it before 3.4.0 ;)
I will take a look at these tomorrow/today?
On Mon, Jan 20, 2014 at 6:54 AM, Maxim Ermilov
wrote:
> Please review/pull the:
>
> https://github.com/apache/cordova-cli/pull/119
> https://github.com/apache/cordova-ubuntu/pull/5
> https://github.com/apache/cordova-plugin-file/pull/23
> https://githu
Please review/pull the:
https://github.com/apache/cordova-cli/pull/119
https://github.com/apache/cordova-ubuntu/pull/5
https://github.com/apache/cordova-plugin-file/pull/23
https://github.com/apache/cordova-plugin-device-orientation/pull/9
https://github.com/apache/cordova-plugin-media-capture/pul
Just one snag - the iss...@cordova.apache.org list only takes submissions
from @apache.org addresses, and there is no way to send email from an @
apache.org email address from a Gmail and/or Email IFTTT channel. I emailed
issues-ow...@cordova.apache.org to see if I can be whitelisted...
On Thu, J
I like it.
@purplecabbage
risingj.com
On Thu, Jan 16, 2014 at 10:51 AM, Andrew Grieve wrote:
> SGTM. I was planning on writing a script to poll github's pull
> requests. This sounds even easier.
>
> On Thu, Jan 16, 2014 at 1:41 PM, Daniel Gómez
> wrote:
&g
SGTM. I was planning on writing a script to poll github's pull
requests. This sounds even easier.
On Thu, Jan 16, 2014 at 1:41 PM, Daniel Gómez
wrote:
> Sounds great to me!
>
>
>
>
>
>
> El día jueves, 16 de enero de 2014 15:27, Shazron
> escribió:
>
>
Sounds great to me!
El día jueves, 16 de enero de 2014 15:27, Shazron escribió:
As you know we don't get notifications for any PR posted in Github unless
you watch a specific repo -- but then that goes to a specific user. Not
sure if Infra has any solution for this on their end, but they c
As you know we don't get notifications for any PR posted in Github unless
you watch a specific repo -- but then that goes to a specific user. Not
sure if Infra has any solution for this on their end, but they could add
hooks in Github - has anyone pursued this?
Another option is, to use http://IFT
Patchwork looks neat, but it would be annoying to have to maintain a
service, and I don't trust our github setup to always send us pull request
emails.
I filed this as a feature request:
CB-5625 - Add coho command for listing outstanding pull
requests<https://issues.apache.org/jira/browse
Mercurial uses "Patchwork"
http://patchwork.serpentine.com/project/hg/list/
-
This transmission (including any attachments) may contain confidential
information, privileged material (including material protected by the
solicitor
Just finished going through most of our repos and addressing pull requests.
Lots of things that have fallen through the cracks :(. (e.g. 4 month old
requests that were still relevant).
I think what might improve our situation here is to write a script that can
poll all of our github repos and
platforms but, it is Dec, so we might have to bump to Jan.
> > > >
> > > >
> > > > On Wed, Nov 27, 2013 at 9:58 AM, Naik, Archana
> > wrote:
> > > >
> > > > > Hi, Steven
> > > > >
> > >
gt; >
> > >
> > > On Wed, Nov 27, 2013 at 9:58 AM, Naik, Archana
> wrote:
> > >
> > > > Hi, Steven
> > > >
> > > > Do you know when will amazon-fireos be part of cordova's official
> > > release?
> &g
, Naik, Archana wrote:
> >
> > > Hi, Steven
> > >
> > > Do you know when will amazon-fireos be part of cordova's official
> > release?
> > > I see 3.2 was releases last week. When is the next release planned?
> > > Also, we wante
Archana wrote:
>
> > Hi, Steven
> >
> > Do you know when will amazon-fireos be part of cordova's official
> release?
> > I see 3.2 was releases last week. When is the next release planned?
> > Also, we wanted to support 3.0 and 3.1 as well. There are pul
l release?
> I see 3.2 was releases last week. When is the next release planned?
> Also, we wanted to support 3.0 and 3.1 as well. There are pull requests
> for these too. Is there any chance of merging those?
>
> Thanks
> Archana
>
> On 11/26/13 4:57 PM, "Steven Gill&q
Hi, Steven
Do you know when will amazon-fireos be part of cordova's official release?
I see 3.2 was releases last week. When is the next release planned?
Also, we wanted to support 3.0 and 3.1 as well. There are pull requests
for these too. Is there any chance of merging those?
Thanks
Ar
All of these plugins have been merged into dev branches! Feel free to close
the pull requests.
I also went ahead and added amazon-fireos support to cordova-mobile-spec
On Wed, Nov 20, 2013 at 1:05 PM, Naik, Archana wrote:
> Thank you steven. :) Please let me know if anything doesn
Thank you steven. :) Please let me know if anything doesn't seem right.
On 11/20/13 12:57 PM, "Steven Gill" wrote:
>I will get to this today/tomorrow
>
>
>On Wed, Nov 20, 2013 at 12:45 PM, Naik, Archana wrote:
>
>> Hello, Devs
>>
>> I have sent this earlier but thought would remind you guys for
I will get to this today/tomorrow
On Wed, Nov 20, 2013 at 12:45 PM, Naik, Archana wrote:
> Hello, Devs
>
> I have sent this earlier but thought would remind you guys for these core
> plug-ins. Amazon-fireos has been added as a platform in all these. Can
> someone please review and merge?
>
> co
Hello, Devs
I have sent this earlier but thought would remind you guys for these core
plug-ins. Amazon-fireos has been added as a platform in all these. Can someone
please review and merge?
cordova-plugin-battery-status
Dev - https://github.com/apache/cordova-plugin-battery-status/pull/6
Mast
Whoops, I also meant to say, those LGTM, especially the first one. Much
more detailed docs for CLI are very welcome.
Braden
On Wed, Nov 20, 2013 at 1:20 PM, Braden Shepherdson wrote:
> Reviewboard was giving Mark problems last week, too. Pull requests are
> more convenient with the exc
Reviewboard was giving Mark problems last week, too. Pull requests are more
convenient with the exception that they send emails on every comment,
rather than buffering them until you submit the review. One of the Github's
oldest outstanding requests, etc. etc.
Braden
On Wed, Nov 20, 2013
Hello,
Can somebody please review these two documentation pull requests?
https://github.com/apache/cordova-docs/pull/140
https://github.com/apache/cordova-docs/pull/149
I'd like to merge them pretty soon - I guess I can do this on my own based
on silent consensus.
Also, I tried to us
Naik Thanks for all this contributions and bringing a new
>>platform
>> >>>to
>> >>> >>the
>> >>> >> Cordova Family !
>> >>> >>
>> >>> >> I will recommend to take a look at the following if you have not
>> &
t Generation Test Plugin Structure: (branch cdv-test pre plugin)
> >>> >> Look in each individual plugin repo for a branch "cdv-test" like
> >>> >> https://github.com/apache/cordova-plugin-contacts/tree/cdvtest
> >>> >> Not all plugins
>> >>
>>> >> Mobile Spec: Our current generation test framework App with
>>>automated
>>> >>and
>>> >> manual tests.
>>> >> https://github.com/apache/cordova-mobile-spec
>>> >>
>>> >>
>
he
> > >> >> Cordova Family !
> > >> >>
> > >> >> I will recommend to take a look at the following if you have not
> > >> already
> > >> >> done so.
> > >> >>
> > >> >> Mobile Spec: Ou
ady
> >> >> done so.
> >> >>
> >> >> Mobile Spec: Our current generation test framework App with automated
> >> >>and
> >> >> manual tests.
> >> >> https://github.com/apache/cordova-mobile-spec
> >> >>
&
>> >>
>> >> Next Generation Test Framework: (branch cdv-test)
>> >> https://github.com/apache/cordova-labs/tree/cdvtest
>> >>
>> >>
>> >> Next Generation Test Plugin Structure: (branch cdv-test pre plugin)
>> >> Loo
t; >> Next Generation Test Plugin Structure: (branch cdv-test pre plugin)
> >> Look in each individual plugin repo for a branch "cdv-test" like
> >> https://github.com/apache/cordova-plugin-contacts/tree/cdvtest
> >> Not all plugins are ported yet, (help is
ps://github.com/apache/cordova-plugin-contacts/tree/cdvtest
>> Not all plugins are ported yet, (help is always appreciated :-) )
>>
>> --Carlos
>>
>>
>>
>>
>>
>>
>> On Fri, Nov 15, 2013 at 5:01 PM, Joe Bowser wrote:
>>
>>> Exce
ext Generation Test Plugin Structure: (branch cdv-test pre plugin)
>> Look in each individual plugin repo for a branch "cdv-test" like
>> https://github.com/apache/cordova-plugin-contacts/tree/cdvtest
>> Not all plugins are ported yet, (help is always appreciated :-)
yet, (help is always appreciated :-) )
>
> --Carlos
>
>
>
>
>
>
> On Fri, Nov 15, 2013 at 5:01 PM, Joe Bowser wrote:
>
>> Excellent! Thanks for sending the pull requests.
>> On Nov 15, 2013 1:34 PM, "Naik, Archana" wrote:
>>
>> > H
n-contacts/tree/cdvtest
Not all plugins are ported yet, (help is always appreciated :-) )
--Carlos
On Fri, Nov 15, 2013 at 5:01 PM, Joe Bowser wrote:
> Excellent! Thanks for sending the pull requests.
> On Nov 15, 2013 1:34 PM, "Naik, Archana" wrote:
>
> > Hello,
Excellent! Thanks for sending the pull requests.
On Nov 15, 2013 1:34 PM, "Naik, Archana" wrote:
> Hello, Devs
>
> As you guys know, I am working on cordova amazon-fireos platform port. I
> have made changes in CLI, core plug-ins and plugman repos to add
> amazon-fire
list of repos and pull request URLS.
Cordova-amazon-fireos
Github url : https://github.com/archananaik/cordova-amazon-fireos
Cordova-amazon-fireos repository has master, Cordova-3.1.x and 3.0.x branches
that I would like to be imported to apache cordova-amazon-fireos repo.
Pull requests
CLI
Hi all,
That's right, my name is Meina Liu :)
Best Regards!
On 2013-8-20, at 上午4:10, Max Woghiren wrote:
> I believe it's Meina Liu—the confirmation was sent on June 3rd.
>
> I'll pull these changes in.
>
> On Mon, Aug 19, 2013 at 4:07 PM, Andrew Grieve wrote:
t; > pull request:
> > https://github.com/apache/cordova-mobile-spec/pull/37/commits
> >
> >
> > repo:cordova-plugin-file
> >
> > pull request:
> > https://github.com/apache/cordova-plugin-file/pull/3/commits
> >
> >
> > I would really appreciate your time in reviewing my pull requests.
> >
> > FYI: I have signed ICLA earlier.
> >
> >
> > Best Regards!
> >
> >
> >
> >
>
ithub.com/apache/cordova-mobile-spec/pull/37/commits
>
>
> repo:cordova-plugin-file
>
> pull request:
> https://github.com/apache/cordova-plugin-file/pull/3/commits
>
>
> I would really appreciate your time in reviewing my pull requests.
>
> FYI: I have signed ICLA earlier.
>
>
> Best Regards!
>
>
>
>
://github.com/apache/cordova-plugin-file/pull/3/commits
I would really appreciate your time in reviewing my pull requests.
FYI: I have signed ICLA earlier.
Best Regards!
Alright good enough for me. Leaving it for 2.9.0
On Mon, May 27, 2013 at 12:58 PM, Andrew Grieve wrote:
> They would require writing and upgrade script for. I don't think it's worth
> cherry-picking though since they aren't really fixing anything.
>
>
> On Mon, May 27, 2013 at 2:38 PM, Shazron
They would require writing and upgrade script for. I don't think it's worth
cherry-picking though since they aren't really fixing anything.
On Mon, May 27, 2013 at 2:38 PM, Shazron wrote:
> I think these two issues are medium risk to put into 2.8.0. What do you
> think?
>
> Wrong Linker Flag fo
I think these two issues are medium risk to put into 2.8.0. What do you
think?
Wrong Linker Flag for project template
https://issues.apache.org/jira/browse/CB-3507
requiring all_load linker flag is bad practice and breaks other SDKs with
Objective-C categories
https://issues.apache.org/jira/brows
I think that what went wrong in this case is that there was an issue
created, but not referenced by the commit description. I've since made a
habit of re-writing the commit descriptions to include issue numbers.
I'll update the pull request instructions on the wiki (
http://wiki.apache.org/cordova
+1 seems reasonable
On Sat, May 4, 2013 at 1:49 AM, Tommy-Carlos Williams wrote:
> +1
>
> Especially for this part:
>
> On 04/05/2013, at 8:47 AM, Joe Bowser wrote:
>
> > Make sure that there's a JIRA issue so that we can re-open the
> > issue if we have to revert it for some reason
>
>
>
1 - 100 of 111 matches
Mail list logo
