Re: Android's new Whitelist Plugins

2015-03-03 Thread Michal Mocny
My thoughts: - The split between , , and : Like it a lot. - I think the defaults *for the plugin* are very reasonable. However, we may want to provide a default set of tags for the hello world app. A year or so ago we added a default access * whitelist and I think maybe we should continue that.

Re: Android's new Whitelist Plugins

2015-03-03 Thread Michal Mocny
..taking a look at the cli create.js script, we would need to update it a bit to actually have it import a hello-world config.xml. The lib actually ships the template config.xml right now instead of the hello-world project, which seems unnecessary given our --copy-from/--link-to import logic. Seem

Re: Android's new Whitelist Plugins

2015-03-03 Thread Andrew Grieve
Like your ideas a lot. Updating the project template makes a lot of sense. Tried to make it clear in the README, so if any part was not clear please fix it. But, the CSP tag is the more important bit, since can't actually block all requests. The only reason to even leave in there is to support p

Re: Android's new Whitelist Plugins

2015-03-03 Thread Michal Mocny
Ah, the bit about being mostly useful for pre-kitkat was context I was missing. Seems important to note at the start of the section. I'll update the README. On Tue, Mar 3, 2015 at 1:02 PM, Andrew Grieve wrote: > Like your ideas a lot. Updating the project template makes a lot of sense. > > Tr

Re: Android's new Whitelist Plugins

2015-03-03 Thread Michal Mocny
(Added this note: https://github.com/apache/cordova-plugins/commit/3ed17046ea7efaeccda4c4ffe82bb351e8b966f1, let me know if its inacurate). -Michal On Tue, Mar 3, 2015 at 1:06 PM, Michal Mocny wrote: > Ah, the bit about being mostly useful for pre-kitkat was context > I was missing. Seems imp

Re: Android's new Whitelist Plugins

2015-03-03 Thread Michal Mocny
I've filed a JIRA issue with my thoughts on how to approach this: https://issues.apache.org/jira/browse/CB-8597 On Tue, Mar 3, 2015 at 1:02 PM, Andrew Grieve wrote: > Like your ideas a lot. Updating the project template makes a lot of sense. > > Tried to make it clear in the README, so if any pa

RE: Android's new Whitelist Plugins

2015-03-03 Thread Nikhil Khandelwal
l Message- From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal Mocny Sent: Tuesday, March 3, 2015 11:22 AM To: dev Subject: Re: Android's new Whitelist Plugins I've filed a JIRA issue with my thoughts on how to approach this: https://issues.apache.org/jira/browse/C

Re: Android's new Whitelist Plugins

2015-03-04 Thread Ian Clelland
s all of them need to include this > plugin to have any network access work. > > Thanks, > Nikhil > > > -Original Message- > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal > Mocny > Sent: Tuesday, March 3, 2015 11:22 AM > To: dev > Su

Re: Android's new Whitelist Plugins

2015-03-04 Thread Michal Mocny
downstream CLIs as well - as all of them need to include this > > plugin to have any network access work. > > > > Thanks, > > Nikhil > > > > > > -Original Message- > > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal > >

Re: Android's new Whitelist Plugins

2015-03-04 Thread Jesse
ates in > IDEs > > > and other downstream CLIs as well - as all of them need to include this > > > plugin to have any network access work. > > > > > > Thanks, > > > Nikhil > > > > > > > > > -Original Message- > &g

RE: Android's new Whitelist Plugins

2015-03-04 Thread Nikhil Khandelwal
n the migration guide from Android 3.x to 4.0. Thanks, Nikhil -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Wednesday, March 4, 2015 11:05 AM To: dev@cordova.apache.org Subject: Re: Android's new Whitelist Plugins I like the defaults as discussed, regardless o

Re: Android's new Whitelist Plugins

2015-03-04 Thread Andrew Grieve
se changes should also be documented in the > migration guide from Android 3.x to 4.0. > > Thanks, > Nikhil > > > -Original Message- > From: Jesse [mailto:purplecabb...@gmail.com] > Sent: Wednesday, March 4, 2015 11:05 AM > To: dev@cordova.apache.org > Subject: R

Re: Android's new Whitelist Plugins

2015-03-04 Thread Andrew Grieve
way to warn devs to refer >> them to use this plugin. These changes should also be documented in the >> migration guide from Android 3.x to 4.0. >> >> Thanks, >> Nikhil >> >> >> -Original Message- >> From: Jesse [mailto:purplecabb...@gmail.

Re: Android's new Whitelist Plugins

2015-03-04 Thread Michal Mocny
refer > >> them to use this plugin. These changes should also be documented in the > >> migration guide from Android 3.x to 4.0. > >> > >> Thanks, > >> Nikhil > >> > >> > >> -Original Message- > >> From: Jesse [mailto:pur

Re: Android's new Whitelist Plugins

2015-03-05 Thread Andrew Grieve
; > > policy is no longer in effect, and it is a true whitelist >> >> > > (block-by-default) >> >> > > >> >> > > My biggest concern with this is that developers are going to >> blindly >> >> > update >> >>

Re: Android's new Whitelist Plugins

2015-03-05 Thread Jesse
gt; wrote: > >> > > >> >> I like Ian's proposal of blocking network access only when a > whitelist > >> >> plugin is added to do so and is choosing to override the default > >> behavior. > >> >> > >> >> Scanning config

Re: Android's new Whitelist Plugins

2015-03-11 Thread Andrew Grieve
015 at 7:54 PM, Nikhil Khandelwal < > > >> nikhi...@microsoft.com> > > >> > wrote: > > >> > > > >> >> I like Ian's proposal of blocking network access only when a > > whitelist > > >> >> plugin is added to do so

Re: Android's new Whitelist Plugins

2015-03-11 Thread Steven Gill
gt; > >> > > > > >> > > > > >> > > > > >> > > > > >> > On Wed, Mar 4, 2015 at 7:54 PM, Nikhil Khandelwal < > > > >> nikhi...@microsoft.com> > > > >> > wrote: > > > >>

Re: Android's new Whitelist Plugins

2015-03-11 Thread Andrew Grieve
gt; > > pretty > > > > >> > quickly. We should also be very clear in the release notes and > > > upgrade > > > > >> > guide. > > > > >> > > > > > >> > > > > > >> > > > > >