of
> > > cordova core plugins where we always have callbacks first and then call
> > > parameters.
> > >
> > > The important note is that I used special check for the args type to
> work
> > > correctly in case old method signature is used. I will see
rectly in case old method signature is used. I will see when it was
> > missed.
> >
> > Do you like the idea of changing method signature and making it work for
> > old version or it is better just to revert it back? - Thoughts?
> >
> > Thx!
> > Sergey
> > ---
ge-
> From: Carlos Santana [mailto:csantan...@gmail.com]
> Sent: Tuesday, June 24, 2014 11:55 PM
> To: dev@cordova.apache.org
> Subject: Re: Contacts API, iOS
>
> I took a few minutes to look deeper on what's going on with Contacts
> Plugin.
>
@cordova.apache.org
Subject: Re: Contacts API, iOS
I took a few minutes to look deeper on what's going on with Contacts Plugin.
Here are my findings:
Back in April [1] when navigator.contacts.pickContact() was added the signature
for navigator.contacts.find() was changed
From:
navigator.contacts.find:fun
Behalf Of Andrew
> Grieve
> Sent: Monday, June 23, 2014 9:42 PM
> To: dev
> Subject: Re: Contacts API, iOS
>
> Yes - meant plugins registry.
>
> right now the plugin links point to github, so you always see master
>
> I don't think we should concern ourselves with cor
will it be
> corrected?
> (Not trying to be pushy, just want to make sure I explain it well to
> others if asked. :)
>
>
>
> From: Carlos Santana
> Sent: Saturday, June 21, 2014 12:09 PM
> To: dev@cordova.apache.org
> Subject: R
ted?
> (Not trying to be pushy, just want to make sure I explain it well to others
> if asked. :)
>
>
>
> From: Carlos Santana
> Sent: Saturday, June 21, 2014 12:09 PM
> To: dev@cordova.apache.org
> Subject: Re: Contacts API, iOS
&
ll to others if asked. :)
From: Carlos Santana
Sent: Saturday, June 21, 2014 12:09 PM
To: dev@cordova.apache.org
Subject: Re: Contacts API, iOS
Andrew plugins are not in npm, did you meant the plugin registry.
Then yes I agree that way user can read the docs
e out what really happened though? Maybe a PR with the
> updated
> > doc, but not the plugin, accidentally got accepted?
> >
> >
> > From: Mike Billau >
> > Sent: Friday, June 20, 2014 2:06 PM
> > To: dev@cordova.apa
ccidentally got accepted?
>
>
> From: Mike Billau
> Sent: Friday, June 20, 2014 2:06 PM
> To: dev@cordova.apache.org
> Subject: Re: Contacts API, iOS
>
> Just noticed this an hour ago as well. On Android, pickContact just doesn't
> do anything, but some other pe
, accidentally got accepted?
From: Mike Billau
Sent: Friday, June 20, 2014 2:06 PM
To: dev@cordova.apache.org
Subject: Re: Contacts API, iOS
Just noticed this an hour ago as well. On Android, pickContact just doesn't
do anything, but some other peopl
gt; From: mmo...@google.com on behalf of Michal Mocny <
> mmo...@chromium.org>
> Sent: Friday, June 20, 2014 1:36 PM
> To: Michal Mocny
> Cc: dev
> Subject: Re: Contacts API, iOS
>
> As far as the API documentation, and why iOS has a different interface.. I
> don'
or this to "officially" land.
From: mmo...@google.com on behalf of Michal Mocny
Sent: Friday, June 20, 2014 1:36 PM
To: Michal Mocny
Cc: dev
Subject: Re: Contacts API, iOS
As far as the API documentation, and why iOS has a different interface.. I
do
As far as the API documentation, and why iOS has a different interface.. I
don't know the history, but this seems mighty confusing. I think contacts
plugin has been in need of some love for quite a while, but its been hard
to get anyone excited about it.
-Michal
On Fri, Jun 20, 2014 at 2:30 PM,
Alright, sorry I got confused reading the history because of some
fast-forward merges.
Seems all is well in the repo -- but the last plugins release Steven held
back contacts due to failing tests, hence whats up on plugins.cordova.io
being so stale.
-Michal
On Fri, Jun 20, 2014 at 2:23 PM, Mich
That may not be right at all. Something seems fishy at first glance, but
its hard to track the history. Ian and I are looking at it.
On Fri, Jun 20, 2014 at 2:18 PM, Michal Mocny wrote:
> Looks like the last release was based on dev branch (
> https://github.com/apache/cordova-plugin-contacts
Looks like the last release was based on dev branch (
https://github.com/apache/cordova-plugin-contacts/blob/55ba3f2580d2c3bbd1662f49d89043710446220a/www/contacts.js),
which was closed, but maybe wasn't merged in to master?
-Michal
On Fri, Jun 20, 2014 at 2:10 PM, Ray Camden wrote:
> Ok, so...
Ok, so doing
cordova plugin add org.apache.cordova.contacts
brings in org.apache.cordova.contacts/www/contacts.js that does NOT match what
I'm seeing in
https://github.com/apache/cordova-plugin-contacts/blob/master/www/contacts.js,
which was last updated *2* months ago.
Any ideas?
_
18 matches
Mail list logo
