Github user eymorale closed the pull request at:
https://github.com/apache/cordova-lib/pull/189
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
7:20 AM
To: dev@cordova.apache.org
Subject: Re: 'cordova plugin save' should also save plugin versions
Definitely agree with alignment with npm's save! :D
On Tue, Mar 24, 2015 at 1:46 PM, Nikhil Khandelwal
nikhi...@microsoft.com
wrote:
I'm in favor of alignment
I'd like to get input on how 'cordova platform save' and 'cordova plugin save'
commands (that save information about all installed platforms or plugins to
config.xml) should work with regard to modifying existing version information
in config.xml.
(Background: I'm updating the --save option
: 'cordova plugin save' should also save plugin versions
+1 for making the shrinkwrap as the default for the save.
This makes sure the users will restore the same version they saved
before.
Byoungro So
SSG / DPD / Mobile Computing and Compilers Intel Corporation
On 3/24/15, 12
, 2015 7:20 AM
To: dev@cordova.apache.org
Subject: Re: 'cordova plugin save' should also save plugin versions
Definitely agree with alignment with npm's save! :D
On Tue, Mar 24, 2015 at 1:46 PM, Nikhil Khandelwal nikhi...@microsoft.com
wrote:
I'm in favor of alignment of 'plugin save' behavior
25, 2015 7:20 AM
To: dev@cordova.apache.org
Subject: Re: 'cordova plugin save' should also save plugin versions
Definitely agree with alignment with npm's save! :D
On Tue, Mar 24, 2015 at 1:46 PM, Nikhil Khandelwal
nikhi...@microsoft.com
wrote:
I'm in favor of alignment of 'plugin save
if they are not
explicitly shrinkwrapped.
As for CB-8733, cordova plugin save command can not save the version
information even if it had wanted to because fetch.json is missing that
information. It is a bug.
--
Gorkem
On Tue, Mar 24, 2015 at 11:29 AM, Raymond Camden raymondcam...@gmail.com
wrote
Currently, version info is not saved for plugins in the fetch.json. That
needs to be added so that plugin version can be saved in the config.xml. It
should follow what 'cordova platform save' does. I created a jira item for
this: https://issues.apache.org/jira/browse/CB-8733 and opened a pull
Ah yes. Looks like it.
Thanks,
Edna Morales
From: Raymond Camden raymondcam...@gmail.com
To: dev@cordova.apache.org
Date: 03/24/2015 11:30 AM
Subject:Re: 'cordova plugin save' should also save plugin versions
Is that a dupe of https://issues.apache.org/jira/browse/CB-8594
this change while I'm there.
Sure, go ahead. I would not be able to get to it until next week.
From: Steven Gill [stevengil...@gmail.com]
Sent: Wednesday, March 25, 2015 7:20 AM
To: dev@cordova.apache.org
Subject: Re: 'cordova plugin save' should
next week.
From: Steven Gill [stevengil...@gmail.com]
Sent: Wednesday, March 25, 2015 7:20 AM
To: dev@cordova.apache.org
Subject: Re: 'cordova plugin save' should also save plugin versions
Definitely agree with alignment with npm's save! :D
to the latest possible version available if they are not
explicitly shrinkwrapped.
How about doing what npm does, and always save the version, but save
it as
^1.0.3, so that you still get updates, but not major version
changes?
As for CB-8733, cordova plugin save command can not save the
version
version available if they are not
explicitly shrinkwrapped.
How about doing what npm does, and always save the version, but save
it as
^1.0.3, so that you still get updates, but not major version
changes?
As for CB-8733, cordova plugin save command can not save the
version
information even
Is that a dupe of https://issues.apache.org/jira/browse/CB-8594?
On Tue, Mar 24, 2015 at 10:19 AM, Edna Y Morales eymor...@us.ibm.com wrote:
Currently, version info is not saved for plugins in the fetch.json. That
needs to be added so that plugin version can be saved in the config.xml. It
PM
To: dev@cordova.apache.org
Subject: Re: 'cordova plugin save' should also save plugin versions
+1 for making the shrinkwrap as the default for the save.
This makes sure the users will restore the same version they saved before.
Byoungro So
SSG / DPD / Mobile Computing and Compilers Intel
, cordova plugin save command can not save the version
information even if it had wanted to because fetch.json is missing that
information. It is a bug.
--
Gorkem
On Tue, Mar 24, 2015 at 11:29 AM, Raymond Camden raymondcam...@gmail.com
wrote:
Is that a dupe of https://issues.apache.org/jira
option does that.
-Nikhil
-Original Message-
From: So, Byoungro [mailto:byoungro...@intel.com]
Sent: Tuesday, March 24, 2015 12:40 PM
To: dev@cordova.apache.org
Subject: Re: 'cordova plugin save' should also save plugin versions
+1 for making the shrinkwrap as the default
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/178
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26284601
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -278,9 +283,16 @@ module.exports = function plugin(command, targets,
opts) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26284603
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -295,14 +307,87 @@ module.exports = function plugin(command, targets,
opts) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26284597
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -234,7 +239,6 @@ module.exports = function plugin(command, targets,
opts) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26284609
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -144,7 +144,10 @@ function fetchPlugin(plugin_src, plugins_dir, options)
{
});
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26284638
--- Diff: cordova-lib/src/plugman/util/metadata.js ---
@@ -59,3 +59,10 @@ exports.save_fetch_metadata = function(pluginsDir,
pluginId, data) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26284598
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -267,7 +271,8 @@ module.exports = function plugin(command, targets,
opts) {
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/178#issuecomment-78182770
Thanks for raising this issue, @gorkem. I just pushed some changes to
handle `dependent` plugins and only save `top-level` plugins in config.xml.
---
If your
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26058485
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -134,7 +135,7 @@ module.exports = function plugin(command, targets,
opts) {
Github user gorkem commented on the pull request:
https://github.com/apache/cordova-lib/pull/178#issuecomment-77955805
I think this saves **all** the installed plugins to config.xml. The
dependency plugins ( those plugins that were installed as a dependency of
another) should never
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/178#issuecomment-77955992
Interesting. @gorkem, could you give an example of a plugin that has
dependency plugins ? I'll carry some testing regarding that.
---
If your project is set up for
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26082685
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -284,6 +284,11 @@ module.exports = function plugin(command, targets,
opts) {
Github user gorkem commented on the pull request:
https://github.com/apache/cordova-lib/pull/178#issuecomment-77956329
I was just testing com.ibm.mobile.cordova.ibmpush for something else which
seems to pull in another large plugin
---
If your project is set up for it, you can reply
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-lib/pull/178
CB-8521 `cordova plugin save` should save all installed plugins and their
version/git-url/folder-location into config.xml
CB-8521 `cordova plugin save` should save all installed plugins
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/178#issuecomment-77661119
@vladimir-kotikov , please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
*To:* dev
*Cc:* Treggiari, Leo
*Subject:* Re: cordova plugin save
Summarizing / simplifying since this thread has run away:
Run-time Platform-specific config:
- Automatically created on prepare from a combination of initial
application template and many project properties
Sent: Monday, August 18, 2014 5:53 AM
To: Treggiari, Leo
Cc: Michal Mocny; dev
Subject: Re: cordova plugin save
On Fri, Aug 15, 2014 at 10:29 PM, Treggiari, Leo leo.treggi...@intel.com
wrote:
I have a few follow-on questions / comments:
Run-time Platform-specific config:
- Automatically
?
-Original Message-
From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal
Mocny
Sent: Monday, August 18, 2014 5:53 AM
To: Treggiari, Leo
Cc: Michal Mocny; dev
Subject: Re: cordova plugin save
On Fri, Aug 15, 2014 at 10:29 PM, Treggiari, Leo leo.treggi...@intel.com
In order to keep the plugins as project deps in package.json we need to
sort out some details of treating plugins as npm packages first:
1) Plugins don't currently have package.json files, and list their deps in
plugin.xml.
2) Are we ok with loosing the possibility of specifying platform specific
We don't have to make plugins a package.json thing…we could do that latter.
If we do choose to use package.json highly likely we'll need to reserve a
key for our 'namespace'. Perhaps cordova. That key could have whatever we
want in it (such as mapping our current config.xml properties/values).
On Mon, Aug 18, 2014 at 5:58 PM, Brian LeRoux b...@brian.io wrote:
We don't have to make plugins a package.json thing…we could do that latter.
If we do choose to use package.json highly likely we'll need to reserve a
key for our 'namespace'. Perhaps cordova. That key could have whatever we
ya this too…again we should save moving plugins to npm for a later date…the
problems there aren't ones we have and the reuse symmetry being craved here
is already in place given we re-used most of npm's arch and modules…
On Mon, Aug 18, 2014 at 6:03 PM, Andrew Grieve agri...@chromium.org wrote:
: RE: cordova plugin save
Hi Chuck,
Thanks for adding the other 'app metadata file' (like AndroidManifest.xml
or package.appxmanifest.xml.) to the conversation. It's important to
consider that as well. Those are somewhat different because they contain
information that is not built
...@google.com [mailto:mmo...@google.com] On Behalf Of Michal Mocny
Sent: Thursday, August 14, 2014 5:53 AM
To: dev
Cc: Treggiari, Leo
Subject: Re: cordova plugin save
Summarizing / simplifying since this thread has run away:
Run-time Platform-specific config:
- Automatically created on prepare from
sources that were in
the project that was 'save'd? Does it need to?
Thanks,
Leo
-Original Message-
From: Chuck Lantz [mailto:cla...@microsoft.com]
Sent: Wednesday, August 13, 2014 3:58 PM
To: dev@cordova.apache.org; Treggiari, Leo
Subject: RE: cordova plugin save
My two cents
: RE: cordova plugin save
Hi Chuck,
Thanks for adding the other 'app metadata file' (like
AndroidManifest.xml or package.appxmanifest.xml.) to the conversation.
It's important to consider that as well. Those are somewhat different
because they contain information that is not built
On Tue, Aug 12, 2014 at 09:36:34PM -0400, Andrew Grieve wrote:
On Tue, Aug 12, 2014 at 6:43 PM, Gorkem Ercan gorkem.er...@gmail.com
wrote:
Just returning from PTO, great timing :)
:)
On Tue, Aug 12, 2014 at 04:06:14PM -0400, Andrew Grieve wrote:
Played around with it and it's
...@google.com] On Behalf Of Michal
Mocny
Sent: Tuesday, August 12, 2014 1:34 PM
To: dev
Cc: Gorkem Ercan
Subject: Re: Feedback on cordova plugin save friends
plugin is nice, but why not just dependency as plugin.xml already
uses?
config.xml and plugin.xml share lots of tags already
we are bound with what CLI can
support.
-Chuck
-Original Message-
From: Parashuram Narasimhan (MS OPEN TECH)
Sent: Tuesday, August 12, 2014 4:05 PM
To: dev@cordova.apache.org; Chuck Lantz
Subject: RE: Feedback on cordova plugin save friends
Given that we are looking
I'm new to this mailing list. I work on the Intel(r) XDK which is another IDE
which supports the creation of hybrid apps using Cordova plugins.
I'm having trouble figuring out what the proposed 'cordova plugin save' command
does. Is there an up-to-date 'spec' that explains the goals
that was added is fixed until the user explicitly
removes and re-adds it. Is 'cordova plugin save' 'restore' suggesting a
new version management model? E.g. if I add a plugin without a specific
version suffix and 'restore' it later, I may not get the same version,
right
and contributing something like it.
-Chuck
-Original Message-
From: Gorkem Ercan [mailto:gorkem.er...@gmail.com]
Sent: Wednesday, August 13, 2014 3:37 AM
To: dev@cordova.apache.org
Cc: Parashuram Narasimhan (MS OPEN TECH)
Subject: Re: Feedback on cordova plugin save friends
On Wed, Aug 13, 2014 at 01
the creation of hybrid apps using Cordova plugins.
I'm having trouble figuring out what the proposed 'cordova plugin save'
command does. Is there an up-to-date 'spec' that explains the goals of the
command and the implementation?
A couple of things that I have read in the mailing list
trouble figuring out what the proposed 'cordova plugin save'
command does. Is there an up-to-date 'spec' that explains the goals of
the
command and the implementation?
A couple of things that I have read in the mailing list concern me.
There is mention of saving information
To: Treggiari, Leo
Cc: dev@cordova.apache.org
Subject: Re: cordova plugin save
On Wed, Aug 13, 2014 at 6:07 PM, Treggiari, Leo leo.treggi...@intel.com
wrote:
Hi Michal,
Thanks for your answers. They were quite helpful. I have a few
follow-ups.
With your answers, and references, and I
? Does it need to?
Thanks,
Leo
-Original Message-
From: Chuck Lantz [mailto:cla...@microsoft.com]
Sent: Wednesday, August 13, 2014 3:58 PM
To: dev@cordova.apache.org; Treggiari, Leo
Subject: RE: cordova plugin save
My two cents - there are three things here:
1. App metadata
2. Project
Played around with it and it's pretty clear to me that the ability to
record your plugins platforms in config.xml is a big step up.
I do have some specific comments about the current design though:
- Right now the plugin save saves all plugins to config.xml rather than
just explicitly-installed
plugin is nice, but why not just dependency as plugin.xml already uses?
config.xml and plugin.xml share lots of tags already, why fork here?
-Michal
On Tue, Aug 12, 2014 at 4:06 PM, Andrew Grieve agri...@google.com wrote:
Played around with it and it's pretty clear to me that the ability to
Just returning from PTO, great timing :)
On Tue, Aug 12, 2014 at 04:06:14PM -0400, Andrew Grieve wrote:
Played around with it and it's pretty clear to me that the ability to
record your plugins platforms in config.xml is a big step up.
I do have some specific comments about the current
PM
To: dev
Cc: Gorkem Ercan
Subject: Re: Feedback on cordova plugin save friends
plugin is nice, but why not just dependency as plugin.xml already uses?
config.xml and plugin.xml share lots of tags already, why fork here?
-Michal
On Tue, Aug 12, 2014 at 4:06 PM, Andrew Grieve agri
.
-Original Message-
From: Gorkem Ercan [mailto:gorkem.er...@gmail.com]
Sent: Tuesday, August 12, 2014 3:59 PM
To: Chuck Lantz
Cc: dev@cordova.apache.org
Subject: Re: Feedback on cordova plugin save friends
On Tue, Aug 12, 2014 at 08:40:25PM +, Chuck Lantz wrote:
+1
That same pattern
Results in:
cdv:engine id=android version=3.6.0-dev /
-Chuck
-Original Message-
From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal
Mocny
Sent: Tuesday, August 12, 2014 1:34 PM
To: dev
Cc: Gorkem Ercan
Subject: Re: Feedback on cordova plugin save
on cordova plugin save friends
Given that we are looking at decoupling engine and platform releases, there
should be ways to specify them separately, right ? In this case, I am assuming
it is basically version of cordova-cli/cordova-lib and the platform, assuming
that cordova-cli can work with older
On Tue, Aug 12, 2014 at 6:43 PM, Gorkem Ercan gorkem.er...@gmail.com
wrote:
Just returning from PTO, great timing :)
:)
On Tue, Aug 12, 2014 at 04:06:14PM -0400, Andrew Grieve wrote:
Played around with it and it's pretty clear to me that the ability to
record your plugins platforms in
61 matches
Mail list logo
