[jira] [Commented] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

[ https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13158338#comment-13158338 ] Filipe Manana commented on COUCHDB-1289: Bob, +1. You did most of the hard work,

[jira] [Commented] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

[ https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13158378#comment-13158378 ] Filipe Manana commented on COUCHDB-1289: (Jira messed up with the patch

[jira] [Commented] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

[ https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13158376#comment-13158376 ] Filipe Manana commented on COUCHDB-1289: Bob, just caught another case where the

[jira] [Commented] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

[ https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13158030#comment-13158030 ] Bob Dionne commented on COUCHDB-1289: - I think this is correct, I certainly agree

[jira] [Commented] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

[ https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13157464#comment-13157464 ] Filipe Manana commented on COUCHDB-1289: Looks good Bob, only a small regression

[jira] [Commented] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

[ https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13157473#comment-13157473 ] Bob Dionne commented on COUCHDB-1289: - Thanks for the review Filipe. I pushed your

[jira] [Commented] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

[ https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13157615#comment-13157615 ] Bob Dionne commented on COUCHDB-1289: - Add etap test for this last case[1] [1]

[jira] [Commented] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

[ https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13156641#comment-13156641 ] Bob Dionne commented on COUCHDB-1289: - Filipe, Ah, thanks, it looks like

[jira] [Commented] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

[ https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155811#comment-13155811 ] Filipe Manana commented on COUCHDB-1289: Bob, np. Looking at the whole context,

[jira] [Commented] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

[ https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155246#comment-13155246 ] Filipe Manana commented on COUCHDB-1289: Bob looks good. Just have a few

[jira] [Commented] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

[ https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155261#comment-13155261 ] Bob Dionne commented on COUCHDB-1289: - Filipe, thanks for the comments: 3. It took

[jira] [Commented] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

[ https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155273#comment-13155273 ] Filipe Manana commented on COUCHDB-1289: Bob, for the indentation we have those

[jira] [Commented] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

[ https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155283#comment-13155283 ] Bob Dionne commented on COUCHDB-1289: - Filipe, I've seen these guidelines. I

[jira] [Commented] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

[ https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155293#comment-13155293 ] Filipe Manana commented on COUCHDB-1289: Bob, the thing about the if is that the

[jira] [Commented] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

[ https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155370#comment-13155370 ] Bob Dionne commented on COUCHDB-1289: - cool, I'll fix it.

[jira] [Commented] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

[ https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155469#comment-13155469 ] Bob Dionne commented on COUCHDB-1289: - Filipe, Sorry to be dense about this, but

[jira] [Commented] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

[ https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154769#comment-13154769 ] Bob Dionne commented on COUCHDB-1289: - Added a failing etap test for this[1] [1]

[jira] [Commented] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

[ https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13108477#comment-13108477 ] Filipe Manana commented on COUCHDB-1289: Good finding Bob. What about using a

[jira] [Commented] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results

[ https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13108065#comment-13108065 ] Paul Joseph Davis commented on COUCHDB-1289: There are two aspects to this