[jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-05-30 Thread Jiajia Li (JIRA)
[ https://issues.apache.org/jira/browse/DIRKRB-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307113#comment-15307113 ] Jiajia Li commented on DIRKRB-542: -- bq. would you help address it as follow-on if you find any issue to

RE: [jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-05-29 Thread Zheng, Kai
in authorization domain!! Regards, Kai -Original Message- From: Zheng, Kai [mailto:kai.zh...@intel.com] Sent: Friday, May 27, 2016 8:41 PM To: Apache Directory Developers List <dev@directory.apache.org> Subject: RE: [jira] [Commented] (DIRKRB-542) Kerby Authorization Great discu

[jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-05-29 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/DIRKRB-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15306071#comment-15306071 ] Kai Zheng commented on DIRKRB-542: -- Per the discussion in mailing list, I committed this to trunk with

RE: [jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-05-27 Thread Zheng, Kai
<dev@directory.apache.org> Subject: Re: [jira] [Commented] (DIRKRB-542) Kerby Authorization Le 26/05/16 à 04:17, Richard Feezel a écrit : > Kai, > > I recall that the Kerberos specifications indicate that empty lists > (sequences) should not be included in the ASN.1 encoded by

[jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-05-26 Thread Jiajia Li (JIRA)
[ https://issues.apache.org/jira/browse/DIRKRB-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301591#comment-15301591 ] Jiajia Li commented on DIRKRB-542: -- Thank you for the explanation. bq. This is related to the Asn1

[jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-05-26 Thread Jiajia Li (JIRA)
[ https://issues.apache.org/jira/browse/DIRKRB-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301589#comment-15301589 ] Jiajia Li commented on DIRKRB-542: -- Thank you for the explanation. bq. This is related to the Asn1

Re: [jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-05-25 Thread Emmanuel Lécharny
Le 26/05/16 à 04:17, Richard Feezel a écrit : > Kai, > > I recall that the Kerberos specifications indicate that empty lists > (sequences) should not be included in the ASN.1 encoded byte stream. Thus > the correct representation of items that are empty in object space is with > NULL, not with a

Re: [jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-05-25 Thread Richard Feezel
> > How do you think? Thanks again. > > > > Regards, > > Kai > > > > *From:* Richard Feezel [mailto:rfee...@gmail.com] > *Sent:* Thursday, May 26, 2016 2:26 AM > *To:* Apache Directory Developers List <dev@directory.apache.org> > *Subject:* Re:

Re: [jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-05-25 Thread Richard Feezel
There was a general problem with the ASN.1 decoding code prior to our patch. Objects were being created even though the corresponding (optional) tag never appeared in the ASN.1 byte stream being decoded. In the case of a SEQUENCE-OF an empty container was being created. This did not correctly

[jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-05-25 Thread Gerard Gagliano (JIRA)
[ https://issues.apache.org/jira/browse/DIRKRB-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299923#comment-15299923 ] Gerard Gagliano commented on DIRKRB-542: This is related to the Asn1 modifications. Items were

[jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-05-25 Thread Jiajia Li (JIRA)
[ https://issues.apache.org/jira/browse/DIRKRB-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299643#comment-15299643 ] Jiajia Li commented on DIRKRB-542: -- The update of the latest patch is great, with nice code format and

[jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-05-25 Thread Jiajia Li (JIRA)
[ https://issues.apache.org/jira/browse/DIRKRB-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299586#comment-15299586 ] Jiajia Li commented on DIRKRB-542: -- Thanks for the patch, but with some questions: 1. In

[jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-05-24 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/DIRKRB-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298245#comment-15298245 ] Kai Zheng commented on DIRKRB-542: -- Thanks Gerard for the update providing the tests. Would you combine

RE: [jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-04-04 Thread Zheng, Kai
ia...@intel.com] Sent: Tuesday, April 05, 2016 9:47 AM To: Apache Directory Developers List <dev@directory.apache.org> Cc: ke...@directory.apache.org Subject: RE: [jira] [Commented] (DIRKRB-542) Kerby Authorization Hi Gerard, I think this commit "https://github.

RE: [jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-04-04 Thread Li, Jiajia
-- From: Gerard Gagliano [mailto:gera...@prodentity.com] Sent: Tuesday, April 05, 2016 9:14 AM To: Apache Directory Developers List Cc: ke...@directory.apache.org Subject: Re: [jira] [Commented] (DIRKRB-542) Kerby Authorization Kai, That sounds good. Could you be specifiec what version to get.

Re: [jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-04-04 Thread Gerard Gagliano
esday, April 05, 2016 7:05 AM > To: Apache Directory Developers List <dev@directory.apache.org>; > ke...@directory.apache.org > Subject: RE: [jira] [Commented] (DIRKRB-542) Kerby Authorization > > Thanks for the sync up Gerard! > > We don't have concrete plan for RC3 yet. I'm

RE: [jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-04-04 Thread Zheng, Kai
] Sent: Tuesday, April 05, 2016 7:05 AM To: Apache Directory Developers List <dev@directory.apache.org>; ke...@directory.apache.org Subject: RE: [jira] [Commented] (DIRKRB-542) Kerby Authorization Thanks for the sync up Gerard! We don't have concrete plan for RC3 yet. I'm thinking that a

RE: [jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-04-04 Thread Zheng, Kai
ct: Re: [jira] [Commented] (DIRKRB-542) Kerby Authorization Kai, We are thinking about some additional stuff, but this is all we have done thus far. As for tests, Richard is putting some together. What time frame are you thinking for RC3? Also, are you aware of any Java code that can parse

Re: [jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-04-04 Thread Gerard Gagliano
Kai, We are thinking about some additional stuff, but this is all we have done thus far. As for tests, Richard is putting some together. What time frame are you thinking for RC3? Also, are you aware of any Java code that can parse MS-PAC? Thanks! g -- > On Apr 4, 2016, at 4:47 PM, Kai

[jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-04-04 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/DIRKRB-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225212#comment-15225212 ] Kai Zheng commented on DIRKRB-542: -- Is there any update? It can be a major thing for the next RC release.

[jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-04-01 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/DIRKRB-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221390#comment-15221390 ] Kai Zheng commented on DIRKRB-542: -- Great work! It would be good to add some unit tests. It's easy if

[jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-03-31 Thread Jiajia Li (JIRA)
[ https://issues.apache.org/jira/browse/DIRKRB-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221092#comment-15221092 ] Jiajia Li commented on DIRKRB-542: -- Great work, no tests failure and check style issues now. If you can

RE: [jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-03-31 Thread Li, Jiajia
Thanks Richard and Gerard for the quick changes, I will test the new patch soon. Regards, Jiajia From: Richard Feezel [mailto:rfee...@gmail.com] Sent: Thursday, March 31, 2016 7:50 PM To: Apache Directory Developers List Subject: Re: [jira] [Commented] (DIRKRB-542) Kerby Authorization I have

Re: [jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-03-31 Thread Richard Feezel
ards, > > Kai > > > > *From:* Richard Feezel [mailto:rfee...@gmail.com] > *Sent:* Thursday, March 31, 2016 11:51 AM > *To:* Apache Directory Developers List <dev@directory.apache.org> > *Subject:* Re: [jira] [Commented] (DIRKRB-542) Kerby Authorization > > &g

RE: [jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-03-31 Thread Zheng, Kai
ct: Re: [jira] [Commented] (DIRKRB-542) Kerby Authorization PersonnelRecordTest is indeed failing due to changes in Asn1CollectionType.java in the patch. Unfortunately we can't simply roll back the changes because the changes were made to address a problem with the decoding logic which resulted in

FW: [jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-03-31 Thread Zheng, Kai
Let’s discuss this in the Kerby space. Thanks. Regards, Kai From: Li, Jiajia [mailto:jiajia...@intel.com] Sent: Thursday, March 31, 2016 12:19 PM To: Apache Directory Developers List <dev@directory.apache.org> Subject: RE: [jira] [Commented] (DIRKRB-542) Kerby Authorization Run “mvn

RE: [jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-03-30 Thread Li, Jiajia
AM To: Apache Directory Developers List Subject: Re: [jira] [Commented] (DIRKRB-542) Kerby Authorization I don't believe ADAuthenticationIndicators, note the S at the end belongs. It was renamed to singular. On Wed, Mar 30, 2016 at 10:17 PM, Gerard Gagliano <gera...@prodentity.com<mailt

Re: [jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-03-30 Thread Richard Feezel
PersonnelRecordTest is indeed failing due to changes in Asn1CollectionType.java in the patch. Unfortunately we can't simply roll back the changes because the changes were made to address a problem with the decoding logic which resulted in adding default or empty values to the decoded object when

Re: [jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-03-30 Thread Richard Feezel
I don't believe ADAuthenticationIndicators, note the S at the end belongs. It was renamed to singular. On Wed, Mar 30, 2016 at 10:17 PM, Gerard Gagliano wrote: > There should not be any compilation issues, can you describe the errors? > > -- > > On Mar 30, 2016, at 7:44

Re: [jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-03-30 Thread Gerard Gagliano
There should not be any compilation issues, can you describe the errors? -- > On Mar 30, 2016, at 7:44 PM, Jiajia Li (JIRA) wrote: > > >[ >

[jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-03-30 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/DIRKRB-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219207#comment-15219207 ] Kai Zheng commented on DIRKRB-542: -- bq. Each line should not exceed 80 Note we don't enforce the rule

[jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-03-30 Thread Jiajia Li (JIRA)
[ https://issues.apache.org/jira/browse/DIRKRB-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219187#comment-15219187 ] Jiajia Li commented on DIRKRB-542: -- [~gg], thanks for your contribution, I think it will be new

[jira] [Commented] (DIRKRB-542) Kerby Authorization

2016-03-30 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/DIRKRB-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219100#comment-15219100 ] Kai Zheng commented on DIRKRB-542: -- Thanks [~Gerard Gagliano] a lot for this major contribution filling