Re: [dpdk-dev] [PATCH 01/11] examples/ipsec-secgw: updated MAINTAINERS file

2017-10-16 Thread De Lara Guarch, Pablo
Hi Aviad, > -Original Message- > From: Aviad Yehezkel [mailto:avia...@dev.mellanox.co.il] > Sent: Sunday, October 15, 2017 1:54 PM > To: dev@dpdk.org; Gonzalez Monroy, Sergio > ; De Lara Guarch, Pablo > ; avia...@mellanox.com > Cc: bor...@mellanox.com; akhil.go...@nxp.com; > hemant.agra...

[dpdk-dev] [PATCH] net/failsafe: improve stats accuracy

2017-10-16 Thread Matan Azrad
The stats_get API was changed to return error in case of failure at stats getting process time. By this way, failsafe can get stats snapshot in removal process for each PMD which can give stats after removal event. This patch implements ultimate stats snapshot on removal time by trying to get the

Re: [dpdk-dev] dev Digest, Vol 164, Issue 196

2017-10-16 Thread Jan Scheurich
> Date: Fri, 6 Oct 2017 14:40:15 +0800 > From: Yuanhan Liu > To: Jan Scheurich > Cc: "'dev@dpdk.org'" > Subject: Re: [dpdk-dev] [PATCH v3] vhost: Expose virtio interrupt need > on rte_vhost API > Message-ID: <20171006064015.GD1545@yliu-home> > Content-Type: text/plain; charset=us-ascii >

Re: [dpdk-dev] [PATCH 1/2] net/tap: fix indentation in flow file

2017-10-16 Thread Pascal Mazon
Hi, Sorry for the delay, I was on vacation. Nevermind this indent patch for now. Matan, could you integrate it (squashed) when you'll have a new patch modifying tap_flow.c? Thank you. Regards, Pascal On 05/10/2017 23:33, Ferruh Yigit wrote: > On 10/4/2017 6:26 PM, Ferruh Yigit wrote: >> On 10/

[dpdk-dev] [PATCH] doc: update mlx5 flow count limitations

2017-10-16 Thread Ori Kam
Signed-off-by: Ori Kam Acked-by: Shahaf Shuler --- doc/guides/nics/mlx5.rst |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index d24941a..80bcbd6 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.r

Re: [dpdk-dev] [PATCH] net/failsafe: improve stats accuracy

2017-10-16 Thread Gaëtan Rivet
Hey Matan, Thanks for the patch. Here are some remarks: On Mon, Oct 16, 2017 at 07:41:50AM +, Matan Azrad wrote: > The stats_get API was changed to return error in case of failure at > stats getting process time. > By this way, failsafe can get stats snapshot in removal process for > each PMD

Re: [dpdk-dev] [PATCH] pmd_virtio: Unchecked return value from library

2017-10-16 Thread Basierski, SebastianX
-Original Message- From: Basierski, SebastianX Sent: Friday, September 29, 2017 9:44 AM To: Tan, Jianfeng ; skh...@vmware.com Cc: dev@dpdk.org Subject: RE: [PATCH] pmd_virtio: Unchecked return value from library -Original Message- From: Tan, Jianfeng Sent: Wednesday, September

[dpdk-dev] [PATCH v2] doc: update mlx5 flow count limitations

2017-10-16 Thread Ori Kam
Signed-off-by: Ori Kam Acked-by: Shahaf Shuler --- doc/guides/nics/mlx5.rst |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index d24941a..7da5c87 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst

Re: [dpdk-dev] [PATCH] doc: fix highlight of bumped libs in release notes

2017-10-16 Thread Yang, Zhiyong
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Saturday, October 14, 2017 8:10 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] doc: fix highlight of bumped libs in release notes > > The libraries which have their ABI version increa

Re: [dpdk-dev] [PATCH v4 06/12] ethdev: support security APIs

2017-10-16 Thread Nicolau, Radu
Hi Shahaf, I will address the issues asap, they didn't made it into v4 because of timing reasons. Regards, Radu > -Original Message- > From: Shahaf Shuler [mailto:shah...@mellanox.com] > Sent: Sunday, October 15, 2017 2:13 PM > To: Akhil Goyal ; dev@dpdk.org > Cc: Doherty, Declan ; De L

Re: [dpdk-dev] [PATCH] net/failsafe: improve stats accuracy

2017-10-16 Thread Matan Azrad
Hi Geatan > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Monday, October 16, 2017 11:28 AM > To: Matan Azrad > Cc: dev@dpdk.org > Subject: Re: [PATCH] net/failsafe: improve stats accuracy > > Hey Matan, > > Thanks for the patch. Here are some remarks: >

Re: [dpdk-dev] [PATCH v1 6/6] bbdev: auxiliary changes to DPDK framework

2017-10-16 Thread Mokhtar, Amr
My initial thought was that the whole patchset is applied as a whole at once to dpdk. Will get the source files submitted with belonging Makefiles to get it incrementally compilable. Thanks Anatoly for catching this. > -Original Message- > From: Burakov, Anatoly > Sent: Wednesday 4 Oct

[dpdk-dev] [PATCH] igb_uio: fix compile error

2017-10-16 Thread Jingjing Wu
Compile fails when kernel version is <= 3.17 with error: "dereferencing pointer to incomplete type". This is because struct uio_device definition is not exposed in kernel earlier than 3.17. This patch fixes it by using pointer of rte_uio_pci_dev as dev_id instead of uio_device for irq device handl

Re: [dpdk-dev] [PATCH 01/11] examples/ipsec-secgw: updated MAINTAINERS file

2017-10-16 Thread Sergio Gonzalez Monroy
Hi Aviad, On 14/10/2017 14:27, avia...@dev.mellanox.co.il wrote: From: Aviad Yehezkel As agreed with Sergio and Pablo I don't think the commit message is relevant. Either me or Pablo acking the patch would have the same meaning. Thanks, Sergio Signed-off-by: Aviad Yehezkel --- MAINTAIN

Re: [dpdk-dev] [PATCH 05/11] examples/ipsec-secgw: Fixed transport

2017-10-16 Thread Sergio Gonzalez Monroy
On 14/10/2017 14:27, avia...@dev.mellanox.co.il wrote: From: Aviad Yehezkel Seems like transport was broken for a long time Commit message needs to be improved. Just mentioned what is wrong or how do you fix it. Given that it is a fix, you should start the commit title with "fix ..." then a

Re: [dpdk-dev] [PATCH 06/11] examples/ipsec-secgw: Added correct padding to tunnel mode

2017-10-16 Thread Sergio Gonzalez Monroy
Could you provide the cases where the padding is wrong in tunnel mode? Thanks, Sergio On 14/10/2017 14:27, avia...@dev.mellanox.co.il wrote: From: Aviad Yehezkel Signed-off-by: Aviad Yehezkel --- examples/ipsec-secgw/esp.c | 51 ++ 1 file change

Re: [dpdk-dev] [PATCH 07/11] examples/ipsec-secgw: Fixed phyiscal address of aad

2017-10-16 Thread Sergio Gonzalez Monroy
On 14/10/2017 14:27, avia...@dev.mellanox.co.il wrote: From: Aviad Yehezkel Signed-off-by: Aviad Yehezkel --- examples/ipsec-secgw/esp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/examples/ipsec-secgw/esp.c b/examples/ipsec-secgw/esp.c index 689e917..aa2233d 10064

Re: [dpdk-dev] [PATCH 08/11] examples/ipsec-secgw: iv should be be64

2017-10-16 Thread Sergio Gonzalez Monroy
On 14/10/2017 14:28, avia...@dev.mellanox.co.il wrote: From: Aviad Yehezkel To be compatibile with Linux kernel I am not sure what you are trying to achieve with this change. The requirement is that the IV is unique, IMO changing the endianess is irrelevant here. Can you provide case/exampl

Re: [dpdk-dev] [PATCH 09/11] examples/ipsec-secgw: Fixed ip length in case of transport

2017-10-16 Thread Sergio Gonzalez Monroy
On 14/10/2017 14:28, avia...@dev.mellanox.co.il wrote: From: Aviad Yehezkel IP length was incorrect causing corrupted ICMP packets for example Signed-off-by: Aviad Yehezkel --- examples/ipsec-secgw/esp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/ipsec

Re: [dpdk-dev] [PATCH 10/11] app/testpmd: compile even if ixgbe anf bnxt pmds are not compiling

2017-10-16 Thread Sergio Gonzalez Monroy
On 14/10/2017 14:28, avia...@dev.mellanox.co.il wrote: From: Aviad Yehezkel Signed-off-by: Aviad Yehezkel Signed-off-by: Nicolai Radu --- app/test-pmd/cmdline.c | 13 ++--- app/test-pmd/config.c | 12 +++- 2 files changed, 21 insertions(+), 4 deletions(-) This patch is

Re: [dpdk-dev] [PATCH v3 15/19] vhost: postpone rings addresses translation

2017-10-16 Thread Maxime Coquelin
Hi Yao, On 10/16/2017 08:23 AM, Yao, Lei A wrote: Hi, Maxime Add one comment: This issue with virtio-net only occur when I use CPU on socket 1. Thanks for the report. I fail to reproduce for now. What is your qemu command line? Is it reproducible systematically when there is a NUMA reallocat

Re: [dpdk-dev] [PATCH V4 5/5] app/testpmd: cli for traffic metering and policing

2017-10-16 Thread Wu, Jingjing
> -Original Message- > From: Dumitrescu, Cristian > Sent: Friday, October 13, 2017 8:22 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; adrien.mazarg...@6wind.com; Wu, Jingjing > ; Mcnamara, John ; > hemant.agra...@nxp.com; jerin.ja...@caviumnetworks.com; Singh, Jasvinder > > Subject: [

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix ip version check

2017-10-16 Thread Sergio Gonzalez Monroy
On 13/10/2017 13:50, Tomasz Duszynski wrote: Since new_ip and ip4 are overlapping buffers copying ip4 over new_ip using memmove() might overwrite memory at ip4. This could happen if following condition holds: ip_hdr_len > sizeof(struct esp_hdr) + sa->iv_len Thus using ip4 to check ip version is

Re: [dpdk-dev] [PATCH v1 1/6] bbdev: librte_bbdev library

2017-10-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Amr Mokhtar > Sent: Saturday, September 30, 2017 2:38 AM > To: dev@dpdk.org > Cc: Power, Niall ; Macnamara, Chris > ; Mokhtar, Amr > Subject: [dpdk-dev] [PATCH v1 1/6] bbdev: librte_bbdev library > You are addi

Re: [dpdk-dev] [PATCH V4 5/5] app/testpmd: cli for traffic metering and policing

2017-10-16 Thread Wu, Jingjing
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wu, Jingjing > Sent: Monday, October 16, 2017 5:50 PM > To: Dumitrescu, Cristian ; dev@dpdk.org > Cc: tho...@monjalon.net; adrien.mazarg...@6wind.com; Mcnamara, John > ; hemant.agra...@nxp.com; > jerin.ja...@caviu

Re: [dpdk-dev] [PATCH] igb_uio: fix compile error

2017-10-16 Thread Tan, Jianfeng
> -Original Message- > From: Wu, Jingjing > Sent: Monday, October 16, 2017 9:58 AM > To: Tan, Jianfeng > Cc: dev@dpdk.org; Wu, Jingjing > Subject: [PATCH] igb_uio: fix compile error > > Compile fails when kernel version is <= 3.17 with error: > "dereferencing pointer to incomplete type".

Re: [dpdk-dev] [PATCH] doc: update release notes for mlx5 driver

2017-10-16 Thread Thomas Monjalon
16/10/2017 07:23, Shahaf Shuler: > --- a/doc/guides/rel_notes/release_17_11.rst > +++ b/doc/guides/rel_notes/release_17_11.rst > @@ -165,6 +165,19 @@ New Features >checksums, and doesn't update checksums for output packets. >Additionally, the GSO library doesn't process IP fragmented packet

Re: [dpdk-dev] [PATCH v9 3/3] app/test-pmd: add CLI for TM nodes and hierarchy commit

2017-10-16 Thread Wu, Jingjing
> -Original Message- > From: Singh, Jasvinder > Sent: Saturday, October 14, 2017 6:20 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Wu, Jingjing > ; Pei, Yulong > Subject: [PATCH v9 3/3] app/test-pmd: add CLI for TM nodes and hierarchy > commit > > Add following CLIs in testpmd app

Re: [dpdk-dev] [PATCH] app/testpmd: remove useless funciton declarations

2017-10-16 Thread Thomas Monjalon
16/10/2017 04:30, Zhiyong Yang: > The four function declarations have no funciton implementation, > remove them. > > Signed-off-by: Zhiyong Yang Please add Fixes: line.

Re: [dpdk-dev] [PATCH v3] eal: add counter size for efd clean

2017-10-16 Thread Wu, Jingjing
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, October 11, 2017 9:11 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Tan, Jianfeng ; > shreyansh.j...@nxp.com; hemant.agra...@nxp.com; > santosh.shu...@caviumnetworks.com; Tomasz Duszynski ; > Jacek S

Re: [dpdk-dev] [PATCH] ring: guarantee ordering of cons/prod loading when doing enqueue/dequeue

2017-10-16 Thread Zhao, Bing
Hi Guys, If needed, we can provide a simplified UT test case and ring patch to reproduce this. And then we can catch the information to prove that in a SP+MC scenario, when the tail and head pointers' number are smaller than the ring size, some lcore thread will have a fault judge and then make

[dpdk-dev] [PATCH] eventdev: remove experimental label

2017-10-16 Thread Jerin Jacob
The eventdev API was introduced in DPDK 17.05 release. Since then it - has been reviewed and iterated for 17.08, 17.11 releases - three drivers were implemented using the API. - introduced another subsystem like service core and ethdev-eventdev Rx adapter APIs to abstract the difference between HW

Re: [dpdk-dev] [PATCH] ring: guarantee ordering of cons/prod loading when doing enqueue/dequeue

2017-10-16 Thread Liu, Jie2
Hi guys, We found this issue when we run mbuf_autotest. It failed on a aarch64 platform. I am not sure if it can be reproduced on other platforms. Regards, Jie Liu -Original Message- From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] Sent: 2017年10月13日 1:06 To: Olivier MATZ ;

Re: [dpdk-dev] [PATCH 08/11] examples/ipsec-secgw: iv should be be64

2017-10-16 Thread Aviad Yehezkel
On 10/16/2017 12:42 PM, Sergio Gonzalez Monroy wrote: On 14/10/2017 14:28, avia...@dev.mellanox.co.il wrote: From: Aviad Yehezkel To be compatibile with Linux kernel I am not sure what you are trying to achieve with this change. The requirement is that the IV is unique, IMO changing the end

Re: [dpdk-dev] [PATCH 10/11] app/testpmd: compile even if ixgbe anf bnxt pmds are not compiling

2017-10-16 Thread Aviad Yehezkel
On 10/16/2017 12:44 PM, Sergio Gonzalez Monroy wrote: On 14/10/2017 14:28, avia...@dev.mellanox.co.il wrote: From: Aviad Yehezkel Signed-off-by: Aviad Yehezkel Signed-off-by: Nicolai Radu ---   app/test-pmd/cmdline.c | 13 ++---   app/test-pmd/config.c  | 12 +++-   2 files ch

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-16 Thread Thomas Monjalon
15/10/2017 14:51, Aviad Yehezkel: > > On 10/15/2017 1:17 AM, Akhil Goyal wrote: > > From: Radu Nicolau > > > > Signed-off-by: Radu Nicolau > > Signed-off-by: Declan Doherty > > --- > > drivers/net/Makefile | 2 +- > > drivers/net/ixgbe/Makefile | 2 +- > >

Re: [dpdk-dev] [PATCH 05/11] examples/ipsec-secgw: Fixed transport

2017-10-16 Thread Aviad Yehezkel
On 10/16/2017 12:30 PM, Sergio Gonzalez Monroy wrote: On 14/10/2017 14:27, avia...@dev.mellanox.co.il wrote: From: Aviad Yehezkel Seems like transport was broken for a long time Commit message needs to be improved. Just mentioned what is wrong or how do you fix it. Given that it is a fix,

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix ip version check

2017-10-16 Thread Aviad Yehezkel
Reviewed-by: Aviad Yehezkel On 10/16/2017 12:56 PM, Sergio Gonzalez Monroy wrote: On 13/10/2017 13:50, Tomasz Duszynski wrote: Since new_ip and ip4 are overlapping buffers copying ip4 over new_ip using memmove() might overwrite memory at ip4. This could happen if following condition holds: i

Re: [dpdk-dev] [PATCH v4 00/12] introduce security offload library

2017-10-16 Thread Thomas Monjalon
15/10/2017 00:17, Akhil Goyal: > This patchset introduce the rte_security library in DPDK. > This also includes the sample implementation of drivers and > changes in ipsec gateway application to demonstrate its usage. [...] > This patchset is also available at: > git://dpdk.org/draft/dpdk-draft-ips

Re: [dpdk-dev] [PATCH 01/11] examples/ipsec-secgw: updated MAINTAINERS file

2017-10-16 Thread Aviad Yehezkel
On 10/16/2017 12:27 PM, Sergio Gonzalez Monroy wrote: Hi Aviad, On 14/10/2017 14:27, avia...@dev.mellanox.co.il wrote: From: Aviad Yehezkel As agreed with Sergio and Pablo I don't think the commit message is relevant. Either me or Pablo acking the patch would have the same meaning. Thank

Re: [dpdk-dev] [PATCH v3] eal: add counter size for efd clean

2017-10-16 Thread Thomas Monjalon
16/10/2017 12:29, Wu, Jingjing: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Hi, > > > > 24/08/2017 04:10, Jingjing Wu: > > > } else if (intr_handle->type == RTE_INTR_HANDLE_VDEV) { > > > - /* do nothing, and let vdev driver to initialize this > > > struct */ > >

Re: [dpdk-dev] [PATCH v3 15/19] vhost: postpone rings addresses translation

2017-10-16 Thread Maxime Coquelin
On 10/16/2017 11:47 AM, Maxime Coquelin wrote: Hi Yao, On 10/16/2017 08:23 AM, Yao, Lei A wrote: Hi, Maxime Add one comment: This issue with virtio-net only occur when I use CPU on socket 1. Thanks for the report. I fail to reproduce for now. What is your qemu command line? Is it reproduc

Re: [dpdk-dev] [PATCH] ring: guarantee ordering of cons/prod loading when doing enqueue/dequeue

2017-10-16 Thread Kuusisaari, Juhamatti
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Liu, Jie2 > Sent: Friday, October 13, 2017 3:25 AM > To: Ananyev, Konstantin ; Olivier MATZ > ; dev@dpdk.org; > jerin.ja...@caviumnetworks.com > Cc: He, Jia ; Zhao, Bing semitech.com>; Jia He > Subject: Re: [dpd

Re: [dpdk-dev] [PATCH] igb_uio: fix compile error

2017-10-16 Thread Thomas Monjalon
16/10/2017 12:10, Tan, Jianfeng: > From: Wu, Jingjing > > > > Compile fails when kernel version is <= 3.17 with error: > > "dereferencing pointer to incomplete type". This is because struct > > uio_device definition is not exposed in kernel earlier than 3.17. > > > > This patch fixes it by using

[dpdk-dev] [PATCH] eventdev: add API to map file

2017-10-16 Thread Nikhil Rao
Add rte_event_eth_rx_adapter_service_id_get to map file Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter implementation") Signed-off-by: Nikhil Rao --- lib/librte_eventdev/rte_eventdev_version.map | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eventdev/rte_even

Re: [dpdk-dev] [PATCH] eventdev: add API to map file

2017-10-16 Thread De Lara Guarch, Pablo
Hi Nikhil, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Nikhil Rao > Sent: Monday, October 16, 2017 8:37 PM > To: jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] eventdev: add API to map file > > Add rte_event_eth_rx_adapter_s

Re: [dpdk-dev] [PATCH v2] doc: update mlx5 flow count limitations

2017-10-16 Thread Nélio Laranjeiro
On Mon, Oct 16, 2017 at 11:32:39AM +0300, Ori Kam wrote: > Signed-off-by: Ori Kam > Acked-by: Shahaf Shuler > --- > doc/guides/nics/mlx5.rst |5 - > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst > index d24941a..7da

Re: [dpdk-dev] [PATCH] crypto/dpaa_sec: remove memset of icv on decryption side

2017-10-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Friday, October 13, 2017 3:23 PM > To: alok.makhar...@nxp.com; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > hemant.agra...@nxp.com > Subject: Re: [PATCH] crypto/dpaa_sec: remove memset of icv on decryption > sid

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove memset of icv on decryption side

2017-10-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Friday, October 13, 2017 3:24 PM > To: alok.makhar...@nxp.com; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > hemant.agra...@nxp.com; sta...@dpdk.org > Subject: Re: [PATCH] crypto/dpaa2_sec: remove memset of icv o

Re: [dpdk-dev] [PATCH v2 11/18] devargs: simplify implementation

2017-10-16 Thread Shreyansh Jain
Hello Gaetan, On Thursday 12 October 2017 01:51 PM, Gaetan Rivet wrote: Re-use existing code, remove incorrect comments. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/librte_eal/comm

Re: [dpdk-dev] [PATCH v2 11/18] devargs: simplify implementation

2017-10-16 Thread Shreyansh Jain
Hello Gaetan, Please ignore this email (reason inline) On Monday 16 October 2017 05:09 PM, Shreyansh Jain wrote: Hello Gaetan, On Thursday 12 October 2017 01:51 PM, Gaetan Rivet wrote: Re-use existing code, remove incorrect comments. Signed-off-by: Gaetan Rivet ---   lib/librte_eal/common/e

Re: [dpdk-dev] [PATCH v2] doc: update mlx5 flow count limitations

2017-10-16 Thread Ori Kam
Please see my comments, > -Original Message- > From: Nélio Laranjeiro [mailto:nelio.laranje...@6wind.com] > Sent: Monday, October 16, 2017 2:18 PM > To: Ori Kam > Cc: Adrien Mazarguil ; Yongseok Koh > ; dev@dpdk.org > Subject: Re: [PATCH v2] doc: update mlx5 flow count limitations > > On

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: add support for out of place buffers

2017-10-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Friday, October 13, 2017 3:25 PM > To: alok.makhar...@nxp.com; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > hemant.agra...@nxp.com > Subject: Re: [PATCH] crypto/dpaa2_sec: add support for out of place > buffers

Re: [dpdk-dev] [PATCH] crypto/dpaa_sec: add support for out of place buffers

2017-10-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Friday, October 13, 2017 3:26 PM > To: alok.makhar...@nxp.com; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > hemant.agra...@nxp.com > Subject: Re: [PATCH] crypto/dpaa_sec: add support for out of place buffers >

Re: [dpdk-dev] [PATCH] event/sw: allow fwd and rel when out of credits

2017-10-16 Thread Jerin Jacob
-Original Message- > Date: Mon, 11 Sep 2017 08:52:44 + > From: "Van Haaren, Harry" > To: "Eads, Gage" , "dev@dpdk.org" > CC: "jerin.ja...@caviumnetworks.com" > Subject: Re: [dpdk-dev] [PATCH] event/sw: allow fwd and rel when out of > credits > > > From: Eads, Gage > > Sent: Friday,

Re: [dpdk-dev] [PATCH] eventdev: use new event enqueue in Rx adapter

2017-10-16 Thread Jerin Jacob
-Original Message- > Date: Sat, 14 Oct 2017 08:18:42 +0530 > From: "Rao, Nikhil" > To: Pavan Nikhilesh , > jerin.ja...@caviumnetworks.com > CC: dev@dpdk.org > Subject: Re: [PATCH] eventdev: use new event enqueue in Rx adapter > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gec

Re: [dpdk-dev] [PATCH] eventdev: add API to map file

2017-10-16 Thread Pavan Nikhilesh Bhagavatula
On Tue, Oct 17, 2017 at 01:07:26AM +0530, Nikhil Rao wrote: > Add rte_event_eth_rx_adapter_service_id_get to map file > > Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter implementation") > > Signed-off-by: Nikhil Rao > --- > lib/librte_eventdev/rte_eventdev_version.map | 2 +- > 1 file changed

Re: [dpdk-dev] [PATCH 09/11] examples/ipsec-secgw: Fixed ip length in case of transport

2017-10-16 Thread Aviad Yehezkel
On 10/16/2017 12:43 PM, Sergio Gonzalez Monroy wrote: On 14/10/2017 14:28, avia...@dev.mellanox.co.il wrote: From: Aviad Yehezkel IP length was incorrect causing corrupted ICMP packets for example Signed-off-by: Aviad Yehezkel ---   examples/ipsec-secgw/esp.c | 4 ++--   1 file changed, 2 ins

[dpdk-dev] [PATCH 0/2] examples/kni: update kni example application

2017-10-16 Thread Tomasz Duszynski
This patch series introduces some changes to the kni example application so that non-pci devices and those that can cannot do rx/tx while being stopped can use it. Tomasz Duszynski (2): examples/kni: check if pci_dev isn't NULL before using it examples/kni: stop lcores while doing kni ops ex

[dpdk-dev] [PATCH 2/2] examples/kni: stop lcores while doing kni ops

2017-10-16 Thread Tomasz Duszynski
Since the transmit and receive functions should not be invoked when the device is stopped, stop lcores during kni ops and restart them after device is started once again. Signed-off-by: Tomasz Duszynski --- examples/kni/main.c | 28 1 file changed, 28 insertions(+)

[dpdk-dev] [PATCH 1/2] examples/kni: check if pci_dev isn't NULL before using it

2017-10-16 Thread Tomasz Duszynski
Since virtual devices, i.e mrvl net pmd, do not touch pci_dev dereferencing it will cause segmentation fault as by default it's set to NULL in rte_eth_dev_info_get(). Signed-off-by: Tomasz Duszynski --- examples/kni/main.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [dpdk-dev] [PATCH 08/11] examples/ipsec-secgw: iv should be be64

2017-10-16 Thread Sergio Gonzalez Monroy
On 16/10/2017 11:35, Aviad Yehezkel wrote: On 10/16/2017 12:42 PM, Sergio Gonzalez Monroy wrote: On 14/10/2017 14:28, avia...@dev.mellanox.co.il wrote: From: Aviad Yehezkel To be compatibile with Linux kernel I am not sure what you are trying to achieve with this change. The requirement is

Re: [dpdk-dev] [PATCH 09/11] examples/ipsec-secgw: Fixed ip length in case of transport

2017-10-16 Thread Sergio Gonzalez Monroy
On 16/10/2017 12:44, Aviad Yehezkel wrote: On 10/16/2017 12:43 PM, Sergio Gonzalez Monroy wrote: On 14/10/2017 14:28, avia...@dev.mellanox.co.il wrote: From: Aviad Yehezkel IP length was incorrect causing corrupted ICMP packets for example Signed-off-by: Aviad Yehezkel --- examples/ipsec-

Re: [dpdk-dev] [PATCH] event/sw: fix get of single xstat value

2017-10-16 Thread Jerin Jacob
-Original Message- > Date: Tue, 10 Oct 2017 16:47:57 +0100 > From: Harry van Haaren > To: dev@dpdk.org > CC: jerin.ja...@caviumnetworks.com, Harry van Haaren > , bruce.richard...@intel.com > Subject: [PATCH] event/sw: fix get of single xstat value > X-Mailer: git-send-email 2.7.4 > > Thi

Re: [dpdk-dev] [RFC PATCH v2 0/1] eventtimer: introduce event timer adapter

2017-10-16 Thread Pavan Nikhilesh Bhagavatula
On Mon, Oct 09, 2017 at 08:30:35PM +, Carrillo, Erik G wrote: > > > > > > The second big change is to replace API parameters specifying pointer > > > to rte_event_timer_adapter with ids, which seems more common > > > throughout DPDK. > > > > > > Other changes include: > > > - removed rte_event

Re: [dpdk-dev] [PATCH v2] doc: update mlx5 flow count limitations

2017-10-16 Thread Nélio Laranjeiro
On Mon, Oct 16, 2017 at 11:31:32AM +, Ori Kam wrote: > Please see my comments, > > > -Original Message- > > From: Nélio Laranjeiro [mailto:nelio.laranje...@6wind.com] > > Sent: Monday, October 16, 2017 2:18 PM > > To: Ori Kam > > Cc: Adrien Mazarguil ; Yongseok Koh > > ; dev@dpdk.org

Re: [dpdk-dev] [RFC PATCH v2 0/1] eventtimer: introduce event timer adapter

2017-10-16 Thread Pavan Nikhilesh Bhagavatula
On Mon, Oct 16, 2017 at 05:34:36PM +0530, Pavan Nikhilesh Bhagavatula wrote: > On Mon, Oct 09, 2017 at 08:30:35PM +, Carrillo, Erik G wrote: > > > > > > > > The second big change is to replace API parameters specifying pointer > > > > to rte_event_timer_adapter with ids, which seems more common

Re: [dpdk-dev] [PATCH v2] doc: update mlx5 flow count limitations

2017-10-16 Thread Ori Kam
> -Original Message- > From: Nélio Laranjeiro [mailto:nelio.laranje...@6wind.com] > Sent: Monday, October 16, 2017 3:36 PM > To: Ori Kam > Cc: Adrien Mazarguil ; Yongseok Koh > ; dev@dpdk.org > Subject: Re: [PATCH v2] doc: update mlx5 flow count limitations > > On Mon, Oct 16, 2017 at 1

[dpdk-dev] [PATCH v2] doc: update release notes for mlx5 driver

2017-10-16 Thread Shahaf Shuler
Signed-off-by: Shahaf Shuler --- on v2: - Moved mlx5 notes next to net PMDs. --- doc/guides/rel_notes/release_17_11.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release_17_11.rst index 8db35f5e4..24018fdd5

Re: [dpdk-dev] [PATCH 01/11] examples/ipsec-secgw: updated MAINTAINERS file

2017-10-16 Thread De Lara Guarch, Pablo
Hi Aviad, > -Original Message- > From: Aviad Yehezkel [mailto:avia...@dev.mellanox.co.il] > Sent: Monday, October 16, 2017 11:44 AM > To: Gonzalez Monroy, Sergio ; > dev@dpdk.org; De Lara Guarch, Pablo ; > avia...@mellanox.com > Cc: bor...@mellanox.com; akhil.go...@nxp.com; > hemant.agra..

Re: [dpdk-dev] [PATCH v2 11/18] devargs: simplify implementation

2017-10-16 Thread Gaëtan Rivet
On Mon, Oct 16, 2017 at 05:12:37PM +0530, Shreyansh Jain wrote: > Hello Gaetan, > > Please ignore this email (reason inline) > Hello Shreyansh, Thanks for reading this patchset, and sorry about the confusion (the previous cover-letter only listed the PCI bus move, the bus control was only added

[dpdk-dev] [PATCH v1 1/2] mempool/octeontx: move mbox from event to mempool

2017-10-16 Thread Santosh Shukla
Octeontx mempool pmd need mailbox for pool setup. That mailbox was defined at drivers/event/octeontx. So mempool has dependency on event/octeontx driver and commit:8700239f7767 has added make rule which makes sure event/* get build before mempool, but this rule introduces cyclic dependency and may

[dpdk-dev] [PATCH v1 2/2] event/octeontx: bump library version

2017-10-16 Thread Santosh Shukla
This commit bumps the library version to reflect the ABI change caused by removing the below function from event/octeontx: * octeontx_ssovf_info * octeontx_ssovf_bar * octeontx_ssovf_mbox_send And moved to mempool/octeontx area. Signed-off-by: Santosh Shukla --- doc/guides/rel_notes/release_17_

Re: [dpdk-dev] Shared compilation issue - mempool/octeontx: add build and log infrastructure

2017-10-16 Thread santosh
Hi Hemant, On Monday 16 October 2017 12:20 PM, santosh wrote: > On Monday 16 October 2017 12:18 PM, Hemant Agrawal wrote: >> Hi Santosh, >> >> On 10/14/2017 8:57 PM, santosh wrote: >>> On Saturday 14 October 2017 11:37 AM, Hemant Agrawal wrote: Santosh/jerin, Your patch "mempool/oct

[dpdk-dev] [PATCH 1/2] power: switching to unbuffered stdio for /sys file access

2017-10-16 Thread Radoslaw Biernacki
This patch fixes the bug caused by improper use of buffered stdio file access for switching the CPU frequency and governor. Each write operation when using buffered stdio must be flushed out and the return code from fflush() must be verified. In buffered mode, write() syscall return value is is not

[dpdk-dev] [PATCH 2/2] power: check if userspace governor is available

2017-10-16 Thread Radoslaw Biernacki
Since for new Intel CPU's kernel use intel_pstate driver, which does not offer userspace governor, it is vise to check the userspace governor availability before trying to perform governor switch. The outcome from this patch is direct information for user about the root cause of failure during the

Re: [dpdk-dev] [PATCH v2] crypto/dpaa2_sec: add check for segmented buffer

2017-10-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Friday, October 13, 2017 4:45 PM > To: alok.makhar...@nxp.com; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > hemant.agra...@nxp.com; sta...@dpdk.org > Subject: Re: [PATCH v2] crypto/dpaa2_sec: add check for segme

Re: [dpdk-dev] [PATCH v2] crypto/dpaa_sec: add check for segmented buffer

2017-10-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Friday, October 13, 2017 4:45 PM > To: alok.makhar...@nxp.com; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > hemant.agra...@nxp.com > Subject: Re: [PATCH v2] crypto/dpaa_sec: add check for segmented buffer > > O

[dpdk-dev] [PATCH v3] doc: update mlx5 flow count limitations

2017-10-16 Thread Ori Kam
Signed-off-by: Ori Kam Acked-by: Shahaf Shuler --- v3: * Remove unnecessary line. doc/guides/nics/mlx5.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index d24941a..7ef9b0d 100644 --- a/doc/guides/nics/mlx5.rst ++

[dpdk-dev] [PATCH] vhost: translate addrs in set_vring_addr if ring already enabled

2017-10-16 Thread Maxime Coquelin
Commit 3ea7052f4b1b ("vhost: postpone rings addresses translation") moves rings addresses translation at either vring kick or enable time, depending on whether protocol features are enabled or not. This is done not interpret ring information as long as the vring is not fully initialized. The probl

[dpdk-dev] [PATCH] doc: announce API change for ethdev port info

2017-10-16 Thread Ivan Boule
To help administrative tasks on ports, new per-port information need to be added into the data structure rte_eth_dev_info supplied by the dev_infos_get() function exported by a Poll Mode Driver. See http://dpdk.org/ml/archives/dev/2017-September/074885.html for details. Signed-off-by: Ivan Boule

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: add support for out of place buffers

2017-10-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Monday, October 16, 2017 12:33 PM > To: Akhil Goyal ; alok.makhar...@nxp.com; > dev@dpdk.org > Cc: hemant.agra...@nxp.com > Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: add sup

Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/ipsec-secgw: fix ip version check

2017-10-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Sergio > Gonzalez Monroy > Sent: Monday, October 16, 2017 10:57 AM > To: Tomasz Duszynski ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] examples/ipsec-secgw: fix ip > v

[dpdk-dev] [PATCH v7 1/2] doc: add generic compilation doc for all sample apps

2017-10-16 Thread Marko Kovacevic
From: Herakliusz Lipiec Moved duplicated, and occasionally outdated, doc sections from each of the sample app guides chapters to a common chapter at the start. This reduces the duplication in the docs and provides a single point of reference for compiling the sample apps. Signed-off-by: Herakli

[dpdk-dev] [PATCH v7 2/2] doc: add new introduction to sample app guides

2017-10-16 Thread Marko Kovacevic
Add new Introduction Section into the sample app guides. Signed-off-by: Marko Kovacevic --- V7: removed :ref: targets. (Thomas) doc/guides/faq/faq.rst | 2 +- doc/guides/sample_app_ug/dist_app.rst | 1 + doc/guides/sample_app_ug/exception_path.

Re: [dpdk-dev] [PATCH] pmd_virtio: Unchecked return value from library

2017-10-16 Thread Tan, Jianfeng
Hi Sebastian, Sorry for the late response. I missed the previous emails. On 10/16/2017 4:32 PM, Basierski, SebastianX wrote: flags = fcntl(dev->vhostfd, F_GETFL); - fcntl(dev->vhostfd, F_SETFL, flags | O_NONBLOCK); + if (fcntl(

[dpdk-dev] [PATCH v2] vhost: translate addrs in set_vring_addr if ring already enabled

2017-10-16 Thread Maxime Coquelin
Commit 3ea7052f4b1b ("vhost: postpone rings addresses translation") moves rings addresses translation at either vring kick or enable time, depending on whether protocol features are enabled or not. This is done not interpret ring information as long as the vring is not fully initialized. The probl

Re: [dpdk-dev] [PATCH v3] doc: update mlx5 flow count limitations

2017-10-16 Thread Nélio Laranjeiro
On Mon, Oct 16, 2017 at 05:11:26PM +0300, Ori Kam wrote: > Signed-off-by: Ori Kam > Acked-by: Shahaf Shuler > > --- > > v3: > * Remove unnecessary line. > > doc/guides/nics/mlx5.rst | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/nics/mlx5.rst b/doc/gui

Re: [dpdk-dev] [PATCH 02/11] examples/ipsec-secgw: Fixed init of aead crypto devices

2017-10-16 Thread De Lara Guarch, Pablo
Hi Aviad, > -Original Message- > From: Aviad Yehezkel [mailto:avia...@dev.mellanox.co.il] > Sent: Sunday, October 15, 2017 1:54 PM > To: dev@dpdk.org; Gonzalez Monroy, Sergio > ; De Lara Guarch, Pablo > ; avia...@mellanox.com > Cc: bor...@mellanox.com; akhil.go...@nxp.com; > hemant.agra...

[dpdk-dev] [PATCH v3 1/4] drivers: add queue parameter in event processing callback

2017-10-16 Thread Nipun Gupta
For event dequeues for ethernet queues, a dpaa2_queue structure is required to get the configuration for that ethernet queue. Based on this configuration the rte_event is to be filled at the ingress side. Signed-off-by: Nipun Gupta Acked-by: Hemant Agrawal --- This patch series is based over the

[dpdk-dev] [PATCH v3 2/4] net/dpaa2: add API's to support event eth adapter

2017-10-16 Thread Nipun Gupta
Signed-off-by: Nipun Gupta --- Changes in v3: Check the queue schedule type before configuring MC (Hemant) drivers/net/dpaa2/dpaa2_ethdev.c| 62 + drivers/net/dpaa2/dpaa2_ethdev.h| 15 +++ drivers/net/dpaa2/dpaa2_rxtx.c | 20

[dpdk-dev] [PATCH v3 3/4] event/dpaa2: support event eth adapter

2017-10-16 Thread Nipun Gupta
Signed-off-by: Nipun Gupta Reviewed-by: Nikhil Rao Acked-by: Hemant Agrawal --- Changes in v3: Fix shared library build Changes in v2: Support rx_queue_id = -1 in eth adapter queue and and del (Nikhil) Remove duplicate returns (Nikhil) drivers/Makefile | 2 +- drive

[dpdk-dev] [PATCH v3 4/4] event/dpaa2: improve the err handling and log msg

2017-10-16 Thread Nipun Gupta
Signed-off-by: Nipun Gupta Acked-by: Hemant Agrawal --- drivers/event/dpaa2/dpaa2_eventdev.c | 9 + drivers/event/dpaa2/dpaa2_hw_dpcon.c | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c ind

Re: [dpdk-dev] [PATCH v3] vhost: Expose virtio interrupt need on rte_vhost API

2017-10-16 Thread Jan Scheurich
Fixed the subject. > Date: Fri, 6 Oct 2017 14:40:15 +0800 > From: Yuanhan Liu > To: Jan Scheurich > Cc: "'dev@dpdk.org'" > Subject: Re: [dpdk-dev] [PATCH v3] vhost: Expose virtio interrupt need > on rte_vhost API > Message-ID: <20171006064015.GD1545@yliu-home> > Content-Type: text/plain;

Re: [dpdk-dev] [PATCH 03/11] examples/ipsec-secgw: Fixed create session also for aead

2017-10-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: avia...@dev.mellanox.co.il [mailto:avia...@dev.mellanox.co.il] > Sent: Saturday, October 14, 2017 2:28 PM > To: dev@dpdk.org; Gonzalez Monroy, Sergio > ; De Lara Guarch, Pablo > ; avia...@mellanox.com > Cc: bor...@mellanox.com; akhil.go...@nxp.com; > hemant.ag

Re: [dpdk-dev] [PATCH 04/11] examples/ipsec-secgw: Fix aad_len for for aes-gcm support

2017-10-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: avia...@mellanox.com [mailto:avia...@mellanox.com] > Sent: Saturday, October 14, 2017 2:27 PM > To: dev@dpdk.org; Gonzalez Monroy, Sergio > ; De Lara Guarch, Pablo > ; avia...@mellanox.com > Cc: bor...@mellanox.com; akhil.go...@nxp.com; > hemant.agra...@nxp.co

Re: [dpdk-dev] [PATCH 11/11] examples/ipsec-secgw: Ethernet MAC configuration is now dynamic throw conf file

2017-10-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: avia...@mellanox.com [mailto:avia...@mellanox.com] > Sent: Saturday, October 14, 2017 2:27 PM > To: dev@dpdk.org; Gonzalez Monroy, Sergio > ; De Lara Guarch, Pablo > ; avia...@mellanox.com > Cc: bor...@mellanox.com; akhil.go...@nxp.com; > hemant.agra...@nxp.co

[dpdk-dev] [PATCH] net/mlx5: fix parsing flags of multi-packet send

2017-10-16 Thread Yongseok Koh
Fixes: 43e9d9794cde ("net/mlx5: support upstream rdma-core") Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/ml

Re: [dpdk-dev] [PATCH v9 3/3] app/test-pmd: add CLI for TM nodes and hierarchy commit

2017-10-16 Thread Singh, Jasvinder
> > diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.c > > index 38048ae..002209c 100644 > > --- a/app/test-pmd/cmdline_tm.c > > +++ b/app/test-pmd/cmdline_tm.c > > @@ -42,6 +42,17 @@ > > #include "testpmd.h" > > #include "cmdline_tm.h" > > > > +#define PARSE_DELIMITER

[dpdk-dev] [PATCH v10 1/3] app/test-pmd: add CLI for TM capability and stats

2017-10-16 Thread Jasvinder Singh
Add following CLIs to testpmd application for device traffic management; - commands to display TM capability information. (per port, per hierarchy level and per hierarchy node) - command to display hiearchy node type - stats collection Signed-off-by: Jasvinder Singh Tested-by: Yulong Pei Revie

  1   2   >