Re: [dpdk-dev] [RFC v2 00/23] Dynamic memory allocation for DPDK

2018-02-06 Thread Nélio Laranjeiro
On Mon, Feb 05, 2018 at 10:36:58AM +, Burakov, Anatoly wrote: > On 05-Feb-18 10:18 AM, Nélio Laranjeiro wrote: > > On Mon, Feb 05, 2018 at 10:03:35AM +, Burakov, Anatoly wrote: > > > On 02-Feb-18 7:28 PM, Yongseok Koh wrote: > > > > On Tue, Dec 26, 2017 at 05:19:25PM +, Walker, Benjamin

Re: [dpdk-dev] [PATCH 1/7] cxgbe: fix secondary process initialization

2018-02-06 Thread Rahul Lakkireddy
On Monday, February 02/05/18, 2018 at 22:53:36 +0530, Ferruh Yigit wrote: > On 2/4/2018 6:06 AM, Rahul Lakkireddy wrote: > > From: Kumar Sanghvi > > > > rte_eth_dev_allocate already assigns the eth_dev_data. So, > > don't allocate it separately as part of probe function. And we > > save this eth_

[dpdk-dev] [PATCH] net/mlx5: fix flow RSS configuration

2018-02-06 Thread Nelio Laranjeiro
An RSS configuration without a key is valid according to the rte_eth_rss_conf API definition. Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow") Cc: sta...@dpdk.org Reported-by: Yuanhan Liu Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 29 +

Re: [dpdk-dev] [PATCH 3/7] cxgbe: add support to update RSS hash configuration and key

2018-02-06 Thread Rahul Lakkireddy
On Monday, February 02/05/18, 2018 at 22:39:55 +0530, Ferruh Yigit wrote: > On 2/4/2018 6:06 AM, Rahul Lakkireddy wrote: > > From: Kumar Sanghvi > > > > Add firmware API for updating RSS hash configuration and key. Move > > RSS hash configuration from cxgb4_write_rss() to a separate function > >

[dpdk-dev] [PATCH] net/mlx5: fix UAR remapping on non configured queues

2018-02-06 Thread Nelio Laranjeiro
priv_tx_uar_remap() is wrongly considering the queue is already configured and thus present in the queue array of the device. Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file descriptor") Cc: xuemi...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Nelio Laranjeiro --- driver

Re: [dpdk-dev] [PATCH v3] eal: add function to return number of detected sockets

2018-02-06 Thread Burakov, Anatoly
On 05-Feb-18 10:45 PM, Thomas Monjalon wrote: 05/02/2018 18:39, Burakov, Anatoly: On 05-Feb-18 4:37 PM, Anatoly Burakov wrote: During lcore scan, find maximum socket ID and store it. Signed-off-by: Anatoly Burakov --- Notes: v3: - Added ABI backwards compatibility v2

Re: [dpdk-dev] [PATCH 0/8] vhost: input validation enhancements

2018-02-06 Thread Maxime Coquelin
Hi Stefan, On 02/05/2018 01:16 PM, Stefan Hajnoczi wrote: This patch series addresses missing input validation that I came across when reviewing vhost_user.c. The first patch explains the security model and the rest fixes places with missing checks. Now is a good time to discuss the security m

Re: [dpdk-dev] [PATCH v3] eal: add function to return number of detected sockets

2018-02-06 Thread Thomas Monjalon
06/02/2018 10:28, Burakov, Anatoly: > On 05-Feb-18 10:45 PM, Thomas Monjalon wrote: > > 05/02/2018 18:39, Burakov, Anatoly: > >> On 05-Feb-18 4:37 PM, Anatoly Burakov wrote: > >>> During lcore scan, find maximum socket ID and store it. > >>> > >>> Signed-off-by: Anatoly Burakov > >>> --- > >>> > >

Re: [dpdk-dev] [PATCH 2/8] vhost: avoid enum fields in VhostUserMsg

2018-02-06 Thread Maxime Coquelin
On 02/05/2018 01:16 PM, Stefan Hajnoczi wrote: The VhostUserMsg struct binary representation must match the vhost-user protocol specification since this struct is read from and written to the socket. The VhostUserMsg.request union contains enum fields. Enum binary representation is implementa

Re: [dpdk-dev] [PATCH 0/8] vhost: input validation enhancements

2018-02-06 Thread Maxime Coquelin
On 02/05/2018 01:16 PM, Stefan Hajnoczi wrote: This patch series addresses missing input validation that I came across when reviewing vhost_user.c. The first patch explains the security model and the rest fixes places with missing checks. Now is a good time to discuss the security model if an

Re: [dpdk-dev] [PATCH 3/7] cxgbe: add support to update RSS hash configuration and key

2018-02-06 Thread Ferruh Yigit
On 2/6/2018 9:22 AM, Rahul Lakkireddy wrote: > On Monday, February 02/05/18, 2018 at 22:39:55 +0530, Ferruh Yigit wrote: >> On 2/4/2018 6:06 AM, Rahul Lakkireddy wrote: >>> From: Kumar Sanghvi >>> >>> Add firmware API for updating RSS hash configuration and key. Move >>> RSS hash configuration fr

Re: [dpdk-dev] [PATCH 1/7] vhost: make capabilities configurable

2018-02-06 Thread Maxime Coquelin
Hi Zhihong, On 02/03/2018 12:28 AM, Zhihong Wang wrote: This patch makes vhost device capabilities configurable to adopt new devices, since different devices may have different capabilities, like different combinations of supported features, or different number of queues. APIs are introduced to

[dpdk-dev] [PATCH] kni: optimize the kni release speed

2018-02-06 Thread zhouyangchao
Physical addresses in the fifo named alloc_q need to be traversed to release in user space. The physical address to the virtual address conversion in kernel space is much better. Signed-off-by: Yangchao Zhou --- lib/librte_eal/linuxapp/kni/kni_dev.h | 1 + lib/librte_eal/linuxapp/kni/kni_misc.

[dpdk-dev] [PATCH] kni: optimize the kni release speed

2018-02-06 Thread zhouyangchao
Physical addresses in the fifo named alloc_q need to be traversed to release in user space. The physical address to the virtual address conversion in kernel space is much better. Signed-off-by: Yangchao Zhou --- lib/librte_eal/linuxapp/kni/kni_dev.h | 1 + lib/librte_eal/linuxapp/kni/kni_misc.

Re: [dpdk-dev] [PATCH 3/7] cxgbe: add support to update RSS hash configuration and key

2018-02-06 Thread Thomas Monjalon
06/02/2018 11:11, Ferruh Yigit: > On 2/6/2018 9:22 AM, Rahul Lakkireddy wrote: > > On Monday, February 02/05/18, 2018 at 22:39:55 +0530, Ferruh Yigit wrote: > >> I tend to get driver patches even after integration deadline, mainly > >> because of > >> their limited scope. > >> But since these are

[dpdk-dev] Q: uio_generic_pci

2018-02-06 Thread Ran Shalit
Hello, I would please like to ask about uio_generic_pci : 1. how to set irq from userspace. Is there anything similar to echo "3" > /sys/bus/pci/drivers/uio_pci_generic/irq in all documentation which talk about it, it is not mentioned (or I don't find it): https://github.com/rumpkernel/wiki/wiki/

Re: [dpdk-dev] [PATCH v2 3/4] net/mlx: version rdma-core glue libraries

2018-02-06 Thread Adrien Mazarguil
On Mon, Feb 05, 2018 at 03:06:19PM -0200, Marcelo Ricardo Leitner wrote: > On Mon, Feb 05, 2018 at 04:54:55PM +0100, Adrien Mazarguil wrote: > > On Mon, Feb 05, 2018 at 01:29:42PM -0200, Marcelo Ricardo Leitner wrote: > > > On Mon, Feb 05, 2018 at 03:59:18PM +0100, Adrien Mazarguil wrote: > > > > O

Re: [dpdk-dev] [PATCH v3] net/bnxt: Fix to set timestamp flag

2018-02-06 Thread Ferruh Yigit
On 2/6/2018 2:52 AM, Somnath Kotur wrote: > The timestamp flag needs to be set in the offload flags > for the received pkt in case of PTP offload. > > Fixes: b11cceb83a34 ("net/bnxt: support timesync") > Cc: somnath.ko...@broadcom.com > > Signed-off-by: Somnath Kotur Applied to dpdk-next-net/ma

[dpdk-dev] [PATCH] net/bnx2x: reserve enough headroom for mbuf prepend

2018-02-06 Thread zhouyangchao
Signed-off-by: Yangchao Zhou --- drivers/net/bnx2x/bnx2x_rxtx.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x_rxtx.c b/drivers/net/bnx2x/bnx2x_rxtx.c index a0d4ac9..d8a3225 100644 --- a/drivers/net/bnx2x/bnx2x_rxtx.c +++ b/drivers/net/bnx2x/bn

[dpdk-dev] [PATCH] net/bnx2x: reserve enough headroom for mbuf prepend

2018-02-06 Thread zhouyangchao
Signed-off-by: Yangchao Zhou --- drivers/net/bnx2x/bnx2x_rxtx.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x_rxtx.c b/drivers/net/bnx2x/bnx2x_rxtx.c index a0d4ac9..d8a3225 100644 --- a/drivers/net/bnx2x/bnx2x_rxtx.c +++ b/drivers/net/bnx2x/bn

[dpdk-dev] [PATCH] net/bnx2x: reserve enough headroom for mbuf prepend

2018-02-06 Thread zhouyangchao
Signed-off-by: Yangchao Zhou --- drivers/net/bnx2x/bnx2x_rxtx.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x_rxtx.c b/drivers/net/bnx2x/bnx2x_rxtx.c index a0d4ac9..d8a3225 100644 --- a/drivers/net/bnx2x/bnx2x_rxtx.c +++ b/drivers/net/bnx2x/bn

[dpdk-dev] [PATCH] net/bnx2x: reserve enough headroom for mbuf prepend

2018-02-06 Thread zhouyangchao
Signed-off-by: Yangchao Zhou --- drivers/net/bnx2x/bnx2x_rxtx.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x_rxtx.c b/drivers/net/bnx2x/bnx2x_rxtx.c index a0d4ac9..d8a3225 100644 --- a/drivers/net/bnx2x/bnx2x_rxtx.c +++ b/drivers/net/bnx2x/bn

[dpdk-dev] [PATCH] net/bnx2x: reserve enough headroom for mbuf prepend

2018-02-06 Thread zhouyangchao
Signed-off-by: Yangchao Zhou --- drivers/net/bnx2x/bnx2x_rxtx.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x_rxtx.c b/drivers/net/bnx2x/bnx2x_rxtx.c index a0d4ac9..d8a3225 100644 --- a/drivers/net/bnx2x/bnx2x_rxtx.c +++ b/drivers/net/bnx2x/bn

[dpdk-dev] [PATCH] net/bnx2x: reserve enough headroom for mbuf prepend

2018-02-06 Thread zhouyangchao
Signed-off-by: Yangchao Zhou --- drivers/net/bnx2x/bnx2x_rxtx.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x_rxtx.c b/drivers/net/bnx2x/bnx2x_rxtx.c index a0d4ac9..d8a3225 100644 --- a/drivers/net/bnx2x/bnx2x_rxtx.c +++ b/drivers/net/bnx2x/bn

Re: [dpdk-dev] [PATCH v2 0/4] net/mlx: enhance rdma-core glue configuration

2018-02-06 Thread Shahaf Shuler
Friday, February 2, 2018 6:46 PM, Adrien Mazarguil: > The decision to deliver mlx4/mlx5 rdma-core glue plug-ins separately instead > of generating them at run time due to security concerns [1] led to a few > issues: > > - They must be present on the file system before running DPDK. > - Their locat

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow RSS configuration

2018-02-06 Thread Shahaf Shuler
Tuesday, February 6, 2018 11:22 AM, Nelio Laranjeiro: > An RSS configuration without a key is valid according to the rte_eth_rss_conf > API definition. > > Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow") > > Cc: sta...@dpdk.org > Reported-by: Yuanhan Liu > Signed-off-

Re: [dpdk-dev] [PATCH] net/mlx5: fix UAR remapping on non configured queues

2018-02-06 Thread Shahaf Shuler
Tuesday, February 6, 2018 11:26 AM, Nelio Laranjeiro: > priv_tx_uar_remap() is wrongly considering the queue is already configured > and thus present in the queue array of the device. > > Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file > descriptor") > Cc: xuemi...@mellanox.com

Re: [dpdk-dev] [PATCH v2] doc: update application minimum requirement info

2018-02-06 Thread Mcnamara, John
> -Original Message- > From: Varghese, Vipin > Sent: Monday, February 5, 2018 5:32 PM > To: dev@dpdk.org; Kovacevic, Marko ; De Lara > Guarch, Pablo > Cc: Mcnamara, John ; Varghese, Vipin > > Subject: [PATCH v2] doc: update application minimum requirement info > > Added note section to

Re: [dpdk-dev] [PATCH] doc: update info on multi crypto instances

2018-02-06 Thread Mcnamara, John
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Monday, February 5, 2018 3:58 PM > To: Varghese, Vipin ; dev@dpdk.org; Kovacevic, > Marko > Cc: Mcnamara, John ; Varghese, Vipin > > Subject: RE: [dpdk-dev] [PATCH] doc: update info on multi crypto instances > > > > > -Or

Re: [dpdk-dev] [PATCH] doc: update the usage for shared library

2018-02-06 Thread Mcnamara, John
> -Original Message- > From: Varghese, Vipin > Sent: Monday, February 5, 2018 2:17 PM > To: dev@dpdk.org; Kovacevic, Marko > Cc: Mcnamara, John ; Varghese, Vipin > > Subject: [PATCH] doc: update the usage for shared library > > Add note information to intimate about use of option '-d'

Re: [dpdk-dev] [PATCH v3] doc: update definition of lcore id and lcore index

2018-02-06 Thread Mcnamara, John
> -Original Message- > From: Kovacevic, Marko > Sent: Friday, February 2, 2018 3:03 PM > To: dev@dpdk.org > Cc: Mcnamara, John ; Varghese, Vipin > ; Richardson, Bruce > ; sta...@dpdk.org; Kovacevic, Marko > > Subject: [PATCH v3] doc: update definition of lcore id and lcore index > > Add

Re: [dpdk-dev] [PATCH v2 4/4] doc/power: add information on per-core turbo APIs

2018-02-06 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt > Sent: Wednesday, September 13, 2017 11:44 AM > To: dev@dpdk.org > Cc: Hunt, David > Subject: [dpdk-dev] [PATCH v2 4/4] doc/power: add information on per-core > turbo APIs > > Signed-off-by: David Hu

[dpdk-dev] [PATCH] net/mlx5: dump flow create error message

2018-02-06 Thread Xueming Li
Add error message dump when flow create error happened. Signed-off-by: Xueming Li --- drivers/net/mlx5/mlx5_flow.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index e38452ef3..ea90556d0 100644 --- a/drivers/net/mlx5/mlx5_flow.c

[dpdk-dev] [PATCH] net/mlx5: fix socket assertion error during dev close

2018-02-06 Thread Xueming Li
This patch fixed primary socket assertion error during close on a device that failed to start. Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file descriptor") Signed-off-by: Xueming Li --- drivers/net/mlx5/mlx5.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --gi

Re: [dpdk-dev] [PATCH] net/mlx5: dump flow create error message

2018-02-06 Thread Nélio Laranjeiro
On Tue, Feb 06, 2018 at 08:52:53PM +0800, Xueming Li wrote: > Add error message dump when flow create error happened. > > Signed-off-by: Xueming Li > --- > drivers/net/mlx5/mlx5_flow.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_

Re: [dpdk-dev] [PATCH] net/mlx5: fix socket assertion error during dev close

2018-02-06 Thread Nélio Laranjeiro
On Tue, Feb 06, 2018 at 08:54:22PM +0800, Xueming Li wrote: > This patch fixed primary socket assertion error during close on a device > that failed to start. > > Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file > descriptor") > Signed-off-by: Xueming Li > --- > drivers/net/m

Re: [dpdk-dev] [PATCH 1/8] vhost: add security model documentation to vhost_user.c

2018-02-06 Thread Kovacevic, Marko
> Input validation is not applied consistently in vhost_user.c. This suggests > that > not everyone has the same security model in mind when working on the > code. > > Make the security model explicit so that everyone can understand and follow > the same model when modifying the code. > > Signe

Re: [dpdk-dev] [PATCH] doc: add info on hyperthreading to power library

2018-02-06 Thread Kovacevic, Marko
> Signed-off-by: David Hunt > --- > doc/guides/prog_guide/power_man.rst | 8 > 1 file changed, 8 insertions(+) > > diff --git a/doc/guides/prog_guide/power_man.rst > b/doc/guides/prog_guide/power_man.rst <...> Acked-by: Marko Kovacevic

[dpdk-dev] [Bug 15] Kernel crash after "Detected Tx Unit Hang" report

2018-02-06 Thread bugzilla
https://dpdk.org/tracker/show_bug.cgi?id=15 Bug ID: 15 Summary: Kernel crash after "Detected Tx Unit Hang" report Product: DPDK Version: 17.11 Hardware: x86 OS: Linux Status: CONFIRMED Severity: critical

[dpdk-dev] [PATCH v2] bbdev: fix exported dynamic log type

2018-02-06 Thread Amr Mokhtar
This patch fixes shared library compilation due to undefined reference to an exported variable 'bbdev_logtype'. v2: * In this fix, * - The logtype has become static and owned individually by each *component. * - Helper logging macros are removed from bbdev lib header files *and replaced wi

[dpdk-dev] [PATCH v5 5/6] test: fix memory leak in table autotest

2018-02-06 Thread Anatoly Burakov
Always deallocate allocated resources after the test is done. Acked-by: Cristian Dumitrescu Fixes: 5205954791cb ("app/test: packet framework unit tests") Cc: cristian.dumitre...@intel.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- Notes: v4: put ack after signoff test/test/te

[dpdk-dev] [PATCH v5 4/6] test: fix memory leak in ring perf autotest

2018-02-06 Thread Anatoly Burakov
Acked-by: Olivier Matz Fixes: ac3fb3019c52 ("app: rework ring tests") Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- Notes: v2: remove static ring variable test/test/test_ring_perf.c | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff

[dpdk-dev] [PATCH v5 2/6] test: fix memory leak in reorder autotest

2018-02-06 Thread Anatoly Burakov
Add a teardown function that frees allocated resources. Fixes: d0c9b58d7156 ("app/test: new reorder unit test") Cc: sergio.gonzalez.mon...@intel.com Cc: reshma.pat...@intel.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- Notes: v4: fix Reshma Pattan's email address test/test/tes

[dpdk-dev] [PATCH v5 1/6] test: fix memory leak in bitmap test

2018-02-06 Thread Anatoly Burakov
Acked-by: Cristian Dumitrescu Fixes: c7e4a134e769 ("test: verify bitmap operations") Cc: pbhagavat...@caviumnetworks.com Signed-off-by: Anatoly Burakov --- Notes: v4: put ack after signoff test/test/test_bitmap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/test/test_bitmap

[dpdk-dev] [PATCH v5 3/6] test: fix memory leak in ring autotest

2018-02-06 Thread Anatoly Burakov
Get rid of global static ring variable and don't reuse rings between test runs. Acked-by: Olivier Matz Fixes: 4e32101f9b01 ("ring: support freeing") Cc: pablo.de.lara.gua...@intel.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- Notes: v5: fix use of uninitialized pointer v3:

[dpdk-dev] [PATCH v5 6/6] test: fix memory leak in timer perf autotest

2018-02-06 Thread Anatoly Burakov
Fixes: 277afaf3dbcb ("app/test: add timer_perf") Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- test/test/test_timer_perf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/test/test/test_timer_perf.c b/test/test/test_timer_perf.c index afa3a06..0fe2b74 100644 --- a/test/test/test_time

[dpdk-dev] [PATCH] net/bnxt: fix Rx checksum flags

2018-02-06 Thread Olivier Matz
Fix the Rx offload flags when the IP or L4 checksum is seen as incorrect by the hardware. In this case, the proper value is PKT_RX_IP_CKSUM_BAD. PKT_RX_IP_CKSUM_NONE means that the checksum may be incorrect in the packet headers, but the integrity of the IP header is verified. This is mostly usefu

Re: [dpdk-dev] [PATCH] doc: update i40e guide

2018-02-06 Thread Kovacevic, Marko
> This patch updates the i40e guide with new device parameter support-multi- > driver. > > Signed-off-by: Beilei Xing > Cc: sta...@dpdk.org > > doc/guides/nics/i40e.rst | 11 +++ > 1 file changed, 11 insertions(+) > Acked-by: Marko Kovacevic

[dpdk-dev] [PATCH v2] doc: update multiple instance info for NULL crypto

2018-02-06 Thread Vipin Varghese
Add foot note & example to inform user how to use multiple instance. Signed-off-by: Vipin Varghese --- V2 Changes: - Updated Note for better wording - Pablo - Multiple instance information to Crypto Device Lib - Pablo --- doc/guides/cryptodevs/null.rst | 12 +--- 1 file changed, 9 ins

Re: [dpdk-dev] [PATCH] net/bnx2x: reserve enough headroom for mbuf prepend

2018-02-06 Thread Ferruh Yigit
On 2/6/2018 11:21 AM, zhouyangchao wrote: > Signed-off-by: Yangchao Zhou Hi Yangchao, There are multiple version of this patch and all seems marked as rejected in patchwork, intentionally? If not can you please update the correct one as new in patchwork?

Re: [dpdk-dev] [PATCH 00/14] implement packed virtqueues

2018-02-06 Thread Jens Freimann
On Tue, Feb 06, 2018 at 02:20:02PM +0800, Jason Wang wrote: On 2018???01???29??? 22:11, Jens Freimann wrote: May I ask how do you test the patch? I believe you need some basic packed ring support in both qemu and vhost-user protocol. Yes, I have a small patch for qemu here: https://github.co

[dpdk-dev] [PATCH v2] doc: update the usage for shared library

2018-02-06 Thread Vipin Varghese
Add note information to intimate about use of option '-d' for shared library in DPDK application. Signed-off-by: Vipin Varghese --- V2 Changes: - updated the space - John - updated testpmd to dpdk-testpmd - John --- doc/guides/nics/build_and_test.rst | 5 + 1 file changed, 5 insertions(+)

Re: [dpdk-dev] [PATCH v3] doc: update flow filtering document

2018-02-06 Thread Ferruh Yigit
On 2/5/2018 3:31 PM, Mcnamara, John wrote: > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Wednesday, January 31, 2018 5:24 PM >> To: Zhao1, Wei ; dev@dpdk.org >> Cc: Mcnamara, John ; sta...@dpdk.org; >> or...@mellanox.com >> Subject: Re: [dpdk-dev] [PATCH v3] doc: update flow filt

Re: [dpdk-dev] [PATCH] net/mlx5: dump flow create error message

2018-02-06 Thread Xueming(Steven) Li
Hi Nelio, > -Original Message- > From: Nélio Laranjeiro [mailto:nelio.laranje...@6wind.com] > Sent: Tuesday, February 6, 2018 9:22 PM > To: Xueming(Steven) Li > Cc: Nelio Laranjeiro ; dev@dpdk.org; Shahaf > Shuler > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: dump flow create error message

Re: [dpdk-dev] [PATCH 2/3] net/vdpa_virtio_pci: introduce vdpa sample driver

2018-02-06 Thread Maxime Coquelin
Hi Xiao, On 02/04/2018 03:55 PM, Xiao Wang wrote: This driver is a reference sample of making vDPA device driver based on vhost lib, this driver uses a standard virtio-net PCI device as vDPA device, it can serve as a backend for a virtio-net pci device in nested VM. The key driver ops implement

Re: [dpdk-dev] [PATCH v4] app/testpmd: fix port DCB configuration

2018-02-06 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yanglong Wu > Sent: Monday, February 5, 2018 5:56 PM > To: dev@dpdk.org > Cc: shah...@mellanox.com; Lu, Wenzhuo; Wu, Yanglong > Subject: [dpdk-dev] [PATCH v4] app/testpmd: fix port DCB configuration > > The port_

Re: [dpdk-dev] [PATCH v1] build: add more implementers' IDs and PNs for Arm platforms

2018-02-06 Thread Bruce Richardson
On Tue, Feb 06, 2018 at 11:32:59AM +0530, Pavan Nikhilesh wrote: > On Tue, Feb 06, 2018 at 05:51:29AM +, Herbert Guan wrote: > > Hi Pavan, > > > > > -Original Message- > > > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > > > Sent: Monday, February 5, 2018 17:23 > > > T

Re: [dpdk-dev] [PATCH v3] net/i40e: fix multiple DDP packages should not be allowed

2018-02-06 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xing, Beilei > Sent: Tuesday, February 6, 2018 10:27 AM > To: Rybalchenko, Kirill; dev@dpdk.org > Cc: sta...@dpdk.org; Chilikin, Andrey; Wu, Jingjing > Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix multiple DDP

Re: [dpdk-dev] [PATCH v3] net/i40e: fix issue about interrupt

2018-02-06 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Beilei Xing > Sent: Tuesday, February 6, 2018 1:34 PM > To: Zhang, Qi Z; Wu, Jingjing > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v3] net/i40e: fix issue about interrupt > > This patch fixes

Re: [dpdk-dev] [PATCH v2] doc: update the usage for shared library

2018-02-06 Thread Mcnamara, John
> -Original Message- > From: Varghese, Vipin > Sent: Tuesday, February 6, 2018 2:09 PM > To: dev@dpdk.org; Mcnamara, John > Cc: sta...@dpdk.org; Kovacevic, Marko ; > Varghese, Vipin > Subject: [PATCH v2] doc: update the usage for shared library > > Add note information to intimate abou

Re: [dpdk-dev] [PATCH v3] net/i40e: fix issue about interrupt

2018-02-06 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Helin > Sent: Tuesday, February 6, 2018 11:23 PM > To: Xing, Beilei; Zhang, Qi Z; Wu, Jingjing > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix issue about interrupt >

Re: [dpdk-dev] [PATCH 1/8] vhost: add security model documentation to vhost_user.c

2018-02-06 Thread Kovacevic, Marko
<...> > > This is a useful comment but I don't know if it makes sense to include it in > the vhost_user.c file. > > > > Particularly at the top where it looks like a general descriptive comment > > for > the file. > > > > It would probably be better in the vhost-user section of the programmer's >

[dpdk-dev] [PATCH] ether: fix incorrect stats query for lowest xstat id

2018-02-06 Thread Bruce Richardson
When querying either the name or the value of a stat using the xstats APIs, a check is done to see if the regular stats API or the xstats APIs for the driver need to be used. However, the id of the stat requested is checked to see if it is greater than the number of basic stats, rather than checkin

Re: [dpdk-dev] [PATCH v4] doc: convert Intel sharing license headers to SPDX tags

2018-02-06 Thread Kovacevic, Marko
> Subject: [dpdk-dev] [PATCH v4] doc: convert Intel sharing license headers to > SPDX tags > > Signed-off-by: Ferruh Yigit > Acked-by: Bruce Richardson > --- > v3: Intel ones sharing copyright > --- > doc/guides/linux_gsg/linux_drivers.rst | 28 +--- <...> Acked-by: Mar

Re: [dpdk-dev] [PATCH] doc: fix release note for rawdev library

2018-02-06 Thread Kovacevic, Marko
> Signed-off-by: Shreyansh Jain > --- > doc/guides/rel_notes/release_18_02.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Marko Kovacevic

[dpdk-dev] [PATCH v3] doc: add info on multiple instance SW crypto

2018-02-06 Thread Vipin Varghese
Add infomration to explain applications using multiple instances of sw crypto with example. Signed-off-by: Vipin Varghese --- V3 Changes: - moved the multiple sw crypto to more generic place holder - Pablo V2 Changes: - Updated Note for better wording - Pablo - Multiple instance information

[dpdk-dev] [PATCH] bus: fix dpaa returning IOVA as PA

2018-02-06 Thread Pavan Nikhilesh
Fix dpaa bus returning IOVA as PA when there is no device attached to the bus. Fixes: 1ee9569576f6 ("config: enable dpaaX drivers for generic ARMv8") Fixes: d5a4e3a00c4a ("bus/dpaa: set IOVA mode as physical") Signed-off-by: Pavan Nikhilesh --- Currently Octeontx platform is broken due to this

Re: [dpdk-dev] [PATCH v3] doc: add info on multiple instance SW crypto

2018-02-06 Thread De Lara Guarch, Pablo
> -Original Message- > From: Varghese, Vipin > Sent: Tuesday, February 6, 2018 4:12 PM > To: dev@dpdk.org; De Lara Guarch, Pablo > > Cc: sta...@dpdk.org; Mcnamara, John ; > Kovacevic, Marko ; Varghese, Vipin > > Subject: [PATCH v3] doc: add info on multiple instance SW crypto > > Add i

Re: [dpdk-dev] [PATCH v4] raw/skeleton: fix device start test

2018-02-06 Thread Thomas Monjalon
06/02/2018 07:43, Shreyansh Jain: > Device can only be started if firmware is loaded, as per Skeleton > rawdev driver semantics. This patch fixes original implementation > which attempted to start the device without loading firmware. > > Fixes: 55ca1b0f2151 ("raw/skeleton: add test cases") > Cc: s

Re: [dpdk-dev] [PATCH v2] doc: update application minimum requirement info

2018-02-06 Thread De Lara Guarch, Pablo
> -Original Message- > From: Varghese, Vipin > Sent: Monday, February 5, 2018 5:32 PM > To: dev@dpdk.org; Kovacevic, Marko ; De > Lara Guarch, Pablo > Cc: Mcnamara, John ; Varghese, Vipin > > Subject: [PATCH v2] doc: update application minimum requirement info > > Added note section to

Re: [dpdk-dev] [PATCH] doc: fix release note for rawdev library

2018-02-06 Thread Thomas Monjalon
06/02/2018 17:10, Kovacevic, Marko: > > Signed-off-by: Shreyansh Jain > > --- > > doc/guides/rel_notes/release_18_02.rst | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Acked-by: Marko Kovacevic Applied, thanks

Re: [dpdk-dev] [PATCH v2] examples/l2fwd: check if user portmask is valid

2018-02-06 Thread De Lara Guarch, Pablo
> -Original Message- > From: Varghese, Vipin > Sent: Thursday, February 1, 2018 6:59 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; De Lara Guarch, Pablo > ; Richardson, Bruce > ; Varghese, Vipin > > Subject: [PATCH v2] examples/l2fwd: check if user portmask is valid > > User can pass por

[dpdk-dev] [PATCH] net/bnxt: fix packet type

2018-02-06 Thread Olivier Matz
The hw flags are not read correctly: the defines RX_PKT_CMPL_FLAGS_ITYPE_* are not bits but values, so the should not be tested with if (value & X) but with if ((value & MASK) == X). This was resulting in a wrong packet type. For instance, an IPv4/ICMP packet was returning a value of 7 for the lay

[dpdk-dev] [PATCH] bus/fslmc: fix build issue with latest glib-headers

2018-02-06 Thread Jerin Jacob
Fix the following build error with latest glib-headers( Part of aarch64-linux-gnu-gcc-7.3.0 toolchain) In file included from /tmp/drivers/bus/fslmc/mc/fsl_mc_sys.h:30:0, from /tmp/drivers/bus/fslmc/mc/dpmng.c:7: /usr/aarch64-linux-gnu/usr/include/libio.h:21:2: error: #warning " is

Re: [dpdk-dev] [PATCH v2 0/3] testpmd: fix rss forward config

2018-02-06 Thread Thomas Monjalon
> Matan Azrad (3): > app/testpmd: fix port index in RSS fwd config > app/testpmd: fix port topology in RSS fwd config > app/testpmd: use dedicated function to get Tx port Applied, thanks

[dpdk-dev] [PATCH v2] bus/dpaa: fix dpaa returning IOVA as PA by default

2018-02-06 Thread Pavan Nikhilesh
Fix dpaa bus returning IOVA as PA even when it is not running on dpaa platform. Fixes: 1ee9569576f6 ("config: enable dpaaX drivers for generic ARMv8") Fixes: d5a4e3a00c4a ("bus/dpaa: set IOVA mode as physical") Signed-off-by: Pavan Nikhilesh --- v2 Changes: - redo commit log. Currently all

Re: [dpdk-dev] [PATCH v2] bus/dpaa: fix dpaa returning IOVA as PA by default

2018-02-06 Thread Hemant Agrawal
On 2/6/2018 10:52 PM, Pavan Nikhilesh wrote: Fix dpaa bus returning IOVA as PA even when it is not running on dpaa platform. Fixes: 1ee9569576f6 ("config: enable dpaaX drivers for generic ARMv8") Fixes: d5a4e3a00c4a ("bus/dpaa: set IOVA mode as physical") Signed-off-by: Pavan Nikhilesh ---

Re: [dpdk-dev] [dpdk-stable] [PATCH] bus/fslmc: fix build issue with latest glib-headers

2018-02-06 Thread Thomas Monjalon
06/02/2018 18:14, Jerin Jacob: > Fix the following build error with latest glib-headers( > Part of aarch64-linux-gnu-gcc-7.3.0 toolchain) > > In file included from /tmp/drivers/bus/fslmc/mc/fsl_mc_sys.h:30:0, > from /tmp/drivers/bus/fslmc/mc/dpmng.c:7: > /usr/aarch64-linux-gnu/usr

Re: [dpdk-dev] [PATCH v2] bus/dpaa: fix dpaa returning IOVA as PA by default

2018-02-06 Thread Thomas Monjalon
06/02/2018 18:28, Hemant Agrawal: > On 2/6/2018 10:52 PM, Pavan Nikhilesh wrote: > > Fix dpaa bus returning IOVA as PA even when it is not running on dpaa > > platform. > > > > Fixes: 1ee9569576f6 ("config: enable dpaaX drivers for generic ARMv8") > > Fixes: d5a4e3a00c4a ("bus/dpaa: set IOVA mode

Re: [dpdk-dev] [PATCH] ether: fix incorrect stats query for lowest xstat id

2018-02-06 Thread Ferruh Yigit
On 2/6/2018 4:06 PM, Bruce Richardson wrote: > When querying either the name or the value of a stat using the xstats > APIs, a check is done to see if the regular stats API or the xstats APIs > for the driver need to be used. However, the id of the stat requested is > checked to see if it is greate

Re: [dpdk-dev] [PATCH] ether: fix incorrect stats query for lowest xstat id

2018-02-06 Thread Thomas Monjalon
06/02/2018 17:06, Bruce Richardson: > When querying either the name or the value of a stat using the xstats > APIs, a check is done to see if the regular stats API or the xstats APIs > for the driver need to be used. However, the id of the stat requested is > checked to see if it is greater than th

Re: [dpdk-dev] [PATCH v2] bbdev: fix exported dynamic log type

2018-02-06 Thread Thomas Monjalon
06/02/2018 14:29, Amr Mokhtar: > This patch fixes shared library compilation due to undefined > reference to an exported variable 'bbdev_logtype'. > > v2: > * In this fix, > * - The logtype has become static and owned individually by each > *component. > * - Helper logging macros are removed f

Re: [dpdk-dev] [PATCH v2] examples/l2fwd: check if user portmask is valid

2018-02-06 Thread Thomas Monjalon
> > User can pass portmask with any value, even invalid mask. The code checks > > against actual portmask. > > > > Signed-off-by: Vipin Varghese > > --- > > > > V2 Changes: > > - correct the spelling in comment - Vipin > > I think there is no need to CC stable here, so I will remove it from th

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-02-06 Thread Ravi Kerur
On Mon, Feb 5, 2018 at 2:01 AM, Burakov, Anatoly wrote: > On 02-Feb-18 8:51 PM, Ravi Kerur wrote: > >> >> >> On Fri, Feb 2, 2018 at 12:21 PM, Ravi Kerur > rke...@gmail.com>> wrote: >> >> >> >> On Fri, Feb 2, 2018 at 2:28 AM, Burakov, Anatoly >> mailto:anatoly.bura...@intel.com>> wrote: >>

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix timer_period unit

2018-02-06 Thread Singh, Jasvinder
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of > long...@viettel.com.vn > Sent: Wednesday, January 31, 2018 8:48 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; longtb5 > Subject: [dpdk-dev] [PATCH] examples/ip_pipeline: fix timer_period unit > > The time

Re: [dpdk-dev] [PATCH v5 1/6] test: fix memory leak in bitmap test

2018-02-06 Thread Thomas Monjalon
06/02/2018 14:35, Anatoly Burakov: > Acked-by: Cristian Dumitrescu > > Fixes: c7e4a134e769 ("test: verify bitmap operations") > Cc: pbhagavat...@caviumnetworks.com > Signed-off-by: Anatoly Burakov Series applied, thanks

[dpdk-dev] EAL reports "ot enough memory available on socket 0!"

2018-02-06 Thread Huertas García , Víctor
Hi all, This is my first post in this mailing list. I am glad to become a member of this community. I am a newbie using DPDK and I have tried to compile and execute an example app called "l3fwd-acl". The DPDK command is DPDK_Test -c 0xf0 -n 2 --socket-mem 64 but the application tells me th

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix timer_period unit

2018-02-06 Thread Thomas Monjalon
> > The timer_period option specified by users via config file should have unit > > of > > 1 millisecond. However timer_period is internally converted to unit of 10 > > millisecond. > > > > Fixes: 4e14069328fc ("examples/ip_pipeline: measure CPU utilization") Cc: sta...@dpdk.org > > Signed-off-

Re: [dpdk-dev] [PATCH v2] eventdev: fix unchecked return in default Rx adapter conf cb

2018-02-06 Thread Jerin Jacob
-Original Message- > Date: Sun, 4 Feb 2018 23:48:31 +0530 > From: Nikhil Rao > To: dev@dpdk.org > CC: nikhil@intel.com, vipin.vargh...@intel.com, > deepak.k.j...@intel.com, jerin.ja...@caviumnetworks.com > Subject: [PATCH v2] eventdev: fix unchecked return in default Rx adapter > con

Re: [dpdk-dev] [PATCH v2] eventdev: fix unchecked return in default Rx adapter conf cb

2018-02-06 Thread Thomas Monjalon
> > The default adapter configuration callback is invoked when a Rx > > queue is added to the adapter and the adapter detects that a SW > > service is needed. The adapter needs to re-configure the device > > with an additional port and to do do, it needs to stop the > > device and restart it after

Re: [dpdk-dev] [PATCH] doc: remove UTF-8 BOM from programmer's guide

2018-02-06 Thread Thomas Monjalon
> > Fixes: 55694b2a9f64 ("doc: add membership documentation") > > Cc: yipeng1.w...@intel.com > > Signed-off-by: Anatoly Burakov > > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH] doc: add info on hyperthreading to power library

2018-02-06 Thread Thomas Monjalon
06/02/2018 14:27, Kovacevic, Marko: > > Signed-off-by: David Hunt > > --- > > doc/guides/prog_guide/power_man.rst | 8 > > 1 file changed, 8 insertions(+) > > > > diff --git a/doc/guides/prog_guide/power_man.rst > > b/doc/guides/prog_guide/power_man.rst > > <...> > > Acked-by: Marko K

Re: [dpdk-dev] [PATCH v3] net/virtio-user: fix unchecked return value

2018-02-06 Thread Thomas Monjalon
14/11/2017 11:39, SebastianX Basierski: > Report error message if clearing O_NONBLOCK flag will fail, > then return from function. > > Coverity issue: 143439 > > Fixes: ef53b6030039 ("net/virtio-user: support LSC") > Cc: jianfeng@intel.com > Cc: y...@fridaylinux.org > cc: dev@dpdk.org > > Si

Re: [dpdk-dev] [PATCH v2] net/bonding: fix link status check

2018-02-06 Thread Thomas Monjalon
17/01/2018 17:02, Ferruh Yigit: > On 11/29/2017 3:42 PM, Tomasz Kulasek wrote: > > Some devices needs more time to initialize and bring interface up. When > > link is down the link properties are not valid, e.g. link_speed is > > reported as 0 and this is not a valid speed for slave as well as for

Re: [dpdk-dev] Q: uio_generic_pci

2018-02-06 Thread Stephen Hemminger
On Tue, 6 Feb 2018 12:57:15 +0200 Ran Shalit wrote: > Hello, > > I would please like to ask about uio_generic_pci : > > 1. how to set irq from userspace. No. that is not generally possible. It is expected that the IRQ will come from the hardware device. On some hardware it is possible to poke

Re: [dpdk-dev] [PATCH] examples/ptpclient: fix Tx configuration

2018-02-06 Thread Thomas Monjalon
01/02/2018 17:42, Pablo de Lara: > The PTP Client application requires IEEE1588 to be supported > by the network driver used, which needs full Tx data path > to be used. > > Fixes: b960219b0d83 ("examples/ptpclient: convert to new ethdev offloads API") > > Signed-off-by: Pablo de Lara Applied,

Re: [dpdk-dev] EAL reports "ot enough memory available on socket 0!"

2018-02-06 Thread Wiles, Keith
> On Feb 6, 2018, at 12:38 PM, Huertas García, Víctor wrote: > > Hi all, > > > This is my first post in this mailing list. I am glad to become a member of > this community. > > > I am a newbie using DPDK and I have tried to compile and execute an example > app called "l3fwd-acl". > > >

Re: [dpdk-dev] [PATCH v3] doc: update definition of lcore id and lcore index

2018-02-06 Thread Thomas Monjalon
> > Added examples in lcore index for better explanation on various examples, > > Sited examples for lcore id. > > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH v3] doc: add info on multiple instance SW crypto

2018-02-06 Thread Thomas Monjalon
> > Add infomration to explain applications using multiple instances of sw > > crypto with example. > > > > Signed-off-by: Vipin Varghese > > Typo: instances (which could be fixed when merging). > > Also, there is no need to add sta...@dpdk.org, so I will remove it from the > CC list. > > Apa

Re: [dpdk-dev] [PATCH v2] doc: update application minimum requirement info

2018-02-06 Thread Thomas Monjalon
> > Added note section to update information for use cases working with > > multiple crypto devices. > > > > Signed-off-by: Vipin Varghese > > Acked-by: Pablo de Lara Applied, thanks

  1   2   >