[dpdk-dev] [PATCH v1] net/axgbe: swupport flow control API

2020-01-27 Thread asomalap
From: Amaranath Somalapuram adding api for flow_ctrl_get and flow_ctrl_set by default axgbe driver flow control is dissabled adding dpdk flow control to set water high and low Signed-off-by: Amaranath Somalapuram --- drivers/net/axgbe/axgbe_ethdev.c | 85 +++- drive

[dpdk-dev] [PATCH 9/9] net/bnxt: fix coverity warnings

2020-01-27 Thread Somnath Kotur
From: Kalesh AP return value stored in "ret" but it has been overwritten before use. CID 353621: Code maintainability issues (UNUSED_VALUE) Fixes: 57813868 ("net/bnxt: fix VLAN strip") Fixes: df6cd7c1 ("net/bnxt: handle reset notify async event from FW") Signed-off-by: Kalesh AP Reviewed-by:

[dpdk-dev] [PATCH 7/9] net/bnxt: remove a redundant variable

2020-01-27 Thread Somnath Kotur
From: Kalesh AP Use "dev->data->dev_started" state, instead of local "dev_stopped" to check whether port has been started or not. Fixes: 316e412299fd ("net/bnxt: fix crash when closing") Reviewed-by: Santoshkumar Karanappa Rastapur Reviewed-by: Somnath Kotur Signed-off-by: Somnath Kotur ---

[dpdk-dev] [PATCH 8/9] net/bnxt: fix to support zero mark id along with RSS action

2020-01-27 Thread Somnath Kotur
Certain applications(Ex: OVS-DPDK) can issue rte_flow_create with mark id set to 0. The mark table entry creation in the driver was assuming non-zero mark ids. Fix it to have a valid flag for each entry. Also, it is possible that both RSS flags and cfa_code/ mark id are set as part of the Rx packet

[dpdk-dev] [PATCH 3/9] net/bnxt: fix to allow group ID 0 for RSS action

2020-01-27 Thread Somnath Kotur
Allow RSS action with group ID 0. The RSS match check will ensure if requested RSS action configuration parameters should be allowed as per the VNIC's RSS configuration or not and if it does match as it is by design in OVS-DPDK use case, the default vnic can be used to create the filter. As part of

[dpdk-dev] [PATCH 6/9] net/bnxt: remove unnecessary structure variable

2020-01-27 Thread Somnath Kotur
From: Kalesh AP This change could help in reducing the size of bnxt PMD private data structure by converting a uint8_t variable to use bit map flag. Fixes: 5cd0e2889c432 ("net/bnxt: support NIC Partitioning") Reviewed-by: Santoshkumar Karanappa Rastapur Reviewed-by: Somnath Kotur Signed-off-b

[dpdk-dev] [PATCH 4/9] net/bnxt: remove redundant if statement

2020-01-27 Thread Somnath Kotur
From: Kalesh AP Since "eth_dev->data->dev_started" has been assigned to 0 at the beginning of bnxt_dev_stop_op() routine, the code inside the if() condition is redundant. Remove it. Anyways "eth_dev->data->dev_link.link_status" will be set to 0 in bnxt_dev_set_link_down_op() later in the routine

[dpdk-dev] [PATCH 5/9] net/bnxt: remove redundant macro

2020-01-27 Thread Somnath Kotur
From: Kalesh AP Use "dev->data->dev_started" state, instead of local BNXT_FLAG_INIT_DONE to check whether device has been initialised or not. Fixes: ed2ced6fe927 ("net/bnxt: check initialization before accessing stats") Reviewed-by: Santoshkumar Karanappa Rastapur Reviewed-by: Ajit Kumar Khapa

[dpdk-dev] [PATCH 1/9] net/bnxt: fix bnxt_alloc_filter() to use a common routine

2020-01-27 Thread Somnath Kotur
Invoke bnxt_get_unused_filter() inside bnxt_alloc_filter() so that all filters are allocated from one common routine. Fixes: f92735db1e4c ("net/bnxt: add L2 filter alloc/init/free") Reviewed-by: Kalesh Anakkur Purayil Signed-off-by: Somnath Kotur --- drivers/net/bnxt/bnxt_filter.c | 4 +--- 1

[dpdk-dev] [PATCH v2 0/9] bnxt patchset

2020-01-27 Thread Somnath Kotur
Please apply. Kalesh AP (5): net/bnxt: remove redundant if statement net/bnxt: remove redundant macro net/bnxt: remove unnecessary structure variable net/bnxt: remove a redundant variable net/bnxt: fix coverity warnings Somnath Kotur (4): net/bnxt: fix bnxt_alloc_filter() to use a com

[dpdk-dev] [PATCH 2/9] net/bnxt: fix bumping of L2 filter reference count

2020-01-27 Thread Somnath Kotur
Now that the L2 filter reference count is bumped up in all cases including bnxt_alloc_filter() which is issued in init, just move this ref count bump inside the routine issuing the HWRM cmd so that it is bumped up only if the cmd is successful. Fixes: f0f6b5e6cf94 ("fix reusing L2 filter") Review

Re: [dpdk-dev] [PATCH v2 2/2] examples/crypto: crypto test application

2020-01-27 Thread Akhil Goyal
Hi, > > From: Sardar Shamsher Singh > > test application to test Cipher/Authentication/AEAD in AMD CCP > a crypto controller. This test application can be used as > reference to develop/test crypto algo. > > Signed-off-by: Sardar Shamsher Singh > --- Why do you need a separate example applicat

[dpdk-dev] [PATCH 7/8] net/bnxt: remove a redundant variable

2020-01-27 Thread Somnath Kotur
From: Kalesh AP Use "dev->data->dev_started" state, instead of local "dev_stopped" to check whether port has been started or not. Fixes: 316e412299fd ("net/bnxt: fix crash when closing") Reviewed-by: Santoshkumar Karanappa Rastapur Reviewed-by: Somnath Kotur Signed-off-by: Kalesh AP --- dri

[dpdk-dev] [PATCH 6/8] net/bnxt: remove unnecessary structure variable

2020-01-27 Thread Somnath Kotur
From: Kalesh AP This change could help in reducing the size of bnxt PMD private data structure by converting a uint8_t variable to use bit map flag. Fixes: 5cd0e2889c432 ("net/bnxt: support NIC Partitioning") Reviewed-by: Santoshkumar Karanappa Rastapur Reviewed-by: Somnath Kotur Signed-off-b

[dpdk-dev] [PATCH 3/8] net/bnxt: fix to allow group ID 0 for RSS action

2020-01-27 Thread Somnath Kotur
Allow RSS action with group ID 0. The RSS match check will ensure if requested RSS action configuration parameters should be allowed as per the VNIC's RSS configuration or not and if it does match as it is by design in OVS-DPDK use case, the default vnic can be used to create the filter. As part of

[dpdk-dev] [PATCH 8/8] net/bnxt: fix to support zero mark id along with RSS action

2020-01-27 Thread Somnath Kotur
Certain applications(Ex: OVS-DPDK) can issue rte_flow_create with mark id set to 0. The mark table entry creation in the driver was assuming non-zero mark ids. Fix it to have a valid flag for each entry. Also, it is possible that both RSS flags and cfa_code/ mark id are set as part of the Rx packet

[dpdk-dev] [PATCH 2/8] net/bnxt: fix bumping of L2 filter reference count

2020-01-27 Thread Somnath Kotur
Now that the L2 filter reference count is bumped up in all cases including bnxt_alloc_filter() which is issued in init, just move this ref count bump inside the routine issuing the HWRM cmd so that it is bumped up only if the cmd is successful. Fixes: f0f6b5e6cf94 ("fix reusing L2 filter") Review

[dpdk-dev] [PATCH 5/8] net/bnxt: remove redundant macro

2020-01-27 Thread Somnath Kotur
From: Kalesh AP Use "dev->data->dev_started" state, instead of local BNXT_FLAG_INIT_DONE to check whether device has been initialised or not. Fixes: ed2ced6fe927 ("net/bnxt: check initialization before accessing stats") Reviewed-by: Santoshkumar Karanappa Rastapur Reviewed-by: Ajit Kumar Khapa

[dpdk-dev] [PATCH 4/8] net/bnxt: remove redundant if statement

2020-01-27 Thread Somnath Kotur
From: Kalesh AP Since "eth_dev->data->dev_started" has been assigned to 0 at the beginning of bnxt_dev_stop_op() routine, the code inside the if() condition is redundant. Remove it. Anyways "eth_dev->data->dev_link.link_status" will be set to 0 in bnxt_dev_set_link_down_op() later in the routine

[dpdk-dev] [PATCH 1/8] net/bnxt: fix bnxt_alloc_filter() to use a common routine

2020-01-27 Thread Somnath Kotur
Invoke bnxt_get_unused_filter() inside bnxt_alloc_filter() so that all filters are allocated from one common routine. Fixes: f92735db1e4c ("net/bnxt: add L2 filter alloc/init/free") Reviewed-by: Kalesh Anakkur Purayil Signed-off-by: Somnath Kotur --- drivers/net/bnxt/bnxt_filter.c | 4 +--- 1

[dpdk-dev] [PATCH 0/8] bnxt patch set

2020-01-27 Thread Somnath Kotur
Please apply. Kalesh AP (4): net/bnxt: remove redundant if statement net/bnxt: remove redundant macro net/bnxt: remove unnecessary structure variable net/bnxt: remove a redundant variable Somnath Kotur (4): net/bnxt: fix bnxt_alloc_filter() to use a common routine net/bnxt: fix bumpin

Re: [dpdk-dev] [PATCH v1] crypto/ccp: aes-gcm driver bug fix

2020-01-27 Thread Akhil Goyal
> > Looks good to me. > > Acked-by: Ravi Kumar > > Regards, > Ravi > > > > > > > >fixes ccp crypto driver to make aes-gcm output match with openssl/NIST > output > > > >Signed-off-by: Selwin Sebastian > >--- Please mention commit id for the original patch for which this fix is submitted. "Fi

Re: [dpdk-dev] [PATCH v2 1/1] test/crypto: remove repeated test and enable on QAT

2020-01-27 Thread Akhil Goyal
> > > > Remove one AES GCM scatter-gather unit test repetition > > and enable this test on QAT (after a fix included in the commit > > b26ef1a11f21). > > > > Fixes: 157d0b11d204 ("test/crypto: add capability checks") > > Fixes: b26ef1a11f21 ("test/crypto: fix missing operation status check") > > >

Re: [dpdk-dev] [PATCH 1/2] crypto/dpaa_sec: fix performance issue

2020-01-27 Thread Akhil Goyal
> > DPAA sec driver is using virtual to physical address > translation in its data path and driver is using > dpaax_iova_table_update() API in every address translation > which is very costly. > This patch moves dpaax_iova_table_update() calling to rte_dpaa_mem_ptov(), > only if it fails to found

Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto:skip dev configure for masked devices

2020-01-27 Thread Akhil Goyal
> > The devices which are masked by cryptodev mask should not be initialized > and skipped while traversing the device list. > > Fixes: 61a7018ba0 ("examples/l2fwd-crypto:skip dev configure for masked > devices") > Cc: sta...@dpdk.org > > Signed-off-by: Apeksha Gupta > --- Acked-by: Akhil Goy

Re: [dpdk-dev] [PATCH v1] crypto/ccp: add support for new CCP device ID

2020-01-27 Thread Akhil Goyal
> > > Looks good to me. > > Acked-by: Ravi Kumar > Applied to dpdk-next-crypto Thanks

Re: [dpdk-dev] [PATCH] test/compress: add cycle-count mode to the perf tool

2020-01-27 Thread Akhil Goyal
> > > > This commit adds cycle-count mode to the compression perf tool. > > The new mode enhances the compression performance tool to allow > > cycle-count measurement of both hardware and softwate PMDs. > > > > Signed-off-by: Artur Trybula > Acked-by: Fiona Trahe Applied to dpdk-next-crypto Th

Re: [dpdk-dev] [PATCH] event/dsw: use custom element size ring for control

2020-01-27 Thread Jerin Jacob
On Wed, Jan 22, 2020 at 10:36 AM Honnappa Nagarahalli wrote: > > > > > Subject: [PATCH] event/dsw: use custom element size ring for control > > > > Replace DSW's use of regular DPDK rings (and code for packing/unpacking > > control messages into void pointers) with custom size rings. > > > > In a

[dpdk-dev] [PATCH v6 09/11] examples/l3fwd: add event em main loop

2020-01-27 Thread pbhagavatula
From: Pavan Nikhilesh Add em main loop for handling events based on capabilities of the event device. Signed-off-by: Pavan Nikhilesh --- examples/l3fwd/l3fwd.h | 10 ++ examples/l3fwd/l3fwd_em.c| 177 +++ examples/l3fwd/l3fwd_em.h|

[dpdk-dev] [PATCH v6 11/11] doc: update l3fwd user guide to support eventdev

2020-01-27 Thread pbhagavatula
From: Pavan Nikhilesh Update l3fwd user guide to include event device related information. Update release notes and MAINTAINERS file. Signed-off-by: Pavan Nikhilesh --- MAINTAINERS | 1 + doc/guides/rel_notes/release_20_02.rst | 5 ++ doc/guides/sample_app_ug/l3_

[dpdk-dev] [PATCH v6 06/11] examples/l3fwd: add event eth Rx/Tx adapter setup

2020-01-27 Thread pbhagavatula
From: Pavan Nikhilesh Add event eth Rx/Tx adapter setup for both generic and internal port event device pipelines. Signed-off-by: Sunil Kumar Kori Signed-off-by: Pavan Nikhilesh --- examples/l3fwd/l3fwd_event.c | 3 + examples/l3fwd/l3fwd_event.h | 1 + example

[dpdk-dev] [PATCH v6 07/11] examples/l3fwd: add service core setup based on caps

2020-01-27 Thread pbhagavatula
From: Pavan Nikhilesh Add service core setup when eventdev and Rx/Tx adapter don't have internal port capability. Signed-off-by: Pavan Nikhilesh --- examples/l3fwd/l3fwd_event.c | 6 ++ examples/l3fwd/main.c| 188 +++ 2 files changed, 150 insertions(+)

[dpdk-dev] [PATCH v6 10/11] examples/l3fwd: add graceful teardown for eventdevice

2020-01-27 Thread pbhagavatula
From: Pavan Nikhilesh Add graceful teardown that addresses both event mode and poll mode. Signed-off-by: Pavan Nikhilesh --- examples/l3fwd/main.c | 50 +-- 1 file changed, 34 insertions(+), 16 deletions(-) diff --git a/examples/l3fwd/main.c b/examples/

[dpdk-dev] [PATCH v6 08/11] examples/l3fwd: add event lpm main loop

2020-01-27 Thread pbhagavatula
From: Pavan Nikhilesh Add lpm main loop for handling events based on capabilities of the event device. Signed-off-by: Pavan Nikhilesh --- examples/l3fwd/l3fwd.h | 9 ++ examples/l3fwd/l3fwd_event.c | 9 ++ examples/l3fwd/l3fwd_event.h | 5 + examples/l3fwd/l3fwd_lpm.c | 203 +

[dpdk-dev] [PATCH v6 05/11] examples/l3fwd: add event port and queue setup

2020-01-27 Thread pbhagavatula
From: Sunil Kumar Kori Add event device queue and port setup based on event eth Tx adapter capabilities. Signed-off-by: Sunil Kumar Kori --- examples/l3fwd/l3fwd_event.c | 28 +- examples/l3fwd/l3fwd_event.h | 1 + examples/l3fwd/l3fwd_event_generic.c |

[dpdk-dev] [PATCH v6 03/11] examples/l3fwd: add event device configuration

2020-01-27 Thread pbhagavatula
From: Pavan Nikhilesh Add event device configuration based on the capabilities of the probed event device. Signed-off-by: Pavan Nikhilesh --- examples/l3fwd/l3fwd_event.c | 3 + examples/l3fwd/l3fwd_event.h | 36 ++ examples/l3fwd/l3fwd_event_generic.c

[dpdk-dev] [PATCH v6 04/11] examples/l3fwd: add ethdev setup based on eventdev

2020-01-27 Thread pbhagavatula
From: Sunil Kumar Kori Add ethernet port Rx/Tx queue setup for event device which are later used for setting up event eth Rx/Tx adapters. Signed-off-by: Sunil Kumar Kori Signed-off-by: Nipun Gupta --- examples/l3fwd/l3fwd.h | 10 +++ examples/l3fwd/l3fwd_event.c | 138 +

[dpdk-dev] [PATCH v6 02/11] examples/l3fwd: split pipelines based on capability

2020-01-27 Thread pbhagavatula
From: Sunil Kumar Kori Add infra to split eventdev framework based on event Tx adapter capability. If event Tx adapter has internal port capability then we use `rte_event_eth_tx_adapter_enqueue` to transmitting packets else we use a SINGLE_LINK event queue to enqueue packets to a service core whi

[dpdk-dev] [PATCH v6 00/11] example/l3fwd: introduce event device support

2020-01-27 Thread pbhagavatula
From: Pavan Nikhilesh This patchset adds support for event mode in l3fwd. The poll mode is still the default mode of operation. The following new command line parameters are added: --mode: Dictates the mode of operation either poll or event. If unset then by default poll mode is used.

[dpdk-dev] [PATCH v6 01/11] examples/l3fwd: add framework for event device

2020-01-27 Thread pbhagavatula
From: Sunil Kumar Kori Add framework to enable event device as a producer of packets. To switch between event mode and poll mode the following options have been added: `--mode="eventdev"` or `--mode="poll"` Allow the user to select the schedule type to be either RTE_SCHED_TYPE_ORDERED, RT

Re: [dpdk-dev] [PATCH v2 00/12] add eventmode to ipsec-secgw

2020-01-27 Thread Anoob Joseph
Hi Akhil, Konstantin, Do you have any further comments? Thanks, Anoob > -Original Message- > From: dev On Behalf Of Anoob Joseph > Sent: Monday, January 20, 2020 7:15 PM > To: Akhil Goyal ; Radu Nicolau > ; Thomas Monjalon > Cc: Anoob Joseph ; Jerin Jacob Kollanukkaran > ; Narayana Pra

[dpdk-dev] [PATCH v4 6/8] examples/ipsec-secgw: cpu crypto support

2020-01-27 Thread Marcin Smoczynski
Add support for CPU accelerated crypto. 'cpu-crypto' SA type has been introduced in configuration allowing to use abovementioned acceleration. Legacy mode is not currently supported. Signed-off-by: Konstantin Ananyev Signed-off-by: Marcin Smoczynski --- examples/ipsec-secgw/ipsec.c |

[dpdk-dev] [PATCH v4 7/8] examples/ipsec-secgw: cpu crypto testing

2020-01-27 Thread Marcin Smoczynski
Enable cpu-crypto mode testing by adding dedicated environmental variable CRYPTO_PRIM_TYPE. Setting it to 'type cpu-crypto' allows to run test scenario with cpu crypto acceleration. Signed-off-by: Konstantin Ananyev Signed-off-by: Marcin Smoczynski --- examples/ipsec-secgw/test/common_defs.sh

[dpdk-dev] [PATCH v4 8/8] doc: add cpu crypto related documentation

2020-01-27 Thread Marcin Smoczynski
Update documentation with a description of cpu crypto in cryptodev, ipsec and security libraries. Add release notes for 20.02. Signed-off-by: Marcin Smoczynski --- doc/guides/cryptodevs/aesni_gcm.rst | 5 doc/guides/prog_guide/cryptodev_lib.rst | 31 + doc/guid

[dpdk-dev] [PATCH v4 5/8] ipsec: introduce support for cpu crypto mode

2020-01-27 Thread Marcin Smoczynski
Update library to handle CPU cypto security mode which utilizes cryptodev's synchronous, CPU accelerated crypto operations. Signed-off-by: Konstantin Ananyev Signed-off-by: Marcin Smoczynski --- lib/librte_ipsec/esp_inb.c | 154 ++- lib/librte_ipsec/esp_outb.c

[dpdk-dev] [PATCH v4 4/8] security: add cpu crypto action type

2020-01-27 Thread Marcin Smoczynski
Introduce CPU crypto action type allowing to differentiate between regular async 'none security' and synchronous, CPU crypto accelerated sessions. Signed-off-by: Marcin Smoczynski --- lib/librte_security/rte_security.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/

[dpdk-dev] [PATCH v4 3/8] test/crypto: add CPU crypto tests

2020-01-27 Thread Marcin Smoczynski
Add unit and performance tests for CPU crypto mode currently implemented by AESNI-GCM cryptodev. Unit tests cover AES-GCM and GMAC test vectors. Signed-off-by: Marcin Smoczynski --- app/test/Makefile | 1 + app/test/cpu_crypto_all_gcm_perf_test_cases.h | 11 + app/

[dpdk-dev] [PATCH v4 2/8] crypto/aesni_gcm: cpu crypto support

2020-01-27 Thread Marcin Smoczynski
Add support for CPU crypto mode by introducing required handler. Crypto mode (sync/async) is chosen during sym session create if an appropriate flag is set in an xform type number. Authenticated encryption and decryption are supported with tag generation/verification. Signed-off-by: Marcin Smoczy

[dpdk-dev] [PATCH v4 1/8] cryptodev: introduce cpu crypto support API

2020-01-27 Thread Marcin Smoczynski
Add new API allowing to process crypto operations in a synchronous manner. Operations are performed on a set of SG arrays. Sync mode is selected by setting appropriate flag in an xform type number. Cryptodevs which allows CPU crypto operation mode have to use RTE_CRYPTODEV_FF_SYM_CPU_CRYPTO capabi

[dpdk-dev] [PATCH v4 0/8] Introduce CPU crypto mode

2020-01-27 Thread Marcin Smoczynski
Originally both SW and HW crypto PMDs use rte_crypot_op based API to process the crypto workload asynchronously. This way provides uniformity to both PMD types, but also introduce unnecessary performance penalty to SW PMDs that have to "simulate" HW async behavior (crypto-ops enqueue/dequeue, HW ad

Re: [dpdk-dev] [PATCH v5 8/9] build: add additional common files support

2020-01-27 Thread Thomas Monjalon
13/01/2020 22:55, Pallavi Kadam: > Added support for additional common files in meson build > to expand Windows EAL and to support the lcore parsing > feature on Windows. > > Signed-off-by: Pallavi Kadam > Signed-off-by: Antara Ganesh Kolar > Reviewed-by: Ranjit Menon > Reviewed-by: Keith Wiles

Re: [dpdk-dev] [PATCH v5 7/9] eal: remove syslog support for windows

2020-01-27 Thread Thomas Monjalon
13/01/2020 22:55, Pallavi Kadam: > Added #ifndef WIN64 to exclude syslog definitions and parameters > from Windows builds. > > Signed-off-by: Pallavi Kadam > Reviewed-by: Ranjit Menon > --- > --- a/lib/librte_eal/common/eal_common_options.c > +++ b/lib/librte_eal/common/eal_common_options.c > @@

Re: [dpdk-dev] [PATCH v5 3/9] eal: add windows compatible header files

2020-01-27 Thread Thomas Monjalon
13/01/2020 22:55, Pallavi Kadam: > Modified \common\include\arch\x86\rte_vect.h > to include SSE4 header for Windows. > > Adding dlfcn.h on Windows to support common code. > > Adding eal_filesystem.h to support functions and > path defines for files and directories on Windows. I don't see any re

[dpdk-dev] ACL priority field

2020-01-27 Thread Bly, Mike
Hello, Can someone clarify what I am interpreting as a documentation conflict regarding the "priority" field for rte_table_acl_rule_add_params? Below documentation says "highest priority wins", but the header file comment says 0 is highest priority. Based on my testing with conflicting entries

[dpdk-dev] [PATCH] bpf: properly install headers in meson build

2020-01-27 Thread Junxiao Shi
Previously, when librte_bpf is built with meson+ninja, its headers such as bpf_def is not installed to the system. This commit fixes this problem. Fixes: 94972f3 ("bpf: add BPF loading and execution framework") Signed-off-by: Junxiao Shi --- lib/librte_bpf/meson.build | 2 +- 1 file changed, 1

[dpdk-dev] [PATCH v2] net/regexdev: introduce regexdev subsystem

2020-01-27 Thread Ori Kam
Even though there are some vendors which offer Regex HW offload, due to lack of standard API, It is diffcult for DPDK consumer to use them in a portable way. This _RFC_ attempts to standardize the RegEx/DPI offload APIs for DPDK. This RFC crafted based on SW Regex API frameworks such as libpcre a

[dpdk-dev] [PATCH] drivers/crypto: fix set_sym_session_private_data error in sessionless mode

2020-01-27 Thread Junxiao Shi
When OpenSSL or AESNI-MB cryptodev is being used in sessionless mode for symmetric crypto operation (e.g. SHA256 hash), the driver prints error message: CRYPTODEV: set_sym_session_private_data() line 489: Set private data for driver 0 not allowed Then, AESNI-MB driver segfaults

Re: [dpdk-dev] [PATCH v2 1/5] mk/icc: disable treatment of warnings as errors

2020-01-27 Thread Thomas Monjalon
27/01/2020 16:37, Ferruh Yigit: > On 1/24/2020 7:37 PM, Thomas Monjalon wrote: > > 24/01/2020 17:36, Ferruh Yigit: > >> On 1/23/2020 6:20 PM, Alexander Kozyrev wrote: > >>> Remove -Werror-all flag in ICC configuration file to stop treating ICC > >>> warnings as errors in DPDK due to many false posi

Re: [dpdk-dev] [RFC] DPDK Trace support

2020-01-27 Thread Jerin Jacob
On Mon, Jan 27, 2020 at 9:43 PM Aaron Conole wrote: > > Jerin Jacob Kollanukkaran writes: > > > Hi All, > > > > I would like to add tracing support for DPDK. > > I am planning to add this support in v20.05 release. > > > > This RFC attempts to get feedback from the community on > > > > a) Tracing

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: use correct RFC addresses for tx-only

2020-01-27 Thread Ferruh Yigit
On 1/27/2020 3:34 AM, Stephen Hemminger wrote: > The previous patch to change default IP addresses for tx only > mode got the wrong values (typo). > > Fixes: bf5b2126bf44 ("app/testpmd: add ability to set Tx IP and UDP > parameters") > Cc: sta...@dpdk.org > Signed-off-by: Stephen Hemminger > ---

Re: [dpdk-dev] [PATCH v5 00/11] example/l3fwd: introduce event device support

2020-01-27 Thread Jerin Jacob
On Fri, Jan 24, 2020 at 9:35 AM wrote: > > From: Pavan Nikhilesh > > This patchset adds support for event mode in l3fwd. > The poll mode is still the default mode of operation. > > The following new command line parameters are added: > --mode: Dictates the mode of operation either poll or event.

Re: [dpdk-dev] [RFC] DPDK Trace support

2020-01-27 Thread Aaron Conole
Jerin Jacob Kollanukkaran writes: > Hi All, > > I would like to add tracing support for DPDK. > I am planning to add this support in v20.05 release. > > This RFC attempts to get feedback from the community on > > a) Tracing Use cases. > b) Tracing Requirements. > b) Implementation choices. > c) T

[dpdk-dev] [PATCH v2 4/4] net/mlx: workaround static linkage with meson

2020-01-27 Thread Thomas Monjalon
If ibverbs_link is static and the application choose to link DPDK as static libraries, both PMD and ibverbs libraries must be linked as static libraries. And the dependencies of ibverbs (netlink) must still be linked as shared libraries. Unfortunately, meson forget about the static requirement for

[dpdk-dev] [PATCH v2 1/4] net/mlx: add static ibverbs linkage with meson

2020-01-27 Thread Thomas Monjalon
The libibverbs (and libmlx4/5) can be statically embedded in the shared PMD library, or in the application with the static PMD. It was supported with make build system in commit 2c0dd7b69fb0 ("config: add static linkage of mlx dependency"). The same feature is enabled with meson when using pkg-con

[dpdk-dev] [PATCH v2 0/4] add static ibverbs in meson

2020-01-27 Thread Thomas Monjalon
This is the follow-up of the feature I added one year ago: static linkage of libibverbs in mlx PMDs. The first implementation was focused on "make". This second round does the same with "meson". changes in v2: - split mlx patch for normal addition and workarounds - fix ldflags for ibverbs install

[dpdk-dev] [PATCH v2 3/4] build: allow hiding dependencies from pkg-config

2020-01-27 Thread Thomas Monjalon
If a dependency is required for a driver build, but should not be exposed to the application (via pkg-config), it can be declared in the array hidden_deps. The hidden_deps are used as internal dependencies, when building the shared library and the first stage of static library. The final static li

[dpdk-dev] [PATCH v2 2/4] buildtools: get static mlx dependencies for meson

2020-01-27 Thread Thomas Monjalon
The shell script options-ibverbs-static.sh was used with make in forcing static linkage of ibverbs libraries. When choosing to link with a static dependency in meson, the generated .pc file will not force such static linkage. The solution will rely on using this script in meson. If linking with l

Re: [dpdk-dev] [PATCH v2 1/5] mk/icc: disable treatment of warnings as errors

2020-01-27 Thread Ferruh Yigit
On 1/24/2020 7:37 PM, Thomas Monjalon wrote: > 24/01/2020 17:36, Ferruh Yigit: >> On 1/23/2020 6:20 PM, Alexander Kozyrev wrote: >>> Remove -Werror-all flag in ICC configuration file to stop treating ICC >>> warnings as errors in DPDK due to many false positives. We are using >>> GCC and Clang as a

Re: [dpdk-dev] [dpdk-web] DPDK Programmer's Guide :ERRATA

2020-01-27 Thread Honnappa Nagarahalli
Thanks Prateek for the comments. Agree with both the corrections. Would you like to submit a patch? Thanks, Honnappa > -Original Message- > From: Thomas Monjalon > Sent: Sunday, January 26, 2020 3:36 PM > To: prateekag > Cc: dev@dpdk.org; Honnappa Nagarahalli > Subject: Re: [dpdk-web]

Re: [dpdk-dev] [PATCH v2 00/15] add OCTEONTX2 inline IPsec support

2020-01-27 Thread Anoob Joseph
Hi Jerin, Akhil, Let me summarize the design changes from the discussions below. Currently, drivers/crypto/octeontx2/otx2_security.c defines all security ctx ops for the ethdev (idea was to add all crypto security ctx for lookaside also there). That will be moved to drivers/net/octeontx2 as is.

[dpdk-dev] [PATCH v3 3/5] net/mlx4: introduce the mlx4 version of the assert

2020-01-27 Thread Alexander Kozyrev
Use the MLX4_ASSERT macros instead of the standard assert clause. Depends on the RTE_LIBRTE_MLX4_DEBUG configuration option to define it. If RTE_LIBRTE_MLX4_DEBUG is enabled MLX4_ASSERT is equal to RTE_VERIFY to bypass the global CONFIG_RTE_ENABLE_ASSERT option. If RTE_LIBRTE_MLX4_DEBUG is disabled

[dpdk-dev] [PATCH v3 5/5] net/mlx5: introduce the mlx5 version of the assert

2020-01-27 Thread Alexander Kozyrev
Use the MLX5_ASSERT macros instead of the standard assert clause. Depends on the RTE_LIBRTE_MLX5_DEBUG configuration option to define it. If RTE_LIBRTE_MLX5_DEBUG is enabled MLX5_ASSERT is equal to RTE_VERIFY to bypass the global CONFIG_RTE_ENABLE_ASSERT option. If RTE_LIBRTE_MLX5_DEBUG is disabled

[dpdk-dev] [PATCH v3 1/5] mk/icc: disable treatment of warnings as errors

2020-01-27 Thread Alexander Kozyrev
Remove -Werror-all flag in ICC configuration file to stop treating ICC warnings as errors in DPDK due to many false positives. We are using GCC and Clang as a benchmark for warnings anyway for simplification. Suggested-by: Thomas Monjalon Signed-off-by: Alexander Kozyrev Acked-by: Viacheslav Ovs

[dpdk-dev] [PATCH v3 4/5] net/mlx5: use mlx5 debug flag instead of NDEBUG

2020-01-27 Thread Alexander Kozyrev
Use the RTE_LIBRTE_MLX5_DEBUG configuration flag to get rid of dependency on the NDEBUG definition. This is a preparation step to switch from standard assert clauses to DPDK RTE_ASSERT ones in MLX5 driver. Signed-off-by: Alexander Kozyrev Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/Make

[dpdk-dev] [PATCH v3 0/5] net/mlx: assert cleanup in mlx drivers

2020-01-27 Thread Alexander Kozyrev
The Mellanox PMD uses the NDEBUG definition to control built-in debug features including the asserting one. The DPDK uses a bit different approach and provides RTE_ASSERT macro and appropriate global configuration option: CONFIG_RTE_ENABLE_ASSERT. The patch set introduces the MLX_ASSERT macros that

[dpdk-dev] [PATCH v3 2/5] net/mlx4: use mlx4 debug flag instead of NDEBUG

2020-01-27 Thread Alexander Kozyrev
Use the RTE_LIBRTE_MLX4_DEBUG compilation flag to get rid of dependency on the NDEBUG definition. This is a preparation step to switch from standard assert clauses to DPDK RTE_ASSERT ones in MLX4 driver. Signed-off-by: Alexander Kozyrev Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx4/Makefi

[dpdk-dev] [PATCH v5] build: allow using wildcards to disable drivers

2020-01-27 Thread Bruce Richardson
Rather than having to explicitly list each and every driver to disable in a build, we can use a small python script and the python glob library to expand out the wildcards. This means that we can configure meson using e.g. meson -Ddisable_drivers=crypto/*,event/* build to do a build omitting

[dpdk-dev] app/testpmd: configure mapping of port queues to cores

2020-01-27 Thread Asaf Sinai
Hi, Could not find a way to map specific port queues to specific cores. For example, mapping port 0 to cores 1-7, port 1 to cores 8-14 and port 2 to cores 15-21 is very easy in 'l3fwd' test application: --config '(0,0,1),(0,1,2),(0,2,3),(0,3,4),(0,4,5),(0,5,6),(0,6,7), (1,0,8),(1,1,9),(1,2,10),(

[dpdk-dev] Guidance about how to carry out flow control at L2

2020-01-27 Thread nisarg joshi
Hello community, I am working on a project in ns-3(network simulator) where we have a NetDevice implemented called "DpdkNetDevice" which emulates a net device using dpdk. The traffic control module/layer having the qdisc is a part of ns-3 and the transmit ring is a part of the dpdk environment. Bot

[dpdk-dev] [dpdk-dev PATCH] raw/octeontx2_ep: fix coverity scan reported defects

2020-01-27 Thread Mahipal Challa
Defects reported by coverity scan are resolved. Coverity issue: CID 353611 - Error handling. Coverity issue: CID 353622 - Error handling. Coverity issue: CID 353632 - NULL pointer dereference. Signed-off-by: Mahipal Challa --- drivers/raw/octeontx2_ep/otx2_ep_enqdeq.c | 18 ++ 1

Re: [dpdk-dev] [PATCH v4] build: allow using wildcards to disable drivers

2020-01-27 Thread Bruce Richardson
On Mon, Jan 27, 2020 at 12:26:53PM +0100, Andrzej Ostruszka wrote: > On 1/24/20 4:10 PM, Bruce Richardson wrote: > > Rather than having to explicitly list each and every driver to disable in a > > build, we can use a small python script and the python glob library to > > expand out the wildcards. T

Re: [dpdk-dev] [PATCH v4] build: allow using wildcards to disable drivers

2020-01-27 Thread Luca Boccassi
On Fri, 2020-01-24 at 15:10 +, Bruce Richardson wrote: > Rather than having to explicitly list each and every driver to > disable in a > build, we can use a small python script and the python glob library > to > expand out the wildcards. This means that we can configure meson > using e.g. > >

Re: [dpdk-dev] [PATCH] cryptodev: fix set_sym_session_private_data error in sessionless mode

2020-01-27 Thread Akhil Goyal
> > Bugzilla ID: 377 > > Signed-off-by: Junxiao Shi > --- Please add appropriate description about the bug and also add Fixes line to show the original commit. Change the patch title also as "drivers/crypto: fix ..."

Re: [dpdk-dev] [PATCH v2 00/15] add OCTEONTX2 inline IPsec support

2020-01-27 Thread Akhil Goyal
Hi Jerin, > > On Mon, Jan 27, 2020 at 4:10 PM Akhil Goyal wrote: > > > > > > > > > > On Wed, Jan 22, 2020 at 6:26 PM Akhil Goyal wrote: > > > > > > > > > > > > > > > > > > Hi Jerin, > > > > > > > > > > > > > > Will do the suggested change (RX/rx-> Rx & TX/tx->Tx). Do you > > > > > > > want >

Re: [dpdk-dev] [PATCH v4] build: allow using wildcards to disable drivers

2020-01-27 Thread Andrzej Ostruszka
On 1/24/20 4:10 PM, Bruce Richardson wrote: > Rather than having to explicitly list each and every driver to disable in a > build, we can use a small python script and the python glob library to > expand out the wildcards. This means that we can configure meson using e.g. > > meson -Ddisable_d

Re: [dpdk-dev] [RFC v2 0/7] RFC: Support MACSEC offload in the RTE_SECURITY infrastructure.

2020-01-27 Thread Akhil Goyal
Hi Pavel, > From: Pavel Belous > > This RFC suggest possible API to implement generic MACSEC HW > offload in DPDK infrastructure. > > Right now two PMDs implementing MACSEC hw offload via private > API: ixgbe (Intel) and atlantic (Aquantia). > > During that private API discussion it was decide

Re: [dpdk-dev] [PATCH v2 00/15] add OCTEONTX2 inline IPsec support

2020-01-27 Thread Jerin Jacob
On Mon, Jan 27, 2020 at 4:10 PM Akhil Goyal wrote: > > > > > > On Wed, Jan 22, 2020 at 6:26 PM Akhil Goyal wrote: > > > > > > > > > > > > > > > Hi Jerin, > > > > > > > > > > > > Will do the suggested change (RX/rx-> Rx & TX/tx->Tx). Do you want > > > > > > me > > > > > > to trim the headline as

Re: [dpdk-dev] SPDX license nag

2020-01-27 Thread Mcnamara, John
> -Original Message- > From: dev On Behalf Of Stephen Hemminger > Sent: Wednesday, January 22, 2020 4:19 PM > To: dev@dpdk.org > Subject: [dpdk-dev] SPDX license nag > > Files without SPDX License > -- > app/test-pmd/flowgen.c - Tilera/

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/compress: replace test vector

2020-01-27 Thread Mcnamara, John
> -Original Message- > From: dev On Behalf Of Mcnamara, John > Sent: Monday, January 20, 2020 6:00 PM > To: Thomas Monjalon ; Trahe, Fiona > ; Trybula, ArturX > Cc: dev@dpdk.org; sta...@dpdk.org; shal...@marvell.com; Dybkowski, AdamX > ; Danilewicz, MarcinX > ; Akhil Goyal > Subject:

Re: [dpdk-dev] [PATCH 2/5] devtools: add license tag to cocci.sh

2020-01-27 Thread Mcnamara, John
> -Original Message- > From: dev On Behalf Of Stephen Hemminger > Sent: Wednesday, December 4, 2019 3:55 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH 2/5] devtools: add license tag to cocci.sh > > This file still had original BSD boilerplate text. > Replace

Re: [dpdk-dev] 17.11.10 (LTS) patches review and test

2020-01-27 Thread Luca Boccassi
On Sun, 2020-01-26 at 14:58 +, Ali Alnubani wrote: > Hi Luca, > Sorry for the late response 😊 > > > -Original Message- > > From: Luca Boccassi < > > bl...@debian.org > > > > > Sent: Thursday, January 23, 2020 1:06 PM > > To: Ali Alnubani < > > alia...@mellanox.com > > >; dpdk stable <

Re: [dpdk-dev] [PATCH v2 00/15] add OCTEONTX2 inline IPsec support

2020-01-27 Thread Akhil Goyal
> > On Wed, Jan 22, 2020 at 6:26 PM Akhil Goyal wrote: > > > > > > > > > > > > Hi Jerin, > > > > > > > > > > Will do the suggested change (RX/rx-> Rx & TX/tx->Tx). Do you want me > > > > > to trim the headline as well? > > > > > > > > > > > > > Hi Anoob, > > > > > > > > > @Akhil, did you get a

[dpdk-dev] [PATCH 2/2] eal: add eal_parse_optionlist to parse user input

2020-01-27 Thread Hariprasad Govindharajan
In current version, there is a function which parses the corelist based on user value. A new generic function eal_parse_optionlist is added which will parse corelist as well as similar user input so that we can use it as a public API too. Signed-off-by: Hariprasad Govindharajan --- lib/librte_ea

[dpdk-dev] [PATCH 1/2] app/testpmd: add portlist option to the testpmd

2020-01-27 Thread Hariprasad Govindharajan
In current version, we are setting the ports using portmask. With portmask, we can use only upto 64 ports. This portlist option enables the user to use more than 64 ports. Now we can specify the ports in 2 different ways - Using portmask (-p [0x]nnn): mask must be in hex for

[dpdk-dev] [PATCH 0/2] app/testpmd: add portlist option to the testpmd

2020-01-27 Thread Hariprasad Govindharajan
This patchset contains 2 patches. The first one will be changes to testpmd where a new option portlist is added. The second one adds a function eal_parse_optionlist which will parse user input The following new command line parameter is added: --portlist: user can specify the list of forwarding p

[dpdk-dev] [PATCH 2/2] crypto/dpaa_sec: reorganize structure members

2020-01-27 Thread Gagandeep Singh
This patch reorganize the members of a structure used by driver in its data-path to improve performance. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa_sec/dpaa_sec.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.h b/drivers

[dpdk-dev] [PATCH 1/2] crypto/dpaa_sec: fix performance issue

2020-01-27 Thread Gagandeep Singh
DPAA sec driver is using virtual to physical address translation in its data path and driver is using dpaax_iova_table_update() API in every address translation which is very costly. This patch moves dpaax_iova_table_update() calling to rte_dpaa_mem_ptov(), only if it fails to found translation fro

Re: [dpdk-dev] [PATCH v2 02/15] common/octeontx2: add routine to check if sec capable otx2

2020-01-27 Thread Anoob Joseph
Hi Akhil, Minor correction. Please see inline. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Anoob Joseph > Sent: Monday, January 27, 2020 1:33 PM > To: Akhil Goyal ; Declan Doherty > ; Thomas Monjalon > Cc: Vamsi Krishna Attunuru ; Jerin Jacob > Kollanukkaran ; Narayana

Re: [dpdk-dev] [PATCH v2 02/15] common/octeontx2: add routine to check if sec capable otx2

2020-01-27 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Monday, January 27, 2020 12:31 PM > To: Anoob Joseph ; Declan Doherty > ; Thomas Monjalon > Cc: Vamsi Krishna Attunuru ; Jerin Jacob > Kollanukkaran ; Narayana Prasad Raju Athreya > ; Kiran Kuma