Re: [dpdk-dev] [PATCH v3 1/2] virtio: one way barrier for split vring used idx

2020-04-16 Thread Ye Xiaolong
On 04/06, Joyce Kong wrote: >In case VIRTIO_F_ORDER_PLATFORM(36) is not negotiated, then the frontend >and backend are assumed to be implemented in software, that is they can >run on identical CPUs in an SMP configuration. >Thus a weak form of memory barriers like rte_smp_r/wmb, other than >rte_cio

[dpdk-dev] [PATCH] net/octeontx2: update red algo for shaper dynamic update

2020-04-16 Thread Nithin Dabilpuram
From: Nithin Dabilpuram Due to an errata red algo needs to be set to discard instead of stall for 96XX C0 silicon for two rate shaping. This workaround is being already handled for newly created hierarchy but not for dynamic shaper update cases. This patch hence applies the workaround even when f

Re: [dpdk-dev] [PATCH v12 1/7] ethdev: added UNKNOWN speed value

2020-04-16 Thread Ivan Dyukov
Hello Everyone, Ook. I can take care about examples updates. link_speed could be printed in following way: ("link speed %u%s", link_speed, link_speed ==ETH_SPEED_NUM_UNKNOWN?"(UNKNOWN)":"") Please let me know if you have any objections. There are about 47 cases. $ grep -rn link_speed examples

[dpdk-dev] [dpdk-dev v7 2/3] net/iavf: add RSS configuration for VFs

2020-04-16 Thread Jeff Guo
The VF must be capable of configuring RSS. Add a virtchnl handler to parse a specific RSS configuration, and process the configuration for VFs, such as add or delete a RSS rule. Signed-off-by: Jeff Guo Reviewed-by: Qi Zhang --- v7->v6: refine eth and vlan process --- doc/guides/rel_notes/releas

[dpdk-dev] [dpdk-dev v7 3/3] app/testpmd: add new types to RSS hash commands

2020-04-16 Thread Jeff Guo
Add some new types, such as eth/l2-src-only/l2-dst-only/svlan/cvlan/ l2tpv3/esp/ah/pfcp types into RSS hash commands, it could be used to configure these rss input set by cmdline. Example flow commands was: testpmd>flow create 0 ingress pattern eth / ipv4 / l2tpv3oip / end \ actions rss ty

[dpdk-dev] [dpdk-dev v7 1/3] ethdev: add new RSS offload types

2020-04-16 Thread Jeff Guo
Defines some new RSS offload types for ETH/S_VLAN/C_VLAN/L2TPV3/ /PFCP/L2_SRC_ONLY/L2_DST_ONLY. Signed-off-by: Jeff Guo Reviewed-by: Qi Zhang Acked-by: Ori Kam --- v7->v6: rebase and add ETH_RSS_VLAN to cover ETH_RSS_S_VLAN and ETH_RSS_C_VLAN --- lib/librte_ethdev/rte_ethdev.h | 17 +++

[dpdk-dev] [dpdk-dev v7 0/3] add RSS configuration for iavf

2020-04-16 Thread Jeff Guo
Because the VF must be capable of configuring RSS, so add RSS configuration for iavf, VFs could add or delete a RSS rule base on the PF's capability. The supported protocol rss input set as below. l2-src-only/ l2-dst-only/ svlan/ cvlan/ ipv4/ ipv6/ l3_src_only/ l3_dst_only/ l2tpv3/ esp/ ah/ pfcp/

[dpdk-dev] [PATCH v2] net/bnxt: add flow stats in extended stats

2020-04-16 Thread Ajit Khaparde
From: Somnath Kotur This patch allows to display flow stats in extended stats. To do this, DMA-able memory is registered with the FW during device initialization. Then the driver uses an alarm thread to query the per flow stats using the HWRM_CFA_COUNTER_QSTATS HWRM command at regular intervals a

Re: [dpdk-dev] [PATCH 2/2] net/bonding: fix MAC address when one port resets

2020-04-16 Thread Wei Hu (Xavier)
Hi, Chas On 2020/4/4 22:07, Chas Williams wrote: The behavior is probably going to be inconsistent. Only one of the calls to mac_address_slaves_update() is checked for failure. The two calls are in bond_ethdev_lsc_event_callback()     if (internals->active_slave_count < 1) {    

[dpdk-dev] [PATCH] net/bnxt: add flow stats in extended stats

2020-04-16 Thread Ajit Khaparde
From: Somnath Kotur This patch allows to display flow stats in extended stats. To do this, DMA-able memory is registered with the FW during device initialization. Then the driver uses an alarm thread to query the per flow stats using the HWRM_CFA_COUNTER_QSTATS HWRM command at regular intervals a

Re: [dpdk-dev] [PATCH v1] net/ice: check the DSN package file firstly

2020-04-16 Thread Wang, Haiyue
> -Original Message- > From: Ye, Xiaolong > Sent: Friday, April 17, 2020 12:51 > To: Wang, Haiyue > Cc: dev@dpdk.org; Zhang, Qi Z ; Yang, Qiming > > Subject: Re: [PATCH v1] net/ice: check the DSN package file firstly > > On 04/16, Haiyue Wang wrote: > >Align the package file search seq

Re: [dpdk-dev] [PATCH v1] net/ice: check the DSN package file firstly

2020-04-16 Thread Ye Xiaolong
On 04/16, Haiyue Wang wrote: >Align the package file search sequence with PF only for DCF mode. Get >the DSN through the virtual channel firstly to check the package file >accessible. check the accessibility of the package file? > >Signed-off-by: Haiyue Wang >--- > drivers/net/ice/ice_dcf_parent

[dpdk-dev] [PATCH v3 08/11] baseband/fpga_5gnr_fec: add configure function

2020-04-16 Thread Nicolas Chautru
Add configure function to configure the PF from within the bbdev-test itself without external application configuration the device. Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 57 ++ doc/guides/bbdevs/fpga_5gnr_fec.rst| 123 +++

[dpdk-dev] [PATCH v3 10/11] baseband/fpga_5gnr_fec: add interrupt support

2020-04-16 Thread Nicolas Chautru
Adding support for interrupt capability in the PMD and the related operations. Signed-off-by: Nicolas Chautru --- drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h | 17 +++ drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 139 + 2 files changed, 156 insertions(+) diff

[dpdk-dev] [PATCH v3 11/11] doc: add feature matrix table for bbdev devices

2020-04-16 Thread Nicolas Chautru
Adding missing overview page in documentation with comparison of feature set by each available PMD implementation. Signed-off-by: Nicolas Chautru --- .gitignore | 1 + doc/guides/bbdevs/features/default.ini | 16 doc/guides/bbdevs/feature

[dpdk-dev] [PATCH v3 09/11] baseband/fpga_5gnr_fec: add harq loopback capability

2020-04-16 Thread Nicolas Chautru
Adding optional capability to support loopback preloading and check of the extern HARQ memory. This function is required to run the HARQ bit exact test successfully. Signed-off-by: Nicolas Chautru --- drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 171 + 1 file changed,

[dpdk-dev] [PATCH v3 05/11] baseband/fpga_5gnr_fec: add LDPC processing functions

2020-04-16 Thread Nicolas Chautru
Adding LDPC processing operations and related documentation. Signed-off-by: Nicolas Chautru --- doc/guides/bbdevs/fpga_5gnr_fec.rst| 28 + drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h | 9 + drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 660 +

[dpdk-dev] [PATCH v3 07/11] baseband/fpga_5gnr_fec: add debug functionality

2020-04-16 Thread Nicolas Chautru
Adding functionality for debug mode to be more verbose and catch error from unsupported configuration. Signed-off-by: Nicolas Chautru --- drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h | 13 + drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 356 + 2 files changed, 3

[dpdk-dev] [PATCH v3 04/11] baseband/fpga_5gnr_fec: add queue configuration

2020-04-16 Thread Nicolas Chautru
Adding function to create and configure queues for the device. Still no capability. Signed-off-by: Nicolas Chautru --- drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h | 110 +++ drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 365 - 2 files changed, 474 insertions

[dpdk-dev] [PATCH v3 03/11] baseband/fpga_5gnr_fec: add device info_get function

2020-04-16 Thread Nicolas Chautru
Add in the "info_get" function to the driver, to allow us to query the device. No capability are available yet. Linking bbdev-test to support the PMD with null capability. Signed-off-by: Nicolas Chautru --- app/test-bbdev/Makefile| 3 ++ app/test-bbdev/meson.build

[dpdk-dev] [PATCH v3 06/11] baseband/fpga_5gnr_fec: add HW error capture

2020-04-16 Thread Nicolas Chautru
Adding HW specific parsing of error report for negative scenarios. Not hit through unit test. Signed-off-by: Nicolas Chautru --- drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 56 ++ 1 file changed, 56 insertions(+) diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_

[dpdk-dev] [PATCH v3 01/11] drivers/baseband: add PMD for FPGA 5GNR FEC

2020-04-16 Thread Nicolas Chautru
Add stubs for the FPGA 5GNR FEC PMD Signed-off-by: Nicolas Chautru --- config/common_base | 5 + doc/guides/bbdevs/fpga_5gnr_fec.rst| 146 doc/guides/bbdevs/index.rst| 1 + doc/guides/rel_notes/release_2

[dpdk-dev] [PATCH v3 02/11] baseband/fpga_5gnr_fec: add register definition file

2020-04-16 Thread Nicolas Chautru
Add in the list of registers for the device and related HW specs definitions. Signed-off-by: Nicolas Chautru --- drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h | 189 + 1 file changed, 189 insertions(+) diff --git a/drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h b/drive

[dpdk-dev] [PATCH v3 00/11] drivers/baseband: PMD for FPGA 5GNR FEC

2020-04-16 Thread Nicolas Chautru
v3: Incremental changes from reviews : file name change, moving few inline function to .h, adding missing inline, doxygen markup fix. Adding new baseband PMD for FPGA 5GNR FEC implementation. Nicolas Chautru (11): drivers/baseband: add PMD for FPGA 5GNR FEC baseband/fpga_5gnr_fec: add reg

Re: [dpdk-dev] [PATCH v2 01/10] Add __rte_internal tag for functions and version target

2020-04-16 Thread Wang, Haiyue
> -Original Message- > From: Neil Horman > Sent: Friday, April 17, 2020 10:38 > To: Wang, Haiyue > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Richardson, > Bruce > ; Thomas Monjalon ; David > Marchand > ; Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH v2 01/10] Add __rte_internal ta

Re: [dpdk-dev] Napatech pmd

2020-04-16 Thread Michael Lilja
> -Original Message- > From: Neil Horman > Sent: 17. april 2020 04:55 > To: Thomas Monjalon > Cc: Finn Christensen ; dev@dpdk.org; Bent Kuhre > ; Michael Lilja ; techbo...@dpdk.org > Subject: Re: [dpdk-dev] Napatech pmd > > On Tue, Mar 31, 2020 at 10:07:12PM +0200, Thomas Monjalon wrote:

Re: [dpdk-dev] [PATCH v5 00/11] framework for advanced iAVF PMD

2020-04-16 Thread Ye Xiaolong
On 04/16, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Rong, Leyi >> Sent: Thursday, April 16, 2020 4:10 PM >> To: Wu, Jingjing ; Zhang, Qi Z >> ; Xing, Beilei ; Ye, Xiaolong >> >> Cc: dev@dpdk.org; Rong, Leyi >> Subject: [PATCH v5 00/11] framework for advanced iAVF PMD >> >> T

Re: [dpdk-dev] [PATCH v4 0/5] support fm10k switch management

2020-04-16 Thread Ye Xiaolong
On 04/16, Wang, Xiao W wrote: >For the series, Reviewed-by: Xiao Wang > >Best Regards, >Xiao > >> -Original Message- >> From: Xiaojun Liu >> Sent: Thursday, April 9, 2020 2:26 PM >> To: Wang, Xiao W ; Zhang, Qi Z >> ; Kwan, Ngai-mint ; Keller, >> Jacob E >> Cc: dev@dpdk.org; Xiaojun Liu

[dpdk-dev] [PATCH] net/ixgbe: fix status synchronization on BSD

2020-04-16 Thread zhihongx . peng
From: Peng Zhihong DPDK does not implement interrupt mechanism on BSD, so force NIC status synchronization. Fixes: dc66e5fd01b9 (net/ixgbe: improve link state check on VF) Cc: liang-min.w...@intel.com Signed-off-by: Peng Zhihong --- drivers/net/ixgbe/ixgbe_ethdev.c | 5 + 1 file changed,

Re: [dpdk-dev] Napatech pmd

2020-04-16 Thread Neil Horman
On Tue, Mar 31, 2020 at 10:07:12PM +0200, Thomas Monjalon wrote: > 31/03/2020 21:56, Neil Horman: > > On Tue, Mar 31, 2020 at 02:29:08PM +0200, Thomas Monjalon wrote: > > > 31/03/2020 14:17, Neil Horman: > > > > On Tue, Mar 31, 2020 at 01:25:25PM +0200, Thomas Monjalon wrote: > > > > > Hi, > > > >

[dpdk-dev] [PATCH v2] vhost: fix shadow update

2020-04-16 Thread Marvin Liu
Defer shadow ring update introduces functional issue which has been described in Eugenio's fix patch. The current implementation of vhost_net in packed vring tries to fill the shadow vector before send any actual changes to the guest. While this can be beneficial for the throughput, it conflicts w

Re: [dpdk-dev] [PATCH v2 01/10] Add __rte_internal tag for functions and version target

2020-04-16 Thread Neil Horman
On Fri, Apr 17, 2020 at 02:04:30AM +, Wang, Haiyue wrote: > Hi Neil, > > > -Original Message- > > From: dev On Behalf Of Neil Horman > > Sent: Thursday, June 13, 2019 22:24 > > To: dev@dpdk.org > > Cc: Neil Horman ; Jerin Jacob Kollanukkaran > > ; Richardson, > > Bruce ; Thomas Monja

Re: [dpdk-dev] [PATCH 5/5] app/test-flow-perf: add packet forwarding support

2020-04-16 Thread Xiaoyu Min
On Thu, 20-04-09, 15:42, Wisam Jaddo wrote: > Introduce packet forwarding support to the app to do > some performance measurements. > > The measurements are reported in term of packet per > second unit. The forwarding will start after the end > of insertion/deletion operations. > > The support ha

Re: [dpdk-dev] [PATCH 4/5] app/test-flow-perf: add memory dump to app

2020-04-16 Thread Xiaoyu Min
On Thu, 20-04-09, 15:42, Wisam Jaddo wrote: > Introduce new feature to dump memory statistics of each socket > and a total for all before and after the creation. > > This will give two main advantage: > 1- Check the memory consumption for large number of flows > "insertion rate scenario alone" >

Re: [dpdk-dev] [PATCH 3/5] app/test-flow-perf: add deletion rate calculation

2020-04-16 Thread Xiaoyu Min
On Thu, 20-04-09, 15:42, Wisam Jaddo wrote: > Add the ability to test deletion rate for flow performance > application. > > This feature is disabled by default, and can be enabled by > add "--deletion-rate" in the application command line options. > > Signed-off-by: Wisam Jaddo Reviewed-by: Xiao

Re: [dpdk-dev] [PATCH 2/5] app/test-flow-perf: add insertion rate calculation

2020-04-16 Thread Xiaoyu Min
On Thu, 20-04-09, 15:42, Wisam Jaddo wrote: > Add insertion rate calculation feature into flow > performance application. > > The application now provide the ability to test > insertion rate of specific rte_flow rule, by > stressing it to the NIC, and calculate the > insertion rate. > > The appli

Re: [dpdk-dev] [PATCH 1/5] app/test-flow-perf: add flow performance skeleton

2020-04-16 Thread Xiaoyu Min
On Thu, 20-04-16, 23:12, Wisam Monther wrote: > > > >-Original Message- > >From: dev On Behalf Of Wisam Jaddo > >Sent: Thursday, April 9, 2020 6:43 PM > >To: dev@dpdk.org; Jack Min ; > >jerinjac...@gmail.com > >Cc: Thomas Monjalon > >Subject: [dpdk-dev] [PATCH 1/5] app/test-flow-perf: a

Re: [dpdk-dev] [PATCH v2 01/10] Add __rte_internal tag for functions and version target

2020-04-16 Thread Wang, Haiyue
Hi Neil, > -Original Message- > From: dev On Behalf Of Neil Horman > Sent: Thursday, June 13, 2019 22:24 > To: dev@dpdk.org > Cc: Neil Horman ; Jerin Jacob Kollanukkaran > ; Richardson, > Bruce ; Thomas Monjalon > Subject: [dpdk-dev] [PATCH v2 01/10] Add __rte_internal tag for functions

Re: [dpdk-dev] [PATCH] net/mlx5: fix crash when releasing the meter table

2020-04-16 Thread Suanming Mou
Hi Tonghao, Good catch. Add maintainers. Thanks, SuanmingMou > -Original Message- > From: xiangxia.m@gmail.com > Sent: Wednesday, April 15, 2020 4:52 PM > To: Suanming Mou ; > david.march...@redhat.com > Cc: dev@dpdk.org; Tonghao Zhang ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5

Re: [dpdk-dev] [dpdk-dev v6 3/3] app/testpmd: add new types to RSS hash commands

2020-04-16 Thread Jeff Guo
hi, ferruh On 4/16/2020 11:52 PM, Ferruh Yigit wrote: On 4/16/2020 4:15 PM, Jeff Guo wrote: hi, bernard On 4/16/2020 7:16 PM, Iremonger, Bernard wrote: Hi Jeff, -Original Message- From: Guo, Jia Sent: Thursday, April 16, 2020 8:20 PM To: Iremonger, Bernard ; or...@mellanox.com; Y

[dpdk-dev] [PATCH] vhost: fix shadowed descs not flushed

2020-04-16 Thread Marvin Liu
When ring size or enqueue packets not aligned with batch number, it is possible that descs update still kept in shadowed used structure when batched enqueue. Fix this issue by flushing remained shadowed used descs before batch flush. Fixes: f41516c309d ("vhost: flush batched enqueue descs directly

Re: [dpdk-dev] [PATCH v3 0/4] add new k32v64 hash table

2020-04-16 Thread Wang, Yipeng1
> -Original Message- > From: Mattias Rönnblom > Sent: Thursday, April 16, 2020 4:41 AM > To: Medvedkin, Vladimir ; dev@dpdk.org > Cc: Ananyev, Konstantin ; Wang, Yipeng1 > ; Gobriel, Sameh ; > Richardson, Bruce > Subject: Re: [dpdk-dev] [PATCH v3 0/4] add new k32v64 hash table > > On 202

Re: [dpdk-dev] [PATCH v2] eal: choose initial PRNG seed source at runtime

2020-04-16 Thread Dan Gora
On Thu, Apr 16, 2020 at 8:30 AM Mattias Rönnblom wrote: > > diff --git a/lib/librte_eal/meson.build b/lib/librte_eal/meson.build > > index 0267c3b9d..748359b8c 100644 > > --- a/lib/librte_eal/meson.build > > +++ b/lib/librte_eal/meson.build > > @@ -15,9 +15,6 @@ deps += 'kvargs' > > if dpdk_conf

Re: [dpdk-dev] [PATCH v5] hash: add hash bulk lookup with hash signatures array

2020-04-16 Thread Wang, Yipeng1
> -Original Message- > From: Medvedkin, Vladimir > Sent: Thursday, April 16, 2020 8:07 AM > To: dev@dpdk.org > Cc: Wang, Yipeng1 ; Gobriel, Sameh > ; Richardson, Bruce > Subject: [PATCH v5] hash: add hash bulk lookup with hash signatures array > > Implement rte_hash_lookup_with_hash_bulk

Re: [dpdk-dev] [Minutes 04/15/2020] Bi-Weekly DPDK Windows Community Call

2020-04-16 Thread Dmitry Kozlyuk
> * [AI Dmitry K, Harini] Dmitry K to send summary of conversation for > feedback, Harini to follow-up for resolution. On Windows community calls we've been discussing memory management implementation approaches and plans. This summary aims to bring everyone interested to the same page and to

Re: [dpdk-dev] [PATCH v3] eal/ppc64: improve rte_rdtsc() with __ppc_get_timebase()

2020-04-16 Thread Thomas Monjalon
Any review please? 25/03/2020 01:13, Thinh Tran: > __ppc_get_timebase() reads and returns the current value of the Time > Base Register. It's more efficient as it uses the processor’s time > base facility directly > > the DPDK on FreeBSD currently is not supported on Powerpc64, it sho

Re: [dpdk-dev] [dpdk-dev v3] [PATCH] mempool/octeontx2: add devargs to lock ctx in cache

2020-04-16 Thread Thomas Monjalon
06/04/2020 10:39, Jerin Jacob: > On Thu, Mar 26, 2020 at 12:04 PM wrote: > > > > From: Pavan Nikhilesh > > > > Add device arguments to lock NPA aura and pool contexts in NDC cache. > > The device args take hexadecimal bitmask where each bit represent the > > corresponding aura/pool id. > > Exampl

Re: [dpdk-dev] [PATCH dpdk-dev v3 2/2] mempool: use shared memzone for rte_mempool_ops

2020-04-16 Thread Thomas Monjalon
13/04/2020 16:21, xiangxia.m@gmail.com: > The order of mempool initiation affects mempool index in the > rte_mempool_ops_table. For example, when building APPs with: > > $ gcc -lrte_mempool_bucket -lrte_mempool_ring ... > > The "bucket" mempool will be registered firstly, and its index > in t

Re: [dpdk-dev] [PATCH v12 1/7] ethdev: added UNKNOWN speed value

2020-04-16 Thread Thomas Monjalon
Hi, Please look at an update below from ethdev co-maintainers. 16/04/2020 14:42, Ivan Dyukov: > UNKNOWN speed equals to 0x [...] > +#define ETH_SPEED_NUM_UNKNOWN 0x /**< Unknown */ This approach is being rejected in another thread: http://inbox.dpdk.org/dev/42de4bd1-0a6c-6591-cd2

Re: [dpdk-dev] [PATCH 0/3] refresh NIC features matrix

2020-04-16 Thread Thomas Monjalon
12/03/2020 00:01, Thomas Monjalon: > This series aims to clean-up the big table of ethdev features: > http://doc.dpdk.org/guides/nics/overview.html#id1 > > We could reorganize the information in this table, > maybe split it or add/remove some rows. > Before going to such reorganization, we shoul

Re: [dpdk-dev] [PATCH v2 10/13] baseband/fpga_5gnr_fec: add configure function

2020-04-16 Thread Chautru, Nicolas
Hi Akhil, > > diff --git a/drivers/baseband/fpga_5gnr_fec/Makefile > > b/drivers/baseband/fpga_5gnr_fec/Makefile > > index 3f5c511..b68a79f 100644 > > --- a/drivers/baseband/fpga_5gnr_fec/Makefile > > +++ b/drivers/baseband/fpga_5gnr_fec/Makefile > > @@ -23,4 +23,7 @@ LIBABIVER := 1 > > # librar

Re: [dpdk-dev] [PATCH v2 05/13] baseband/fpga_5gnr_fec: add device info_get function

2020-04-16 Thread Chautru, Nicolas
Hi Akhil, > > Add in the "info_get" function to the driver, to allow us to query the > > device. > > No capability are available yet. > > Linking bbdev-test to support the PMD with null capability. > > > > Signed-off-by: Nicolas Chautru > > --- > > app/test-bbdev/Makefile

Re: [dpdk-dev] [PATCH RFC v1 0/7] relax barriers for ENA PMD and small fixes

2020-04-16 Thread Chauskin, Igor
Hi all, Please see the first batch of comments related to these patches: 1. Relaxing the register read/write isn't always good enough. Specifically, when barriers are required between different memory types, the reordering can occur even on x86. Yet in DPDK the io/cio/smp barrier flavors for x8

Re: [dpdk-dev] [PATCH RFC v1 0/7] relax barriers for ENA PMD and small fixes

2020-04-16 Thread Chauskin, Igor
Hi, These changes are ARM-oriented and the behavior will be different on x86-based systems. As such, we need to generalize them and it's not straightforward - we're still reviewing the implications. I will update when we're ready. Thanks, Igor -Original Message- From: Ferruh Yigit S

Re: [dpdk-dev] [PATCH 0/3] refresh NIC features matrix

2020-04-16 Thread Thomas Monjalon
Any more opinion about removing VF columns from the NIC matrix? 24/03/2020 09:36, Andrew Rybchenko: > On 3/20/20 2:15 PM, Zhang, Qi Z wrote: > > From: Thomas Monjalon > >> 20/03/2020 06:35, Zhang, Qi Z: > >>> From: Thomas Monjalon > The second and third patches are removing 8 columns which

Re: [dpdk-dev] [PATCH] doc: fix sphinx compatibility

2020-04-16 Thread Thomas Monjalon
09/04/2020 23:03, Thomas Monjalon: > The function add_stylesheet() is deprecated since sphinx 1.8. > It will be removed in sphinx 4.0. > It is replaced by add_css_file(). > > Cc: sta...@dpdk.org > > Signed-off-by: Thomas Monjalon Applied

Re: [dpdk-dev] [dpdk-stable] [PATCH] log: fix level picked with globbing on type register

2020-04-16 Thread Thomas Monjalon
08/04/2020 00:47, Thomas Monjalon: > When a log type is registered, the level can be picked > by matching saved options. > The check of fnmatch globbing result was reversed. > > The same bug was already fixed in a similar function. > This one is acting in log type register function. > > Note: thi

Re: [dpdk-dev] [PATCH v1] common/mlx5: remove devx depndency on ibv and dv

2020-04-16 Thread Thomas Monjalon
16/04/2020 19:35, Ferruh Yigit: > On 4/9/2020 8:24 AM, David Marchand wrote: > > On Wed, Apr 8, 2020 at 7:12 PM Ferruh Yigit wrote: > >> On 4/1/2020 10:59 AM, Raslan Darawsheh wrote: > >>> From: Ophir Munk > > File mlx5_devx_cmds.c should contain pure DevX calls. It must be OS > ag

Re: [dpdk-dev] [PATCH v2 10/13] baseband/fpga_5gnr_fec: add configure function

2020-04-16 Thread Akhil Goyal
> > diff --git a/drivers/baseband/fpga_5gnr_fec/Makefile > b/drivers/baseband/fpga_5gnr_fec/Makefile > index 3f5c511..b68a79f 100644 > --- a/drivers/baseband/fpga_5gnr_fec/Makefile > +++ b/drivers/baseband/fpga_5gnr_fec/Makefile > @@ -23,4 +23,7 @@ LIBABIVER := 1 > # library source files > SRCS-

Re: [dpdk-dev] [PATCH v8 1/6] lib/eal: implement the family of commonbit operation APIs

2020-04-16 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Joyce Kong > Sent: Thursday, April 16, 2020 7:39 AM > > Bitwise operation APIs are defined and used in a lot of PMDs, > which caused a huge code duplication. To reduce duplication, > this patch consolidates them into a common API family. > [

Re: [dpdk-dev] [PATCH v4 3/3] ipfrag: add unit test case

2020-04-16 Thread Aaron Conole
Lukasz Wojciechowski writes: > Hi Aaron, > > W dniu 15.04.2020 o 19:25, Aaron Conole pisze: >> Initial IP fragmentation unit test. >> >> Signed-off-by: Aaron Conole >> --- Thanks for the review, Lukasz! >> MAINTAINERS| 1 + >> app/test/meson.build | 2 + >> app/test/test_

[dpdk-dev] [PATCH v2] x86/eal: gcc 10 ignore stringop-overflow warnings

2020-04-16 Thread Kevin Traynor
stringop-overflow warns when it sees a possible overflow in a string operation. In the rte_memcpy functions different branches are taken depending on the size. stringop-overflow is raised for the branches in the function where it sees the static size of the src could be overflowed. However, in re

Re: [dpdk-dev] [PATCH] build: gcc 10 disable stringop-overflow warnings

2020-04-16 Thread Kevin Traynor
On 10/04/2020 14:23, Bruce Richardson wrote: > On Fri, Apr 10, 2020 at 11:51:56AM +0100, Kevin Traynor wrote: >> On 07/04/2020 17:27, Kevin Traynor wrote: >>> stringop-overflow warns when it sees a possible overflow >>> in a string operation. >>> >>> In the rte_memcpy functions different implementa

Re: [dpdk-dev] [PATCH v2 12/13] baseband/fpga_5gnr_fec: add interrupt support

2020-04-16 Thread Akhil Goyal
> > Adding support for interrupt capability in the PMD > and the related operations. > > Signed-off-by: Nicolas Chautru > --- > drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 156 > + > 1 file changed, 156 insertions(+) > > diff --git a/drivers/baseband/fpga_5gnr_fec/

Re: [dpdk-dev] [PATCH v3 10/10] eal/windows: implement basic memory management

2020-04-16 Thread Ranjit Menon
On 4/14/2020 12:44 PM, Dmitry Kozlyuk wrote: Basic memory management supports core libraries and PMDs operating in IOVA as PA mode. It uses a kernel-mode driver, virt2phys, to obtain IOVAs of hugepages allocated from user-mode. Signed-off-by: Dmitry Kozlyuk --- diff --git a/lib/librte_eal/

Re: [dpdk-dev] [PATCH v2 05/13] baseband/fpga_5gnr_fec: add device info_get function

2020-04-16 Thread Akhil Goyal
> > Add in the "info_get" function to the driver, to allow us to query the > device. > No capability are available yet. > Linking bbdev-test to support the PMD with null capability. > > Signed-off-by: Nicolas Chautru > --- > app/test-bbdev/Makefile| 3 ++ > app/test

Re: [dpdk-dev] [PATCH v4 00/34] add support for host based flow table management

2020-04-16 Thread Ajit Khaparde
On Thu, Apr 16, 2020 at 10:40 AM Ferruh Yigit wrote: > On 4/15/2020 9:18 AM, Venkat Duvvuru wrote: > > This patchset introduces a new mechanism to allow host-memory based > > flow table management. This should allow higher flow scalability > > than what is currently supported. This new approach a

Re: [dpdk-dev] [PATCH v4 05/34] net/bnxt: add initial tf core session close support

2020-04-16 Thread Ajit Khaparde
On Thu, Apr 16, 2020 at 10:39 AM Ferruh Yigit wrote: > On 4/15/2020 9:18 AM, Venkat Duvvuru wrote: > > From: Michael Wildt > > > > - Add TruFlow session and resource support functions > > - Add Truflow session close API and related message support functions > > for both session and hw resource

Re: [dpdk-dev] [PATCH v4 04/34] net/bnxt: add initial tf core session open

2020-04-16 Thread Ajit Khaparde
On Thu, Apr 16, 2020 at 10:40 AM Ferruh Yigit wrote: > On 4/15/2020 9:18 AM, Venkat Duvvuru wrote: > > From: Michael Wildt > > > > - Add infrastructure support > > - Add tf_core open session support > > > > Signed-off-by: Michael Wildt > > Reviewed-by: Randy Schacher > > Reviewed-by: Ajit Kuma

Re: [dpdk-dev] [PATCH v5 1/2] test/crypto: add capability check

2020-04-16 Thread Trahe, Fiona
> -Original Message- > From: dev On Behalf Of Pablo de Lara > Sent: Thursday, April 16, 2020 6:24 PM > To: Doherty, Declan > Cc: dev@dpdk.org; akhil.go...@nxp.com; De Lara Guarch, Pablo > > Subject: [dpdk-dev] [PATCH v5 1/2] test/crypto: add capability check > > Check if test case i

Re: [dpdk-dev] [PATCH v5 2/2] test/crypto: do not check for internal PMD information

2020-04-16 Thread Trahe, Fiona
> -Original Message- > From: dev On Behalf Of Pablo de Lara > Sent: Thursday, April 16, 2020 6:24 PM > To: Doherty, Declan > Cc: dev@dpdk.org; akhil.go...@nxp.com; De Lara Guarch, Pablo > > Subject: [dpdk-dev] [PATCH v5 2/2] test/crypto: do not check for internal PMD > information >

Re: [dpdk-dev] [PATCH] test/crypto: fix flag check

2020-04-16 Thread Trahe, Fiona
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday, April 16, 2020 6:13 PM > To: Trahe, Fiona ; Doherty, Declan > > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: [PATCH] test/crypto: fix flag check > > An incorrect flag check was done, using

Re: [dpdk-dev] [PATCH v4 00/34] add support for host based flow table management

2020-04-16 Thread Ferruh Yigit
On 4/15/2020 9:18 AM, Venkat Duvvuru wrote: > This patchset introduces a new mechanism to allow host-memory based > flow table management. This should allow higher flow scalability > than what is currently supported. This new approach also defines a > new rte_flow parser, and mapper which currently

Re: [dpdk-dev] [PATCH v4 05/34] net/bnxt: add initial tf core session close support

2020-04-16 Thread Ferruh Yigit
On 4/15/2020 9:18 AM, Venkat Duvvuru wrote: > From: Michael Wildt > > - Add TruFlow session and resource support functions > - Add Truflow session close API and related message support functions > for both session and hw resources > > Signed-off-by: Michael Wildt > Reviewed-by: Randy Schacher

Re: [dpdk-dev] [PATCH v4 04/34] net/bnxt: add initial tf core session open

2020-04-16 Thread Ferruh Yigit
On 4/15/2020 9:18 AM, Venkat Duvvuru wrote: > From: Michael Wildt > > - Add infrastructure support > - Add tf_core open session support > > Signed-off-by: Michael Wildt > Reviewed-by: Randy Schacher > Reviewed-by: Ajit Kumar Khaparde > Signed-off-by: Venkat Duvvuru <...> > +int > +tfp_call

Re: [dpdk-dev] [PATCH v1] common/mlx5: remove devx depndency on ibv and dv

2020-04-16 Thread Ferruh Yigit
On 4/9/2020 8:24 AM, David Marchand wrote: > Hello, > > On Wed, Apr 8, 2020 at 7:12 PM Ferruh Yigit wrote: >> >> On 4/1/2020 10:59 AM, Raslan Darawsheh wrote: >>> Hi, >>> -Original Message- From: Ophir Munk Sent: Monday, March 30, 2020 1:32 AM To: dev@dpdk.org; Matan

Re: [dpdk-dev] [PATCH 0/4] Introduce IF proxy library

2020-04-16 Thread Jerin Jacob
On Thu, Apr 16, 2020 at 10:34 PM Stephen Hemminger wrote: > > On Thu, 16 Apr 2020 22:19:05 +0530 > Jerin Jacob wrote: > > > On Thu, Apr 16, 2020 at 9:41 PM Stephen Hemminger > > wrote: > > > > > > On Fri, 6 Mar 2020 17:41:00 +0100 > > > Andrzej Ostruszka wrote: > > > > > > > What is this useful

Re: [dpdk-dev] [PATCH 0/4] Introduce IF proxy library

2020-04-16 Thread Andrzej Ostruszka [C]
On 4/16/20 7:04 PM, Stephen Hemminger wrote: > On Thu, 16 Apr 2020 22:19:05 +0530 > Jerin Jacob wrote: > >> On Thu, Apr 16, 2020 at 9:41 PM Stephen Hemminger >> wrote: [...] >>> Has anyone investigated solving this in the kernel rather than >>> creating the added overhead of more Linux devices?

[dpdk-dev] [PATCH v5 0/2] Crypto test refactoring (first phase)

2020-04-16 Thread Pablo de Lara
This patchset adds crypto capability checks in the cryptodev test code, to be able to skip unsupported test cases for each crypto device, according to their capabilities. Thanks to this patchset, there is no more need to check for internal PMD information in the test code, making it more "device-a

[dpdk-dev] [PATCH v5 2/2] test/crypto: do not check for internal PMD information

2020-04-16 Thread Pablo de Lara
Now that capabilities are checked to see if an algorithm is supported by a device, there is no need to check for a specific version of a library used in a PMD. Signed-off-by: Pablo de Lara Acked-by: Adam Dybkowski Tested-by: Ruifeng Wang --- app/test/test_cryptodev_hash_test_vectors.h | 25 --

[dpdk-dev] [PATCH v5 1/2] test/crypto: add capability check

2020-04-16 Thread Pablo de Lara
Check if test case is supported by the crypto device, including algorithm and some of its parameter, such as key length, IV length, etc, using the capabilities API. If it is not supported, test case is skipped. Signed-off-by: Pablo de Lara Acked-by: Adam Dybkowski Tested-by: Ruifeng Wang ---

Re: [dpdk-dev] [PATCH 0/4] Introduce IF proxy library

2020-04-16 Thread Stephen Hemminger
On Thu, 16 Apr 2020 17:12:07 + "Andrzej Ostruszka [C]" wrote: > On 4/16/20 6:49 PM, Jerin Jacob wrote: > > On Thu, Apr 16, 2020 at 9:41 PM Stephen Hemminger > > wrote: > [...] > >> Has anyone investigated solving this in the kernel rather than > >> creating the added overhead of more Linux

Re: [dpdk-dev] [RFC 1/3] eventdev: allow for event devices requiring maintenance

2020-04-16 Thread Jerin Jacob
On Tue, Apr 14, 2020 at 11:25 PM Mattias Rönnblom wrote: > > On 2020-04-14 18:15, Jerin Jacob wrote: > > On Tue, Apr 14, 2020 at 9:27 PM Mattias Rönnblom > > wrote: > >> On 2020-04-10 15:00, Jerin Jacob wrote: > >>> On Thu, Apr 9, 2020 at 7:32 PM Mattias Rönnblom > >>> wrote: > On 2020-04-0

[dpdk-dev] [PATCH] net/mlx5: fix location of assert function

2020-04-16 Thread Asaf Penso
The asserts makes sure that 'i' doesn't exceed the exepcted value. This to prevent an out of bound access to dbr_bitmap. The current location of the assert protects the assignment of dbr_bitmap, but not the access to it. Moved the assert to the correct place, to protect both cases. Also, used an

[dpdk-dev] [PATCH] test/crypto: fix flag check

2020-04-16 Thread Pablo de Lara
An incorrect flag check was done, using "&&" instead of "&". Fixes: 2717246ecd7d ("cryptodev: replace mbuf scatter gather flag") Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara --- app/test/test_cryptodev_blockcipher.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/tes

Re: [dpdk-dev] [PATCH 0/4] Introduce IF proxy library

2020-04-16 Thread Andrzej Ostruszka [C]
On 4/16/20 6:49 PM, Jerin Jacob wrote: > On Thu, Apr 16, 2020 at 9:41 PM Stephen Hemminger > wrote: [...] >> Has anyone investigated solving this in the kernel rather than >> creating the added overhead of more Linux devices? >> >> What I am thinking of is a netlink to userspace interface. >> The

Re: [dpdk-dev] [PATCH v2 00/10] net/mlx5: optimize flow structure

2020-04-16 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Thursday, April 16, 2020 11:34 AM > To: Slava Ovsiienko ; Matan Azrad > > Cc: Ori Kam ; Wentao Cui ; > Raslan Darawsheh ; dev@dpdk.org > Subject: [PATCH v2 00/10] net/mlx5: optimize flow structure > > This patch set is third part of

Re: [dpdk-dev] [PATCH] ci: remove aarch64 from Travis jobs

2020-04-16 Thread Aaron Conole
Honnappa Nagarahalli writes: > > >> Subject: Re: [PATCH] ci: remove aarch64 from Travis jobs >> >> 16/04/2020 15:45, Aaron Conole: >> > David Marchand writes: >> > > On Thu, Apr 16, 2020 at 2:44 PM Aaron Conole >> wrote: >> > >> Thomas Monjalon writes: >> > >> >> > >> > Travis is not reliabl

Re: [dpdk-dev] [PATCH] ci: remove aarch64 from Travis jobs

2020-04-16 Thread Aaron Conole
Thomas Monjalon writes: > 16/04/2020 15:45, Aaron Conole: >> David Marchand writes: >> > On Thu, Apr 16, 2020 at 2:44 PM Aaron Conole wrote: >> >> Thomas Monjalon writes: >> >> >> >> > Travis is not reliable for native Arm and PPC: >> >> > https://travis-ci.community/t/disk-quota-exceeded-on-a

Re: [dpdk-dev] [PATCH 0/4] Introduce IF proxy library

2020-04-16 Thread Stephen Hemminger
On Thu, 16 Apr 2020 22:19:05 +0530 Jerin Jacob wrote: > On Thu, Apr 16, 2020 at 9:41 PM Stephen Hemminger > wrote: > > > > On Fri, 6 Mar 2020 17:41:00 +0100 > > Andrzej Ostruszka wrote: > > > > > What is this useful for > > > === > > > > > > Usually, when an ethernet port

Re: [dpdk-dev] [PATCH v4 00/34] add support for host based flow table management

2020-04-16 Thread Ajit Khaparde
On Thu, Apr 16, 2020 at 9:23 AM Ferruh Yigit wrote: > On 4/15/2020 9:18 AM, Venkat Duvvuru wrote: > > This patchset introduces a new mechanism to allow host-memory based > > flow table management. This should allow higher flow scalability > > than what is currently supported. This new approach al

Re: [dpdk-dev] [PATCH v2 0/4] Crypto test refactoring (second phase)

2020-04-16 Thread Trahe, Fiona
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday, April 16, 2020 10:25 AM > To: Doherty, Declan ; ravi1.ku...@amd.com; > ruifeng.w...@arm.com; > ano...@marvell.com; Zhang, Roy Fan ; Trahe, Fiona > ; t...@semihalf.com; rnagadhee...@marvell.com; > adwiv...@marvell.com

Re: [dpdk-dev] [PATCH 0/4] Introduce IF proxy library

2020-04-16 Thread Jerin Jacob
On Thu, Apr 16, 2020 at 9:41 PM Stephen Hemminger wrote: > > On Fri, 6 Mar 2020 17:41:00 +0100 > Andrzej Ostruszka wrote: > > > What is this useful for > > === > > > > Usually, when an ethernet port is assigned to DPDK it vanishes from the > > system and user looses ability to

[dpdk-dev] [PATCH v6] examples/ipsec-secgw: support flow director feature

2020-04-16 Thread Praveen Shetty
Support load distribution in security gateway application using NIC load distribution feature(Flow Director). Flow Director is used to redirect the specified inbound ipsec flow to a specified queue.This is achieved by extending the SA rule syntax to support specification by adding new action_type o

Re: [dpdk-dev] [PATCH v4 1/2] test/crypto: add capability check

2020-04-16 Thread De Lara Guarch, Pablo
Hi Fiona, > -Original Message- > From: Trahe, Fiona > Sent: Thursday, April 16, 2020 5:26 PM > To: De Lara Guarch, Pablo ; Doherty, Declan > > Cc: dev@dpdk.org; akhil.go...@nxp.com; De Lara Guarch, Pablo > ; Dybkowski, AdamX > ; Trahe, Fiona > Subject: RE: [dpdk-dev] [PATCH v4 1/2] test

[dpdk-dev] TestPMD sample application

2020-04-16 Thread Sahil Khandelwal
I am able to run the testpmd sample application but the statistics always show the number of transmitted and received packets 0

Re: [dpdk-dev] [PATCH 20.05 00/15] clean-up use of __attribute__

2020-04-16 Thread Thomas Monjalon
10/02/2020 17:20, Thomas Monjalon: > Almost all usages of __attribute__ keyword are replaced > by a macro (existing or new) with prefix __rte_. > It makes code more consistent and will help changing > compiler behaviour, or adapting to new compilers, > in a central place. > > Kernel and BPF files

Re: [dpdk-dev] [PATCH v2] eal: fix crash when the random init

2020-04-16 Thread Mattias Rönnblom
On 2020-04-15 09:43, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > When rte_rand_init is invoked, and the kernel running dpdk does't > support *getentropy, at the same time, the cpu does't support rdseed, > then rte_rand_init invoked rte_get_timer_cycles which invoked > rte_get_hpet_cy

Re: [dpdk-dev] [PATCH v5 00/33] DPDK Trace support

2020-04-16 Thread Jerin Jacob
On Thu, Apr 16, 2020 at 9:53 PM Thomas Monjalon wrote: > > 16/04/2020 18:08, Jerin Jacob: > > On Thu, Apr 16, 2020 at 7:09 PM David Marchand > > wrote: > > > > > > On Wed, Apr 15, 2020 at 4:40 PM Jerin Jacob wrote: > > > > > - What do you think of splitting the API in two headers, thinking > > >

Re: [dpdk-dev] [PATCH v4 1/2] test/crypto: add capability check

2020-04-16 Thread Trahe, Fiona
Hi Pablo, > -Original Message- > From: dev On Behalf Of Pablo de Lara > Sent: Thursday, April 16, 2020 10:08 AM > To: Doherty, Declan > Cc: dev@dpdk.org; akhil.go...@nxp.com; De Lara Guarch, Pablo > ; > Dybkowski, AdamX > Subject: [dpdk-dev] [PATCH v4 1/2] test/crypto: add capability c

  1   2   3   >