Re: [dpdk-dev] [dpdk-dev v21.11] [PATCH v5 8/8] eventdev: simplify Rx adapter event vector config

2021-03-26 Thread Jayatheerthan, Jay
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Thursday, March 25, 2021 7:25 PM > To: Jayatheerthan, Jay ; Jerin Jacob > Kollanukkaran ; Carrillo, Erik G > ; Gujjar, Abhinandan S > ; McDaniel, Timothy > ; hemant.agra...@nxp.com; Van Haaren, Harry > ; mattias.ronnblom >

[dpdk-dev] [PATCH v3] meson: remove unnecessary explicit link to libpcap

2021-03-26 Thread Gabriel Ganne
libpcap is already found and registered as a dependency by meson, and the dependency is already correctly used in librte_port. This line is just unnecessary. It also has the side effect of messing with the meson link line: dpdk link will be declared twice: manually and then through pkg-config. If

[dpdk-dev] [PATCH] telemetry: cleanup internal header

2021-03-26 Thread David Marchand
The experimental banner can be removed. Every in-tree file is compiled with _GNU_SOURCE, so RTE_HAS_CPUSET is unneeded for an internal header. Fixes: 0e64ae618e10 ("telemetry: move init function to internal header") Signed-off-by: David Marchand --- lib/librte_telemetry/rte_telemetry.h | 1

Re: [dpdk-dev] [PATCH v6 0/2] EAL Thread TLS API enhancements

2021-03-26 Thread Thomas Monjalon
16/03/2021 14:28, Tal Shnaiderman: > --- > v6: fix misalignment in comment fix from v5 and missing NL in RN [Thomas] > v5: shorten docu comment on rte_errno and add ABI change info to release note > [Thomas] > v4: replace errno EOTHER with ENOEXEC as EOTHER is undefined in unix. > v3: -Unify rte_e

Re: [dpdk-dev] Handling missing export functions in MSVC linkage

2021-03-26 Thread Thomas Monjalon
08/06/2020 10:33, David Marchand: > On Mon, Jun 8, 2020 at 2:09 AM Dmitry Kozlyuk > wrote: > > On Sun, 7 Jun 2020 12:26:56 + > > If you create a .def manually, it will override the generation from .map. Of > > cause, this adds manual work and ideally all .def files should be generated. > > O

[dpdk-dev] [PATCH v7] app/testpmd: support multi-process

2021-03-26 Thread Min Hu (Connor)
From: Lijun Ou This patch adds multi-process support for testpmd. The test cmd example as follows: the primary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ --rxq=4 --txq=4 --num-procs=2 --proc-id=0 the secondary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 2-3 -- -i \ --rxq=4 --t

[dpdk-dev] [PATCH 1/2] net/hns3: fix code check warning

2021-03-26 Thread Min Hu (Connor)
This patch fixed cyclomatic complexity about MTU in device configure process. Fixes: 1f5ca0b460cd ("net/hns3: support some device operations") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c | 61 +- 1 file changed, 3

[dpdk-dev] [PATCH 0/2] Support PTP for hns3 PMD

2021-03-26 Thread Min Hu (Connor)
This set includes two patches, one patch is to fix cyclomatic complexity, the other patch is to support PTP, but depends on the first patch. So the two forms one set of patches. Min Hu (Connor) (2): net/hns3: fix code check warning net/hns3: support IEEE 1588 PTP doc/guides/nics/features/hns

[dpdk-dev] [PATCH 2/2] net/hns3: support IEEE 1588 PTP

2021-03-26 Thread Min Hu (Connor)
Add hns3 support for new ethdev APIs to enable and read IEEE1588/ 802.1AS PTP timestamps. Signed-off-by: Min Hu (Connor) --- doc/guides/nics/features/hns3.ini | 2 + doc/guides/nics/hns3.rst | 1 + drivers/net/hns3/hns3_cmd.h | 33 + drivers/net/hns3/hns3_ethdev.c| 5

Re: [dpdk-dev] [PATCH v3 3/7] net/txgbe: update link setup process of backplane NICs

2021-03-26 Thread Ferruh Yigit
On 3/26/2021 2:02 AM, Jiawen Wu wrote: On March 25, 2021 6:20 PM, Ferruh Yigit wrote: On 3/25/2021 5:51 AM, Jiawen Wu wrote: Add device arguments to support runtime options. And use these configuration to control the link setup flow, to adapt to different NIC's construction. Use firmware versio

Re: [dpdk-dev] [PATCH v5 4/8] eventdev: add Rx adapter event vector support

2021-03-26 Thread Pavan Nikhilesh Bhagavatula
>> From: Pavan Nikhilesh Bhagavatula >> Sent: Thursday, March 25, 2021 6:44 PM >> To: Jayatheerthan, Jay ; Jerin Jacob >Kollanukkaran ; Carrillo, Erik G >> ; Gujjar, Abhinandan S >; McDaniel, Timothy >> ; hemant.agra...@nxp.com; Van >Haaren, Harry ; mattias.ronnblom >> ; Ma, Liang J > >> Cc: dev@d

Re: [dpdk-dev] [PATCH v6 2/5] eal/windows: hide asprintf() shim

2021-03-26 Thread Thomas Monjalon
20/03/2021 14:05, Dmitry Kozlyuk: > Make asprintf(3) implementation for Windows private to EAL, so that it's > hidden from external consumers. It is not exposed to internal consumers > either, because they don't need asprintf() and also because callers from > other modules would have no reliable wa

Re: [dpdk-dev] [PATCH v6 3/5] eal: make OS shims internal

2021-03-26 Thread Thomas Monjalon
20/03/2021 14:05, Dmitry Kozlyuk: > DPDK code often relies on functions and macros that are not standard C, > but are found on all platforms, even if by slightly different names. > Windows provided macros or inline definitions for such symbols. > However, when placed in public header, these symbol

[dpdk-dev] [PATCH v1 0/2] Enhancements to crypto adapter forward mode

2021-03-26 Thread Shijith Thotton
This series proposes a new event device enqueue operation if crypto adapter forward mode is supported. Second patch in the series is the implementation of the same in PMD. Test application changes for the usage of new API is yet to add. v1: - Added crypto adapter forward mode support for octeontx2

[dpdk-dev] [PATCH v1 1/2] eventdev: introduce crypto adapter enqueue API

2021-03-26 Thread Shijith Thotton
From: Akhil Goyal In case an event from a previous stage is required to be forwarded to a crypto adapter and PMD supports internal event port in crypto adapter, exposed via capability RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD, we do not have a way to check in the API rte_event_enqueue_bur

[dpdk-dev] [PATCH v1 2/2] event/octeontx2: support crypto adapter forward mode

2021-03-26 Thread Shijith Thotton
Advertise crypto adapter forward mode capability and set crypto adapter enqueue function in driver. Signed-off-by: Shijith Thotton --- drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 34 +--- drivers/event/octeontx2/otx2_evdev.c | 5 +- .../event/octeontx2/otx2_evdev_crypto_adptr.c

[dpdk-dev] [PATCH] doc: update limitations of OCTEON TX crypto PMDs

2021-03-26 Thread Anoob Joseph
Update known limitations of OCTEON TX crypto PMDs. Signed-off-by: Anoob Joseph --- doc/guides/cryptodevs/octeontx.rst | 6 ++ doc/guides/cryptodevs/octeontx2.rst | 6 ++ 2 files changed, 12 insertions(+) diff --git a/doc/guides/cryptodevs/octeontx.rst b/doc/guides/cryptodevs/octeontx.

Re: [dpdk-dev] [PATCH v3 3/7] net/txgbe: update link setup process of backplane NICs

2021-03-26 Thread Jiawen Wu
On March 26, 2021 4:56 PM, Ferruh Yigit wrote: > On 3/26/2021 2:02 AM, Jiawen Wu wrote: > > On March 25, 2021 6:20 PM, Ferruh Yigit wrote: > >> On 3/25/2021 5:51 AM, Jiawen Wu wrote: > >>> Add device arguments to support runtime options. > >>> And use these configuration to control the link setup f

Re: [dpdk-dev] [PATCH v6 4/5] net: provide IP-related API on any OS

2021-03-26 Thread Thomas Monjalon
20/03/2021 14:05, Dmitry Kozlyuk: > Users of relied on it to provide IP-related defines, > like IPPROTO_* constatns, but still had to include POSIX headers typo: constants > for inet_pton() and other standard IP-related facilities. > > Extend so that it is a single header to gain access > to I

Re: [dpdk-dev] [PATCH v6 5/5] net: replace Windows networking shim

2021-03-26 Thread Thomas Monjalon
20/03/2021 14:05, Dmitry Kozlyuk: > Remove networking shim from Windows EAL. > > Replace it with system headers with two workarounds: > > 1. Windows Sockets headers contain `#define s_addr S_un.S_addr`, which >conflicts with `s_addr` field of `struct rte_ether_hdr`. Undefining >this macro

Re: [dpdk-dev] [PATCH v3] meson: remove unnecessary explicit link to libpcap

2021-03-26 Thread Thomas Monjalon
26/03/2021 09:22, Gabriel Ganne: > libpcap is already found and registered as a dependency by meson, and > the dependency is already correctly used in librte_port. This line is > just unnecessary. > > It also has the side effect of messing with the meson link line: dpdk > link will be declared twi

Re: [dpdk-dev] [PATCH] telemetry: cleanup internal header

2021-03-26 Thread Thomas Monjalon
26/03/2021 09:24, David Marchand: > The experimental banner can be removed. > Every in-tree file is compiled with _GNU_SOURCE, so RTE_HAS_CPUSET is > unneeded for an internal header. > > Fixes: 0e64ae618e10 ("telemetry: move init function to internal header") > > Signed-off-by: David Marchand g

[dpdk-dev] [PATCH] net/mlx5: fix using flow tunnel before null check

2021-03-26 Thread wangyunjian
From: Yunjian Wang Coverity flags that 'ctx->tunnel' variable is used before it's checked for NULL. This patch fixes this issue. Coverity issue: 366201 Fixes: 868d2e342cf3 ("net/mlx5: fix tunnel offload hub multi-thread protection") Signed-off-by: Yunjian Wang --- drivers/net/mlx5/mlx5_flow.c

[dpdk-dev] [PATCH] net/sfc: fix error path inconsistency

2021-03-26 Thread Ivan Malov
At the fail label, there's a statement to set general errno and error message. However, before the label is reached, a custom error message can be set by the code which parses actions. This custom (action-specific) message, when present, must not be replaced by the general one. Fixes: 662286ae61d2

Re: [dpdk-dev] [dpdk-dev v21.11] [PATCH v5 8/8] eventdev: simplify Rx adapter event vector config

2021-03-26 Thread Pavan Nikhilesh Bhagavatula
>> -Original Message- >> From: Pavan Nikhilesh Bhagavatula >> Sent: Thursday, March 25, 2021 7:25 PM >> To: Jayatheerthan, Jay ; Jerin Jacob >Kollanukkaran ; Carrillo, Erik G >> ; Gujjar, Abhinandan S >; McDaniel, Timothy >> ; hemant.agra...@nxp.com; Van >Haaren, Harry ; mattias.ronnblom >

[dpdk-dev] [PATCH v1] net/octeontx2: support flow action port id

2021-03-26 Thread smadarf
From: Smadar Fuks Action port_id was not supported until now. In this patch the action port_id supports passing from input port PF to output port which is one of input port respective VF Signed-off-by: Smadar Fuks --- doc/guides/nics/octeontx2.rst | 6 +++ drivers/net/octeontx2/

Re: [dpdk-dev] [PATCH] doc: fix formatting in testpmd user guide

2021-03-26 Thread Ferruh Yigit
On 3/9/2021 10:00 PM, Ajit Khaparde wrote: On Tue, Mar 9, 2021 at 4:52 AM Ferruh Yigit wrote: On 3/8/2021 10:34 PM, Ajit Khaparde wrote: Fix formatting in testpmd user guide for hairpin operation. Fixes: 01817b10d27c ("app/testpmd: change hairpin queues setup") Cc:sta...@dpdk.org Signed-off

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/1] net/hinic: fix coredump when in secondary process

2021-03-26 Thread Ferruh Yigit
On 3/23/2021 1:17 PM, Guoyang Zhou wrote: Some apps, such as fstack, will use secondary process to access the memory of eth_dev_ops, and they want to get the info of dev, but hinic driver does not initialized it when in secondary process. Fixes: 66f64dd6dc86 ("net/hinic: fix secondary process")

Re: [dpdk-dev] [PATCH] telemetry: cleanup internal header

2021-03-26 Thread Bruce Richardson
On Fri, Mar 26, 2021 at 10:32:03AM +0100, Thomas Monjalon wrote: > 26/03/2021 09:24, David Marchand: > > The experimental banner can be removed. > > Every in-tree file is compiled with _GNU_SOURCE, so RTE_HAS_CPUSET is > > unneeded for an internal header. > > > > Fixes: 0e64ae618e10 ("telemetry: m

[dpdk-dev] [PATCH 0/2] Fix unit tests execution for ENA PMD

2021-03-26 Thread Michal Krawczyk
Hi, ENA PMD uses timer service to implement various periodic device status check routine. Because of that, it already initializes the timer subsystem. As unit tests also initalizes the timer subsystem, return value is equal to -EAGAIN, as it was already done by the ENA PMD. This patch set adds mi

[dpdk-dev] [PATCH 1/2] timer: clarify subsystem_init return value

2021-03-26 Thread Michal Krawczyk
From: Stanislaw Kardach rte_timer_subsystem_init() may return -EALREADY if it has been already initialized. Therefore put explicitly into doxygen that this is not a failure for the application. Signed-off-by: Stanislaw Kardach Reviewed-by: Michal Krawczyk --- lib/librte_timer/rte_timer.h | 1

[dpdk-dev] [PATCH 2/2] test: proceed if timer subsystem was initialized

2021-03-26 Thread Michal Krawczyk
From: Stanislaw Kardach rte_timer_subsystem_init() may return -EALREADY if the timer subsystem was already initialized. This can happen i.e. in PMD code (see eth_ena_dev_init). This is not an error, rather a notification as the initialization function simply returns without any action taken. Sig

Re: [dpdk-dev] [PATCH 1/7] common/octeontx: enable build only on 64bit Linux

2021-03-26 Thread Jerin Jacob
On Thu, Mar 25, 2021 at 6:32 PM Kinsella, Ray wrote: > > > > On 25/03/2021 12:58, Jerin Jacob wrote: > > On Thu, Mar 25, 2021 at 6:17 PM Kinsella, Ray wrote: > >> > >> > >> > >> On 25/03/2021 12:46, Jerin Jacob wrote: > >>> On Thu, Mar 25, 2021 at 4:33 PM Thomas Monjalon > >>> wrote: > > >

Re: [dpdk-dev] [PATCH 01/25] event/dlb2: add dlb v2.5 probe

2021-03-26 Thread Jerin Jacob
On Thu, Mar 25, 2021 at 1:01 AM McDaniel, Timothy wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Sunday, March 21, 2021 4:48 AM > > To: McDaniel, Timothy > > Cc: dpdk-dev ; Jerin Jacob ; Van Haaren, > > Harry ; Ray Kinsella ; Neil > > Horman ; Rao, Nikhil ; > > Carri

[dpdk-dev] [PATCH v2 1/7] net/qede: remove flags from Tx entry

2021-03-26 Thread Balazs Nemeth
Each sw_tx_ring entry was of type struct qede_tx_entry: struct qede_tx_entry { struct rte_mbuf *mbuf; uint8_t flags; }; Leaving the unused flags member here has a few performance implications. First, each qede_tx_entry takes up more memory which has caching implications as less entr

[dpdk-dev] [PATCH v2 0/7] Optimize qede use of Rx/Tx entries

2021-03-26 Thread Balazs Nemeth
This patch set optimizes qede_{rx,tx}_entry and introduces rte_pktmbuf_free_bulk in qede_process_tx_compl. The overall performance improvement depends on the use-case; in a physical-virtual-physical test on a ThunderX2 99xx system with two SMT threads used in ovs, and two cores used in a vm, an imp

[dpdk-dev] [PATCH v2 2/7] net/qede: get consumer index once

2021-03-26 Thread Balazs Nemeth
Calling ecore_chain_get_cons_idx repeatedly is slower than calling it once and using the result for the remainder of qede_process_tx_compl. Signed-off-by: Balazs Nemeth Reviewed-by: Igor Russkikh --- drivers/net/qede/qede_rxtx.c | 22 ++ 1 file changed, 14 insertions(+), 8 d

[dpdk-dev] [PATCH v2 3/7] net/qede: assume mbuf to free is never null

2021-03-26 Thread Balazs Nemeth
The ring txq->sw_tx_ring is managed with txq->sw_tx_cons. As long as txq->sw_tx_cons is correct, there is no need to check if txq->sw_tx_ring[idx] is null explicitly. Signed-off-by: Balazs Nemeth Reviewed-by: Igor Russkikh --- drivers/net/qede/qede_rxtx.c | 59 +++---

[dpdk-dev] [PATCH v2 4/7] net/qede: free packets in bulk instead of one by one

2021-03-26 Thread Balazs Nemeth
rte_pktmbuf_free_bulk calls rte_mempool_put_bulk with the number of pending packets to return to the mempool. In contrast, rte_pktmbuf_free calls rte_mempool_put that calls rte_mempool_put_bulk with one object. An important performance related downside of adding one packet at a time to the mempool

[dpdk-dev] [PATCH v2 5/7] net/qede: prefetch hardware consumer

2021-03-26 Thread Balazs Nemeth
Ensure that, while ecore_chain_get_cons_idx is running, txq->hw_cons_ptr is prefetched. This shows a slight performance improvement. Signed-off-by: Balazs Nemeth Reviewed-by: Igor Russkikh --- drivers/net/qede/qede_rxtx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/qede/qede

[dpdk-dev] [PATCH v2 6/7] net/qede: prefetch next packet to free

2021-03-26 Thread Balazs Nemeth
While handling the current mbuf, pull the next mbuf into the cache. Note that the last four mbufs pulled into the cache are not handled, but that doesn't matter. Signed-off-by: Balazs Nemeth Reviewed-by: Igor Russkikh --- drivers/net/qede/qede_rxtx.c | 6 ++ 1 file changed, 6 insertions(+)

[dpdk-dev] [PATCH v2 7/7] net/qede: remove unnecessary field in Rx entry and simplify

2021-03-26 Thread Balazs Nemeth
The member page_offset is always zero. Having this in the qede_rx_entry makes it larger than it needs to be and this has cache performance implications so remove that field. In addition, since qede_rx_entry only has an rte_mbuf*, remove the definition of qede_rx_entry. Signed-off-by: Balazs Nemeth

Re: [dpdk-dev] [PATCH] telemetry: cleanup internal header

2021-03-26 Thread Power, Ciara
>-Original Message- >From: Richardson, Bruce >Sent: Friday 26 March 2021 10:32 >To: Thomas Monjalon >Cc: David Marchand ; dev@dpdk.org; Power, >Ciara >Subject: Re: [dpdk-dev] [PATCH] telemetry: cleanup internal header > >On Fri, Mar 26, 2021 at 10:32:03AM +0100, Thomas Monjalon wrote:

Re: [dpdk-dev] [PATCH v2 1/3] build: enable iavf base code to build on windows

2021-03-26 Thread Ferruh Yigit
On 3/11/2021 1:58 AM, Pallavi Kadam wrote: Enable IAVF driver to build on Windows as it is required to build ice PMD. Disable all other drivers from common directory. This patch also includes fix for a macro redefinition warning in the IAVF driver. Signed-off-by: Pallavi Kadam Reviewed-by: Ranj

Re: [dpdk-dev] [PATCH v2 2/3] net/ice: build on Windows

2021-03-26 Thread Ferruh Yigit
On 3/11/2021 1:58 AM, Pallavi Kadam wrote: - Add Intel ice PMD support on Windows. - Remove #include sys/ioctl header file as it is not needed. - Replace x86intrin.h with rte_vect.h to avoid __m_prefetchw conflicting types. - Replace POSIX usleep() API with rte API. - Add a new macro for the acce

Re: [dpdk-dev] [PATCH v2 3/3] net/ice: disable ice DDP package on Windows

2021-03-26 Thread Ferruh Yigit
On 3/11/2021 1:58 AM, Pallavi Kadam wrote: Disable loading of external DDP package as it is not supported on Windows. Should this be documented in driver documentation as Windows support limitation? Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon <...>

Re: [dpdk-dev] [PATCH v2 2/3] net/ice: build on Windows

2021-03-26 Thread Ferruh Yigit
On 3/11/2021 1:58 AM, Pallavi Kadam wrote: - Add Intel ice PMD support on Windows. - Remove #include sys/ioctl header file as it is not needed. - Replace x86intrin.h with rte_vect.h to avoid __m_prefetchw conflicting types. - Replace POSIX usleep() API with rte API. - Add a new macro for the acce

Re: [dpdk-dev] [PATCH v2] ethdev: introduce enable_driver_sdk to install driver headers

2021-03-26 Thread Ferruh Yigit
On 3/24/2021 4:24 PM, Tyler Retzlaff wrote: On Wed, Mar 24, 2021 at 12:30:36PM +0100, Thomas Monjalon wrote: 24/03/2021 12:27, Ferruh Yigit: But not sure how to manage the same problem for whole project, if install all headers in one patch, or add them gradually via separate patches by time ..

Re: [dpdk-dev] [PATCH v2] mem: fix cleanup when multi-process is disabled

2021-03-26 Thread Burakov, Anatoly
On 24-Mar-21 7:32 PM, Dmitry Kozlyuk wrote: rte_eal_memory_detach() did not account for cases where multi-process mode is disabled: --in-memory and --no-shconf. This resulted in unmapping memory that had not been mapped, which caused errors: EAL: Could not unmap memory: No error (Windows)

Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer

2021-03-26 Thread Jerin Jacob
On Wed, Mar 10, 2021 at 7:05 AM Lijun Ou wrote: > > Here addes Kunpeng920 config back which was deleted. Please fix the commit message. With commit message update: Acked-by: Jerin Jacob > > Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous variables") > > Signed-off-by: Chengch

Re: [dpdk-dev] [PATCH V2 2/4] config/arm: add Hisilicon kunpeng930 implementer

2021-03-26 Thread Jerin Jacob
On Wed, Mar 10, 2021 at 7:05 AM Lijun Ou wrote: > > Here add Hisilicon kunpeng930 config back which was deleted. Please fix the commit message. I think, 1/4 and 2/4 cab squashed. With above change: Acked-by: Jerin Jacob > > Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous varia

Re: [dpdk-dev] [PATCH V2 3/4] config/arm: add kunpeng920 meson cross compile target

2021-03-26 Thread Jerin Jacob
On Thu, Mar 25, 2021 at 1:18 PM Ruifeng Wang wrote: > > > -Original Message- > > From: dev On Behalf Of Lijun Ou > > Sent: Wednesday, March 10, 2021 9:36 AM > > To: tho...@monjalon.net; ferruh.yi...@intel.com > > Cc: dev@dpdk.org; linux...@openeuler.org > > Subject: [dpdk-dev] [PATCH V2 3

Re: [dpdk-dev] [PATCH V2 4/4] config/arm: add kunpeng930 meson cross compile target

2021-03-26 Thread Jerin Jacob
On Wed, Mar 10, 2021 at 7:05 AM Lijun Ou wrote: > > Here add arm64 cross compile support for Hisilicon kunpeng930. > > Signed-off-by: Chengchang Tang > Signed-off-by: Lijun Ou Similar comments to 3/4 patch. With change: Acked-by: Jerin Jacob > --- > config/arm/arm64_kunpeng930_linux_gcc

Re: [dpdk-dev] [PATCH] ethdev: update qfi definition

2021-03-26 Thread Ferruh Yigit
On 3/23/2021 12:11 PM, Raslan Darawsheh wrote: qfi field is 8 bits which represent single bit for PPP (paging Policy Presence) single bit for RQI (Reflective QoS Indicator) and 6 bits for qfi (QoS Flow Identifier) Can you please put a reference for above information? This update the doxygen

Re: [dpdk-dev] [PATCH] net/mlx5: fix using flow tunnel before null check

2021-03-26 Thread Slava Ovsiienko
> -Original Message- > From: wangyunjian > Sent: Friday, March 26, 2021 12:37 > To: dev@dpdk.org > Cc: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko ; > jerry.lili...@huawei.com; chenchan...@huawei.com; Yunjian Wang > > Subject: [dpdk-dev] [PATCH] net/mlx5: fix using flow tunnel before

Re: [dpdk-dev] [PATCH 01/52] config/arm: add support for Marvell CN10K

2021-03-26 Thread Jerin Jacob
On Fri, Mar 5, 2021 at 7:09 PM Nithin Dabilpuram wrote: > > From: Pavan Nikhilesh > > Add config support to cross compile for Marvell CN10K SoC. > > Signed-off-by: Nithin Dabilpuram > Signed-off-by: Pavan Nikhilesh Please move this patch from this series and send a separate patch and CC arm m

Re: [dpdk-dev] [PATCH 03/52] common/cnxk: add model init and IO handling API

2021-03-26 Thread Jerin Jacob
On Fri, Mar 5, 2021 at 7:10 PM Nithin Dabilpuram wrote: > > From: Jerin Jacob > > Add routines for SoC model identification and HW IO handling > routines specific to CN9K and CN10K Marvell SoC's. > These are based on arm64 ISA and behaviour specific to > Marvell SoC's. > > Signed-off-by: Jerin Ja

Re: [dpdk-dev] [PATCH 09/52] common/cnxk: add base npa device support

2021-03-26 Thread Jerin Jacob
On Fri, Mar 5, 2021 at 7:11 PM Nithin Dabilpuram wrote: > > From: Ashwin Sekhar T K > > Add NPA init and fini functions. Please add a few line git commit messagee on what is NPA. > > Signed-off-by: Ashwin Sekhar T K > --- > drivers/common/cnxk/meson.build | 1 + > drivers/common/cnxk/ro

Re: [dpdk-dev] [PATCH 01/25] event/dlb2: add dlb v2.5 probe

2021-03-26 Thread McDaniel, Timothy
> -Original Message- > From: Jerin Jacob > Sent: Friday, March 26, 2021 6:01 AM > To: McDaniel, Timothy > Cc: dpdk-dev ; Jerin Jacob ; Van Haaren, > Harry ; Ray Kinsella ; Neil > Horman ; Rao, Nikhil ; > Carrillo, Erik G ; Gujjar, Abhinandan S > ; Pavan Nikhilesh > ; Hemant Agrawal ; >

[dpdk-dev] [PATCH v8 0/8] Introduce event vectorization

2021-03-26 Thread pbhagavatula
From: Pavan Nikhilesh In traditional event programming model, events are identified by a flow-id and a uintptr_t. The flow-id uniquely identifies a given event and determines the order of scheduling based on schedule type, the uintptr_t holds a single object. Event devices also support burst mod

[dpdk-dev] [PATCH v8 1/8] eventdev: introduce event vector capability

2021-03-26 Thread pbhagavatula
From: Pavan Nikhilesh Introduce rte_event_vector datastructure which is capable of holding multiple uintptr_t of the same flow thereby allowing applications to vectorize their pipeline and reducing the complexity of pipelining the events across multiple stages. This approach also reduces the sche

[dpdk-dev] [PATCH v8 4/8] eventdev: add Rx adapter event vector support

2021-03-26 Thread pbhagavatula
From: Pavan Nikhilesh Add event vector support for event eth Rx adapter, the implementation creates vector flows based on port and queue identifier of the received mbufs. The flow id for SW Rx event vectorization will use 12-bits of queue identifier and 8-bits port identifier when custom flow id

[dpdk-dev] [PATCH v8 3/8] eventdev: introduce event vector Tx capability

2021-03-26 Thread pbhagavatula
From: Pavan Nikhilesh Introduce event vector transmit capability for event eth tx adapter. The capability indicates that the Tx adapter is capable of transmitting event vectors. When rte_event_vector::union_valid is set, the Tx adapter should transmit all the packets to the rte_event_vector::por

[dpdk-dev] [PATCH v8 2/8] eventdev: introduce event vector Rx capability

2021-03-26 Thread pbhagavatula
From: Pavan Nikhilesh Introduce event ethernet Rx adapter event vector capability. If an event eth Rx adapter has the capability of RTE_EVENT_ETH_RX_ADAPTER_CAP_EVENT_VECTOR then a given Rx queue can be configured to enable event vectorization by passing the flag RTE_EVENT_ETH_RX_ADAPTER_QUEUE_E

[dpdk-dev] [PATCH v8 5/8] eventdev: add Tx adapter event vector support

2021-03-26 Thread pbhagavatula
From: Pavan Nikhilesh Add event vector support for event eth Tx adapter, the implementation receives events from the single linked queue and based on rte_event_vector::attr_valid transmits the vector of mbufs to a given port, queue pair. Signed-off-by: Pavan Nikhilesh Acked-by: Jay Jayatheertha

[dpdk-dev] [PATCH v8 6/8] app/eventdev: add event vector mode in pipeline test

2021-03-26 Thread pbhagavatula
From: Pavan Nikhilesh Add event vector support in pipeline tests. By default this mode is disabled, it can be enabled by using the option --enable_vector. example: dpdk-test-eventdev -l 7-23 -s 0xff00 -- --prod_type_ethdev --nb_pkts=0 --verbose 2 --test=pipeline_atq --stlist=a

[dpdk-dev] [PATCH v8 7/8] doc: announce event Rx adapter config changes

2021-03-26 Thread pbhagavatula
From: Pavan Nikhilesh The Rx adapter event vector configuration will be merged into Rx adapter queue configuration to simplify enabling event vectorization. Signed-off-by: Pavan Nikhilesh Acked-by: Ray Kinsella --- doc/guides/rel_notes/deprecation.rst | 9 + 1 file changed, 9 insertio

[dpdk-dev] [dpdk-dev v21.11] [PATCH v8 8/8] eventdev: simplify Rx adapter event vector config

2021-03-26 Thread pbhagavatula
From: Pavan Nikhilesh Include vector configuration into the structure ``rte_event_eth_rx_adapter_queue_conf`` used when configuring rest of the Rx adapter ethernet device Rx queue parameters. This simplifies event vector configuration as it avoids splitting configuration per Rx queue. Signed-off

Re: [dpdk-dev] [PATCH 27/52] common/cnxk: add support for nix extended stats

2021-03-26 Thread Jerin Jacob
On Fri, Mar 5, 2021 at 7:14 PM Nithin Dabilpuram wrote: > > From: Satha Rao > > Add support for retrieving NIX extended stats that are > per NIX LF and per LMAC. > > Signed-off-by: Satha Rao Please check http://mails.dpdk.org/archives/test-report/2021-March/181016.html > --- > drivers/common/

Re: [dpdk-dev] [PATCH 40/52] common/cnxk: add npc support

2021-03-26 Thread Jerin Jacob
On Fri, Mar 5, 2021 at 7:16 PM Nithin Dabilpuram wrote: > > From: Kiran Kumar K > > Adding initial npc support. Please add multiple lines of comments on what is NPC. > > Signed-off-by: Kiran Kumar K > --- > drivers/common/cnxk/roc_api.h | 3 + > drivers/common/cnxk/roc_npc.h | 129

Re: [dpdk-dev] [PATCH 01/25] event/dlb2: add dlb v2.5 probe

2021-03-26 Thread Jerin Jacob
On Fri, Mar 26, 2021 at 7:33 PM McDaniel, Timothy wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Friday, March 26, 2021 6:01 AM > > To: McDaniel, Timothy > > Cc: dpdk-dev ; Jerin Jacob ; Van Haaren, > > Harry ; Ray Kinsella ; Neil > > Horman ; Rao, Nikhil ; > > Carri

Re: [dpdk-dev] [PATCH v8 7/8] doc: announce event Rx adapter config changes

2021-03-26 Thread Jerin Jacob
On Fri, Mar 26, 2021 at 7:41 PM wrote: > > From: Pavan Nikhilesh > > The Rx adapter event vector configuration will be merged into > Rx adapter queue configuration to simplify enabling event > vectorization. > > Signed-off-by: Pavan Nikhilesh > Acked-by: Ray Kinsella Acked-by: Jerin Jacob @J

Re: [dpdk-dev] [PATCH 1/4] vhost: fix uninitialized vhost queue

2021-03-26 Thread Maxime Coquelin
On 3/17/21 1:56 PM, Jiayu Hu wrote: > This patch allocates vhost queue by rte_zmalloc() to avoid > undefined values. > > Fixes: 8acd7c213353 ("vhost: fix virtqueues metadata allocation") This is not the right commit. rte_malloc was used prior to it. > Signed-off-by: Jiayu Hu > --- > lib/lib

Re: [dpdk-dev] [PATCH v3 2/2] drivers/net: remove explicit include of legacy filtering

2021-03-26 Thread Ferruh Yigit
On 3/25/2021 10:20 AM, Thomas Monjalon wrote: 25/03/2021 11:00, Ferruh Yigit: On 3/25/2021 5:53 AM, Andrew Rybchenko wrote: On 3/24/21 11:00 PM, Thomas Monjalon wrote: 24/03/2021 19:08, Ferruh Yigit: On 3/21/2021 9:00 AM, Thomas Monjalon wrote: The header file rte_eth_ctrl.h should not be ne

Re: [dpdk-dev] [PATCH v2] mem: fix cleanup when multi-process is disabled

2021-03-26 Thread David Marchand
On Wed, Mar 24, 2021 at 8:32 PM Dmitry Kozlyuk wrote: > > rte_eal_memory_detach() did not account for cases where multi-process > mode is disabled: --in-memory and --no-shconf. This resulted > in unmapping memory that had not been mapped, which caused errors: > > EAL: Could not unmap memory: N

Re: [dpdk-dev] [PATCH] telemetry: cleanup internal header

2021-03-26 Thread David Marchand
On Fri, Mar 26, 2021 at 9:25 AM David Marchand wrote: > > The experimental banner can be removed. > Every in-tree file is compiled with _GNU_SOURCE, so RTE_HAS_CPUSET is > unneeded for an internal header. > > Fixes: 0e64ae618e10 ("telemetry: move init function to internal header") > > Signed-off-b

Re: [dpdk-dev] [PATCH] examples/l3fwd: fix TX burst queue drain edge case

2021-03-26 Thread Kathleen Capella
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, March 24, 2021 1:16 PM > To: Kathleen Capella > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > > Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix TX burst queue drain edge > case > > 23/02/2021 19:23, Kathleen Capella:

Re: [dpdk-dev] [EXT] [PATCH 02/25] event/dlb2: add DLB v2.5 probe-time hardware init

2021-03-26 Thread McDaniel, Timothy
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Sunday, March 21, 2021 5:30 AM > To: McDaniel, Timothy ; dev@dpdk.org > Cc: Van Haaren, Harry ; m...@ashroe.eu; > nhor...@tuxdriver.com; Rao, Nikhil ; Carrillo, Erik G > ; Gujjar, Abhinandan S > ; Pavan Nikhilesh Bhagavatula

[dpdk-dev] [PATCH] drivers: add missing headers

2021-03-26 Thread Ferruh Yigit
These headers are used but not included explicitly, including them. "arpa/inet.h" is included for 'htons' and friends. "netinet/in.h" is included for 'IPPROTO_IP'. Signed-off-by: Ferruh Yigit --- drivers/crypto/dpaa_sec/dpaa_sec.c| 1 + drivers/event/octeontx/ssovf_worker.h | 2 ++ drivers/

Re: [dpdk-dev] [PATCH v3] pflock: implementation of phase-fair reader writer locks

2021-03-26 Thread Stephen Hemminger
On Wed, 3 Mar 2021 11:19:45 -0800 Stephen Hemminger wrote: > This is a new type of reader-writer lock that provides better fairness > guarantees which makes it better for typical DPDK applications. > They lock internally uses two ticket pools, one for readers and one > for writers. > > Phase fa

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: replace callback getting filter operations

2021-03-26 Thread Ferruh Yigit
On 3/24/2021 6:05 PM, Ferruh Yigit wrote: On 3/21/2021 9:00 AM, Thomas Monjalon wrote: Since rte_flow is the only API for filtering operations, the legacy driver interface filter_ctrl was too much complicated for the simple task of getting the struct rte_flow_ops. The filter type RTE_ETH_FILTER

[dpdk-dev] [PATCH] table: relax requirements for table entry action data

2021-03-26 Thread Cristian Dumitrescu
From: Churchill Khangar Currently, the table entry action data is required to be NULL when the action data size is zero. We now require that action data is ignored when the action data size is zero. This is to allow for a table entry instance to be allocated once with max action data size for the

[dpdk-dev] [PATCH v2] table: relax requirements for table entry action data

2021-03-26 Thread Cristian Dumitrescu
From: Churchill Khangar Currently, the table entry action data is required to be NULL when the action data size is zero. We now require that action data is ignored when the action data size is zero. This is to allow for a table entry instance to be allocated once with max action data size for the

[dpdk-dev] [PATCH] pipeline: validate header on emit

2021-03-26 Thread Cristian Dumitrescu
Enhance the behavior of the emit instruction to ignore invalid headers, as mandated by the P4 language specification. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_swx_pipeline.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/librte_pipeline/r

[dpdk-dev] [PATCH] app/test: fix IPv6 header initialization

2021-03-26 Thread Lance Richardson
Fix two issues found when writing PMD unit tests for HW ptype and L4 checksum offload: - The version field in the IPv6 header was being set to zero, which prevented hardware from recognizing it as IPv6. The IP version field is now set to six. - The payload_len field was being initi

Re: [dpdk-dev] [PATCH v2] ethdev: introduce enable_driver_sdk to install driver headers

2021-03-26 Thread Tyler Retzlaff
On Fri, Mar 26, 2021 at 12:02:55PM +, Ferruh Yigit wrote: > On 3/24/2021 4:24 PM, Tyler Retzlaff wrote: > >On Wed, Mar 24, 2021 at 12:30:36PM +0100, Thomas Monjalon wrote: > >>24/03/2021 12:27, Ferruh Yigit: > >>> > >>>But not sure how to manage the same problem for whole project, if install >

Re: [dpdk-dev] [PATCH v3 2/2] drivers/net: remove explicit include of legacy filtering

2021-03-26 Thread Thomas Monjalon
26/03/2021 16:37, Ferruh Yigit: > On 3/25/2021 10:20 AM, Thomas Monjalon wrote: > > 25/03/2021 11:00, Ferruh Yigit: > >> On 3/25/2021 5:53 AM, Andrew Rybchenko wrote: > >>> On 3/24/21 11:00 PM, Thomas Monjalon wrote: > 24/03/2021 19:08, Ferruh Yigit: > > On 3/21/2021 9:00 AM, Thomas Monjal

[dpdk-dev] [PATCH] pipeline: add drop instruction to the SWX pipeline

2021-03-26 Thread Cristian Dumitrescu
Enabled the TX instruction to accept an immediate value for the output port argument. The drop instruction is simply an alias to the TX instruction for the last output port of the pipeline. Signed-off-by: Cristian Dumitrescu --- examples/pipeline/examples/vxlan.spec | 3 +- lib/librte_pipelin

[dpdk-dev] [PATCH v4 00/10] eal: Add new API for threading

2021-03-26 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile EAL thread API **Problem Statement** DPDK currently uses the pthread interface to create and manage threads. Windows does not support the POSIX thread programming model, so it currently relies on a header file that hides the Windows calls under pthread matched interfaces. Gi

[dpdk-dev] [PATCH v4 02/10] eal: add thread attributes

2021-03-26 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Implement thread attributes for: * thread affinity * thread priority Implement functions for managing thread attributes. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c| 53 lib/librte_eal/include/rte_thread.h | 82 +

[dpdk-dev] [PATCH v4 04/10] eal: implement functions for thread affinity management

2021-03-26 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Implement functions for getting/setting thread affinity. Signed-off-by: Narcisa Vasile Signed-off-by: Dmitry Malloy --- lib/librte_eal/common/rte_thread.c | 13 ++ lib/librte_eal/include/rte_thread.h | 41 +++ lib/librte_eal/windows/eal_lcore.c | 170 ++

[dpdk-dev] [PATCH v4 01/10] eal: add thread id and simple thread functions

2021-03-26 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add the thread identifier type. Add functions for comparing thread ids and obtaining the thread id for the current thread. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c| 101 ++ lib/librte_eal/include/rte_thread.h

[dpdk-dev] [PATCH v4 03/10] windows/eal: translate Windows errors to errno-style errors

2021-03-26 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add function to translate Windows error codes to errno-style error codes. Signed-off-by: Narcisa Vasile --- lib/librte_eal/windows/rte_thread.c | 65 ++--- 1 file changed, 50 insertions(+), 15 deletions(-) diff --git a/lib/librte_eal/windows/rte_th

[dpdk-dev] [PATCH v4 05/10] eal: implement thread priority management functions

2021-03-26 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add function for setting the priority for a thread. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c | 25 ++ lib/librte_eal/include/rte_thread.h | 17 +++ lib/librte_eal/windows/rte_thread.c | 76 + 3 files chan

[dpdk-dev] [PATCH v4 07/10] eal: implement functions for mutex management

2021-03-26 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for mutex init, destroy, lock, unlock. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c| 24 + lib/librte_eal/include/rte_thread.h | 53 +++ lib/librte_eal/include/rte_thread_types.h | 3 +

[dpdk-dev] [PATCH v4 06/10] eal: add thread lifetime management

2021-03-26 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add function for thread creation, join, canceling. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c | 110 lib/librte_eal/include/rte_thread.h | 53 lib/librte_eal/windows/rte_thread.c | 125 ++

[dpdk-dev] [PATCH v4 08/10] eal: implement functions for thread barrier management

2021-03-26 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for barrier init, destroy, wait. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c| 16 +++ lib/librte_eal/include/rte_thread.h | 46 +++ lib/librte_eal/include/rte_thread_types.h | 2 + .../in

[dpdk-dev] [PATCH v4 09/10] eal: add EAL argument for setting thread priority

2021-03-26 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Allow the user to choose the thread priority through an EAL command line argument. The user can select the thread priority to be either 'normal' or 'critical': --thread-prio normal --thread-prio realtime Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/eal_common_o

[dpdk-dev] [PATCH V3 1/3] config/arm: add Hisilicon kunpeng implementer

2021-03-26 Thread Lijun Ou
Here adds configs for Kunpeng server. Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous variables") Signed-off-by: Chengchang Tang Signed-off-by: Lijun Ou Acked-by: Jerin Jacob Reviewed-by: Ruifeng Wang --- V2->V3: - refined the commit - merge [1/4] and [2/4] into one. V1->V2: -

[dpdk-dev] [PATCH V3 2/3] config/arm: add kunpeng920 cross target

2021-03-26 Thread Lijun Ou
Add support for Hisilicon kunpeng920 cross target. Signed-off-by: Chengchang Tang Signed-off-by: Lijun Ou Acked-by: Jerin Jacob Reviewed-by: Ruifeng Wang --- V2->V3: - rewrite title - rewrite commit log - add Acked-by and Reviewed-by --- config/arm/arm64_kunpeng920_linux_gcc | 1

  1   2   >