[dpdk-dev] [PATCH 1/2] ethdev: add pre-defined meter policy API

2021-03-31 Thread Li Zhang
Currently, the flow meter policy does not support multiple actions per color; also the allowed action types per color are very limited. In addition, the policy cannot be pre-defined. Due to the growing in flow actions offload abilities there is a potential for the user to use variety of actions pe

[dpdk-dev] [PATCH 2/2] app/testpmd: support policy actions per color

2021-03-31 Thread Li Zhang
From: Haifei Luo add the new create meter with policy API to support it. Signed-off-by: Haifei Luo --- app/test-pmd/cmdline.c | 6 +- app/test-pmd/cmdline_flow.c | 118 +++- app/test-pmd/cmdline_mtr.c | 85 -- app/test-pmd/cmdlin

[dpdk-dev] [PATCH 0/2] Support meter policy API

2021-03-31 Thread Li Zhang
Currently, the flow meter policy does not support multiple actions per color; also the allowed action types per color are very limited. In addition, the policy cannot be pre-defined. Due to the growing in flow actions offload abilities there is a potential for the user to use variety of actions pe

Re: [dpdk-dev] [PATCH 0/2] Check meter packet mode in PMD

2021-03-31 Thread Li Zhang
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Thursday, April 1, 2021 2:31 PM > To: Li Zhang > Cc: Ori Kam ; Slava Ovsiienko ; > Matan Azrad ; cristian.dumitre...@intel.com; > lir...@marvell.com; dev@dpdk.org; Raslan Darawsheh > ; Roni Bar Yanai > Subject: Re: [PATCH

Re: [dpdk-dev] [PATCH v2 08/10] net/sfc: support action VXLAN ENCAP in MAE backend

2021-03-31 Thread Andrew Rybchenko
On 4/1/21 2:36 AM, Ivan Malov wrote: > Hi, > > On 01/04/2021 02:21, Thomas Monjalon wrote: >> 12/03/2021 12:07, Ivan Malov: >>> +static int >>> +sfc_mae_encap_header_add(struct sfc_adapter *sa, >>> + const struct sfc_mae_bounce_eh *bounce_eh, >>> + struct sfc_mae_encap_heade

Re: [dpdk-dev] [PATCH 0/2] Check meter packet mode in PMD

2021-03-31 Thread Thomas Monjalon
01/04/2021 08:16, Li Zhang: > Currently meter algorithms only supports rate is bytes per second(BPS). > Add packet_mode flag in meter profile parameters data structure in RTE. What means RTE? I see no flag added in these patches. > Add the necessary checks to the existing drivers implementing > t

Re: [dpdk-dev] [PATCH 1/2] ethdev: add packet mode in meter profile structure

2021-03-31 Thread Li Zhang
Hi Dumitrescu and Liron, I add the check in softnet and mvpp2 drivers in the following patch. Please help review it. https://patchwork.dpdk.org/project/dpdk/list/?series=16036 Thanks! Regards, Li Zhang > -Original Message- > From: Li Zhang > Sent: Thursday, April 1, 2021 9:42 AM > To: Dum

Re: [dpdk-dev] [PATCH v2] net/igc: fix Rx error counter for badlen packets

2021-03-31 Thread Wang, Haiyue
> -Original Message- > From: Zhang, AlvinX > Sent: Thursday, April 1, 2021 13:21 > To: Wang, Haiyue ; Guo, Jia > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: [PATCH v2] net/igc: fix Rx error counter for badlen packets > > When the size of a packet in Rx channel is less th

[dpdk-dev] [PATCH 1/2] net/softnic: check meter packet mode

2021-03-31 Thread Li Zhang
Currently meter algorithms only supports bytes per second(BPS). Check packet_mode set to TRUE are rejected. Signed-off-by: Li Zhang --- drivers/net/softnic/rte_eth_softnic_meter.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/softnic/rte_eth_softnic_meter.c b/drivers/n

[dpdk-dev] [PATCH 0/2] Check meter packet mode in PMD

2021-03-31 Thread Li Zhang
Currently meter algorithms only supports rate is bytes per second(BPS). Add packet_mode flag in meter profile parameters data structure in RTE. Add the necessary checks to the existing drivers implementing the rte_mtr API to makes sure that profiles with packet_mode set to TRUE are rejected. Depen

[dpdk-dev] [PATCH 2/2] net/mvpp2: check meter packet mode

2021-03-31 Thread Li Zhang
Currently meter algorithms only supports bytes per second(BPS). Check packet_mode set to TRUE are rejected. Signed-off-by: Li Zhang --- drivers/net/mvpp2/mrvl_mtr.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/mvpp2/mrvl_mtr.c b/drivers/net/mvpp2/mrvl_mtr.c index 2fa5cb4

Re: [dpdk-dev] [PATCH v2] net/e1000: fix Rx error counter for badlen packets

2021-03-31 Thread Wang, Haiyue
> -Original Message- > From: Zhang, AlvinX > Sent: Thursday, April 1, 2021 13:22 > To: Wang, Haiyue ; Guo, Jia > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: [PATCH v2] net/e1000: fix Rx error counter for badlen packets > > When the size of a packet in Rx channel is less

[dpdk-dev] [PATCH v2] net/e1000: fix Rx error counter for badlen packets

2021-03-31 Thread Alvin Zhang
When the size of a packet in Rx channel is less than the minimum or greater than the maximum, the packet will be simultaneously counted by RLEC(Receive Length Error Count) and RUC(Receive Under Size Count)/ROC(Receive Oversize Count) registers. This patch fixes the issue of counting a length error

[dpdk-dev] [PATCH v2] net/igc: fix Rx error counter for badlen packets

2021-03-31 Thread Alvin Zhang
When the size of a packet in Rx channel is less than the minimum or greater than the maximum, the packet will be simultaneously counted by RLEC(Receive Length Error Count) and RUC(Receive Under Size Count)/ROC(Receive Oversize Count) registers. This patch fixes the issue of counting a length error

[dpdk-dev] [PATCH v2] net/e1000: fix Rx error counter for badlen packets

2021-03-31 Thread Alvin Zhang
When the size of a packet in Rx channel is less than the minimum or greater than the maximum, the packet will be simultaneously counted by RLEC(Receive Length Error Count) and RUC(Receive Under Size Count)/ROC(Receive Oversize Count) registers. This patch fixed the issue of counting a length error

[dpdk-dev] [PATCH v2] net/igc: fix Rx error counter for badlen packets

2021-03-31 Thread Alvin Zhang
When the size of a packet in Rx channel is less than the minimum or greater than the maximum, the packet will be simultaneously counted by RLEC(Receive Length Error Count) and RUC(Receive Under Size Count)/ROC(Receive Oversize Count) registers. This patch fixed the issue of counting a length error

Re: [dpdk-dev] L3fwd mode in testpmd

2021-03-31 Thread Jerin Jacob
On Thu, Apr 1, 2021 at 5:51 AM Honnappa Nagarahalli wrote: > > > > > > > > > > > > > > > > > On Thu, Mar 11, 2021 at 12:01 AM Honnappa Nagarahalli > > > > > > > wrote: > > > > > > > > > > > > > > > > Hello, > > > > > > > > Performance of L3fwd example application is one of > > > > > > >

Re: [dpdk-dev] [PATCH v3 1/8] app/testpmd: store VXLAN/NVGRE encap data globally

2021-03-31 Thread Jiawei(Jonny) Wang
Hello Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, March 31, 2021 8:08 PM > To: Salem Sol ; dev@dpdk.org > Cc: Jiawei(Jonny) Wang ; Ori Kam ; > Xiaoyun Li > Subject: Re: [dpdk-dev] [PATCH v3 1/8] app/testpmd: store VXLAN/NVGRE > encap data globally > > On 3/17/20

[dpdk-dev] [PATCH v2] net/i40e: fix inappropriate config during flow validate

2021-03-31 Thread Murphy Yang
The configuration of FDIR input set should not be set during flow validate. It should be set when flow create. Fixes: fe5d0e85b713 ("net/i40e: fix flow director flex configuration") Fixes: 15018d79f0be ("net/i40e: add FDIR support for GTP-C and GTP-U") Signed-off-by: Murphy Yang --- v2: - fix me

[dpdk-dev] [PATCH] net/ice: fix illegal pointer access in dev init

2021-03-31 Thread Wenwu Ma
mac_addrs in dev data should be allocated more memory space, Otherwise, traversing mac_addrs in function eth_dev_mac_restore() will result heap-buffer-overflow. Signed-off-by: Wenwu Ma --- drivers/net/ice/ice_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

[dpdk-dev] [PATCH] net/ice: fix illegal pointer access in releasing vsi

2021-03-31 Thread Wenwu Ma
When deleting the mac filter in ice_remove_all_mac_vlan_filters(), TAILQ_FOREACH_SAFE should be used instead of TAILQ_FOREACH, Otherwise, it will result in a illegal pointer access. Signed-off-by: Wenwu Ma --- drivers/net/ice/ice_ethdev.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions

Re: [dpdk-dev] [PATCH 0/6] test: refactor crypto unit test framework

2021-03-31 Thread Ruifeng Wang
> -Original Message- > From: dev On Behalf Of Ciara Power > Sent: Tuesday, March 16, 2021 10:33 PM > To: dev@dpdk.org > Cc: declan.dohe...@intel.com; Ciara Power > Subject: [dpdk-dev] [PATCH 0/6] test: refactor crypto unit test framework > > The current crypto unit test framework is not

[dpdk-dev] [PATCH] net/ice: fix illegal pointer access in releasing vsi

2021-03-31 Thread Wenwu Ma
From: wenwu ma When deleting the mac filter in ice_remove_all_mac_vlan_filters(), TAILQ_FOREACH_SAFE should be used instead of TAILQ_FOREACH, Otherwise, it will result in a null pointer access. Signed-off-by: wenwu ma --- drivers/net/ice/ice_ethdev.c | 7 +-- 1 file changed, 5 insertions(+

[dpdk-dev] [PATCH v3] doc: add sampling and mirroring in testpmd guide

2021-03-31 Thread Jiawei Wang
Update documentation for sample action usage in testpmd and show the command line example. Signed-off-by: Jiawei Wang Acked-by: Viacheslav Ovsiienko --- v3: * Update the description for sampling. v2: * Update the description. --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 52 +++

Re: [dpdk-dev] [PATCH] net/ice: fix illegal pointer access in dev init

2021-03-31 Thread Stephen Hemminger
On Thu, 1 Apr 2021 13:24:53 + Wenwu Ma wrote: > + dev->data->mac_addrs = rte_zmalloc(NULL, > + sizeof(struct rte_ether_addr) * ICE_NUM_MACADDR_MAX, 0); This looks like a good place to use rte_calloc().

[dpdk-dev] [PATCH] net/bnxt: fix double free in port start failure

2021-03-31 Thread Kalesh A P
From: Kalesh AP During port start when bnxt_start_nic() fails, it tries to free "intr_handle->intr_vec" but the variable is not set to NULL after that. If port start fails, driver invokes bnxt_dev_stop() which will lead to a double free of "intr_handle->intr_vec". Fix it by removing the call to

Re: [dpdk-dev] [PATCH v2 3/3] net/ice: support FDIR for IP fragment packet

2021-03-31 Thread Xu, Ting
Hi, Jeff See inline Best Regards, Xu Ting > -Original Message- > From: Guo, Jia > Sent: Wednesday, March 24, 2021 9:54 PM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: Xu, Ting ; dev@dpdk.org; Guo, Jia > Subject: [PATCH v2 3/3] net/ice: support FDIR for IP fragment packet > > New FDIR par

Re: [dpdk-dev] [PATCH] net/igc: fix Rx error counter for badlen packets

2021-03-31 Thread Wang, Haiyue
> -Original Message- > From: Zhang, AlvinX > Sent: Thursday, April 1, 2021 09:17 > To: Wang, Haiyue ; Guo, Jia > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: [PATCH] net/igc: fix Rx error counter for badlen packets > > When the size of the packet is less than the minimum

[dpdk-dev] [PATCH v3] net/ice: support VXLAN VNI field in FDIR

2021-03-31 Thread Zhirun Yan
Add support for VNI field in FDIR. Treat VXLAN flow type as ICE_FLTR_PTYPE_NONF_IPV4_UDP_VXLAN to align with shared code. It allows to match outer L2/L3, VNI and inner L2/L3 fields with VXLAN pattern. VNI takes 24 bits in VXLAN header, but uses 32 bits for matching in shared code. The 8 bits reserv

Re: [dpdk-dev] [PATCH 1/2] ethdev: add packet mode in meter profile structure

2021-03-31 Thread Li Zhang
Hi Dumitrescu, Thank you for your comments. I will add the necessary checks in V2 patches. Regards, Li Zhang > -Original Message- > From: Dumitrescu, Cristian > Sent: Thursday, April 1, 2021 12:27 AM > To: Li Zhang ; dek...@nvidia.com; Ori Kam > ; Slava Ovsiienko ; Matan > Azrad ; Shaha

[dpdk-dev] [PATCH] net/ice: fix illegal pointer access in releasing vsi

2021-03-31 Thread Wenwu Ma
When deleting the mac filter in ice_remove_all_mac_vlan_filters(), TAILQ_FOREACH_SAFE should be used instead of TAILQ_FOREACH, Otherwise, it will result in a illegal pointer access. Signed-off-by: Wenwu Ma --- drivers/net/ice/ice_ethdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-

[dpdk-dev] [PATCH] net/ice: fix illegal pointer access in dev init

2021-03-31 Thread Wenwu Ma
mac_addrs in dev data should be allocated more memory space, Otherwise, traversing mac_addrs in function eth_dev_mac_restore() will result heap-buffer-overflow. Signed-off-by: Wenwu Ma --- drivers/net/ice/ice_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

Re: [dpdk-dev] [PATCH] config/arm: add support for Marvell CN10K

2021-03-31 Thread Honnappa Nagarahalli
> Subject: Re: [dpdk-dev] [PATCH] config/arm: add support for Marvell CN10K > > On Wed, Mar 31, 2021 at 10:53 PM Nithin Dabilpuram > wrote: > > > > From: Pavan Nikhilesh > > > > Add config support to cross compile for Marvell CN10K SoC. > > Marvell CN10K SoC is based on ARM Neoverse N2 cores.

Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix RSS RETA be reset after port start

2021-03-31 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Wang, Haiyue > Sent: Monday, March 29, 2021 8:41 PM > To: Yang, MurphyX ; dev@dpdk.org > Cc: Yang, Qiming ; Guo, Jia ; > Yang, SteveX ; Zhang, RobinX > > Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix RSS RETA be reset after port > start

[dpdk-dev] [PATCH] net/e1000: fix Rx error counters for badlen packets

2021-03-31 Thread Alvin Zhang
When the size of the packet is less than the minimum or greater than the maximum, the packet will be counted twice in the error packet counter. Fixes: 70bdb18657da ("ethdev: add Rx error counters for missed, badcrc and badlen packets") Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drivers

[dpdk-dev] [PATCH] net/igc: fix Rx error counter for badlen packets

2021-03-31 Thread Alvin Zhang
When the size of the packet is less than the minimum or greater than the maximum, the packet will be counted twice in the error packet counter. Fixes: e6defdfddc3b ("net/igc: enable statistics") Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drivers/net/igc/igc_ethdev.c | 3 +-- 1 file chan

[dpdk-dev] [PATCH] net/igc: fix Rx error counter for badlen packets

2021-03-31 Thread Alvin Zhang
When the size of the packet is less than the minimum or greater than the maximum, the packet will be counted twice in the error packet counter. Fixes: e6defdfddc3b ("net/igc: enable statistics") Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drivers/net/igc/igc_ethdev.c | 3 +-- 1 file chan

Re: [dpdk-dev] L3fwd mode in testpmd

2021-03-31 Thread Honnappa Nagarahalli
> > > > > > > > > > > > On Thu, Mar 11, 2021 at 12:01 AM Honnappa Nagarahalli > > > > > > wrote: > > > > > > > > > > > > > > Hello, > > > > > > > Performance of L3fwd example application is one of > > > > > > > the key > > > > > > benchmarks in DPDK. However, the application does not hav

Re: [dpdk-dev] [PATCH v2 08/10] net/sfc: support action VXLAN ENCAP in MAE backend

2021-03-31 Thread Ivan Malov
Hi, On 01/04/2021 02:21, Thomas Monjalon wrote: 12/03/2021 12:07, Ivan Malov: +static int +sfc_mae_encap_header_add(struct sfc_adapter *sa, +const struct sfc_mae_bounce_eh *bounce_eh, +struct sfc_mae_encap_header **encap_headerp) +{ + struct

Re: [dpdk-dev] [PATCH v2 08/10] net/sfc: support action VXLAN ENCAP in MAE backend

2021-03-31 Thread Thomas Monjalon
12/03/2021 12:07, Ivan Malov: > +static int > +sfc_mae_encap_header_add(struct sfc_adapter *sa, > + const struct sfc_mae_bounce_eh *bounce_eh, > + struct sfc_mae_encap_header **encap_headerp) > +{ > + struct sfc_mae_encap_header *encap_header; > + s

Re: [dpdk-dev] [PATCH] eal: move DMA mapping from bus-specific to generic driver

2021-03-31 Thread Thomas Monjalon
01/04/2021 00:45, Thomas Monjalon: > The operations of DMA mapping and unmapping are controlled in some > bus drivers, following rte_bus specification. > If the device driver don't provide any specific mapping operation, > the bus driver may have a fallback (VFIO case for PCI). > > The DMA mapping

[dpdk-dev] [PATCH] eal: move DMA mapping from bus-specific to generic driver

2021-03-31 Thread Thomas Monjalon
The operations of DMA mapping and unmapping are controlled in some bus drivers, following rte_bus specification. If the device driver don't provide any specific mapping operation, the bus driver may have a fallback (VFIO case for PCI). The DMA mapping done by the device drivers are called from the

[dpdk-dev] [PATCH 2/2] bus/pci: rename probe/remove operation types

2021-03-31 Thread Thomas Monjalon
The names of the prototypes pci_probe_t and pci_remove_t are missing a prefix rte_. These function types are simply renamed. No compatibility break is expected for the applications because it is considered as an internal name in the driver interface. Signed-off-by: Thomas Monjalon --- drivers/b

[dpdk-dev] [PATCH 1/2] pci: rename catch-all ID

2021-03-31 Thread Thomas Monjalon
The name of the constant PCI_ANY_ID was missing RTE_ prefix. It is renamed, and the old name becomes a deprecated alias. While renaming, the duplicate definitions in rte_bus_pci.h are removed to keep only those in rte_pci.h. Note: rte_pci.h is included in rte_bus_pci.h Signed-off-by: Thomas Monja

[dpdk-dev] [PATCH 0/2] pci: add rte prefix

2021-03-31 Thread Thomas Monjalon
Small namespace cleanups in PCI lib and bus driver. Thomas Monjalon (2): pci: rename catch-all ID bus/pci: rename probe/remove operation types drivers/bus/pci/pci_common.c | 8 drivers/bus/pci/rte_bus_pci.h | 20 lib/librte_pci/rte_pci.h | 12 +++-

Re: [dpdk-dev] [PATCH v5 09/10] eal: add EAL argument for setting thread priority

2021-03-31 Thread Stephen Hemminger
On Thu, 1 Apr 2021 00:12:54 +0300 Dmitry Kozlyuk wrote: > 2021-03-30 14:11 (UTC-0700), Stephen Hemminger: > > On Mon, 29 Mar 2021 15:40:39 -0700 > > Narcisa Ana Maria Vasile wrote: > > > > > From: Narcisa Vasile > > > > > > Allow the user to choose the thread priority through an EAL > > > c

Re: [dpdk-dev] [PATCH v6 3/5] eal: make OS shims internal

2021-03-31 Thread Thomas Monjalon
31/03/2021 23:45, Nick Connolly: > > > > I don't understand your point. > > I am just proposing to allow some apps to explicitly include the shim > > for their convenience in case they are fully based on DPDK and > > understand the risk of conflict with some other code. > > > Agreed - there’s no

Re: [dpdk-dev] [PATCH v6 3/5] eal: make OS shims internal

2021-03-31 Thread Nick Connolly
> > I don't understand your point. > I am just proposing to allow some apps to explicitly include the shim > for their convenience in case they are fully based on DPDK and > understand the risk of conflict with some other code. Agreed - there’s no harm in doing so. My point was simply that for a

Re: [dpdk-dev] [PATCH v6 3/5] eal: make OS shims internal

2021-03-31 Thread Thomas Monjalon
31/03/2021 23:05, Nick Connolly: > > > This shim could have been convenient for applications. > > If not named "internal", we could export the header file > > and allow apps including it. > > > > Otherwise the app can recreate this file on its side, > > it is not a big deal. > > Opinions? > Based

Re: [dpdk-dev] [PATCH v5 03/10] windows/eal: translate Windows errors to errno-style errors

2021-03-31 Thread Nick Connolly
Also, I don't think this is a thread specific function, other implementations can use it in the future, maybe move it to rte_windows.h? I'd suggest that it's probably better suited to a .c file rather than a header.  As an example of what it might end up like see https://github.com/wpdk/wpdk

Re: [dpdk-dev] L3fwd mode in testpmd

2021-03-31 Thread Jerin Jacob
On Thu, Apr 1, 2021 at 2:05 AM Kathleen Capella wrote: > > > > > -Original Message- > > From: Honnappa Nagarahalli > > Sent: Thursday, March 11, 2021 11:00 AM > > To: tho...@monjalon.net > > Cc: Jerin Jacob ; dev@dpdk.org; Kathleen Capella > > ; Dharmik Thakkar > > ; Ruifeng Wang ; > > da

Re: [dpdk-dev] [PATCH v5 09/10] eal: add EAL argument for setting thread priority

2021-03-31 Thread Dmitry Kozlyuk
2021-03-30 14:11 (UTC-0700), Stephen Hemminger: > On Mon, 29 Mar 2021 15:40:39 -0700 > Narcisa Ana Maria Vasile wrote: > > > From: Narcisa Vasile > > > > Allow the user to choose the thread priority through an EAL > > command line argument. > > > > The user can select the thread priority to be

Re: [dpdk-dev] [PATCH v6 3/5] eal: make OS shims internal

2021-03-31 Thread Nick Connolly
This shim could have been convenient for applications. If not named "internal", we could export the header file and allow apps including it. Otherwise the app can recreate this file on its side, it is not a big deal. Opinions? Based on my experience with SPDK, I believe this would get messy v

Re: [dpdk-dev] L3fwd mode in testpmd

2021-03-31 Thread Kathleen Capella
> -Original Message- > From: Honnappa Nagarahalli > Sent: Thursday, March 11, 2021 11:00 AM > To: tho...@monjalon.net > Cc: Jerin Jacob ; dev@dpdk.org; Kathleen Capella > ; Dharmik Thakkar > ; Ruifeng Wang ; > david.march...@redhat.com; Bruce Richardson > ; jer...@marvell.com; > hemant.

Re: [dpdk-dev] [PATCH v2 2/2] test/crypto: support block cipher DIGEST_ENCRYPTED mode

2021-03-31 Thread Akhil Goyal
> > Adding support for block cipher DIGEST_ENCRYPTED mode. > > Signed-off-by: Tejasree Kondoj > --- Acked-by: Akhil Goyal

Re: [dpdk-dev] [PATCH v2 1/2] common/cpt: support DIGEST_ENCRYPTED mode

2021-03-31 Thread Akhil Goyal
> Adding support for DIGEST_ENCRYPTED mode. > > Signed-off-by: Tejasree Kondoj > --- Acked-by: Akhil Goyal

Re: [dpdk-dev] [PATCH v2] app/test-pmd: enable testpmd on windows

2021-03-31 Thread Kadam, Pallavi
On 3/19/2021 9:51 AM, Jie Zhou wrote: From: Jie Zhou This patch is to enable testpmd on windows. It mainly includes: - Enable building libraries on Windows that TestPMD depends on - Enable building testpmd on Windows - Resolve name collisions with Windows types - Add clock_gettime_monotic for

Re: [dpdk-dev] [PATCH v2] build: optional NUMA and cpu counts detection

2021-03-31 Thread David Christensen
On 3/31/21 2:06 AM, Juraj Linkeš wrote: Add an option to automatically discover the host's numa and cpu counts and use those values for a non cross-build. Give users the option to override the per-arch default values or values from cross files by specifying them on the command line with -Dmax_l

Re: [dpdk-dev] [PATCH 03/52] common/cnxk: add model init and IO handling API

2021-03-31 Thread Nithin Dabilpuram
On Fri, Mar 26, 2021 at 07:18:35PM +0530, Jerin Jacob wrote: > On Fri, Mar 5, 2021 at 7:10 PM Nithin Dabilpuram > wrote: > > > > From: Jerin Jacob > > > > Add routines for SoC model identification and HW IO handling > > routines specific to CN9K and CN10K Marvell SoC's. > > These are based on arm

Re: [dpdk-dev] [PATCH] config/arm: add support for Marvell CN10K

2021-03-31 Thread Jerin Jacob
On Wed, Mar 31, 2021 at 10:53 PM Nithin Dabilpuram wrote: > > From: Pavan Nikhilesh > > Add config support to cross compile for Marvell CN10K SoC. > Marvell CN10K SoC is based on ARM Neoverse N2 cores. cores->core > > Signed-off-by: Nithin Dabilpuram > Signed-off-by: Pavan Nikhilesh With the

[dpdk-dev] [PATCH] config/arm: add support for Marvell CN10K

2021-03-31 Thread Nithin Dabilpuram
From: Pavan Nikhilesh Add config support to cross compile for Marvell CN10K SoC. Marvell CN10K SoC is based on ARM Neoverse N2 cores. Signed-off-by: Nithin Dabilpuram Signed-off-by: Pavan Nikhilesh --- config/arm/arm64_cn10k_linux_gcc | 20 1 file changed, 20 insertions(+

[dpdk-dev] [dpdk-dev v2] cryptodev: change raw data path dequeue API

2021-03-31 Thread Fan Zhang
This patch changes the experimental raw data path dequeue burst API. Originally the API enforces the user to provide callback function to get maximum dequeue count. This change gives the user one more option to pass directly the expected dequeue count. Signed-off-by: Fan Zhang --- app/test/test_

Re: [dpdk-dev] [PATCH v2 1/2] vhost: Add API to get negotiated protocol features

2021-03-31 Thread Ferruh Yigit
On 3/22/2021 7:22 AM, Keiichi Watanabe wrote: Add rte_vhost_get_negotiated_protocol_features, which returns a set of enabled protocol features. Signed-off-by: Keiichi Watanabe <...> diff --git a/lib/librte_vhost/version.map b/lib/librte_vhost/version.map index 9183d6f2f..95c4c0990 100644 --

Re: [dpdk-dev] [PATCH v4] pflock: add phase-fair reader writer locks

2021-03-31 Thread Stephen Hemminger
On Wed, 31 Mar 2021 04:19:14 + Honnappa Nagarahalli wrote: > > + > > + rte_pflock_write_lock(&sl); > > + /* this message should be the last message of test */ > > + printf("Global write lock taken on main core %u\n", rte_lcore_id()); > > + rte_pflock_write_unlock(&sl); > > + > > + r

Re: [dpdk-dev] [PATCH 1/2] ethdev: add packet mode in meter profile structure

2021-03-31 Thread Dumitrescu, Cristian
Hi Li, > -Original Message- > From: Li Zhang > Sent: Wednesday, March 31, 2021 9:54 AM > To: dek...@nvidia.com; or...@nvidia.com; viachesl...@nvidia.com; > ma...@nvidia.com; shah...@nvidia.com; Dumitrescu, Cristian > ; Thomas Monjalon > ; Yigit, Ferruh ; Andrew > Rybchenko > Cc: dev@dpdk

Re: [dpdk-dev] [PATCH v1] net/octeontx2: support flow action port id

2021-03-31 Thread Ferruh Yigit
On 3/27/2021 2:29 PM, Jerin Jacob wrote: On Fri, Mar 26, 2021 at 3:18 PM wrote: From: Smadar Fuks Action port_id was not supported until now. In this patch the action port_id supports passing from input port PF to output port which is one of input port respective VF Signed-off-by: Smadar Fu

[dpdk-dev] [PATCH] doc: refer to the supported Field IDs for modify field API

2021-03-31 Thread Alexander Kozyrev
Include the rte_flow_field_id enumeration reference into the documentation to point to the full list of all supported Field IDs available for the MODIFY_FIELD RTE action. Signed-off-by: Alexander Kozyrev Acked-by: Viacheslav Ovsiienko --- doc/guides/prog_guide/rte_flow.rst | 11 +-- 1 f

Re: [dpdk-dev] [PATCH v2 5/6] doc: add list of supported Field IDs to modify

2021-03-31 Thread Ferruh Yigit
On 3/24/2021 3:04 PM, Alexander Kozyrev wrote: Include the rte_flow_field_id enumeration into the documentation to provide the full list of all supported Field IDs available for the MODIFY_FIELD RTE action. Signed-off-by: Alexander Kozyrev --- doc/guides/prog_guide/rte_flow.rst | 45 +

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-03-31 Thread Dumitrescu, Cristian
Hi Matan, > -Original Message- > From: Matan Azrad > Sent: Monday, March 29, 2021 9:44 PM > To: Dumitrescu, Cristian ; Li Zhang > ; Dekel Peled ; Ori Kam > ; Slava Ovsiienko ; Shahaf > Shuler ; lir...@marvell.com; Singh, Jasvinder > ; NBU-Contact-Thomas Monjalon > ; Yigit, Ferruh ; Andrew

Re: [dpdk-dev] [PATCH] doc: add sampling and mirroring in testpmd guide

2021-03-31 Thread Ferruh Yigit
On 3/31/2021 3:38 PM, Jiawei(Jonny) Wang wrote: Hi Ferruh, -Original Message- From: Ferruh Yigit Sent: Wednesday, March 31, 2021 5:45 PM To: Jiawei(Jonny) Wang ; Slava Ovsiienko ; xiaoyun...@intel.com; Ori Kam Cc: dev@dpdk.org; Andrew Rybchenko ; NBU- Contact-Thomas Monjalon Subject:

Re: [dpdk-dev] [PATCH v3 0/3] support GTPU inner IPv4/IPv6 for AVF FDIR.

2021-03-31 Thread Ferruh Yigit
On 3/26/2021 6:41 AM, Zhang, Qi Z wrote: -Original Message- From: Guo, Junfeng Sent: Friday, March 26, 2021 10:30 PM To: Zhang, Qi Z ; Wu, Jingjing ; Xing, Beilei Cc: dev@dpdk.org; Wang, Haiyue ; Zhang, Yuying ; Guo, Junfeng Subject: [PATCH v3 0/3] support GTPU inner IPv4/IPv6 for A

Re: [dpdk-dev] [PATCH v3 1/3] net/iavf: support GTPU inner IPv4 for FDIR

2021-03-31 Thread Ferruh Yigit
On 3/26/2021 2:29 PM, Junfeng Guo wrote: Support GTPU_(EH)_IPV4 inner L3 and L4 fields matching for AVF FDIR. +--+-+ | Pattern|Input Set| +--+

Re: [dpdk-dev] [PATCH 5/6] test/crypto: dynamically build blockcipher suite

2021-03-31 Thread Akhil Goyal
Hi Ciara, Nice work. I have below comment on the output of the results. ++ more crypto PMD maintainers. > In the existing implementation, the blockcipher test cases are being run > and reported as one test case per type, even though multiple test cases > are hidden in each. For example, "test_AE

Re: [dpdk-dev] [PATCH 0/6] test: refactor crypto unit test framework

2021-03-31 Thread Aaron Conole
"Doherty, Declan" writes: > Hey Aaron, > > based on the work you've been doing on the unit test documentation we > would appreciate if you could take a look over this patchset and get > your thoughts. The primary drive here is to make it easier to get a > clear picture of what is being executed i

Re: [dpdk-dev] [PATCH 2/6] test: introduce parent testsuite format

2021-03-31 Thread Aaron Conole
Ciara Power writes: > The current structure for unit testing only allows for running a > test suite with nested test cases. This means all test cases for an > autotest must be in one suite, which is not ideal. > For example, in some cases we may want to run multiple lists of test > cases that eac

Re: [dpdk-dev] [PATCH 1/6] app/test: refactor of unit test suite runner

2021-03-31 Thread Aaron Conole
Ciara Power writes: > Some small changes were made to the unit test suite runner for > readability and to enable reuse of some of the function in a later patch. > > On test suite setup skip/fail, the loop to count testcases as > skipped/failed has been moved to another function. > This will allow

Re: [dpdk-dev] [PATCH] doc: add sampling and mirroring in testpmd guide

2021-03-31 Thread Jiawei(Jonny) Wang
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, March 31, 2021 5:45 PM > To: Jiawei(Jonny) Wang ; Slava Ovsiienko > ; xiaoyun...@intel.com; Ori Kam > > Cc: dev@dpdk.org; Andrew Rybchenko ; NBU- > Contact-Thomas Monjalon > Subject: Re: [PATCH] doc: add sampling an

[dpdk-dev] [PATCH v3] vhost: add support for packed ring in async vhost

2021-03-31 Thread Cheng Jiang
For now async vhost data path only supports split ring structure. In order to make async vhost compatible with virtio 1.1 spec this patch enables packed ring in async vhost data path. Signed-off-by: Cheng Jiang --- v3: * fix error handler for DMA-copy packet * remove variables that are no lon

Re: [dpdk-dev] [PATCH 6/6] doc: add unit test suite change to release notes

2021-03-31 Thread Akhil Goyal
> The unit test suite framework now supports having nested sub-testsuites, > or a list of testcases as before. > This new unit test feature is added to the release notes. > > Signed-off-by: Ciara Power > --- No need for a separate patch for release notes. You can squash it in last patch.

Re: [dpdk-dev] [PATCH v5 03/10] windows/eal: translate Windows errors to errno-style errors

2021-03-31 Thread Tal Shnaiderman
> Subject: [PATCH v5 03/10] windows/eal: translate Windows errors to errno- > style errors > > External email: Use caution opening links or attachments > > > From: Narcisa Vasile > > Add function to translate Windows error codes to errno-style error codes. > > Signed-off-by: Narcisa Vasile >

[dpdk-dev] [PATCH] examples/pipeline: add newline to error messages

2021-03-31 Thread Cristian Dumitrescu
Add newline to some error messages that were missing it. Signed-off-by: Cristian Dumitrescu --- examples/pipeline/cli.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c index 9d7d69d34..ef47febaa 100644 --- a/examples/pip

Re: [dpdk-dev] [PATCH v2 0/6] modify field action enhancements

2021-03-31 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, March 24, 2021 5:05 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad ; Ori Kam > > Subject: [PATCH v2 0/6] modify field action enhancements > > Various fixes/improvements for RTE MODIFY_F

Re: [dpdk-dev] [PATCH v4] build: add platform meson option

2021-03-31 Thread Bruce Richardson
On Wed, Mar 31, 2021 at 12:16:59PM +, Juraj Linkeš wrote: > Bruce, what do you think of the patch now? Do we need to add/change anything > else, like documentation? > > One thing to note is that we're changing the default behavior in this patch > from machine=native to machine=generic (or mo

Re: [dpdk-dev] [PATCH v1] net/iavf: implement power management API

2021-03-31 Thread Ferruh Yigit
On 3/11/2021 1:37 PM, Burakov, Anatoly wrote: On 11-Mar-21 11:55 AM, David Hunt wrote: Implement support for the power management API by implementing a `get_monitor_addr` function that will return an address of an RX ring's status bit. This patch is basically a cut-and-paste of the changes alre

Re: [dpdk-dev] [PATCH v4] build: add platform meson option

2021-03-31 Thread Juraj Linkeš
> -Original Message- > From: Juraj Linkeš > Sent: Wednesday, March 31, 2021 2:17 PM > To: Juraj Linkeš ; tho...@monjalon.net; > david.march...@redhat.com; bruce.richard...@intel.com; > honnappa.nagaraha...@arm.com > Cc: dev@dpdk.org > Subject: RE: [PATCH v4] build: add platform meson opt

Re: [dpdk-dev] [PATCH v4] build: add platform meson option

2021-03-31 Thread Juraj Linkeš
Bruce, what do you think of the patch now? Do we need to add/change anything else, like documentation? One thing to note is that we're changing the default behavior in this patch from machine=native to machine=generic (or more accurately, to cpu_instruction_set=generic). Do we want to do that?

Re: [dpdk-dev] [PATCH v3 8/8] doc: update dpdk 21.05 release notes

2021-03-31 Thread Ferruh Yigit
On 3/17/2021 9:26 AM, Salem Sol wrote: Update release notes for dpdk 21.05 to include the new Mellanox driver's support for VXLAN and NVGRE encap as sample actions. Signed-off-by: Salem Sol --- doc/guides/rel_notes/release_21_05.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/d

Re: [dpdk-dev] [PATCH v3 1/8] app/testpmd: store VXLAN/NVGRE encap data globally

2021-03-31 Thread Ferruh Yigit
On 3/17/2021 9:26 AM, Salem Sol wrote: From: Jiawei Wang With the current code the VXLAN/NVGRE parsing routine stored the configuration of the header on stack, this might lead to overwriting the data on the stack. This patch stores the external data of vxlan and nvgre encap into global data as

Re: [dpdk-dev] [PATCH v3 6/8] doc: update sample actions support in testpmd guide

2021-03-31 Thread Ferruh Yigit
On 3/17/2021 9:26 AM, Salem Sol wrote: Update documentation for sample action usage in testpmd utilizing rte_flow_action_vxlan_encap and rte_flow_action_nvgre_encap and show the command line example. This patch has dependency to [1], right, can you please confirm it? [1]: https://patches.dpd

Re: [dpdk-dev] [PATCH 2/2] net/hns3: support IEEE 1588 PTP

2021-03-31 Thread Min Hu (Connor)
在 2021/3/31 17:26, Ferruh Yigit 写道: On 3/31/2021 8:28 AM, Thomas Monjalon wrote: 31/03/2021 04:35, Min Hu (Connor): 在 2021/3/30 21:59, Ferruh Yigit 写道: On 3/26/2021 8:56 AM, Min Hu (Connor) wrote: Add hns3 support for new ethdev APIs to enable and read IEEE1588/ 802.1AS PTP timestamps. Si

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-03-31 Thread Jerin Jacob
On Tue, Mar 30, 2021 at 2:01 AM Matan Azrad wrote: > > Hi Jerin > > Thanks for the review. > PSB > > From: Jerin Jacob > > On Thu, Mar 18, 2021 at 2:28 PM Li Zhang wrote: > > > > > > Currently, the flow meter policy does not support multiple actions per > > > color; also the allowed action types

[dpdk-dev] [PATCH v17 2/3] build: add 'platform' meson option and Arm SoC config

2021-03-31 Thread Juraj Linkeš
Add Arm SoC configuration sets to Arm meson.build and add an arch agnostic meson option, 'platform', to select from these SoC configurations for meson native builds. This is preferable to specifying a cross file when doing aarch64 -> aarch64 builds, since the cross file specifies the toolchain as w

[dpdk-dev] [PATCH v17 3/3] config: fix Arm implementer and its SoCs

2021-03-31 Thread Juraj Linkeš
Fix the implementer and part number of DPAA and ARMADA SoCs. The current values of 16 cores and 1 NUMA node don't cover all SoCs from the Arm implementer, e.g. Taishan 2280 has 64 cores and 4 NUMA nodes. Increase these to 64 and 4 to widen the coverage. Add configuration to SoC options where smalle

[dpdk-dev] [PATCH v17 1/3] build: disable/enable drivers in Arm builds

2021-03-31 Thread Juraj Linkeš
Add support for enabling or disabling drivers for Arm cross build. Do not implement any enable/disable lists yet. Enabling drivers is useful when building for an SoC where we only want to build a few drivers. That way the list won't be too long. Similarly, disabling drivers is useful when we want

[dpdk-dev] [PATCH v17 0/3] Arm build options rework

2021-03-31 Thread Juraj Linkeš
The current way of specifying Arm configuration options is insufficient since we can't identify the SoC we're building for from the MIDR information. For example, we can't distinguish between N1SDP, Graviton2 or Ampere Altra. We also want to be able to enable/disable which drivers are built withou

Re: [dpdk-dev] [PATCH 2/2] [RFC]: ethdev: manage meter API object handles by the drivers

2021-03-31 Thread Jerin Jacob
On Tue, Mar 30, 2021 at 1:40 AM Matan Azrad wrote: > > Hi Jerin Hi Matan > > Thanks for the review. > PSB > > From: Jerin Jacob > > On Thu, Mar 25, 2021 at 1:51 PM Matan Azrad wrote: > > > > > > Hi Cristian > > > > > > From: Dumitrescu, Cristian > > > > Hi Li and Matan, > > > > > > > > > -

Re: [dpdk-dev] [PATCH v3 4/5] bus: add device arguments name parsing API

2021-03-31 Thread Thomas Monjalon
The commit log should start by explaining it is adding a callback to the bus drivers for the new devargs syntax. 30/03/2021 14:15, Xueming Li: > To use Global Device Syntax as devargs, name is required for device > management. Context is missing. You mean the argument "name" for the vdev bus? >

[dpdk-dev] [PATCH v2 2/2] net/ice: add Rx AVX512 offload path

2021-03-31 Thread Leyi Rong
Split AVX512 Rx data path into two, one is for basic, the other one can support additional Rx offload features, including Rx checksum offload, Rx vlan offload, RSS offload. Signed-off-by: Leyi Rong Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_rxtx.c| 46 +++- drivers/net/ice/i

[dpdk-dev] [PATCH v2 1/2] net/ice: add Tx AVX512 offload path

2021-03-31 Thread Leyi Rong
Add alternative Tx data path for AVX512 which can support partial Tx offload features, including Tx checksum offload, vlan/QinQ insertion offload. Signed-off-by: Leyi Rong Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_rxtx.c| 27 +-- drivers/net/ice/ice_rxtx.h|

[dpdk-dev] [PATCH v2 0/2] add alternative AVX512 offload path

2021-03-31 Thread Leyi Rong
Add alternative Rx/Tx offload path for AVX512, which can support Rx/Tx offload features, like checksum/vlan/RSS/QinQ offload. --- v2: - add "do_offload" parameter to according functions for reducing code duplication. Leyi Rong (2): net/ice: add Tx AVX512 offload path net/ice: add Rx AVX512

  1   2   >