Re: [dpdk-dev] [PATCH v6 3/3] test/event_crypto: use crypto adapter enqueue API

2021-04-12 Thread Shijith Thotton
On Mon, Apr 12, 2021 at 05:10:56AM +, Gujjar, Abhinandan S wrote: > Hi Shijith, > > CI is failing for this patch -> ci/Intel-compilation failapply issues > Whereas CI is not running for other patches. Could you please check? > [snip] Hi Abhinandan, Full CI is run only for the last patc

Re: [dpdk-dev] [PATCH 0/7] support set thread name

2021-04-12 Thread David Marchand
On Sat, Apr 10, 2021 at 12:40 PM Min Hu (Connor) wrote: > > This set of patches support set thread name for debugging. > > Chengwen Feng (7): > net/ark: support set thread name > net/ice: support set VSI reset thread name > vdpa/ifc: support set notify and vring relay thread name > raw/ifp

Re: [dpdk-dev] [PATCH v2 7/8] app/bbdev: add parameter to take input in network order

2021-04-12 Thread David Marchand
On Sat, Apr 10, 2021 at 7:04 PM Hemant Agrawal wrote: > > From: Nipun Gupta > > Test bbdev application is reading the input and output from the > test vector files in the same endianness which is of the system. > This patch adds an option to provide data in the network order > i.e. big endian for

Re: [dpdk-dev] [PATCH v6 3/3] test/event_crypto: use crypto adapter enqueue API

2021-04-12 Thread Gujjar, Abhinandan S
Hi Shijith, > -Original Message- > From: Shijith Thotton > Sent: Monday, April 12, 2021 12:33 PM > To: Gujjar, Abhinandan S > Cc: Shijith Thotton ; dev@dpdk.org; > tho...@monjalon.net; jer...@marvell.com; hemant.agra...@nxp.com; > nipun.gu...@nxp.com; sachin.sax...@oss.nxp.com; ano...@ma

Re: [dpdk-dev] [PATCH] eventdev: fix doxygen for function declaration

2021-04-12 Thread Jerin Jacob
On Fri, Apr 9, 2021 at 6:50 PM wrote: > > From: Pavan Nikhilesh > > Fix missing parameters in doxygen of function declaration. > > Fixes: 5b1337f0a08a ("eventdev: introduce event vector Rx capability") Squashed to this change in the next-eventdev tree. > > Signed-off-by: Pavan Nikhilesh > --

Re: [dpdk-dev] [PATCH v2 4/5] net/mlx5: add mlx5 APIs for single flow dump feature

2021-04-12 Thread Slava Ovsiienko
> -Original Message- > From: Haifei Luo > Sent: Wednesday, April 7, 2021 9:09 > To: dev@dpdk.org > Cc: Ori Kam ; Slava Ovsiienko ; > Raslan Darawsheh ; Xueming(Steven) Li > ; Haifei Luo ; Matan Azrad > ; Shahaf Shuler > Subject: [PATCH v2 4/5] net/mlx5: add mlx5 APIs for single flow dump

Re: [dpdk-dev] [PATCH v2 7/8] app/bbdev: add parameter to take input in network order

2021-04-12 Thread Hemant Agrawal
On 4/12/2021 12:52 PM, David Marchand wrote: On Sat, Apr 10, 2021 at 7:04 PM Hemant Agrawal wrote: From: Nipun Gupta Test bbdev application is reading the input and output from the test vector files in the same endianness which is of the system. This patch adds an option to provide data in

Re: [dpdk-dev] [PATCH v1] eventdev: fix case to initiate crypto adapter service

2021-04-12 Thread Jerin Jacob
On Fri, Apr 9, 2021 at 12:38 PM Shijith Thotton wrote: > > Initiate software crypto adapter service, only if hardware capabilities > are not reported. > > Case 1.a. OP_FORWARD mode -> HW Dequeue + SW enqueue, should also check Case 1.a is required in the commit message? > OP_FORWARD capability

Re: [dpdk-dev] [PATCH v2 3/5] common/mlx5: add mlx5 APIs for single flow dump feature

2021-04-12 Thread Slava Ovsiienko
> -Original Message- > From: Haifei Luo > Sent: Wednesday, April 7, 2021 9:09 > To: dev@dpdk.org > Cc: Ori Kam ; Slava Ovsiienko ; > Raslan Darawsheh ; Xueming(Steven) Li > ; Haifei Luo ; Matan Azrad > ; Shahaf Shuler ; Ray Kinsella > ; Neil Horman > Subject: [PATCH v2 3/5] common/mlx5: a

Re: [dpdk-dev] [PATCH v6 3/3] test/event_crypto: use crypto adapter enqueue API

2021-04-12 Thread Shijith Thotton
On Mon, Apr 12, 2021 at 07:24:21AM +, Gujjar, Abhinandan S wrote: > Hi Shijith, > > > -Original Message- > > From: Shijith Thotton > > Sent: Monday, April 12, 2021 12:33 PM > > To: Gujjar, Abhinandan S > > Cc: Shijith Thotton ; dev@dpdk.org; > > tho...@monjalon.net; jer...@marvell.co

Re: [dpdk-dev] [PATCH v2 4/5] net/mlx5: add mlx5 APIs for single flow dump feature

2021-04-12 Thread Slava Ovsiienko
> -Original Message- > From: Haifei Luo > Sent: Wednesday, April 7, 2021 9:09 > To: dev@dpdk.org > Cc: Ori Kam ; Slava Ovsiienko ; > Raslan Darawsheh ; Xueming(Steven) Li > ; Haifei Luo ; Matan Azrad > ; Shahaf Shuler > Subject: [PATCH v2 4/5] net/mlx5: add mlx5 APIs for single flow dump

[dpdk-dev] [PATCH v7 0/3] Enhancements to crypto adapter forward mode

2021-04-12 Thread Shijith Thotton
This series proposes a new event device enqueue operation if crypto adapter forward mode is supported. Second patch in the series is the implementation of the same in PMD. Test application changes are added in third patch. v7: - Rebased. v6: - Rebased. v5: - Set rte_errno if crypto adapter enque

[dpdk-dev] [PATCH v7 1/3] eventdev: introduce crypto adapter enqueue API

2021-04-12 Thread Shijith Thotton
From: Akhil Goyal In case an event from a previous stage is required to be forwarded to a crypto adapter and PMD supports internal event port in crypto adapter, exposed via capability RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD, we do not have a way to check in the API rte_event_enqueue_bur

[dpdk-dev] [PATCH v7 2/3] event/octeontx2: support crypto adapter forward mode

2021-04-12 Thread Shijith Thotton
Advertise crypto adapter forward mode capability and set crypto adapter enqueue function in driver. Signed-off-by: Shijith Thotton --- drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 42 ++ drivers/event/octeontx2/otx2_evdev.c | 5 +- .../event/octeontx2/otx2_evdev_crypto_adptr

[dpdk-dev] [PATCH v7 3/3] test/event_crypto: use crypto adapter enqueue API

2021-04-12 Thread Shijith Thotton
Use rte_event_crypto_adapter_enqueue() API to enqueue events to crypto adapter if forward mode is supported in driver. Signed-off-by: Shijith Thotton --- app/test/test_event_crypto_adapter.c | 33 ++-- 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/app/te

Re: [dpdk-dev] [PATCH v2 1/2] telemetry: fix missing check for thread creation

2021-04-12 Thread David Marchand
On Mon, Apr 12, 2021 at 2:32 AM Min Hu (Connor) wrote: > > From: Chengwen Feng > > Add result check and message print out for thread creation after > failure. Ah, I was looking at this code too, while looking at your other series :-). > > Fixes: b80fe1805eee ("telemetry: introduce backward com

Re: [dpdk-dev] [Linuxarm] Re: [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test

2021-04-12 Thread Ferruh Yigit
On 4/10/2021 3:58 AM, oulijun wrote: 在 2021/4/10 8:56, Ferruh Yigit 写道: On 3/25/2021 2:21 AM, Li, Xiaoyun wrote: -Original Message- From: oulijun Sent: Wednesday, March 24, 2021 21:40 To: linux...@openeuler.org; Li, Xiaoyun ; dev Subject: Re: [Linuxarm] Re: [PATCH 1/3] app/testpm

Re: [dpdk-dev] [PATCH v6 00/10] eal: Add new API for threading

2021-04-12 Thread David Marchand
On Sat, Apr 3, 2021 at 3:39 AM Narcisa Ana Maria Vasile wrote: > > From: Narcisa Vasile > > EAL thread API > > **Problem Statement** > DPDK currently uses the pthread interface to create and manage threads. > Windows does not support the POSIX thread programming model, so it currently > relies on

Re: [dpdk-dev] [PATCH] eal/windows: fix pthreads macros return values

2021-04-12 Thread Tal Shnaiderman
> Subject: Re: [PATCH] eal/windows: fix pthreads macros return values > > External email: Use caution opening links or attachments > > > Hi Tal, > > Getting warnings from x86_64-w64-mingw32-gcc (GCC) 9.3.0: > > ../../../lib/librte_eal/common/eal_common_thread.c: In function > ‘ctrl_params_free

Re: [dpdk-dev] [PATCH] examples/ptpclient: delete wrong comments

2021-04-12 Thread Ferruh Yigit
On 4/10/2021 10:11 AM, Min Hu (Connor) wrote: Hi, Ferruh, kirill and all, Any comments about this patch? 在 2021/3/27 15:36, Min Hu (Connor) 写道: This patch deletes the comments which are wrong and unnecessary. Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client") Cc: sta...@dp

[dpdk-dev] [PATCH] net/memif: fix missing Tx-bps stats for zero-copy

2021-04-12 Thread Tianyu Li
Fix the missing Tx-bps counter for memif zero-copy mode Before Rx-pps: 6891450 Rx-bps: 3528438928 Tx-pps: 6891482 Tx-bps:0 After Throughput (since last show) Rx-pps: 11157056 Rx-bps: 5712413016 Tx-pps: 11157056 Tx-bps:

Re: [dpdk-dev] [PATCH] eal/windows: fix pthreads macros return values

2021-04-12 Thread Thomas Monjalon
12/04/2021 09:59, Tal Shnaiderman: > > Subject: Re: [PATCH] eal/windows: fix pthreads macros return values > > > > External email: Use caution opening links or attachments > > > > > > Hi Tal, > > > > Getting warnings from x86_64-w64-mingw32-gcc (GCC) 9.3.0: > > > > ../../../lib/librte_eal/comm

Re: [dpdk-dev] [PATCH v1 3/4] net/mlx5: fix rebuild bug for Memory Region cache

2021-04-12 Thread Slava Ovsiienko
Hi, Feifei Sorry, I do not follow what this patch fixes. Do we have some issue/bug with MR cache in practice? Each Tx queue has its own dedicated "local" cache for MRs to convert buffer address in mbufs being transmitted to LKeys (HW-related entity handle) and the "global" cache for all MR reg

[dpdk-dev] [PATCH 0/3] add lock-free stack support discovery

2021-04-12 Thread Stanislaw Kardach
The lock-free stack implementation (RTE_STACK_F_LF) is supported only on a subset of platforms, namely x86_64 and arm64. Platforms supporting 128b atomics have to opt-in to a generic or C11 implementations. All other platforms use a stubbed implementation for push/pop operations which are basically

[dpdk-dev] [PATCH 1/3] stack: update lock-free supported archs

2021-04-12 Thread Stanislaw Kardach
Since 7911ba047 lock-free stack is supported on arm64 but this description was missing from the doxygen for the flag. Signed-off-by: Stanislaw Kardach Fixes: 7911ba0473e0 ("stack: enable lock-free implementation for aarch64") Cc: phil.y...@arm.com Cc: sta...@dpdk.org --- lib/librte_stack/rte_sta

[dpdk-dev] [PATCH 2/3] stack: add lock-free support indication

2021-04-12 Thread Stanislaw Kardach
Currently it is impossible to detect programatically whether lock-free implementation of rte_stack is supported. One could check whether the header guard for lock-free stubs is defined (_RTE_STACK_LF_STUBS_H_) but that's an unstable implementation detail. Because of that currently all lock-free rin

[dpdk-dev] [PATCH 3/3] test: run lock-free stack tests when supported

2021-04-12 Thread Stanislaw Kardach
Use the recently added RTE_STACK_LF_SUPPORTED flag to disable the lock-free stack tests at the compile time. Perf test doesn't fail because rte_ring_create() succeeds, however marking this test as skipped gives a better indication of what actually was tested. Signed-off-by: Stanislaw Kardach Cc:

Re: [dpdk-dev] [RFC] bus/auxiliary: introduce auxiliary bus

2021-04-12 Thread Xueming(Steven) Li
> +/* > + * Test whether the auxiliary device exist */ bool > +auxiliary_exists(const char *name) { > + DIR *dir; > + char dirname[PATH_MAX]; > + > + snprintf(dirname, sizeof(dirname), "%s/%s", > + rte_auxiliary_get_sysfs_path(), name); > + dir = opendir(rte_auxilia

Re: [dpdk-dev] [PATCH v3 1/3] net/ice/base: support IP fragment RSS and FDIR

2021-04-12 Thread Xu, Ting
Hi, Jeff, Best Regards, Xu Ting > -Original Message- > From: Guo, Jia > Sent: Sunday, April 11, 2021 2:07 PM > To: Zhang, Qi Z ; Yang, Qiming > > Cc: dev@dpdk.org; Xu, Ting ; Guo, Jia > Subject: [PATCH v3 1/3] net/ice/base: support IP fragment RSS and FDIR > > Add support for IP fragm

Re: [dpdk-dev] [PATCH v3 4/4] net/iavf: support FDIR for IP fragment packet

2021-04-12 Thread Xu, Ting
Hi, Jeff Best Regards, Xu Ting > -Original Message- > From: Guo, Jia > Sent: Sunday, April 11, 2021 2:02 PM > To: or...@nvidia.com; Zhang, Qi Z ; Xing, Beilei > ; Li, Xiaoyun ; Wu, Jingjing > > Cc: dev@dpdk.org; Xu, Ting ; Guo, Jia > Subject: [PATCH v3 4/4] net/iavf: support FDIR for I

[dpdk-dev] [PATCH v2] eventdev: fix case to initiate crypto adapter service

2021-04-12 Thread Shijith Thotton
Initiate software crypto adapter service, only if hardware capabilities are not reported. In OP_FORWARD mode, software service is not required to enqueue events if OP_FORWARD capability is supported by the PMD. Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation") Signed-off-by: Shi

[dpdk-dev] [PATCH v2] net/ice: support flow priority for DCF switch filter

2021-04-12 Thread Yuying Zhang
Support rte flow priority attribute for DCF switch filter. The rules with same patterns couldn't be created at the same time since they were related to the same recipe. This patch supports flow priority to create different recipes for this situation. Only priority 0 and 1 are supported and higher v

Re: [dpdk-dev] [PATCH v3] vhost: add header check in dequeue offload

2021-04-12 Thread Wang, Xiao W
Hi, > -Original Message- > From: Wang, Xiao W > Sent: Friday, April 2, 2021 4:39 PM > To: David Marchand > Cc: Xia, Chenbo ; Maxime Coquelin > ; Liu, Yong ; dev > ; Ananyev, Konstantin ; > dpdk stable ; yangy...@inspur.com > Subject: RE: [PATCH v3] vhost: add header check in dequeue offlo

Re: [dpdk-dev] 19.11.8 patches review and test

2021-04-12 Thread Christian Ehrhardt
On Fri, Apr 9, 2021 at 9:44 AM Christian Ehrhardt wrote: > > Hi all, > > Here is a list of patches targeted for stable release 19.11.8. > > The planned date for the final release is 16th April. > > Please help with testing and validation of your use cases and report > any issues/results with reply

Re: [dpdk-dev] [PATCH v3] vhost: add header check in dequeue offload

2021-04-12 Thread David Marchand
On Mon, Apr 12, 2021 at 11:09 AM Wang, Xiao W wrote: > Considering the major consumer of vhost API is virtual switch/router, I tend > to keep the current implementation and apply this fix patch. > Any comments? This is just a hack that bypasses the vswitch control. It happens to work when the v

Re: [dpdk-dev] [PATCH v2 2/3] hash: add predictable RSS implementation

2021-04-12 Thread Ananyev, Konstantin
> > > > >> +#defineRETA_SZ_MIN2U > >> +#defineRETA_SZ_MAX16U > > > > Should these RETA_SZ defines be in public header? > > So user can know what are allowed values? > > > > I don't think this is necessary, because the user chooses it not > arbitrary, but depending on the NIC. Sure thing, but i

Re: [dpdk-dev] [PATCH] eal/windows: fix pthreads macros return values

2021-04-12 Thread Dmitry Kozlyuk
2021-04-12 07:59 (UTC+), Tal Shnaiderman: > > Subject: Re: [PATCH] eal/windows: fix pthreads macros return values > > > > External email: Use caution opening links or attachments > > > > > > Hi Tal, > > > > Getting warnings from x86_64-w64-mingw32-gcc (GCC) 9.3.0: > > > > ../../../lib/libr

[dpdk-dev] [PATCH 1/3] test: disable no-huge test with PA IOVA

2021-04-12 Thread Stanislaw Kardach
On linux systems without IOMMU support available (be it lack of supported IOMMU or lack of IOMMU support in kernel), the IOVA mapping will default to DMA with physical addresses. This implicitly requires hugepage support (most prominently for performance reasons). Therefore trying to run the eal_fl

[dpdk-dev] [PATCH 0/3] Increase test compatibility with PA IOVA

2021-04-12 Thread Stanislaw Kardach
While working in some scenarios where only RTE_IOVA_PA is available I've noticed that some of the EAL tests are failing because of a totally different reason than the test itself. Namely the --no-huge flag and PA IOVA can't be used together and EAL init fails warning about this. This patchset tries

[dpdk-dev] [PATCH 2/3] test: disable no-huge where it's not necessary

2021-04-12 Thread Stanislaw Kardach
In tests where no-shconf flag is used, no-huge is also passed due to compatibility with FreeBSD system, as described in: b5d878e6d. However on Linux systems with RTE_IOVA_PA (lack of or an incompatible IOMMU) this causes issues since hugepages are required by EAL. Therefore replace all occurrences

[dpdk-dev] [PATCH 3/3] test: fix the -n unit test description

2021-04-12 Thread Stanislaw Kardach
When -n argument became optional, the test logic was fixed (by 1e0b51fd4) but the comment indicating why --no-huge and --no-shconf are used was not changed. Today those flags are used for compatibility with FreeBSD (see b5d878e6d), so change the comment to reflect that. Signed-off-by: Stanislaw Ka

Re: [dpdk-dev] [PATCH] eal/windows: fix pthreads macros return values

2021-04-12 Thread David Marchand
On Sat, Apr 10, 2021 at 9:55 PM Tal Shnaiderman wrote: > > The macro definitions of the following pthread functions > return incorrect values from the inner function return code. > > while pthread_barrier_init, pthread_barrier_destroy and > pthread_cancel return 0 in a case of success and non zero

Re: [dpdk-dev] [PATCH] eal/windows: fix pthreads macros return values

2021-04-12 Thread Tal Shnaiderman
> Subject: Re: [PATCH] eal/windows: fix pthreads macros return values > > External email: Use caution opening links or attachments > > > On Sat, Apr 10, 2021 at 9:55 PM Tal Shnaiderman > wrote: > > > > The macro definitions of the following pthread functions return > > incorrect values from the

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: remove forwarding config from parsing Rx and Tx

2021-04-12 Thread Ferruh Yigit
On 3/5/2021 10:22 AM, Lijun Ou wrote: From: Huisong Li The "fwd_config_setup()" function does release and apply for memory of forwarding flows, and re-establish these streams when rxq/txq or rxd/txd is changed. The function is also called by "start_packet_forwarding()" when user executes "start

[dpdk-dev] [PATCH v2] eal/windows: fix pthreads macros return values

2021-04-12 Thread Tal Shnaiderman
The macro definitions of the following pthread functions return incorrect values from the inner function return code. while pthread_barrier_init, pthread_barrier_destroy and pthread_cancel return 0 in a case of success and non zero (errno) value otherwise the shimming functions InitializeSynchroni

Re: [dpdk-dev] [PATCH] common/mlx5: fix missing __rte_internal tags in exported functions

2021-04-12 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Tal Shnaiderman > Sent: Sunday, April 11, 2021 3:22 PM > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon ; Matan Azrad > ; Raslan Darawsheh ; Asaf Penso > ; Wisam Monther ; > sta...@dpdk.org > Subject: [PATCH] common/mlx5: fix missing __rte_internal tag

Re: [dpdk-dev] [PATCH] test: make hugepage check more robust under Linux

2021-04-12 Thread David Marchand
On Fri, Apr 9, 2021 at 5:33 PM Thomas Monjalon wrote: > > > This seems to me like the test binary itself should be checking the > > > presence of hugepages, and reporting skips if necessary. It's not just > > > when > > > run through ninja that this functionality would be useful. > > > > Either w

[dpdk-dev] [PATCH v5 1/4] vhost: abstract and reorganize async split ring code

2021-04-12 Thread Cheng Jiang
In order to improve code efficiency and readability when async packed ring support is enabled. This patch abstract some functions like shadow_ring_store and write_back_completed_descs_split. And improve the efficiency of some pointer offset calculation. Signed-off-by: Cheng Jiang --- lib/librte_

[dpdk-dev] [PATCH v5 2/4] vhost: add support for packed ring in async vhost

2021-04-12 Thread Cheng Jiang
For now async vhost data path only supports split ring structure. In order to make async vhost compatible with virtio 1.1 spec this patch enables packed ring in async vhost data path. Signed-off-by: Cheng Jiang --- lib/librte_vhost/rte_vhost_async.h | 1 + lib/librte_vhost/vhost.c |

[dpdk-dev] [PATCH v5 3/4] vhost: add batch datapath for async vhost packed ring

2021-04-12 Thread Cheng Jiang
Add batch datapath for async vhost packed ring to improve the performance of small packet. Signed-off-by: Cheng Jiang --- lib/librte_vhost/virtio_net.c | 43 +++ 1 file changed, 38 insertions(+), 5 deletions(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/lib

[dpdk-dev] [PATCH v5 4/4] doc: add release note for vhost async packed ring

2021-04-12 Thread Cheng Jiang
Add release note for the support of vhost async packed ring. Signed-off-by: Cheng Jiang --- doc/guides/rel_notes/release_21_05.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_21_05.rst b/doc/guides/rel_notes/release_21_05.rst index 374d6d98e..eb5200669 1

[dpdk-dev] [PATCH v5 0/4] add support for packed ring in async vhost

2021-04-12 Thread Cheng Jiang
For now async vhost data path only supports split ring structure. In order to make async vhost compatible with virtio 1.1 spec this patch set cleans async split ring codes and enables packed ring in async vhost data path. Batch datapath is also enabled in async vhost packed ring. v5: * clean some

Re: [dpdk-dev] [PATCH v4 3/5] kvargs: add get by key function

2021-04-12 Thread Xueming(Steven) Li
> -Original Message- > From: Olivier Matz > Sent: Monday, April 12, 2021 2:53 PM > To: Xueming(Steven) Li > Cc: NBU-Contact-Thomas Monjalon ; Gaetan Rivet > ; dev@dpdk.org; Asaf Penso > ; Ray Kinsella ; Neil Horman > > Subject: Re: [PATCH v4 3/5] kvargs: add get by key function > >

Re: [dpdk-dev] [PATCH v4 1/5] devargs: unify scratch buffer storage

2021-04-12 Thread Xueming(Steven) Li
> -Original Message- > From: Tal Shnaiderman > Sent: Sunday, April 11, 2021 4:00 AM > To: Xueming(Steven) Li ; NBU-Contact-Thomas Monjalon > ; Gaetan Rivet > > Cc: dev@dpdk.org; Xueming(Steven) Li ; Asaf Penso > ; Wenzhuo Lu > ; Beilei Xing ; Bernard > Iremonger ; Gaetan Rivet > ; A

Re: [dpdk-dev] [Linuxarm] Re: [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test

2021-04-12 Thread oulijun
在 2021/4/12 15:52, Ferruh Yigit 写道: On 4/10/2021 3:58 AM, oulijun wrote: 在 2021/4/10 8:56, Ferruh Yigit 写道: On 3/25/2021 2:21 AM, Li, Xiaoyun wrote: -Original Message- From: oulijun Sent: Wednesday, March 24, 2021 21:40 To: linux...@openeuler.org; Li, Xiaoyun ; dev Subject: R

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: remove forwarding config from parsing Rx and Tx

2021-04-12 Thread oulijun
在 2021/4/12 18:35, Ferruh Yigit 写道: On 3/5/2021 10:22 AM, Lijun Ou wrote: From: Huisong Li The "fwd_config_setup()" function does release and apply for memory of forwarding flows, and re-establish these streams when rxq/txq or rxd/txd is changed. The function is also called by "start_packet

Re: [dpdk-dev] [PATCH] common/mlx5: fix missing __rte_internal tags in exported functions

2021-04-12 Thread Thomas Monjalon
12/04/2021 13:25, Raslan Darawsheh: > Removed __ from the commit title to fix wrong headline format issue. Removing __ makes it wrong: rte_internal does not exist. The idea of discouraging the use of underscore is to avoid naming bits and bytes in the title. Here it should be: "add missing interna

Re: [dpdk-dev] [PATCH] common/mlx5: fix missing __rte_internal tags in exported functions

2021-04-12 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Thomas Monjalon > Sent: Monday, April 12, 2021 3:26 PM > To: Tal Shnaiderman ; Raslan Darawsheh > > Cc: dev@dpdk.org; Matan Azrad ; Asaf Penso > ; Wisam Monther ; > sta...@dpdk.org > Subject: Re: [PATCH] common/mlx5: fix missing __rte_internal tags in > e

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix queue Rx and Tx offload reconfig cmd

2021-04-12 Thread Ferruh Yigit
On 4/12/2021 3:21 AM, Li, Xiaoyun wrote: -Original Message- From: Yu, DapengX Sent: Friday, April 9, 2021 18:29 To: Li, Xiaoyun ; Yigit, Ferruh ; Zhang, Qi Z Cc: dev@dpdk.org; sta...@dpdk.org Subject: RE: [dpdk-stable] [PATCH] app/testpmd: fix queue Rx and Tx offload reconfig cmd

Re: [dpdk-dev] [PATCH] net/mlx5: fix resource release issue for mirror flow

2021-04-12 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Jiawei Wang > Sent: Friday, April 9, 2021 3:33 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko ; > Jiawei(Jonny) Wang > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix resource release issue for mirr

Re: [dpdk-dev] [dpdk-stable] [PATCH] common/mlx5: fix missing __rte_internal tags in exported functions

2021-04-12 Thread Ferruh Yigit
On 4/12/2021 12:25 PM, Raslan Darawsheh wrote: Hi, -Original Message- From: Tal Shnaiderman Sent: Sunday, April 11, 2021 3:22 PM To: dev@dpdk.org Cc: NBU-Contact-Thomas Monjalon ; Matan Azrad ; Raslan Darawsheh ; Asaf Penso ; Wisam Monther ; sta...@dpdk.org Subject: [PATCH] common/mlx5

Re: [dpdk-dev] [dpdk-stable] [PATCH] common/mlx5: fix missing __rte_internal tags in exported functions

2021-04-12 Thread Thomas Monjalon
12/04/2021 14:59, Ferruh Yigit: > On 4/12/2021 12:25 PM, Raslan Darawsheh wrote: > > Hi, > > > > From: Tal Shnaiderman > >> > > Removed __ from the commit title to fix wrong headline format issue. > > > >> Several functions introduced in the addition of the Windows support to > >> mlx5 were miss

[dpdk-dev] [PATCH V3] app/testpmd: support Tx mbuf free on demand cmd

2021-04-12 Thread Lijun Ou
From: Chengwen Feng This patch support tx_done_cleanup command: tx_done_cleanup port (port_id) (queue_id) (free_cnt) Users must make sure there are no concurrent access to the same Tx queue (like rte_eth_tx_burst, rte_eth_dev_tx_queue_stop and so on) this command executed. Signed-off-by: Chengw

[dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1

2021-04-12 Thread Jerin Jacob Kollanukkaran
Patched moved to next pull-request for next RC1 ~ 1) http://patches.dpdk.org/user/todo/dpdk/?series=16285 (Waiting for @abhinandan.guj...@intel.com Ack) 2) http://patches.dpdk.org/project/dpdk/patch/8d73cf4b565f5f66badaca26ec3a9f26cedf2304.1618217424.git.

Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1

2021-04-12 Thread McDaniel, Timothy
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Monday, April 12, 2021 8:20 AM > To: Thomas Monjalon ; Gujjar, Abhinandan S > ; McDaniel, Timothy > ; Jerin Jacob Kollanukkaran > ; Van Haaren, Harry > Cc: dev@dpdk.org; Shijith Thotton ; Akhil Goyal > ; Pavan Nikhilesh Bhag

Re: [dpdk-dev] [dpdk-stable] [PATCH] common/mlx5: fix missing __rte_internal tags in exported functions

2021-04-12 Thread Ferruh Yigit
On 4/12/2021 2:06 PM, Thomas Monjalon wrote: 12/04/2021 14:59, Ferruh Yigit: On 4/12/2021 12:25 PM, Raslan Darawsheh wrote: Hi, From: Tal Shnaiderman Removed __ from the commit title to fix wrong headline format issue. Several functions introduced in the addition of the Windows support t

Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1

2021-04-12 Thread Jerin Jacob
On Mon, Apr 12, 2021 at 6:57 PM McDaniel, Timothy wrote: > Jerin, > > I had sent you an email last week asking for clarification on your request > that I use git mv. @McDaniel, Timothy Could you share the link for patchwork link for the same. > > Thanks, Tim

Re: [dpdk-dev] [PATCH v6 3/3] test/event_crypto: use crypto adapter enqueue API

2021-04-12 Thread Shijith Thotton
On Mon, Apr 12, 2021 at 01:05:45PM +0530, Shijith Thotton wrote: > On Mon, Apr 12, 2021 at 07:24:21AM +, Gujjar, Abhinandan S wrote: > > Hi Shijith, > > > > > -Original Message- > > > From: Shijith Thotton > > > Sent: Monday, April 12, 2021 12:33 PM > > > To: Gujjar, Abhinandan S > >

Re: [dpdk-dev] [dpdk-stable] [PATCH] common/mlx5: fix missing __rte_internal tags in exported functions

2021-04-12 Thread David Marchand
On Mon, Apr 12, 2021 at 3:35 PM Ferruh Yigit wrote: > > On 4/12/2021 2:06 PM, Thomas Monjalon wrote: > > 12/04/2021 14:59, Ferruh Yigit: > >> On 4/12/2021 12:25 PM, Raslan Darawsheh wrote: > >>> Hi, > >>> > >>> From: Tal Shnaiderman > > >>> Removed __ from the commit title to fix wrong headl

Re: [dpdk-dev] [PATCH v19 0/3] Arm build options rework

2021-04-12 Thread Honnappa Nagarahalli
> > > It seems that our SoC configuration patches are block by this series: > https://patchwork.dpdk.org/project/dpdk/list/?series=15918 Thank you and appreciate your help. Appreciate updating your patch according to this series. > > I reworked our configuration based on this series and then t

Re: [dpdk-dev] [PATCH 0/7] support set thread name

2021-04-12 Thread Power, Ciara
>-Original Message- >From: David Marchand >Sent: Monday 12 April 2021 08:20 >To: Min Hu (Connor) ; Shepard Siegel >; Yang, Qiming ; >Wang, Xiao W ; Xu, Rosen ; >Maxime Coquelin >Cc: dev ; Yigit, Ferruh ; Mcnamara, >John ; Power, Ciara >Subject: Re: [dpdk-dev] [PATCH 0/7] support set thr

Re: [dpdk-dev] [PATCH v3 0/7] Enhancements and fixes for flow-perf

2021-04-12 Thread Thomas Monjalon
14/03/2021 10:54, Wisam Jaddo: > v4: > * Fix warrning of 100 char long line. > * Add more discription in cover letter. > > Wisam Jaddo (7): > app/flow-perf: start using more generic wrapper for cycles > app/flow-perf: add new option to use unique data on the fly > app/flow-perf: fix naming o

Re: [dpdk-dev] [dpdk-stable] [PATCH v5 3/3] kni: fix kernel deadlock when using mlx devices

2021-04-12 Thread Elad Nachman
Hi, The new patch is fine by me. Tested several dozens restarts of our proprietary application without apparent problem. FYI, Elad. בתאריך יום ו׳, 9 באפר׳ 2021, 17:56, מאת Ferruh Yigit ‏< ferruh.yi...@intel.com>: > On 3/29/2021 3:36 PM, Ferruh Yigit wrote: > > KNI runs userspace callback with

Re: [dpdk-dev] [EXT] [PATCH v19 0/3] Arm build options rework

2021-04-12 Thread Pavan Nikhilesh Bhagavatula
Hi Juraj, >The current way of specifying Arm configuration options is insufficient >since we can't identify the SoC we're building for from the MIDR >information. For example, we can't distinguish between N1SDP, >Graviton2 >or Ampere Altra. > >We also want to be able to enable/disable which driver

Re: [dpdk-dev] [PATCH v6 3/3] test/event_crypto: use crypto adapter enqueue API

2021-04-12 Thread Gujjar, Abhinandan S
> -Original Message- > From: Shijith Thotton > Sent: Monday, April 12, 2021 7:22 PM > To: Gujjar, Abhinandan S > Cc: Shijith Thotton ; dev@dpdk.org; > tho...@monjalon.net; jer...@marvell.com; hemant.agra...@nxp.com; > nipun.gu...@nxp.com; sachin.sax...@oss.nxp.com; ano...@marvell.com;

Re: [dpdk-dev] [dpdk-stable] [PATCH] common/mlx5: fix missing __rte_internal tags in exported functions

2021-04-12 Thread Tal Shnaiderman
> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] common/mlx5: fix missing > __rte_internal tags in exported functions > > External email: Use caution opening links or attachments > > > On Mon, Apr 12, 2021 at 3:35 PM Ferruh Yigit > wrote: > > > > On 4/12/2021 2:06 PM, Thomas Monjalon wrote: > >

Re: [dpdk-dev] [PATCH] eal: move DMA mapping from bus-specific to generic driver

2021-04-12 Thread Kinsella, Ray
On 31/03/2021 23:53, Thomas Monjalon wrote: > 01/04/2021 00:45, Thomas Monjalon: >> The operations of DMA mapping and unmapping are controlled in some >> bus drivers, following rte_bus specification. >> If the device driver don't provide any specific mapping operation, >> the bus driver may have a

Re: [dpdk-dev] [dpdk-stable] [PATCH] common/mlx5: fix missing __rte_internal tags in exported functions

2021-04-12 Thread Ferruh Yigit
On 4/12/2021 2:54 PM, David Marchand wrote: On Mon, Apr 12, 2021 at 3:35 PM Ferruh Yigit wrote: On 4/12/2021 2:06 PM, Thomas Monjalon wrote: 12/04/2021 14:59, Ferruh Yigit: On 4/12/2021 12:25 PM, Raslan Darawsheh wrote: Hi, From: Tal Shnaiderman Removed __ from the commit title to fix

Re: [dpdk-dev] [PATCH] common/mlx5: fix missing __rte_internal tags in exported functions

2021-04-12 Thread Thomas Monjalon
11/04/2021 14:21, Tal Shnaiderman: > Several functions introduced in the addition of the Windows support to > mlx5 were missing the __rte_internal tag although being exported. > > Fixes: 1552fb287166 ("common/mlx5: add alloc/dealloc PD on Windows") > Fixes: 1969ee424405 ("common/mlx5: add UMEM reg

Re: [dpdk-dev] [PATCH v8] app/testpmd: support multi-process

2021-04-12 Thread Ferruh Yigit
On 3/30/2021 2:48 AM, Min Hu (Connor) wrote: From: Lijun Ou This patch adds multi-process support for testpmd. The test cmd example as follows: the primary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ --rxq=4 --txq=4 --num-procs=2 --proc-id=0 the secondary cmd: ./dpdk-testpmd -a

Re: [dpdk-dev] [PATCH v9 05/10] kvargs: update parser to support multiple lists

2021-04-12 Thread Kinsella, Ray
On 11/03/2021 13:13, Xueming Li wrote: > This patch updates kvargs parser to support value of multiple lists or > ranges: > k1=v[1,2]v[3-5] > > Signed-off-by: Xueming Li > Acked-by: Viacheslav Ovsiienko > Acked-by: Thomas Monjalon > --- > app/test/test_kvargs.c | 46 +

[dpdk-dev] DTS improvement workgroup

2021-04-12 Thread Honnappa Nagarahalli
Hello, I am trying to setup a workgroup to improve DTS. The intention is make it easy for the development community to add test cases while developing new features. There are already few ideas captured in [1]. Few of us (in the CC list) are meeting on 13th April, 8AM to 9AM CST (1:00PM t

Re: [dpdk-dev] DTS improvement workgroup

2021-04-12 Thread Jerin Jacob Kollanukkaran
Hi Honnappa, Could you send us a meeting invitation? From: techboard on behalf of Honnappa Nagarahalli Sent: Monday, April 12, 2021 10:56 PM To: dev@dpdk.org ; c...@dpdk.org ; Aaron Conole Cc: techbo...@dpdk.org ; Juraj Linkeš ; Lincoln Lavoie ; ferruh.yi.

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add packet integrity checks

2021-04-12 Thread Ferruh Yigit
On 4/11/2021 6:34 PM, Gregory Etelson wrote: From: Ori Kam Currently, DPDK application can offload the checksum check, and report it in the mbuf. However, as more and more applications are offloading some or all logic and action to the HW, there is a need to check the packet integrity so the r

Re: [dpdk-dev] DTS improvement workgroup

2021-04-12 Thread Honnappa Nagarahalli
Ok, will send out a meeting notice. I missed the reference in the earlier mail. Here is the reference. [1] https://docs.google.com/document/d/1c5S0_mZzFvzZfYkqyORLT2-qNvUb-fBdjA6DGusy4yM/edit# From: Jerin Jacob Kollanukkaran Sent: Monday, April 12, 2021 12:34 PM To: Honnappa Nagarahalli ; dev@

Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: add support for integrity item

2021-04-12 Thread Ferruh Yigit
On 4/11/2021 6:34 PM, Gregory Etelson wrote: From: Ori Kam The integrity item allows the application to match on the integrity of a packet. use example: match that packet integrity checks are ok. The checks depend on packet layers. For example ICMP packet will not check L4 level. flow create 0

[dpdk-dev] DTS improvement workgroup meeting

2021-04-12 Thread Honnappa Nagarahalli
Hello, I am trying to setup a workgroup to improve DTS. The intention is make it easy for the development community to add test cases while developing new features. Suggestion for the agenda items: 1) Agree upon the goal for the working group 2) Discuss timelines 3) Next steps (any recur

[dpdk-dev] [PATCH] net/enic: fix completion pointer calculation

2021-04-12 Thread John Daley
The completion queue index could be implicitly extended past its uint16_t size when multiplied by the size of the descriptor. While this should not be a problem, coverity flags it. Do the extention explicitly by casting the index to uintptr_t. Coverity issue: 161317 Fixes: 8b428cb5a92e ("net/enic:

Re: [dpdk-dev] [PATCH v3 3/4] net/softnic: check meter packet mode

2021-04-12 Thread Dumitrescu, Cristian
> -Original Message- > From: Li Zhang > Sent: Saturday, April 10, 2021 8:25 AM > To: dek...@nvidia.com; or...@nvidia.com; viachesl...@nvidia.com; > ma...@nvidia.com; shah...@nvidia.com; Dumitrescu, Cristian > ; lir...@marvell.com; Singh, Jasvinder > > Cc: dev@dpdk.org; tho...@monjalon.

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add packet mode in meter profile structure

2021-04-12 Thread Dumitrescu, Cristian
> -Original Message- > From: Li Zhang > Sent: Saturday, April 10, 2021 8:25 AM > To: dek...@nvidia.com; or...@nvidia.com; viachesl...@nvidia.com; > ma...@nvidia.com; shah...@nvidia.com; Dumitrescu, Cristian > ; lir...@marvell.com; Thomas Monjalon > ; Yigit, Ferruh ; Andrew > Rybchenko

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add packet integrity checks

2021-04-12 Thread Ori Kam
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Subject: Re: [PATCH v2 1/2] ethdev: add packet integrity checks > > On 4/11/2021 6:34 PM, Gregory Etelson wrote: > > From: Ori Kam > > > > Currently, DPDK application can offload the checksum check, > > and report it in the mbuf. >

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add packet mode in meter profile structure

2021-04-12 Thread Jerin Jacob
On Tue, Apr 13, 2021 at 12:54 AM Dumitrescu, Cristian wrote: > > > > > -Original Message- > > From: Li Zhang > > Sent: Saturday, April 10, 2021 8:25 AM > > To: dek...@nvidia.com; or...@nvidia.com; viachesl...@nvidia.com; > > ma...@nvidia.com; shah...@nvidia.com; Dumitrescu, Cristian > > ;

Re: [dpdk-dev] [PATCH v2 1/5] ethdev: modify rte API for single flow dump

2021-04-12 Thread Ori Kam
Hi Haifei, > -Original Message- > From: Haifei Luo > Sent: Wednesday, April 7, 2021 9:09 AM > > Subject: [PATCH v2 1/5] ethdev: modify rte API for single flow dump > > Previous implementations support dump all the flows. Add new arg > rte_flow in rte_flow_dev_dump to dump one flow. > >

Re: [dpdk-dev] [PATCH v2 0/4] Change shared action API to action handle API

2021-04-12 Thread Ferruh Yigit
On 4/10/2021 3:03 PM, Bing Zhao wrote: The patch set includes: 1. API changes 2. testpmd adaption and guide update 3. driver update (only net/mlx5 impacted) --- v2: add adaptions of testpmd and driver part --- Bing Zhao (4): ethdev: introduce indirect action APIs app/test-pmd: ch

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: introduce indirect action APIs

2021-04-12 Thread Ferruh Yigit
On 4/10/2021 3:03 PM, Bing Zhao wrote: Right now, rte_flow_shared_action_* APIs are used for some shared actions, like RSS, count. The shared action should be created before using it inside a flow. These shared actions sometimes are not really shared but just some indirect actions decoupled from

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] eal/windows: fix pthreads macros return values

2021-04-12 Thread Thomas Monjalon
12/04/2021 12:37, Tal Shnaiderman: > The macro definitions of the following pthread functions > return incorrect values from the inner function return code. > > while pthread_barrier_init, pthread_barrier_destroy and > pthread_cancel return 0 in a case of success and non zero (errno) value > other

[dpdk-dev] [PATCH v1] net/enic: fix completion pointer calculation

2021-04-12 Thread John Daley
The completion queue index could be implicitly extended past its uint16_t size when multiplied by the size of the descriptor. While this should not be a problem, coverity flags it. Do the extension explicitly by casting the index to uintptr_t. Coverity issue: 161317 Fixes: 8b428cb5a92e ("net/enic:

Re: [dpdk-dev] [PATCH v4 4/5] bus: add device arguments name parsing API

2021-04-12 Thread Thomas Monjalon
10/04/2021 16:23, Xueming Li: > + /* Resolve devarg's name. */ s/devarg's name/devargs name/ > + if (bus && bus->devargs_parse) Please make checks explicits with != NULL > + ret = bus->devargs_parse(devargs); > + else if (layers[0].kvlist != NULL) > + ret = d

Re: [dpdk-dev] [PATCH v4 3/5] kvargs: add get by key function

2021-04-12 Thread Thomas Monjalon
12/04/2021 14:07, Xueming(Steven) Li: > From: Olivier Matz > > > + if (!kvlist) > > > + return NULL; > > > + for (i = 0; i < kvlist->count; ++i) { > > > + /* Allows key to be NULL. */ > > > + if (!key && !kvlist->pairs[i].key) > > > + return kvlist->pairs[i]

Re: [dpdk-dev] [PATCH v4 5/5] devargs: parse global device syntax

2021-04-12 Thread Thomas Monjalon
10/04/2021 16:23, Xueming Li: > --- a/doc/guides/rel_notes/release_21_05.rst > +++ b/doc/guides/rel_notes/release_21_05.rst > @@ -131,6 +131,12 @@ New Features >* Added command to display Rx queue used descriptor count. > ``show port (port_id) rxq (queue_id) desc used count`` > > +* **En

  1   2   >