Re: [PATCH 12/13] ethdev: remove deprecated flow item PHY PORT

2022-09-27 Thread Thomas Monjalon
22/08/2022 07:33, Ori Kam: > > Such deprecation was commenced in DPDK 21.11. > > Since then, no parties have objected. Remove. > > > > The patch breaks ABI. > > > > Signed-off-by: Ivan Malov > > Reviewed-by: Andrew Rybchenko > > Acked-by: Ori Kam > Best, > Ori The patch is missing following

[PATCH v2 0/2] check illegal packets

2022-09-27 Thread Kevin Liu
Check whether the data packet is illegal of ice and iavf driver. v2: Change the scheme, check the data_len and update commit log. Kevin Liu (2): net/iavf: check illegal packets net/ice: check illegal packets drivers/net/iavf/iavf_rxtx.c | 9 + drivers/net/iavf/iavf_rxtx.h | 2 ++

[PATCH v2 2/2] net/ice: check illegal packets

2022-09-27 Thread Kevin Liu
If the length of data_len in mbuf is less than 17 or greater than the maximum frame size, it is illegal. These illegal packets will lead to TX/RX hang and can't recover automatically. This patch check those illegal packets and protect TX/RX from hanging. Fixes: 17c7d0f9d6a4 ("net/ice: support ba

[PATCH v2 1/2] net/iavf: check illegal packets

2022-09-27 Thread Kevin Liu
If the length of data_len in mbuf is less than 17 or greater than the maximum frame size, it is illegal. These illegal packets will lead to TX/RX hang and can't recover automatically. This patch check those illegal packets and protect TX/RX from hanging. Fixes: a2b29a7733ef ("net/avf: enable bas

[v2 0/7] FIPS asymmetric validation

2022-09-27 Thread Gowrishankar Muthukrishnan
This patch series adds support in fips_validation app to perform asymmetric validation. To start with, RSA algorithm is used in the evaluation. For the key value pairs which is multiprecision in arithmetic, openssl library is used. Changes: v2: - minor fixes in v1 - addition of digest encodin

[v2 2/7] examples/fips_validation: add interim parse writeback

2022-09-27 Thread Gowrishankar Muthukrishnan
Asym tests need a callback to write interim info in expected output. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley --- examples/fips_validation/fips_validation.c | 6 ++ examples/fips_validation/fips_validation.h | 1 + 2 files changed, 7 insertions(+) diff --git a/examp

[v2 1/7] examples/fips_validation: fix parsing test group info

2022-09-27 Thread Gowrishankar Muthukrishnan
If a test group does not have expected key, it should not crash. This patch fixes parsing test group info to continue further when a key does not exist (as in asym tests). Fixes: 58cc98801eb ("examples/fips_validation: add JSON parsing") Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian

[v2 3/7] examples/fips_validation: add function to calculate SHA hash size

2022-09-27 Thread Gowrishankar Muthukrishnan
Add function to calculate hash size for a given SHA hash algorithm. Fixes: d5c247145c2 ("examples/fips_validation: add parsing for SHA") Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley --- v2: - fixed include file --- examples/fips_validation/fips_validation.h| 1 + ...

[v2 4/7] examples/fips_validation: fix buffer size to parse JSON string

2022-09-27 Thread Gowrishankar Muthukrishnan
In asym op, while parsing test interim info, existing buffer of size 256 bytes is not sufficient, hence setting it to maximum that a test would need. Fixes: 58cc98801eb ("examples/fips_validation: add JSON parsing") Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley --- examples/

[v2 5/7] examples/fips_validation: add asymmetric validation

2022-09-27 Thread Gowrishankar Muthukrishnan
Add support for asymmetric crypto validation starting with RSA. For the generation of crypto values which is multiprecision in math, openssl library is used only for this purpose. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley -- v2: - improved handling priv key type. --- co

[v2 6/7] examples/fips_validation: encode digest with hash OID

2022-09-27 Thread Gowrishankar Muthukrishnan
FIPS RSA validation requires hash ddigest be encoded with ASN.1 value for digest info. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/main.c | 78 + 1 file changed, 78 insertions(+) diff --git a/examples/fips_validation/main.c b/examples/f

[v2 7/7] examples/fips_validation: randomize message for conformance test

2022-09-27 Thread Gowrishankar Muthukrishnan
FIPS conformance tests require randomizing message based on SP 800-106. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.h| 4 + .../fips_validation/fips_validation_rsa.c | 112 +- 2 files changed, 115 insertions(+), 1 deletion(-)

RE: [PATCH v3 1/9] net/gve: introduce GVE PMD base code

2022-09-27 Thread Guo, Junfeng
> -Original Message- > From: Stephen Hemminger > Sent: Saturday, September 24, 2022 02:58 > To: Guo, Junfeng > Cc: Zhang, Qi Z ; Wu, Jingjing > ; ferruh.yi...@xilinx.com; dev@dpdk.org; Li, > Xiaoyun ; awogbem...@google.com; Richardson, > Bruce ; Lin, Xueqin ; > Wang, Haiyue > Subject:

RE: [PATCH v3 1/9] net/gve: introduce GVE PMD base code

2022-09-27 Thread Guo, Junfeng
> -Original Message- > From: Stephen Hemminger > Sent: Saturday, September 24, 2022 02:59 > To: Guo, Junfeng > Cc: Zhang, Qi Z ; Wu, Jingjing > ; ferruh.yi...@xilinx.com; dev@dpdk.org; Li, > Xiaoyun ; awogbem...@google.com; Richardson, > Bruce ; Lin, Xueqin ; > Wang, Haiyue > Subject:

RE: [PATCH v3 2/9] net/gve: add logs and OS specific implementation

2022-09-27 Thread Guo, Junfeng
> -Original Message- > From: Stephen Hemminger > Sent: Saturday, September 24, 2022 03:01 > To: Guo, Junfeng > Cc: Zhang, Qi Z ; Wu, Jingjing > ; ferruh.yi...@xilinx.com; dev@dpdk.org; Li, > Xiaoyun ; awogbem...@google.com; Richardson, > Bruce ; Lin, Xueqin ; > Wang, Haiyue > Subject:

[v1 1/2] cryptodev: add enumeration in EC xform for FPM

2022-09-27 Thread Gowrishankar Muthukrishnan
Add enumeration in EC xform for FPM. Crypto driver would need this to xform point multiplication based on given type of EC curve. Signed-off-by: Kiran Kumar K Signed-off-by: Gowrishankar Muthukrishnan --- lib/cryptodev/rte_crypto_asym.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib

[v1 0/2] examples/fips_validation: add ECDSA tests

2022-09-27 Thread Gowrishankar Muthukrishnan
This series adds ECDSA validation in fips_validation app. Depends-on: series-24851 ("FIPS asymmetric validation") Gowrishankar Muthukrishnan (2): cryptodev: add enumeration in EC xform for FPM examples/fips_validation: add ECDSA validation doc/guides/sample_app_ug/fips_validation.rst | 1

[v1 2/2] examples/fips_validation: add ECDSA validation

2022-09-27 Thread Gowrishankar Muthukrishnan
This patch adds support in fips_validation app to validate ECDSA. Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/sample_app_ug/fips_validation.rst | 1 + examples/fips_validation/fips_validation.c| 2 + examples/fips_validation/fips_validation.h| 27 ++ .../fips_validatio

RE: [PATCH v4] vhost: support CPU copy for small packets

2022-09-27 Thread Ma, WenwuX
> -Original Message- > From: Morten Brørup > Sent: 2022年9月7日 22:47 > To: Ma, WenwuX ; maxime.coque...@redhat.com; > Xia, Chenbo ; dev@dpdk.org; Richardson, Bruce > > Cc: Pai G, Sunil ; Hu, Jiayu ; > Wang, Yinan ; He, Xingguang > ; Ding, Xuan ; Jiang, > Cheng1 ; Wang, YuanX > Subject: R

[PATCH v4 0/9] introduce GVE PMD

2022-09-27 Thread Junfeng Guo
Introduce a new PMD for Google Virtual Ethernet (GVE). This patch set requires an exception for MIT license for GVE base code. And the base code includes the following files: - gve_adminq.c - gve_adminq.h - gve_desc.h - gve_desc_dqo.h - gve_register.h It's based on GVE kernel driver v1.3.0 a

[PATCH v4 1/9] net/gve/base: introduce GVE PMD base code

2022-09-27 Thread Junfeng Guo
The following base code is based on Google Virtual Ethernet (gve) driver v1.3.0 under MIT license. - gve_adminq.c - gve_adminq.h - gve_desc.h - gve_desc_dqo.h - gve_register.h - gve.h The original code is in: https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-linux/\ tree/v1.3.0/googl

[PATCH v4 2/9] net/gve/base: add logs and OS specific implementation

2022-09-27 Thread Junfeng Guo
Add GVE PMD logs. Add some MACRO definitions and memory operations which are specific for DPDK. Signed-off-by: Haiyue Wang Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- drivers/net/gve/base/gve_adminq.h | 2 + drivers/net/gve/base/gve_desc.h | 2 + drivers/net/gve/base/gve

[PATCH v4 3/9] net/gve: add support for device initialization

2022-09-27 Thread Junfeng Guo
Support device init and the fowllowing devops: - dev_configure - dev_start - dev_stop - dev_close Signed-off-by: Haiyue Wang Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- MAINTAINERS| 6 + doc/guides/nics/features/gve.ini | 10 + doc/guides/nics/

[PATCH v4 4/9] net/gve: add support for link update

2022-09-27 Thread Junfeng Guo
Support dev_ops link_update. Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- doc/guides/nics/features/gve.ini | 2 ++ drivers/net/gve/gve_ethdev.c | 30 ++ 2 files changed, 32 insertions(+) diff --git a/doc/guides/nics/features/gve.ini b/doc/guides/nic

[PATCH v4 5/9] net/gve: add support for MTU setting

2022-09-27 Thread Junfeng Guo
Support dev_ops mtu_set. Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- doc/guides/nics/features/gve.ini | 1 + drivers/net/gve/gve_ethdev.c | 29 + 2 files changed, 30 insertions(+) diff --git a/doc/guides/nics/features/gve.ini b/doc/guides/nics/feat

[PATCH v4 6/9] net/gve: add support for queue operations

2022-09-27 Thread Junfeng Guo
Add support for queue operations: - setup rx/tx queue - release rx/tx queue - start rx/tx queues - stop rx/tx queues Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- drivers/net/gve/gve_ethdev.c | 206 + drivers/net/gve/gve_ethdev.h | 48 driver

[PATCH v4 7/9] net/gve: add support for Rx/Tx

2022-09-27 Thread Junfeng Guo
Add Rx/Tx of GQI_QPL queue format and GQI_RDA queue format. Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- doc/guides/nics/features/gve.ini | 2 + drivers/net/gve/gve_ethdev.c | 5 + drivers/net/gve/gve_ethdev.h | 16 ++ drivers/net/gve/gve_rx.c | 143 ++

[PATCH v4 8/9] net/gve: add support for dev info get and dev configure

2022-09-27 Thread Junfeng Guo
Add dev_ops dev_infos_get. Complete dev_configure with RX offloads configuration. Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- doc/guides/nics/features/gve.ini | 1 + drivers/net/gve/gve_ethdev.c | 65 +++- 2 files changed, 65 insertions(+), 1 deleti

[PATCH v4 9/9] net/gve: add support for stats

2022-09-27 Thread Junfeng Guo
Update stats add support of dev_ops stats_get/reset. Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- doc/guides/nics/features/gve.ini | 2 + drivers/net/gve/gve_ethdev.c | 71 drivers/net/gve/gve_ethdev.h | 11 + drivers/net/gve/gve_rx.c

RE: [PATCH v3] net/vhost: support asynchronous data path

2022-09-27 Thread Wang, YuanX
Hi Chenbo, > -Original Message- > From: Xia, Chenbo > Sent: Monday, September 26, 2022 2:55 PM > To: Wang, YuanX ; maxime.coque...@redhat.com; > dev@dpdk.org > Cc: Hu, Jiayu ; He, Xingguang > ; Jiang, Cheng1 ; Ma, > WenwuX > Subject: RE: [PATCH v3] net/vhost: support asynchronous data pa

[v1] crypto/cnxk: add support for fixed point multiplication

2022-09-27 Thread Gowrishankar Muthukrishnan
Add fixed point multiplication for EC curve in CNXK. Signed-off-by: Kiran Kumar K Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/cnxk/roc_ae.h | 1 + drivers/crypto/cnxk/cnxk_ae.h | 69 +++ .../crypto/cnxk/cnxk_cryptodev_capabiliti

[v1] crypto/cnxk: support exponent type private key

2022-09-27 Thread Gowrishankar Muthukrishnan
This patch adds support for RTE_RSA_KEY_TYPE_EXP in cnxk crypto driver. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/cnxk/cnxk_ae.h| 60 ++-- drivers/crypto/cnxk/cnxk_cryptodev.c | 1 + 2 files changed, 48 insertions(+), 13 deletions(-) diff --gi

RE: [PATCH] cryptodev: add trace points

2022-09-27 Thread Akhil Goyal
> diff --git a/lib/cryptodev/rte_cryptodev_trace.h > b/lib/cryptodev/rte_cryptodev_trace.h > index a3f6048e7d..84991c5b0a 100644 > --- a/lib/cryptodev/rte_cryptodev_trace.h > +++ b/lib/cryptodev/rte_cryptodev_trace.h > @@ -18,6 +18,7 @@ extern "C" { > #include > > #include "rte_cryptodev.h" > +

[PATCH] examples/pipeline: fix file close

2022-09-27 Thread Harshad Narayane
Coverity issue: 380860 Fixes: 9043f66a ("examples/pipeline: add command for code generation") Fix file close at pipeline code generation. Signed-off-by: Harshad Narayane Signed-off-by: Kamalakannan R Acked-by: Cristian Dumitrescu --- examples/pipeline/cli.c | 1 + 1 file changed, 1 insertion(

[PATCH] examples/pipeline: fix memory free

2022-09-27 Thread Harshad Narayane
Coverity issue: 380863 Coverity issue: 380866 Fixes: 6bc14d9f ("examples/pipeline: add command for shared library build") Fix memory resource free for buffer allocation failure at pipeline library build. Signed-off-by: Harshad Narayane Signed-off-by: Kamalakannan R Acked-by: Cristian Dumitrescu

Re: [PATCH 00/13] ethdev: proceed with flow subsystem rework

2022-09-27 Thread Thomas Monjalon
12/08/2022 21:18, Ivan Malov: > Series [1] requires that certain experimental flow features in DPDK > be promoted to stable. Also, reviewers request that some drivers be > adjusted to support flow action REPRESENTED_PORT. This series takes > care of that and also proceeds to remove deprecated items

[PATCH] net/softnic: fix file close

2022-09-27 Thread Harshad Narayane
Coverity issue: 380976 Fixes: e3be2495 ("net/softnic: add pipeline code generation command") Fix file close at pipeline code generation. Signed-off-by: Harshad Narayane Signed-off-by: Kamalakannan R Acked-by: Cristian Dumitrescu --- drivers/net/softnic/rte_eth_softnic_cli.c | 1 + 1 file chan

[PATCH] net/softnic: fix memory free

2022-09-27 Thread Harshad Narayane
Coverity issue: 380975 Coverity issue: 380977 Fixes: 02270033 ("net/softnic: add pipeline library build command") Fix memory resource free for buffer allocation failure at pipeline library build. Signed-off-by: Harshad Narayane Signed-off-by: Kamalakannan R Acked-by: Cristian Dumitrescu --- d

RE: [EXT] Re: [PATCH 1/3] net: add MACsec header

2022-09-27 Thread Akhil Goyal
Hi Olivier, > > +#define RTE_MACSEC_TCI_E 0x08 /**< User data is encrypted */ > > +#define RTE_MACSEC_TCI_C 0x04 /**< User data was changed (because of > encryption) */ > E bit means the user data is encrypted if set. Above defines are mask to each of the fields in tci_an. I would add a comm

RE: [PATCH 1/3] eventdev: introduce event cryptodev vector type

2022-09-27 Thread Gujjar, Abhinandan S
> -Original Message- > From: Volodymyr Fialko > Sent: Monday, September 26, 2022 4:32 PM > To: Gujjar, Abhinandan S ; dev@dpdk.org; Jerin > Jacob Kollanukkaran ; Pavan Nikhilesh Bhagavatula > ; Shijith Thotton ; > Hemant Agrawal ; Sachin Saxena > ; Jayatheerthan, Jay > > Cc: Akhil Goya

RE: facing _apply patch failure_ warning

2022-09-27 Thread Naga Harish K, S V
Hi David, Thanks for triggering test. The "_apply patch failure_" warning still shows for the patch. Is this fine? -Harish > -Original Message- > From: David Marchand > Sent: Monday, September 26, 2022 1:35 PM > To: Naga Harish K, S V > Cc: acon...@redhat.com; ahass...@iol.unh.edu; J

Re: facing _apply patch failure_ warning

2022-09-27 Thread David Marchand
Hello, Please, don't top post, I reordered your reply to keep the context in a logical order. On Tue, Sep 27, 2022 at 11:06 AM Naga Harish K, S V wrote: > > From: David Marchand > > On Mon, Sep 26, 2022 at 9:54 AM Naga Harish K, S V > > > I am facing _apply patch failure_ warning for one of m

RE: [PATCH 1/3] eventdev: introduce event cryptodev vector type

2022-09-27 Thread Volodymyr Fialko
> -Original Message- > From: Gujjar, Abhinandan S > Sent: Tuesday, September 27, 2022 11:05 AM > To: Volodymyr Fialko ; dev@dpdk.org; Jerin Jacob > Kollanukkaran > ; Pavan Nikhilesh Bhagavatula ; > Shijith Thotton > ; Hemant Agrawal ; Sachin Saxena > ; Jayatheerthan, Jay > Cc: Akhil

RE: [PATCH 1/3] eventdev: introduce event cryptodev vector type

2022-09-27 Thread Gujjar, Abhinandan S
> -Original Message- > From: Volodymyr Fialko > Sent: Tuesday, September 27, 2022 2:55 PM > To: Gujjar, Abhinandan S ; dev@dpdk.org; Jerin > Jacob Kollanukkaran ; Pavan Nikhilesh Bhagavatula > ; Shijith Thotton ; > Hemant Agrawal ; Sachin Saxena > ; Jayatheerthan, Jay > > Cc: Akhil Goy

Re: [EXT] [PATCH v7 6/7] bbdev: add queue related warning and status information

2022-09-27 Thread Ferruh Yigit
On 9/24/2022 5:34 PM, Chautru, Nicolas wrote: Hi Ferruh, Ray, Akhil, -Original Message- From: Ferruh Yigit Sent: Friday, September 23, 2022 4:28 PM To: Akhil Goyal ; Nicolas Chautru ; dev@dpdk.org; tho...@monjalon.net; hemant.agra...@nxp.com; Ray Kinsella Cc: maxime.coque...@redhat.c

[PATCH v3] net/iavf: fix TSO offload for tunnel case

2022-09-27 Thread Zhichao Zeng
This patch is to fix the tunnel TSO not enabling issue, simplify the logic of calculating 'Tx Buffer Size' of data descriptor with IPSec, and fix handling that the mbuf size exceeds the TX descriptor hardware limit(1B-16KB) which causes malicious behavior to the NIC. Fixes: 1e728b01120c ("net/iavf

Re: [EXT] [PATCH v2 2/5] crypto/uadk: introduce uadk crypto driver

2022-09-27 Thread Zhangfei Gao
On 2022/9/26 下午4:36, Akhil Goyal wrote: Introduce a new crypto PMD for hardware accelerators based on UADK [1]. UADK is a framework for user applications to access hardware accelerators. UADK relies on IOMMU SVA (Shared Virtual Address) feature, which share the same page table between IOMMU a

[PATCH v5 0/3] add uncore api to be called through l3fwd-power

2022-09-27 Thread Tadhg Kearney
This is targeting 22.11 and aims to add an API to DPDK power library to allow uncore frequency adjustment. This will be called through the l3fwd-power app and gives the ability to set the minimum and maximum uncore frequency to both min, max or specific frequency index. Signed-off-by: tadhgkearn

[PATCH v5 1/3] power: add uncore frequency control API to the power library

2022-09-27 Thread Tadhg Kearney
Add API to allow uncore frequency adjustment. This is done through manipulating related uncore frequency control sysfs entries to adjust the minimum and maximum uncore frequency values. Nine API's are being added that are all public and experimental. Signed-off-by: Tadhg Kearney --- doc/guides/p

[PATCH v5 2/3] l3fwd-power: add option to call uncore API

2022-09-27 Thread Tadhg Kearney
Add option for setting uncore frequency min/max/index, through uncore API. This will be set for each package and die on the SKU. On exit, uncore min and max frequency will be reverted back to previous frequencies. Signed-off-by: Tadhg Kearney --- .../sample_app_ug/l3_forward_power_man.rst|

[PATCH v5 3/3] test/power: add unit tests for uncore API

2022-09-27 Thread Tadhg Kearney
Add basic unit tests covering all nine uncore API's. Signed-off-by: Tadhg Kearney --- app/test/meson.build | 2 + app/test/test_power_uncore.c | 301 +++ 2 files changed, 303 insertions(+) create mode 100644 app/test/test_power_uncore.c diff --git a/ap

Re: [PATCH v5 06/10] dts: add ssh connection module

2022-09-27 Thread Stanislaw Kardach
On Mon, Sep 26, 2022 at 02:17:09PM +, Juraj Linkeš wrote: > The module uses the pexpect python library and implements connection to > a node and two ways to interact with the node: > 1. Send a string with specified prompt which will be matched after >the string has been sent to the node. >

[PATCH v3] net/virtio: fix crash when dev is configured twice

2022-09-27 Thread Alexander Chernavin
When first attempt to configure a device with RX interrupt enabled fails for some reason (e.g. because "Multiple intr vector not supported"), second attempt to configure the device with RX interrupt disabled and feature set unchanged will succeed but will leave virtio queues not allocated. Accessin

Re: [PATCH v6 1/2] eventdev/eth_tx: add queue start stop API

2022-09-27 Thread Jerin Jacob
On Mon, Sep 26, 2022 at 7:34 AM Naga Harish K S V wrote: > > Add support to start or stop a particular queue > that is associated with the adapter. > > Start function enables the Tx adapter to start enqueueing > packets to the Tx queue. > > Stop function stops the Tx adapter from enqueueing any >

RE: [PATCH v6 1/2] eventdev/eth_tx: add queue start stop API

2022-09-27 Thread Jayatheerthan, Jay
> -Original Message- > From: Jerin Jacob > Sent: Tuesday, September 27, 2022 3:45 PM > To: Naga Harish K, S V > Cc: Jayatheerthan, Jay ; dev@dpdk.org > Subject: Re: [PATCH v6 1/2] eventdev/eth_tx: add queue start stop API > > On Mon, Sep 26, 2022 at 7:34 AM Naga Harish K S V > wrote: >

Re: [PATCH] ethdev: fix push new event

2022-09-27 Thread Thomas Monjalon
11/06/2022 10:59, lihuisong (C): > 在 2022/6/7 14:44, Thomas Monjalon 写道: > > 07/06/2022 03:23, lihuisong (C): > >> 在 2022/6/3 15:42, Thomas Monjalon 写道: > >>> 02/06/2022 13:24, lihuisong (C): > 在 2022/5/30 19:10, Ferruh Yigit 写道: > > On 5/30/2022 9:28 AM, Thomas Monjalon wrote: > >> [C

RE: [PATCH v4] vhost: support CPU copy for small packets

2022-09-27 Thread Morten Brørup
> From: Ma, WenwuX [mailto:wenwux...@intel.com] > Sent: Tuesday, 27 September 2022 09.32 > > > From: Morten Brørup > > Sent: 2022年9月7日 22:47 > > > > > From: Wenwu Ma [mailto:wenwux...@intel.com] > > > Sent: Monday, 29 August 2022 02.57 > > > > > > Offloading small packets to DMA degrades throughp

Re: [PATCH V2 3/6] ethdev: fix push new event

2022-09-27 Thread Thomas Monjalon
15/09/2022 14:45, Huisong Li: > The 'state' in struct rte_eth_dev may be used to update some information > when app receive these events. For example, when app receives a new event, > app may get the socket id of this port by calling rte_eth_dev_socket_id to > setup the attached port. The 'state' i

Re: [PATCH v2] drivers: remove support to limit XAQ in cnxk event driver

2022-09-27 Thread Jerin Jacob
On Tue, Sep 20, 2022 at 12:33 PM Shijith Thotton wrote: > > Removed support to limit XAQ from devargs. If XAQ is limited, new add > works could run out of XAQ entries and disable the queue. > > Signed-off-by: Shijith Thotton Updated the git commit as follows and applied to dpdk-next-net-eventdev

Re: [PATCH v2 3/3] event/cnxk: disable timer resolution estimation

2022-09-27 Thread Jerin Jacob
On Wed, Sep 21, 2022 at 11:48 AM wrote: > > From: Pavan Nikhilesh > > Disable timer resolution estimation, read TIM LF clock registers > to get the current running clock counter as estimating causes > time drift. > > Signed-off-by: Pavan Nikhilesh Applied to dpdk-next-net-eventdev/for-main. Th

RE: [PATCH v4 2/6] crypto/scheduler: use unified session

2022-09-27 Thread Ji, Kai
Have the sym sessions changes been tested with the dpdk-test-crypto-perf tool ? root@silpixa00401033:build# ./app/dpdk-test-crypto-perf -l 3,4 --socket-mem 4096,0 -a :33:01.0,qat_sym_cipher_crc_enable=1 --vdev crypto_aesni_mb1 --vdev "crypto_scheduler,worker=crypto_aesni_mb1,worker=:33

Re: [PATCH v3] event/dlb2: fix max cq_depth/enq_depth cli override

2022-09-27 Thread Jerin Jacob
On Wed, Sep 21, 2022 at 9:59 PM Abdullah Sevincer wrote: > > This patch addresses an issue of enqueuing more than > max_enq_depth and not able to dequeuing events equal > to max_cq_depth in a single call of rte_event_enqueue_burst > and rte_event_dequeue_burst. > > Apply fix for restricting enqueu

[PATCH] vhost: remove deprecated helpers

2022-09-27 Thread David Marchand
Those helpers have been marked as deprecated for a long time and have documented equivalent helpers. Signed-off-by: David Marchand --- doc/guides/rel_notes/release_22_11.rst | 3 ++ lib/vhost/rte_vhost.h | 55 -- lib/vhost/version.map |

RE: [EXT] [dpdk-dev v2] app/test: random test vectors for Asymc RSA

2022-09-27 Thread Gowrishankar Muthukrishnan
> -Original Message- > From: Przemyslaw Zegan > Sent: Wednesday, August 17, 2022 7:45 PM > To: dev@dpdk.org > Cc: Akhil Goyal ; roy.fan.zh...@intel.com; > Przemyslaw Zegan > Subject: [EXT] [dpdk-dev v2] app/test: random test vectors for Asymc RSA > > External Email > > -

[PATCH] malloc: remove unused function to set limit

2022-09-27 Thread David Marchand
This function was never implemented and has been deprecated for a long time. We can remove it. Signed-off-by: David Marchand --- doc/guides/rel_notes/release_22_11.rst | 2 ++ lib/eal/common/rte_malloc.c| 10 -- lib/eal/include/rte_malloc.h | 17 -

Re: [PATCH] vhost: remove deprecated helpers

2022-09-27 Thread Maxime Coquelin
On 9/27/22 13:36, David Marchand wrote: Those helpers have been marked as deprecated for a long time and have documented equivalent helpers. Signed-off-by: David Marchand --- doc/guides/rel_notes/release_22_11.rst | 3 ++ lib/vhost/rte_vhost.h | 55 --

RE: [PATCH v5 0/7] ethdev: separate metering and marking from policing

2022-09-27 Thread Dumitrescu, Cristian
> -Original Message- > From: Alexander Kozyrev > Sent: Monday, September 26, 2022 3:58 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; > jerinjac...@gmail.com; or...@nvidia.com; tho...@monjalon.net; > ivan.ma...@oktetlabs.ru; andrew.rybche...@oktetlabs.ru; > ferruh.yi...@xilinx.com;

RE: [PATCH v5 0/7] ethdev: separate metering and marking from policing

2022-09-27 Thread Dumitrescu, Cristian
> -Original Message- > From: Alexander Kozyrev > Sent: Monday, September 26, 2022 7:48 PM > To: Dumitrescu, Cristian ; dev@dpdk.org > Cc: jerinjac...@gmail.com; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; > ivan.ma...@oktetlabs.ru; andrew.rybche...@oktetlabs.ru; > ferruh.yi...

Re: [PATCH v6 03/14] baseband/acc: rename directory from acc100 to acc

2022-09-27 Thread Maxime Coquelin
On 9/24/22 02:50, Nicolas Chautru wrote: From: Nic Chautru Using a common directory for the ACC PMDs Signed-off-by: Nic Chautru --- MAINTAINERS | 2 +- app/test-bbdev/meson.build| 4 ++-- app/test-bbdev/test_bbdev_pe

RE: [PATCH 2/7] common/mlx5: add hairpin SQ buffer type capabilities

2022-09-27 Thread Slava Ovsiienko
> -Original Message- > From: Dariusz Sosnowski > Sent: Monday, September 19, 2022 19:37 > To: Matan Azrad ; Slava Ovsiienko > Cc: dev@dpdk.org > Subject: [PATCH 2/7] common/mlx5: add hairpin SQ buffer type capabilities > > This patch extends HCA_CAP and SQ Context structs available in PR

Re: [PATCH v6 06/14] baseband/acc: add info get function for ACC200

2022-09-27 Thread Maxime Coquelin
On 9/24/22 02:50, Nicolas Chautru wrote: From: Nic Chautru Add support for info_get to allow to query the device. Null capability exposed. Signed-off-by: Nic Chautru --- drivers/baseband/acc/acc200_pmd.h | 1 + drivers/baseband/acc/rte_acc200_pmd.c | 239 ++

RE: [PATCH 3/7] common/mlx5: add hairpin RQ buffer type capabilities

2022-09-27 Thread Slava Ovsiienko
> -Original Message- > From: Dariusz Sosnowski > Sent: Monday, September 19, 2022 19:37 > To: Matan Azrad ; Slava Ovsiienko > Cc: dev@dpdk.org > Subject: [PATCH 3/7] common/mlx5: add hairpin RQ buffer type capabilities > > This patch adds new HCA capability related to hairpin RQs. This n

RE: [PATCH 5/7] net/mlx5: allow hairpin Rx queue in locked memory

2022-09-27 Thread Slava Ovsiienko
> -Original Message- > From: Dariusz Sosnowski > Sent: Monday, September 19, 2022 19:37 > To: Matan Azrad ; Slava Ovsiienko > Cc: dev@dpdk.org > Subject: [PATCH 5/7] net/mlx5: allow hairpin Rx queue in locked memory > > This patch adds a capability to place hairpin Rx queue in locked dev

RE: [PATCH 4/7] net/mlx5: allow hairpin Tx queue in RTE memory

2022-09-27 Thread Slava Ovsiienko
> -Original Message- > From: Dariusz Sosnowski > Sent: Monday, September 19, 2022 19:37 > To: Matan Azrad ; Slava Ovsiienko > Cc: dev@dpdk.org > Subject: [PATCH 4/7] net/mlx5: allow hairpin Tx queue in RTE memory > > This patch adds a capability to place hairpin Tx queue in host memory >

Re: [PATCH v6 07/14] baseband/acc: add queue configuration for ACC200

2022-09-27 Thread Maxime Coquelin
On 9/24/22 02:50, Nicolas Chautru wrote: From: Nic Chautru Adding function to create and configure queues for the device. Signed-off-by: Nic Chautru --- drivers/baseband/acc/acc_common.h | 1 + drivers/baseband/acc/rte_acc200_pmd.c | 391 +- 2 files change

Re: [PATCH v4 08/14] baseband/acc: add LDPC processing functions

2022-09-27 Thread Maxime Coquelin
On 9/23/22 23:55, Chautru, Nicolas wrote: Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Friday, September 23, 2022 1:30 AM To: Chautru, Nicolas ; dev@dpdk.org; tho...@monjalon.net Cc: t...@redhat.com; m...@ashroe.eu; Richardson, Bruce ; hemant.agra...@nxp.com; david.marc

Re: [PATCH v6 08/14] baseband/acc: add LDPC processing functions

2022-09-27 Thread Maxime Coquelin
On 9/24/22 02:50, Nicolas Chautru wrote: From: Nic Chautru Adding LDPC encode and decode processing functions. Signed-off-by: Nic Chautru --- drivers/baseband/acc/acc_common.h | 84 ++ drivers/baseband/acc/rte_acc200_pmd.c | 1384 - 2 files changed, 1464 i

Re: [PATCH 1/3] eventdev: introduce event cryptodev vector type

2022-09-27 Thread Jerin Jacob
> > > > > > > > > Right now we are targeting crypto_cn10k PMD and ipsec-secgw event > > > > mode to support vectorization. > > > Is there a way to test this? When can be dataplane changes expected? > > > > > If the spec looks okay, support in s/w crypto adapter and other h/w PMDs can > > be added b

Re: [PATCH v4 09/14] baseband/acc: add LTE processing functions

2022-09-27 Thread Maxime Coquelin
On 9/24/22 00:21, Chautru, Nicolas wrote: Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Friday, September 23, 2022 2:00 AM To: Chautru, Nicolas ; dev@dpdk.org; tho...@monjalon.net Cc: t...@redhat.com; m...@ashroe.eu; Richardson, Bruce ; hemant.agra...@nxp.com; david.marc

Re: [PATCH v2 1/3] eventdev: add element offset to event vector

2022-09-27 Thread Jerin Jacob
On Thu, Sep 22, 2022 at 11:10 AM Mattias Rönnblom wrote: > > On 2022-09-21 18:43, pbhagavat...@marvell.com wrote: > > From: Pavan Nikhilesh > > > > Add `rte_event_vector:elem_offset:12` bit field event vector > > structure the bits are taken from `rte_event_vector::rsvd:15`. > > The element offse

Re: [PATCH v6 09/14] baseband/acc: add LTE processing functions

2022-09-27 Thread Maxime Coquelin
On 9/24/22 02:50, Nicolas Chautru wrote: From: Nic Chautru Add functions and capability for 4G FEC Signed-off-by: Nic Chautru --- drivers/baseband/acc/rte_acc200_pmd.c | 854 +- 1 file changed, 850 insertions(+), 4 deletions(-) diff --git a/drivers/baseband/acc/

Re: [PATCH v6 10/14] baseband/acc: add support for FFT operations

2022-09-27 Thread Maxime Coquelin
On 9/24/22 02:50, Nicolas Chautru wrote: From: Nic Chautru Add functions and capability for FFT processing Signed-off-by: Nic Chautru --- drivers/baseband/acc/rte_acc200_pmd.c | 242 +- 1 file changed, 240 insertions(+), 2 deletions(-) diff --git a/drivers/baseb

Re: [PATCH v6 11/14] baseband/acc: support interrupt

2022-09-27 Thread Maxime Coquelin
On 9/24/22 02:50, Nicolas Chautru wrote: From: Nic Chautru Adding support for capability and functions for MSI/MSI-X interrupt and underlying information ring. Signed-off-by: Nic Chautru --- drivers/baseband/acc/rte_acc200_pmd.c | 303 +- 1 file changed, 301 inse

RE: [PATCH] cryptodev: add trace points

2022-09-27 Thread Amit Prakash Shukla
Hi Akhil, Thanks for your feedback. I will do the suggested changes in next version of the patch. > -Original Message- > From: Akhil Goyal > Sent: Tuesday, September 27, 2022 1:37 PM > To: Amit Prakash Shukla ; Fan Zhang > ; Ray Kinsella > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ;

Re: [PATCH v4 13/14] baseband/acc: add PF configure companion function

2022-09-27 Thread Maxime Coquelin
On 9/24/22 02:20, Chautru, Nicolas wrote: Hi Maxime, Thanks will send an updated serie now. Much appreciated. -Original Message- From: Maxime Coquelin Sent: Friday, September 23, 2022 2:26 AM To: Chautru, Nicolas ; dev@dpdk.org; tho...@monjalon.net Cc: t...@redhat.com; m...@ashroe.e

Re: [PATCH v2 1/1] ethdev: support congestion management

2022-09-27 Thread Thomas Monjalon
19/09/2022 14:15, sk...@marvell.com: > From: Jerin Jacob > > NIC HW controllers often come with congestion management support on > various HW objects such as Rx queue depth or mempool queue depth. > > Also, it can support various modes of operation such as RED > (Random early discard), WRED etc

[PATCH v4] event/dlb2: fix max cq_depth/enq_depth cli override

2022-09-27 Thread Abdullah Sevincer
This patch addresses an issue of enqueuing more than max_enq_depth and not able to dequeuing events equal to max_cq_depth in a single call of rte_event_enqueue_burst and rte_event_dequeue_burst. Apply fix for restricting enqueue of events to max_enq_depth so that in a single rte_event_enqueue_burs

Re: [PATCH v2 1/1] ethdev: support congestion management

2022-09-27 Thread Bruce Richardson
On Tue, Sep 27, 2022 at 04:36:18PM +0200, Thomas Monjalon wrote: > 19/09/2022 14:15, sk...@marvell.com: > > From: Jerin Jacob > > > > NIC HW controllers often come with congestion management support on > > various HW objects such as Rx queue depth or mempool queue depth. > > > > Also, it can sup

[PATCH] event/cnxk: fix missing xstats ops registration

2022-09-27 Thread pbhagavatula
From: Pavan Nikhilesh Fix missing xstats ops registration when initializing event device. Fixes: b5a52c9d97e2 ("event/cnxk: add event port and queue xstats") Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 4 drivers/event/cnxk/cn9k_eventdev.c | 4 2 files

[dpdk-dev] [PATCH 1/2] net/bnxt: remove unnecessary check

2022-09-27 Thread Kalesh A P
From: Kalesh AP We are not invoking rte_eth_switch_domain_free currently owing to an unnecessary check. This patch fixes that. Fixes: e2895305a5b5 ("net/bnxt: fix resource cleanup") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde Reviewed-by: Somnath Kotur --- driver

[dpdk-dev] [PATCH 2/2] net/bnxt: fix freeing of representor info memory

2022-09-27 Thread Kalesh A P
From: Kalesh AP Driver allocates "bp->rep_info" inside bnxt_init_rep_info() which is invoked from bnxt_rep_port_probe(). But the memory is freed inside bnxt_uninit_resources(), which is wrong. As a result, after error recovery bp->rep_info will be NULL. The memory should have freed inside bnxt_dr

Re: [PATCH 12/13] ethdev: remove deprecated flow item PHY PORT

2022-09-27 Thread Ajit Khaparde
On Tue, Sep 27, 2022 at 12:08 AM Thomas Monjalon wrote: > > 22/08/2022 07:33, Ori Kam: > > > Such deprecation was commenced in DPDK 21.11. > > > Since then, no parties have objected. Remove. > > > > > > The patch breaks ABI. > > > > > > Signed-off-by: Ivan Malov > > > Reviewed-by: Andrew Rybchenk

RE: [EXT] Re: [PATCH v5 1/3] ethdev: add IPsec SA expiry event subtypes

2022-09-27 Thread Akhil Goyal
> 24/09/2022 15:57, Akhil Goyal: > > From: Vamsi Attunuru > > > > Patch adds new event subtypes for notifying expiry > > events upon reaching IPsec SA soft packet expiry and > > hard packet/byte expiry limits. > > > > Signed-off-by: Vamsi Attunuru > > Signed-off-by: Akhil Goyal > > --- > > --- a

RE: [PATCH] security: remove get_userdata function pointer

2022-09-27 Thread Akhil Goyal
> Subject: [PATCH] security: remove get_userdata function pointer > > Removes get_userdata function pointer as it is being unused > and make fast accessing method that uses dynamic field to get > userdata as default for optimizing security path. > > Signed-off-by: Srujana Challa Applied to dpdk-

RE: [PATCH 0/1] Add security perf application

2022-09-27 Thread Akhil Goyal
Hi Anoob, > Hi Akhil, > > Do you have any further comments? > > > > Subject: [PATCH 0/1] Add security perf application > > > > > > > > Add performance application to test security session create & > > > > destroy rates supported by the security enabled cryptodev PMD. The > > > > application would

RE: [PATCH v4 2/6] crypto/scheduler: use unified session

2022-09-27 Thread Akhil Goyal
> Have the sym sessions changes been tested with the dpdk-test-crypto-perf tool > ? I have not tested for scheduler pmd. Can you root cause the issue and send a fix? Fan may have tested it. > > root@silpixa00401033:build# ./app/dpdk-test-crypto-perf -l 3,4 --socket-mem > 4096,0 -a :33:01.

RE: [EXT] [PATCH v7 6/7] bbdev: add queue related warning and status information

2022-09-27 Thread Chautru, Nicolas
Hi Ferruh, Thanks for your comment. To be totally honest I don't yet see how your suggestion would be better, but I quite possibly miss something. I did not reply in line with your comments so that to try to be clearer and avoid spreading the argument to much. Ray and Bruce feel free to chime

RE: [PATCH v2] net/mlx5: use just sufficient barrier for Arm platforms

2022-09-27 Thread Honnappa Nagarahalli
> > Hi, Honnappa Hi Slava, thanks for the feedback. > > We discussed the barrier here: > http://patches.dpdk.org/project/dpdk/patch/20210606164948.35997-1- > honnappa.nagaraha...@arm.com/ Yes, I have changed the patch according to the discussion. i.e. barrier is needed, but different (inner s

RE: [PATCH v2] net/mlx5: use just sufficient barrier for Arm platforms

2022-09-27 Thread Honnappa Nagarahalli
> > Hi, Honnappa > > We discussed the barrier here: > http://patches.dpdk.org/project/dpdk/patch/20210606164948.35997-1- > honnappa.nagaraha...@arm.com/ > > (BTW, it is good practice to keep the reference to previous patch versions > below Commit Message of the next ones). Apologies, I did not

[Bug 1085] [dpdk-22.11]ieee1588: ninja build failed with 'Dc_args=-DRTE_LIBRTE_IEEE1588'

2022-09-27 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1085 Bug ID: 1085 Summary: [dpdk-22.11]ieee1588: ninja build failed with 'Dc_args=-DRTE_LIBRTE_IEEE1588' Product: DPDK Version: unspecified Hardware: All OS: All

  1   2   >