[GitHub] drill issue #764: DRILL-5301: Server metadata API

2017-03-01 Thread sudheeshkatkam
Github user sudheeshkatkam commented on the issue: https://github.com/apache/drill/pull/764 +1 Is this PR inclusive of comments in #613 (for DRILL-4994, DRILL-4730)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-03-01 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r103636512 --- Diff: protocol/src/main/java/org/apache/drill/exec/proto/beans/QueryContextInformation.java --- @@ -51,6 +51,7 @@ public static QueryContextInformation ge

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-03-01 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r103636828 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/ContextInformation.java --- @@ -29,13 +29,15 @@ private final long queryStartTime;

[GitHub] drill issue #729: Drill 1328: Support table statistics for Parquet

2017-03-01 Thread gparai
Github user gparai commented on the issue: https://github.com/apache/drill/pull/729 I have addressed the second set of comments. @amansinha100 @paul-rogers could you please review and/or approve? Thanks! --- If your project is set up for it, you can reply to this email and have your

[jira] [Created] (DRILL-5307) Drill sometimes stops to recognize dfs directories

2017-03-01 Thread mehran (JIRA)
mehran created DRILL-5307: - Summary: Drill sometimes stops to recognize dfs directories Key: DRILL-5307 URL: https://issues.apache.org/jira/browse/DRILL-5307 Project: Apache Drill Issue Type: Bug

[GitHub] drill pull request #520: DRILL-3510: Add ANSI_QUOTES option so that Drill's ...

2017-03-01 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/520#discussion_r99830247 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java --- @@ -204,10 +204,11 @@ public void validate(final OptionVa

[GitHub] drill pull request #520: DRILL-3510: Add ANSI_QUOTES option so that Drill's ...

2017-03-01 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/520#discussion_r103672254 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java --- @@ -231,11 +274,16 @@ public boolean storesMixedCaseQuotedId

[GitHub] drill pull request #520: DRILL-3510: Add ANSI_QUOTES option so that Drill's ...

2017-03-01 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/520#discussion_r103463608 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -695,6 +698,33 @@ public void runQuery(QueryType type, List plan

[GitHub] drill pull request #520: DRILL-3510: Add ANSI_QUOTES option so that Drill's ...

2017-03-01 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/520#discussion_r99824747 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java --- @@ -59,9 +62,11 @@ public static final String USER = "user";

[GitHub] drill pull request #520: DRILL-3510: Add ANSI_QUOTES option so that Drill's ...

2017-03-01 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/520#discussion_r9981 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java --- @@ -204,10 +204,11 @@ public void validate(final OptionVa

[GitHub] drill pull request #520: DRILL-3510: Add ANSI_QUOTES option so that Drill's ...

2017-03-01 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/520#discussion_r99823941 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java --- @@ -161,6 +161,19 @@ public SqlNode parse(String sql) {

[GitHub] drill issue #613: DRILL-4730: Update JDBC DatabaseMetaData implementation to...

2017-03-01 Thread laurentgo
Github user laurentgo commented on the issue: https://github.com/apache/drill/pull/613 yes, pull requests have been kept in sync. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] drill issue #764: DRILL-5301: Server metadata API

2017-03-01 Thread laurentgo
Github user laurentgo commented on the issue: https://github.com/apache/drill/pull/764 yes, pull requests have been kept in sync --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

Re: [Drill 1.9.0] : [CONNECTION ERROR] :- (user client) closed unexpectedly. Drillbit down?

2017-03-01 Thread Anup Tiwari
Hi, Can someone look into it? As we are now getting this more frequently in Adhoc queries as well. And for automation jobs, we are moving to Hive as in drill we are getting this more frequently. Regards, *Anup Tiwari* On Sat, Dec 31, 2016 at 12:11 PM, Anup Tiwari wrote: > Hi, > > We are gettin

Re: Time for 1.10 release

2017-03-01 Thread Laurent Goujon
The following jiras have all been reviewed and are ready to commit: * DRILL-4994: Add back JDBC prepared statement for older servers * DRILL-4730: Update JDBC DatabaseMetaData implementation to use new Metadata APIs * DRILL-5301: Server metadata API * DRILL-5167: Send escape character for metadata

Re: Time for 1.10 release

2017-03-01 Thread Jinfeng Ni
Hi Laurent, Thanks for the update. For the C++ client commits (DRILL-5301, DRILL-5221), did you guys run some sanity check to see if there is any regression? I know Parth used to build/test with the new C++ change. Since he is not available this time, just wanna to check if you have done similar

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-03-01 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r103796907 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -390,4 +391,15 @@ String DYNAMIC_UDF_SUPPORT_ENABLED

[jira] [Created] (DRILL-5308) Asking an sv2 for its buffer clears the sv2

2017-03-01 Thread Paul Rogers (JIRA)
Paul Rogers created DRILL-5308: -- Summary: Asking an sv2 for its buffer clears the sv2 Key: DRILL-5308 URL: https://issues.apache.org/jira/browse/DRILL-5308 Project: Apache Drill Issue Type: Bug

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-03-01 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r103806768 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/ContextInformation.java --- @@ -29,13 +29,15 @@ private final long queryStartTim

[GitHub] drill issue #764: DRILL-5301: Server metadata API

2017-03-01 Thread jinfengni
Github user jinfengni commented on the issue: https://github.com/apache/drill/pull/764 Which JIRA should the last commit (Refactor DrillCursor) belong to, DRILL-4994, 4730, OR 5301? --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: Time for 1.10 release

2017-03-01 Thread Jinfeng Ni
I applied Laurent's PR on top of latest Apache master branch, and hit build failure: " This is likely due to you adding new dependencies to a java-exec and not updating the excludes in this module. This is important as it minimizes the size of the dependency of Drill application users. ...drill/ex

[GitHub] drill issue #764: DRILL-5301: Server metadata API

2017-03-01 Thread laurentgo
Github user laurentgo commented on the issue: https://github.com/apache/drill/pull/764 The cursor change belongs to DRILL-4994 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

Re: Time for 1.10 release

2017-03-01 Thread Laurent Goujon
The C++ patches have been built under windows/Linux/macos, and sanity checks have been done for all of them. For the escape character fix and the cancel fix, those have been tested in production like environment for weeks. Laurent On Mar 1, 2017 13:10, "Jinfeng Ni" wrote: Hi Laurent, Thanks fo

Re: Time for 1.10 release

2017-03-01 Thread Jinfeng Ni
Hi Laurent, Thanks for the update. I'm putting the patches in a merge branch, and will merge to master once I complete the regression run. On Wed, Mar 1, 2017 at 6:18 PM, Laurent Goujon wrote: > The C++ patches have been built under windows/Linux/macos, and sanity > checks have been done for

[GitHub] drill issue #701: DRILL-4963: Fix issues with dynamically loaded overloaded ...

2017-03-01 Thread jinfengni
Github user jinfengni commented on the issue: https://github.com/apache/drill/pull/701 +1 I have one naive question. Before we dive into MVCC, or try to improve the current ZK-based approach, have we consider adding a command "refresh function registry", so that users enforce

[GitHub] drill issue #745: DRILL-5252: Fix a condition that always returns true

2017-03-01 Thread jinfengni
Github user jinfengni commented on the issue: https://github.com/apache/drill/pull/745 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur