[GitHub] drill pull request #258: DRILL-4091: Support for additional gis operations i...

Github user cgivre commented on a diff in the pull request: https://github.com/apache/drill/pull/258#discussion_r148172580 --- Diff: contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STUnionAggregate.java --- @@ -0,0 +1,114 @@ +/** + * Licensed to the

[GitHub] drill pull request #258: DRILL-4091: Support for additional gis operations i...

Github user cgivre commented on a diff in the pull request: https://github.com/apache/drill/pull/258#discussion_r148117858 --- Diff: contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STContains.java --- @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #258: DRILL-4091: Support for additional gis operations i...

Github user cgivre commented on a diff in the pull request: https://github.com/apache/drill/pull/258#discussion_r148114646 --- Diff: contrib/gis/src/main/java/com/esri/core/geometry/VertexGeomAccessor.java --- @@ -0,0 +1,25 @@ +/** --- End diff -- Please put the

[GitHub] drill pull request #258: DRILL-4091: Support for additional gis operations i...

Github user cgivre commented on a diff in the pull request: https://github.com/apache/drill/pull/258#discussion_r148172786 --- Diff: contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STUnionAggregate.java --- @@ -0,0 +1,114 @@ +/** + * Licensed to the

[GitHub] drill pull request #258: DRILL-4091: Support for additional gis operations i...

Github user cgivre commented on a diff in the pull request: https://github.com/apache/drill/pull/258#discussion_r148115797 --- Diff: contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STBuffer.java --- @@ -0,0 +1,65 @@ +/** + * Licensed to the Apache

Re: Drill SASL Forward Compatibility

- if using Kerberos, things are a bit different: even if a MITM intercepts the token, only the server can decode it properly and set up encryption so that only client can use it (a proxy server would not be able to decode the traffic). So what you need to ensure is that you actually use Kerberos

[GitHub] drill issue #978: DRILL-5842: Refactor and simplify the fragment, operator c...

Github user sohami commented on the issue: https://github.com/apache/drill/pull/978 Looking into the PR and based on description it says below: _A result of these changes is that OperatorContext is now a one-stop-shop for services needed by operators. It now provides:_

Re: Drill SASL Forward Compatibility

Regarding DRILL-5582 patch which broke compatibility with 1.9 version (which is less than a year old): I'm still not clear what we are trying to prevent here: stealing user credentials and/or data? connecting to a rogue server which could return corrupted data to the user? The patch gives a false

[GitHub] drill pull request #978: DRILL-5842: Refactor and simplify the fragment, ope...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/978#discussion_r148150382 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/BaseOperatorContext.java --- @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #978: DRILL-5842: Refactor and simplify the fragment, ope...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/978#discussion_r148146597 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/OperatorContextImpl.java --- @@ -17,33 +17,23 @@ */ package

[GitHub] drill pull request #978: DRILL-5842: Refactor and simplify the fragment, ope...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/978#discussion_r148153093 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/OperatorContextImpl.java --- @@ -98,37 +70,25 @@ public boolean isClosed() {

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r148157850 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/BatchUtils.java --- @@ -0,0 +1,280 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r148157170 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/BatchUtils.java --- @@ -0,0 +1,280 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r148157140 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/BatchUtils.java --- @@ -0,0 +1,280 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r148144235 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/BaseDirTestWatcher.java --- @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software

Re: Drill SASL Forward Compatibility

Hi Laurent, We are preventing 2 cases here: * False positive for successful authentication. Even though MITM attack can happen after successful authentication, but client and server involved here has ensure successful authentication handshake has taken place. With the security flaw there

Re: gitbox?

I’d vote +1 for moving to gitbox. — C > On Oct 31, 2017, at 13:54, Parth Chandra wrote: > > Bumping this thread up. > > Vlad brought this up in the hangout today and it sounds like we would like > to move to Gitbox. Thanks Vlad for the patient explanations! > > Committers,

Re: gitbox?

Gitbox allows committers to streamline the review and merge process. It provides a single button in github to merge pull requests to the Apache Drill mirror on github. This is then synchronized seamlessly with the Apache master. The process would still require a committer to 1) review code, 2)

Re: [HANGOUT] Topics for 10/31/2017

Meeting minutes 31 October 2017: Attendees: Aman, Arina, Boaz, Gautam, Karthik, Rob, Padma, Parth, Paul, Prasad, Pritesh, Sorabh, Tim, Vlad, Vova This is the draft of the meeting notes I remember: Gitbox: * Provide write access to github repo * Provide fine grain controlled on

[GitHub] drill pull request #987: DRILL-5863: Sortable table incorrectly sorts fragme...

Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/987#discussion_r148126237 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java --- @@ -76,12 +77,14 @@ public String getId() {

[GitHub] drill pull request #987: DRILL-5863: Sortable table incorrectly sorts fragme...

Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/987#discussion_r148123715 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java --- @@ -76,12 +77,14 @@ public String getId() {

[jira] [Created] (DRILL-5918) Allow manual configuration when using Runtime.getRuntime().availableProcessors()

Elijah Zupancic created DRILL-5918: -- Summary: Allow manual configuration when using Runtime.getRuntime().availableProcessors() Key: DRILL-5918 URL: https://issues.apache.org/jira/browse/DRILL-5918

RE: gitbox?

For those of us that missed the hangout, can we get the minutes of the meeting? Would help in deciding on the vote rather than be an absentee. -Original Message- From: Parth Chandra [mailto:par...@apache.org] Sent: Tuesday, October 31, 2017 10:54 AM To: dev

Re: gitbox?

Bumping this thread up. Vlad brought this up in the hangout today and it sounds like we would like to move to Gitbox. Thanks Vlad for the patient explanations! Committers, let's use this thread to vote on the the suggestion. I'm +1 on moving to gitbox. Also, I can work with Vlad and Paul on

Re: [HANGOUT] Topics for 10/31/2017

Hello All, Can anyone please share some information on “how to get started debugging”. I’m a new member and want myself to get involved in this project. Any help is highly appreciated. Thanks Karthik Sent from my iPhone > On Oct 30, 2017, at 10:03 AM, Matthew Mucker

Re: [HANGOUT] Topics for 10/31/2017

says video call is full On Tue, Oct 31, 2017 at 1:04 PM, Parth Chandra wrote: > Starting the hangout in a bit ... > > On Mon, Oct 30, 2017 at 1:12 PM, Timothy Farkas wrote: > > > I'll speak about unit testing: > > > > > > - Common mistakes that were made

Re: [HANGOUT] Topics for 10/31/2017

Starting the hangout in a bit ... On Mon, Oct 30, 2017 at 1:12 PM, Timothy Farkas wrote: > I'll speak about unit testing: > > > - Common mistakes that were made in unit tests > > - The soon to be merged temp directory test watcher classes > > - Making our Travis build run

Re: Drill SASL Forward Compatibility

See my answers inline. On Tue, Oct 31, 2017 at 1:40 AM, Sorabh Hamirwasia wrote: > Hi Laurent, > > Thanks for pointing issue with <= 1.9 version Drillbit, I looked into > supported_methods field and it doesn't advertise SASL support using that > [1][2]. Do you mean that

[GitHub] drill issue #996: DRILL-5878: TableNotFound exception is being reported for ...

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/996 @HanumathRao thanks for making the changes. +1, LGTM. ---

[GitHub] drill issue #971: Drill-5834 Add Networking Functions

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/971 @cgivre under squash commits @paul-rogers meant that you should end up with one commit (now you have 13). You might consider using rebase and then do force push in your branch to overwrite

[jira] [Created] (DRILL-5917) Ban json.org library in Drill

Arina Ielchiieva created DRILL-5917: --- Summary: Ban json.org library in Drill Key: DRILL-5917 URL: https://issues.apache.org/jira/browse/DRILL-5917 Project: Apache Drill Issue Type: Task

[GitHub] drill issue #1017: DRILL-5822: The query with "SELECT *" with "ORDER BY" cla...

Github user vdiravka commented on the issue: https://github.com/apache/drill/pull/1017 @paul-rogers Could you please review this PR? You can find a short description here or more detailed - in the jira ticket [DRILL-5822](https://issues.apache.org/jira/browse/DRILL-5822). ---

[jira] [Created] (DRILL-5916) Drill document window function example on LAST_VALUE is incorrect

Raymond Wong created DRILL-5916: --- Summary: Drill document window function example on LAST_VALUE is incorrect Key: DRILL-5916 URL: https://issues.apache.org/jira/browse/DRILL-5916 Project: Apache Drill

[GitHub] drill pull request #904: DRILL-5717: change some date time test cases with s...

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/904#discussion_r148002267 --- Diff: logical/src/test/java/org/apache/drill/common/expression/fn/JodaDateValidatorTest.java --- @@ -119,13 +118,14 @@ public void

[GitHub] drill pull request #904: DRILL-5717: change some date time test cases with s...

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/904#discussion_r147997514 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewDateFunctions.java --- @@ -26,14 +26,14 @@ import org.junit.Test;

[GitHub] drill pull request #904: DRILL-5717: change some date time test cases with s...

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/904#discussion_r147996953 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewDateFunctions.java --- @@ -26,14 +26,14 @@ import org.junit.Test;

[GitHub] drill pull request #904: DRILL-5717: change some date time test cases with s...

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/904#discussion_r148000393 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/testing/TestDateConversions.java --- @@ -104,6 +110,13 @@ public void

[GitHub] drill pull request #904: DRILL-5717: change some date time test cases with s...

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/904#discussion_r148000718 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/testing/TestDateConversions.java --- @@ -117,10 +130,18 @@ public void

[GitHub] drill issue #904: DRILL-5717: change some date time test cases with specific...

Github user weijietong commented on the issue: https://github.com/apache/drill/pull/904 @vvysotskyi thanks for your help! have done, please review. ---

[GitHub] drill pull request #1017: The query with "SELECT *" with "ORDER BY" clause a...

GitHub user vdiravka opened a pull request: https://github.com/apache/drill/pull/1017 The query with "SELECT *" with "ORDER BY" clause and `planner.slice_t… …arget`=1 doesn't preserve column order Issue: Columns ordering doesn't preserve for the star query with sorting

Re: Drill SASL Forward Compatibility

Hi Laurent, Thanks for pointing issue with <= 1.9 version Drillbit, I looked into supported_methods field and it doesn't advertise SASL support using that [1][2]. Do you mean that checking if supported_methods list is non-empty should suffice since it was introduced in 1.10 ? For security