Pushpendra Jaiswal created DRILL-5937:
-
Summary: prepare.statement.create_timeout_ms default is 10
seconds but code comment says default should be 10 mins
Key: DRILL-5937
URL: https://issues.apache.org/jira/b
[
https://issues.apache.org/jira/browse/DRILL-5746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arina Ielchiieva resolved DRILL-5746.
-
Resolution: Fixed
In the scope of DRILL-5716.
> Pcap PR manually edited Protobuf files, v
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1021
@prasadns14 as far as I understood, you made all these changes to replace
`completed` with `succeeded`. What if you just make changes in State enum
itself, refactor some code and thus no cha
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1020#discussion_r149349985
--- Diff: exec/java-exec/src/main/resources/rest/metrics/metrics.ftl ---
@@ -138,21 +154,14 @@
});
};
-function upd
GitHub user vladimirtkach opened a pull request:
https://github.com/apache/drill/pull/1026
DRILL-5919: Add session option to allow json reader/writer to work with
NaN,INF
Added two session options `store.json.reader.non_numeric_numbers` and
`store.json.reader.non_numeric_numbers`
Volodymyr Tkach created DRILL-5938:
--
Summary: Write unit tests for math function with NaN and Infinity
numbers
Key: DRILL-5938
URL: https://issues.apache.org/jira/browse/DRILL-5938
Project: Apache D
Volodymyr Tkach created DRILL-5939:
--
Summary: NullPointerException in convert_toJSON function
Key: DRILL-5939
URL: https://issues.apache.org/jira/browse/DRILL-5939
Project: Apache Drill
Issu
GitHub user akumarb2010 opened a pull request:
https://github.com/apache/drill/pull/1027
DRILL-4779 : Kafka storage plugin
This PR contains Kafka support with JSON message format.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ak
B Anil Kumar created DRILL-5940:
---
Summary: Avro with schema registry support for Kafka
Key: DRILL-5940
URL: https://issues.apache.org/jira/browse/DRILL-5940
Project: Apache Drill
Issue Type: Ne
Arina Ielchiieva created DRILL-5941:
---
Summary: Skip header / footer logic works incorrectly for Hive
tables when file has several input splits
Key: DRILL-5941
URL: https://issues.apache.org/jira/browse/DRILL-594
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r149440392
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/testing/TestDateConversions.java
---
@@ -225,4 +243,16 @@ public void testPostgresDat
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r149440814
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestCastFunctions.java
---
@@ -77,16 +82,23 @@ public void testCastByConstantFolding(
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r149440034
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/interp/TestConstantFolding.java
---
@@ -117,6 +123,13 @@ public void createFiles(int small
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149463638
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java ---
@@ -239,6 +259,11 @@ QueryDataBatch getNext() throws UserException,
Interr
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149465309
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java ---
@@ -239,6 +259,11 @@ QueryDataBatch getNext() throws UserException,
Inte
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149467572
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java ---
@@ -376,6 +415,19 @@ synchronized void cleanup() {
currentBatchHol
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149471249
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java ---
@@ -100,13 +103,17 @@
final LinkedBlockingDeque batchQueue =
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149471937
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java
---
@@ -46,6 +48,8 @@
DrillRemoteStatement
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149472806
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java
---
@@ -61,8 +65,14 @@ protected DrillPreparedStatementImpl(Dri
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149472887
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -66,11 +70,27 @@
private final DrillConnectionImpl connect
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149473521
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -66,11 +70,27 @@
private final DrillConnectionImpl connect
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149473999
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -96,6 +117,13 @@ private void throwIfClosed() throws
AlreadyClos
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149474455
--- Diff:
exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java ---
@@ -237,6 +245,127 @@ public String toString() {
}
}
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149474798
--- Diff:
exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java ---
@@ -237,6 +245,127 @@ public String toString() {
}
}
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149475115
--- Diff:
exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java ---
@@ -237,6 +245,127 @@ public String toString() {
}
}
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149475535
--- Diff:
exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java ---
@@ -237,6 +245,127 @@ public String toString() {
}
}
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149476190
--- Diff:
exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java ---
@@ -237,6 +245,127 @@ public String toString() {
}
}
Timothy Farkas created DRILL-5942:
-
Summary: Drill Resource Management
Key: DRILL-5942
URL: https://issues.apache.org/jira/browse/DRILL-5942
Project: Apache Drill
Issue Type: Bug
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149476642
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java
---
@@ -61,8 +65,14 @@ protected DrillPreparedStatementImpl(D
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149476740
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -66,11 +70,27 @@
private final DrillConnectionImpl conne
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149476820
--- Diff:
exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java ---
@@ -237,6 +245,127 @@ public String toString() {
}
}
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149477233
--- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/StatementTest.java
---
@@ -61,55 +71,129 @@ public static void tearDownStatement() throws
SQLExcepti
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149477222
--- Diff:
exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java ---
@@ -237,6 +245,127 @@ public String toString() {
}
}
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149477955
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java ---
@@ -376,6 +415,19 @@ synchronized void cleanup() {
currentBatchH
[
https://issues.apache.org/jira/browse/DRILL-5138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothy Farkas resolved DRILL-5138.
---
Resolution: Fixed
> TopN operator on top of ~110 GB data set is very slow
> --
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149506412
--- Diff:
exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java ---
@@ -237,6 +245,127 @@ public String toString() {
}
}
Hello all,
I’d really love to see this PR make it into the next version of Drill. Is
there anything that I could do to assist?
Thanks,
- C
Github user ppadma commented on the issue:
https://github.com/apache/drill/pull/1015
@paul-rogers Thanks a lot for the review. Updated the PR with code review
comments. Please take a look.
Overall, good improvement with this change. Here are the numbers.
select count
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1024
@laurentgo Done the changes... ready for review.
---
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149543581
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -96,6 +105,14 @@ private void throwIfClosed() throws
AlreadyCl
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149542622
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java ---
@@ -239,6 +261,11 @@ QueryDataBatch getNext() throws UserException,
Inte
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149543078
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java ---
@@ -333,8 +368,14 @@ void close() {
final int batchQueueThrottli
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149542720
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java ---
@@ -260,6 +288,10 @@ void close() {
// when the main thread is
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149543163
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java ---
@@ -376,6 +417,19 @@ synchronized void cleanup() {
currentBatchH
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149542468
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java ---
@@ -139,8 +147,22 @@ private boolean stopThrottlingIfSo() {
re
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149545534
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java ---
@@ -239,6 +261,11 @@ QueryDataBatch getNext() throws UserException,
Interr
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149545640
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java ---
@@ -260,6 +288,10 @@ void close() {
// when the main thread is b
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/904
applied the review comments
---
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149546105
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java ---
@@ -260,6 +288,10 @@ void close() {
// when the main thread is
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149546258
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java ---
@@ -139,8 +147,22 @@ private boolean stopThrottlingIfSo() {
retu
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149546431
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java ---
@@ -376,6 +417,19 @@ synchronized void cleanup() {
currentBatchHol
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r149544267
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/TestGracefulShutdown.java ---
@@ -0,0 +1,323 @@
+/*
+ * Licensed to the Apache Softwar
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r149542196
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -348,6 +354,21 @@ public void run() {
*/
}
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r149541807
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitStateManager.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149547712
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -96,6 +105,14 @@ private void throwIfClosed() throws
AlreadyClos
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149548337
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -96,6 +105,14 @@ private void throwIfClosed() throws
AlreadyCl
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149548759
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java ---
@@ -333,8 +368,14 @@ void close() {
final int batchQueueThrottling
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149550418
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -96,6 +105,14 @@ private void throwIfClosed() throws
AlreadyClos
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149550602
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java ---
@@ -260,6 +288,10 @@ void close() {
// when the main thread is b
GitHub user sohami opened a pull request:
https://github.com/apache/drill/pull/1028
DRILL-5943: Avoid the strong check introduced by DRILL-5582 for PLAINâ¦
⦠mechanism
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sohami/dril
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/1021
@arina-ielchiieva, @prasadns14, here is my two cents.
The names and numbers used in the protobuf definitions are part of Drill's
public network API. This API is not versioned, so we can't
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/1028
@parthchandra & @laurentgo - Please help to review this PR.
---
Sorabh Hamirwasia created DRILL-5943:
Summary: Avoid the strong check introduced by DRILL-5582 for PLAIN
mechanism
Key: DRILL-5943
URL: https://issues.apache.org/jira/browse/DRILL-5943
Project: Ap
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1015#discussion_r149555002
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternEndsWithMatcher.java
---
@@ -17,33 +17,30 @@
*/
package o
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1015#discussion_r149552506
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/AbstractSqlPatternMatcher.java
---
@@ -0,0 +1,61 @@
+/*
+ * Licensed t
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1015#discussion_r149552453
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/AbstractSqlPatternMatcher.java
---
@@ -0,0 +1,61 @@
+/*
+ * Licensed t
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1015#discussion_r149554356
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternEndsWithMatcher.java
---
@@ -17,33 +17,30 @@
*/
package o
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1015#discussion_r149554195
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java
---
@@ -17,37 +17,48 @@
*/
package o
Github user ppadma commented on the issue:
https://github.com/apache/drill/pull/1015
@paul-rogers updated with latest review comments taken care of. Please take
a look.
---
69 matches
Mail list logo
