weijietong commented on a change in pull request #1334: DRILL-6385: Support
JPPD feature
URL: https://github.com/apache/drill/pull/1334#discussion_r200521164
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/RuntimeFilterManager.java
##
@@ -0,0
weijietong commented on a change in pull request #1334: DRILL-6385: Support
JPPD feature
URL: https://github.com/apache/drill/pull/1334#discussion_r200520720
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/RuntimeFilterManager.java
##
@@ -0,0
weijietong commented on a change in pull request #1334: DRILL-6385: Support
JPPD feature
URL: https://github.com/apache/drill/pull/1334#discussion_r200520207
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java
##
@@ -375,6 +378,30 @@ pro
weijietong commented on a change in pull request #1334: DRILL-6385: Support
JPPD feature
URL: https://github.com/apache/drill/pull/1334#discussion_r200519816
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionValue.java
##
@@ -76,7 +77,7
weijietong commented on a change in pull request #1334: DRILL-6385: Support
JPPD feature
URL: https://github.com/apache/drill/pull/1334#discussion_r200519330
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ScanPrel.java
##
@@ -151,12 +151
weijietong commented on a change in pull request #1334: DRILL-6385: Support
JPPD feature
URL: https://github.com/apache/drill/pull/1334#discussion_r200518460
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ScanPrel.java
##
@@ -151,12 +151
vdiravka opened a new pull request #1364: DRILL-6559: Travis timing out
URL: https://github.com/apache/drill/pull/1364
* Excluding contrib module tests and all exec TPCH unit tests for travis
full build.
* Introducing new TRAVIS profile
* Travis build is faster for 4-5 mins
-
Rob Wu created DRILL-6581:
-
Summary: Improve C++ Client's SSL Error Messages
Key: DRILL-6581
URL: https://issues.apache.org/jira/browse/DRILL-6581
Project: Apache Drill
Issue Type: Task
Com
Hi Paul,
That was what I thought as well. The function doesn't seem to work properly
either setting positive as 1 or -1. I looked at other UDFs that I’ve written
in the past that return Boolean values and the implementation is almost exactly
the same, so I’m a bit at a loss on this one.
— C
Hi Tim,
My understanding is that Booleans are stored, as you said, as a UInt1 vector.
But, the values are 0 and (positive) 1. As you said, singletonInt will read
this value. If the value is coming back as -1, then this is a bug. I'd be
surprised if it is since I wrote lots of code that assumed
amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature
URL: https://github.com/apache/drill/pull/1334#issuecomment-402828959
@weijietong I have couple of design questions that are better discussed in
the JIRA, so I will add them there.. pls take a look. Thanks.
-
amansinha100 commented on a change in pull request #1334: DRILL-6385: Support
JPPD feature
URL: https://github.com/apache/drill/pull/1334#discussion_r199558705
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ScanPrel.java
##
@@ -151,12 +1
amansinha100 commented on a change in pull request #1334: DRILL-6385: Support
JPPD feature
URL: https://github.com/apache/drill/pull/1334#discussion_r199559121
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataTunnel.java
##
@@ -92,6 +91,26 @@
amansinha100 commented on a change in pull request #1334: DRILL-6385: Support
JPPD feature
URL: https://github.com/apache/drill/pull/1334#discussion_r199558426
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ScanPrel.java
##
@@ -151,12 +1
amansinha100 commented on a change in pull request #1334: DRILL-6385: Support
JPPD feature
URL: https://github.com/apache/drill/pull/1334#discussion_r199559935
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionSet.java
##
@@ -118,4 +118
amansinha100 commented on a change in pull request #1334: DRILL-6385: Support
JPPD feature
URL: https://github.com/apache/drill/pull/1334#discussion_r199560963
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionValue.java
##
@@ -76,7 +77
amansinha100 commented on a change in pull request #1334: DRILL-6385: Support
JPPD feature
URL: https://github.com/apache/drill/pull/1334#discussion_r200462708
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/RuntimeFilterManager.java
##
@@ -0,
amansinha100 commented on a change in pull request #1334: DRILL-6385: Support
JPPD feature
URL: https://github.com/apache/drill/pull/1334#discussion_r199638120
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java
##
@@ -375,6 +378,30 @@ p
amansinha100 commented on a change in pull request #1334: DRILL-6385: Support
JPPD feature
URL: https://github.com/apache/drill/pull/1334#discussion_r200454496
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/RuntimeFilterManager.java
##
@@ -0,
amansinha100 commented on a change in pull request #1334: DRILL-6385: Support
JPPD feature
URL: https://github.com/apache/drill/pull/1334#discussion_r200463243
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/RuntimeFilterManager.java
##
@@ -0,
amansinha100 commented on a change in pull request #1334: DRILL-6385: Support
JPPD feature
URL: https://github.com/apache/drill/pull/1334#discussion_r200459684
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/RuntimeFilterManager.java
##
@@ -0,
vrozov commented on a change in pull request #1264: DRILL-6422: Update guava
to 23.0 and shade it
URL: https://github.com/apache/drill/pull/1264#discussion_r200415787
##
File path:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.j
vrozov commented on a change in pull request #1264: DRILL-6422: Update guava
to 23.0 and shade it
URL: https://github.com/apache/drill/pull/1264#discussion_r200415939
##
File path:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.j
ppadma commented on issue #1363: DRILL-6549: batch sizing for nested loop join
URL: https://github.com/apache/drill/pull/1363#issuecomment-40236
@sohami @Ben-Zvi can one of you review this ? Pretty straightforward
changes.
--
cgivre commented on issue #1331: DRILL-6519: Add String Distance and Phonetic
Functions
URL: https://github.com/apache/drill/pull/1331#issuecomment-402767430
@arina-ielchiieva
Sorry about that. I didn't realize that my unit tests weren't run by Travis
CI. In any event, I removed the
Hi Timothy,
I am still having issues with the unit tests for this particular function. The
code is below. This function takes the soundex values of two strings and if
they are equal is supposed to return true, if not returns false. I do this by
setting the value of a BitHolder to either -1 o
arina-ielchiieva edited a comment on issue #1272: DRILL-5977: Filter Pushdown
in Drill-Kafka plugin
URL: https://github.com/apache/drill/pull/1272#issuecomment-402678125
@aravi5 merged your changes, had to change your commit message since it did
not comply with Drill policy.
arina-ielchiieva commented on issue #1272: DRILL-5977: Filter Pushdown in
Drill-Kafka plugin
URL: https://github.com/apache/drill/pull/1272#issuecomment-402678125
@aravi5 merged your changes, had to change your commit message since it did
not comply Drill policy.
asfgit closed pull request #1272: DRILL-5977: Filter Pushdown in Drill-Kafka
plugin
URL: https://github.com/apache/drill/pull/1272
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a fore
arina-ielchiieva commented on issue #1126: DRILL-6179: Added pcapng-format
support
URL: https://github.com/apache/drill/pull/1126#issuecomment-402660764
@paul-rogers could you please do final code review? Vlad has addressed code
review comments and we plan to include this change in 1.14.
30 matches
Mail list logo