[GitHub] kkhatua commented on issue #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query

2019-02-05 Thread GitBox
kkhatua commented on issue #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query URL: https://github.com/apache/drill/pull/1608#issuecomment-460930334 Let me take a look at `WebUserConnection` . I want to make sure that we don't hold all the results indefinitely if we

[GitHub] cgivre commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin

2019-02-05 Thread GitBox
cgivre commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin URL: https://github.com/apache/drill/pull/1530#discussion_r254135268 ## File path: contrib/format-syslog/src/main/resources/checkstyle-config.xml ## @@ -0,0 +1,40 @@ + + +http:/

[GitHub] cgivre commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin

2019-02-05 Thread GitBox
cgivre commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin URL: https://github.com/apache/drill/pull/1530#discussion_r254135160 ## File path: contrib/format-syslog/src/main/java/org/apache/drill/exec/store/syslog/SyslogFormatConfig.java ###

[jira] [Created] (DRILL-7029) Move LogRegex Format Plugin to Contrib

2019-02-05 Thread Charles Givre (JIRA)
Charles Givre created DRILL-7029: Summary: Move LogRegex Format Plugin to Contrib Key: DRILL-7029 URL: https://issues.apache.org/jira/browse/DRILL-7029 Project: Apache Drill Issue Type: Task

[GitHub] cgivre commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin

2019-02-05 Thread GitBox
cgivre commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin URL: https://github.com/apache/drill/pull/1530#discussion_r254134574 ## File path: contrib/format-syslog/README.md ## @@ -0,0 +1,41 @@ +# Syslog Format Plugin Review comment:

[GitHub] kkhatua commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query

2019-02-05 Thread GitBox
kkhatua commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query URL: https://github.com/apache/drill/pull/1608#discussion_r254118821 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java ###

[GitHub] kkhatua commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query

2019-02-05 Thread GitBox
kkhatua commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query URL: https://github.com/apache/drill/pull/1608#discussion_r254115477 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker

[GitHub] kkhatua commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query

2019-02-05 Thread GitBox
kkhatua commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query URL: https://github.com/apache/drill/pull/1608#discussion_r254106628 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/Profil

[GitHub] kkhatua commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query

2019-02-05 Thread GitBox
kkhatua commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query URL: https://github.com/apache/drill/pull/1608#discussion_r254106698 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/user/UserWorker.java

[GitHub] kkhatua commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query

2019-02-05 Thread GitBox
kkhatua commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query URL: https://github.com/apache/drill/pull/1608#discussion_r254106312 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java

[GitHub] kkhatua commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query

2019-02-05 Thread GitBox
kkhatua commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query URL: https://github.com/apache/drill/pull/1608#discussion_r254106312 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java

[GitHub] kkhatua commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query

2019-02-05 Thread GitBox
kkhatua commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query URL: https://github.com/apache/drill/pull/1608#discussion_r254105360 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java ###

[jira] [Created] (DRILL-7028) Reduce the planning time of queries on large Parquet tables with large metadata cache files

2019-02-05 Thread Venkata Jyothsna Donapati (JIRA)
Venkata Jyothsna Donapati created DRILL-7028: Summary: Reduce the planning time of queries on large Parquet tables with large metadata cache files Key: DRILL-7028 URL: https://issues.apache.org/jira/br

[jira] [Created] (DRILL-7027) TPCH Queries hit IOB when planner.enable_demux_exchange = true

2019-02-05 Thread Karthikeyan Manivannan (JIRA)
Karthikeyan Manivannan created DRILL-7027: - Summary: TPCH Queries hit IOB when planner.enable_demux_exchange = true Key: DRILL-7027 URL: https://issues.apache.org/jira/browse/DRILL-7027 Projec

[GitHub] cgivre opened a new pull request #1635: DRILL-7021: HTTPD Throws NPE and Doesn't Recognize Timeformat

2019-02-05 Thread GitBox
cgivre opened a new pull request #1635: DRILL-7021: HTTPD Throws NPE and Doesn't Recognize Timeformat URL: https://github.com/apache/drill/pull/1635 This PR addresses several issues with the HTTPD format plugin. 1. Several fields were missing in the implementation which were causing a

[GitHub] kfaraaz opened a new pull request #1634: DRILL-6979: Added autofocus attribute to username on login page, and to query tex…

2019-02-05 Thread GitBox
kfaraaz opened a new pull request #1634: DRILL-6979: Added autofocus attribute to username on login page, and to query tex… URL: https://github.com/apache/drill/pull/1634 …tbox on Query tab @sohami @kkhatua Can you please review ? --

Apache Drill Hangout - 05 Feb, 2019

2019-02-05 Thread Bohdan Kazydub
Hi Drillers, The bi-weekly Apache Drill hangout is scheduled for today, Tuesday, Feb 5th, at 10 AM PST. The original plan is for Sorabh & Hanumath to talk about Resource Management. If there are any other topics or questions, feel free to reply or raise during the hangout. The hangout link: https:

[GitHub] vvysotskyi commented on issue #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query

2019-02-05 Thread GitBox
vvysotskyi commented on issue #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query URL: https://github.com/apache/drill/pull/1608#issuecomment-460669449 Regarding this fix and fix for DRILL-6050. I think allowing web-client to rewrite the query is not the best approa

Re: [DISCUSS] Format plugins in contrib module

2019-02-05 Thread Vitalii Diravka
Absolutely agree with Arina. I think the core Format Plugins for Parquet, Json and CSV, TSV, PSV files (which are used for creating Drill tables) can be left in current config file and the rest ones should be factored out to the separate config files along with creating separate modules in Drill *

[GitHub] vvysotskyi commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query

2019-02-05 Thread GitBox
vvysotskyi commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query URL: https://github.com/apache/drill/pull/1608#discussion_r253866957 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWor

Re: [DISCUSS] Format plugins in contrib module

2019-02-05 Thread Charles Givre
I’d concur with Arina’s suggestion. I do think this would be useful and make it easier to make plugins “pluggable”. In the meantime, should we recommend that developers of format-plugins include their plugins in the bootstrap-storage-plugins.json? I was thinking also that we might want to ha

[jira] [Resolved] (DRILL-4813) Need better error message for table function when table does not exist

2019-02-05 Thread Arina Ielchiieva (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva resolved DRILL-4813. - Resolution: Fixed > Need better error message for table function when table does not exis

[jira] [Resolved] (DRILL-5673) NPE from planner when using a table function with an invalid table

2019-02-05 Thread Arina Ielchiieva (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva resolved DRILL-5673. - Resolution: Fixed > NPE from planner when using a table function with an invalid table >

[GitHub] arina-ielchiieva commented on issue #1612: DRILL-6970: fix issue with logregex format plugin where drillbuf was overflowing

2019-02-05 Thread GitBox
arina-ielchiieva commented on issue #1612: DRILL-6970: fix issue with logregex format plugin where drillbuf was overflowing URL: https://github.com/apache/drill/pull/1612#issuecomment-460618283 @jcmcote is there any update? T

[DISCUSS] Format plugins in contrib module

2019-02-05 Thread Arina Yelchiyeva
Hi all, Before we were adding new formats / plugins into the exec module. Eventually we came up to the point that exec package size is growing and adding plugin and format contributions is better to separate out in the different module. Now we have contrib module where we add such contributions.

[GitHub] vdiravka commented on a change in pull request #1627: DRILL-7014: Format plugin for LTSV files

2019-02-05 Thread GitBox
vdiravka commented on a change in pull request #1627: DRILL-7014: Format plugin for LTSV files URL: https://github.com/apache/drill/pull/1627#discussion_r253824507 ## File path: contrib/format-ltsv/src/main/java/org/apache/drill/exec/store/ltsv/LTSVFormatPlugin.java ## @@

[GitHub] vvysotskyi commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query

2019-02-05 Thread GitBox
vvysotskyi commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query URL: https://github.com/apache/drill/pull/1608#discussion_r253814230 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.ja

[GitHub] vvysotskyi commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query

2019-02-05 Thread GitBox
vvysotskyi commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query URL: https://github.com/apache/drill/pull/1608#discussion_r253807881 ## File path: exec/java-exec/src/main/resources/rest/static/js/querySubmission.js ##

[GitHub] vvysotskyi commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query

2019-02-05 Thread GitBox
vvysotskyi commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query URL: https://github.com/apache/drill/pull/1608#discussion_r253817340 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/user/UserWorker.ja

[GitHub] vvysotskyi commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query

2019-02-05 Thread GitBox
vvysotskyi commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query URL: https://github.com/apache/drill/pull/1608#discussion_r253814733 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java

[GitHub] vvysotskyi commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query

2019-02-05 Thread GitBox
vvysotskyi commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query URL: https://github.com/apache/drill/pull/1608#discussion_r253798677 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java

[GitHub] vdiravka commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin

2019-02-05 Thread GitBox
vdiravka commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin URL: https://github.com/apache/drill/pull/1530#discussion_r253767075 ## File path: contrib/format-syslog/src/main/java/org/apache/drill/exec/store/syslog/SyslogRecordReader.java #

[GitHub] vdiravka commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin

2019-02-05 Thread GitBox
vdiravka commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin URL: https://github.com/apache/drill/pull/1530#discussion_r253763788 ## File path: contrib/format-syslog/README.md ## @@ -0,0 +1,41 @@ +# Syslog Format Plugin Review commen

[GitHub] vdiravka commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin

2019-02-05 Thread GitBox
vdiravka commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin URL: https://github.com/apache/drill/pull/1530#discussion_r253784583 ## File path: contrib/format-syslog/src/main/java/org/apache/drill/exec/store/syslog/SyslogFormatConfig.java #

[GitHub] shimamoto commented on issue #1627: DRILL-7014: Format plugin for LTSV files

2019-02-05 Thread GitBox
shimamoto commented on issue #1627: DRILL-7014: Format plugin for LTSV files URL: https://github.com/apache/drill/pull/1627#issuecomment-460559287 > Also, IMHO, you should add the config to the default Drill config so that people can query `ltsv` files by default. Is it correct to ad

[GitHub] shimamoto commented on a change in pull request #1627: DRILL-7014: Format plugin for LTSV files

2019-02-05 Thread GitBox
shimamoto commented on a change in pull request #1627: DRILL-7014: Format plugin for LTSV files URL: https://github.com/apache/drill/pull/1627#discussion_r253772190 ## File path: contrib/format-ltsv/src/main/java/org/apache/drill/exec/store/ltsv/LTSVFormatPlugin.java ## @

[GitHub] shimamoto commented on a change in pull request #1627: DRILL-7014: Format plugin for LTSV files

2019-02-05 Thread GitBox
shimamoto commented on a change in pull request #1627: DRILL-7014: Format plugin for LTSV files URL: https://github.com/apache/drill/pull/1627#discussion_r253772028 ## File path: contrib/format-ltsv/src/main/java/org/apache/drill/exec/store/ltsv/LTSVFormatPlugin.java ## @

[GitHub] shimamoto commented on a change in pull request #1627: DRILL-7014: Format plugin for LTSV files

2019-02-05 Thread GitBox
shimamoto commented on a change in pull request #1627: DRILL-7014: Format plugin for LTSV files URL: https://github.com/apache/drill/pull/1627#discussion_r253771968 ## File path: contrib/format-ltsv/src/main/java/org/apache/drill/exec/store/ltsv/LTSVRecordReader.java ## @

[GitHub] shimamoto commented on a change in pull request #1627: DRILL-7014: Format plugin for LTSV files

2019-02-05 Thread GitBox
shimamoto commented on a change in pull request #1627: DRILL-7014: Format plugin for LTSV files URL: https://github.com/apache/drill/pull/1627#discussion_r253770309 ## File path: contrib/format-ltsv/src/main/java/org/apache/drill/exec/store/ltsv/LTSVRecordReader.java ## @

[GitHub] shimamoto commented on a change in pull request #1627: DRILL-7014: Format plugin for LTSV files

2019-02-05 Thread GitBox
shimamoto commented on a change in pull request #1627: DRILL-7014: Format plugin for LTSV files URL: https://github.com/apache/drill/pull/1627#discussion_r253770219 ## File path: contrib/format-ltsv/src/main/java/org/apache/drill/exec/store/ltsv/LTSVRecordReader.java ## @

[GitHub] shimamoto commented on a change in pull request #1627: DRILL-7014: Format plugin for LTSV files

2019-02-05 Thread GitBox
shimamoto commented on a change in pull request #1627: DRILL-7014: Format plugin for LTSV files URL: https://github.com/apache/drill/pull/1627#discussion_r253769950 ## File path: contrib/format-ltsv/src/main/java/org/apache/drill/exec/store/ltsv/LTSVFormatPluginConfig.java ###

[GitHub] shimamoto commented on a change in pull request #1627: DRILL-7014: Format plugin for LTSV files

2019-02-05 Thread GitBox
shimamoto commented on a change in pull request #1627: DRILL-7014: Format plugin for LTSV files URL: https://github.com/apache/drill/pull/1627#discussion_r25376 ## File path: contrib/format-ltsv/src/main/java/org/apache/drill/exec/store/ltsv/LTSVFormatPluginConfig.java ###