[GitHub] [drill] paul-rogers commented on a change in pull request #1711: DRILL-7011: Support schema in scan framework

2019-03-27 Thread GitBox
paul-rogers commented on a change in pull request #1711: DRILL-7011: Support schema in scan framework URL: https://github.com/apache/drill/pull/1711#discussion_r269437772 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/easy/text/compliant/TestCsvWithSchema.ja

[GitHub] [drill] paul-rogers commented on a change in pull request #1711: DRILL-7011: Support schema in scan framework

2019-03-27 Thread GitBox
paul-rogers commented on a change in pull request #1711: DRILL-7011: Support schema in scan framework URL: https://github.com/apache/drill/pull/1711#discussion_r269438194 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/easy/text/compliant/TestCsvWithSchema.ja

[GitHub] [drill] paul-rogers commented on issue #1711: DRILL-7011: Support schema in scan framework

2019-03-27 Thread GitBox
paul-rogers commented on issue #1711: DRILL-7011: Support schema in scan framework URL: https://github.com/apache/drill/pull/1711#issuecomment-477031299 Added wildcard projection handling for both "lenient" and "strict" schemas. Added tests for the scan framework. Added a basic tests for "

[GitHub] [drill] vdiravka commented on a change in pull request #1681: DRILL-7051: Upgrade to Jetty 9.3

2019-03-27 Thread GitBox
vdiravka commented on a change in pull request #1681: DRILL-7051: Upgrade to Jetty 9.3 URL: https://github.com/apache/drill/pull/1681#discussion_r269085173 ## File path: pom.xml ## @@ -2553,7 +2548,13 @@ 4.0.1 provided - + +

[GitHub] [drill] arina-ielchiieva opened a new pull request #1717: DRILL-6989: Upgrade to SqlLine 1.7

2019-03-27 Thread GitBox
arina-ielchiieva opened a new pull request #1717: DRILL-6989: Upgrade to SqlLine 1.7 URL: https://github.com/apache/drill/pull/1717 Details in [DRILL-6989](https://issues.apache.org/jira/browse/DRILL-6989). This is an automat

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1711: DRILL-7011: Support schema in scan framework

2019-03-27 Thread GitBox
arina-ielchiieva commented on a change in pull request #1711: DRILL-7011: Support schema in scan framework URL: https://github.com/apache/drill/pull/1711#discussion_r269512455 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/project/ScanLevelProje

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1711: DRILL-7011: Support schema in scan framework

2019-03-27 Thread GitBox
arina-ielchiieva commented on a change in pull request #1711: DRILL-7011: Support schema in scan framework URL: https://github.com/apache/drill/pull/1711#discussion_r269542539 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/file/MetadataColumn.ja

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1711: DRILL-7011: Support schema in scan framework

2019-03-27 Thread GitBox
arina-ielchiieva commented on a change in pull request #1711: DRILL-7011: Support schema in scan framework URL: https://github.com/apache/drill/pull/1711#discussion_r269512903 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/project/WildcardProjec

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1711: DRILL-7011: Support schema in scan framework

2019-03-27 Thread GitBox
arina-ielchiieva commented on a change in pull request #1711: DRILL-7011: Support schema in scan framework URL: https://github.com/apache/drill/pull/1711#discussion_r269513816 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/scan/BaseScanOperatorExecTe

[GitHub] [drill] arina-ielchiieva commented on issue #1711: DRILL-7011: Support schema in scan framework

2019-03-27 Thread GitBox
arina-ielchiieva commented on issue #1711: DRILL-7011: Support schema in scan framework URL: https://github.com/apache/drill/pull/1711#issuecomment-477160154 @paul-rogers command syntax is the following: ``` CREATE [OR REPLACE] SCHEMA [LOAD 'file:///path/to/file'] [(column_name

[GitHub] [drill] arina-ielchiieva edited a comment on issue #1711: DRILL-7011: Support schema in scan framework

2019-03-27 Thread GitBox
arina-ielchiieva edited a comment on issue #1711: DRILL-7011: Support schema in scan framework URL: https://github.com/apache/drill/pull/1711#issuecomment-477160154 @paul-rogers command syntax is the following: ``` CREATE [OR REPLACE] SCHEMA [LOAD 'file:///path/to/file'] [(colum

[GitHub] [drill] arina-ielchiieva edited a comment on issue #1711: DRILL-7011: Support schema in scan framework

2019-03-27 Thread GitBox
arina-ielchiieva edited a comment on issue #1711: DRILL-7011: Support schema in scan framework URL: https://github.com/apache/drill/pull/1711#issuecomment-477160154 @paul-rogers command syntax is the following: ``` CREATE [OR REPLACE] SCHEMA [LOAD 'file:///path/to/file'] [(colum

[GitHub] [drill] ihuzenko commented on issue #1706: DRILL-7115: Improve Hive schema show tables performance

2019-03-27 Thread GitBox
ihuzenko commented on issue #1706: DRILL-7115: Improve Hive schema show tables performance URL: https://github.com/apache/drill/pull/1706#issuecomment-477196081 Hi @vdiravka , according to the [PR discussion](https://github.com/apache/drill/pull/461#discussion_r58753354) , show tables aut

[GitHub] [drill] ihuzenko commented on issue #1706: DRILL-7115: Improve Hive schema show tables performance

2019-03-27 Thread GitBox
ihuzenko commented on issue #1706: DRILL-7115: Improve Hive schema show tables performance URL: https://github.com/apache/drill/pull/1706#issuecomment-477219702 @vdiravka could you please review again from scratch ? Because a lot of things were changed since last review.

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269711718 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269710545 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269719993 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/StatementTest.java #

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269711132 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269720137 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/StatementTest.java #

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269720874 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2489CallsAfterClos

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269710453 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269719449 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269719305 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269711273 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269720328 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/StatementTest.java #

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269710761 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269711570 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269720581 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/StatementTest.java #

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269711477 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269711070 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269720507 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/StatementTest.java #

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269710983 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269710348 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269720216 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/StatementTest.java #

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269720404 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/StatementTest.java #

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269719774 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/StatementTest.java #

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269719943 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/StatementTest.java #

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269709745 ## File path: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementI

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269711382 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269719854 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/StatementTest.java #

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269711807 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java

[GitHub] [drill] kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269751346 ## File path: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl

[GitHub] [drill] kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269753040 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java ###

[GitHub] [drill] kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269753146 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java ###

[GitHub] [drill] gparai commented on a change in pull request #1715: DRILL-7117: Support creation of equi-depth histogram for selected dat…

2019-03-27 Thread GitBox
gparai commented on a change in pull request #1715: DRILL-7117: Support creation of equi-depth histogram for selected dat… URL: https://github.com/apache/drill/pull/1715#discussion_r269754472 ## File path: exec/java-exec/src/main/resources/drill-module.conf ## @@ -685,5 +6

[GitHub] [drill] gparai commented on a change in pull request #1715: DRILL-7117: Support creation of equi-depth histogram for selected dat…

2019-03-27 Thread GitBox
gparai commented on a change in pull request #1715: DRILL-7117: Support creation of equi-depth histogram for selected dat… URL: https://github.com/apache/drill/pull/1715#discussion_r269753784 ## File path: exec/jdbc-all/pom.xml ## @@ -452,6 +452,7 @@ org/a

[GitHub] [drill] gparai commented on a change in pull request #1715: DRILL-7117: Support creation of equi-depth histogram for selected dat…

2019-03-27 Thread GitBox
gparai commented on a change in pull request #1715: DRILL-7117: Support creation of equi-depth histogram for selected dat… URL: https://github.com/apache/drill/pull/1715#discussion_r269755101 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/NumericEqu

[GitHub] [drill] gparai commented on a change in pull request #1715: DRILL-7117: Support creation of equi-depth histogram for selected dat…

2019-03-27 Thread GitBox
gparai commented on a change in pull request #1715: DRILL-7117: Support creation of equi-depth histogram for selected dat… URL: https://github.com/apache/drill/pull/1715#discussion_r269756979 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/NumericEqu

[GitHub] [drill] gparai commented on a change in pull request #1715: DRILL-7117: Support creation of equi-depth histogram for selected dat…

2019-03-27 Thread GitBox
gparai commented on a change in pull request #1715: DRILL-7117: Support creation of equi-depth histogram for selected dat… URL: https://github.com/apache/drill/pull/1715#discussion_r269731108 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/TDigestFunct

[GitHub] [drill] gparai commented on a change in pull request #1715: DRILL-7117: Support creation of equi-depth histogram for selected dat…

2019-03-27 Thread GitBox
gparai commented on a change in pull request #1715: DRILL-7117: Support creation of equi-depth histogram for selected dat… URL: https://github.com/apache/drill/pull/1715#discussion_r269748728 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/

[GitHub] [drill] gparai commented on a change in pull request #1715: DRILL-7117: Support creation of equi-depth histogram for selected dat…

2019-03-27 Thread GitBox
gparai commented on a change in pull request #1715: DRILL-7117: Support creation of equi-depth histogram for selected dat… URL: https://github.com/apache/drill/pull/1715#discussion_r269730355 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/TDigestFunct

[GitHub] [drill] gparai commented on a change in pull request #1715: DRILL-7117: Support creation of equi-depth histogram for selected dat…

2019-03-27 Thread GitBox
gparai commented on a change in pull request #1715: DRILL-7117: Support creation of equi-depth histogram for selected dat… URL: https://github.com/apache/drill/pull/1715#discussion_r269757452 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/StringEqui

[GitHub] [drill] gparai commented on a change in pull request #1715: DRILL-7117: Support creation of equi-depth histogram for selected dat…

2019-03-27 Thread GitBox
gparai commented on a change in pull request #1715: DRILL-7117: Support creation of equi-depth histogram for selected dat… URL: https://github.com/apache/drill/pull/1715#discussion_r269733494 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/TDigestFunct

[GitHub] [drill] gparai commented on a change in pull request #1715: DRILL-7117: Support creation of equi-depth histogram for selected dat…

2019-03-27 Thread GitBox
gparai commented on a change in pull request #1715: DRILL-7117: Support creation of equi-depth histogram for selected dat… URL: https://github.com/apache/drill/pull/1715#discussion_r269752998 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/

[GitHub] [drill] gparai commented on a change in pull request #1715: DRILL-7117: Support creation of equi-depth histogram for selected dat…

2019-03-27 Thread GitBox
gparai commented on a change in pull request #1715: DRILL-7117: Support creation of equi-depth histogram for selected dat… URL: https://github.com/apache/drill/pull/1715#discussion_r269752646 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillStats

[GitHub] [drill] gparai commented on a change in pull request #1715: DRILL-7117: Support creation of equi-depth histogram for selected dat…

2019-03-27 Thread GitBox
gparai commented on a change in pull request #1715: DRILL-7117: Support creation of equi-depth histogram for selected dat… URL: https://github.com/apache/drill/pull/1715#discussion_r269727107 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/TDigestFunct

[GitHub] [drill] kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269759078 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2489CallsAfterCloseTh

[GitHub] [drill] kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

2019-03-27 Thread GitBox
kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r269763048 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java ###

[jira] [Created] (DRILL-7136) Num_buckets for HashAgg in profile may be inaccurate

2019-03-27 Thread Robert Hou (JIRA)
Robert Hou created DRILL-7136: - Summary: Num_buckets for HashAgg in profile may be inaccurate Key: DRILL-7136 URL: https://issues.apache.org/jira/browse/DRILL-7136 Project: Apache Drill Issue Typ

[jira] [Created] (DRILL-7137) Implement unit test case to test Drill client <-> interaction in a secure setup

2019-03-27 Thread Karthikeyan Manivannan (JIRA)
Karthikeyan Manivannan created DRILL-7137: - Summary: Implement unit test case to test Drill client <-> interaction in a secure setup Key: DRILL-7137 URL: https://issues.apache.org/jira/browse/DRILL-7137

[GitHub] [drill] gparai opened a new pull request #1718: DRILL-7121: Use correct ndv when statistics is disabled

2019-03-27 Thread GitBox
gparai opened a new pull request #1718: DRILL-7121: Use correct ndv when statistics is disabled URL: https://github.com/apache/drill/pull/1718 @amansinha100 can you please review the PR? Thanks! This is an automated message f