[GitHub] [drill] KazydubB commented on issue #1902: DRILL-7448: Fix warnings when running Drill memory tests

2019-11-19 Thread GitBox
KazydubB commented on issue #1902: DRILL-7448: Fix warnings when running Drill memory tests URL: https://github.com/apache/drill/pull/1902#issuecomment-13720 @paul-rogers, @vvysotskyi I've updated the PR with @vvysotskyi 's suggestion. Thank you! --

[GitHub] [drill] arina-ielchiieva commented on issue #1902: DRILL-7448: Fix warnings when running Drill memory tests

2019-11-19 Thread GitBox
arina-ielchiieva commented on issue #1902: DRILL-7448: Fix warnings when running Drill memory tests URL: https://github.com/apache/drill/pull/1902#issuecomment-22348 @KazydubB thanks for making the changes. Discussed this issue with @vvysotskyi, it looks like adding janino dependency t

[GitHub] [drill] arina-ielchiieva edited a comment on issue #1902: DRILL-7448: Fix warnings when running Drill memory tests

2019-11-19 Thread GitBox
arina-ielchiieva edited a comment on issue #1902: DRILL-7448: Fix warnings when running Drill memory tests URL: https://github.com/apache/drill/pull/1902#issuecomment-22348 @KazydubB thanks for making the changes. Discussed this issue with @vvysotskyi, it looks like adding janino depen

[GitHub] [drill] KazydubB commented on issue #1902: DRILL-7448: Fix warnings when running Drill memory tests

2019-11-19 Thread GitBox
KazydubB commented on issue #1902: DRILL-7448: Fix warnings when running Drill memory tests URL: https://github.com/apache/drill/pull/1902#issuecomment-75489 @arina-ielchiieva, yes, this is definetely better. Thank you! @arina-ielchiieva, @vvysotskyi, @paul-rogers I've yet another ch

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1895: DRILL-6540: Upgrade to HADOOP-3.x libraries

2019-11-19 Thread GitBox
arina-ielchiieva commented on a change in pull request #1895: DRILL-6540: Upgrade to HADOOP-3.x libraries URL: https://github.com/apache/drill/pull/1895#discussion_r348014523 ## File path: docs/dev/HadoopWinutils.md ## @@ -0,0 +1,11 @@ +## Hadoop Winutils + +Hadoop Winutil

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1895: DRILL-6540: Upgrade to HADOOP-3.x libraries

2019-11-19 Thread GitBox
arina-ielchiieva commented on a change in pull request #1895: DRILL-6540: Upgrade to HADOOP-3.x libraries URL: https://github.com/apache/drill/pull/1895#discussion_r348013784 ## File path: docs/dev/HadoopWinutils.md ## @@ -0,0 +1,11 @@ +## Hadoop Winutils + +Hadoop Winutil

[GitHub] [drill] KazydubB edited a comment on issue #1902: DRILL-7448: Fix warnings when running Drill memory tests

2019-11-19 Thread GitBox
KazydubB edited a comment on issue #1902: DRILL-7448: Fix warnings when running Drill memory tests URL: https://github.com/apache/drill/pull/1902#issuecomment-75489 @arina-ielchiieva, yes, this is definetely better. Thank you! @arina-ielchiieva, @vvysotskyi, @paul-rogers I've made ye

[GitHub] [drill] arina-ielchiieva commented on issue #1902: DRILL-7448: Fix warnings when running Drill memory tests

2019-11-19 Thread GitBox
arina-ielchiieva commented on issue #1902: DRILL-7448: Fix warnings when running Drill memory tests URL: https://github.com/apache/drill/pull/1902#issuecomment-76350 +1, LGTM. This is an automated message from the Apache

[GitHub] [drill] arina-ielchiieva edited a comment on issue #1902: DRILL-7448: Fix warnings when running Drill memory tests

2019-11-19 Thread GitBox
arina-ielchiieva edited a comment on issue #1902: DRILL-7448: Fix warnings when running Drill memory tests URL: https://github.com/apache/drill/pull/1902#issuecomment-22348 @KazydubB thanks for making the changes. Discussed this issue with @vvysotskyi, it looks like adding janino depen

[GitHub] [drill] agozhiy commented on a change in pull request #1895: DRILL-6540: Upgrade to HADOOP-3.x libraries

2019-11-19 Thread GitBox
agozhiy commented on a change in pull request #1895: DRILL-6540: Upgrade to HADOOP-3.x libraries URL: https://github.com/apache/drill/pull/1895#discussion_r348067739 ## File path: docs/dev/HadoopWinutils.md ## @@ -0,0 +1,11 @@ +## Hadoop Winutils + +Hadoop Winutils native

[GitHub] [drill] agozhiy commented on a change in pull request #1895: DRILL-6540: Upgrade to HADOOP-3.x libraries

2019-11-19 Thread GitBox
agozhiy commented on a change in pull request #1895: DRILL-6540: Upgrade to HADOOP-3.x libraries URL: https://github.com/apache/drill/pull/1895#discussion_r348067839 ## File path: docs/dev/HadoopWinutils.md ## @@ -0,0 +1,11 @@ +## Hadoop Winutils + +Hadoop Winutils native

[GitHub] [drill] paul-rogers commented on a change in pull request #1899: DRILL-7445: Create batch copier based on result set framework

2019-11-19 Thread GitBox
paul-rogers commented on a change in pull request #1899: DRILL-7445: Create batch copier based on result set framework URL: https://github.com/apache/drill/pull/1899#discussion_r348105189 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/protocol/Vector

[GitHub] [drill] paul-rogers commented on a change in pull request #1899: DRILL-7445: Create batch copier based on result set framework

2019-11-19 Thread GitBox
paul-rogers commented on a change in pull request #1899: DRILL-7445: Create batch copier based on result set framework URL: https://github.com/apache/drill/pull/1899#discussion_r348112152 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/resultSet/impl/Resul

[GitHub] [drill] paul-rogers commented on a change in pull request #1899: DRILL-7445: Create batch copier based on result set framework

2019-11-19 Thread GitBox
paul-rogers commented on a change in pull request #1899: DRILL-7445: Create batch copier based on result set framework URL: https://github.com/apache/drill/pull/1899#discussion_r348110561 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/resultSet/impl/Resul

[GitHub] [drill] paul-rogers commented on a change in pull request #1899: DRILL-7445: Create batch copier based on result set framework

2019-11-19 Thread GitBox
paul-rogers commented on a change in pull request #1899: DRILL-7445: Create batch copier based on result set framework URL: https://github.com/apache/drill/pull/1899#discussion_r348113047 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/record/selection/SelectionVec

[GitHub] [drill] paul-rogers commented on a change in pull request #1899: DRILL-7445: Create batch copier based on result set framework

2019-11-19 Thread GitBox
paul-rogers commented on a change in pull request #1899: DRILL-7445: Create batch copier based on result set framework URL: https://github.com/apache/drill/pull/1899#discussion_r348095757 ## File path: common/src/main/java/org/apache/drill/common/types/Types.java ## @@ -80

[GitHub] [drill] paul-rogers commented on a change in pull request #1899: DRILL-7445: Create batch copier based on result set framework

2019-11-19 Thread GitBox
paul-rogers commented on a change in pull request #1899: DRILL-7445: Create batch copier based on result set framework URL: https://github.com/apache/drill/pull/1899#discussion_r348109502 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/resultSet/impl/Resul

[GitHub] [drill] paul-rogers commented on a change in pull request #1899: DRILL-7445: Create batch copier based on result set framework

2019-11-19 Thread GitBox
paul-rogers commented on a change in pull request #1899: DRILL-7445: Create batch copier based on result set framework URL: https://github.com/apache/drill/pull/1899#discussion_r348101045 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/protocol/Vector

[GitHub] [drill] paul-rogers commented on a change in pull request #1899: DRILL-7445: Create batch copier based on result set framework

2019-11-19 Thread GitBox
paul-rogers commented on a change in pull request #1899: DRILL-7445: Create batch copier based on result set framework URL: https://github.com/apache/drill/pull/1899#discussion_r348105915 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/protocol/Vector

[GitHub] [drill] paul-rogers commented on a change in pull request #1899: DRILL-7445: Create batch copier based on result set framework

2019-11-19 Thread GitBox
paul-rogers commented on a change in pull request #1899: DRILL-7445: Create batch copier based on result set framework URL: https://github.com/apache/drill/pull/1899#discussion_r348104135 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/protocol/Vector

[GitHub] [drill] paul-rogers commented on a change in pull request #1899: DRILL-7445: Create batch copier based on result set framework

2019-11-19 Thread GitBox
paul-rogers commented on a change in pull request #1899: DRILL-7445: Create batch copier based on result set framework URL: https://github.com/apache/drill/pull/1899#discussion_r348110343 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/resultSet/impl/Resul

[GitHub] [drill] paul-rogers commented on issue #1896: DRILL-7441: Fix issues with fillEmpties, offset vectors

2019-11-19 Thread GitBox
paul-rogers commented on issue #1896: DRILL-7441: Fix issues with fillEmpties, offset vectors URL: https://github.com/apache/drill/pull/1896#issuecomment-555679746 @vvysotskyi, thanks much for the review. Addressed your comments; please take another look.

[GitHub] [drill] paul-rogers commented on issue #1899: DRILL-7445: Create batch copier based on result set framework

2019-11-19 Thread GitBox
paul-rogers commented on issue #1899: DRILL-7445: Create batch copier based on result set framework URL: https://github.com/apache/drill/pull/1899#issuecomment-555680733 @ihuzenko, thanks for your detailed review. Addressed most of your comments, added explanations for the others. T

HDF5

2019-11-19 Thread Charles Givre
Hi Arina, Paul, I believe I have addressed the comments in the HDF5 reader. Please forgive the piecemeal nature of the commits. I've had an EXTREMELY busy week and only can work on this for a few min here and there. -- C

[jira] [Created] (DRILL-7451) Planner inserts project node even if scan handles project push-down

2019-11-19 Thread Paul Rogers (Jira)
Paul Rogers created DRILL-7451: -- Summary: Planner inserts project node even if scan handles project push-down Key: DRILL-7451 URL: https://issues.apache.org/jira/browse/DRILL-7451 Project: Apache Drill

[GitHub] [drill] arjuntheprogrammer opened a new pull request #1903: Drill 5844

2019-11-19 Thread GitBox
arjuntheprogrammer opened a new pull request #1903: Drill 5844 URL: https://github.com/apache/drill/pull/1903 Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API. According to JDBC API, the typical types are "TABLE", "VIEW", "SYSTEM TABLE", "GL

[GitHub] [drill] arjuntheprogrammer closed pull request #1903: Drill 5844

2019-11-19 Thread GitBox
arjuntheprogrammer closed pull request #1903: Drill 5844 URL: https://github.com/apache/drill/pull/1903 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [drill] ihuzenko commented on a change in pull request #1899: DRILL-7445: Create batch copier based on result set framework

2019-11-19 Thread GitBox
ihuzenko commented on a change in pull request #1899: DRILL-7445: Create batch copier based on result set framework URL: https://github.com/apache/drill/pull/1899#discussion_r348333879 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/resultSet/impl/ResultSe