[GitHub] [drill] cgivre commented on a diff in pull request #2722: DRILL-8371: Add Write/Insert Capability to Splunk Plugin

2022-12-19 Thread GitBox
cgivre commented on code in PR #2722: URL: https://github.com/apache/drill/pull/2722#discussion_r1052352513 ## contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkBatchWriter.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [drill] jnturton commented on a diff in pull request #2722: DRILL-8371: Add Write/Insert Capability to Splunk Plugin

2022-12-19 Thread GitBox
jnturton commented on code in PR #2722: URL: https://github.com/apache/drill/pull/2722#discussion_r1052337380 ## contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkBatchWriter.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software

[GitHub] [drill] jnturton commented on a diff in pull request #2722: DRILL-8371: Add Write/Insert Capability to Splunk Plugin

2022-12-19 Thread GitBox
jnturton commented on code in PR #2722: URL: https://github.com/apache/drill/pull/2722#discussion_r1052328977 ## contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkInsertWriter.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software

[GitHub] [drill] jnturton opened a new pull request, #2724: [BACKPORT-TO-STABLE] Bugfix Release 1.20.3 Phase 3

2022-12-19 Thread GitBox
jnturton opened a new pull request, #2724: URL: https://github.com/apache/drill/pull/2724 # [BACKPORT-TO-STABLE] Bugfix Release 1.20.3 Phase 3 ## Description Merges the following backport-to-stable commits into the 1.20 branch. - 3861abe76 (HEAD -> 1.20, jnturton/1.20)

[GitHub] [drill] jnturton merged pull request #2692: [BACKPORT-TO-STABLE] Bugfix Release 1.20.3 Phase 2

2022-12-19 Thread GitBox
jnturton merged PR #2692: URL: https://github.com/apache/drill/pull/2692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] weijunlu opened a new issue, #2723: Failed to execute an insert statement across the database

2022-12-18 Thread GitBox
weijunlu opened a new issue, #2723: URL: https://github.com/apache/drill/issues/2723 Failed to execute an insert statement across the database. Steps to reproduce the behavior: 1. Prepare the mysql and postgresql table structures and data mysql: create table t1(c1 int, c2

[GitHub] [drill] yaozhu commented on issue #2721: select * from hive ;report refcnt = 0 error

2022-12-18 Thread GitBox
yaozhu commented on issue #2721: URL: https://github.com/apache/drill/issues/2721#issuecomment-1357006842 > Can you tell us the Drill version please? @jnturton u can use drill version such as “Drill 1.20.2 Released” 。 by the way ,the error was not report out every time, but High

[GitHub] [drill] cgivre opened a new pull request, #2722: DRILL-8371: Add Write/Insert Capability to Splunk Plugin

2022-12-16 Thread GitBox
cgivre opened a new pull request, #2722: URL: https://github.com/apache/drill/pull/2722 # [DRILL-8371](https://issues.apache.org/jira/browse/DRILL-8371): Add Write/Append Capability to Splunk Plugin ## Description Adds the ability to create/delete Splunk indexes via CTAS and DROP

[GitHub] [drill] jnturton merged pull request #2713: DRILL-8359: Add mount and unmount command support to the filesystem plugin

2022-12-15 Thread GitBox
jnturton merged PR #2713: URL: https://github.com/apache/drill/pull/2713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] jnturton commented on pull request #2713: DRILL-8359: Add mount and unmount command support to the filesystem plugin

2022-12-15 Thread GitBox
jnturton commented on PR #2713: URL: https://github.com/apache/drill/pull/2713#issuecomment-1353117449 > > @cgivre I've added a boot option that disables mount commands by default. So to make your Drill servers vulnerable to malicious Drill admins you have to set that in drill-override

[GitHub] [drill] cgivre commented on pull request #2713: DRILL-8359: Add mount and unmount command support to the filesystem plugin

2022-12-15 Thread GitBox
cgivre commented on PR #2713: URL: https://github.com/apache/drill/pull/2713#issuecomment-1353007032 > @cgivre I've added a boot option that disables mount commands by default. So to make your Drill servers vulnerable to malicious Drill admins you have to set that in drill-override first.

[GitHub] [drill] jnturton commented on a diff in pull request #2713: DRILL-8359: Add mount and unmount command support to the filesystem plugin

2022-12-15 Thread GitBox
jnturton commented on code in PR #2713: URL: https://github.com/apache/drill/pull/2713#discussion_r1049318599 ## exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemConfig.java: ## @@ -53,18 +53,23 @@ public class FileSystemConfig extends StoragePluginConfig

[GitHub] [drill] jnturton commented on a diff in pull request #2713: DRILL-8359: Add mount and unmount command support to the filesystem plugin

2022-12-14 Thread GitBox
jnturton commented on code in PR #2713: URL: https://github.com/apache/drill/pull/2713#discussion_r1049256392 ## exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemConfig.java: ## @@ -53,18 +53,23 @@ public class FileSystemConfig extends StoragePluginConfig

[GitHub] [drill] jnturton commented on a diff in pull request #2713: DRILL-8359: Add mount and unmount command support to the filesystem plugin

2022-12-14 Thread GitBox
jnturton commented on code in PR #2713: URL: https://github.com/apache/drill/pull/2713#discussion_r1049256392 ## exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemConfig.java: ## @@ -53,18 +53,23 @@ public class FileSystemConfig extends StoragePluginConfig

[GitHub] [drill] cgivre merged pull request #2718: DRILL-8369: Add support for querying DeltaLake snapshots by version

2022-12-14 Thread GitBox
cgivre merged PR #2718: URL: https://github.com/apache/drill/pull/2718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] cgivre merged pull request #2720: Bump commons-net from 3.6 to 3.9.0

2022-12-14 Thread GitBox
cgivre merged PR #2720: URL: https://github.com/apache/drill/pull/2720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] jnturton commented on pull request #2713: DRILL-8359: Add mount and unmount command support to the filesystem plugin

2022-12-14 Thread GitBox
jnturton commented on PR #2713: URL: https://github.com/apache/drill/pull/2713#issuecomment-1351106936 @cgivre I've added a boot option that disables mount commands by default. So to make your Drill servers vulnerable to malicious Drill admins you have to set that in drill-override first.

[GitHub] [drill] spydev commented on issue #2440: IllegalArgumentException: databaseName can not be null - Mongo DB

2022-12-14 Thread GitBox
spydev commented on issue #2440: URL: https://github.com/apache/drill/issues/2440#issuecomment-1350676336 > What was the alternative? No alternate considered, I then redirected myself for more optimization of data queries and for the time being my slow queries issues resolved but on

[GitHub] [drill] jnturton commented on issue #2440: IllegalArgumentException: databaseName can not be null - Mongo DB

2022-12-14 Thread GitBox
jnturton commented on issue #2440: URL: https://github.com/apache/drill/issues/2440#issuecomment-1350623434 Can you attach the full JSON query profile ? It's available in the Drill web UI at Profiles -> [Select your query] -> JSON Profile. It probably won't include sensitive information

[GitHub] [drill] sid-viadots commented on issue #2440: IllegalArgumentException: databaseName can not be null - Mongo DB

2022-12-13 Thread GitBox
sid-viadots commented on issue #2440: URL: https://github.com/apache/drill/issues/2440#issuecomment-1350570353 Yes. Similar error happens for other queries where 3 tables are used. Never produced for 2 table queries. -- This is an automated message from the Apache Git Service. To

[GitHub] [drill] jnturton commented on issue #2440: IllegalArgumentException: databaseName can not be null - Mongo DB

2022-12-13 Thread GitBox
jnturton commented on issue #2440: URL: https://github.com/apache/drill/issues/2440#issuecomment-135092 And do any of these queries succeed? I'm trying to understand if the storage plugin configuration works at all. ``` select * from mongo.db.drs limit 10; select * from

[GitHub] [drill] jnturton commented on issue #2721: select * from hive ;report refcnt = 0 error

2022-12-13 Thread GitBox
jnturton commented on issue #2721: URL: https://github.com/apache/drill/issues/2721#issuecomment-1350523375 Can you tell us the Drill version please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [drill] sid-viadots commented on issue #2440: IllegalArgumentException: databaseName can not be null - Mongo DB

2022-12-13 Thread GitBox
sid-viadots commented on issue #2440: URL: https://github.com/apache/drill/issues/2440#issuecomment-1350513703 Query is something like this. SELECT count(*) AS `count` FROM (WITH drs as (SELECT d.10.1.1 as 1011, d.1, 2, d.2,

[GitHub] [drill] yaozhu commented on issue #2721: select * from hive ;report refcnt = 0 error

2022-12-13 Thread GitBox
yaozhu commented on issue #2721: URL: https://github.com/apache/drill/issues/2721#issuecomment-1350239242 > @yaozhu Would you mind running this query again with verbose error reporting on and then posting the full stack trace? > > You can turn on the error reporting with

[GitHub] [drill] cgivre commented on issue #2721: select * from hive ;report refcnt = 0 error

2022-12-13 Thread GitBox
cgivre commented on issue #2721: URL: https://github.com/apache/drill/issues/2721#issuecomment-1350230062 @yaozhu Would you mind running this query again with verbose error reporting on and then posting the full stack trace? You can turn on the error reporting with the command:

[GitHub] [drill] yaozhu opened a new issue, #2721: select * from hive ;report refcnt = 0 error

2022-12-13 Thread GitBox
yaozhu opened a new issue, #2721: URL: https://github.com/apache/drill/issues/2721 create table in hive schame by drill as follows: create table hive.t (a string ,b string, c string) insert value lengths should longer than 256 words eg: insert into hive.t

[GitHub] [drill] dependabot[bot] opened a new pull request, #2720: Bump commons-net from 3.6 to 3.9.0

2022-12-13 Thread GitBox
dependabot[bot] opened a new pull request, #2720: URL: https://github.com/apache/drill/pull/2720 Bumps commons-net from 3.6 to 3.9.0. [![Dependabot compatibility

[GitHub] [drill] cgivre commented on a diff in pull request #2718: DRILL-8369: Add support for querying DeltaLake snapshots by version

2022-12-13 Thread GitBox
cgivre commented on code in PR #2718: URL: https://github.com/apache/drill/pull/2718#discussion_r1047310929 ## contrib/format-deltalake/src/main/java/org/apache/drill/exec/store/delta/format/DeltaFormatPluginConfig.java: ## @@ -18,15 +18,55 @@ package

[GitHub] [drill] vvysotskyi commented on a diff in pull request #2718: DRILL-8369: Add support for querying DeltaLake snapshots by version

2022-12-13 Thread GitBox
vvysotskyi commented on code in PR #2718: URL: https://github.com/apache/drill/pull/2718#discussion_r1047307275 ## contrib/format-deltalake/src/main/java/org/apache/drill/exec/store/delta/format/DeltaFormatPluginConfig.java: ## @@ -18,15 +18,55 @@ package

[GitHub] [drill] pjfanning commented on a diff in pull request #2718: DRILL-8369: Add support for querying DeltaLake snapshots by version

2022-12-13 Thread GitBox
pjfanning commented on code in PR #2718: URL: https://github.com/apache/drill/pull/2718#discussion_r1047285109 ## contrib/format-deltalake/src/main/java/org/apache/drill/exec/store/delta/format/DeltaFormatPluginConfig.java: ## @@ -18,15 +18,55 @@ package

[GitHub] [drill] jnturton merged pull request #2719: DRILL-8370: Upgrade splunk-sdk-java to 1.9.3

2022-12-13 Thread GitBox
jnturton merged PR #2719: URL: https://github.com/apache/drill/pull/2719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] jnturton commented on pull request #2719: DRILL-8370: Upgrade splunk-sdk-java to 1.9.3

2022-12-13 Thread GitBox
jnturton commented on PR #2719: URL: https://github.com/apache/drill/pull/2719#issuecomment-1348668638 @cgivre okay the last commit may have gotten rid of those sporadic CI failures 爛. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [drill] jnturton commented on issue #2440: IllegalArgumentException: databaseName can not be null - Mongo DB

2022-12-13 Thread GitBox
jnturton commented on issue #2440: URL: https://github.com/apache/drill/issues/2440#issuecomment-1348153403 @sid-viadots what is the query that you're running when you encounter that error? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [drill] vvysotskyi commented on a diff in pull request #2718: DRILL-8369: Add support for querying DeltaLake snapshots by version

2022-12-13 Thread GitBox
vvysotskyi commented on code in PR #2718: URL: https://github.com/apache/drill/pull/2718#discussion_r1046827000 ## contrib/format-deltalake/src/main/java/org/apache/drill/exec/store/delta/format/DeltaFormatPluginConfig.java: ## @@ -18,15 +18,55 @@ package

[GitHub] [drill] pjfanning commented on a diff in pull request #2718: DRILL-8369: Add support for querying DeltaLake snapshots by version

2022-12-13 Thread GitBox
pjfanning commented on code in PR #2718: URL: https://github.com/apache/drill/pull/2718#discussion_r1046793510 ## contrib/format-deltalake/src/main/java/org/apache/drill/exec/store/delta/format/DeltaFormatPluginConfig.java: ## @@ -18,15 +18,55 @@ package

[GitHub] [drill] vvysotskyi commented on a diff in pull request #2718: DRILL-8369: Add support for querying DeltaLake snapshots by version

2022-12-13 Thread GitBox
vvysotskyi commented on code in PR #2718: URL: https://github.com/apache/drill/pull/2718#discussion_r1046773655 ## contrib/format-deltalake/src/main/java/org/apache/drill/exec/store/delta/format/DeltaFormatPluginConfig.java: ## @@ -18,15 +18,55 @@ package

[GitHub] [drill] sid-viadots commented on issue #2440: IllegalArgumentException: databaseName can not be null - Mongo DB

2022-12-12 Thread GitBox
sid-viadots commented on issue #2440: URL: https://github.com/apache/drill/issues/2440#issuecomment-1347759839 Mongo config { "type": "mongo", "connection": "mongodb+srv://username:passw...@clouddb.mongodb.net/dbname", "pluginOptimizations": {

[GitHub] [drill] cgivre commented on a diff in pull request #2718: DRILL-8369: Add support for querying DeltaLake snapshots by version

2022-12-12 Thread GitBox
cgivre commented on code in PR #2718: URL: https://github.com/apache/drill/pull/2718#discussion_r1046647612 ## contrib/format-deltalake/src/main/java/org/apache/drill/exec/store/delta/format/DeltaFormatPluginConfig.java: ## @@ -18,15 +18,55 @@ package

[GitHub] [drill] vvysotskyi commented on a diff in pull request #2709: DRILL-8358: Storage plugin for querying other Apache Drill clusters

2022-12-12 Thread GitBox
vvysotskyi commented on code in PR #2709: URL: https://github.com/apache/drill/pull/2709#discussion_r1046390848 ## contrib/storage-drill/src/test/java/org/apache/drill/exec/store/drill/plugin/DrillPluginQueriesTest.java: ## @@ -0,0 +1,312 @@ +/* + * Licensed to the Apache

[GitHub] [drill] cgivre merged pull request #2709: DRILL-8358: Storage plugin for querying other Apache Drill clusters

2022-12-12 Thread GitBox
cgivre merged PR #2709: URL: https://github.com/apache/drill/pull/2709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] github-code-scanning[bot] commented on a diff in pull request #2719: DRILL-8370: Upgrade splunk-sdk-java to 1.9.3

2022-12-12 Thread GitBox
github-code-scanning[bot] commented on code in PR #2719: URL: https://github.com/apache/drill/pull/2719#discussion_r1046056001 ## contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkConnection.java: ## @@ -152,4 +172,45 @@ public EntityCollection

[GitHub] [drill] cgivre commented on pull request #2719: DRILL-8370: Upgrade splunk-sdk-java to 1.9.3

2022-12-12 Thread GitBox
cgivre commented on PR #2719: URL: https://github.com/apache/drill/pull/2719#issuecomment-1346705339 Just noting here for future reference, but here is the issue on Splunk's SDK that references the SSL issue: https://github.com/splunk/splunk-sdk-java/issues/204 -- This is an

[GitHub] [drill] jnturton commented on pull request #2719: DRILL-8370: Upgrade splunk-sdk-java to 1.9.3

2022-12-12 Thread GitBox
jnturton commented on PR #2719: URL: https://github.com/apache/drill/pull/2719#issuecomment-1346704255 The latest commit adds a patch for Splunk's broken validateCertificates toggle by @cgivre. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [drill] jnturton commented on a diff in pull request #2709: DRILL-8358: Storage plugin for querying other Apache Drill clusters

2022-12-12 Thread GitBox
jnturton commented on code in PR #2709: URL: https://github.com/apache/drill/pull/2709#discussion_r1039337680 ## contrib/storage-drill/src/test/java/org/apache/drill/exec/store/drill/plugin/DrillPluginQueriesTest.java: ## @@ -0,0 +1,312 @@ +/* + * Licensed to the Apache

[GitHub] [drill] jnturton opened a new pull request, #2719: DRILL-8370: Upgrade splunk-sdk-java to 1.9.3

2022-12-12 Thread GitBox
jnturton opened a new pull request, #2719: URL: https://github.com/apache/drill/pull/2719 # [DRILL-8370](https://issues.apache.org/jira/browse/DRILL-8370): Upgrade splunk-sdk-java to 1.9.3 ## Description Changes in splunk-sdk-java since 1.9.1. > Minor Changes >

[GitHub] [drill] jnturton commented on pull request #2705: DRILL-8357: Add new config options to the Splunk storage plugin

2022-12-12 Thread GitBox
jnturton commented on PR #2705: URL: https://github.com/apache/drill/pull/2705#issuecomment-1346461462 @kingswanwho please note the backport label I just added to this merged PR and also to #2706. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [drill] jnturton commented on issue #2440: IllegalArgumentException: databaseName can not be null - Mongo DB

2022-12-12 Thread GitBox
jnturton commented on issue #2440: URL: https://github.com/apache/drill/issues/2440#issuecomment-1346338172 Reading the comments here, it looks to me like different issues have been encountered by different commenters. If you're using the latest release of Drill and can share config and

[GitHub] [drill] sid-viadots commented on issue #2440: IllegalArgumentException: databaseName can not be null - Mongo DB

2022-12-12 Thread GitBox
sid-viadots commented on issue #2440: URL: https://github.com/apache/drill/issues/2440#issuecomment-1346330273 What was the alternative? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [drill] spydev commented on issue #2440: IllegalArgumentException: databaseName can not be null - Mongo DB

2022-12-12 Thread GitBox
spydev commented on issue #2440: URL: https://github.com/apache/drill/issues/2440#issuecomment-1346133035 for me, It didn't work. I stopped using drill -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [drill] sid-viadots commented on issue #2440: IllegalArgumentException: databaseName can not be null - Mongo DB

2022-12-11 Thread GitBox
sid-viadots commented on issue #2440: URL: https://github.com/apache/drill/issues/2440#issuecomment-1345986255 Any update on this? Still getting the same error!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [drill] cgivre merged pull request #2714: DRILL-8364: Add Support for OAuth Enabled File Systems

2022-12-10 Thread GitBox
cgivre merged PR #2714: URL: https://github.com/apache/drill/pull/2714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] cgivre commented on a diff in pull request #2714: DRILL-8364: Add Support for OAuth Enabled File Systems

2022-12-10 Thread GitBox
cgivre commented on code in PR #2714: URL: https://github.com/apache/drill/pull/2714#discussion_r1045149074 ## exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemSchemaFactory.java: ## @@ -82,13 +83,21 @@ public class FileSystemSchema extends AbstractSchema

[GitHub] [drill] vvysotskyi opened a new pull request, #2718: DRILL-8369: Add support for querying DeltaLake snapshots by version

2022-12-10 Thread GitBox
vvysotskyi opened a new pull request, #2718: URL: https://github.com/apache/drill/pull/2718 # [DRILL-8369](https://issues.apache.org/jira/browse/DRILL-8369): Add support for querying DeltaLake snapshots by version ## Description Added functionality for querying specific Delta Lake

[GitHub] [drill] jnturton commented on a diff in pull request #2714: DRILL-8364: Add Support for OAuth Enabled File Systems

2022-12-09 Thread GitBox
jnturton commented on code in PR #2714: URL: https://github.com/apache/drill/pull/2714#discussion_r1044992012 ## exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemSchemaFactory.java: ## @@ -82,13 +83,21 @@ public class FileSystemSchema extends

[GitHub] [drill] jnturton commented on a diff in pull request #2714: DRILL-8364: Add Support for OAuth Enabled File Systems

2022-12-09 Thread GitBox
jnturton commented on code in PR #2714: URL: https://github.com/apache/drill/pull/2714#discussion_r1044990682 ## exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/SeekableByteArrayInputStream.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software

[GitHub] [drill] vvysotskyi commented on pull request #2709: DRILL-8358: Storage plugin for querying other Apache Drill clusters

2022-12-09 Thread GitBox
vvysotskyi commented on PR #2709: URL: https://github.com/apache/drill/pull/2709#issuecomment-1344035229 @cgivre, yes, you can create a plugin in drill1 with the name drill2, and query all plugins that drill2 has configured from drill1, so if drill2 has file system plugin called dfs2,

[GitHub] [drill] vvysotskyi commented on a diff in pull request #2709: DRILL-8358: Storage plugin for querying other Apache Drill clusters

2022-12-09 Thread GitBox
vvysotskyi commented on code in PR #2709: URL: https://github.com/apache/drill/pull/2709#discussion_r1044224231 ## contrib/storage-drill/src/main/java/org/apache/drill/exec/store/drill/plugin/DrillSubScan.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software

[GitHub] [drill] cgivre commented on a diff in pull request #2709: DRILL-8358: Storage plugin for querying other Apache Drill clusters

2022-12-08 Thread GitBox
cgivre commented on code in PR #2709: URL: https://github.com/apache/drill/pull/2709#discussion_r1036638344 ## contrib/storage-drill/src/main/java/org/apache/drill/exec/store/drill/plugin/DrillSubScan.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [drill] vvysotskyi commented on a diff in pull request #2709: DRILL-8358: Storage plugin for querying other Apache Drill clusters

2022-12-08 Thread GitBox
vvysotskyi commented on code in PR #2709: URL: https://github.com/apache/drill/pull/2709#discussion_r1043755276 ## contrib/storage-drill/src/main/java/org/apache/drill/exec/store/drill/plugin/DrillStoragePluginConfig.java: ## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache

[GitHub] [drill] cgivre commented on a diff in pull request #2714: DRILL-8364: Add Support for OAuth Enabled File Systems

2022-12-08 Thread GitBox
cgivre commented on code in PR #2714: URL: https://github.com/apache/drill/pull/2714#discussion_r1043748748 ## exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/SeekableByteArrayInputStream.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [drill] cgivre merged pull request #2717: DRILL-8368: Update Yauaa to 7.9.0

2022-12-08 Thread GitBox
cgivre merged PR #2717: URL: https://github.com/apache/drill/pull/2717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] cgivre commented on a diff in pull request #2714: DRILL-8364: Add Support for OAuth Enabled File Systems

2022-12-08 Thread GitBox
cgivre commented on code in PR #2714: URL: https://github.com/apache/drill/pull/2714#discussion_r1043592053 ## exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/BoxFileSystem.java: ## @@ -0,0 +1,459 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [drill] jnturton commented on a diff in pull request #2714: DRILL-8364: Add Support for OAuth Enabled File Systems

2022-12-08 Thread GitBox
jnturton commented on code in PR #2714: URL: https://github.com/apache/drill/pull/2714#discussion_r1042270417 ## exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/BoxFileSystem.java: ## @@ -0,0 +1,459 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [drill] nielsbasjes opened a new pull request, #2717: DRILL-8368: Update Yauaa to 7.9.0

2022-12-08 Thread GitBox
nielsbasjes opened a new pull request, #2717: URL: https://github.com/apache/drill/pull/2717 # [DRILL-8368](https://issues.apache.org/jira/browse/DRILL-8368): Updating Yauaa to 7.9.0 ## Description Updating dependency -- This is an automated message from the Apache Git

[GitHub] [drill-test-framework] Agirish merged pull request #4: Bump httpclient from 4.5.5 to 4.5.13 in /framework

2022-12-07 Thread GitBox
Agirish merged PR #4: URL: https://github.com/apache/drill-test-framework/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] jnturton commented on pull request #2714: DRILL-8364: Add Support for OAuth Enabled File Systems

2022-12-07 Thread GitBox
jnturton commented on PR #2714: URL: https://github.com/apache/drill/pull/2714#issuecomment-1341006745 > @jnturton I don't know. Unlike the regular storage plugins, which are pretty self-contained, to use a file system, you have to "register" it in the `FileSystemPlugin` class.

[GitHub] [drill] cgivre commented on pull request #2714: DRILL-8364: Add Support for OAuth Enabled File Systems

2022-12-07 Thread GitBox
cgivre commented on PR #2714: URL: https://github.com/apache/drill/pull/2714#issuecomment-1340938156 > @jnturton I don't know. Unlike the regular storage plugins, which are pretty self-contained, to use a file system, you have to "register" it in the `FileSystemPlugin` class.

[GitHub] [drill] jnturton commented on pull request #2714: DRILL-8364: Add Support for OAuth Enabled File Systems

2022-12-06 Thread GitBox
jnturton commented on PR #2714: URL: https://github.com/apache/drill/pull/2714#issuecomment-1340417592 Would it be possible, for the sake of structuring the code base, to move the Box and Dropbox filesystem implementations out to contrib/storage-box and contrib/storage-dropbox modules

[GitHub] [drill] cgivre merged pull request #2716: DRILL-8366: Late release of compressor memory in the Parquet writer

2022-12-06 Thread GitBox
cgivre merged PR #2716: URL: https://github.com/apache/drill/pull/2716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] cgivre commented on pull request #2713: DRILL-8359: Add mount and unmount command support to the filesystem plugin

2022-12-06 Thread GitBox
cgivre commented on PR #2713: URL: https://github.com/apache/drill/pull/2713#issuecomment-1339798220 > @cgivre > > > I guess my first question is whose permissions will these commands run under? > > Another thing to think about is making sure that users can't arbitrarily add this

[GitHub] [drill] jnturton opened a new pull request, #2716: DRILL-8366: Late release of compressor memory in the Parquet writer

2022-12-06 Thread GitBox
jnturton opened a new pull request, #2716: URL: https://github.com/apache/drill/pull/2716 # [DRILL-8366](https://issues.apache.org/jira/browse/DRILL-8366): Late release of compressor memory in the Parquet writer ## Description The Parquet writer waits until the end of the

[GitHub] [drill] jnturton commented on pull request #2713: DRILL-8359: Add mount and unmount command support to the filesystem plugin

2022-12-06 Thread GitBox
jnturton commented on PR #2713: URL: https://github.com/apache/drill/pull/2713#issuecomment-1339255735 @cgivre > I guess my first question is whose permissions will these commands run under? > Another thing to think about is making sure that users can't arbitrarily add this code

[GitHub] [drill] cgivre commented on pull request #2713: DRILL-8359: Add mount and unmount command support to the filesystem plugin

2022-12-06 Thread GitBox
cgivre commented on PR #2713: URL: https://github.com/apache/drill/pull/2713#issuecomment-1339182473 @jnturton I guess my first question is whose permissions will these commands run under? Are we impersonating the user for them? I do like the idea of adding a boot level option to

[GitHub] [drill] jnturton commented on pull request #2713: DRILL-8359: Add mount and unmount command support to the filesystem plugin

2022-12-06 Thread GitBox
jnturton commented on PR #2713: URL: https://github.com/apache/drill/pull/2713#issuecomment-1339169730 @cgivre @vvysotskyi before I come and fix the unit test failures here, what is a good road forward as far as security goes? 1. Make this feature disabled by default with a boot

[GitHub] [drill] vvysotskyi commented on issue #2693: Order by expression failed to execute in mysql plugin

2022-12-05 Thread GitBox
vvysotskyi commented on issue #2693: URL: https://github.com/apache/drill/issues/2693#issuecomment-1337940517 @jnturton, bot sure why, but the query above worked fine after disabling only_full_group_by. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [drill] cgivre closed issue #2701: Http Storage Plugins need reorder "tail" and paginator parameters

2022-12-05 Thread GitBox
cgivre closed issue #2701: Http Storage Plugins need reorder "tail" and paginator parameters URL: https://github.com/apache/drill/issues/2701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [drill] cgivre merged pull request #2715: DRILL-8365: HTTP Plugin Places Parameters in Wrong Place

2022-12-05 Thread GitBox
cgivre merged PR #2715: URL: https://github.com/apache/drill/pull/2715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] jnturton commented on issue #2693: Order by expression failed to execute in mysql plugin

2022-12-05 Thread GitBox
jnturton commented on issue #2693: URL: https://github.com/apache/drill/issues/2693#issuecomment-1337217929 This feels like a bit of a blind spot in MySQL to me. [The docs say](https://dev.mysql.com/doc/refman/5.7/en/group-by-handling.html) that since 5.7.5 MySQL has detected functional

[GitHub] [drill] cgivre commented on issue #2701: Http Storage Plugins need reorder "tail" and paginator parameters

2022-12-04 Thread GitBox
cgivre commented on issue #2701: URL: https://github.com/apache/drill/issues/2701#issuecomment-1336515492 Hi @xqgzh I just submitted a bug fix for this. If you could take a look and review, I'd really appreciate it. -- This is an automated message from the Apache Git Service. To

[GitHub] [drill] cgivre opened a new pull request, #2715: DRILL-8365: HTTP Plugin Places Parameters in Wrong Place

2022-12-04 Thread GitBox
cgivre opened a new pull request, #2715: URL: https://github.com/apache/drill/pull/2715 # [DRILL-8365](https://issues.apache.org/jira/browse/DRILL-8365): HTTP Plugin Places Parameters in Wrong Place ## Description This PR fixes a bug when a user configures a HTTP plugin with the

[GitHub] [drill] vvysotskyi commented on issue #2693: Order by expression failed to execute in mysql plugin

2022-12-03 Thread GitBox
vvysotskyi commented on issue #2693: URL: https://github.com/apache/drill/issues/2693#issuecomment-1336325999 There are several ways to do that. Here are some examples: https://stackoverflow.com/questions/23921117/disable-only-full-group-by -- This is an automated message from the Apache

[GitHub] [drill] cgivre opened a new pull request, #2714: DRILL-8364: Add Support for OAuth Enabled File Systems

2022-12-03 Thread GitBox
cgivre opened a new pull request, #2714: URL: https://github.com/apache/drill/pull/2714 # [DRILL-8364](https://issues.apache.org/jira/browse/DRILL-8364): Add Support for OAuth Enabled File Systems ## Description This PR adds support for Drill to query file systems which use OAuth

[GitHub] [drill] cgivre commented on issue #2693: Order by expression failed to execute in mysql plugin

2022-12-03 Thread GitBox
cgivre commented on issue #2693: URL: https://github.com/apache/drill/issues/2693#issuecomment-1336277574 Thanks @vvysotskyi . Can you explain to to disable the `sql_mode`? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [drill] vvysotskyi commented on issue #2693: Order by expression failed to execute in mysql plugin

2022-12-03 Thread GitBox
vvysotskyi commented on issue #2693: URL: https://github.com/apache/drill/issues/2693#issuecomment-1336197613 Drill (actually Calcite) rewrites the query to use the expression specified in the project in the `GROUP BY` and `ORDER BY` statements. It is done so because some databases don't

[GitHub] [drill] kmatt commented on pull request #2702: DRILL-8353: Format plugin for Delta Lake

2022-12-02 Thread GitBox
kmatt commented on PR #2702: URL: https://github.com/apache/drill/pull/2702#issuecomment-1335803778 @cgivre @vvysotskyi Thanks, I missed the "will be" clause ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [drill] cgivre commented on pull request #2702: DRILL-8353: Format plugin for Delta Lake

2022-12-02 Thread GitBox
cgivre commented on PR #2702: URL: https://github.com/apache/drill/pull/2702#issuecomment-1335460790 @kmatt This hasn't been implemented yet. That's why the query doesn't yet work. @vvysotskyi is working on that. :-) -- This is an automated message from the Apache Git Service. To

[GitHub] [drill] kmatt commented on pull request #2702: DRILL-8353: Format plugin for Delta Lake

2022-12-02 Thread GitBox
kmatt commented on PR #2702: URL: https://github.com/apache/drill/pull/2702#issuecomment-1335452201 The version function seems not to parse: ``` apache drill (dfs.delta)> select count(*) from table(dfs.delta.`delta_table`(type => 'delta')); ++ | EXPR$0 |

[GitHub] [drill] vvysotskyi commented on pull request #2702: DRILL-8353: Format plugin for Delta Lake

2022-12-01 Thread GitBox
vvysotskyi commented on PR #2702: URL: https://github.com/apache/drill/pull/2702#issuecomment-1334839612 Hi @kmatt, no, it is not supported yet, but will be added in the near future. The version will be specified using the table function. Here is the example query for it: ```sql

[GitHub] [drill] kmatt commented on pull request #2702: DRILL-8353: Format plugin for Delta Lake

2022-12-01 Thread GitBox
kmatt commented on PR #2702: URL: https://github.com/apache/drill/pull/2702#issuecomment-1334708491 @vvysotskyi Does this support VERSION AS OF queries? https://docs.delta.io/latest/quick-start.html#read-older-versions-of-data-using-time-travel Ex: `SELECT * FROM

[GitHub] [drill] cgivre commented on a diff in pull request #2713: DRILL-8359: Add mount and unmount command support to the filesystem plugin

2022-12-01 Thread GitBox
cgivre commented on code in PR #2713: URL: https://github.com/apache/drill/pull/2713#discussion_r1037418363 ## contrib/storage-splunk/pom.xml: ## @@ -42,7 +42,7 @@ com.splunk splunk - 1.9.1 + 1.9.2 Review Comment: Do we want to include the

[GitHub] [drill] jnturton opened a new pull request, #2713: DRILL-8359: Add mount and unmount command support to the filesystem plugin

2022-12-01 Thread GitBox
jnturton opened a new pull request, #2713: URL: https://github.com/apache/drill/pull/2713 # [DRILL-8359](https://issues.apache.org/jira/browse/DRILL-8359): Add mount and unmount command support to the filesystem plugin ## Description Optional mount and unmount commands are

[GitHub] [drill] jnturton commented on a diff in pull request #2709: DRILL-8358: Storage plugin for querying other Apache Drill clusters

2022-12-01 Thread GitBox
jnturton commented on code in PR #2709: URL: https://github.com/apache/drill/pull/2709#discussion_r1037061461 ## contrib/storage-drill/src/main/java/org/apache/drill/exec/store/drill/plugin/DrillStoragePluginConfig.java: ## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache

[GitHub] [drill] jnturton commented on a diff in pull request #2709: DRILL-8358: Storage plugin for querying other Apache Drill clusters

2022-12-01 Thread GitBox
jnturton commented on code in PR #2709: URL: https://github.com/apache/drill/pull/2709#discussion_r1037061461 ## contrib/storage-drill/src/main/java/org/apache/drill/exec/store/drill/plugin/DrillStoragePluginConfig.java: ## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache

[GitHub] [drill] cgivre merged pull request #2712: DRILL-8363: upgrade postgresql to 42.4.3 due to security issue

2022-11-30 Thread GitBox
cgivre merged PR #2712: URL: https://github.com/apache/drill/pull/2712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] kmatt commented on pull request #2702: DRILL-8353: Format plugin for Delta Lake

2022-11-29 Thread GitBox
kmatt commented on PR #2702: URL: https://github.com/apache/drill/pull/2702#issuecomment-1331605371 On Windows 10 `git clone` fails due to a path length in this patch. Repo clones successfully on Debian 11. ``` git clone https://github.com/apache/drill.git Cloning into

[GitHub] [drill] pjfanning opened a new pull request, #2712: upgrade postgresql to 42.4.3 due to security issue

2022-11-29 Thread GitBox
pjfanning opened a new pull request, #2712: URL: https://github.com/apache/drill/pull/2712 https://github.com/advisories/GHSA-562r-vg33-8x8h # [DRILL-](https://issues.apache.org/jira/browse/DRILL-): PR Title (Please replace `PR Title` with actual PR Title) ##

[GitHub] [drill] cgivre merged pull request #2711: DRILL-8362: bump excel-streaming-reader to v4.0.5

2022-11-29 Thread GitBox
cgivre merged PR #2711: URL: https://github.com/apache/drill/pull/2711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] pjfanning opened a new pull request, #2711: DRILL-8362: bump excel-streaming-reader to v4.0.5

2022-11-29 Thread GitBox
pjfanning opened a new pull request, #2711: URL: https://github.com/apache/drill/pull/2711 ## Description A couple of small bugs fixed. Ones that may not actually affect Drill usage but still tidier to upgrade. ## Documentation (Please describe user-visible changes similar

[GitHub] [drill] cgivre merged pull request #2710: DRILL-8360: Add Provided Schema for XML Reader

2022-11-28 Thread GitBox
cgivre merged PR #2710: URL: https://github.com/apache/drill/pull/2710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] cgivre commented on a diff in pull request #2710: DRILL-8360: Add Provided Schema for XML Reader

2022-11-28 Thread GitBox
cgivre commented on code in PR #2710: URL: https://github.com/apache/drill/pull/2710#discussion_r1033690003 ## contrib/format-xml/src/main/java/org/apache/drill/exec/store/xml/XMLReader.java: ## @@ -428,8 +435,67 @@ private void writeFieldData(String fieldName, String

<    1   2   3   4   5   6   7   8   9   10   >