Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/671
Agreed with your comment about the importance of doing calcite rebasing.
AFAIK, someone(s) else in Ukraine have been working on calcite rebasing for a
while. Last time I heard is they managed
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/671#discussion_r91389995
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/cost/DrillRelMdDistinctRowCount.java
---
@@ -43,6 +48,30 @@ public Double
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/671
@jacques-n , CachingRelMetadataProvider provides caching capability per
meta-method / rel node [1]. Since Drill logical rel (DrillJoinRel) and Drill
physical rel (JoinPrel) are different rels
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/646
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/637
@amansinha100 , @parthchandra , I pushed three commits, to address the
review comments, and add one option. Please kindly take another look at the
commits. Thanks!
---
If your project is set up
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/637#discussion_r86488578
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/RangeExprEvaluator.java
---
@@ -0,0 +1,282 @@
+/**
+ * Licensed
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/637#discussion_r86487867
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/PlannerPhase.java ---
@@ -346,6 +355,20 @@ static RuleSet getPruneScanRules
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/637#discussion_r86465657
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/stat/ParquetMetaStatCollector.java
---
@@ -0,0 +1,146
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/637#discussion_r86459835
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/stat/ParquetFooterStatCollector.java
---
@@ -0,0 +1,176
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/637#discussion_r86455969
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRGFilterEvaluator.java
---
@@ -0,0 +1,252 @@
+/**
+ * Licensed
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/637#discussion_r86455871
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -1000,6 +1053,81 @@ public long getColumnValueCount
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/637#discussion_r86449453
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -1000,6 +1053,81 @@ public long getColumnValueCount
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/637#discussion_r86444637
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetCompareFunctionProcessor.java
---
@@ -0,0 +1,280
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/637#discussion_r86444051
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -77,7 +78,7 @@
public class Metadata {
static
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/560
+1
The revised patch looks good to me. @arina-ielchiieva , thanks for your
pull request!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/560#discussion_r86382118
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java ---
@@ -445,11 +447,16 @@ public PartitionExplorer
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/611
+1
Look good to me.
Very good documentation of design and configuration parameters.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/560#discussion_r85989838
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/interpreter/InterpreterEvaluator.java
---
@@ -378,8 +388,14 @@ public ValueHolder
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/637
Drill 1950 : Parquet row group filter pushdown.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jinfengni/incubator-drill DRILL-1950
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/584
+1
@zbdzzg , thanks for the patch!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/628
+1
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/629
DRILL-4967: Adding template_name to source code generated using freemâ¦
â¦arker template.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/629
@amansinha100 , could you please review this PR? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/584
The fix looks fine to me. But do you plan to add a unit test case? thx.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/584#discussion_r84831079
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/validate/IteratorValidatorBatchIterator.java
---
@@ -301,7 +301,7 @@ public
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/584#discussion_r84801937
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/validate/IteratorValidatorBatchIterator.java
---
@@ -301,7 +301,7 @@ public
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r83335982
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetGroupScan.java
---
@@ -117,4 +119,18 @@ public void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r83334160
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java
---
@@ -115,17 +118,30 @@
public
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r83335915
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetGroupScan.java
---
@@ -117,4 +119,18 @@ public void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r83335163
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetRecordReaderTest.java
---
@@ -637,7 +637,7 @@ public void testPerformance
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r83339590
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -913,19 +928,25 @@ public GroupScan applyLimit(long
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r83334623
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java
---
@@ -139,6 +155,11 @@ public
Github user jinfengni closed the pull request at:
https://github.com/apache/drill/pull/471
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/471
Close this PR as it has been merged to Drill.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jinfengni closed the pull request at:
https://github.com/apache/drill/pull/342
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/342
Close this PR, as the patch has been merged to Drill.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/328
this PR has been merged to drill 1.6.0. Close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jinfengni closed the pull request at:
https://github.com/apache/drill/pull/328
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r81245030
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -864,6 +872,14 @@ public String getDigest
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/597
+1
LGTM.
If possible, please run a performance workload. The patch supposedly
should not impact the performance workload. But in case I might miss something,
it would be good
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r81196419
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -894,11 +910,21 @@ public GroupScan clone(List
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r81196052
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -926,16 +952,22 @@ public GroupScan applyLimit(long
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r81194437
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -926,16 +944,22 @@ public GroupScan applyLimit(long
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/599
DRILL-4911: Avoid plan serialization in SimpleParallelizer when debuâ¦
â¦g logging is not enabled.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r80970307
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -115,6 +115,8 @@
private List rowGroupInfos
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r80968936
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -125,13 +125,14 @@
String
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r80968605
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -125,13 +125,14 @@
String
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r80796011
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -115,6 +115,8 @@
private List rowGroupInfos
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/597
comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r80754698
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetScanBatchCreator.java
---
@@ -107,7 +107,7 @@ public ScanBatch getBatch
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r80608344
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetScanBatchCreator.java
---
@@ -107,7 +107,7 @@ public ScanBatch getBatch
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r80606955
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -115,6 +115,8 @@
private List rowGroupInfos
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/583
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/575
+1
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/575#discussion_r75964268
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -173,8 +173,18 @@ public ParquetGroupScan
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/575#discussion_r75963852
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
---
@@ -520,4 +531,10 @@ private static boolean
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/569
+1
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/569#discussion_r75037246
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -470,41 +483,38 @@ private ParquetTableMetadataBase
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/566
+1
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/517
I'll make minor change to the commit based on Aman's comment, and re-run
regression and merge if everything is fine.
---
If your project is set up for it, you can reply to this email and have
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/562
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/562#discussion_r73969588
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/ExcessiveExchangeIdentifier.java
---
@@ -72,6 +73,47 @@ public Prel
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/517
Since we will have a discussion for long term plan of decimal type support
(tomorrow hangout), I think it makes sense to apply a small-scoped change to
fix this incorrect query result issue
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/562#discussion_r73959459
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/ExcessiveExchangeIdentifier.java
---
@@ -72,6 +73,47 @@ public Prel
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/517
This is the prototype patch I tried [1]. I replied with the link in our
prior direct communication.
[1] https://github.com/jinfengni/incubator-drill/commits/review/DRILL-4704
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/517
I'm not fully convinced that we should check the precision for each input
value for this castIntDecimal function.
The argument of proposed patch is parameter "precision=0" is
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/517
The change to the cast function implementation will impact not only
implicit cast, but also explicit cast. You are right that the test case of
employee_id = 170 will trigger implicit cast. However
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/559
@amansinha100 , thanks for your comments. Could you please take another
look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/559#discussion_r73725525
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestPartitionFilter.java ---
@@ -386,4 +386,49 @@ public void testPartitionFilterWithInSubquery
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/559#discussion_r73725537
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestPartitionFilter.java ---
@@ -386,4 +386,49 @@ public void testPartitionFilterWithInSubquery
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/559#discussion_r73725484
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java
---
@@ -402,4 +402,18 @@ public String getCacheFileRoot
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/559#discussion_r73725279
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DirPrunedEnumerableTableScan.java
---
@@ -0,0 +1,73
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/559
@amansinha100 , could you please review this patch?
Unit test / functional regression have passed.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/559
DRILL-4825: Fix incorrect result issue caused by partition pruning whâ¦
â¦en same tables are queried multiple times with different filters in
query.
1) Introduce
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/517
> I attached debugger to Drill and found it's passing through line 172 (not
315-316) of ExpressionTreeMaterializer.java, and that the "toType" object is
one of those runtime generat
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/517
I agreed with Aman that the eval() of CastIntDecimal28Sparse() should not
ignore the specified scale/precision, if they are passed as parameters.
As you analyzed, the problem is the scale
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/549
I feel it might be better to work on this issue after Drill rebases
Calcite. I debugged a bit in SqlValidator, and seem that the code in Drill's
forked Calcite is different from what Calcite master
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/549#discussion_r73227364
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/DrillCompoundIdentifier.java
---
@@ -69,31 +70,38 @@ public void addIndex
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/549#discussion_r73226886
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestSelectWithFullNameIdentifiers.java
---
@@ -0,0 +1,180 @@
+/**
+ * Licensed
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/555
+1
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/555#discussion_r73079809
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/UnionAllPrule.java
---
@@ -61,7 +61,8 @@ public void onMatch(RelOptRuleCall
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/555#discussion_r73028431
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/UnionAllPrule.java
---
@@ -61,7 +61,8 @@ public void onMatch(RelOptRuleCall
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/553
+1
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/553#discussion_r72296459
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
---
@@ -387,16 +378,35 @@ protected void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/549#discussion_r71918817
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/CompoundIdentifierConverter.java
---
@@ -115,6 +119,18 @@ public SqlNode
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/546#discussion_r71825128
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java
---
@@ -267,6 +276,15 @@ private TransferPair
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/549#discussion_r71816190
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java ---
@@ -1195,4 +1195,25 @@ public void testDateImplicitCasting() throws
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/546
I picked the latest commit, and am running the regression. Will merge to
master if everything runs fine.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/546
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/546
Thanks, @jaltekruse . I'll make the change you recommended, and squashed
into Chunhui's patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/546
+1
Overall LGTM.
@jaltekruse , do you have any further comment? thx.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/546#discussion_r71760001
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java
---
@@ -267,10 +276,21 @@ private TransferPair
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/550
+1
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/546#discussion_r71630375
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java
---
@@ -129,11 +129,21 @@ private void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/546#discussion_r71630181
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java
---
@@ -129,11 +129,21 @@ private void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/546#discussion_r71629104
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/nested/TestFastComplexSchema.java
---
@@ -80,4 +80,33 @@ public void test4() throws Exception
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/546#discussion_r71368874
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java
---
@@ -129,8 +129,14 @@ private void
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/519
+1
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/436
I'll will regression and merge this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/519#discussion_r70537956
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -607,7 +607,14 @@ public long getRowCount
201 - 300 of 539 matches
Mail list logo
