GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/255
DRILL-3765: Move partitioning pruning to HepPlanner to avoid the perfâ¦
â¦ormance overhead for redundant rule execution.
Add fall back option in planner.
Run the regression/unit
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/253#discussion_r44845244
--- Diff:
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java
---
@@ -36,6 +36,19 @@ public static void setupOptions
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/253#issuecomment-156584940
Overall LGTM.
In case that only constants are used and no column is required from scan
operator, the scan operator still has to go through the data source; the
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/255#discussion_r44974839
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java
---
@@ -116,20 +117,32 @@ public DrillSqlWorker(QueryContext
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/193#discussion_r45010657
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillDirectScanRel.java
---
@@ -0,0 +1,111 @@
+/**
+ * Licensed to the
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/193#discussion_r45406832
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/FindLimit0Visitor.java
---
@@ -36,16 +48,62 @@
* executing a schema
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/193#discussion_r45406939
--- Diff:
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java
---
@@ -42,6 +43,25 @@ public void hiveReadWithDb
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/193#issuecomment-158212142
Overall, looks good to me. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/193#discussion_r45407282
--- Diff:
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java
---
@@ -42,6 +43,25 @@ public void hiveReadWithDb
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/285#issuecomment-161017412
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/286
Drill 4127: Reduce Hive metastore client API call in HiveSchema
Also, it has commit for DRILL-4126: Add cache to HiveSchema in order to
reduce long planning time or execution time caused by slow
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/286#issuecomment-161210859
@vkorukanti , I revised the patch based on our discussions.
The cache is enabled when impersonation is turned on. I also put another
commit which uses flat
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/286#issuecomment-161335544
@vkorukanti , the patches pass the unit test, pre-commit test, and
impersonation test.
---
If your project is set up for it, you can reply to this email and
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/286#issuecomment-162665850
@vkorukanti , could you please take a look at the revised patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/286#issuecomment-162982945
Address venki's comments in the revised patches.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user jinfengni closed the pull request at:
https://github.com/apache/drill/pull/286
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/300#discussion_r47582011
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveStoragePlugin.java
---
@@ -91,20 +91,24 @@ public void
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/300#issuecomment-164609559
+1. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/301#issuecomment-164657881
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/305
DRILL-4201 : Allow partial filter to be pushed down project for betteâ¦
â¦r performance.
Partial filter pushdown has performance benefits because:
1) enable partition pruning, if the
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/305#issuecomment-165567570
@amansinha100 , could you please review the patch for DRILL-4201? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/318
DRILL-4250: Fix directory-based partition pruning when directory has â¦
â¦both subdirectory and file.
@amansinha100 , could you please review this small patch for
directory-based
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/328
Drill 2517: Apply directory-based partition pruning before reading files in
planning.
1. Run the pre-commit tests and unit tests. Some queries in pre-commit
suites have changed plan. Most of the
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/329#issuecomment-173229548
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/328#discussion_r50302540
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
---
@@ -78,71 +94,68 @@ public PruneScanRule
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/342
DRILL-4279: Improve query performance when no column is required fromâ¦
⦠scan operator.
Use different approaches, when no column is not required from scan operator.
1) If data
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/345#discussion_r51518520
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java
---
@@ -118,13 +133,34 @@ public boolean apply(@Nullable
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/345#discussion_r51518560
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -338,8 +354,14 @@ private boolean hasSingleValue
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/345#discussion_r51612792
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java
---
@@ -118,13 +133,34 @@ public boolean apply(@Nullable
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/345#issuecomment-178746517
Overall, looks good to me.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/345#discussion_r51612851
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -338,8 +354,14 @@ private boolean hasSingleValue
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/349#issuecomment-179526708
LGTM.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/371
DRILL-4363: Row count based pruning for parquet table used in Limit nâ¦
⦠query.
Modify two existint unit testcase:
1) TestPartitionFilter.testMainQueryFalseCondition(): rowCount
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/371#discussion_r52476961
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushLimitToScanRule.java
---
@@ -0,0 +1,107 @@
+/**
+ * Licensed
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/371#discussion_r52498045
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushLimitToScanRule.java
---
@@ -0,0 +1,107 @@
+/**
+ * Licensed
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/371#discussion_r52539112
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushLimitToScanRule.java
---
@@ -0,0 +1,107 @@
+/**
+ * Licensed
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/371#discussion_r52563924
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -791,6 +799,43 @@ public FileGroupScan clone
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/371#discussion_r52563951
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractGroupScan.java
---
@@ -128,4 +128,12 @@ public int getOperatorType
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/371#discussion_r52564032
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushLimitToScanRule.java
---
@@ -0,0 +1,108 @@
+/**
+ * Licensed
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/371#discussion_r52565738
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -485,12 +486,14 @@ public void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52953882
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -120,7 +120,7 @@ drill.exec: {
affinity.factor: 1.2
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/376#discussion_r52973315
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java
---
@@ -68,6 +79,7 @@ protected FileSelection(final FileSelection
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/376#discussion_r52973451
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -529,6 +549,36 @@ public long getRowCount
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/376#discussion_r53068818
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -529,6 +549,36 @@ public long getRowCount
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/379
DRILL-4387: GroupScan or ScanBatchCreator should not use star column â¦
â¦in case of skipAll query.
The skipAll query should be handled in RecordReader.
You can merge this pull request
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/380#discussion_r53357932
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestComplexTypeReader.java
---
@@ -241,4 +252,49 @@ public void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/379#discussion_r53360482
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/GroupScan.java
---
@@ -35,6 +35,8 @@
public interface GroupScan extends
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/379#discussion_r53361870
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetScanBatchCreator.java
---
@@ -87,9 +87,6 @@ public ScanBatch getBatch
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/380#discussion_r53362337
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestComplexTypeReader.java
---
@@ -241,4 +252,49 @@ public void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/379#discussion_r53366236
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetScanBatchCreator.java
---
@@ -87,9 +87,6 @@ public ScanBatch getBatch
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/379#discussion_r53387614
--- Diff:
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseGroupScan.java
---
@@ -34,6 +34,7 @@
import
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/383
DRILL-4392: Fix CTAS partition to remove one unnecessary internal fieâ¦
â¦ld in generated parquet files.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/383#issuecomment-186332099
Right. The planner could not remove that internal field by projection
removal, since Writer operator has to use that field. It's the writer's job to
exclude
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/377#discussion_r53499889
--- Diff: pom.xml ---
@@ -1278,7 +1278,7 @@
org.apache.calcite
calcite-core
-1.4.0-drill
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/377#discussion_r53522848
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java
---
@@ -216,6 +217,20 @@ public void eval
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/377#discussion_r53527480
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFuncHolder.java
---
@@ -264,7 +265,24 @@ public boolean isFieldReader(int i
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/377#discussion_r53528079
--- Diff:
exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/Extract.java
---
@@ -31,6 +31,48 @@
public class ${className
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/377#discussion_r53529398
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java
---
@@ -17,40 +17,42 @@
*/
package
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/377#discussion_r53536497
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperator.java
---
@@ -18,69 +18,81 @@
package
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/377#discussion_r53536574
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java
---
@@ -17,40 +17,42 @@
*/
package
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/377#discussion_r53537030
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DummyConvertFrom.java
---
@@ -32,6 +34,8 @@
@FunctionTemplate(name
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/377#discussion_r53537609
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DummyConvertFrom.java
---
@@ -32,6 +34,8 @@
@FunctionTemplate(name
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/377#discussion_r53537856
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DummyFlatten.java
---
@@ -32,6 +34,7 @@
@FunctionTemplate(name
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/377#discussion_r53538246
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/annotations/FunctionTemplate.java
---
@@ -109,6 +116,16 @@ public int getValue
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/377#discussion_r53537811
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DummyConvertTo.java
---
@@ -32,6 +34,8 @@
@FunctionTemplate(name
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/377#discussion_r53539261
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java
---
@@ -0,0 +1,196 @@
+/**
+ * Licensed to the
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/377#discussion_r53539694
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java
---
@@ -0,0 +1,196 @@
+/**
+ * Licensed to the
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/377#discussion_r53540001
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java
---
@@ -0,0 +1,196 @@
+/**
+ * Licensed to the
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/377#discussion_r53540182
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java
---
@@ -0,0 +1,196 @@
+/**
+ * Licensed to the
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/377#discussion_r53540420
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java
---
@@ -0,0 +1,196 @@
+/**
+ * Licensed to the
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54680335
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperator.java
---
@@ -18,69 +18,43 @@
package
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54680708
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperator.java
---
@@ -18,69 +18,43 @@
package
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54680921
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java
---
@@ -0,0 +1,571 @@
+/**
+ * Licensed to the
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54680959
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java
---
@@ -0,0 +1,571 @@
+/**
+ * Licensed to the
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54681010
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java
---
@@ -0,0 +1,571 @@
+/**
+ * Licensed to the
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54761017
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java
---
@@ -0,0 +1,571 @@
+/**
+ * Licensed to the
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54765563
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java
---
@@ -92,38 +94,110 @@ public DrillFunctionRegistry
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54804039
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperator.java
---
@@ -18,69 +18,43 @@
package
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/401#discussion_r54817380
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java
---
@@ -273,12 +282,90 @@ public RelNode visit
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/401#discussion_r54817765
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlParser.java
---
@@ -0,0 +1,349 @@
+/**
+ * Licensed to the Apache
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/401#discussion_r54836613
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java
---
@@ -273,12 +282,90 @@ public RelNode visit
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/401#discussion_r54836874
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java
---
@@ -273,12 +282,90 @@ public RelNode visit
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/401#discussion_r54837401
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java
---
@@ -273,12 +282,90 @@ public RelNode visit
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/401#discussion_r54907078
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java
---
@@ -273,12 +282,90 @@ public RelNode visit
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/401#discussion_r54907758
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java
---
@@ -273,12 +282,90 @@ public RelNode visit
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/401#discussion_r54908424
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerConfig.java
---
@@ -18,30 +18,41 @@
package
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/401#discussion_r54912629
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlParser.java
---
@@ -0,0 +1,349 @@
+/**
+ * Licensed to the Apache
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/401#discussion_r54912350
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlParser.java
---
@@ -0,0 +1,349 @@
+/**
+ * Licensed to the Apache
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/401#discussion_r54970576
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java
---
@@ -0,0 +1,364 @@
+/**
+ * Licensed to the Apache
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/401#issuecomment-192034285
Overall, looks good to me. The patch simplifies Calcite integration, make
the code cleaner, and make it easier to extend in Drill.
+1
---
If your
501 - 590 of 590 matches
Mail list logo
