Re: [DISCUSS] 1.13.0 release

So it is. My mistake :). Travis is good. Will start the release process. On Mon, Mar 12, 2018 at 6:00 PM, Arina Yelchiyeva < arina.yelchiy...@gmail.com> wrote: > Parth, > > looks like build on Travis is still running [1]. > > [1] > https://travis-ci.org/apache/drill/builds/352294695?utm_ > source

Re: [DISCUSS] 1.13.0 release

Parth, looks like build on Travis is still running [1]. [1] https://travis-ci.org/apache/drill/builds/352294695?utm_source=github_status&utm_medium=notification Kind regards Arina On Mon, Mar 12, 2018 at 2:26 PM, Parth Chandra wrote: > Travis build is broken after the merge. I'm almost sure

Re: [DISCUSS] 1.13.0 release

Travis build is broken after the merge. I'm almost sure this was already addressed. @Volodymyr I thought this was part of the PR for DRILL-1491? On Sat, Mar 10, 2018 at 11:08 AM, Parth Chandra wrote: > Update on DRILL-1491 - > The illegal state transition (cancellation_requested -> enqueued) i

Re: [DISCUSS] 1.13.0 release

Update on DRILL-1491 - The illegal state transition (cancellation_requested -> enqueued) is no longer happening for me after I updated my JDK to the latest version. I'll try on and off over the weekend and if it cannot be reproduced, I'll let it go. Release plan - I'll merge the PRs for DRILL-

Re: [DISCUSS] 1.13.0 release

he vladimir's branch (i.e DRILL-1491). >>> > >>> >> > > > Used the maven test command for testing it. >>> > >>> >> > > > >>> > >>> >> > > > output of the test run. >>> > >>> >> > &

Re: [DISCUSS] 1.13.0 release

in org.apache.drill.exec.server.T >> estDrillbitResilience >> > >>> >> > > > >> > >>> >> > > > >> > >>> >> > > > >> > >>> >> > > > >> > >>> >> > > > On Wed, Mar

Re: [DISCUSS] 1.13.0 release

;>> >> 1.14.0. > > >>> >> > > > > I'm hoping we can resolve the other three in the next few > > >>> days. > > >>> >> > Target > > >>> >> > > > date > > >>> >> > > >

Re: [DISCUSS] 1.13.0 release

> > > >>> >> > > > > Once these are resolved, I will create a branch for the > >>> release so > >>> >> > that > >>> >> > > > > Apache master remains open for commits. If any issues are > >>> found in

Re: [DISCUSS] 1.13.0 release

is finalized I will add a >>> >> > release >>> >> > > > tag >>> >> > > > > and remove the branch. >>> >> > > > > >>> >> > > > > Also note if QA folks want to get started on testing t

Re: [DISCUSS] 1.13.0 release

nt to get started on testing the >> release, >> >> the >> >> > > > > current head of Apache master is close to final. Javadoc >> >> generation >> >> > is >> >> > > > only >> >> > >

Re: [DISCUSS] 1.13.0 release

gt; > > > > > >> > > > > > >> > > > > > >> > > > > On Wed, Mar 7, 2018 at 11:23 PM, Aman Sinha < > amansi...@apache.org > >> > > >> > > > wrote: > >> > > > > > >> >

Re: [DISCUSS] 1.13.0 release

PM, Aman Sinha > > >> > > > wrote: >> > > > > >> > > > > > It seems to me the main blockers are: >> > > > > > >> > > > > > 1. DRILL-4547Javadoc fails with Java8 <-- Can we split up >&g

Re: [DISCUSS] 1.13.0 release

> > > > among few people to resolve these ? > > > > > > 2. DRILL-6216Metadata mismatch.. <-- Agreement was to > > > > revert > > > > > > one small piece of code and it appears Sorabh is looking into it &g

Re: [DISCUSS] 1.13.0 release

bh is looking into it > > > > > 3. TestDrillbitResilience.cancelAfterAllResultsProduced <-- need > > > > someone > > > > > to look into this > > > > > > > > > > Regarding the JDBC issues that Parth mentioned, looking

Re: [DISCUSS] 1.13.0 release

issues that Parth mentioned, looking at the JIRAs, > > it > > > > seems they are not showstoppers...Parth do you agree ? > > > > > > > > Since we are close to the finish line for JDK 8, IMO we should try > and > > > see > > > > if in anot

Re: [DISCUSS] 1.13.0 release

d, Mar 7, 2018 at 7:17 AM, Pritesh Maker wrote: > > > > > > > The JDK 8 issues will likely require more time to harden for it to be > > > > included in the 1.13 release. My recommendation would be to move > ahead > > > with > > > > the 1.13 r

Re: [DISCUSS] 1.13.0 release

> > > > The JDK 8 issues will likely require more time to harden for it to be > > > included in the 1.13 release. My recommendation would be to move ahead > > with > > > the 1.13 release now and address these issues right. > > > > > > Pritesh > > &g

Re: [DISCUSS] 1.13.0 release

e > > included in the 1.13 release. My recommendation would be to move ahead > with > > the 1.13 release now and address these issues right. > > > > Pritesh > > > > -----Original Message- > > From: Parth Chandra > > Sent: March 7, 2018 3:34 AM

Re: [DISCUSS] 1.13.0 release

and address these issues right. > > Pritesh > > -Original Message- > From: Parth Chandra > Sent: March 7, 2018 3:34 AM > To: dev > Subject: Re: [DISCUSS] 1.13.0 release > > My mistake Volodymyr. > > Found some other JDK 8 issues in JIRA not tracked in D

RE: [DISCUSS] 1.13.0 release

Subject: Re: [DISCUSS] 1.13.0 release My mistake Volodymyr. Found some other JDK 8 issues in JIRA not tracked in DRILL-1491 DRILL-4547Javadoc fails with Java8 DRILL-6163Switch Travis To Java 8 The following are tracked in DRILL-1491, but it doesn't look like we're addres

Re: [DISCUSS] 1.13.0 release

hanks, > >> Sorabh > >> > >> ____ > >> From: Parth Chandra > >> Sent: Tuesday, March 6, 2018 6:48:21 PM > >> To: dev > >> Subject: Re: [DISCUSS] 1.13.0 release > >> > >> We have two items r

Re: [DISCUSS] 1.13.0 release

___ >> From: Parth Chandra >> Sent: Tuesday, March 6, 2018 6:48:21 PM >> To: dev >> Subject: Re: [DISCUSS] 1.13.0 release >> >> We have two items remaining - >> >> DRILL-1491 - Ideally, I would like to make sure that CANCEL is handle

Re: [DISCUSS] 1.13.0 release

__ > From: Parth Chandra > Sent: Tuesday, March 6, 2018 6:48:21 PM > To: dev > Subject: Re: [DISCUSS] 1.13.0 release > > We have two items remaining - > > DRILL-1491 - Ideally, I would like to make sure that CANCEL is handled > correctly with JDK 8. If the fai

Re: [DISCUSS] 1.13.0 release

Just sent an email on RCA of DRILL-6216 to discuss next steps. Thanks, Sorabh From: Parth Chandra Sent: Tuesday, March 6, 2018 6:48:21 PM To: dev Subject: Re: [DISCUSS] 1.13.0 release We have two items remaining - DRILL-1491 - Ideally, I would like to make

Re: [DISCUSS] 1.13.0 release

We have two items remaining - DRILL-1491 - Ideally, I would like to make sure that CANCEL is handled correctly with JDK 8. If the failure of the unit test is because the cancel is received after the query is completed, then the issue is less severe, but I would like to be sure that this is the cas

Re: [DISCUSS] 1.13.0 release

Hi Parth DRILL-6216 is a release blocker that is being currently looked into.  Ref:  DRILL-6216: Metadata mismatch when connecting to a Drill 1.12.0 with a Drill-1.13.0-SNAPSHOT driver https://issues.apache.org/jira/browse/DRILL-6216 Please add it to the list of required commits as well.  Than

Re: [DISCUSS] 1.13.0 release

Right now i haven't found the reason of TestDrillbitResilience.cancelAfterAllResultsProduced failure, most likely the cause of the failure is that the query is able to have been completed before cancellation request is processed. This test not only the case, there is one more ignored test TestDrill

Re: [DISCUSS] 1.13.0 release

*Update for:* DRILL-1491: Support for JDK 8 Currently we have 1 unit tests fail on test cluster. If ignored, all other tests succeed. Failed tests: TestDrillbitResilience.cancelAfterAllResultsProduced:672->assertCancelledWithoutException:564->assertCancelledWithoutException:557->assertStateComplet

Re: [DISCUSS] 1.13.0 release

Merged Drill on Yarn. Paul thanks for making the changes. Regarding JDK8 there is an open PR ( https://github.com/apache/drill/pull/1143) which needs to be merged. As Volodymyr mentioned there were some issues with unit tests and Travis. Padma and I have addressed unit tests issues but we still ne

Re: [DISCUSS] 1.13.0 release

Sounds good. On Sun, Mar 4, 2018 at 1:18 PM, Paul Rogers wrote: > Hi Parth, > Issues with DRILL-1170 are resolved. Needs one final review by Arina, then > we should be good to do. > Thanks to everyone for getting the other two "batch size" PRs committed > recently. > Thanks, > - Paul > > > >

Re: [DISCUSS] 1.13.0 release

Hi Parth, Issues with DRILL-1170 are resolved. Needs one final review by Arina, then we should be good to do. Thanks to everyone for getting the other two "batch size" PRs committed recently. Thanks, - Paul On Saturday, March 3, 2018, 10:57:10 PM PST, Parth Chandra wrote: Thank you

Re: [DISCUSS] 1.13.0 release

Thank you Arina ! Build and unit tests with JDK 8 passed for me with the latest master. I'm guessing there is still something more to be addressed, since DRILL-1491 is still open? Updated list: DRILL-1491: Support for JDK 8 --* In progress.* DRILL-1170: YARN support for Drill -- Needs Committer

Re: [DISCUSS] 1.13.0 release

I will take care of FunctionInitializerTest#testConcurrentFunctionBodyLoad in DRILL-6208. Also I have merged all Jiras with ready-to-commit label. Drill on Yarn was NOT merged due to banned dependencies issue. Kind regards Arina On Sat, Mar 3, 2018 at 12:11 PM, Parth Chandra wrote: > Thanks

Re: [DISCUSS] 1.13.0 release

Thanks for the updates guys. Please keep updating the status in this thread. On Fri, Mar 2, 2018 at 11:18 PM, Padma Penumarthy wrote: > I can look at failure in testFlattenUpperLimit. I added this test recently. > > Thanks > Padma > > > On Mar 2, 2018, at 8:19 AM, Volodymyr Tkach vovatkac...@gm

Re: [DISCUSS] 1.13.0 release

I can look at failure in testFlattenUpperLimit. I added this test recently. Thanks Padma On Mar 2, 2018, at 8:19 AM, Volodymyr Tkach mailto:vovatkac...@gmail.com>> wrote: testFlattenUpperLimit

Re: [DISCUSS] 1.13.0 release

*Update for:* DRILL-1491: Support for JDK 8 There is 1 failing test FunctionInitializerTest#testConcurrentFunctionBodyLoad caused by Jmokit library. Looking for replacement for mocking private method. *Travis:* Currenlty fails due to testFlattenUpperLimit(org.apache.drill.exec.physical.unit.TestO

Re: [DISCUSS] 1.13.0 release

Good show. Updated list: DRILL-6185: Error is displaying while accessing query profiles via the Web-UI -- Ready to commit DRILL-6174: Parquet pushdown planning improvements -- Ready to commit DRILL-6191: Need more information on TCP flags -- Ready to commit DRILL-6190: Packets can be bigger than

Re: [DISCUSS] 1.13.0 release

and worth including for > > the > > > > > 1.13 release (maybe give another week to resolve this before the > 1st > > RC > > > > is > > > > > created?) > > > > > > > > > > DRILL-6027 Implement spill to disk for the Has

Re: [DISCUSS] 1.13.0 release

> > > is > > > > created?) > > > > > > > > DRILL-6027 Implement spill to disk for the Hash Join -- Boaz and Tim > > > > DRILL-6173 Support transitive closure during filter push down and > > > > partition pruning - Vi

Re: [DISCUSS] 1.13.0 release

eral other bugs/ improvements that are marked in progress > - > > > https://issues.apache.org/jira/secure/Dashboard.jspa? > > selectPageId=12332152 > > > - if folks are not working on them, we should remove the fixVersion for > > > 1.13. > > > > > &g

Re: [DISCUSS] 1.13.0 release

gt; - if folks are not working on them, we should remove the fixVersion for > > 1.13. > > > > Pritesh > > > > > > -Original Message- > > From: Abhishek Girish > > Sent: February 27, 2018 10:44 AM > > To: dev@drill.apache.org > &g

Re: [DISCUSS] 1.13.0 release

Pritesh > > > > > > -Original Message- > > From: Abhishek Girish > > Sent: February 27, 2018 10:44 AM > > To: dev@drill.apache.org > > Subject: Re: [DISCUSS] 1.13.0 release > > > > For JDK 8, we've run through both unit tests & regres

Re: [DISCUSS] 1.13.0 release

> > Pritesh > > > -Original Message- > From: Abhishek Girish > Sent: February 27, 2018 10:44 AM > To: dev@drill.apache.org > Subject: Re: [DISCUSS] 1.13.0 release > > For JDK 8, we've run through both unit tests & regression tests from [1] > and have obs

RE: [DISCUSS] 1.13.0 release

for 1.13. Pritesh -Original Message- From: Abhishek Girish Sent: February 27, 2018 10:44 AM To: dev@drill.apache.org Subject: Re: [DISCUSS] 1.13.0 release For JDK 8, we've run through both unit tests & regression tests from [1] and have observed no issues - so i think we shoul

Re: [DISCUSS] 1.13.0 release

For JDK 8, we've run through both unit tests & regression tests from [1] and have observed no issues - so i think we should get the fixes into 1.13.0 and claim support for JDK 8. [1] https://github.com/mapr/drill-test-framework On Tue, Feb 27, 2018 at 9:46 AM, Aman Sinha wrote: > Agree with Ar

Re: [DISCUSS] 1.13.0 release

Agree with Arina on JDK8 support..let's get through the last remaining hurdles for this for 1.13 release. Calcite in fact is dropping support for JDK 7 in their next release. They are even looking ahead to JDK 9. For Drill-on-Yarn, I think ultimately it is at the discretion of the release manager

Re: [DISCUSS] 1.13.0 release

I want to include DRILL-6174. It has already passed code review. Regarding JDK8 support. Volodymyr Tkach is working on this issue. Currently all unit tests have passed. Now he is working on enforcing Java 8 (changes in travis.yml, drill-config.sh, pom.xml etc). Regarding Drill on Yarn, Salim has

Re: [DISCUSS] 1.13.0 release

There are two issues marked as blockers for 1.13.0 - TPatch InfoKeySummaryReporterPStatusResolutionCreatedUpdatedDueFix Version/s Assignee [image: Bug] DRILL-6185

Re: [DISCUSS] 1.13.0 release

There is a pcap improvement about to be ready. And a bug (with a fix) that just turned up. I will push for a PR On Feb 23, 2018 00:14, "Parth Chandra" wrote: > Bit of a tepid response from dev; but Aman's approval is all the > encouragement I need to roll out a release :) > > Thoughts on pending

Re: [DISCUSS] 1.13.0 release

I believe we should move to JDK 8 in 1.13.0 release. Thanks, Khurram From: Arina Yelchiyeva Sent: Monday, February 26, 2018 8:03:31 AM To: dev@drill.apache.org Subject: Re: [DISCUSS] 1.13.0 release I remember that at the beginning of the year we discussed

Re: [DISCUSS] 1.13.0 release

I remember that at the beginning of the year we discussed that Drill on Yarn, transition to JDK 8 should be in 1.13 release. Before doing the release we need to make sure all these are done and merged. Drill on Yarn PR is reviewed but requires some fixes. Not sure about JDK 8. On Mon, Feb 26, 201

Re: [DISCUSS] 1.13.0 release

Since there don't appear to be many PRs that folks want merged in, I'm thinking of rolling out the release candidate on March 1st. That should give folks who want to get stuff in at the last minute enough time. Note that I'm on Indian time so I'll be half a day ahead of most other folks. Charles, t

Re: [DISCUSS] 1.13.0 release

I agree and I’ll try to get the log file PR done for this release. Sent from my iPhone > On Feb 23, 2018, at 00:14, Parth Chandra wrote: > > Bit of a tepid response from dev; but Aman's approval is all the > encouragement I need to roll out a release :) > > Thoughts on pending PRs? > > > >

Re: [DISCUSS] 1.13.0 release

Bit of a tepid response from dev; but Aman's approval is all the encouragement I need to roll out a release :) Thoughts on pending PRs? On Thu, Feb 22, 2018 at 9:54 PM, Aman Sinha wrote: > Agreed...it would be good to get the ball rolling on the 1.13.0 release. > Among other things, this rel

Re: [DISCUSS] 1.13.0 release

Agreed...it would be good to get the ball rolling on the 1.13.0 release. Among other things, this release has the long pending Calcite rebase changes and the sooner we get it it out for users, the better. Thanks for volunteering ! -Aman On Wed, Feb 21, 2018 at 9:03 PM, Parth Chandra wrote: > H

[DISCUSS] 1.13.0 release

Hello Drillers, I feel we might benefit from a early release for 1.13.0. We took longer to do the previous release so it would be nice to bring the release train back on track. I'll volunteer (!) to manage the release :) What do you guys think? If we are in agreement on starting the rel