[GitHub] [drill] jnturton commented on a diff in pull request #2655: DRILL-8314: Add support for automatically retrying and disabling broken storage plugins

2022-10-10 Thread GitBox
jnturton commented on code in PR #2655: URL: https://github.com/apache/drill/pull/2655#discussion_r991218134 ## exec/java-exec/src/main/java/org/apache/calcite/jdbc/DynamicRootSchema.java: ## @@ -91,22 +91,69 @@ private CalciteSchema getSchema(String schemaName, boolean

[GitHub] [drill] jnturton commented on a diff in pull request #2655: DRILL-8314: Add support for automatically retrying and disabling broken storage plugins

2022-09-27 Thread GitBox
jnturton commented on code in PR #2655: URL: https://github.com/apache/drill/pull/2655#discussion_r981927883 ## exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java: ## @@ -130,11 +132,18 @@ private static PhysicalPlan convertPlan(QueryContext

[GitHub] [drill] jnturton commented on a diff in pull request #2655: DRILL-8314: Add support for automatically retrying and disabling broken storage plugins

2022-09-27 Thread GitBox
jnturton commented on code in PR #2655: URL: https://github.com/apache/drill/pull/2655#discussion_r981328928 ## exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java: ## @@ -130,11 +132,18 @@ private static PhysicalPlan convertPlan(QueryContext

[GitHub] [drill] jnturton commented on a diff in pull request #2655: DRILL-8314: Add support for automatically retrying and disabling broken storage plugins

2022-09-26 Thread GitBox
jnturton commented on code in PR #2655: URL: https://github.com/apache/drill/pull/2655#discussion_r979835243 ## exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java: ## @@ -1094,6 +1095,35 @@ public static String bootDefaultFor(String name) { new

[GitHub] [drill] jnturton commented on a diff in pull request #2655: DRILL-8314: Add support for automatically retrying and disabling broken storage plugins

2022-09-26 Thread GitBox
jnturton commented on code in PR #2655: URL: https://github.com/apache/drill/pull/2655#discussion_r979835243 ## exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java: ## @@ -1094,6 +1095,35 @@ public static String bootDefaultFor(String name) { new

[GitHub] [drill] jnturton commented on a diff in pull request #2655: DRILL-8314: Add support for automatically retrying and disabling broken storage plugins

2022-09-26 Thread GitBox
jnturton commented on code in PR #2655: URL: https://github.com/apache/drill/pull/2655#discussion_r979833628 ## exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java: ## @@ -1094,6 +1095,35 @@ public static String bootDefaultFor(String name) { new

[GitHub] [drill] jnturton commented on a diff in pull request #2655: DRILL-8314: Add support for automatically retrying and disabling broken storage plugins

2022-09-26 Thread GitBox
jnturton commented on code in PR #2655: URL: https://github.com/apache/drill/pull/2655#discussion_r979823862 ## exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java: ## @@ -34,12 +34,22 @@ public interface StoragePluginRegistry extends Iterable

[GitHub] [drill] jnturton commented on a diff in pull request #2655: DRILL-8314: Add support for automatically retrying and disabling broken storage plugins

2022-09-26 Thread GitBox
jnturton commented on code in PR #2655: URL: https://github.com/apache/drill/pull/2655#discussion_r979818742 ## exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerConfig.java: ## @@ -52,12 +59,81 @@ public QueryContext getContext() { return

[GitHub] [drill] jnturton commented on a diff in pull request #2655: DRILL-8314: Add support for automatically retrying and disabling broken storage plugins

2022-09-26 Thread GitBox
jnturton commented on code in PR #2655: URL: https://github.com/apache/drill/pull/2655#discussion_r979810768 ## exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java: ## @@ -130,11 +132,18 @@ private static PhysicalPlan convertPlan(QueryContext

[GitHub] [drill] jnturton commented on a diff in pull request #2655: DRILL-8314: Add support for automatically retrying and disabling broken storage plugins

2022-09-26 Thread GitBox
jnturton commented on code in PR #2655: URL: https://github.com/apache/drill/pull/2655#discussion_r979810768 ## exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java: ## @@ -130,11 +132,18 @@ private static PhysicalPlan convertPlan(QueryContext