[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2018-01-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1040 ---

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158184949 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/server/TestSpnegoAuthentication.java --- @@ -0,0 +1,597 @@ +/* + * Licensed to the Apach

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158113430 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillHttpSecurityHandlerProvider.java --- @@ -0,0 +1,187 @@ +/* + * Lic

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158112333 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillHttpSecurityHandlerProvider.java --- @@ -0,0 +1,187 @@ +/* + * Lic

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158099889 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/LogInLogOutResources.java --- @@ -69,23 +79,94 @@ public Viewable getLoginPage(@Cont

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158112289 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillHttpSecurityHandlerProvider.java --- @@ -0,0 +1,187 @@ +/* + * Lic

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158164861 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillSpnegoAuthenticator.java --- @@ -0,0 +1,150 @@ +/* + * Licensed to

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158135221 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/SpnegoUtil.java --- @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache So

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158099695 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/LogInLogOutResources.java --- @@ -69,23 +79,94 @@ public Viewable getLoginPage(@Cont

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158164495 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillSpnegoAuthenticator.java --- @@ -0,0 +1,150 @@ +/* + * Licensed to

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158120552 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/SPNEGOSecurityHandler.java --- @@ -0,0 +1,37 @@ +/* + * Licensed to the

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158166373 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillSpnegoAuthenticator.java --- @@ -0,0 +1,150 @@ +/* + * Licensed to

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158348706 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillErrorHandler.java --- @@ -0,0 +1,45 @@ +/* + * Licensed to the Apa

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158112439 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillHttpSecurityHandlerProvider.java --- @@ -0,0 +1,187 @@ +/* + * Lic

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158118536 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/FORMSecurityHanlder.java --- @@ -0,0 +1,50 @@ +/* + * Licensed to the A

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158117082 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillSpnegoLoginService.java --- @@ -0,0 +1,151 @@ +/* + * Licensed to

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158118993 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/FORMSecurityHanlder.java --- @@ -0,0 +1,50 @@ +/* + * Licensed to the A

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158117860 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillSpnegoLoginService.java --- @@ -0,0 +1,151 @@ +/* + * Licensed to

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158166736 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/rpc/security/KerberosHelper.java --- @@ -43,16 +45,20 @@ public String SERVER_PRINCIPAL;

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158111965 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillHttpSecurityHandlerProvider.java --- @@ -0,0 +1,187 @@ +/* + * Lic

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158100823 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java --- @@ -183,17 +180,19 @@ public void start() throws Exception {

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158137486 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillSpnegoAuthenticator.java --- @@ -0,0 +1,150 @@ +/* + * Licensed to

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158113700 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillSpnegoAuthenticator.java --- @@ -0,0 +1,150 @@ +/* + * Licensed to

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158120686 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/SPNEGOSecurityHandler.java --- @@ -0,0 +1,37 @@ +/* + * Licensed to the

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158121657 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/BasicServer.java --- @@ -202,6 +202,9 @@ public int bind(final int initialPort, boolean allowPortH

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158135735 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/SpnegoUtil.java --- @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache So

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158137533 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillSpnegoAuthenticator.java --- @@ -0,0 +1,150 @@ +/* + * Licensed to

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158184891 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/server/TestSpnegoAuthentication.java --- @@ -0,0 +1,597 @@ +/* + * Licensed to the Apach

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158135822 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/SpnegoUtil.java --- @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache So

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158106496 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillHttpConstraintSecurityHandler.java --- @@ -0,0 +1,61 @@ +/* + * Li

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158099938 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/LogInLogOutResources.java --- @@ -69,23 +79,94 @@ public Viewable getLoginPage(@Cont

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158102763 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServerConstants.java --- @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158099736 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/LogInLogOutResources.java --- @@ -69,23 +79,94 @@ public Viewable getLoginPage(@Cont

[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

2017-12-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1040#discussion_r158100206 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/LogInLogOutResources.java --- @@ -69,23 +79,94 @@ public Viewable getLoginPage(@Cont