Re: Potential copyright issue with transitive npm dependency

2019-03-27 Thread Huxing Zhang
Hi, On Fri, Mar 22, 2019 at 1:55 PM Hen wrote: > > > (including Huxing) > > On Thu, Mar 21, 2019 at 10:55 PM Hen wrote: >> >> >> Give substack a few days to reply and then nudge them on Twitter: >> https://twitter.com/substack or their email (listed on https://substack.net/ >> ). I tried to s

pull request

2019-03-27 Thread jialin niu
please help me merge https://github.com/apache/incubator-dubbo/pull/3750 thank you

Re: pull request

2019-03-27 Thread Ian Luo
merged. Thanks, -Ian. On Wed, Mar 27, 2019 at 4:07 PM jialin niu wrote: > please help me merge > https://github.com/apache/incubator-dubbo/pull/3750 > thank you >

Re: [VOTE]: Release Apache Dubbo Admin(Incubating) 0.2.0 [RC2]

2019-03-27 Thread Huxing Zhang
Hi, On Thu, Mar 21, 2019 at 1:45 PM Justin Mclean wrote: > > Hi, > > > These dependencies are all development time dependencies, which can be > > found in "devDependencies" section of package.json file. > > Anyone who compiles the source will get these and be unaware of them, that > seems a lit

Re: [VOTE]: Release Apache Dubbo Admin(Incubating) 0.2.0 [RC2]

2019-03-27 Thread Justin Mclean
Hi, > It shows the node-forge module has contains GPL license, but looking > into the license file, it is actually dual licensed with GPL (Category > X) and BSD-3 clause (Category A). So I think it is fine. Yep that is fine, for anything dual licensed you can take the most permissive license. T

Re: [VOTE] Release Apache Dubbo Spring Boot Project (Incubating) 2.7.1

2019-03-27 Thread Huxing Zhang
Hi, I haven't had time to check yet, but I noticed that the tag for 2.7.1 has been deleted and re-created, is there anything wrong with this candidate? If that it true, it is better to cancel this vote first. On Wed, Mar 27, 2019 at 1:26 PM Mercy wrote: > > Hello Dubbo Community, > > This is a c

Re: [DRAFT] End of Life for Apache Dubbo 2.5.x

2019-03-27 Thread Huxing Zhang
Hi, On Wed, Mar 27, 2019 at 10:44 AM Ian Luo wrote: > > Huxing, > > We should make it very clear in the announcement email that we will > guarantee the backward compatibility in 2.6.x release. Sounds reasonable, I will add it. > > Thanks, > -Ian. > > On Wed, Mar 27, 2019 at 12:12 AM Huxing Zhang

Re: [VOTE] Release Apache Dubbo Spring Boot Project (Incubating) 2.7.1

2019-03-27 Thread Mercy Ma
This release will be cancel because Github tag attaches the wrong source code, I will renew a vote. Kind regards, Mercy Ma On Wed, Mar 27, 2019 at 1:26 PM Mercy wrote: > Hello Dubbo Community, > > This is a call for the vote to release Apache Dubbo Spring Boot Project > (Incubating) version 2.7

[Vote] Release Apache Dubbo Spring Boot Project (Incubating) 2.7.1 (RC1)

2019-03-27 Thread Mercy Ma
Hello Dubbo Community, This is a call for the vote to release Apache Dubbo Spring Boot Project (Incubating) version 2.7.1 (RC1) The release candidates 2.7.1: https://dist.apache.org/repos/dist/dev/incubator/dubbo/spring-boot-project/2.7.1 The staging repo: https://repository.apache.org/content/r

Re: never create branch on main repo

2019-03-27 Thread Taosheng, Wei
hi Ian, I am so sorry to make the mistake. I just wanted to submit a pr, but it make a mistaken operation of creating a branch. I will be more careful when trying to submit a pr. -- Original -- From: Ian Luo Date: Tue,Mar 26,2019 5:45 PM To: dev Subject: Re: n

Re: [Vote] Release Apache Dubbo Spring Boot Project (Incubating) 2.7.1 (RC1)

2019-03-27 Thread Huxing Zhang
Hi, I vote with:  +1 release the software  Are release files in correct location? Yes  Do release files have the word incubating in their name? Yes  Are the digital signature and hashes correct? Yes  Does DISCLAIMER file exist? Yes  Do LICENSE and NOTICE files exists? Yes  Is the LICENSE a

Re: never create branch on main repo

2019-03-27 Thread Taosheng, Wei
Hi, I have deleted the branch. And I remember why this happened. At the beginning, I tried to revert the pr 3688, so I click the "revert" button of github. And the github should created a branch on the main repo, but I didn't find it. And then I didn't want to revert the pr, so I closed the reve

Re: never create branch on main repo

2019-03-27 Thread Ian Luo
I see. It's fine, let's watch out for each other and avoid of accidental mistake :) Regards, -Ian. On Thu, Mar 28, 2019 at 1:20 AM Taosheng, Wei wrote: > Hi, > I have deleted the branch. And I remember why this happened. At the > beginning, I tried to revert the pr 3688, so I click the "revert"

Re: [Vote] Release Apache Dubbo Spring Boot Project (Incubating) 2.7.1 (RC1)

2019-03-27 Thread Ian Luo
-1, Minor issues, please fix in the next release: > - There are lots of .flattened-pom.xml in source release, which does > not exist in Github tag. For example: > Only in > apache-dubbo-spring-boot-project-incubating-2.7.1-source-release/dubbo-spring-boot-actuator: > .flattened-pom.xml I think w

Re: [Vote] Release Apache Dubbo Spring Boot Project (Incubating) 2.7.1 (RC1)

2019-03-27 Thread Mercy Ma
I also vote -1, a lot of *.flattened-pom.xml* files should be removed from source code, they are useless, thus I will vote again. Kind regards, Mercy Ma On Thu, Mar 28, 2019 at 10:27 AM Ian Luo wrote: > -1, > > Minor issues, please fix in the next release: > > - There are lots of .flattened-pom

Re: Potential copyright issue with transitive npm dependency

2019-03-27 Thread Hen
On Wed, Mar 27, 2019 at 12:56 AM Huxing Zhang wrote: > Hi, > > On Fri, Mar 22, 2019 at 1:55 PM Hen wrote: > > > > > > (including Huxing) > > > > On Thu, Mar 21, 2019 at 10:55 PM Hen wrote: > >> > >> > >> Give substack a few days to reply and then nudge them on Twitter: > https://twitter.com/sub

Re: Potential copyright issue with transitive npm dependency

2019-03-27 Thread Justin Mclean
Hi, > * the test file would not be in the download for Apache Dubbo (and > presumably other typical use cases)? It not in the download it’s only shows up when you instal the software. Users would install via npm to get the dependancies. > * the test file would not be in Apache Dubbo source cont

Re: [Vote] Release Apache Dubbo Spring Boot Project (Incubating) 2.7.1 (RC1)

2019-03-27 Thread jun liu
-1 We should remove those *.flattened-pom.xml files, though it’s not a functionality flaw, it does confuses users who would rely on sources directly. Jun > On Mar 28, 2019, at 12:46 PM, Mercy Ma wrote: > > I also vote -1, a lot of *.flattened-pom.xml* files should be removed from > source cod

Re: Potential copyright issue with transitive npm dependency

2019-03-27 Thread Huxing Zhang
Hi, On Thu, Mar 28, 2019 at 1:49 PM Hen wrote: > > > > > On Wed, Mar 27, 2019 at 12:56 AM Huxing Zhang wrote: >> >> Hi, >> >> On Fri, Mar 22, 2019 at 1:55 PM Hen wrote: >> > >> > >> > (including Huxing) >> > >> > On Thu, Mar 21, 2019 at 10:55 PM Hen wrote: >> >> >> >> >> >> Give substack a few

Re: Potential copyright issue with transitive npm dependency

2019-03-27 Thread Huxing Zhang
Adding some links. On Thu, Mar 28, 2019 at 2:08 PM Huxing Zhang wrote: > > Hi, > > On Thu, Mar 28, 2019 at 1:49 PM Hen wrote: > > > > > > > > > > On Wed, Mar 27, 2019 at 12:56 AM Huxing Zhang wrote: > >> > >> Hi, > >> > >> On Fri, Mar 22, 2019 at 1:55 PM Hen wrote: > >> > > >> > > >> > (includ

Re: never create branch on main repo

2019-03-27 Thread jun liu
Hi, Taosheng For the exact PR[1] that is related to this accident branch, I think it should be reconsidered, I am not sure if the changes in it are right, I will take a look at it later. I noticed you merged it by yourself, since there is no sign suggests that it’s an emergency patch or in so

[VOTE] Release Apache Dubbo Spring Boot Project (Incubating) 2.7.1 (RC2)

2019-03-27 Thread Mercy Ma
Hello Dubbo Community, This is a call for the vote to release Apache Dubbo Spring Boot Project (Incubating) version 2.7.1 (RC2) The release candidates 2.7.1: https://dist.apache.org/repos/dist/dev/incubator/dubbo/spring-boot-project/2.7.1 The staging repo: https://repository.apache.org/content/r

Re: never create branch on main repo

2019-03-27 Thread Taosheng, Wei
hi jun, I have concerned the inappropriate of merging one's pr by one's self. I will not do it like this. About this pr, welcome to review it. If it's wrong, please tell me to fix it or would you please to fix it. Thank you! Taosheng -- Original -- From: jun

CI tasks bumped up, it seems to has stopped being scheduled.

2019-03-27 Thread jun liu
Hi, I noticed the CI tasks for some PRs and branches from several of our projects are waiting to be scheduled, for a really long time. I guess there’re some problems with the Travis system. Please notice that for some minor changes that I am sure will work fine, I will merge them directly witho