[VOTE]: Release Apache Dubbo 2.7.4 [RC2]

2019-10-12 Thread victory
Hello Dubbo Community, This is a call for vote to release Apache Dubbo version 2.7.4. The release candidates: https://dist.apache.org/repos/dist/dev/dubbo/2.7.4/ The staging repo: https://repository.apache.org/content/repositories/orgapachedubbo-1045 Git tag for the release: https://github.com/

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC2]

2019-10-12 Thread 郑泽超
+1,I have been looking forward to it for a long time. > 在 2019年10月12日,下午7:26,victory 写道: > > Hello Dubbo Community, > > This is a call for vote to release Apache Dubbo version 2.7.4. > > The release candidates: > https://dist.apache.org/repos/dist/dev/dubbo/2.7.4/ > > The staging repo: > https

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC2]

2019-10-14 Thread Mercy Ma
+1 approved Kind regards, Mercy On Sat, Oct 12, 2019 at 7:26 PM victory wrote: > Hello Dubbo Community, > > This is a call for vote to release Apache Dubbo version 2.7.4. > > The release candidates: > https://dist.apache.org/repos/dist/dev/dubbo/2.7.4/ > > The staging repo: > https://repository

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC2]

2019-10-15 Thread Lonre Wang
+1 Mercy Ma 于2019年10月15日周二 下午1:06写道: > +1 approved > > Kind regards, > Mercy > > On Sat, Oct 12, 2019 at 7:26 PM victory wrote: > > > Hello Dubbo Community, > > > > This is a call for vote to release Apache Dubbo version 2.7.4. > > > > The release candidates: > > https://dist.apache.org/repos/d

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC2]

2019-10-15 Thread Jun Liu
Hi, Please help to check the contents listed in this mail, list the parts you checked when voting can help others following. Refer this article for how to do the check: http://dubbo.apache.org/zh-cn/blog/prepare-an-apache-release.html Thanks. Jun > On Oct 15, 2019, at 3:42 PM, Lonre Wang wr

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC2]

2019-10-15 Thread Jun Liu
+1 binding. I checked: * signatures and hashes are good. Seems this time you signed with a new key. * LICENSE and NOTICE exit and contents are good * All files no binaries * `mvn clean test` can pass: Mac + Oracle JDK 1.8 * tags match with source * staged maven artifacts are ok. * Issues pointed i

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC2]

2019-10-15 Thread Justin Mclean
Hi, +1 (binding) I checked: - signatures and hashes fine - LICENSE and NOTICE OK - no unexpected binary files - source files have ASF headers - can compile from source RE the software grant normally when a copyright is removed and the headers replaced you need to put something in NOTICE saying

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC2]

2019-10-17 Thread victory
We’ve received 3 +1 binding votes and 2 +1 non-binding vote: +1 binding, Mercy Ma +1 binding, Justin Mclean +1 binding, Jun Liu +1 non-binding, Lonre Wang +1 non-binding , 郑泽超 I will release dubbo-2.7.4 today. Best regards, The Apache Dubbo (Incubating) Team Justin Mclean 于2019年10月16日周三 上午10:58

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC2]

2019-10-20 Thread bailei
-1. I don’t know if I am qualified from voting. Is 2.7.4 released? I think there is a issue need to be checked (https://github.com/apache/dubbo/issues/5186 ). Fix me if I was wrong. > 在 2019年10月18日,上午9:46,victory 写道: > > We’ve received 3 +1 bindi

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC2]

2019-10-20 Thread Jason Joo
-1. So will it be included in 2.7.4 or 2.7.5? One of our project using annotations came to introduce multiple registries. But we found that there was a bug on subscribing same interface from different registries before 2.7.3(inclusive) util #5033(https://github.com/apache/dubbo/pull/5033) had

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC2]

2019-10-20 Thread victory
I have released dubbo-2.7.4 two days ago. If you have some problem, please file an issue on https://github.com/apache/dubbo/issues If your problem is very severe, we will try to fix in next release as soon as possible. Jason Joo 于2019年10月21日周一 上午8:49写道: > -1. > > So will it be included in 2.7.4

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC2]

2019-10-21 Thread bailei
IMO, it is quite serve. Step 1: Upgrade dubbo to 2.7.4 in dubbo-samples-api. Step 2: Start `org.apache.dubbo.samples.provider.Application`. Will report an NPE problem. > 在 2019年10月21日,下午2:30,victory 写道: > > I have released dubbo-2.7.4 two days ago. > If you have some problem, please file an is

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC2]

2019-10-21 Thread Jason Joo
And I'm ok to file a NEW issue but will anyone to discuss and follow together? It seems that most guys are busy currently. Maybe for the event of 11.11? This issue would affect quite a large amount of upgraded users. An active issue needs our following up in time so we can do it better. And I

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC2]

2019-10-21 Thread victory
I will check this problem, and I will give you reply. If this problem is servere and urgent, I will try to fix it in a fix version on this week. Jason Joo 于2019年10月21日周一 下午3:26写道: > And I'm ok to file a NEW issue but will anyone to discuss and follow > together? > > It seems that most guys are

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC2]

2019-10-21 Thread Jason Joo
Hi, victory Thank you for your following. And the issue is #5186 (https://github.com/apache/dubbo/issues/5186 ) We will not need a new issue I think. And I filed two issues one of which is a resubmitted for quite an old one to mark it out that we sh

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC2]

2019-10-21 Thread victory
I have found the problem, and I think it should be fixed as soon as possible. We will release dubbo-2.7.4.1 in this week victory 于2019年10月21日周一 下午4:15写道: > I will check this problem, and I will give you reply. > If this problem is servere and urgent, I will try to fix it in a fix > version on

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC2]

2019-10-21 Thread Jun Liu
Hi Bailei, Jason > But after updating to branch of 2.7.4 we continue to suffer the NPE issue > (Location AbstractInterfaceConfig.useRegistryForConfigIfNecessary which is > mentioned by @bailei). The issue you reported is indeed a serious issue that need to be fixed. Though the Cvictory hasn’

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC2]

2019-10-21 Thread bailei
The fix code looks good to me. I think we need a basic flow smoking unit test, such as:provider export service->consumer subscribe -> consumer call -> validate what we expect.The registry I suggest using a embedded zookeeper server. Anyway,just a quick thought in my mind, I think the community wi

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC2]

2019-10-22 Thread victory
We have some integration test in https://github.com/apache/dubbo-samples . If you have installed docker in your computer, you can run it directly. At round 1 of 2.7.4 release vote, I have run the integration test, and it work well. But before round 2 of 2.7.4 release vote, we try to fix an issue