Re: [VOTE]: Release Apache dubbo-go v1.2.0 RC1

2019-11-14 Thread xinming he
Hello Dubbo/Dubbogo Community, The release Apache dubbo-go version v1.2.0 RC1 vote finished, We’ve received 3 (binding) votes. +1 binding, Jun Liu +1 binding, Mercy Ma +1 binding, Ian Luo The vote and result thread: https://lists.apache.org/thread.html/a3f79295e7467c973ecc6efbd665b741126bff19

Re: [VOTE]: Release Apache dubbo-go v1.2.0 RC1

2019-11-14 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release. [v] Are release files in correct location? [v] Are the digital signature and hashes correct? [v] Do LICENSE and NOTICE files exists? [v] Is the LICENSE and NOTICE text correct? [v] Is the NOTICE year correct? [x] Un-included soft

Re: [VOTE]: Release Apache dubbo-go v1.2.0 RC1

2019-11-14 Thread Mercy Ma
+1 Binding. KInd regards, Mercy Ma On Fri, Nov 1, 2019 at 7:39 PM xinming he wrote: > Hello Dubbo/Dubbogo Community, > > > This is a call for vote to release Apache dubbo-go version v1.2.0 RC1. > > > The release candidates: > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.2.0-rc1/ >

Re: [VOTE]: Release Apache dubbo-go v1.2.0 RC1

2019-11-12 Thread Jun Liu
+1 biding. Though I still have questions about how the UT works exactly and agree this issue should better being fixed, I think it should not be a release blocker and can be done the next time. Xinming has clearly stated, the origin of the zookeeper jar file hosted in her[1] is an official zook

Re: [VOTE]: Release Apache dubbo-go v1.2.0 RC1

2019-11-12 Thread Jun Liu
Sorry, I just noticed that you stated that’s no source code change. But I still don’t how did you achieved that without changing any source. Jun > On Nov 13, 2019, at 9:08 AM, Jun Liu wrote: > > Hi, Xinming > >> I changed the zookeeper fatjar which will be download by executing >> before_ut.

Re: [VOTE]: Release Apache dubbo-go v1.2.0 RC1

2019-11-12 Thread Jun Liu
Hi, Xinming > I changed the zookeeper fatjar which will be download by executing > before_ut.sh file to a clearly resource from [1] ,which is official website > of apache zookeeper. Do you mean you repackaged the source? If so, I think we need to start a new thread like 'v1.2.0 RC2' to vote.

Re: [VOTE]: Release Apache dubbo-go v1.2.0 RC1

2019-11-08 Thread xinming he
Hi, I changed the zookeeper fatjar which will be download by executing before_ut.sh file to a clearly resource from [1] ,which is official website of apache zookeeper. And because the website does not provide the link of fatjar file, we need to download the whole release package of zookeeper-

Re: [VOTE]: Release Apache dubbo-go v1.2.0 RC1

2019-11-04 Thread Jun Liu
Hi, Xinming As Justin has pointed. It’s fine to use some binary files during developing and include them in the source repo. What volatiles the Apache rule is that we cannot package any binary files into the Apache source release package[1], that should be excluded when packaging if there’s any

Re: [VOTE]: Release Apache dubbo-go v1.2.0 RC1

2019-11-04 Thread xinming he
Thanks for your suggestion, Justin. And how about if I change to the jar where come from [1] clearly provided by [2] and mentioned in README as following: 'As of version 3.5.5, the parent, zookeeper and zookeeper-jute artifacts are deployed to the central repository after the release is voted on

Re: [VOTE]: Release Apache dubbo-go v1.2.0 RC1

2019-11-04 Thread Justin Mclean
Hi, > The jar file is used to start the zookeeper process for code unit testing > temporarily which I download it from [1]. Is there any problem? That depends on if if jar is made from released code or not. I’m a little uncomfortable on having a source release depend on a jar whose origins are

Re: [VOTE]: Release Apache dubbo-go v1.2.0 RC1

2019-11-04 Thread xinming he
Hi, The jar file is used to start the zookeeper process for code unit testing temporarily which I download it from [1]. Is there any problem? Thanks, Xinming He. 1. http://central.maven.org/maven2/org/apache/zookeeper/zookeeper/3.4.9/zookeeper-3.4.9.jar Justin Mclean 于2019年11月4日周一 下午4:06写道:

Re: [VOTE]: Release Apache dubbo-go v1.2.0 RC1

2019-11-04 Thread Justin Mclean
Hi, I noticed that before_ut.sh is missing an execute bit. I also noticed that the install script grabs a jar from here [1]. How is that jar produced? Thanks, Justin 1. https://github.com/dubbogo/resources/tree/master/zookeeper-4unitest/contrib/fatjar

Re: [VOTE]: Release Apache dubbo-go v1.2.0 RC1

2019-11-03 Thread Jun Liu
+1 binding, I checked: * signature and hash are good * no binary files in source package * source matches with github tag * Jun > On Nov 1, 2019, at 7:39 PM, xinming he wrote: > > Hello Dubbo/Dubbogo Community, > > > This is a call for vote to release Apache dubbo-go version v1.2.0 RC1.

[VOTE]: Release Apache dubbo-go v1.2.0 RC1

2019-11-01 Thread xinming he
Hello Dubbo/Dubbogo Community, This is a call for vote to release Apache dubbo-go version v1.2.0 RC1. The release candidates: https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.2.0-rc1/ Git tag for the release:https://github.com/apache/dubbo-go/tree/v1.2.0-rc01 Hash for the releas