Re: Fragment support

2009-05-06 Thread Richard S. Hall
On 5/6/09 3:24 PM, Filippo Diotalevi wrote: On Wed, May 6, 2009 at 1:15 AM, Richard S. Hall wrote: No problem. I have another fix to commit once SVN is working again. Had the time to do only some tests - host and fragment import the same package - host and fragment import the same v

Re: Fragment support

2009-05-06 Thread Filippo Diotalevi
On Wed, May 6, 2009 at 1:15 AM, Richard S. Hall wrote: > No problem. I have another fix to commit once SVN is working again. Had the time to do only some tests - host and fragment import the same package - host and fragment import the same versioned package everything is working well. -- Filipp

Re: Fragment support

2009-05-05 Thread Richard S. Hall
No problem. I have another fix to commit once SVN is working again. -> richard On 5/5/09 5:19 PM, Filippo Diotalevi wrote: On Tue, May 5, 2009 at 6:40 PM, Richard S. Hall wrote: Filippo, As it turns out, the use case I was trying to solve for GF also had overlapping requirements, so I wa

Re: Fragment support

2009-05-05 Thread Filippo Diotalevi
On Tue, May 5, 2009 at 6:40 PM, Richard S. Hall wrote: > Filippo, > > As it turns out, the use case I was trying to solve for GF also had > overlapping requirements, so I was forced to loosen up conflict > determination to some degree. I did as I said below, which is to check if > the requirements

Re: Fragment support

2009-05-05 Thread Richard S. Hall
Filippo, As it turns out, the use case I was trying to solve for GF also had overlapping requirements, so I was forced to loosen up conflict determination to some degree. I did as I said below, which is to check if the requirements are identical, if so I allow it, otherwise it is a conflict a

Re: Fragment support

2009-05-03 Thread Richard S. Hall
On 5/3/09 1:45 PM, Filippo Diotalevi wrote: If redundant imports (same package, same version range) could be simply ignored it would be great; but if it's too much work to implement it now, for me it's not a big problem. The support is definitely good enough (and specification-compliant, for what

Re: Fragment support

2009-05-03 Thread Filippo Diotalevi
On Sun, May 3, 2009 at 4:51 PM, Richard S. Hall wrote: > I am not so worried since I know the area we are discussing can be improved > later. I guess the question we need to answer for now is, is this level of > support good enough to move forward for now and we can improve it later > (release ear

Re: Fragment support

2009-05-03 Thread Marcel Offermans
On May 3, 2009, at 18:13 , Richard S. Hall wrote: On 5/3/09 11:58 AM, Marcel Offermans wrote: So what if there was a bundle that actually exported: foo;version=1.0.0 and foo;version=2.0.0. One could argue that this would allow this bundle to be wired to the one above, which needs version 1 and

Re: Fragment support

2009-05-03 Thread Richard S. Hall
On 5/3/09 11:58 AM, Marcel Offermans wrote: So what if there was a bundle that actually exported: foo;version=1.0.0 and foo;version=2.0.0. One could argue that this would allow this bundle to be wired to the one above, which needs version 1 and 2, both of which are exported by the same bundle.

Re: Fragment support

2009-05-03 Thread Marcel Offermans
On May 3, 2009, at 16:45 , Richard S. Hall wrote: For example, the host could import foo;version=[1.0.0,1.0.0] and the fragment could import foo;version=[2.0.0,2.0.0]. This would be impossible to resolve. Version is just one attribute, but there could be conflicts with any attribute. It pr

Re: Fragment support

2009-05-03 Thread Richard S. Hall
Yep, you are correct...see my other response. Thanks for really looking into this. I am not so worried since I know the area we are discussing can be improved later. I guess the question we need to answer for now is, is this level of support good enough to move forward for now and we can impr

Re: Fragment support

2009-05-03 Thread Richard S. Hall
On 5/3/09 10:35 AM, Filippo Diotalevi wrote: On Sun, May 3, 2009 at 3:41 PM, Richard S. Hall wrote: The specification is somewhat vague on what it means for a fragment and host (or other fragments) to conflict. Initially I have taken a conservative view of this, so if there is any overlap a

Re: Fragment support

2009-05-03 Thread Filippo Diotalevi
On Sun, May 3, 2009 at 4:35 PM, Filippo Diotalevi wrote: > Just noticed that the (infamous, by now ;-) hibernate bundle example > has the same problem for exports: f.i. the "org.hibernate.cfg" package > is exported by the host bundle and by 2 fragments. Haven't tested this > use case yet. Do you t

Re: Fragment support

2009-05-03 Thread Filippo Diotalevi
On Sun, May 3, 2009 at 3:41 PM, Richard S. Hall wrote: > The specification is somewhat vague on what it means for a fragment and host > (or other fragments) to conflict. Initially I have taken a conservative view > of this, so if there is any overlap at all I consider them to be in > conflict. > >

Re: Fragment support

2009-05-03 Thread Richard S. Hall
The specification is somewhat vague on what it means for a fragment and host (or other fragments) to conflict. Initially I have taken a conservative view of this, so if there is any overlap at all I consider them to be in conflict. It would be possible to loosen this up by allowing overlap if

Re: Fragment support

2009-05-03 Thread Filippo Diotalevi
On Sun, May 3, 2009 at 12:39 PM, Filippo Diotalevi wrote: > Specification wise, I think these double imports should be specified Sorry, *should not* ! -- Filippo Diotalevi

Re: Fragment support

2009-05-03 Thread Filippo Diotalevi
On Sun, May 3, 2009 at 3:31 AM, Richard S. Hall wrote: > [..] > Please try out some fragments and give feedback. > > I will likely need to push a release of this soon, since GF has some > requirements I need to address with it. So any feedback is welcome. Hi Richard, I did a fair amount of test

Re: Fragment support

2009-05-03 Thread Clement Escoffier
By the way, this version support Spring SL4J bundles (using fragment to contribute API implementations). [ 27] [Active ] [1] SLF4J API (1.5.6) [ 28] [Resolved ] [1] SLF4J Jakarta Commons Logging Binding (1.5.6) [ 29] [Active ] [1] Apache Commons Logging (1.1.1) Reg

Re: Fragment support

2009-05-02 Thread Richard S. Hall
p.s. I have deployed new snapshot of framework and main... On 5/2/09 9:31 PM, Richard S. Hall wrote: I recently checked in a first pass at providing support for fragments to do exports, imports, and requires. (Native libraries are not yet supported since that requires some work on the bundle ca

Re: Fragment support 1.0.4 to 1.2 doesn't Import classes

2008-10-14 Thread Felix Meschberger
Hi, Richard S. Hall schrieb: > Just to be clear, you are saying we should check to see if it is an > extension bundle and allow that case, right? Yes. Currently the ManifestParser constructor calls the checkAndNormalizeR4() method, which in turn has the following code to check Extension Bundles:

Re: Fragment support 1.0.4 to 1.2 doesn't Import classes

2008-10-13 Thread Richard S. Hall
Just to be clear, you are saying we should check to see if it is an extension bundle and allow that case, right? -> richard Felix Meschberger wrote: Hi, Richard S. Hall schrieb: Daniel, I just applied a patch to trunk that makes the fragment install exception configurable. For details:

Re: Fragment support 1.0.4 to 1.2 doesn't Import classes

2008-10-13 Thread Felix Meschberger
Hi, Richard S. Hall schrieb: > Daniel, > > I just applied a patch to trunk that makes the fragment install > exception configurable. For details: > >https://issues.apache.org/jira/browse/FELIX-725 In fact IMHO the Fragment-Host checks are to generous. Because they also include Framework Ext

Re: Fragment support 1.0.4 to 1.2 doesn't Import classes

2008-09-12 Thread Richard S. Hall
Daniel, I just applied a patch to trunk that makes the fragment install exception configurable. For details: https://issues.apache.org/jira/browse/FELIX-725 I have deployed a new maven snapshot or you can build from trunk if you want to use it. -> richard Daniel Rubio wrote: I hadn't

Re: Fragment support 1.0.4 to 1.2 doesn't Import classes

2008-09-11 Thread Daniel Rubio
I hadn't actually tried to upgrade until now, and since some of the bundles I was using were libraries (apache tomcat, jasper compiler,etc) I didn't realize they were fragments until I got this message testing on 1.2! I believe ignoring fragments in 1.0.4 - or the Fragment-Host directive -

Re: Fragment support 1.0.4 to 1.2 doesn't Import classes

2008-09-11 Thread Richard S. Hall
Argh! Yes, we probably should have made that configurable. Where were you when I was asking about throwing an exception on fragment install? ;-) I guess the short answer is "no, there is no way to change it". You have two options at this point: 1. Roll your own release that disables the e

Re: Fragment support

2008-08-29 Thread Richard S. Hall
Stuart McCulloch wrote: 2008/8/18 Alin Dreghiciu <[EMAIL PROTECTED]> On Sat, Aug 16, 2008 at 6:54 PM, Richard S. Hall <[EMAIL PROTECTED]> wrote: Hello everyone, Currently, we log a WARNING when people install a fragment, which says that fragments are not fully supported.

Re: Fragment support

2008-08-28 Thread Stuart McCulloch
2008/8/18 Alin Dreghiciu <[EMAIL PROTECTED]> > On Sat, Aug 16, 2008 at 6:54 PM, Richard S. Hall <[EMAIL PROTECTED]> > wrote: > > Hello everyone, > > Currently, we log a WARNING when people install a fragment, which says > that > > fragments are not fully supported. We should decide if we want to k

Re: Fragment support

2008-08-28 Thread Richard S. Hall
Alin Dreghiciu wrote: On Sat, Aug 16, 2008 at 6:54 PM, Richard S. Hall <[EMAIL PROTECTED]> wrote: Hello everyone, Currently, we log a WARNING when people install a fragment, which says that fragments are not fully supported. We should decide if we want to keep this as is or be more specific a

Re: Fragment support

2008-08-18 Thread Alin Dreghiciu
On Sat, Aug 16, 2008 at 6:54 PM, Richard S. Hall <[EMAIL PROTECTED]> wrote: > Hello everyone, > Currently, we log a WARNING when people install a fragment, which says that > fragments are not fully supported. We should decide if we want to keep this > as is or be more specific and indicate the leve

Re: Fragment support

2008-08-18 Thread Rob Walker
This sounds like great news Richard - nice one. I noticed when reading the Spring OSGi page that they had a comment on Felix not fully supporting fragments as a constraint on their dynamic modules approach, so hopefully it will help with that too. -- Rob Richard S. Hall wrote: Hello everyo