Ok, I have pushed the 'JSHint - gjslint' commits.
The framework classes are now clean against this gjslint command:
gjslint --strict --disable 0100 -r ./
I've used the --disable command because the new interface handling
relies on a variable on the prototype that is initialised with a 'non
Thanks, Erik. I'll make sure I run those tools on the JS code before
checking stuff in.
--peter
On 11/7/13 9:05 AM, Erik de Bruin e...@ixsoftware.nl wrote:
Ok, I have pushed the 'JSHint - gjslint' commits.
The framework classes are now clean against this gjslint command:
gjslint --strict
Awesome, thanks.
Any chance you can find time to put this 'recipe' in the wiki?
What are some of the coding style differences you saw between files? Just
whitespace? Or more? Peter and I did run lint most of the time, but I
wasn't using --strict so maybe that's why things went off the rails.
JSHint is about checking much more than whitespace and JSDoc (which is
it doesn't check at all ;-) That is why we need both tools, IMHO.
I could write a whole lot about the tool and why it will certainly
save your behind in large projects (check out my latest commits for
examples), but the tool
Here is the Wiki entry:
https://cwiki.apache.org/confluence/x/W5sTAg
EdB
On Thu, Nov 7, 2013 at 5:11 PM, Alex Harui aha...@adobe.com wrote:
Awesome, thanks.
Any chance you can find time to put this 'recipe' in the wiki?
What are some of the coding style differences you saw between files?
I checked a number of files in yesterday and I'm pretty sure a handful
won't pass glint right now; I meant to do them all, but forgot some so I'm
doing them this morning. If you want to go ahead and run the tool just to
see if and how failures pop-up, go right ahead.
--peter
On 11/6/13 2:40 AM,
I have spend the day running all JS files through JSHint and gjslint.
I fixed about 6 errors that emerged (vars not declared etc.) up, but I
also corrected all whitespace. It's a monster commit, if I get it
finished ;-)
Another issue: there is a rather large discrepancy between the class
Nuts, you sent that just as I turned off my computer last night...
On 11/6/13 7:54 AM, Erik de Bruin e...@ixsoftware.nl wrote:
I have spend the day running all JS files through JSHint and gjslint.
I fixed about 6 errors that emerged (vars not declared etc.) up, but I
also corrected all
I haven't tried all of the example yet. Was going to do that once I
finished up a wiki page and cleaned up the remaining glint issues.
The discrepancy is known and it is something I have been working on
recently. I haven't attempted any @interface stuff yet, so I created some
base classes to
Ok, let's do it this way:
You guys just keep committing (remember to pull before you push ;-))
and I'll fix any merge issues. Once I'm done (I think my tomorrow),
I'll put my changes in a new public branch, so we can test against the
examples to make sure I didn't break anything.
Also,
Ah, and one to remember: there is no need for @this annotations on
class members that are defined on the prototype. I've removed these
references when I encountered them.
EdB
On Wed, Nov 6, 2013 at 5:24 PM, Erik de Bruin e...@ixsoftware.nl wrote:
Ok, let's do it this way:
You guys just keep
OK, I'm all checked in. I'll post an overlay shortly. Lint away!
Thanks,
-Alex
On 11/6/13 8:24 AM, Erik de Bruin e...@ixsoftware.nl wrote:
Ok, let's do it this way:
You guys just keep committing (remember to pull before you push ;-))
and I'll fix any merge issues. Once I'm done (I think my
Alex,
Do you also see the following warning when compiling DataBindingTest to JS:
Data binding will not be able to detect assignments to 'strings'.
dataProvider={MyModel(applicationModel).strings} /
Just checking to make sure I have the same results as you... Also,
when I run the app (debug
On 11/6/13 11:41 PM, Erik de Bruin e...@ixsoftware.nl wrote:
Alex,
Do you also see the following warning when compiling DataBindingTest to
JS:
Data binding will not be able to detect assignments to 'strings'.
dataProvider={MyModel(applicationModel).strings} /
Yes.
Just checking to make sure
Hi,
I would like to run the entire JS framework through the 'gjslint'
tool. This is the JS linter provided by Google to check code that is
to be processed by the Closure Compiler.
It has some very strict whitespace rules, that will result in changes
in most files (although we started out with a
15 matches
Mail list logo
