Re: Record API removal

On 22.10.2015 17:24, Fabian Hueske wrote: Hmm, it took IntelliJ some time to figure out all the consequences of removing the Record API. Seems to be more than I initially expected. @Chesnay, do you want to help? I would push my current version to my repository and you could take over some

Re: FastR-Flink: a new open source Truffle project

Wow! Very nice. Thanks for sharing. I will try it out :-) On Thursday, October 22, 2015, Kunft, Andreas wrote: > FYI: > > > FastR on Flink, a project to combine the R programming language with > Flink, just went open source: > > >

[jira] [Created] (FLINK-2890) Apply JMH on StringSerializationSpeedBenchmark class.

GaoLun created FLINK-2890: - Summary: Apply JMH on StringSerializationSpeedBenchmark class. Key: FLINK-2890 URL: https://issues.apache.org/jira/browse/FLINK-2890 Project: Flink Issue Type: Sub-task

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc0)

Not sure if it's a blocker, but the yarn detached mode is faulty for interactive programs with eager execution calls. The most basic starting point for yarn, i.e. *bin/flink run -m yarn-cluster -yd -n <> examples/Wordcount.jar* fails in a bad way. -- Sachin Goel Computer Science, IIT Delhi m.

Re: Design document for FLINK-2254

Hi Saumitra, As you already noticed, the first version (with duplicates) is highly inefficient and consumes a lot of memory. So, I suggest we drop it for now. The version with the label makes a lot of modifications on the base Graph class, and this, in my opinion would make it more difficult to

[jira] [Created] (FLINK-2891) Key for Keyed State is not set upon Window Evaluation

Aljoscha Krettek created FLINK-2891: --- Summary: Key for Keyed State is not set upon Window Evaluation Key: FLINK-2891 URL: https://issues.apache.org/jira/browse/FLINK-2891 Project: Flink

[jira] [Created] (FLINK-2899) The groupReduceOn* methods which take types as a parameter fail with TypeErasure

Andra Lungu created FLINK-2899: -- Summary: The groupReduceOn* methods which take types as a parameter fail with TypeErasure Key: FLINK-2899 URL: https://issues.apache.org/jira/browse/FLINK-2899 Project:

Re: Kafka source stuck while canceling

I don't think I have the logs for that run anymore, I wasn't smart enough to save it. If I encounter it again I will try to get more info. Thanks, Gyula Stephan Ewen ezt írta (időpont: 2015. okt. 21., Sze, 19:04): > The Kafka consumer API has issue with being interruptible

Re: Design document for FLINK-2254

Hi Vasia, Here is the Google doc. -- Saumitra S. Shahapure On Thu, Oct 22, 2015 at 11:10 AM, Vasiliki Kalavri < vasilikikala...@gmail.com> wrote: > Hi Saumitra, > > could you maybe add your ideas

[jira] [Created] (FLINK-2893) Rename recovery configuration keys

Ufuk Celebi created FLINK-2893: -- Summary: Rename recovery configuration keys Key: FLINK-2893 URL: https://issues.apache.org/jira/browse/FLINK-2893 Project: Flink Issue Type: Improvement

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc0)

On Oct 22, 2015 3:01 PM, "Maximilian Michels" wrote: > > @Stephan: That's right, the detached mode is very useful for streaming > programs. Let's see if we can merge Sachin's pull request to give more > meaningful exceptions in case of user programs which are not > compatible

[jira] [Created] (FLINK-2900) Remove Record-API dependencies from Hadoop Compat module

Fabian Hueske created FLINK-2900: Summary: Remove Record-API dependencies from Hadoop Compat module Key: FLINK-2900 URL: https://issues.apache.org/jira/browse/FLINK-2900 Project: Flink Issue

[jira] [Created] (FLINK-2903) Web interface numeric localization

Greg Hogan created FLINK-2903: - Summary: Web interface numeric localization Key: FLINK-2903 URL: https://issues.apache.org/jira/browse/FLINK-2903 Project: Flink Issue Type: Improvement

Re: [DISCUSS] Java code style

I agree and don't think that it is possible to add good/valuable comments to all the classes in a reasonable time frame. I would stage this effort to add comments lazily as we touch components -or- as people are motivated to add comments. We can add exclusions for this check per file (might be a

[jira] [Created] (FLINK-2901) Several flink-test ITCases depend on Record API features

Fabian Hueske created FLINK-2901: Summary: Several flink-test ITCases depend on Record API features Key: FLINK-2901 URL: https://issues.apache.org/jira/browse/FLINK-2901 Project: Flink Issue

Re: [DISCUSS] Java code style

Could we make certain rules to give warning instead of error? This would allow us to cherry-pick certain rules we would like people to follow but not strictly enforced. - Henry On Thu, Oct 22, 2015 at 9:20 AM, Stephan Ewen wrote: > I don't think a "let add comments to

[jira] [Created] (FLINK-2902) Web interface sort tasks newest first

Greg Hogan created FLINK-2902: - Summary: Web interface sort tasks newest first Key: FLINK-2902 URL: https://issues.apache.org/jira/browse/FLINK-2902 Project: Flink Issue Type: Improvement

Re: [DISCUSS] Java code style

+1 for the google style, but keeping tabs. I'm against a too narrow line length limitation (at least 100) On Thu, Oct 22, 2015 at 6:05 PM, Henry Saputra wrote: > Could we make certain rules to give warning instead of error? > > This would allow us to cherry-pick certain

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc0)

I am onto FLINK-2800 and FLINK-2888 I would not disable YARN detached mode, it is used quite a bit by streaming users and makes perfect sense for streaming jobs, which are always one-shot currently. On Thu, Oct 22, 2015 at 11:03 AM, Maximilian Michels wrote: > I had a gut

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc0)

Hi, I found an issue with the web interface. It only shows the last 5 finished jobs and the "Jobs Finished" counter also goes up to 5. I found FLINK-2206, but it seems that this was fixed for the old interface and broken again in the new one? Shall I open another issue or is there something I

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc0)

@Vasia: We cannot keep infinite history currently, because the history is kept in memory. Should improve that in the future... On Thu, Oct 22, 2015 at 11:31 AM, Maximilian Michels wrote: > @Stephan: That's right, the detached mode is very useful for streaming > programs. Let's

Re: Design document for FLINK-2254

Hi Saumitra, could you maybe add your ideas above in a google doc and share the link, so we can easily comment and/or edit? Thank you! -Vasia. On 22 October 2015 at 10:53, Andra Lungu wrote: > Hi Saumitra, > > As you already noticed, the first version (with duplicates)

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc0)

We still have this issue as blocker https://issues.apache.org/jira/browse/FLINK-2747 I don’t see a fix for this yet, however. > On 22 Oct 2015, at 11:53, Maximilian Michels wrote: > > Ah. Good catch! :) The job counter should not be limited by the size > of the job history.

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc0)

I had a gut feeling this wouldn't be the last RC :) I second Stephan, Ufuk, and Fabian. It's a good idea to start testing the release candidate. We might discover more issues on the way. In the meantime, let's fix FLINK-2763 and FLINK-2800 and push those to the release-0.10 branch. Eager

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc0)

@Stephan: That's right, the detached mode is very useful for streaming programs. Let's see if we can merge Sachin's pull request to give more meaningful exceptions in case of user programs which are not compatible with the detached execution mode. @Vasia: That's a feature :) You can adjust the

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc0)

Thanks! But shouldn't the "completed jobs" counter be updated regardless of the configuration value of how much history we store? On 22 October 2015 at 11:32, Stephan Ewen wrote: > @Vasia: We cannot keep infinite history currently, because the history is > kept in memory.

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc0)

Ah. Good catch! :) The job counter should not be limited by the size of the job history. https://issues.apache.org/jira/browse/FLINK-2206 fixed that for the old web frontend but since we have a new one now... On Thu, Oct 22, 2015 at 11:38 AM, Vasiliki Kalavri wrote: >

[jira] [Created] (FLINK-2897) Use distinct initial indices for OutputEmitter round-robin

Greg Hogan created FLINK-2897: - Summary: Use distinct initial indices for OutputEmitter round-robin Key: FLINK-2897 URL: https://issues.apache.org/jira/browse/FLINK-2897 Project: Flink Issue

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc0)

I just deleted the Record API to check what would break. Doesn't look too scary, just a few tests that need to be adapted. I'm right in the middle of that. Hope to open a PR soon. 2015-10-22 16:42 GMT+02:00 Chesnay Schepler : > @RecordAPI: Yes, i was curious where we are at

Re: [DISCUSS] Java code style

Any ideas how to deal with the mandatory JavaDoc rule for existing code? Just adding empty headers to make the checkstyle pass or start a serious effort to add the missing docs? 2015-10-21 13:31 GMT+02:00 Matthias J. Sax : > Agreed. That's the reason why I am in favor of using

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc0)

We r actually targeting Flink 0.10, since 0.10 would be out by the time we have Flink-Mahout integration in place. On Thu, Oct 22, 2015 at 9:02 AM, Till Rohrmann wrote: > Forget my last mail. Just found out that the Mahout guys are still running > on 0.9-SNAPSHOT. > ​ > >

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc0)

Thanks Till for bringing this up. This is one of the blockers we r facing now for Flink-Mahout integration. It would be great to have this in 0.10. On Thu, Oct 22, 2015 at 8:53 AM, Till Rohrmann wrote: > I found another issue (FLINK-2894 >

Re: [DISCUSS] Java code style

I think we have to document all these classes. Code Style doesn't come for free :) On Thu, Oct 22, 2015 at 3:09 PM, Fabian Hueske wrote: > Any ideas how to deal with the mandatory JavaDoc rule for existing code? > Just adding empty headers to make the checkstyle pass or start

Re: [DISCUSS] Java code style

Sure, I don't expect it to be free. But everybody should be aware of the cost of adding this code style, i.e., spending a huge amount of time on reformatting and documenting code. Alternatively, we could drop the JavaDocs rule and make the transition significantly cheaper. 2015-10-22 15:24

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc0)

I'd like to bring up Vasia's question on the project structure. Stephan started the discussion and proposed a new project structure about three weeks ago [1]. The proposal was refined a bit and eventually backed by many +1s. Do we want to make this happen in 0.10 or do we postpone it after the

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc0)

@RecordAPI: Yes, i was curious where we are at regarding the removal of the Record API. If there are still tests left to port (or other related things) I'd be more than happy to do it (got a /lot/ of free time on my hands). The related JIRA issues weren't particularly helpful though in figuring

[jira] [Created] (FLINK-2895) Duplicate immutable object creation

Greg Hogan created FLINK-2895: - Summary: Duplicate immutable object creation Key: FLINK-2895 URL: https://issues.apache.org/jira/browse/FLINK-2895 Project: Flink Issue Type: Improvement

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc0)

This reminded me that at some point we wanted to remove the old record API ( https://issues.apache.org/jira/browse/FLINK-1681). I think that Chesnay checked with Henry on this topic in JIRA. On Thu, Oct 22, 2015 at 3:38 PM, Fabian Hueske wrote: > I'd like to bring up Vasia's

[jira] [Created] (FLINK-2894) Flink does not allow to specify default serializer for Kryo

Till Rohrmann created FLINK-2894: Summary: Flink does not allow to specify default serializer for Kryo Key: FLINK-2894 URL: https://issues.apache.org/jira/browse/FLINK-2894 Project: Flink

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc0)

Forget my last mail. Just found out that the Mahout guys are still running on 0.9-SNAPSHOT. ​ On Thu, Oct 22, 2015 at 2:53 PM, Till Rohrmann wrote: > I found another issue (FLINK-2894 > ) while helping the > mahout guys

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc0)

I found another issue (FLINK-2894 ) while helping the mahout guys with the flink bindings for Samsara. Currently we don't allow to register default serializer for Kryo. This means it is not possible to specify a serializer for a base class and all

[jira] [Created] (FLINK-2898) Invert Travis CI build order

Greg Hogan created FLINK-2898: - Summary: Invert Travis CI build order Key: FLINK-2898 URL: https://issues.apache.org/jira/browse/FLINK-2898 Project: Flink Issue Type: Improvement

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc0)

Hmm, it took IntelliJ some time to figure out all the consequences of removing the Record API. Seems to be more than I initially expected. @Chesnay, do you want to help? I would push my current version to my repository and you could take over some packages and fix the tests. Just reply to me

Re: [DISCUSS] Java code style

I don't think a "let add comments to everything" effort gives us good comments, actually. It just gives us checkmark comments that make the rules pass. On Thu, Oct 22, 2015 at 3:29 PM, Fabian Hueske wrote: > Sure, I don't expect it to be free. > But everybody should be aware

Re: [VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc0)

Thanks for bringing up the projects and the record API: - Concerning the projects: Nice to have, but not critical, unless we want to change the names of the Maven artifacts. I would rather not rush this - Removal of Record API. Good thing to have, but should not be a release blocker. I would

FastR-Flink: a new open source Truffle project

FYI: FastR on Flink, a project to combine the R programming language with Flink, just went open source: http://mail.openjdk.java.net/pipermail/graal-dev/2015-October/003728.html? Best Andreas