Re: [DISCUSS] Adopting a Code Style and Quality Guide

Thanks for creating this code style and quality guide Stephan. I think Flink can benefit from such a guide. Thus +1 for introducing and adhering to it. Cheers, Till On Thu, Jun 13, 2019 at 5:26 AM Bowen Li wrote: > Hi Stephan, > > Definitely a good guide in principle IMO! I personally already f

Re: [DISCUSS] Adopting a Code Style and Quality Guide

Thanks for the proposal, Stephan. Big +1 on this. This is definitely helpful and indispensable for flink's code quality and healthy community growth. It would also benefit downstream project to integrate flink easier. Till Rohrmann 于2019年6月13日周四 下午3:29写道： > Thanks for creating this code style

Re: [VOTE] FLIP-33: Standardize connector metrics

The rate metrics should end in "PerSecond" instead of "PerSec" to be consistent with existing metrics. I'm a bit unsure whether it makes send to include the In/Out metrics in this proposal, given that these metrics are standardized across all operators already (at least in terms of _/existing/

Re: [DISCUSS] FLIP-33: Standardize connector metrics

Thanks for driving this. I’ve just noticed one small thing. With new SourceReader interface Flink will be able to provide `idleTime` metric automatically. Piotrek > On 13 Jun 2019, at 03:30, Becket Qin wrote: > > Thanks all for the feedback and discussion. > > Since there wasn't any concern

Re: [DISCUSS] Adopting a Code Style and Quality Guide

Thanks for creating this guide Stephan. It is also a good start point to internals doc. One suggestion is we could finally separate the guide into separated files each of which focus on a specific topic. Besides, add the guide to our repository should make contributors more aware of it. Best, tis

Re: [VOTE] FLIP-33: Standardize connector metrics

+1 from my side % Chesnay’s comment. Piotrek > On 13 Jun 2019, at 09:35, Chesnay Schepler wrote: > > The rate metrics should end in "PerSecond" instead of "PerSec" to be > consistent with existing metrics. > > I'm a bit unsure whether it makes send to include the In/Out metrics in this > pro

Re: [DISCUSS] Adopting a Code Style and Quality Guide

This should definitely be split up into topics, agreed. And it should be linked form the "how to contribute" page or the PR template to make contributors aware. On Thu, Jun 13, 2019 at 9:51 AM Zili Chen wrote: > Thanks for creating this guide Stephan. It is also > a good start point to internals

Re: [DISCUSS] Adopting a Code Style and Quality Guide

+1 for it and general content and thank everybody that was involved in creating & writing this down. +1 for splitting it up into some easily navigable topics. Piotrek > On 13 Jun 2019, at 09:54, Stephan Ewen wrote: > > This should definitely be split up into topics, agreed. > And it should be

Re: [DISCUSS] Adopting a Code Style and Quality Guide

As for >add the guide to our repository<, it means check in guide files under docs/, possibly docs/flinkDev. If we exclude details of the guide from the doc site, maybe somewhere else. Best, tison. Stephan Ewen 于2019年6月13日周四 下午3:54写道： > This should definitely be split up into topics, agreed. >

[jira] [Created] (FLINK-12827) Extract Optimizer from Stream/BatchTableEnvImpl

Dawid Wysakowicz created FLINK-12827: Summary: Extract Optimizer from Stream/BatchTableEnvImpl Key: FLINK-12827 URL: https://issues.apache.org/jira/browse/FLINK-12827 Project: Flink Issue

Re: [DISCUSS] Adopting a Code Style and Quality Guide

big +1, the content is very useful and enlightening. But it's really too long to look at. +1 for splitting it and expose it to contributors. Even I think it's possible to put its link on the default description of pull request, so that the user has to see it when submits the code. Best, Jingsong

[jira] [Created] (FLINK-12828) Support -f option with a sql script file as input

Zhenghua Gao created FLINK-12828: Summary: Support -f option with a sql script file as input Key: FLINK-12828 URL: https://issues.apache.org/jira/browse/FLINK-12828 Project: Flink Issue Type:

[jira] [Created] (FLINK-12829) jobmaster log taskmanger address when task transition state to failed with error

zhaoshijie created FLINK-12829: -- Summary: jobmaster log taskmanger address when task transition state to failed with error Key: FLINK-12829 URL: https://issues.apache.org/jira/browse/FLINK-12829 Project:

Re: [DISCUSS] Start a user...@flink.apache.org mailing list for the Chinese-speaking community?

Hey all, the user...@flink.apache.org is now a few months old and I wanted to hear how things are going. >From the number of people in the DingTalk group (5000 ?), I would have expected more people to use the mailing list. But I also understand that mailing lists are an outdated technology from t

[jira] [Created] (FLINK-12830) TableSinkITCase#testBoundedTableSink fails in IDE if run with other tests

Dawid Wysakowicz created FLINK-12830: Summary: TableSinkITCase#testBoundedTableSink fails in IDE if run with other tests Key: FLINK-12830 URL: https://issues.apache.org/jira/browse/FLINK-12830 Pro

[jira] [Created] (FLINK-12831) Split FunctionCatalog into Flink & Calcite specific parts

Dawid Wysakowicz created FLINK-12831: Summary: Split FunctionCatalog into Flink & Calcite specific parts Key: FLINK-12831 URL: https://issues.apache.org/jira/browse/FLINK-12831 Project: Flink

[jira] [Created] (FLINK-12832) Enhance StreamGraphGenerator/StreamGraph for Blink Table Runner

Aljoscha Krettek created FLINK-12832: Summary: Enhance StreamGraphGenerator/StreamGraph for Blink Table Runner Key: FLINK-12832 URL: https://issues.apache.org/jira/browse/FLINK-12832 Project: Flin

Re: [VOTE] FLIP-33: Standardize connector metrics

Hi Chesnay and Piotr, Thanks for the reply. I have updated the wiki page to change rate metric name from "PerSec" to "PerSecond". And yes, the I/O metrics are sort of standardized across all the operators, and probably for all the connectors in Flink as well. The reason I included them into the c

Re: [DISCUSS] FLIP-33: Standardize connector metrics

Hi Piotr, That's great to know. Chances are that we will need to revisit the convention list and adjust them accordingly when FLIP-27 is ready, At that point we can mark some of the metrics as available by default for connectors implementing the new interface. Thanks, Jiangjie (Becket) Qin On T

[jira] [Created] (FLINK-12833) Add Klaviyo to Chinese PoweredBy page

Fabian Hueske created FLINK-12833: - Summary: Add Klaviyo to Chinese PoweredBy page Key: FLINK-12833 URL: https://issues.apache.org/jira/browse/FLINK-12833 Project: Flink Issue Type: Task

[jira] [Created] (FLINK-12834) Support CharType and BinaryType in blink runner

Jingsong Lee created FLINK-12834: Summary: Support CharType and BinaryType in blink runner Key: FLINK-12834 URL: https://issues.apache.org/jira/browse/FLINK-12834 Project: Flink Issue Type: N

Re: [DISCUSS] Adopting a Code Style and Quality Guide

+1 I think this is a very good effort and should put to rest some back-and-forth discussions on PRs and some differences in “style” between committers. ;-) > On 13. Jun 2019, at 10:21, JingsongLee > wrote: > > big +1, the content is very useful and enlightening. > But it's really too long to

Re: [DISCUSS] Adopting a Code Style and Quality Guide

+1 for this, I think all contributors can benefit from this. Best, Congxian Aljoscha Krettek 于2019年6月13日周四 下午8:14写道： > +1 I think this is a very good effort and should put to rest some > back-and-forth discussions on PRs and some differences in “style” between > committers. ;-) > > > On 13. Ju

Updating Kinesis Connector to latest Apache licensed libs

The Kinesis Client Library v2.x and the AWS Java SDK v2.x both are now on the Apache 2.0 license. https://github.com/awslabs/amazon-kinesis-client/blob/master/LICENSE.txt https://github.com/aws/aws-sdk-java-v2/blob/master/LICENSE.txt There is a PR for the Kinesis Producer Library to update it t

[jira] [Created] (FLINK-12835) Time conversion is wrong in ManualClock

BoWang created FLINK-12835: -- Summary: Time conversion is wrong in ManualClock Key: FLINK-12835 URL: https://issues.apache.org/jira/browse/FLINK-12835 Project: Flink Issue Type: Bug Compone

[jira] [Created] (FLINK-12836) Allow retained checkpoints to be persisted on success

Andrew Duffy created FLINK-12836: Summary: Allow retained checkpoints to be persisted on success Key: FLINK-12836 URL: https://issues.apache.org/jira/browse/FLINK-12836 Project: Flink Issue T

[jira] [Created] (FLINK-12837) MiniClusterResource: java.lang.NoSuchFieldError: BIND_PORT

Sahar Jazebi created FLINK-12837: Summary: MiniClusterResource: java.lang.NoSuchFieldError: BIND_PORT Key: FLINK-12837 URL: https://issues.apache.org/jira/browse/FLINK-12837 Project: Flink

About Contributor Permission

Hi, I've been using Apache Flink for a year and I find it quite interesting. Now I really want to make contribution to Apache Flink so that it will become more popular and useful for big data application. Would you please give me the contributor permission? My JIRA ID is lemony. Best, Kevin

[jira] [Created] (FLINK-12838) Netty-fy the network SSL setup

Nico Kruber created FLINK-12838: --- Summary: Netty-fy the network SSL setup Key: FLINK-12838 URL: https://issues.apache.org/jira/browse/FLINK-12838 Project: Flink Issue Type: Sub-task C

[jira] [Created] (FLINK-12839) Package flink-shaded-netty-tcnative-dynamic into opt/

Nico Kruber created FLINK-12839: --- Summary: Package flink-shaded-netty-tcnative-dynamic into opt/ Key: FLINK-12839 URL: https://issues.apache.org/jira/browse/FLINK-12839 Project: Flink Issue Typ

Re: Updating Kinesis Connector to latest Apache licensed libs

Hi Dyana, Thanks for bringing this up! You are right that ASL is the blocker for us to officially include flink-connecotr-kinesis as a connector module to build and publish to Maven central. I've been thru the mess of building, publishing, and maintaining flink-connector-kinesis via Jfrog, and th

Re: Support for controlling slot assignment based on CPU requirements

Hi Xintong Song, Thanks for the response. I’d thought that the slotSharingGroup(“name”) method call was only available for streaming jobs - as I’d noted below, I’m running a batch workflow. Or is there a way to get this to work? I see that support for slot sharing groups is in Flink’s runtime,

[Contributors List] [JIRA] - Request to be added

Hi, I would like to ask to please be added to the Apache Flink contributors list and to obtain permission to assign JIRA's to myself. GitHub: hmcl Apache JIRA Id: hmclouro Thank you Hugo PS. I have already submitted an ICLA since I am an Apache PMC/Committer

Re: [DISCUSS] Start a user...@flink.apache.org mailing list for the Chinese-speaking community?

I resonate with your concerns Robert. It's because most questions are asked in the DingTalk group which has close to 10,000 people now. Here're my observations and thoughts. Group chat is great for marketing, announce news and updates, broadcast live streams/events, and is just TERRIBLE for ask-an

[jira] [Created] (FLINK-12840) Problems with ipv6 adresses

Pavel Potseluev created FLINK-12840: --- Summary: Problems with ipv6 adresses Key: FLINK-12840 URL: https://issues.apache.org/jira/browse/FLINK-12840 Project: Flink Issue Type: Bug C

[jira] [Created] (FLINK-12841) Unify catalog meta-objects implementations and remove their interfaces

Bowen Li created FLINK-12841: Summary: Unify catalog meta-objects implementations and remove their interfaces Key: FLINK-12841 URL: https://issues.apache.org/jira/browse/FLINK-12841 Project: Flink

Re: [DISCUSS] Adopting a Code Style and Quality Guide

Big +1 and thanks for preparing this. I think wha't more important is making sure most all the contributors can follow the same guide, a clear document is definitely a great start. Committers can first try to follow the guide by self, and spread the standard during code reviewing. Best, Kurt On

Re: [DISCUSS] Releasing Flink 1.8.1

Hi all, After the recent efforts of all of you, all the Issues of Blocker and Critical will be completed soon! :) There are only 2 issues left and they are also almost done: [Blocker] - FLINK-12297 Work by @Aitozi Being reviewed by @Aljoscha Krettek ! [almost done].

Re: Updating Kinesis Connector to latest Apache licensed libs

Hi, Thanks Dyana for bringing this up and Bowen for helping to move this forward. Very happy to hear about this! Please feel free to to create a new JIRA ticket for this and assign it to yourself. +1 to aim this for 1.9.0. The subtasks that Bowen mentioned looks good to me. Issues such as [1] and

Apply for a conributor permission

Hi, I want to contribute to Apache Flink. Would you please give me the contributor permission? My JIRA ID is BeauHe,

Re: [DISCUSS] FLIP-44: Support Local Aggregation in Flink

Hi Aljoscha, I have looked at the "*Process*" section of FLIP wiki page.[1] This mail thread indicates that it has proceeded to the third step. When I looked at the fourth step(vote step), I didn't find the prerequisites for starting the voting process. Considering that the discussion of this fe

Re: [DISCUSS] Start a user...@flink.apache.org mailing list for the Chinese-speaking community?

Thanks Bowen and Robert, Here're my observations and thoughts. 1. Most questions and discussions happen in the DingTalk. 2. We did guide users to use mailing list to ask questions, but people still prefer DingTalk. - We can continue to remind users to use mailing list frequently. 3. All the q

[jira] [Created] (FLINK-12842) Fix invalid check released state during ResultPartition#createSubpartitionView

zhijiang created FLINK-12842: Summary: Fix invalid check released state during ResultPartition#createSubpartitionView Key: FLINK-12842 URL: https://issues.apache.org/jira/browse/FLINK-12842 Project: Flink

[jira] [Created] (FLINK-12843) Refactor the pin logic in ResultPartition

zhijiang created FLINK-12843: Summary: Refactor the pin logic in ResultPartition Key: FLINK-12843 URL: https://issues.apache.org/jira/browse/FLINK-12843 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-12844) Use default conversion class LocalDate/LocalTime/LocalDateTime for DateType/TimeType/TimestampType in blink

Jingsong Lee created FLINK-12844: Summary: Use default conversion class LocalDate/LocalTime/LocalDateTime for DateType/TimeType/TimestampType in blink Key: FLINK-12844 URL: https://issues.apache.org/jira/browse/FL

Re: [DISCUSS] Adopting a Code Style and Quality Guide

Thanks a lot for putting this together! I'm in the process of reworking the "How to contribute" pages [1] and I'm happy to add the guide to the Flink website, once the discussion here is over. [1] https://github.com/apache/flink-web/pull/217 On Fri, Jun 14, 2019 at 3:21 AM Kurt Young wrote: >

Re: [DISCUSS] FLIP-33: Standardize connector metrics

> we will need to revisit the convention list and adjust them accordingly when > FLIP-27 is ready Yes, this sounds good :) Piotrek > On 13 Jun 2019, at 13:35, Becket Qin wrote: > > Hi Piotr, > > That's great to know. Chances are that we will need to revisit the > convention list and adjust

[jira] [Created] (FLINK-12845) Execute multiple statements in command line or sql script file

Zhenghua Gao created FLINK-12845: Summary: Execute multiple statements in command line or sql script file Key: FLINK-12845 URL: https://issues.apache.org/jira/browse/FLINK-12845 Project: Flink