Re: [RESULT] [VOTE] Apache Flink 1.9.0, release candidate #3

2019-08-21 Thread Shaoxuan Wang
Congratulations and thanks all for the great efforts on release1.9. I have verified the RC#3 with the following items: - Verified signatures and hashes. (OK) - Built from source archive. (OK) - Repository contains all artifacts. (OK) - Test WordCount on local cluster. (OK) a. Both streaming

Re: [DISCUSS] Flink client api enhancement for downstream project

2019-08-21 Thread Yang Wang
>From the user's perspective, it is really confused about the scope of per-job cluster. If it means a flink cluster with single job, so that we could get better isolation. Now it does not matter how we deploy the cluster, directly deploy(mode1) or start a flink cluster and then submit job

[jira] [Created] (FLINK-13814) HiveTableSink should strip quotes from partition values

2019-08-21 Thread Rui Li (Jira)
Rui Li created FLINK-13814: -- Summary: HiveTableSink should strip quotes from partition values Key: FLINK-13814 URL: https://issues.apache.org/jira/browse/FLINK-13814 Project: Flink Issue Type: Bug

Re: CiBot Update

2019-08-21 Thread Zili Chen
Thanks for your announcement. Nice work! Best, tison. vino yang 于2019年8月22日周四 上午8:14写道: > +1 for "@flinkbot run travis", it is very convenient. > > Chesnay Schepler 于2019年8月21日周三 下午9:12写道: > > > Hi everyone, > > > > this is an update on recent changes to the CI bot. > > > > > > The bot now

Re: [DISCUSS][CODE STYLE] Breaking long function argument lists and chained method calls

2019-08-21 Thread Zili Chen
Thanks Andrey for driving the discussion. Just for clarification, what we conclude here are several guidelines without automatic checker/tool guard them, right? Best, tison. Andrey Zagrebin 于2019年8月21日周三 下午8:18写道: > Hi All, > > I suggest we also conclude this discussion now. > > Breaking the

Re: [DISCUSS][CODE STYLE] Usage of Java Optional

2019-08-21 Thread Zili Chen
Thanks for driving this thread Andrey. Conclusion looks good to me. Best, tison. Andrey Zagrebin 于2019年8月21日周三 下午7:25写道: > FYI the PR: https://github.com/apache/flink-web/pull/251 > A review from the discussion participants would be appreciated. > > On Wed, Aug 21, 2019 at 1:23 PM Timo

[jira] [Created] (FLINK-13813) metrics is different between overview ui and metric response

2019-08-21 Thread lidesheng (Jira)
lidesheng created FLINK-13813: - Summary: metrics is different between overview ui and metric response Key: FLINK-13813 URL: https://issues.apache.org/jira/browse/FLINK-13813 Project: Flink

Re: CiBot Update

2019-08-21 Thread vino yang
+1 for "@flinkbot run travis", it is very convenient. Chesnay Schepler 于2019年8月21日周三 下午9:12写道: > Hi everyone, > > this is an update on recent changes to the CI bot. > > > The bot now cancels builds if a new commit was added to a PR, and > cancels all builds if the PR was closed. > (This was

[RESULT] [VOTE] Apache Flink 1.9.0, release candidate #3

2019-08-21 Thread Tzu-Li (Gordon) Tai
I'm happy to announce that we have unanimously approved this candidate as the 1.9.0 release. There are 12 approving votes, 5 of which are binding: - Yu Li - Zili Chen - Gordon Tai - Stephan Ewen - Jark Wu - Vino Yang - Gary Yao - Bowen Li - Chesnay Schepler - Till Rohrmann - Aljoscha Krettek -

Re: [VOTE] Apache Flink 1.9.0, release candidate #3

2019-08-21 Thread David Anderson
+1 (non-binding) I upgraded the flink-training-exercises project. I encountered a few rough edges, including problems in the docs, but nothing serious. I had to make some modifications to deal with changes in the Table API: ExternalCatalogTable.builder became new ExternalCatalogTableBuilder

CiBot Update

2019-08-21 Thread Chesnay Schepler
Hi everyone, this is an update on recent changes to the CI bot. The bot now cancels builds if a new commit was added to a PR, and cancels all builds if the PR was closed. (This was implemented a while ago; I'm just mentioning it again for discoverability) Additionally, starting today you

Re: [DISCUSS][CODE STYLE] Breaking long function argument lists and chained method calls

2019-08-21 Thread Andrey Zagrebin
Hi All, I suggest we also conclude this discussion now. Breaking the line of too long statements (line longness is yet to be fully defined) to improve code readability in case of - Long function argument lists (declaration or call): void func(type1 arg1, type2 arg2, ...) - Long

Re: [VOTE] FLIP-52: Remove legacy Program interface.

2019-08-21 Thread Kostas Kloudas
Thanks a lot! We have the 3 +1's so we can move forward. Cheers, Kostas On Wed, Aug 21, 2019 at 1:30 PM Chesnay Schepler wrote: > > +1 > > On 21/08/2019 13:23, Timo Walther wrote: > > +1 > > > > Am 21.08.19 um 13:21 schrieb Stephan Ewen: > >> +1 > >> > >> On Wed, Aug 21, 2019 at 1:07 PM Kostas

Re: [VOTE] FLIP-52: Remove legacy Program interface.

2019-08-21 Thread Aljoscha Krettek
+1 > On 21. Aug 2019, at 13:30, Chesnay Schepler wrote: > > +1 > > On 21/08/2019 13:23, Timo Walther wrote: >> +1 >> >> Am 21.08.19 um 13:21 schrieb Stephan Ewen: >>> +1 >>> >>> On Wed, Aug 21, 2019 at 1:07 PM Kostas Kloudas wrote: >>> Hi all, Following the FLIP process,

Re: [VOTE] Apache Flink 1.9.0, release candidate #3

2019-08-21 Thread Till Rohrmann
+1 (binding) - tested Flink's Java quickstarts - tested Yarn deployment - tested new web UI - run quickstart job on Flink cluster - reviewed release announcement and release notes Cheers, Till On Wed, Aug 21, 2019 at 1:34 PM Chesnay Schepler wrote: > +1 (binding) > > On 21/08/2019 08:09,

Re: [VOTE] Apache Flink 1.9.0, release candidate #3

2019-08-21 Thread Aljoscha Krettek
+1 I checked the last RC on a GCE cluster and was satisfied with the testing. The cherry-picked commits didn’t change anything related, so I’m forwarding my vote from there. Aljoscha > On 21. Aug 2019, at 13:34, Chesnay Schepler wrote: > > +1 (binding) > > On 21/08/2019 08:09, Bowen Li

Re: [DISCUSS] Release flink-shaded 8.0

2019-08-21 Thread Chesnay Schepler
Nico has opened a PR for bumping netty; we plan to have this merged by tomorrow. Unless anyone has concerns I will kick off the release on Friday. On 19/08/2019 12:11, Nico Kruber wrote: I quickly went through all the changelogs for Netty 4.1.32 (which we currently use) to the latest Netty

Re: [VOTE] Apache Flink 1.9.0, release candidate #3

2019-08-21 Thread Chesnay Schepler
+1 (binding) On 21/08/2019 08:09, Bowen Li wrote: +1 non-binding - built from source with default profile - manually ran SQL and Table API tests for Flink's metadata integration with Hive Metastore in local cluster - manually ran SQL tests for batch capability with Blink planner and Hive

[DISCUSS] FLIP-55: Introduction of a Table API Java Expression DSL

2019-08-21 Thread Timo Walther
Hi everyone, some of you might remember the discussion I started end of March [1] about introducing a new Java DSL for Table API that is not embedded in a string. In particular, it solves the following issues: - No possibility of deprecating functions - Missing documentation for users -

Re: [VOTE] FLIP-52: Remove legacy Program interface.

2019-08-21 Thread Chesnay Schepler
+1 On 21/08/2019 13:23, Timo Walther wrote: +1 Am 21.08.19 um 13:21 schrieb Stephan Ewen: +1 On Wed, Aug 21, 2019 at 1:07 PM Kostas Kloudas wrote: Hi all, Following the FLIP process, this is a voting thread dedicated to the FLIP-52. As shown from the corresponding discussion thread

Re: [DISCUSS][CODE STYLE] Usage of Java Optional

2019-08-21 Thread Andrey Zagrebin
FYI the PR: https://github.com/apache/flink-web/pull/251 A review from the discussion participants would be appreciated. On Wed, Aug 21, 2019 at 1:23 PM Timo Walther wrote: > Thanks for summarizing the discussion Andrey, +1 to this style. > > Regards, > Timo > > > Am 21.08.19 um 11:57 schrieb

Re: [VOTE] FLIP-52: Remove legacy Program interface.

2019-08-21 Thread Timo Walther
+1 Am 21.08.19 um 13:21 schrieb Stephan Ewen: +1 On Wed, Aug 21, 2019 at 1:07 PM Kostas Kloudas wrote: Hi all, Following the FLIP process, this is a voting thread dedicated to the FLIP-52. As shown from the corresponding discussion thread [1], we seem to agree that the Program interface

Re: [DISCUSS][CODE STYLE] Usage of Java Optional

2019-08-21 Thread Timo Walther
Thanks for summarizing the discussion Andrey, +1 to this style. Regards, Timo Am 21.08.19 um 11:57 schrieb Andrey Zagrebin: Hi All, It looks like we have reached a consensus regarding the last left question. I suggest the following final summary: - Use @Nullable annotation where you do

Re: [VOTE] FLIP-52: Remove legacy Program interface.

2019-08-21 Thread Stephan Ewen
+1 On Wed, Aug 21, 2019 at 1:07 PM Kostas Kloudas wrote: > Hi all, > > Following the FLIP process, this is a voting thread dedicated to the > FLIP-52. > As shown from the corresponding discussion thread [1], we seem to agree > that > the Program interface can be removed, so let's make it also

[VOTE] FLIP-52: Remove legacy Program interface.

2019-08-21 Thread Kostas Kloudas
Hi all, Following the FLIP process, this is a voting thread dedicated to the FLIP-52. As shown from the corresponding discussion thread [1], we seem to agree that the Program interface can be removed, so let's make it also official with a vote. Cheers, Kostas [1]

Re: [DISCUSS][CODE STYLE] Create collections always with initial capacity

2019-08-21 Thread Andrey Zagrebin
FYI the PR: https://github.com/apache/flink-web/pull/249 A review from the discussion participants would be appreciated. On Tue, Aug 20, 2019 at 5:29 PM Andrey Zagrebin wrote: > I created an umbrella issue for the code style guide effort and a subtask > for this discussion: >

Re: [VOTE] FLIP-50: Spill-able Heap State Backend

2019-08-21 Thread Yu Li
With 3 binding +1 votes and no +0/-1, this vote passed. Thanks all for voting, will start the implementation soon. Best Regards, Yu On Mon, 19 Aug 2019 at 14:07, Tzu-Li (Gordon) Tai wrote: > +1 > > On Sun, Aug 18, 2019 at 4:30 PM Stephan Ewen wrote: > > > +1 > > > > On Sun, Aug 18, 2019 at

[jira] [Created] (FLINK-13812) Code style for the usage of Java Optional

2019-08-21 Thread Andrey Zagrebin (Jira)
Andrey Zagrebin created FLINK-13812: --- Summary: Code style for the usage of Java Optional Key: FLINK-13812 URL: https://issues.apache.org/jira/browse/FLINK-13812 Project: Flink Issue Type:

Re: [DISCUSS][CODE STYLE] Usage of Java Optional

2019-08-21 Thread Andrey Zagrebin
Hi All, It looks like we have reached a consensus regarding the last left question. I suggest the following final summary: - Use @Nullable annotation where you do not use Optional for the nullable values - If you can prove that Optional usage would lead to a performance degradation

[jira] [Created] (FLINK-13811) Support converting flink table to pandas dataframe

2019-08-21 Thread Jeff Zhang (Jira)
Jeff Zhang created FLINK-13811: -- Summary: Support converting flink table to pandas dataframe Key: FLINK-13811 URL: https://issues.apache.org/jira/browse/FLINK-13811 Project: Flink Issue Type:

[jira] [Created] (FLINK-13810) Update `Elasticsearch Connector` label

2019-08-21 Thread hehuiyuan (Jira)
hehuiyuan created FLINK-13810: - Summary: Update `Elasticsearch Connector` label Key: FLINK-13810 URL: https://issues.apache.org/jira/browse/FLINK-13810 Project: Flink Issue Type: Wish

[jira] [Created] (FLINK-13809) The log directory of Flink Python API is unwritable if it is installed via "sudo"

2019-08-21 Thread Wei Zhong (Jira)
Wei Zhong created FLINK-13809: - Summary: The log directory of Flink Python API is unwritable if it is installed via "sudo" Key: FLINK-13809 URL: https://issues.apache.org/jira/browse/FLINK-13809

Re: [SURVEY] How do you use high-availability services in Flink?

2019-08-21 Thread Zili Chen
In addition, FLINK-13750[1] also likely introduce breaking change on high-availability services. So it is highly encouraged you who might be affected by the change share your cases :-) Best, tison. [1] https://issues.apache.org/jira/browse/FLINK-13750 Zili Chen 于2019年8月21日周三 下午3:32写道: > Hi

[jira] [Created] (FLINK-13808) Checkpoints expired by timeout may leak RocksDB files

2019-08-21 Thread Julius Michaelis (Jira)
Julius Michaelis created FLINK-13808: Summary: Checkpoints expired by timeout may leak RocksDB files Key: FLINK-13808 URL: https://issues.apache.org/jira/browse/FLINK-13808 Project: Flink

[SURVEY] How do you use high-availability services in Flink?

2019-08-21 Thread Zili Chen
Hi guys, We want to have an accurate idea of how users actually use high-availability services in Flink, especially how you customize high-availability services by HighAvailabilityServicesFactory. Basically there are standalone impl., zookeeper impl., embedded impl. used in MiniCluster, YARN

Re: [DISCUSS][CODE STYLE] Breaking long function argument lists and chained method calls

2019-08-21 Thread Zili Chen
Implement question: how to apply the line length rules? If we just turn on checkstyle rule "LineLength" then a huge effort is required to break lines those break the rule. If we use an auto-formatter here then it possibly break line "just at the position" awfully. Is it possible we require only

Re: [VOTE] Apache Flink 1.9.0, release candidate #3

2019-08-21 Thread Bowen Li
+1 non-binding - built from source with default profile - manually ran SQL and Table API tests for Flink's metadata integration with Hive Metastore in local cluster - manually ran SQL tests for batch capability with Blink planner and Hive integration (source/sink/udf) in local cluster - file