Re: Re: Re: [DISCUSS ] Make state.backend.incremental as true by default

2022-07-12 Thread Yun Tang
avoid introducing such new configurations unless we have to. Best Yun Tang From: Yuan Mei Sent: Monday, July 11, 2022 11:53 To: dev Cc: ro...@apache.org Subject: Re: Re: Re: [DISCUSS ] Make state.backend.incremental as true by default Hey Lihe Ma, 1. I do not

Re: Re: Re: [DISCUSS ] Make state.backend.incremental as true by default

2022-07-10 Thread Yuan Mei
t; >> > > How about naming the newly in-memory state-backend, which supports > > >> > > incremental checkpoint, as HeapStateBackend . And let the default > > >> > > state-backend still stay as HashMapStateBackend. > > >> > > By doing so, we

Re: Re: Re: [DISCUSS ] Make state.backend.incremental as true by default

2022-06-26 Thread Hangxiang Yu
er state.backend.incremental could be > >> set > >> > > as true safely, which is so widely accepted according to the > replies in > >> > > this thread. > >> > > 2) your newly in-memory state-backend could also be merged and users > >> who > >> > > w

Re:Re: Re: [DISCUSS ] Make state.backend.incremental as true by default

2022-06-24 Thread Lihe Ma
n >> > the >> > > future if the feature of incremental checkpoint is stable. What do you >> > > think? >> > > >> > > >> > > Best, >> > > Lihe Ma >> > > >> > > >> > > >> > > &g

Re: Re: [DISCUSS ] Make state.backend.incremental as true by default

2022-06-19 Thread Yuan Mei
exan...@ververica.com>: > > > > > > > >+1 > > > > > > > >From my experience, it is actually hard to come up with use cases > > > >where > > > >incremental checkpoints should explicitly not be enabled with the > > >

Re: Re: [DISCUSS ] Make state.backend.incremental as true by default

2022-06-16 Thread LuNing Wang
; > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 在 2022-06-15 21:03:31,"Feifan Wang" 写道: > > >Thanks for bringing this up. > > >Strongly +1 > > > > &g

Re: Re: [DISCUSS ] Make state.backend.incremental as true by default

2022-06-16 Thread Zakelly Lan
t; > >—— > >Name: Feifan Wang > >Email: zoltar9...@163.com > > > > > > Replied Message > >| From | Yuan Mei | > >| Date | 06/15/2022 11:41 | > >| To | dev , > > | > >| Subject | Re: [DISCUSS ] Make state.backend.

Re: [DISCUSS ] Make state.backend.incremental as true by default

2022-06-15 Thread Feifan Wang
Thanks for bringing this up. Strongly +1 —— Name: Feifan Wang Email: zoltar9...@163.com Replied Message | From | Yuan Mei | | Date | 06/15/2022 11:41 | | To | dev , | | Subject | Re: [DISCUSS ] Make state.backend.incremental as true by default | Thanks for bringing

Re: [DISCUSS ] Make state.backend.incremental as true by default

2022-06-14 Thread Yuan Mei
t; considering some corner cases, all agreed on enabling the > > incremental > > > > > > checkpoint as default. > > > > > > > > > > > > Best regards, > > > > > > Jing > > > > > > > > > > > > On Mon, Jun 13, 2022 at 12:17 PM Yun Tang > &g

Re: [DISCUSS ] Make state.backend.incremental as true by default

2022-06-14 Thread Jiangang Liu
> > Best regards, > > > > > Jing > > > > > > > > > > On Mon, Jun 13, 2022 at 12:17 PM Yun Tang > wrote: > > > > > > > > > > > Strongly +1 for making incremental checkpoints as default. Many

Re: [DISCUSS ] Make state.backend.incremental as true by default

2022-06-14 Thread Hangxiang Yu
t; > > > > Strongly +1 for making incremental checkpoints as default. Many > users > > > > have > > > > > ever been asking why this configuration is not enabled by default. > > > > > > > > > > BTW, from my knowledge, not

Re: [DISCUSS ] Make state.backend.incremental as true by default

2022-06-14 Thread David Anderson
; > > > > > > > > BTW, from my knowledge, nothing would happen for > HashMapStateBackend, > > > > > which does not support incremental checkpoint yet, when enabling > > > > > incremental checkpoints. > > > > > > > > &g

Re: [DISCUSS ] Make state.backend.incremental as true by default

2022-06-13 Thread Jing Ge
Hi, Just want to let you know that your email is not shown in the main discussion thread. I am not really sure why this is happening. You might want to check if it works with the subject starting with "Re" instead of "RE", which is the only difference I found. Best regards, Jing On Mon, Jun 13,

RE: [DISCUSS ] Make state.backend.incremental as true by default

2022-06-13 Thread kui yuan
Strongly +1 On 2022/06/13 09:59:17 Lihe Ma wrote: > Hi, Everyone, > > I would like to open a discussion on setting incremental checkpoint as default behavior. > > Currently, the configuration of state.backend.incremental is set as false by default. Incremental checkpoint has been adopted widely in

Re: [DISCUSS ] Make state.backend.incremental as true by default

2022-06-13 Thread Rui Fan
kend, > > > > which does not support incremental checkpoint yet, when enabling > > > > incremental checkpoints. > > > > > > > > > > > > Best > > > > Yun Tang > > > > > > >

Re: [DISCUSS ] Make state.backend.incremental as true by default

2022-06-13 Thread Martijn Visser
happen for HashMapStateBackend, > > > which does not support incremental checkpoint yet, when enabling > > > incremental checkpoints. > > > > > > > > > Best > > > Yun Tang > > > > > > From: Martijn Visser > > >

Re: [DISCUSS ] Make state.backend.incremental as true by default

2022-06-13 Thread Alexander Fedulov
t; ____ > > From: Martijn Visser > > Sent: Monday, June 13, 2022 18:05 > > To: dev@flink.apache.org > > Subject: Re: [DISCUSS ] Make state.backend.incremental as true by default > > > > Hi Lihe, > > > > What happens if we enable

Re: [DISCUSS ] Make state.backend.incremental as true by default

2022-06-13 Thread Jing Ge
point yet, when enabling > incremental checkpoints. > > > Best > Yun Tang > > From: Martijn Visser > Sent: Monday, June 13, 2022 18:05 > To: dev@flink.apache.org > Subject: Re: [DISCUSS ] Make state.backend.incremental as true by defau

Re: [DISCUSS ] Make state.backend.incremental as true by default

2022-06-13 Thread Yun Tang
checkpoints. Best Yun Tang From: Martijn Visser Sent: Monday, June 13, 2022 18:05 To: dev@flink.apache.org Subject: Re: [DISCUSS ] Make state.backend.incremental as true by default Hi Lihe, What happens if we enable incremental checkpoints by default while the used

Re: [DISCUSS ] Make state.backend.incremental as true by default

2022-06-13 Thread Martijn Visser
Hi Lihe, What happens if we enable incremental checkpoints by default while the used memory backend is HashMapStateBackend, which doesn't support incremental checkpoints? Best regards, Martijn Op ma 13 jun. 2022 om 11:59 schreef Lihe Ma : > Hi, Everyone, > > I would like to open a discussion o