[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #202 was SUCCESSFUL (with 1222 tests)

2016-01-26 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #202 was successful. --- Scheduled 1226 tests in total. https://build.spring.io/browse/SGF-NAG-202/ -- This

Re: [ANNOUNCE] Donation of GemFire WAN and CQ code

2016-01-26 Thread William Markito
+1 On Tue, Jan 26, 2016 at 4:34 PM Kirk Lund wrote: > +1 I would like to see this get merged to develop > > On Tue, Jan 26, 2016 at 4:02 PM, Dan Smith wrote: > > > All of the subtasks of GEODE-801 are done; I believe this code is ready > to > > be merged. >

Re: Proposal: Move Events to a non-Repo website

2016-01-26 Thread William Markito
The javascript integration you did looks really good to me... Although the Brazilian calendar might be too much given the number of holidays... :P A separate website would be a bit confusing since it would not be handled or managed within the project or by committers of the project, which might

Re: Proposal: Move Events to a non-Repo website

2016-01-26 Thread William Markito
Hi Dave, I think it's a great idea! In fact, I'd rather have it some how (javascript ?) pull that data from a Google Calendar feed or something like that to automate the updates. +1 On Mon, Jan 25, 2016 at 4:34 PM Dave Barnes wrote: > RFF (Request for Feedback) > > Apache

Re: Proposal: Move Events to a non-Repo website

2016-01-26 Thread Nitin Lamba
+1 for data-driven event calendar! William's suggested solution is available as a jQuery plugin [1]. Nitin [1] http://www.jqueryscript.net/social-media/jQuery-Plugin-To-Display-Google-Calendar-Feeds-On-Your-Website.html From: William Markito

Re: Review Request 42736: GEODE-854: Put pulseversion.properties in generated-resources

2016-01-26 Thread Nitin Lamba
Pulse jar is designed to work as a standalone jar so that it can be deployed separately from the locator. The interaction with the rest of the distributed system is through JMX only. Isn't this code change in PulseAppListener creating a 'gemfire-core' dependency so every pulse installation

Re: Review Request 42736: GEODE-854: Put pulseversion.properties in generated-resources

2016-01-26 Thread Jinmei Liao
> On Jan. 25, 2016, 8:46 p.m., Jinmei Liao wrote: > > Anthony filed a related bug: > > https://issues.apache.org/jira/browse/GEODE-852. I think we should re-use > > the GemfireVersion.properties that is already created in gemfire-core and > > not use this pulseVersion.properties at all. I can

[GitHub] incubator-geode pull request: GEODE-854: refactor gemfire-pulse no...

2016-01-26 Thread jinmeiliao
Github user jinmeiliao closed the pull request at: https://github.com/apache/incubator-geode/pull/78 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request: GEODE-854: refactor gemfire-pulse no...

2016-01-26 Thread jinmeiliao
Github user jinmeiliao commented on the pull request: https://github.com/apache/incubator-geode/pull/78#issuecomment-175088490 this fix needs a dependency in gemfire-core. Will not use this fix. --- If your project is set up for it, you can reply to this email and have your reply

Re: Review Request 42769: GEODE-858: Remove 1 second sleep from InternalLocator.startTcpServer

2016-01-26 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42769/#review116374 --- Ship it! I traced this code back to the early days of GemFire

[GitHub] incubator-geode pull request: Feature/geode 735

2016-01-26 Thread sbawaska
Github user sbawaska commented on the pull request: https://github.com/apache/incubator-geode/pull/77#issuecomment-175137609 Hi Ken, This pull request has a lot of other commits. Can you please close this and open another pull request by following the instructions here

[GitHub] incubator-geode pull request: Feature/geode 735

2016-01-26 Thread pdxrunner
Github user pdxrunner closed the pull request at: https://github.com/apache/incubator-geode/pull/77 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Review Request 42808: GEODE-859: Modularize build script

2016-01-26 Thread Anthony Baker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42808/ --- Review request for geode, Dick Cavender, Darrel Schneider, Mark Bretl, and Dan

Re: Review Request 42808: GEODE-859: Modularize build script

2016-01-26 Thread Anthony Baker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42808/ --- (Updated Jan. 26, 2016, 5:54 p.m.) Review request for geode, Dick Cavender,

Re: Review Request 42808: GEODE-859: Modularize build script

2016-01-26 Thread Jens Deppe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42808/#review116389 --- Ship it! Ship It! - Jens Deppe On Jan. 26, 2016, 5:54 p.m.,

Re: [VOTE] Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

2016-01-26 Thread Nitin Lamba
Just noticed that three of the fixes related to LICENSE and NOTICE files have been put in 'develop' branch so at the time of the next RC, they'll have to be cherry-picked into the release ('1.0.0-incubating.M1' branch). Nitin From: Anilkumar Gingade

Re: Review Request 42768: GEODE-857: Fixing synchronization in SystemFailure.stopWatchDog

2016-01-26 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42768/ --- (Updated Jan. 26, 2016, 6:56 p.m.) Review request for geode, Darrel Schneider

Re: [VOTE] Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

2016-01-26 Thread Anthony Baker
Yep, I’m trying to keep the branches more or less in sync. Roman made an earlier suggestion along these lines to always commit on develop and pull changes into the release branch. Once we agree on the specific changes to include in RC2 I’ll cherry-pick the commits. Anthony > On Jan 26,

Re: Review Request 42808: GEODE-859: Modularize build script

2016-01-26 Thread Dick Cavender
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42808/#review116422 --- Ship it! Nice housekeeping! You da man! - Dick Cavender On

Re: Review Request 42808: GEODE-859: Modularize build script

2016-01-26 Thread Mark Bretl
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42808/#review116435 --- Ship it! It was only a matter of time for this task to be

Re: Review Request 42768: GEODE-857: Fixing synchronization in SystemFailure.stopWatchDog

2016-01-26 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42768/#review116438 --- Ship it! Ship It! - Darrel Schneider On Jan. 26, 2016,

Review Request 42822: GEODE-864: Waiting for conflation thread in conflation tests

2016-01-26 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42822/ --- Review request for geode, Barry Oglesby and xiaojian zhou. Repository: geode

Re: Review Request 42817: GEODE-863: Gfsh-started locator exits after a successful auto-reconnect

2016-01-26 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42817/#review116452 --- Ship it! Ship It! - Hitesh Khamesra On Jan. 26, 2016, 7:16

Lambdas in dunits! Time to remove string invoke?

2016-01-26 Thread Dan Smith
I checked in a minor fix to allow you to use a lambda expression in VM.invoke calls with our dunit framework. For example: String result = vm1.invoke(() -> "Hello from vm1!"); I think we should replace all of the VM.invoke calls that use strings with lambdas instead. That will give us better

Re: Lambdas in dunits! Time to remove string invoke?

2016-01-26 Thread Jinmei Liao
+1 Jinmei > On Jan 26, 2016, at 2:02 PM, Dan Smith wrote: > > I checked in a minor fix to allow you to use a lambda expression in > VM.invoke calls with our dunit framework. For example: > > String result = vm1.invoke(() -> "Hello from vm1!"); > > I think we should replace

Re: Lambdas in dunits! Time to remove string invoke?

2016-01-26 Thread Swapnil Bawaskar
+1 Since this is going to be a lot of tests, any ideas on how to split up the work? On Tue, Jan 26, 2016 at 2:06 PM, Jinmei Liao wrote: > +1 > > Jinmei > > > On Jan 26, 2016, at 2:02 PM, Dan Smith wrote: > > > > I checked in a minor fix to allow you to

Re: Lambdas in dunits! Time to remove string invoke?

2016-01-26 Thread Jens Deppe
+1 awesome! On Tue, Jan 26, 2016 at 2:06 PM, Jinmei Liao wrote: > +1 > > Jinmei > > > On Jan 26, 2016, at 2:02 PM, Dan Smith wrote: > > > > I checked in a minor fix to allow you to use a lambda expression in > > VM.invoke calls with our dunit framework.

Re: java 1.7 support was([jira] [Commented] (GEODE-479) Bump Java Language level to 1.8)

2016-01-26 Thread Swapnil Bawaskar
I found this project https://github.com/orfjackal/retrolambda that should be able to provide backwards compatibility for us. It even has a gradle plugin. The project has limited support for default methods and static methods on interfaces, but I don't think we have any of those. Does the

Re: [VOTE] Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

2016-01-26 Thread Niall Pemberton
On Mon, Jan 25, 2016 at 10:29 PM, Roman Shaposhnik wrote: > On Mon, Jan 25, 2016 at 11:28 AM, Anthony Baker wrote: > > Reviewing the feedback received so far on RC1 we have the following > issues to consider: > > > > 1) The binary NOTICE files needs

Re: Lambdas in dunits! Time to remove string invoke?

2016-01-26 Thread Udo Kohlmeyer
+1 Reflection bad On 27/01/2016 9:12 am, Darrel Schneider wrote: +1 The other cool thing about this change is the IDE will now know about the method calls. In your example it will now know that WANTestBase.createReceiver is being called. The fewer uses of reflection we have the better.

Re: Review Request 42822: GEODE-864: Waiting for conflation thread in conflation tests

2016-01-26 Thread Barry Oglesby
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42822/#review116471 --- Ship it! I think you can remove the 'WANTestBase' from the

[GitHub] incubator-geode pull request: GEODE-735: Create JUnit tests for Of...

2016-01-26 Thread pdxrunner
GitHub user pdxrunner opened a pull request: https://github.com/apache/incubator-geode/pull/79 GEODE-735: Create JUnit tests for OffHeapHelper Added OffHeapHelperJUnitTest class Pre-checkin run - 2 failures, both previously reported and not related to OffHeap You can

Re: Lambdas in dunits! Time to remove string invoke?

2016-01-26 Thread Kirk Lund
+1 yes, let me know what I can do to help! On Tue, Jan 26, 2016 at 2:02 PM, Dan Smith wrote: > I checked in a minor fix to allow you to use a lambda expression in > VM.invoke calls with our dunit framework. For example: > > String result = vm1.invoke(() -> "Hello from

Re: Lambdas in dunits! Time to remove string invoke?

2016-01-26 Thread Kenneth Howe
+1 Ken

Re: Review Request 42822: GEODE-864: Waiting for conflation thread in conflation tests

2016-01-26 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42822/#review116478 ---

Re: Proposal: Move Events to a non-Repo website

2016-01-26 Thread Greg Chase
+1 for supporting Brazilian Holidays +1 for a calendar service that makes it easier for the community to contribute events. On Tue, Jan 26, 2016 at 3:26 PM, Dave Barnes wrote: > First pass, using the calendar of Brazilian Holidays - look just below the > Pivotal events: > >

Review Request 42833: GEODE-865: CI Failure: ConcurrentParallelGatewaySenderOperation_2_DUnitTest.testParallelGatewaySenders_SingleNode_UserPR_localDestroy_RecreateRegion

2016-01-26 Thread Barry Oglesby
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42833/ --- Review request for geode, Dan Smith and xiaojian zhou. Bugs: geode-865

Re: Review Request 42833: GEODE-865: CI Failure: ConcurrentParallelGatewaySenderOperation_2_DUnitTest.testParallelGatewaySenders_SingleNode_UserPR_localDestroy_RecreateRegion

2016-01-26 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42833/#review116489 --- Ship it! Ship it! - Dan Smith On Jan. 26, 2016, 11:47 p.m.,

Re: [ANNOUNCE] Donation of GemFire WAN and CQ code

2016-01-26 Thread Kirk Lund
+1 I would like to see this get merged to develop On Tue, Jan 26, 2016 at 4:02 PM, Dan Smith wrote: > All of the subtasks of GEODE-801 are done; I believe this code is ready to > be merged. > > It's been a week and there have been nothing but positive responses on this >

Re: Review Request 42822: GEODE-864: Waiting for conflation thread in conflation tests

2016-01-26 Thread Dan Smith
> On Jan. 26, 2016, 11:26 p.m., xiaojian zhou wrote: > > gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java, > > line 2165 > > > > > > There is a pauseSender() and

Re: Proposal: Move Events to a non-Repo website

2016-01-26 Thread Dan Smith
+1 Good idea! -Dan On Tue, Jan 26, 2016 at 3:44 PM, Greg Chase wrote: > +1 for supporting Brazilian Holidays > > +1 for a calendar service that makes it easier for the community to > contribute events. > > On Tue, Jan 26, 2016 at 3:26 PM, Dave Barnes

Re: Proposal: Move Events to a non-Repo website

2016-01-26 Thread Dave Barnes
This was a proof-of-concept, but the redesign needs more thought. I think a separate site will allow more flexibility in presentation and design. I'm not sure how much information most publicly-visible Google calendars provide, but this example's pretty slim. Doesn't begin to rival the appearance

Re: Lambdas in dunits! Time to remove string invoke?

2016-01-26 Thread Xiaojian Zhou
+1 It saved a lot of trouble in tracing the method. And introduced a simple interface can make such a big difference. On Tue, Jan 26, 2016 at 3:22 PM, Kenneth Howe wrote: > +1 > > Ken > >