Re: Backwards compatibility for 1.1

+1 On Tue, Nov 1, 2016 at 4:00 PM, Dan Smith wrote: > Hi, > > We made a lot of changes in 1.0 that broke compatibility with old versions > of gemfire for various reasons (package renaming, changing membership > system). I just wanted to confirm that starting with 1.1, we're

Re: [DISCUSS] Graduation

+1 On Mon, Oct 31, 2016 at 2:47 PM, Anilkumar Gingade wrote: > +1 > > On Fri, Oct 28, 2016 at 10:23 PM, Avinash Dongre > wrote: > > > +1 > > > > On Sat, Oct 29, 2016 at 8:40 AM, yang theseus > > wrote: > > > > > +1! > > > > > >

Re: Review Request 48665: GEODE-1542 shared/unordered tcp/ip connection times out, initiating suspicion

an one suspect members. geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java (line 550) <https://reviews.apache.org/r/48665/#comment202683> Same as above. - Jianxia Chen On June 13, 2016, 10:50 p.m., Bruce Schu

Review Request 48667: GEODE-1544: Fail to initiate final check when network partition occurs

/membership/gms/fd/GMSHealthMonitor.java f27e0b8 Diff: https://reviews.apache.org/r/48667/diff/ Testing --- Thanks, Jianxia Chen

Review Request 48239: GEODE-1498 CI Failure: DurableClientCommandsDUnitTest.testCloseDurableClients

/48239/diff/ Testing --- Thanks, Jianxia Chen

Re: Review Request 47908: GEODE-1460 RemoveAll fails with NPE in com.gemstone.gemfire.internal.cache.tier.sockets.CacheClientNotifier.checkAndRemoveFromClientMsgsRegion()

/internal/cache/tier/sockets/CacheClientNotifier.java 80d05ba Diff: https://reviews.apache.org/r/47908/diff/ Testing --- Thanks, Jianxia Chen

Review Request 47908: GEODE-1460 RemoveAll fails with NPE in com.gemstone.gemfire.internal.cache.tier.sockets.CacheClientNotifier.checkAndRemoveFromClientMsgsRegion()

- geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java 80d05ba Diff: https://reviews.apache.org/r/47908/diff/ Testing --- Thanks, Jianxia Chen

Review Request 47504: GEODE-1133 SeparateClassloaderTestRunner has to be re-implemented

/diff/ Testing --- Thanks, Jianxia Chen

Review Request 47501: GEODE-1387 CI Failure: LocatorLauncherRemoteFileIntegrationTest.testStatusUsingWorkingDirectory

in it. Diffs - geode-core/src/main/java/com/gemstone/gemfire/internal/process/ControllableProcess.java f459aed Diff: https://reviews.apache.org/r/47501/diff/ Testing --- Thanks, Jianxia Chen

Re: Review Request 47375: GEODE-1393 locator returns incorrect server information when starting up

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47375/#review133452 --- Ship it! Ship It! - Jianxia Chen On May 13, 2016, 11:54 p.m

Re: Review Request 47358: GEODE-1393 locator returns incorrect server information when starting up

/gemfire/distributed/internal/ServerLocator.java (line 211) <https://reviews.apache.org/r/47358/#comment197505> GEODE-1393 - Jianxia Chen On May 13, 2016, 9:19 p.m., Bruce Schuchardt wrote: > > --- > This is an automati

Re: Review Request 47323: GEODE-732 Unable to create PDXInstance from valid JSON using JSONFormatter

. I will recommend call it array instead of list. - Jianxia Chen On May 12, 2016, 8:10 p.m., Hitesh Khamesra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 47195: GEODE-699 PartitionedRegionSingleHopDUnitTest.test_MetadataServiceCallAccuracy

-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionSingleHopDUnitTest.java f79d6c6 Diff: https://reviews.apache.org/r/47195/diff/ Testing --- Thanks, Jianxia Chen

Re: Review Request 47195: GEODE-699 PartitionedRegionSingleHopDUnitTest.test_MetadataServiceCallAccuracy

/gemfire/internal/cache/PartitionedRegionSingleHopDUnitTest.java f79d6c6 Diff: https://reviews.apache.org/r/47195/diff/ Testing --- Thanks, Jianxia Chen

Re: Review Request 47189: GEODE-1375 When using multicast a new member needs to receive the multicast message digest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47189/#review132694 --- Ship it! Ship It! - Jianxia Chen On May 11, 2016, 5:05 p.m

Review Request 47195: GEODE-699 PartitionedRegionSingleHopDUnitTest.test_MetadataServiceCallAccuracy

/main/java/com/gemstone/gemfire/cache/client/internal/SingleHopClientExecutor.java 30cac5b geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionSingleHopDUnitTest.java 399f1ca Diff: https://reviews.apache.org/r/47195/diff/ Testing --- Thanks, Jianxia Chen

Re: Review Request 46940: GEODE-1329 auto-reconnect attempts cease if kicked out during boot-up of the cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46940/#review131537 --- Ship it! Ship It! - Jianxia Chen On May 3, 2016, 3:43 p.m

GMSHealthMonitor Sequence Diagrams

I have added sequence diagrams for GMSHealthMonitor that monitors the health of Geode distributed system. Have a look: https://cwiki.apache.org/confluence/display/GEODE/GMSHealthMonitor+Message+Sequence+Diagram

Re: Review Request 46801: GEDOE-1321 GMSHealthMonitor: java.lang.IllegalStateException: Timer already cancelled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46801/#review131128 --- Ship it! Ship It! - Jianxia Chen On April 29, 2016, 4:47

Re: Next steps with flickering tests

+1 On Mon, Apr 25, 2016 at 6:54 PM, Kirk Lund wrote: > After completing GEODE-1233, all currently known flickering tests are now > annotated with our FlakyTest JUnit Category. > > In an effort to divide our build up into multiple build pipelines that are > sequential and

Re: Review Request 46590: GEODE-1237 remove the check for network-partition-detection uniformity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46590/#review130514 --- Ship it! Ship It! - Jianxia Chen On April 22, 2016, 10:29

Re: Review Request 46457: GEODE-1268: Cleanup of multiple AvailablePort.getRandomAvailablePort invocations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46457/#review129919 --- Ship it! Ship It! - Jianxia Chen On April 21, 2016, 1:58

Re: Review Request 46474: GEODE-33 - Initial structure for geode-examples with list of examples

g/r/46474/#comment193464> Is the link missing? Or is it just a place holder for now? - Jianxia Chen On April 21, 2016, 5:13 a.m., William Markito wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 46354: GEODE-1072: Removing HDFS related code

ticket to track the feature branch? - Jianxia Chen On April 19, 2016, 12:35 a.m., Dan Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: [VOTE] RC2: Apache Geode (Incubating) second Milestone release - v1.0.0-incubating.M2

+1 On Thu, Apr 14, 2016 at 2:47 PM, Swapnil Bawaskar wrote: > +1 > provided we add a comment to the jira with the workaround. > > On Thu, Apr 14, 2016 at 2:39 PM, Jens Deppe wrote: > > > Dan and I spoke about this. Just briefly looking at the issue, it

Re: Review Request 45993: GEODE-1201: Adding compileRuntimeLibs to geode-assembly for tests Amending bind address configuration for http-service-bind-address

64> Do you need to log the bindAddress? - Jianxia Chen On April 13, 2016, 7:39 p.m., Udo Kohlmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 46156: GEODE-679 Explore removing SocketIOWithTimeout and other classes related to FD soft leak

SocketUtils classes. - Jianxia Chen On April 13, 2016, 5:48 p.m., Bruce Schuchardt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 46123: GEODE-1198 CI Failure: DistributedSystemDUnitTest.testConflictingUDPPort

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46123/#review128587 ------- On April 13, 2016, 4:58 p.m., Jianxia Chen wrote: > > ---

Re: Review Request 46123: GEODE-1198 CI Failure: DistributedSystemDUnitTest.testConflictingUDPPort

option is to ignore the RMIException, since adding a port will also fail the test. Diffs (updated) - geode-core/src/test/java/com/gemstone/gemfire/distributed/DistributedSystemDUnitTest.java 0109845 Diff: https://reviews.apache.org/r/46123/diff/ Testing --- Thanks, Jianxia Chen

Re: Jenkins for release branches?

+1 On Tue, Apr 12, 2016 at 2:53 PM, Dan Smith wrote: > Hi all, > > Can we create a jenkins job that runs on the release branch? We can > probably just configure a job to look for any branches that start with > release-* and do a build on them if there are changes. > > -Dan >

Review Request 46123: GEODE-1198 CI Failure: DistributedSystemDUnitTest.testConflictingUDPPort

reviews.apache.org/r/46123/diff/ Testing --- Thanks, Jianxia Chen

Review Request 46108: GEODE-1216 Fix the scalability of remove member

- geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java 5427d77 Diff: https://reviews.apache.org/r/46108/diff/ Testing --- Thanks, Jianxia Chen

Re: Review Request 46056: GEODE-1178 Unexpected DistributedSystemDisconnectedException caused by RejectedExecutionException

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46056/#review128474 --- Ship it! Ship It! - Jianxia Chen On April 12, 2016, 3:51

Re: Review Request 45994: GEODE-1200 : Deprecating InetAddressUtil

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45994/#review128150 --- Ship it! Ship It! - Jianxia Chen On April 10, 2016, 10:04

Re: Review Request 45844: GEODE-1187 If a server launched by Gfsh goes into auto-reconnect the server's PID file is deleted

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45844/#review127686 --- Ship it! Ship It! - Jianxia Chen On April 6, 2016, 11:39

Re: Review Request 45780: GEODE-960 CI failure: LocatorDUnitTest.testOneLocator failed with AssertionError

/LocatorDUnitTest.java b3cc86c Diff: https://reviews.apache.org/r/45780/diff/ Testing --- Thanks, Jianxia Chen

Re: Review Request 45780: GEODE-960 CI failure: LocatorDUnitTest.testOneLocator failed with AssertionError

elf use the new 1000ms member-timeout. - Jianxia --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45780/#review127336 --- On April 5

Re: New committer and PPMC member: Dave Barnes

Welcome Dave! On Tue, Apr 5, 2016 at 2:59 PM, William Markito wrote: > Please welcome Dave Barnes as a new committer to the Geode project and we > are pleased that he accepted! > > We appreciate all the patches he has already contributed and are > hoping to see many more

Review Request 45780: GEODE-960 CI failure: LocatorDUnitTest.testOneLocator failed with AssertionError

/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java b3cc86c Diff: https://reviews.apache.org/r/45780/diff/ Testing --- Thanks, Jianxia Chen

Re: [discuss] Install Google Analytics for tracking activity on geode.incubator.apache.org

+1 On Fri, Apr 1, 2016 at 10:11 AM, Gregory Chase wrote: > Dear Geode contributors, > In the community marketing world, awareness tracking through analytics such > as website traffic are very important. > > We are currently flying blind on geode.incubator.apache.org. > > We

Re: Review Request 45058: GEODE-1107 CI failure: RestAPIsWithSSLDUnitTest.testSimpleSSL

sit: https://reviews.apache.org/r/45058/#review125358 ------- On March 24, 2016, 10 p.m., Jianxia Chen wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 45058: GEODE-1107 CI failure: RestAPIsWithSSLDUnitTest.testSimpleSSL

- Jianxia --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45058/#review125350 --- On March 24, 2016, 10 p.m., Jianxia C

Re: Review Request 45058: GEODE-1107 CI failure: RestAPIsWithSSLDUnitTest.testSimpleSSL

/gemstone/gemfire/rest/internal/web/controllers/RestAPIsWithSSLDUnitTest.java 852591f geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/DUnitLauncher.java 99548b3 Diff: https://reviews.apache.org/r/45058/diff/ Testing --- RestAPIsWithSSLDUnitTest Thanks, Jianxia Chen

Re: Review Request 45142: GEODE-722 CI failure: Bug42039JUnitTest.testBug42039

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45142/#review124838 --- So we will keep the test and add some comments? - Jianxia Chen

Review Request 45142: GEODE-722 CI failure: Bug42039JUnitTest.testBug42039

/gemstone/gemfire/cache/Bug42039JUnitTest.java dc023a9 Diff: https://reviews.apache.org/r/45142/diff/ Testing --- Thanks, Jianxia Chen

Re: Review Request 45132: GEODE-1115 membership-port-range is not being established properly

/internal/membership/gms/messenger/jgroups-config.xml (line 23) <https://reviews.apache.org/r/45132/#comment187313> How about just call it MEMBERSHIP_PORT_RANGE? - Jianxia Chen On March 21, 2016, 11:25 p.m., Bruce Schuchardt

Re: Review Request 45053: GEODE-936 test is seeing DistributedSystemDisconnectedException exception

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45053/#review124574 --- Ship it! Ship It! - Jianxia Chen On March 18, 2016, 9:45

Re: Review Request 44940: GEODE-1100 Neglect view when it send by member which is not in current view.

/internal/membership/gms/membership/GMSJoinLeave.java (line 1458) <https://reviews.apache.org/r/44940/#comment186277> Does it require "msg.setSender(this.localAddress)" before sending the message? - Jianxia Chen On March 16, 2016, 10:57 p.m., Hites

Re: Review Request 44937: GEODE-515 Make sure that we connect to DS using same udp port.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44937/#review123958 --- Ship it! Ship It! - Jianxia Chen On March 16, 2016, 10:44

Re: Review Request 44939: GEODE-519 Make sure that membership port range is available.

/DistributedSystemDUnitTest.java (line 330) <https://reviews.apache.org/r/44939/#comment186275> Better avoid using AvailablePort. We have seen problems before when using AvailablePort. Can we try something similar to SocketCreator.createServerSocketUsingPortRange? - Jianxi

Re: Review Request 44990: GEODE-947 Client log message misleading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44990/#review124118 --- Ship it! Ship It! - Jianxia Chen On March 17, 2016, 10:50

Review Request 45058: GEODE-1107 CI failure: RestAPIsWithSSLDUnitTest.testSimpleSSL

/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsWithSSLDUnitTest.java 29aab32 Diff: https://reviews.apache.org/r/45058/diff/ Testing --- RestAPIsWithSSLDUnitTest Thanks, Jianxia Chen

Re: Review Request 44858: GEODE-639/640: CI failure: CacheXml80DUnitTest.testCacheServerEnableTcpNoDelay

assigned an available port. Diffs (updated) - geode-core/src/test/java/com/gemstone/gemfire/cache30/CacheXml80DUnitTest.java 98134ce Diff: https://reviews.apache.org/r/44858/diff/ Testing --- precheckin Thanks, Jianxia Chen

Re: Review Request 44813: GEODE-1097 allow Lambda invocations to be named so that they show up in test logs

/BasicDUnitTest.java (line 103) <https://reviews.apache.org/r/44813/#comment185967> This is testing NamedCallable for invokeAsync. We also need a test that uses NamedRunnable. Same thing for vm.invoke. - Jianxia Chen On March 14, 2016, 10:55 p.m., Bruce Schuchardt

Re: Review Request 44813: GEODE-1097 allow Lambda invocations to be named so that they show up in test logs

(line 262) <https://reviews.apache.org/r/44813/#comment185960> The first parameter should be nr, instead of r. - Jianxia Chen On March 14, 2016, 10:55 p.m., Bruce Schuchardt wrote: > > --- > This is an automatically g

Re: Review Request 44802: GEODE-1049 LocatorDUnitTest.testMultipleLocatorsRestartingAtSameTime

description of the fix (even a sentence) in the code review or JIRA, will help understand the fix. - Jianxia Chen On March 14, 2016, 7:19 p.m., Hitesh Khamesra wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 44737: GEODE-1084 strip copyright from jgroups configuration before parsing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44737/#review123227 --- Ship it! Ship It! - Jianxia Chen On March 11, 2016, 10:41

Re: Review Request 44738: geode-1081 remove becomeCoordinator from JoinResponseMessage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44738/#review123226 --- Ship it! Ship It! - Jianxia Chen On March 11, 2016, 10:44

Re: Review Request 44736: GEODE-1078 CI failure: ClientMembershipSelectorDUnitTest.testClientMembershipEventsInServer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44736/#review123225 --- Ship it! Ship It! - Jianxia Chen On March 11, 2016, 10:36

Review Request 44682: GEODE-990 CI Failure: GMSJoinLeaveJUnitTest.testPreparedViewFoundDuringBecomeCoordinator failed with NullPointerException

/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java 202888c Diff: https://reviews.apache.org/r/44682/diff/ Testing --- Thanks, Jianxia Chen

Re: Review Request 44587: GEODE-952: Some time many unit tests fails because locator was ForcedDisconnect

/internal/InternalDistributedSystem.java (line 956) <https://reviews.apache.org/r/44587/#comment184882> Not an issue. Just wonder if pid is 0 in pure java mode, will that affect jmap result? - Jianxia Chen On March 9, 2016, 7:27 p.m., Bruce Schuchardt

Review Request 44548: GEODE-226: JSON seems to lose time portion on getObject

a bb159e7 geode-core/src/test/java/com/gemstone/gemfire/CopyJUnitTest.java 1af9f71 Diff: https://reviews.apache.org/r/44548/diff/ Testing --- Thanks, Jianxia Chen

Review Request 44536: GEODE-1038: CI failure: DistributionAdvisorDUnitTest.testGenericAdvice

: https://reviews.apache.org/r/44536/diff/ Testing --- Thanks, Jianxia Chen

Re: Review Request 44458: Fix GEODE-1039 CI Failure: GMSHealthMonitorJUnitTest.testCheckIfAvailableWithSimulatedHeartBeatWithTcpCheck

or.java 536e26e geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java a96b546 Diff: https://reviews.apache.org/r/44458/diff/ Testing --- Thanks, Jianxia Chen

Re: Review Request 44458: Fix GEODE-1039 CI Failure: GMSHealthMonitorJUnitTest.testCheckIfAvailableWithSimulatedHeartBeatWithTcpCheck

tomatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44458/#review122331 ------- On March 7, 2016, 5:45 p.m., Jianxia Chen wrote: > > --- > This is an au

Review Request 44458: Fix GEODE-1039 CI Failure: GMSHealthMonitorJUnitTest.testCheckIfAvailableWithSimulatedHeartBeatWithTcpCheck

/membership/gms/fd/GMSHealthMonitor.java 536e26e Diff: https://reviews.apache.org/r/44458/diff/ Testing --- Thanks, Jianxia Chen

Re: Review Request 44233: GEODE-1029 fixed test issue, where system is not working properly.

until recently? - Jianxia Chen On March 1, 2016, 10:29 p.m., Hitesh Khamesra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 44035: GEODE-1014: PdxSerializationException Error when putall an object from native client withSecurity enabled

/gemstone/gemfire/security/SecurityTestUtil.java ad9b3e1 geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/excludedClasses.txt 2097878 Diff: https://reviews.apache.org/r/44035/diff/ Testing --- Thanks, Jianxia Chen

Re: Review Request 44035: GEODE-1014: PdxSerializationException Error when putall an object from native client withSecurity enabled

/gemfire/internal/cache/tier/sockets/command/PutAll70.java 7507299 geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/PutAll80.java 6a2b072 Diff: https://reviews.apache.org/r/44035/diff/ Testing --- Thanks, Jianxia Chen

Review Request 44035: PdxSerializationException Error when putall an object from native client withSecurity enabled

/LocalRegion.java b6d8c49 Diff: https://reviews.apache.org/r/44035/diff/ Testing --- Thanks, Jianxia Chen

Re: Review Request 43725: Fix GEODE-944: ServerLauncherJUnitTest fails when ISP redirects DNS failures

f13bb73 geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCreator.java 9a74abd Diff: https://reviews.apache.org/r/43725/diff/ Testing --- Thanks, Jianxia Chen

Re: Review Request 43788: Now we do send heartbeat request while doing tcp check

r.doTCPCheckMember(suspectMember, port)? - Jianxia Chen On Feb. 19, 2016, 10:47 p.m., Hitesh Khamesra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 43768: GEODE-929: Do not use AvailablePort.getRandomAvailablePort in this test to avoid intermittent PortNotAvailable error.

emfire/security/SecurityTestUtil.java (line 344) <https://reviews.apache.org/r/43768/#comment181296> Why the port is set to a fixed number 0? - Jianxia Chen On Feb. 19, 2016, 4:51 p.m., Jinmei Liao wrote: > > --- > Thi

Re: Review Request 43725: Fix GEODE-944: ServerLauncherJUnitTest fails when ISP redirects DNS failures

/ServerLauncherJUnitTest.java 7240daa Diff: https://reviews.apache.org/r/43725/diff/ Testing --- Thanks, Jianxia Chen

Re: Review Request 43725: Fix GEODE-944: ServerLauncherJUnitTest fails when ISP redirects DNS failures

-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherJUnitTest.java aa7e028 gemfire-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherJUnitTest.java 7240daa Diff: https://reviews.apache.org/r/43725/diff/ Testing --- Thanks, Jianxia Chen

Re: Review Request 43725: Fix GEODE-944: ServerLauncherJUnitTest fails when ISP redirects DNS failures

gemfire-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherJUnitTest.java aa7e028 gemfire-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherJUnitTest.java 7240daa Diff: https://reviews.apache.org/r/43725/diff/ Testing --- Thanks, Jianxia Chen

Review Request 43725: Fix GEODE-944: ServerLauncherJUnitTest fails when ISP redirects DNS failures

/gemstone/gemfire/distributed/LocatorLauncherJUnitTest.java aa7e028 gemfire-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherJUnitTest.java 7240daa Diff: https://reviews.apache.org/r/43725/diff/ Testing --- Thanks, Jianxia Chen

Re: GEODE-52 Remove @author tags from Java source

+1 On Wed, Feb 17, 2016 at 1:52 PM, William Markito wrote: > +1 > > Sent from my iPhone > > > On Feb 17, 2016, at 1:44 PM, Kenneth Howe wrote: > > > > +1 > > > > Ken > > > >> On Feb 17, 2016, at 1:35 PM, Anthony Baker wrote: > >> > >>

Re: Review Request 43606: Fixing a suspect NPE string

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43606/#review119495 --- Ship it! Ship It! - Jianxia Chen On Feb. 16, 2016, 5:15 p.m

Re: Review Request 43620: Added stat to know time spent in handover udp message to other executor pool

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43620/#review119494 --- Ship it! Ship It! - Jianxia Chen On Feb. 16, 2016, 8:21 p.m

Re: Review Request 39012: GEODE-106: Invalidate operation fails with IndexMaintenanceException with underlying java.lang.ArrayIndexOutOfBoundsException: 1

fore elementData is reassigned, the second thread picks up the new size, but the array is not updated yet. Will this be a problem for the second thread? If not, then that's fine. - Jianxia Chen On Oct. 5, 2015, 8 p.m., J

Re: Review Request 41991: GEODE-245 QueryMonitor cancellation is being ignored by query using CompactRangeIndex

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41991/#review113513 --- Ship it! Ship It! - Jianxia Chen On Jan. 6, 2016, 9:43 p.m

Re: Ready for release candidate?

+1 On Wed, Jan 6, 2016 at 3:38 PM, Anthony Baker wrote: > I was expecting we would always create release branches from develop. > > > > On Jan 6, 2016, at 3:35 PM, Dan Smith wrote: > > > >> > >> I believe we are farther away from the actual '1.0.0'

Re: Review Request 41694: GEODE-708 Stats for Geode membership health monitor

/GMSHealthMonitorJUnitTest.java d539374 Diff: https://reviews.apache.org/r/41694/diff/ Testing --- Thanks, Jianxia Chen

Review Request 41694: GEODE-708 Stats for Geode membership health monitor

/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java d539374 Diff: https://reviews.apache.org/r/41694/diff/ Testing --- Thanks, Jianxia Chen

Stats for GMS Health Monitor

Hi all, I am trying to implement the stats for Geode membership service health monitor, which monitors the health of the members of the distributed system by heartbeats. I will describe the stats that will be implemented. Please take a look and let me know what you think. Assume you have basic

Re: Review Request 41261: Removing TCPConduit's Stub ID class

, it's fine. - Jianxia Chen On Dec. 11, 2015, 6:33 p.m., Bruce Schuchardt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: New Geode website - Latest changes

+1 On Wed, Dec 9, 2015 at 9:29 AM, Dan Smith wrote: > Looks great! > > -Dan > > On Wed, Dec 9, 2015 at 9:24 AM, Roman Shaposhnik > wrote: > > > Very nicely done! > > > > On Tue, Dec 8, 2015 at 5:02 PM, William Markito > > wrote: >

Re: Review Request 41141: Adding test for tcp check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41141/#review109579 --- Ship it! Ship It! - Jianxia Chen On Dec. 9, 2015, 6:14 p.m

Re: Review Request 41142: new unit tests, minor bugfixes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41142/#review109611 --- Ship it! Ship It! - Jianxia Chen On Dec. 9, 2015, 8:58 p.m

Re: Review Request 41142: new unit tests, minor bugfixes

alView doesn't use newView, instead it uses v, which is the preparedView. So either we have to use newView in line 1776 or remove local variable newView (since we don't use it). - Jianxia Chen On Dec. 9, 2015, 5:41 p.m., Bruce Schuchardt

Re: Review Request 41165: adding a unit test for initiation of suspect processing when shared/unordered connection is lost

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41165/#review109647 --- Ship it! Ship It! - Jianxia Chen On Dec. 10, 2015, 12:02 a.m

Re: Review Request 41171: More GMSJoinLeave test

/internal/membership/gms/membership/GMSJoinLeave.java (line 318) <https://reviews.apache.org/r/41171/#comment169246> Why the "private" keyword is removed? - Jianxia Chen On Dec. 10, 2015, 12:25 a.m., Hites

Re: Review Request 40850: GMSJoinLease junit tests

/internal/membership/gms/membership/GMSJoinLeave.java (line 1487) <https://reviews.apache.org/r/40850/#comment168323> Is it better to make it a protected method? - Jianxia Chen On Dec. 3, 2015, 6:50 p.m., Hitesh Khamesra

Re: Review Request 40608: fixing GEODE-590: CI failure in GMSLocatorRecoveryJUnitTest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40608/#review107631 --- Ship it! Ship It! - Jianxia Chen On Nov. 23, 2015, 7:12 p.m

Re: feature/GEODE-77 ready to merge to develop

+1 On Fri, Nov 20, 2015 at 10:03 AM, Bruce Schuchardt wrote: > We are feature-complete and stable on feature/GEODE-77. We've also staged > a merge to develop and tested the result. > > I'd like to push the merge today. >

Re: Review Request 40085: GEODE-77: members unfairly forced out of the distributed system

gms/fd/GMSHealthMonitor.java (line 481) <https://reviews.apache.org/r/40085/#comment164872> These comments can be removed. - Jianxia Chen On Nov. 9, 2015, 4:41 p.m., Bruce Schuchardt wrote: > > --- > This is an automatically generated e-

Re: Review Request 39738: GEODE-77: moving failure-detection port information into the membership view

/messages/JoinResponseMessage.java (line 110) <https://reviews.apache.org/r/39738/#comment162659> This should be removed as well. gemfire-core/src/test/java/com/gemstone/gemfire/cache30/ReconnectDUnitTest.java (line 329) <https://reviews.apache.org/r/39738/#comment162660&

Re: GEODE-474: Update Gradle Wrapper to Gradle Version 2.8

+1 On Thu, Oct 22, 2015 at 5:30 PM, Dan Smith wrote: > +1 > > -Dan > > On Thu, Oct 22, 2015 at 4:42 PM, Mark Bretl wrote: > > > Hi, > > > > I would like to discuss GEODE-474, > > https://issues.apache.org/jira/browse/GEODE-474. We have not updated our > >

Re: Review Request 39488: GEODE-77: deadlock in GMSJoinLeave

/internal/membership/gms/fd/GMSHealthMonitor.java (line 288) <https://reviews.apache.org/r/39488/#comment161269> Should it return false here? If it returns true here, which means doCheckMember call is successful for the dead member. I am confused. - Jianxia Chen On Oct. 20, 2015, 6:

  1   2   >