Re: Review Request 53566: GEODE-2078: Fix manifest classpath

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53566/#review155358 --- Ship it! Ship It! - Mark Bretl On Nov. 7, 2016, 8:23 p.m

Re: Backwards compatibility for 1.1

+1 for backward compatibility with Geode releases. --Mark On Wed, Nov 2, 2016 at 8:11 AM, Kenneth Howe wrote: > +1 to Dan > +1 to Bruce - the distributedTest extensions for backward compatibility > would great > > > On Nov 1, 2016, at 4:11 PM, Bruce Schuchardt > wrote: > > > > +1 > > > > I sti

Re: Review Request 53335: GEODE-2028: Fix license issues from 1.0.0-incubating release

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53335/#review154466 --- Ship it! Ship It! - Mark Bretl On Oct. 31, 2016, 8:03 p.m

Re: Improving release notes

+1 Thanks Anthony for starting the Release Notes page, I think it is a step in the right direction. I took a look at several other top-level projects and came across two styles that I liked: - Apache Brooklyn: http://brooklyn.apache.org/v/latest/misc/ release-notes.html - Apache Ivy: http://ant.a

Re: Review Request 53290: GEODE-2034: Clean up old releases

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53290/#review154222 --- Ship it! Ship It! - Mark Bretl On Oct. 29, 2016, 9:37 a.m

Re: [DISCUSS] Graduation

+1 On Wed, Oct 26, 2016 at 12:04 PM, Ashvin A wrote: > +1 > > On Tue, Oct 25, 2016 at 5:25 PM, Roman Shaposhnik wrote: > > > inactive > > microsoft.com (Ashvin) > > > > :-( >

Re: Review Request 53190: [GEODE-2037] Update documentation links

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53190/#review153896 --- Ship it! Ship It! - Mark Bretl On Oct. 26, 2016, 8:12 a.m

Re: Coding practices/standards

21, 2016, at 12:27 PM, Mark Bretl wrote: > > > > One more time! :) > > > > Conflicting files > > geode-core/src/test/java/org/apache/geode/disttx/PRDistTXDUnitTest.java > > geode-core/src/test/java/org/apache/geode/disttx/ > PRDistTXWithVersionsDUnitTest.java

Re: Coding practices/standards

Fri, Oct 21, 2016 at 12:08 PM, Jared Stewart wrote: > I just pulled and rebased onto develop, and force pushed into the existing > pull request. It should be clean to merge in now. > > Thanks, > Jared > > On Oct 21, 2016, at 11:57 AM, Mark Bretl wrote: > > > > I

Re: Coding practices/standards

écrit : > >> +1 > >> > >> > >> On 20/10/16 4:56 pm, Mark Bretl wrote: > >>> +1 as well... > >>> > >>> - Pulled changes > >>> - Executed './gradlew clean build' and was successful. > >>> - Modi

Re: Coding practices/standards

;>>>> > > >>>>>> The task is fully suppressible with -x spotlessCheck. Also, if > you > > >> have > > >>>>>> any formatter errors you can automatically fix them with 'gradle > > >>>>>> spotlessApp

Re: Nightly geode build?

Nope, its just running successfully :) Last build was 627 The email plugin being used states the following: E-mail will be sent when a build fails, becomes unstable or returns to stable. There is another email plugin which has more options, including sending every job. I can set it up if that is

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2

+1 - Checked signatures - Ran gfsh: ./gfsh version --full - Built from source - Verified Commit ID atches with source tar ball - Reviewed BUILDING.md Under 'Build from Source on Windows' in BUILDING.md it states minimum Gradle is 2.12, when the gradle.properites file has 2.14.1. When run with 2.1

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

+1 On Mon, Oct 17, 2016 at 2:04 PM, Kirk Lund wrote: > +1 > > > On Mon, Oct 17, 2016 at 12:49 PM, Roman Shaposhnik > wrote: > > > On Mon, Oct 17, 2016 at 10:57 AM, Anthony Baker > wrote: > > > Since the geode docs have now been merged to the develop branch, let’s > > start > > > hosting them o

Re: Coding practices/standards

Dan, There is some extra amount of time, 5-10 minutes extra for the entire project (depending on your CPU). I think the real issue to adding it to the precheckin target and have it be 'effective' is it needs to run successfully, otherwise it would turn into noise most of the time I think. We need

Re: Coding practices/standards

Hi Jared, The Checkstyle plugin is already added to the Gradle build. By default it is turned off, however, if you pass the property '-PstaticAnalysis' to the command-line, it will run CheckStyle and FindBugs. It was setup with only basic configuration, so the small amount of work would be to add

Fwd: incubator-geode git commit: GEODE-1956: fix the race condition that cause the vm only hosts 1 primary bucket

Not sure why this got into master, but probably needs to be reverted. --Mark -- Forwarded message -- From: Date: Mon, Oct 10, 2016 at 11:21 AM Subject: incubator-geode git commit: GEODE-1956: fix the race condition that cause the vm only hosts 1 primary bucket To: comm...@geode.in

Re: Review Request 52698: GEODE-1972: Move Geode Hibernate module to a feature branch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52698/#review152029 --- Ship it! Ship It! - Mark Bretl On Oct. 10, 2016, 10:36 a.m

Re: Review Request 52655: GEODE-1973: add more tests to cover GMSAuthenticator and SimpleSecurityManager

cense header - Mark Bretl On Oct. 10, 2016, 8:14 a.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Adding Apache License header to GetRegionsFunctionJUnitTest

Hi Nabarun, It looks like you added to the 'develop2' branch, did you mean 'develop' instead? --Mark On Fri, Oct 7, 2016 at 11:50 AM, Nabarun Nag wrote: > Hi, > > I am adding the license header to this file. Resolving rat issue. > > Regards > Naba >

Re: Hibernate module and Geode 1.0 ?

+1 for feature branch as well. --Mark On Thu, Oct 6, 2016 at 9:30 AM, Dan Smith wrote: > +1 for moving it to a feature branch. > > -Dan > > On Wed, Oct 5, 2016 at 2:40 PM, Jason Huynh wrote: > > Bumping to see if we have come to a decision on whether we want to move > > this to a feature branc

Re: backward compatibility testing against GemFire 8.x WAN/clients

-1 for this I do understand the intent and reason behind this, however, in addition to the reasons Anthony provided, I do not believe this community should carry the burden of testing compatibility with proprietary/commercial software. Even though Geode has its history in GemFire, I can only see t

Re: 1.0 release branch

Version 1.1.0-incubating has now been created in JIRA. --Mark On Saturday, October 1, 2016, Anthony Baker wrote: > Thanks Swapnil! > > I bumped the version on develop to 1.1.0-incubating. Can someone with > JIRA karma could create the corresponding JIRA version? As we resolve > issues on the

Re: Review Request 52410: GEODE-1949: Adding geode-rebalancer to the binary distribution

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52410/#review150966 --- Ship it! Ship It! - Mark Bretl On Sept. 29, 2016, 3:56 p.m

Re: Review Request 52076: GEODE-1511: Remove test dependencies from pom file

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52076/#review149677 --- Ship it! Ship It! - Mark Bretl On Sept. 19, 2016, 8:49 p.m

Re: Review Request 52019: GEODE-1513: Remove duplicate jars from war files

and found the duplicate jars removed from the pulse.war. Very minor: Do we want to add 'jar.enabled = false' to those projects (geode-pulse and geode-web-api) to make sure we will not create the jars in the future? - Mark Bretl On Sept. 18, 2016, 6:11 p.m., Anthony B

Re: Review Request 51741: [GEODE-1817] Prepare for 'release quality' publishing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51741/#review148766 --- Ship it! Ship It! - Mark Bretl On Sept. 10, 2016, 8:15 p.m

Re: Review Request 51741: [GEODE-1817] Prepare for 'release quality' publishing

gree with Dan. I don't think we want this disabled by default as artifacts need to be signed to be uploaded to Apache repositories - Mark Bretl On Sept. 8, 2016, 12:35 p.m., Jens Deppe wrote: > > --- > This is an automatical

Re: Review Request 51380: GEODE-1809: Refactor GemFireVersion

/GemFireVersion.java (line 77) <https://reviews.apache.org/r/51380/#comment213486> This looks to be getting the wrong property, a duplicate 'SOURCE_REPOSITORY. Should this be changed to 'SOURCE_REVISION'? - Mark Bretl On Aug. 24, 2016, 10:36 a.m.

Re: Publishing of geode javadocs

I can add 'geode-assembly/build/install/' to the archive step in the nightly build or we could create a separate job, if necessary, to add the external javadocs. If we add the external javadocs to the current nightly build, the perma link would be https://builds.apache.org/job/Geode-nightly/lastSuc

Re: Review Request 50604: GEODE-1666: Bump Gradle from 2.12 to 2.14

- Mark Bretl On July 29, 2016, 7:50 a.m., Jens Deppe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Build failed in Jenkins: Geode-release #18

So the report publisher has '**/build/test-results/*.xml, **/build/test-results-flaky/*.xml' which should work. I am not sure why it is not picking up the flaky test failures, however, I did update to remove the space between the two patterns, '**/build/test-results/*.xml,**/build/test-results-flak

Re: Build failed in Jenkins: Geode-release #17

We don't have any information, however, we could add a few shell commands at the beginning of the build to help debug possible issues that could come up? If we need anything specific, we would have to create an INFRA ticket. --Mark On Thu, Jul 28, 2016 at 8:58 AM, Bruce Schuchardt wrote: > Do

Review Request 50522: GEODE-64: Add SonarQube Plugin And Initial Configuration

submitting to Apache SonarQube server at https://analysis.apache.org Thanks, Mark Bretl

Re: Review Request 50436: GEODE-1695: Parameterize build metadata

K, the buildId is only used in GemFireVersion.properties. That file > already has a more useful build date embedded. > > Mark Bretl wrote: > The BuildId is used when getting the 'full' version command in GFSH, > 'gfsh gfsh version --full' > > Ex

Re: Review Request 50436: GEODE-1695: Parameterize build metadata

.apache.org/r/50436/ > ------- > > (Updated July 26, 2016, 9:56 a.m.) > > > Review request for geode, Dick Cavender, Mark Bretl, and Dan Smith. > > > Repository: geode > > > Description > --- >

Re: Geode-nightly still has gemfire-pulse step

I thought the git clean 'gemfire-pulse' was there to catch issues when it was renamed to 'geode-pulse', do we still need it anymore? I think it can be removed. --Mark On Fri, Jul 22, 2016 at 11:02 AM, Kirk Lund wrote: > I believe you're correct -- there is no "gemfire-pulse" so that job should

Re: Build failed in Jenkins: Geode-spark-connector #32

Hey Dan, I have updated the Geode Spark build to exclude all Windows VMs now. --Mark On Mon, Jun 27, 2016 at 10:22 AM, Dan Smith wrote: > Looks like this job also tried to run on a windows slave. Can someone with > access to Jenkins change the labels this job is restricted too? I think > Mark

Re: Build failed in Jenkins: Geode-nightly #508

This was run in a Windows system, which would be fine In the future when Ubuntu runs on Windows, however until then I will add another exclusion to the node label. --Mark On Wednesday, June 22, 2016, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See

Re: com.gemstone.gemfire.ForcedDisconnectException: Member isn't responding to heartbeat requests

+ user@geode.i.a.o On Fri, Jun 17, 2016 at 8:49 AM, Anthony Baker wrote: > I would start by turning on GC logging and see if you have any long > collections. A stop-the-world collection that takes longer than the member > timeout could cause the behavior you are observing. > > You may want to c

Re: Review Request 47157: GEODE-1374: Add a flakyTest build task

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47157/#review137547 --- Ship it! Ship It! - Mark Bretl On June 14, 2016, 9:58 a.m

Re: Review Request 47784: GEODE-1410: Fix artifacts published for modules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47784/#review134623 --- Ship it! Ship It! - Mark Bretl On May 24, 2016, 10:57 a.m

Re: Adding a JIRA component for native client component

Hi Anthony, I have added 'native client' as a JIRA component. Let me know if I can do anything else. --Mark On Saturday, May 21, 2016, Anthony Baker wrote: > I’d like to have a JIRA component to track issues related to the native > client (see GEODE-1416). Any volunteers to do this among the

Re: Geode - Sonar integartion

Not sure where the month went, but got some time now and going to try and get this running on a local setup. Does Pivotal or anyone else have a Gradle configuration for SonarQube that can contribute into the feature/GEODE-64 branch? ;) --Mark On Mon, Apr 11, 2016 at 3:42 PM, Mark Bretl wrote

Re: Review Request 47241: GEODE-1203: include spring-web in gfshDependency.jar

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47241/#review132685 --- Ship it! Ship It! - Mark Bretl On May 11, 2016, 8:45 a.m

Re: Moving to JUnit 4.13-SNAPSHOT

I agree with Dan that depending on a SNAPSHOT version is probably not the best, especially when it is a major part running our tests. This could have problems when no developers change anything but JUnit releases a new snapshot and the nightly build uses the newest release resulting in new failures

Re: Review Request 47129: GEODE-1361: Provide location of geode-web war for use in geode-core

g/r/47129/#comment196485> Same thoughts as Anthony, this looks to add a circular dependency. If this is the case, feels like tests are in the wrong project... - Mark Bretl On May 9, 2016, 10:31 a.m., Jens Deppe

Re: Upgrading Gradle to version 2.12

+1 Thanks Jason! --Mark On Wed, Apr 27, 2016 at 5:22 PM, William Markito wrote: > +1 > > On Wed, Apr 27, 2016 at 10:41 AM, Jason Huynh wrote: > > > Hello Geode dev list, > > > > As a heads up, I am about to check in a change to upgrade the Gradle > > version to 2.12. This will address GEODE-1

Re: Review Request 46706: GEODE-1259: Upgrade gradle version to 2.12

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46706/#review130715 --- Ship it! Ship It! - Mark Bretl On April 26, 2016, 4:12 p.m

Re: Review Request 46399: GEODE-1233: apply FlakyTest category to flickering tests

/gemfire/internal/AvailablePort.java (lines 197 - 200) <https://reviews.apache.org/r/46399/#comment193041> Is this part of GEODE-1233? If it is, then can delete the commented code. - Mark Bretl On April 19, 2016, 11:20 a.m., Kirk Lund

Re: Review Request 46071: GEODE-1213: Disables signing task on geode-modules-assembly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46071/#review128455 --- Ship it! Ship It! - Mark Bretl On April 11, 2016, 10:49 p.m

Re: Geode - Sonar integartion

Hey Nitin, I can help out and I have done Sonar integration in the past with the GemFire build. As I am looking at INFRA-9616, I was unaware there is a separate Jenkins server specifically for running Sonar jobs. I have asked for karma to edit the geode job on the other Jenkins server in that infr

Re: Review Request 45993: GEODE-1201: Adding compileRuntimeLibs to geode-assembly for tests Amending bind address configuration for http-service-bind-address

lib. Also, was precheckin or Travis CI run on this change? It looks like tests not in Geode source were run to verify this change. - Mark Bretl On April 10, 2016, 2:59 p.m., Udo Kohlmeyer wrote: > > --- > This is an auto

Re: Review Request 45827: GEODE-902: Remove incorrect src header; update LICENSE and NOTICE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45827/#review127455 --- Ship it! Ship It! - Mark Bretl On April 6, 2016, 11:07 a.m

Re: Review Request 45509: GEODE-1025: Removing bundled SDG and special handling of spring jars

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45509/#review127346 --- Ship it! Ship It! - Mark Bretl On April 5, 2016, 2:32 p.m

Re: [discuss] Install Google Analytics for tracking activity on geode.incubator.apache.org

+1 --Mark On Tuesday, April 5, 2016, Dan Smith wrote: > +1 > > Sounds like good data to have! > > -Dan > > On Tue, Apr 5, 2016 at 9:27 AM, Jianxia Chen > wrote: > > > +1 > > > > On Fri, Apr 1, 2016 at 10:11 AM, Gregory Chase > wrote: > > > > > Dear Geode contributors, > > > In the community m

Re: Review Request 45509: GEODE-1025: Switching the latest SDG version and reanabling SDG test

code changes - Mark Bretl On March 30, 2016, 4:03 p.m., Dan Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 45497: GEODE-1079: Removing unused dist.gemstone.com repository

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45497/#review126195 --- Ship it! Ship It! - Mark Bretl On March 30, 2016, 10:34 a.m

Re: RestAPIsWithSSLDUnitTest fails

Each version of httpclient has a dependency on a different version of httpcore, hence the reason seeing two versions of httpcore. If the IDEA plugin is not respecting the configuration we have in the Gradle build files, then that is an issue with the IDEA. I found an article from 2013, which dealt

Re: Review Request 45114: GEODE-27: Adding spring-webmvc to pulse

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45114/#review124662 --- Ship it! Ship It! - Mark Bretl On March 21, 2016, 10:46 a.m

Re: Review Request 45116: GEODE-27: Adding spring-expression back in to geode-web

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45116/#review124640 --- Ship it! Ship It! - Mark Bretl On March 21, 2016, 11:07 a.m

Re: Can we close GEODE-36 ? (Gfsh renaming)

+1, Geode Functional Shell --Mark On Wed, Mar 16, 2016 at 9:32 AM, Jens Deppe wrote: > +1 > > On Wed, Mar 16, 2016 at 8:58 AM, Gregory Chase wrote: > > > +1, but only if its "Geode Fab-SHell" > > > > On Wed, Mar 16, 2016 at 8:54 AM, Michael Stolz > wrote: > > > > > +1 > > > Or Geode Fabric SH

Re: Review Request 44877: GEODE-27: Adding a test to verify the bundled jars have not changed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44877/#review124077 --- Ship it! Ship It! - Mark Bretl On March 16, 2016, 2:34 p.m

Re: Review Request 44968: GEODE-27: Further build cleanup - removing some forced dependencies and moving findbugs annotations to geode-core

tps://reviews.apache.org/r/44968/#comment186419> Is there ever a time where a sub-project is not dependent on geode-core and would use the findbugs-annotations? No issue moving it now since we don't have that configuration now, however, might need to move it back later. - Mark Bretl

Re: Review Request 44865: GEODE-27: Enabling transitive dependencie and marking jars as optional in the generated pom

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44865/#review124075 --- Ship it! Ship It! - Mark Bretl On March 15, 2016, 2:43 p.m

Re: Review Request 44865: GEODE-27: Enabling transitive dependencie and marking jars as optional in the generated pom

that right? Feels like if the dependency has the optional property, then add the optional node for the Maven POM. I see this solution in GRADLE-1749 issue, but still doesn't help the black magic :) Does the gradle-extra-configurations-plugin help in this situatio

Re: Review Request 44877: GEODE-27: Adding a test to verify the bundled jars have not changed

, however, I can see this getting out of sync. Myabe that is way it needs to be though. - Mark Bretl On March 15, 2016, 6:23 p.m., Dan Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: New Committer to Apache Geode: Nitin Lamba

Welcome to the Rock, Nitin! --Mark On Tue, Mar 8, 2016 at 4:49 PM, Nitin Lamba wrote: > Thanks everyone! > > Hi Roman, > > My preferred e-mail id is nlamba > > Best, > Nitin > > Sent from Outlook Mobile > > > > > On Tue, Mar 8, 2016 at 4:48 PM -0800, "Anthony Baker"

Re: Review Request 44193: GEODe-562 and changes to clean up some gradle dependencies

per project and it will help clean up our Maven distribution in the long run. - Mark Bretl On Feb. 29, 2016, 4:48 p.m., Jason Huynh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://review

Re: Add labels to create issue dialog in JIRA

Hey Dan, Editing workflows/screens/fields is a JIRA Admin privilege and would need to request INFRA most likely. --Mark On Fri, Feb 26, 2016 at 1:32 PM, Dan Smith wrote: > Does anyone have the karma to modify the create issue dialog for the geode > JIRA? I'd like to be able to fill in labels

Re: Review Request 44036: GEODE-992: Integrate with Travis CI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44036/#review120780 --- Ship it! Ship It! - Mark Bretl On Feb. 25, 2016, 12:10 p.m

Are we still using RTC?

Hi, I have been noticing a few commits lately going directly into develop before getting feedback from their review request on ReviewBoard. If you are going to spend the time creating the Review Request, give people time to review it as a general courtesy. Best Regards, --Mark

Re: Review Request 43786: GEODE-829: pulse gradle uses the dependency versions in the property file

t; '+ project.', for easier reading, however that is personal preference. - Mark Bretl On Feb. 19, 2016, 1:29 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 43750: Ugrade selenium driver for pulse tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43750/#review119905 --- Ship it! Ship It! - Mark Bretl On Feb. 18, 2016, 5:15 p.m

Re: Review Request 43655: Not including gradle generated directories in the source distribution

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43655/#review119546 --- Ship it! Ship It! - Mark Bretl On Feb. 17, 2016, 10:32 a.m

Re: GEODE-52 Remove @author tags from Java source

+1 --Mark On Wed, Feb 17, 2016 at 2:01 PM, Jianxia Chen wrote: > +1 > > On Wed, Feb 17, 2016 at 1:52 PM, William Markito > wrote: > > > +1 > > > > Sent from my iPhone > > > > > On Feb 17, 2016, at 1:44 PM, Kenneth Howe wrote: > > > > > > +1 > > > > > > Ken > > > > > >> On Feb 17, 2016, at 1:3

Re: Review Request 43504: Build updates: version, GEODE 918 / 26

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43504/#review118964 --- Ship it! Ship It! - Mark Bretl On Feb. 11, 2016, 3:27 p.m

Re: Review Request 43364: GEODE-948: gemfire-modules-assembly should not publish a jar artifact

script is a good move. - Mark Bretl On Feb. 9, 2016, 9:21 a.m., Jens Deppe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 43229: Looking for git repository starting from the project directory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43229/#review117921 --- Ship it! Ship It! - Mark Bretl On Feb. 4, 2016, 3:12 p.m

Re: Review Request 42655: GEODE-830: Allow transitive test dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42655/#review117521 --- Ship it! Ship It! - Mark Bretl On Feb. 1, 2016, 10:56 a.m

Re: Build failed in Jenkins: Geode-nightly #359

tlook Mobile<https://aka.ms/qtex0l> > > > > > On Wed, Jan 27, 2016 at 11:01 AM -0800, "Mark Bretl" <mailto:asf.mbr...@gmail.com>> wrote: > > I have cleaned the Jenkins workspace, hope that will clean up the next > build. > > --Mark > > On

Re: [VOTE] RC2: Apache Geode (Incubating) first Milestone release - v1.0.0-incubating.M1

+1 --Mark On Thu, Jan 28, 2016 at 6:40 PM, John Blum wrote: > +1 > > I would also add, in addition to what Dan mentioned, that GEODE-27 get > fixed sooner rather than later. I recently completed the Spring Session > GemFire support and went ahead to add support for Apache Geode as well. I > c

Re: Build failed in Jenkins: Geode-nightly #359

I have cleaned the Jenkins workspace, hope that will clean up the next build. --Mark On Wed, Jan 27, 2016 at 9:55 AM, Dan Smith wrote: > Nitin's exactly right. Can someone with permissions on jenkins fix this? > > We could also considering adding a pre build step that does a git clean. Eg > > #

Re: Review Request 42808: GEODE-859: Modularize build script

. Excellent work. - Mark Bretl On Jan. 26, 2016, 9:54 a.m., Anthony Baker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Please Join us for the Inagural Geode Summit - early bird pricing through Jan 31st!

Hi Greg, I don't see this event on the community site, http://geode.incubator.apache.org/community/#events, would you be able to add it? --Mark On Thu, Jan 14, 2016 at 9:54 AM, Gregory Chase wrote: > Pivotal Software is very excited to host this event for the Apache Geode > (incubating) commun

Re: Review Request 42655: GEODE-830: Allow transitive test dependencies

-versions.properties which are not needed anymore. - Mark Bretl On Jan. 22, 2016, 8:28 a.m., Jens Deppe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 42333: GEODE-781: Update maven publishing to include signatures

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42333/#review114722 --- Ship it! Ship It! - Mark Bretl On Jan. 14, 2016, 5:02 p.m

Re: Review Request 42198: GEODE-775: Generate md5 / sha-256 hashes for the distributions

> On Jan. 12, 2016, 5:32 p.m., Dan Smith wrote: > > Looks pretty good. Rather than invoking gpg from the command line, I think > > it would be better to use the built in gradle signing plugin: > > > > https://docs.gradle.org/current/userguide/signing_plugin.html +1 For using Gradle Signing plu

Re: releaseType?

+1 On Mon, Jan 11, 2016 at 11:13 AM, Jens Deppe wrote: > +1 > > On Mon, Jan 11, 2016 at 11:08 AM, John Blum wrote: > > > +1 > > > > On Mon, Jan 11, 2016 at 10:19 AM, Anthony Baker > wrote: > > > > > Sounds like the consensus is to use the Spring conventions (note that > we > > > can always cha

Re: releaseType?

+1 I agree to follow the Spring model (Mx, RCx, RELEASE), which will be inline with following the Maven publishing guidelines. As for using M1, M2, M3 vs ALPHA, BETA for other Apache projects, I took a quick look and seems to be divided. We haven't released yet, so not too late right? Whatever str

Re: [VOTE] Added specific criteria for nomination and voting for new Committers to Apache Geode wiki

+1 For Dan's updates. I agree #2 does not help with understanding criteria. --Mark On Thu, Jan 7, 2016 at 11:19 AM, Dan Smith wrote: > Looks pretty good to me. I'd suggest a slight edit #3: > > Once a contributor shows a consistent history of participating in the > development process or commun

Re: Ready for release candidate?

I believe we are farther away from the actual '1.0.0' release, so it does not make sense to have the long standing release branch. Since '1.0.0-ALPHA' is the release name, I would expect the branch name to match. This goes for any 'beta', M1, M2, Mx, then final '1.0.0' release branch. Those are my

Re: January 2016 Report

+1. Thanks William! --Mark On Wed, Jan 6, 2016 at 9:26 AM, Dan Smith wrote: > +1 Looks good to me! > > -Dan > > On Wed, Jan 6, 2016 at 9:18 AM, Kirk Lund wrote: > > > +1 looks good. Thanks William! > > > > > > On Wed, Jan 6, 2016 at 8:57 AM, Anthony Baker wrote: > > > > > Thanks William, look

Re: Review Request 41802: GEODE-14: Integration of GemFire Session Replication and Hibernate modules

support information is removed, I am good with merging to develop - Mark Bretl On Jan. 6, 2016, 4:25 p.m., Jens Deppe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 41802: GEODE-14: Integration of GemFire Session Replication and Hibernate modules

> On Jan. 6, 2016, 12:51 a.m., Mark Bretl wrote: > > All the shell/bat scripts need to be updated for the jar file changes. > > > > Build changes look good, however, since all the subprojects are going be > > added, that means every Geode build will build the module

Re: Review Request 41802: GEODE-14: Integration of GemFire Session Replication and Hibernate modules

> On Jan. 6, 2016, 12:51 a.m., Mark Bretl wrote: > > All the shell/bat scripts need to be updated for the jar file changes. > > > > Build changes look good, however, since all the subprojects are going be > > added, that means every Geode build will build the module

Re: Review Request 41802: GEODE-14: Integration of GemFire Session Replication and Hibernate modules

changes. Build changes look good, however, since all the subprojects are going be added, that means every Geode build will build the modules? Not sure if we want to add properties or some other mechansim when we want to build extensions. - Mark Bretl On Dec. 30, 2015, 4:48 p.m., Jens Deppe wrote

Re: [GitHub] incubator-geode pull request: Enabling direct reporting on Geode's...

+1 --Mark On Fri, Jan 1, 2016 at 5:49 AM, Anthony Baker wrote: > +1 > > > On Dec 30, 2015, at 9:10 PM, Roman Shaposhnik > wrote: > > > > On Mon, Dec 28, 2015 at 7:23 PM, William Markito > wrote: > >> +1 > > > > So... shall I commit? ;-) > > > > Thanks, > > Roman. > >

Re: Annoyed with transitive = false for tests

Well, keeping track of the actual dependencies was one of the reasons, however, the main reason was the underlying dependency management done by Gradle (via Maven repositories) had to be 'turned off' due to incompatible versions in other dependencies or their downstream dependencies. There were dep

Re: Jenkins build - stacktrace enabled

Hey Anthony, I have removed the '--stacktrace' flag from the build configuration. --Mark On Fri, Dec 18, 2015 at 9:35 AM, Anthony Baker wrote: > Hi William, could you disable --stacktrace on the build? It’s not giving > us anymore info on the rat failures :( > > Anthony > > > > On Dec 15, 201

  1   2   >