phet commented on code in PR #3940:
URL: https://github.com/apache/gobblin/pull/3940#discussion_r1586825670
##
gobblin-metrics-libs/gobblin-metrics-base/src/main/avro/GaaSObservabilityEvent.avsc:
##
Review Comment:
although we don't expect ever to use
phet commented on code in PR #3940:
URL: https://github.com/apache/gobblin/pull/3940#discussion_r1586825670
##
gobblin-metrics-libs/gobblin-metrics-base/src/main/avro/GaaSObservabilityEvent.avsc:
##
Review Comment:
although we don't expect ever to use
phet commented on code in PR #3940:
URL: https://github.com/apache/gobblin/pull/3940#discussion_r1586785913
##
gobblin-metrics-libs/gobblin-metrics-base/src/main/avro/GaaSObservabilityEvent.avsc:
##
@@ -1,6 +1,6 @@
{
"type": "record",
- "name":
[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917186=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917186
]
ASF GitHub Bot logged work on GOBBLIN-2056:
---
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917185=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917185
]
ASF GitHub Bot logged work on GOBBLIN-2056:
---
Author: ASF GitHub Bot
phet commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586776782
##
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java:
##
@@ -244,9 +250,10 @@ public void createTopologySpec() {
}
phet commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586776782
##
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java:
##
@@ -244,9 +250,10 @@ public void createTopologySpec() {
}
[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917184=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917184
]
ASF GitHub Bot logged work on GOBBLIN-2056:
---
Author: ASF GitHub Bot
arjun4084346 commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586760198
##
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java:
##
@@ -244,9 +250,10 @@ public void createTopologySpec()
Will-Lo opened a new pull request, #3940:
URL: https://github.com/apache/gobblin/pull/3940
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the
[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917174=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917174
]
ASF GitHub Bot logged work on GOBBLIN-2056:
---
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917172=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917172
]
ASF GitHub Bot logged work on GOBBLIN-2056:
---
Author: ASF GitHub Bot
phet commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586737313
##
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/BaseFlowToJobSpecCompiler.java:
##
@@ -219,8 +199,6 @@ private AddSpecResponse
phet commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586737313
##
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/BaseFlowToJobSpecCompiler.java:
##
@@ -219,8 +199,6 @@ private AddSpecResponse
[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917171=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917171
]
ASF GitHub Bot logged work on GOBBLIN-2056:
---
Author: ASF GitHub Bot
phet commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586737313
##
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/BaseFlowToJobSpecCompiler.java:
##
@@ -219,8 +199,6 @@ private AddSpecResponse
[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917168=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917168
]
ASF GitHub Bot logged work on GOBBLIN-2056:
---
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917169=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917169
]
ASF GitHub Bot logged work on GOBBLIN-2056:
---
Author: ASF GitHub Bot
phet commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586730784
##
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java:
##
@@ -244,9 +250,10 @@ public void createTopologySpec() {
}
phet commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586730784
##
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java:
##
@@ -244,9 +250,10 @@ public void createTopologySpec() {
}
[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917166=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917166
]
ASF GitHub Bot logged work on GOBBLIN-2056:
---
Author: ASF GitHub Bot
phet commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586726855
##
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java:
##
@@ -114,6 +119,8 @@ public void setup() throws Exception {
[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917163=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917163
]
ASF GitHub Bot logged work on GOBBLIN-2056:
---
Author: ASF GitHub Bot
arjun4084346 commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586719870
##
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/BaseFlowToJobSpecCompiler.java:
##
@@ -219,8 +199,6 @@ private AddSpecResponse
[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917162=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917162
]
ASF GitHub Bot logged work on GOBBLIN-2056:
---
Author: ASF GitHub Bot
arjun4084346 commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586717102
##
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java:
##
@@ -244,9 +250,10 @@ public void createTopologySpec()
[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917160=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917160
]
ASF GitHub Bot logged work on GOBBLIN-2056:
---
Author: ASF GitHub Bot
arjun4084346 commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586706509
##
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java:
##
@@ -114,6 +119,8 @@ public void setup() throws
[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917157=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917157
]
ASF GitHub Bot logged work on GOBBLIN-2056:
---
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917158=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917158
]
ASF GitHub Bot logged work on GOBBLIN-2056:
---
Author: ASF GitHub Bot
phet commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586649678
##
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java:
##
@@ -244,9 +250,10 @@ public void createTopologySpec() {
}
phet commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586649678
##
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java:
##
@@ -244,9 +250,10 @@ public void createTopologySpec() {
}
phet commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586640513
##
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java:
##
@@ -114,6 +119,8 @@ public void setup() throws Exception {
[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917156=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917156
]
ASF GitHub Bot logged work on GOBBLIN-2056:
---
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917153=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917153
]
ASF GitHub Bot logged work on GOBBLIN-2056:
---
Author: ASF GitHub Bot
arjun4084346 commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586634905
##
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##
@@ -73,12 +74,12 @@ public class
[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917149=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917149
]
ASF GitHub Bot logged work on GOBBLIN-2056:
---
Author: ASF GitHub Bot
umustafi commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586537330
##
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##
@@ -73,12 +74,12 @@ public class
[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917143=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917143
]
ASF GitHub Bot logged work on GOBBLIN-2056:
---
Author: ASF GitHub Bot
umustafi commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586473269
##
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##
@@ -73,12 +74,12 @@ public class
[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917102=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917102
]
ASF GitHub Bot logged work on GOBBLIN-2056:
---
Author: ASF GitHub Bot
arjun4084346 commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1585928924
##
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##
@@ -73,12 +74,12 @@ public class
[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917101=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917101
]
ASF GitHub Bot logged work on GOBBLIN-2056:
---
Author: ASF GitHub Bot
arjun4084346 commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1585928379
##
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/BaseFlowToJobSpecCompiler.java:
##
@@ -97,35 +97,13 @@ public abstract class
44 matches
Mail list logo